Re: [BCEL] Release 6.4.0

[Gary Gregory]

Under target/site

Gary

On Mon, Oct 21, 2019, 11:41 Mark Roberts  wrote:

> To respond to questions about changes to Annotation support, I am trying
> to review the current test coverage.  I ran the command line below.  I see
> a file named jacoco.exec  but that appears to be binary data.  Where do I
> find the code coverage report?
>
>
>
> Thanks,
>
> Mark
>
>
>
> *From:* Gary Gregory [mailto:garydgreg...@gmail.com]
> *Sent:* Friday, September 06, 2019 5:01 PM
> *To:* Mark Roberts; Commons Developers List
> *Subject:* Re: [BCEL] Release 6.4.0
>
>
>
> Run:
>
>
>
> mvn clean site -P jacoco
>
>
>
> Then look at the generate site's JaCoCo report and make sure the new code
> has as close to possible to 100% code coverage by the unit tests.
>
>
>
> The profile might not be required but it will make sure the right thing
> happens.
>
>
>
> Gary
>
>
>
> On Fri, Sep 6, 2019, 19:58 Mark Roberts  wrote:
>
> Sorry - not familiar with the release process.  What does check for code
> coverage mean?
>
> mark
>
> -Original Message-----
> From: Gary Gregory [mailto:garydgreg...@gmail.com]
> Sent: Friday, September 6, 2019 3:09 PM
> To: Commons Developers List 
> Subject: Re: [BCEL] Release 6.4.0
>
> I might have some time over the weekend. Would you mind double checking
> you recent work for code coverage.
>
> Gary
>
> On Fri, Sep 6, 2019, 09:07 Mark Roberts  wrote:
>
> > I'm good.  From our standpoint it would be nice to make a BCEL release
> > so we don't need to include a special version with our tool set.
> >
> > Thanks,
> > Mark
> >
> > -Original Message-
> > From: Gary Gregory [mailto:garydgreg...@gmail.com]
> > Sent: Sunday, September 1, 2019 3:25 PM
> > To: Commons Developers List 
> > Subject: [BCEL] Release 6.4.0
> >
> > Hi All and Mark in particular,
> >
> > Is there anything more we need for 6.4.0?
> >
> > Gary
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >
>
>

RE: [BCEL] Release 6.4.0

[Mark Roberts]

To respond to questions about changes to Annotation support, I am trying to 
review the current test coverage.  I ran the command line below.  I see a file 
named jacoco.exec  but that appears to be binary data.  Where do I find the 
code coverage report?

 

Thanks,

Mark

 

From: Gary Gregory [mailto:garydgreg...@gmail.com] 
Sent: Friday, September 06, 2019 5:01 PM
To: Mark Roberts; Commons Developers List
Subject: Re: [BCEL] Release 6.4.0

 

Run:

 

mvn clean site -P jacoco

 

Then look at the generate site's JaCoCo report and make sure the new code has 
as close to possible to 100% code coverage by the unit tests.

 

The profile might not be required but it will make sure the right thing 
happens. 

 

Gary

 

On Fri, Sep 6, 2019, 19:58 Mark Roberts  wrote:

Sorry - not familiar with the release process.  What does check for code 
coverage mean?

mark

-Original Message-
From: Gary Gregory [mailto:garydgreg...@gmail.com] 
Sent: Friday, September 6, 2019 3:09 PM
To: Commons Developers List 
Subject: Re: [BCEL] Release 6.4.0

I might have some time over the weekend. Would you mind double checking you 
recent work for code coverage.

Gary

On Fri, Sep 6, 2019, 09:07 Mark Roberts  wrote:

> I'm good.  From our standpoint it would be nice to make a BCEL release 
> so we don't need to include a special version with our tool set.
>
> Thanks,
> Mark
>
> -Original Message-
> From: Gary Gregory [mailto:garydgreg...@gmail.com]
> Sent: Sunday, September 1, 2019 3:25 PM
> To: Commons Developers List 
> Subject: [BCEL] Release 6.4.0
>
> Hi All and Mark in particular,
>
> Is there anything more we need for 6.4.0?
>
> Gary
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [BCEL] Release 6.4.0

[Gary Gregory]

On Mon, Sep 9, 2019 at 9:07 AM Mark Roberts 
wrote:

> I don’t need to run jacoco to know the coverage is almost zero for the
> classes added to support the new Java 9+ attributes.  I could cobble
> something up if there was some way to add a Java 11 .class file to use as
> input to a test.
>

You can precompile a Java 11 .class file and put it somewhere in
test/resources like a new dir test/resources/java11

Gary

>
>
> Mark
>
>
>
> *From:* Gary Gregory [mailto:garydgreg...@gmail.com]
> *Sent:* Friday, September 06, 2019 5:01 PM
> *To:* Mark Roberts; Commons Developers List
> *Subject:* Re: [BCEL] Release 6.4.0
>
>
>
> Run:
>
>
>
> mvn clean site -P jacoco
>
>
>
> Then look at the generate site's JaCoCo report and make sure the new code
> has as close to possible to 100% code coverage by the unit tests.
>
>
>
> The profile might not be required but it will make sure the right thing
> happens.
>
>
>
> Gary
>
>
>
> On Fri, Sep 6, 2019, 19:58 Mark Roberts  wrote:
>
> Sorry - not familiar with the release process.  What does check for code
> coverage mean?
>
> mark
>
> -Original Message-
> From: Gary Gregory [mailto:garydgreg...@gmail.com]
> Sent: Friday, September 6, 2019 3:09 PM
> To: Commons Developers List 
> Subject: Re: [BCEL] Release 6.4.0
>
> I might have some time over the weekend. Would you mind double checking
> you recent work for code coverage.
>
> Gary
>
> On Fri, Sep 6, 2019, 09:07 Mark Roberts  wrote:
>
> > I'm good.  From our standpoint it would be nice to make a BCEL release
> > so we don't need to include a special version with our tool set.
> >
> > Thanks,
> > Mark
> >
> > -Original Message-
> > From: Gary Gregory [mailto:garydgreg...@gmail.com]
> > Sent: Sunday, September 1, 2019 3:25 PM
> > To: Commons Developers List 
> > Subject: [BCEL] Release 6.4.0
> >
> > Hi All and Mark in particular,
> >
> > Is there anything more we need for 6.4.0?
> >
> > Gary
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >
>
>

RE: [BCEL] Release 6.4.0

[Mark Roberts]

I don’t need to run jacoco to know the coverage is almost zero for the classes 
added to support the new Java 9+ attributes.  I could cobble something up if 
there was some way to add a Java 11 .class file to use as input to a test.

 

Mark

 

From: Gary Gregory [mailto:garydgreg...@gmail.com] 
Sent: Friday, September 06, 2019 5:01 PM
To: Mark Roberts; Commons Developers List
Subject: Re: [BCEL] Release 6.4.0

 

Run:

 

mvn clean site -P jacoco

 

Then look at the generate site's JaCoCo report and make sure the new code has 
as close to possible to 100% code coverage by the unit tests.

 

The profile might not be required but it will make sure the right thing 
happens. 

 

Gary

 

On Fri, Sep 6, 2019, 19:58 Mark Roberts  wrote:

Sorry - not familiar with the release process.  What does check for code 
coverage mean?

mark

-Original Message-
From: Gary Gregory [mailto:garydgreg...@gmail.com] 
Sent: Friday, September 6, 2019 3:09 PM
To: Commons Developers List 
Subject: Re: [BCEL] Release 6.4.0

I might have some time over the weekend. Would you mind double checking you 
recent work for code coverage.

Gary

On Fri, Sep 6, 2019, 09:07 Mark Roberts  wrote:

> I'm good.  From our standpoint it would be nice to make a BCEL release 
> so we don't need to include a special version with our tool set.
>
> Thanks,
> Mark
>
> -Original Message-
> From: Gary Gregory [mailto:garydgreg...@gmail.com]
> Sent: Sunday, September 1, 2019 3:25 PM
> To: Commons Developers List 
> Subject: [BCEL] Release 6.4.0
>
> Hi All and Mark in particular,
>
> Is there anything more we need for 6.4.0?
>
> Gary
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [BCEL] Release 6.4.0

[Gary Gregory]

Run:

mvn clean site -P jacoco

Then look at the generate site's JaCoCo report and make sure the new code
has as close to possible to 100% code coverage by the unit tests.

The profile might not be required but it will make sure the right thing
happens.

Gary

On Fri, Sep 6, 2019, 19:58 Mark Roberts  wrote:

> Sorry - not familiar with the release process.  What does check for code
> coverage mean?
>
> mark
>
> -Original Message-
> From: Gary Gregory [mailto:garydgreg...@gmail.com]
> Sent: Friday, September 6, 2019 3:09 PM
> To: Commons Developers List 
> Subject: Re: [BCEL] Release 6.4.0
>
> I might have some time over the weekend. Would you mind double checking
> you recent work for code coverage.
>
> Gary
>
> On Fri, Sep 6, 2019, 09:07 Mark Roberts  wrote:
>
> > I'm good.  From our standpoint it would be nice to make a BCEL release
> > so we don't need to include a special version with our tool set.
> >
> > Thanks,
> > Mark
> >
> > -Original Message-
> > From: Gary Gregory [mailto:garydgreg...@gmail.com]
> > Sent: Sunday, September 1, 2019 3:25 PM
> > To: Commons Developers List 
> > Subject: [BCEL] Release 6.4.0
> >
> > Hi All and Mark in particular,
> >
> > Is there anything more we need for 6.4.0?
> >
> > Gary
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >
>
>

Re: [BCEL] Release 6.4.0

[Gary Gregory]

I might have some time over the weekend. Would you mind double checking you
recent work for code coverage.

Gary

On Fri, Sep 6, 2019, 09:07 Mark Roberts  wrote:

> I'm good.  From our standpoint it would be nice to make a BCEL release so
> we don't need to include a special version with our tool set.
>
> Thanks,
> Mark
>
> -Original Message-
> From: Gary Gregory [mailto:garydgreg...@gmail.com]
> Sent: Sunday, September 1, 2019 3:25 PM
> To: Commons Developers List 
> Subject: [BCEL] Release 6.4.0
>
> Hi All and Mark in particular,
>
> Is there anything more we need for 6.4.0?
>
> Gary
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

RE: [BCEL] Release 6.4.0

[Mark Roberts]

I'm good.  From our standpoint it would be nice to make a BCEL release so we 
don't need to include a special version with our tool set.

Thanks,
Mark

-Original Message-
From: Gary Gregory [mailto:garydgreg...@gmail.com] 
Sent: Sunday, September 1, 2019 3:25 PM
To: Commons Developers List 
Subject: [BCEL] Release 6.4.0

Hi All and Mark in particular,

Is there anything more we need for 6.4.0?

Gary


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[BCEL] Release 6.4.0

[Gary Gregory]

Hi All and Mark in particular,

Is there anything more we need for 6.4.0?

Gary

Re: [BCEL] Release

[Gary Gregory]

Thanks Bruno!

Gary

On Wed, Mar 20, 2019 at 10:01 PM Bruno P. Kinoshita
 wrote:

>  +1 Gary. Will make sure to review and vote on the RC as soon as I see it
> coming. Or if I don't vote within the 72hours, feel free to remind me and I
> will quickly do so.
> Cheers
>
> On Thursday, 21 March 2019, 10:33:47 am NZDT, Gary Gregory <
> garydgreg...@gmail.com> wrote:
>
>  Hi All:
>
> I need the fix for BCEL-315 ASAP. I plan on creating on RC later today I
> hope.
>
> Based on changes.xml I think the next version should be 6.3.1 instead of
> 6.4.
>
> Gary
>

Re: [BCEL] Release

[Bruno P. Kinoshita]

 +1 Gary. Will make sure to review and vote on the RC as soon as I see it 
coming. Or if I don't vote within the 72hours, feel free to remind me and I 
will quickly do so.
Cheers

On Thursday, 21 March 2019, 10:33:47 am NZDT, Gary Gregory 
 wrote:  
 
 Hi All:

I need the fix for BCEL-315 ASAP. I plan on creating on RC later today I
hope.

Based on changes.xml I think the next version should be 6.3.1 instead of
6.4.

Gary
  

[BCEL] Release

[Gary Gregory]

Hi All:

I need the fix for BCEL-315 ASAP. I plan on creating on RC later today I
hope.

Based on changes.xml I think the next version should be 6.3.1 instead of
6.4.

Gary

[BCEL] Release?

[Gary Gregory]

Hi All,

A project (spotbugs) is currently depending on a 6.1 SNAPSHOT jar to pick
up a fix.

See https://github.com/spotbugs/spotbugs/pull/69

Does anyone want to volunteer to review BCEL for a 6.1 release?

Gary

-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

RE: How tell which BCEL release?

[Mark Roberts]

Great - thanks for all the suggestions.  I will investigate on Monday.

Mark

> -Original Message-
> From: Gary Gregory [mailto:garydgreg...@gmail.com]
> Sent: Friday, July 08, 2016 4:18 PM
> To: Commons Developers List
> Subject: Re: How tell which BCEL release?
> 
> Accessible from java.lang.Package
> 
> Gary
> 
> On Fri, Jul 8, 2016 at 4:10 PM, sebb <seb...@gmail.com> wrote:
> 
> > The Commons Parent pom includes various items in the jar manifest,
> > including the following:
> >
> > Implementation-Version:
> > Specification-Version:
> >
> > These are both set from project.version.
> >
> >
> >


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: How tell which BCEL release?

[Gary Gregory]

Accessible from java.lang.Package

Gary

On Fri, Jul 8, 2016 at 4:10 PM, sebb <seb...@gmail.com> wrote:

> The Commons Parent pom includes various items in the jar manifest,
> including the following:
>
> Implementation-Version:
> Specification-Version:
>
> These are both set from project.version.
>
>
>
> On 8 July 2016 at 23:49, dbrosIus <dbros...@baybroadband.net> wrote:
> > Typicaly one puts the version in the manifest
> >
> >  Original message 
> > From: Mark Roberts <mar...@cs.washington.edu>
> > Date: 7/8/16  6:43 PM  (GMT-05:00)
> > To: 'Commons Developers List' <dev@commons.apache.org>
> > Subject: How tell which BCEL release?
> >
> > Now that BCEL 6.0 looks close, I'm wondering how a client can tell -
> programmatically - which version of BCEL he is running against in order to
> verify it is correct.   Currently, we at PLSE add an extra, dummy class to
> the release in order to do this.   Our goal is to stop shipping our own
> version and use the official 6.0 release - but we still need a way to
> identify the version.  We could do something hokey like looking for a
> recently added method - but I would prefer something more organized.
> >
> > Any thoughts?
> >
> > Mark
> >
> >
> >> -Original Message-
> >> From: Benedikt Ritter [mailto:brit...@apache.org]
> >> Sent: Thursday, July 07, 2016 11:48 AM
> >> To: Commons Developers List
> >> Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> >>
> >> Thank you Mark, I'll have a look ASAP.
> >>
> >> Mark Roberts <mar...@cs.washington.edu> schrieb am Do., 7. Juli 2016 um
> >> 18:41:
> >>
> >> > Unit test attached to BCEL-262.
> >> >
> >> > Mark
> >> >
> >> > > -Original Message-
> >> > > From: Gary Gregory [mailto:garydgreg...@gmail.com]
> >> > > Sent: Wednesday, July 06, 2016 2:26 PM
> >> > > To: Commons Developers List
> >> > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> >> > >
> >> > > I think we should wait for your unit test before we cut another (and
> >> > final I
> >> > > hope) RC.
> >> > >
> >> > > Gary
> >> > >
> >> > > On Wed, Jul 6, 2016 at 10:51 AM, Mark Roberts
> >> > > <mar...@cs.washington.edu>
> >> > > wrote:
> >> > >
> >> > > > The patch that (was) attached to bcel-262 was correct, it just
> >> > > > looks like it was never applied.  The line numbers are a little
> >> > > > off now so I have just updated the patch - the new version is
> relative to
> >> RC7.
> >> > > >
> >> > > > The example failure shown in the bug report requires running
> >> > > > Daikon to repro.  I will see if I can produce a reduced test case,
> >> > > > but it will take a little time.
> >> > > >
> >> > > > I just noticed that the package coordinates change (from
> >> > > > commons/bcel6 back to bcel) was applied to the trunk as well as
> the RC
> >> candidates.
> >> > > > It this change permanent?  I really don't want to edit my sources
> >> > > > back only to have to change them again at some point in the
> future.
> >> > > >
> >> > > > And here is some good (!) news:  I took the current RC7 sources,
> >> > > > applied my InvokeInstruction patch, built the system, used
> >> > > > shade52.xml to get the correct :-) names and inserted the
> >> > > > resulting bcel.jar into the Daikon system.  It built correctly and
> >> > > > passed all the regression
> >> > tests. Ta-
> >> > > da!
> >> > > >
> >> > > > Thank you,
> >> > > > Mark
> >> > > >
> >> > > > > -Original Message-
> >> > > > > From: Benedikt Ritter [mailto:brit...@apache.org]
> >> > > > > Sent: Wednesday, July 06, 2016 9:47 AM
> >> > > > > To: Commons Developers List
> >> > > > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> >> > > > >
> >> > > > > Gary Gregory <garydgreg...@gmail.com> schrieb am Mi., 6. Juli
> >> > > > > 2016 um
> &

Re: How tell which BCEL release?

[sebb]

The Commons Parent pom includes various items in the jar manifest,
including the following:

Implementation-Version:
Specification-Version:

These are both set from project.version.



On 8 July 2016 at 23:49, dbrosIus <dbros...@baybroadband.net> wrote:
> Typicaly one puts the version in the manifest
>
>  Original message 
> From: Mark Roberts <mar...@cs.washington.edu>
> Date: 7/8/16  6:43 PM  (GMT-05:00)
> To: 'Commons Developers List' <dev@commons.apache.org>
> Subject: How tell which BCEL release?
>
> Now that BCEL 6.0 looks close, I'm wondering how a client can tell - 
> programmatically - which version of BCEL he is running against in order to 
> verify it is correct.   Currently, we at PLSE add an extra, dummy class to 
> the release in order to do this.   Our goal is to stop shipping our own 
> version and use the official 6.0 release - but we still need a way to 
> identify the version.  We could do something hokey like looking for a 
> recently added method - but I would prefer something more organized.
>
> Any thoughts?
>
> Mark
>
>
>> -Original Message-
>> From: Benedikt Ritter [mailto:brit...@apache.org]
>> Sent: Thursday, July 07, 2016 11:48 AM
>> To: Commons Developers List
>> Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
>>
>> Thank you Mark, I'll have a look ASAP.
>>
>> Mark Roberts <mar...@cs.washington.edu> schrieb am Do., 7. Juli 2016 um
>> 18:41:
>>
>> > Unit test attached to BCEL-262.
>> >
>> > Mark
>> >
>> > > -Original Message-
>> > > From: Gary Gregory [mailto:garydgreg...@gmail.com]
>> > > Sent: Wednesday, July 06, 2016 2:26 PM
>> > > To: Commons Developers List
>> > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
>> > >
>> > > I think we should wait for your unit test before we cut another (and
>> > final I
>> > > hope) RC.
>> > >
>> > > Gary
>> > >
>> > > On Wed, Jul 6, 2016 at 10:51 AM, Mark Roberts
>> > > <mar...@cs.washington.edu>
>> > > wrote:
>> > >
>> > > > The patch that (was) attached to bcel-262 was correct, it just
>> > > > looks like it was never applied.  The line numbers are a little
>> > > > off now so I have just updated the patch - the new version is relative 
>> > > > to
>> RC7.
>> > > >
>> > > > The example failure shown in the bug report requires running
>> > > > Daikon to repro.  I will see if I can produce a reduced test case,
>> > > > but it will take a little time.
>> > > >
>> > > > I just noticed that the package coordinates change (from
>> > > > commons/bcel6 back to bcel) was applied to the trunk as well as the RC
>> candidates.
>> > > > It this change permanent?  I really don't want to edit my sources
>> > > > back only to have to change them again at some point in the future.
>> > > >
>> > > > And here is some good (!) news:  I took the current RC7 sources,
>> > > > applied my InvokeInstruction patch, built the system, used
>> > > > shade52.xml to get the correct :-) names and inserted the
>> > > > resulting bcel.jar into the Daikon system.  It built correctly and
>> > > > passed all the regression
>> > tests. Ta-
>> > > da!
>> > > >
>> > > > Thank you,
>> > > > Mark
>> > > >
>> > > > > -Original Message-
>> > > > > From: Benedikt Ritter [mailto:brit...@apache.org]
>> > > > > Sent: Wednesday, July 06, 2016 9:47 AM
>> > > > > To: Commons Developers List
>> > > > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
>> > > > >
>> > > > > Gary Gregory <garydgreg...@gmail.com> schrieb am Mi., 6. Juli
>> > > > > 2016 um
>> > > > > 18:37 Uhr:
>> > > > >
>> > > > > > Can you craft a unit test that makes sure the proper behavior
>> > > > > > is in
>> > > > place?
>> > > > > >
>> > > > >
>> > > > > That would be awesome. Furthermore you will have to attach the
>> > > > > patch to jira or create a GitHub PR, since the ML moes not allow
>> > > > > file
>> > > attachments.
>> &

RE: How tell which BCEL release?

[Gary Gregory]

Yes, the manifest. Or you can do a
class.getPackage().getImplementationVersion() IIRC.

Gary
On Jul 8, 2016 3:49 PM, "dbrosIus" <dbros...@baybroadband.net> wrote:

> Typicaly one puts the version in the manifest
>
>  Original message 
> From: Mark Roberts <mar...@cs.washington.edu>
> Date: 7/8/16  6:43 PM  (GMT-05:00)
> To: 'Commons Developers List' <dev@commons.apache.org>
> Subject: How tell which BCEL release?
>
> Now that BCEL 6.0 looks close, I'm wondering how a client can tell -
> programmatically - which version of BCEL he is running against in order to
> verify it is correct.   Currently, we at PLSE add an extra, dummy class to
> the release in order to do this.   Our goal is to stop shipping our own
> version and use the official 6.0 release - but we still need a way to
> identify the version.  We could do something hokey like looking for a
> recently added method - but I would prefer something more organized.
>
> Any thoughts?
>
> Mark
>
>
> > -Original Message-
> > From: Benedikt Ritter [mailto:brit...@apache.org]
> > Sent: Thursday, July 07, 2016 11:48 AM
> > To: Commons Developers List
> > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> >
> > Thank you Mark, I'll have a look ASAP.
> >
> > Mark Roberts <mar...@cs.washington.edu> schrieb am Do., 7. Juli 2016 um
> > 18:41:
> >
> > > Unit test attached to BCEL-262.
> > >
> > > Mark
> > >
> > > > -Original Message-
> > > > From: Gary Gregory [mailto:garydgreg...@gmail.com]
> > > > Sent: Wednesday, July 06, 2016 2:26 PM
> > > > To: Commons Developers List
> > > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> > > >
> > > > I think we should wait for your unit test before we cut another (and
> > > final I
> > > > hope) RC.
> > > >
> > > > Gary
> > > >
> > > > On Wed, Jul 6, 2016 at 10:51 AM, Mark Roberts
> > > > <mar...@cs.washington.edu>
> > > > wrote:
> > > >
> > > > > The patch that (was) attached to bcel-262 was correct, it just
> > > > > looks like it was never applied.  The line numbers are a little
> > > > > off now so I have just updated the patch - the new version is
> relative to
> > RC7.
> > > > >
> > > > > The example failure shown in the bug report requires running
> > > > > Daikon to repro.  I will see if I can produce a reduced test case,
> > > > > but it will take a little time.
> > > > >
> > > > > I just noticed that the package coordinates change (from
> > > > > commons/bcel6 back to bcel) was applied to the trunk as well as
> the RC
> > candidates.
> > > > > It this change permanent?  I really don't want to edit my sources
> > > > > back only to have to change them again at some point in the future.
> > > > >
> > > > > And here is some good (!) news:  I took the current RC7 sources,
> > > > > applied my InvokeInstruction patch, built the system, used
> > > > > shade52.xml to get the correct :-) names and inserted the
> > > > > resulting bcel.jar into the Daikon system.  It built correctly and
> > > > > passed all the regression
> > > tests. Ta-
> > > > da!
> > > > >
> > > > > Thank you,
> > > > > Mark
> > > > >
> > > > > > -Original Message-
> > > > > > From: Benedikt Ritter [mailto:brit...@apache.org]
> > > > > > Sent: Wednesday, July 06, 2016 9:47 AM
> > > > > > To: Commons Developers List
> > > > > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> > > > > >
> > > > > > Gary Gregory <garydgreg...@gmail.com> schrieb am Mi., 6. Juli
> > > > > > 2016 um
> > > > > > 18:37 Uhr:
> > > > > >
> > > > > > > Can you craft a unit test that makes sure the proper behavior
> > > > > > > is in
> > > > > place?
> > > > > > >
> > > > > >
> > > > > > That would be awesome. Furthermore you will have to attach the
> > > > > > patch to jira or create a GitHub PR, since the ML moes not allow
> > > > > > file
> > > > attachments.
> > >

RE: How tell which BCEL release?

[dbrosIus]

Typicaly one puts the version in the manifest

 Original message 
From: Mark Roberts <mar...@cs.washington.edu> 
Date: 7/8/16  6:43 PM  (GMT-05:00) 
To: 'Commons Developers List' <dev@commons.apache.org> 
Subject: How tell which BCEL release? 

Now that BCEL 6.0 looks close, I'm wondering how a client can tell - 
programmatically - which version of BCEL he is running against in order to 
verify it is correct.   Currently, we at PLSE add an extra, dummy class to the 
release in order to do this.   Our goal is to stop shipping our own version and 
use the official 6.0 release - but we still need a way to identify the version. 
 We could do something hokey like looking for a recently added method - but I 
would prefer something more organized. 

Any thoughts?

Mark


> -Original Message-
> From: Benedikt Ritter [mailto:brit...@apache.org]
> Sent: Thursday, July 07, 2016 11:48 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> 
> Thank you Mark, I'll have a look ASAP.
> 
> Mark Roberts <mar...@cs.washington.edu> schrieb am Do., 7. Juli 2016 um
> 18:41:
> 
> > Unit test attached to BCEL-262.
> >
> > Mark
> >
> > > -Original Message-
> > > From: Gary Gregory [mailto:garydgreg...@gmail.com]
> > > Sent: Wednesday, July 06, 2016 2:26 PM
> > > To: Commons Developers List
> > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> > >
> > > I think we should wait for your unit test before we cut another (and
> > final I
> > > hope) RC.
> > >
> > > Gary
> > >
> > > On Wed, Jul 6, 2016 at 10:51 AM, Mark Roberts
> > > <mar...@cs.washington.edu>
> > > wrote:
> > >
> > > > The patch that (was) attached to bcel-262 was correct, it just
> > > > looks like it was never applied.  The line numbers are a little
> > > > off now so I have just updated the patch - the new version is relative 
> > > > to
> RC7.
> > > >
> > > > The example failure shown in the bug report requires running
> > > > Daikon to repro.  I will see if I can produce a reduced test case,
> > > > but it will take a little time.
> > > >
> > > > I just noticed that the package coordinates change (from
> > > > commons/bcel6 back to bcel) was applied to the trunk as well as the RC
> candidates.
> > > > It this change permanent?  I really don't want to edit my sources
> > > > back only to have to change them again at some point in the future.
> > > >
> > > > And here is some good (!) news:  I took the current RC7 sources,
> > > > applied my InvokeInstruction patch, built the system, used
> > > > shade52.xml to get the correct :-) names and inserted the
> > > > resulting bcel.jar into the Daikon system.  It built correctly and
> > > > passed all the regression
> > tests. Ta-
> > > da!
> > > >
> > > > Thank you,
> > > > Mark
> > > >
> > > > > -Original Message-
> > > > > From: Benedikt Ritter [mailto:brit...@apache.org]
> > > > > Sent: Wednesday, July 06, 2016 9:47 AM
> > > > > To: Commons Developers List
> > > > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> > > > >
> > > > > Gary Gregory <garydgreg...@gmail.com> schrieb am Mi., 6. Juli
> > > > > 2016 um
> > > > > 18:37 Uhr:
> > > > >
> > > > > > Can you craft a unit test that makes sure the proper behavior
> > > > > > is in
> > > > place?
> > > > > >
> > > > >
> > > > > That would be awesome. Furthermore you will have to attach the
> > > > > patch to jira or create a GitHub PR, since the ML moes not allow
> > > > > file
> > > attachments.
> > > > >
> > > > > Benedikt
> > > > >
> > > > >
> > > > > > Gary
> > > > > >
> > > > > > On Wed, Jul 6, 2016 at 9:16 AM, Mark Roberts
> > > > > > <mar...@cs.washington.edu>
> > > > > > wrote:
> > > > > >
> > > > > > > Hmm - now I'm thinking the code for InvokeInstruction is not
> > correct.
> > > > > > The
> > > > > > > override method getClassName was added, but my patch was not
> > > > > applied
> > >

How tell which BCEL release?

[Mark Roberts]

Now that BCEL 6.0 looks close, I'm wondering how a client can tell - 
programmatically - which version of BCEL he is running against in order to 
verify it is correct.   Currently, we at PLSE add an extra, dummy class to the 
release in order to do this.   Our goal is to stop shipping our own version and 
use the official 6.0 release - but we still need a way to identify the version. 
 We could do something hokey like looking for a recently added method - but I 
would prefer something more organized. 

Any thoughts?

Mark


> -Original Message-
> From: Benedikt Ritter [mailto:brit...@apache.org]
> Sent: Thursday, July 07, 2016 11:48 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> 
> Thank you Mark, I'll have a look ASAP.
> 
> Mark Roberts  schrieb am Do., 7. Juli 2016 um
> 18:41:
> 
> > Unit test attached to BCEL-262.
> >
> > Mark
> >
> > > -Original Message-
> > > From: Gary Gregory [mailto:garydgreg...@gmail.com]
> > > Sent: Wednesday, July 06, 2016 2:26 PM
> > > To: Commons Developers List
> > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> > >
> > > I think we should wait for your unit test before we cut another (and
> > final I
> > > hope) RC.
> > >
> > > Gary
> > >
> > > On Wed, Jul 6, 2016 at 10:51 AM, Mark Roberts
> > > 
> > > wrote:
> > >
> > > > The patch that (was) attached to bcel-262 was correct, it just
> > > > looks like it was never applied.  The line numbers are a little
> > > > off now so I have just updated the patch - the new version is relative 
> > > > to
> RC7.
> > > >
> > > > The example failure shown in the bug report requires running
> > > > Daikon to repro.  I will see if I can produce a reduced test case,
> > > > but it will take a little time.
> > > >
> > > > I just noticed that the package coordinates change (from
> > > > commons/bcel6 back to bcel) was applied to the trunk as well as the RC
> candidates.
> > > > It this change permanent?  I really don't want to edit my sources
> > > > back only to have to change them again at some point in the future.
> > > >
> > > > And here is some good (!) news:  I took the current RC7 sources,
> > > > applied my InvokeInstruction patch, built the system, used
> > > > shade52.xml to get the correct :-) names and inserted the
> > > > resulting bcel.jar into the Daikon system.  It built correctly and
> > > > passed all the regression
> > tests. Ta-
> > > da!
> > > >
> > > > Thank you,
> > > > Mark
> > > >
> > > > > -Original Message-
> > > > > From: Benedikt Ritter [mailto:brit...@apache.org]
> > > > > Sent: Wednesday, July 06, 2016 9:47 AM
> > > > > To: Commons Developers List
> > > > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> > > > >
> > > > > Gary Gregory  schrieb am Mi., 6. Juli
> > > > > 2016 um
> > > > > 18:37 Uhr:
> > > > >
> > > > > > Can you craft a unit test that makes sure the proper behavior
> > > > > > is in
> > > > place?
> > > > > >
> > > > >
> > > > > That would be awesome. Furthermore you will have to attach the
> > > > > patch to jira or create a GitHub PR, since the ML moes not allow
> > > > > file
> > > attachments.
> > > > >
> > > > > Benedikt
> > > > >
> > > > >
> > > > > > Gary
> > > > > >
> > > > > > On Wed, Jul 6, 2016 at 9:16 AM, Mark Roberts
> > > > > > 
> > > > > > wrote:
> > > > > >
> > > > > > > Hmm - now I'm thinking the code for InvokeInstruction is not
> > correct.
> > > > > > The
> > > > > > > override method getClassName was added, but my patch was not
> > > > > applied
> > > > > > > to
> > > > > > the
> > > > > > > added code.  I have attached the diff.
> > > > > > >
> > > > > > > Sorry for not catching this the first time.
> > > > > > >
> > > > > > > Thank you,
> > > > > > > Mark
> > > > > > >
> > > > > > >
> > > > > > > > -Original Message-
> > > > > > > > From: Mark Roberts [mailto:mar...@cs.washington.edu]
> > > > > > > > Sent: Wednesday, July 06, 2016 6:57 AM
> > > > > > > > To: 'Commons Developers List'
> > > > > > > > Subject: RE: [VOTE] Release Apache Commons BCEL 6.0 based
> > > > > > > > on
> > > > > > > > RC7
> > > > > > > >
> > > > > > > > The RELEASE-NOTES.txt entry for BCEL-262 is incorrect.  It
> > > > > > > > should be
> > > > > > > exactly
> > > > > > > > the opposite.  The override was added to InvokeInstruction
> > > > > > > > because an
> > > > > > > array
> > > > > > > > IS a legal operand.  The code is correct, the throw has
> > > > > > > > been
> > > > removed.
> > > > > > > >
> > > > > > > > Mark
> > > > > > > >
> > > > > > > > > -Original Message-
> > > > > > > > > From: Benedikt Ritter [mailto:brit...@apache.org]
> > > > > > > > > Sent: Tuesday, July 05, 2016 2:17 AM
> > > > > > > > > To: Commons Developers List
> > > > > > > > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0
> > > > > > > > > based on
> > > > > > > > > RC7
> > > > > > 

RE: [BCEL] Release Candidate on Thursday

[Mark Roberts]

I think sebb already took care of these two issues.

> -Original Message-
> From: Benedikt Ritter [mailto:benerit...@gmail.com]
> Sent: Friday, June 17, 2016 9:50 AM
> To: Commons Developers List
> Subject: Re: [BCEL] Release Candidate on Thursday
> 
> Hello Mark,
> 
> Mark Roberts <mar...@cs.washington.edu> schrieb am Di., 14. Juni 2016 um
> 18:31 Uhr:
> 
> > People, please look at the data base before you post.   There has been a
> > fix available since August of last year.   (Shortly before the last effort
> > to produce a 6.0 pooped out.)  There is also a test case that
> > demonstrates the problem.
> >
> 
> Thank you for pointing this out. I understand your frustration since your 
> work seems
> to be blocked because of BCEL.
> However your mail came along a bit aggressively. I've just jumped into the
> development of BCEL because I want to help. This is the reason I may not have
> complete overview over the project. Part of our release process is to go 
> through all
> the issues targeting upcoming release and apply available fixes. I will have 
> a look at
> BCEL-243 and BCEL-195.
> 
> I did not manage to create RC1 yesterday. I hope to have more time this 
> weekend.
> 
> Best regards, and again thank you for your help and your patience.
> Benedikt
> 
> 
> >
> > > -Original Message-
> > > From: Andrey Loskutov [mailto:losku...@gmx.de]
> > > Sent: Tuesday, June 14, 2016 9:27 AM
> > > To: Commons Developers List; Mark Roberts; 'Commons Developers List'
> > > Subject: RE: [BCEL] Release Candidate on Thursday
> > >
> > > 1) You mentioned "private Daikon" build. Can you propose a patch?
> > > 2) The bcel-243 reads as an enhancement (some functionality from 1.8
> > > is missing). Is this true? Are there any regressions or any errors
> > > which
> > can be
> > > demonstrated with current trunk state? It would be nice to add this
> > > info
> > to
> > > Jira task.
> > >
> > >
> > > Am 14. Juni 2016 18:04:24 MESZ, schrieb Mark Roberts
> > > <mar...@cs.washington.edu>:
> > > >243 is a show stopper for Daikon.  It will continue to be shipped
> > > >with our private version of BCEL if it is not fixed.
> > > >
> > > >> -Original Message-
> > > >> From: James Carman [mailto:ja...@carmanconsulting.com]
> > > >> Sent: Tuesday, June 14, 2016 8:51 AM
> > > >> To: Commons Developers List
> > > >> Subject: Re: [BCEL] Release Candidate on Thursday
> > > >>
> > > >> Are they show stoppers?
> > > >>
> > > >> On Tue, Jun 14, 2016 at 11:50 AM Mark Roberts
> > > >> <mar...@cs.washington.edu>
> > > >> wrote:
> > > >>
> > > >> > I can tell you right now I would vote -1 as you have not picked
> > > >> > up
> > > >the
> > > >> > fix for https://issues.apache.org/jira/browse/BCEL-243.
> > > >> >
> > > >> > Also, I think https://issues.apache.org/jira/browse/BCEL-195 is
> > > >fixed,
> > > >> > but has not been closed.
> > > >> >
> > > >> >
> > > >> > Thank you,
> > > >> > Mark Roberts
> > > >> >
> > > >> > > -Original Message-
> > > >> > > From: Benedikt Ritter [mailto:brit...@apache.org]
> > > >> > > Sent: Monday, June 13, 2016 11:49 PM
> > > >> > > To: Commons Developers List
> > > >> > > Subject: [BCEL] Release Candidate on Thursday
> > > >> > >
> > > >> > > Hi,
> > > >> > >
> > > >> > > I'm going to try to create an RC for BCEL 6.0 on friday.
> > > >> > > Please
> > > >have
> > > >> > > a
> > > >> > look at
> > > >> > > the current state of the code base and report any issues you see.
> > > >> > >
> > > >> > > Thank you!
> > > >> > > Benedikt
> > > >> >
> > > >> >
> > > >> >
> > > >---
> > > >--
> > > >> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > >> > For additional commands, e-mail: dev-h...@commons.apache.org
> > > >> >
> > > >> >
> > > >
> > > >
> > > >---
> > > >-- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > >For additional commands, e-mail: dev-h...@commons.apache.org
> > >
> > > --
> > > Kind regards,
> > > Andrey Loskutov
> > >
> > > http://google.com/+AndreyLoskutov
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [BCEL] Release Candidate on Thursday

[Benedikt Ritter]

Hello Mark,

Mark Roberts <mar...@cs.washington.edu> schrieb am Di., 14. Juni 2016 um
18:31 Uhr:

> People, please look at the data base before you post.   There has been a
> fix available since August of last year.   (Shortly before the last effort
> to produce a 6.0 pooped out.)  There is also a test case that demonstrates
> the problem.
>

Thank you for pointing this out. I understand your frustration since your
work seems to be blocked because of BCEL.
However your mail came along a bit aggressively. I've just jumped into the
development of BCEL because I want to help. This is the reason I may not
have complete overview over the project. Part of our release process is to
go through all the issues targeting upcoming release and apply available
fixes. I will have a look at BCEL-243 and BCEL-195.

I did not manage to create RC1 yesterday. I hope to have more time this
weekend.

Best regards, and again thank you for your help and your patience.
Benedikt


>
> > -Original Message-
> > From: Andrey Loskutov [mailto:losku...@gmx.de]
> > Sent: Tuesday, June 14, 2016 9:27 AM
> > To: Commons Developers List; Mark Roberts; 'Commons Developers List'
> > Subject: RE: [BCEL] Release Candidate on Thursday
> >
> > 1) You mentioned "private Daikon" build. Can you propose a patch?
> > 2) The bcel-243 reads as an enhancement (some functionality from 1.8 is
> > missing). Is this true? Are there any regressions or any errors which
> can be
> > demonstrated with current trunk state? It would be nice to add this info
> to
> > Jira task.
> >
> >
> > Am 14. Juni 2016 18:04:24 MESZ, schrieb Mark Roberts
> > <mar...@cs.washington.edu>:
> > >243 is a show stopper for Daikon.  It will continue to be shipped with
> > >our private version of BCEL if it is not fixed.
> > >
> > >> -Original Message-
> > >> From: James Carman [mailto:ja...@carmanconsulting.com]
> > >> Sent: Tuesday, June 14, 2016 8:51 AM
> > >> To: Commons Developers List
> > >> Subject: Re: [BCEL] Release Candidate on Thursday
> > >>
> > >> Are they show stoppers?
> > >>
> > >> On Tue, Jun 14, 2016 at 11:50 AM Mark Roberts
> > >> <mar...@cs.washington.edu>
> > >> wrote:
> > >>
> > >> > I can tell you right now I would vote -1 as you have not picked up
> > >the
> > >> > fix for https://issues.apache.org/jira/browse/BCEL-243.
> > >> >
> > >> > Also, I think https://issues.apache.org/jira/browse/BCEL-195 is
> > >fixed,
> > >> > but has not been closed.
> > >> >
> > >> >
> > >> > Thank you,
> > >> > Mark Roberts
> > >> >
> > >> > > -Original Message-
> > >> > > From: Benedikt Ritter [mailto:brit...@apache.org]
> > >> > > Sent: Monday, June 13, 2016 11:49 PM
> > >> > > To: Commons Developers List
> > >> > > Subject: [BCEL] Release Candidate on Thursday
> > >> > >
> > >> > > Hi,
> > >> > >
> > >> > > I'm going to try to create an RC for BCEL 6.0 on friday. Please
> > >have
> > >> > > a
> > >> > look at
> > >> > > the current state of the code base and report any issues you see.
> > >> > >
> > >> > > Thank you!
> > >> > > Benedikt
> > >> >
> > >> >
> > >> >
> > >-
> > >> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > >> > For additional commands, e-mail: dev-h...@commons.apache.org
> > >> >
> > >> >
> > >
> > >
> > >-
> > >To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > >For additional commands, e-mail: dev-h...@commons.apache.org
> >
> > --
> > Kind regards,
> > Andrey Loskutov
> >
> > http://google.com/+AndreyLoskutov
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

RE: [BCEL] Release Candidate on Thursday

[Mark Roberts]

People, please look at the data base before you post.   There has been a fix 
available since August of last year.   (Shortly before the last effort to 
produce a 6.0 pooped out.)  There is also a test case that demonstrates the 
problem.

> -Original Message-
> From: Andrey Loskutov [mailto:losku...@gmx.de]
> Sent: Tuesday, June 14, 2016 9:27 AM
> To: Commons Developers List; Mark Roberts; 'Commons Developers List'
> Subject: RE: [BCEL] Release Candidate on Thursday
> 
> 1) You mentioned "private Daikon" build. Can you propose a patch?
> 2) The bcel-243 reads as an enhancement (some functionality from 1.8 is
> missing). Is this true? Are there any regressions or any errors which can be
> demonstrated with current trunk state? It would be nice to add this info to
> Jira task.
> 
> 
> Am 14. Juni 2016 18:04:24 MESZ, schrieb Mark Roberts
> <mar...@cs.washington.edu>:
> >243 is a show stopper for Daikon.  It will continue to be shipped with
> >our private version of BCEL if it is not fixed.
> >
> >> -Original Message-
> >> From: James Carman [mailto:ja...@carmanconsulting.com]
> >> Sent: Tuesday, June 14, 2016 8:51 AM
> >> To: Commons Developers List
> >> Subject: Re: [BCEL] Release Candidate on Thursday
> >>
> >> Are they show stoppers?
> >>
> >> On Tue, Jun 14, 2016 at 11:50 AM Mark Roberts
> >> <mar...@cs.washington.edu>
> >> wrote:
> >>
> >> > I can tell you right now I would vote -1 as you have not picked up
> >the
> >> > fix for https://issues.apache.org/jira/browse/BCEL-243.
> >> >
> >> > Also, I think https://issues.apache.org/jira/browse/BCEL-195 is
> >fixed,
> >> > but has not been closed.
> >> >
> >> >
> >> > Thank you,
> >> > Mark Roberts
> >> >
> >> > > -Original Message-
> >> > > From: Benedikt Ritter [mailto:brit...@apache.org]
> >> > > Sent: Monday, June 13, 2016 11:49 PM
> >> > > To: Commons Developers List
> >> > > Subject: [BCEL] Release Candidate on Thursday
> >> > >
> >> > > Hi,
> >> > >
> >> > > I'm going to try to create an RC for BCEL 6.0 on friday. Please
> >have
> >> > > a
> >> > look at
> >> > > the current state of the code base and report any issues you see.
> >> > >
> >> > > Thank you!
> >> > > Benedikt
> >> >
> >> >
> >> >
> >-
> >> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >> > For additional commands, e-mail: dev-h...@commons.apache.org
> >> >
> >> >
> >
> >
> >-
> >To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >For additional commands, e-mail: dev-h...@commons.apache.org
> 
> --
> Kind regards,
> Andrey Loskutov
> 
> http://google.com/+AndreyLoskutov


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

RE: [BCEL] Release Candidate on Thursday

[Andrey Loskutov]

1) You mentioned "private Daikon" build. Can you propose a patch?
2) The bcel-243 reads as an enhancement (some functionality from 1.8 is 
missing). Is this true? Are there any regressions or any errors which can be 
demonstrated with current trunk state? It would be nice to add this info to 
Jira task. 


Am 14. Juni 2016 18:04:24 MESZ, schrieb Mark Roberts <mar...@cs.washington.edu>:
>243 is a show stopper for Daikon.  It will continue to be shipped with
>our private version of BCEL if it is not fixed.
>
>> -Original Message-
>> From: James Carman [mailto:ja...@carmanconsulting.com]
>> Sent: Tuesday, June 14, 2016 8:51 AM
>> To: Commons Developers List
>> Subject: Re: [BCEL] Release Candidate on Thursday
>> 
>> Are they show stoppers?
>> 
>> On Tue, Jun 14, 2016 at 11:50 AM Mark Roberts
>> <mar...@cs.washington.edu>
>> wrote:
>> 
>> > I can tell you right now I would vote -1 as you have not picked up
>the
>> > fix for https://issues.apache.org/jira/browse/BCEL-243.
>> >
>> > Also, I think https://issues.apache.org/jira/browse/BCEL-195 is
>fixed,
>> > but has not been closed.
>> >
>> >
>> > Thank you,
>> > Mark Roberts
>> >
>> > > -Original Message-
>> > > From: Benedikt Ritter [mailto:brit...@apache.org]
>> > > Sent: Monday, June 13, 2016 11:49 PM
>> > > To: Commons Developers List
>> > > Subject: [BCEL] Release Candidate on Thursday
>> > >
>> > > Hi,
>> > >
>> > > I'm going to try to create an RC for BCEL 6.0 on friday. Please
>have
>> > > a
>> > look at
>> > > the current state of the code base and report any issues you see.
>> > >
>> > > Thank you!
>> > > Benedikt
>> >
>> >
>> >
>-
>> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> > For additional commands, e-mail: dev-h...@commons.apache.org
>> >
>> >
>
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>For additional commands, e-mail: dev-h...@commons.apache.org

--
Kind regards,
Andrey Loskutov

http://google.com/+AndreyLoskutov

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [BCEL] Release Candidate on Thursday

[James Carman]

Is it not a showstopper for BCEL itself, though. Do we have a solution to
these two issues readily available? Is it something that we need to noodle
about for a little while and maybe we can just get a release out while we
do that?

On Tue, Jun 14, 2016 at 12:04 PM Mark Roberts <mar...@cs.washington.edu>
wrote:

> 243 is a show stopper for Daikon.  It will continue to be shipped with our
> private version of BCEL if it is not fixed.
>
> > -Original Message-
> > From: James Carman [mailto:ja...@carmanconsulting.com]
> > Sent: Tuesday, June 14, 2016 8:51 AM
> > To: Commons Developers List
> > Subject: Re: [BCEL] Release Candidate on Thursday
> >
> > Are they show stoppers?
> >
> > On Tue, Jun 14, 2016 at 11:50 AM Mark Roberts
> > <mar...@cs.washington.edu>
> > wrote:
> >
> > > I can tell you right now I would vote -1 as you have not picked up the
> > > fix for https://issues.apache.org/jira/browse/BCEL-243.
> > >
> > > Also, I think https://issues.apache.org/jira/browse/BCEL-195 is fixed,
> > > but has not been closed.
> > >
> > >
> > > Thank you,
> > > Mark Roberts
> > >
> > > > -----Original Message-
> > > > From: Benedikt Ritter [mailto:brit...@apache.org]
> > > > Sent: Monday, June 13, 2016 11:49 PM
> > > > To: Commons Developers List
> > > > Subject: [BCEL] Release Candidate on Thursday
> > > >
> > > > Hi,
> > > >
> > > > I'm going to try to create an RC for BCEL 6.0 on friday. Please have
> > > > a
> > > look at
> > > > the current state of the code base and report any issues you see.
> > > >
> > > > Thank you!
> > > > Benedikt
> > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > For additional commands, e-mail: dev-h...@commons.apache.org
> > >
> > >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

RE: [BCEL] Release Candidate on Thursday

[Mark Roberts]

243 is a show stopper for Daikon.  It will continue to be shipped with our 
private version of BCEL if it is not fixed.

> -Original Message-
> From: James Carman [mailto:ja...@carmanconsulting.com]
> Sent: Tuesday, June 14, 2016 8:51 AM
> To: Commons Developers List
> Subject: Re: [BCEL] Release Candidate on Thursday
> 
> Are they show stoppers?
> 
> On Tue, Jun 14, 2016 at 11:50 AM Mark Roberts
> <mar...@cs.washington.edu>
> wrote:
> 
> > I can tell you right now I would vote -1 as you have not picked up the
> > fix for https://issues.apache.org/jira/browse/BCEL-243.
> >
> > Also, I think https://issues.apache.org/jira/browse/BCEL-195 is fixed,
> > but has not been closed.
> >
> >
> > Thank you,
> > Mark Roberts
> >
> > > -Original Message-
> > > From: Benedikt Ritter [mailto:brit...@apache.org]
> > > Sent: Monday, June 13, 2016 11:49 PM
> > > To: Commons Developers List
> > > Subject: [BCEL] Release Candidate on Thursday
> > >
> > > Hi,
> > >
> > > I'm going to try to create an RC for BCEL 6.0 on friday. Please have
> > > a
> > look at
> > > the current state of the code base and report any issues you see.
> > >
> > > Thank you!
> > > Benedikt
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [BCEL] Release Candidate on Thursday

[Benedikt Ritter]

Hello Mark,

thank you for pointing this out. Saves me a lot of time :-)
I will have a look when Jira is reachable again.

Benedikt

Mark Roberts <mar...@cs.washington.edu> schrieb am Di., 14. Juni 2016 um
17:50:

> I can tell you right now I would vote -1 as you have not picked up the fix
> for https://issues.apache.org/jira/browse/BCEL-243.
>
> Also, I think https://issues.apache.org/jira/browse/BCEL-195 is fixed,
> but has not been closed.
>
>
> Thank you,
> Mark Roberts
>
> > -Original Message-
> > From: Benedikt Ritter [mailto:brit...@apache.org]
> > Sent: Monday, June 13, 2016 11:49 PM
> > To: Commons Developers List
> > Subject: [BCEL] Release Candidate on Thursday
> >
> > Hi,
> >
> > I'm going to try to create an RC for BCEL 6.0 on friday. Please have a
> look at
> > the current state of the code base and report any issues you see.
> >
> > Thank you!
> > Benedikt
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [BCEL] Release Candidate on Thursday

[James Carman]

Are they show stoppers?

On Tue, Jun 14, 2016 at 11:50 AM Mark Roberts <mar...@cs.washington.edu>
wrote:

> I can tell you right now I would vote -1 as you have not picked up the fix
> for https://issues.apache.org/jira/browse/BCEL-243.
>
> Also, I think https://issues.apache.org/jira/browse/BCEL-195 is fixed,
> but has not been closed.
>
>
> Thank you,
> Mark Roberts
>
> > -Original Message-
> > From: Benedikt Ritter [mailto:brit...@apache.org]
> > Sent: Monday, June 13, 2016 11:49 PM
> > To: Commons Developers List
> > Subject: [BCEL] Release Candidate on Thursday
> >
> > Hi,
> >
> > I'm going to try to create an RC for BCEL 6.0 on friday. Please have a
> look at
> > the current state of the code base and report any issues you see.
> >
> > Thank you!
> > Benedikt
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

RE: [BCEL] Release Candidate on Thursday

[Mark Roberts]

I can tell you right now I would vote -1 as you have not picked up the fix for 
https://issues.apache.org/jira/browse/BCEL-243.

Also, I think https://issues.apache.org/jira/browse/BCEL-195 is fixed, but has 
not been closed.


Thank you,
Mark Roberts

> -Original Message-
> From: Benedikt Ritter [mailto:brit...@apache.org]
> Sent: Monday, June 13, 2016 11:49 PM
> To: Commons Developers List
> Subject: [BCEL] Release Candidate on Thursday
> 
> Hi,
> 
> I'm going to try to create an RC for BCEL 6.0 on friday. Please have a look at
> the current state of the code base and report any issues you see.
> 
> Thank you!
> Benedikt


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[BCEL] Release Candidate on Thursday

[Benedikt Ritter]

Hi,

I'm going to try to create an RC for BCEL 6.0 on friday. Please have a look
at the current state of the code base and report any issues you see.

Thank you!
Benedikt

Re: BCEL release?

[sebb]

On 2 June 2016 at 00:50, Olivier Lamy  wrote:
> My problem is the maven coordinate changed

That was done as part of BCEL-222.
This will have to be reverted in order to release a compatible version of BCEL.
I did not get around to doing that when I reworked the code.

> I use bcel in a maven plugin.
> So ideally I would have been happy to simply override in the dependencies
> section of the plugin with the new bcel version.
> But due this non compatible change on the maven coordinate I cannot do
> that

Commons has a choice:
(A) release a binary compatible version of BCEL with the same package
name and Maven coords.
or
(B) release a major new version with new package name and new Maven
coords (the current coords would do)

Only approach (A) works as a drop-in replacement.

>
>
> On 1 June 2016 at 14:42, Gary Gregory  wrote:
>
>> Hi Olivier,
>>
>> Can you validate what is in trunk? That would help. It seems like there are
>> clean ups and unfinished business since this is a major release.
>>
>> (See the deprecated org.apache.commons.bcel6.generic.InstructionConstants
>> email thread I just started)
>>
>> Can you go through JIRA and help out what is missing?
>>
>> Thank you,
>> Gary
>>
>> On Tue, May 31, 2016 at 8:26 PM, Olivier Lamy  wrote:
>>
>> > Hi,
>> > Last release is from 2006.
>> > Fixes for java 8 are here for a while.
>> >
>> > Any ETA on releasing BCEL one day?
>> >
>> > Regards
>> > --
>> > Olivier Lamy
>> > http://twitter.com/olamy | http://linkedin.com/in/olamy
>> >
>>
>>
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> 
>> JUnit in Action, Second Edition 
>> Spring Batch in Action 
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: BCEL release?

[Olivier Lamy]

My problem is the maven coordinate changed
I use bcel in a maven plugin.
So ideally I would have been happy to simply override in the dependencies
section of the plugin with the new bcel version.
But due this non compatible change on the maven coordinate I cannot do
that



On 1 June 2016 at 14:42, Gary Gregory  wrote:

> Hi Olivier,
>
> Can you validate what is in trunk? That would help. It seems like there are
> clean ups and unfinished business since this is a major release.
>
> (See the deprecated org.apache.commons.bcel6.generic.InstructionConstants
> email thread I just started)
>
> Can you go through JIRA and help out what is missing?
>
> Thank you,
> Gary
>
> On Tue, May 31, 2016 at 8:26 PM, Olivier Lamy  wrote:
>
> > Hi,
> > Last release is from 2006.
> > Fixes for java 8 are here for a while.
> >
> > Any ETA on releasing BCEL one day?
> >
> > Regards
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: BCEL release?

[Gary Gregory]

Hi Olivier,

Can you validate what is in trunk? That would help. It seems like there are
clean ups and unfinished business since this is a major release.

(See the deprecated org.apache.commons.bcel6.generic.InstructionConstants
email thread I just started)

Can you go through JIRA and help out what is missing?

Thank you,
Gary

On Tue, May 31, 2016 at 8:26 PM, Olivier Lamy  wrote:

> Hi,
> Last release is from 2006.
> Fixes for java 8 are here for a while.
>
> Any ETA on releasing BCEL one day?
>
> Regards
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>



-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

BCEL release?

[Olivier Lamy]

Hi,
Last release is from 2006.
Fixes for java 8 are here for a while.

Any ETA on releasing BCEL one day?

Regards
-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy