Re: LANG-1052: Multiline recursive to string style
Fixed in trunk. 2014-11-07 11:39 GMT+01:00 Jan Matèrne (jhm) apa...@materne.de: All the Lang developers are quite active on the mailing list, so you can assume we've read your earlier email. However, we are busy people with lives outside Apache Commons (the horror!), so it may take us a few days to respond to a mail and longer still to review a patch :-) Thanks for your feedback, Duncan. I know that committers have a life outside the ASF - I also have ;) I pinged because there were no reaction in JIRA nor here. I noticed you created the issue with a fix version of 3.4. We only set a version in this field once the patch is applied, since we cannot guarantee the patch will be applied before the release of an intermediate version. I've updated this to the correct value for this situation, which is Review Patch. Hopefully this will draw more attention to your PR and one of us will get a chance to review it. Thanks, didnt know that. I have chosen the next version. It will help us in reviewing and committing if you can create a SVN patch file and attach it to the issue (see [1] for hints). We can't merge PRs because our GitHub project is a read-only clone of the SVN repos, so ultimately this is a step that has to be done by someone. If you can do it, it speeds things up (particularly for folks like me who don't bother to maintain a local clone of our GitHub stuff). Done. cheers Jan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
AW: LANG-1052: Multiline recursive to string style
Fixed in trunk. Thanks. Jan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: LANG-1052: Multiline recursive to string style
Hi Jan, On 7 November 2014 05:39, Jan Matèrne (jhm) apa...@materne.de wrote: ping :) Jan All the Lang developers are quite active on the mailing list, so you can assume we've read your earlier email. However, we are busy people with lives outside Apache Commons (the horror!), so it may take us a few days to respond to a mail and longer still to review a patch :-) I noticed you created the issue with a fix version of 3.4. We only set a version in this field once the patch is applied, since we cannot guarantee the patch will be applied before the release of an intermediate version. I've updated this to the correct value for this situation, which is Review Patch. Hopefully this will draw more attention to your PR and one of us will get a chance to review it. It will help us in reviewing and committing if you can create a SVN patch file and attach it to the issue (see [1] for hints). We can't merge PRs because our GitHub project is a read-only clone of the SVN repos, so ultimately this is a step that has to be done by someone. If you can do it, it speeds things up (particularly for folks like me who don't bother to maintain a local clone of our GitHub stuff). Duncan [1] http://stackoverflow.com/a/13377540/474189 -Ursprüngliche Nachricht- Von: Jan Matèrne (jhm) [mailto:apa...@materne.de] Gesendet: Dienstag, 4. November 2014 07:04 An: dev@commons.apache.org Betreff: LANG-1052: Multiline recursive to string style I want to make some advertising for this pull request. It contains implementation, junit tests and already earned some positive feedback. Could someone do a review and (hopefully) merge the PR? cheers Jan [1] https://issues.apache.org/jira/browse/LANG-1052 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
AW: LANG-1052: Multiline recursive to string style
All the Lang developers are quite active on the mailing list, so you can assume we've read your earlier email. However, we are busy people with lives outside Apache Commons (the horror!), so it may take us a few days to respond to a mail and longer still to review a patch :-) Thanks for your feedback, Duncan. I know that committers have a life outside the ASF - I also have ;) I pinged because there were no reaction in JIRA nor here. I noticed you created the issue with a fix version of 3.4. We only set a version in this field once the patch is applied, since we cannot guarantee the patch will be applied before the release of an intermediate version. I've updated this to the correct value for this situation, which is Review Patch. Hopefully this will draw more attention to your PR and one of us will get a chance to review it. Thanks, didnt know that. I have chosen the next version. It will help us in reviewing and committing if you can create a SVN patch file and attach it to the issue (see [1] for hints). We can't merge PRs because our GitHub project is a read-only clone of the SVN repos, so ultimately this is a step that has to be done by someone. If you can do it, it speeds things up (particularly for folks like me who don't bother to maintain a local clone of our GitHub stuff). Done. cheers Jan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
AW: LANG-1052: Multiline recursive to string style
ping :) Jan -Ursprüngliche Nachricht- Von: Jan Matèrne (jhm) [mailto:apa...@materne.de] Gesendet: Dienstag, 4. November 2014 07:04 An: dev@commons.apache.org Betreff: LANG-1052: Multiline recursive to string style I want to make some advertising for this pull request. It contains implementation, junit tests and already earned some positive feedback. Could someone do a review and (hopefully) merge the PR? cheers Jan [1] https://issues.apache.org/jira/browse/LANG-1052 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
LANG-1052: Multiline recursive to string style
I want to make some advertising for this pull request. It contains implementation, junit tests and already earned some positive feedback. Could someone do a review and (hopefully) merge the PR? cheers Jan [1] https://issues.apache.org/jira/browse/LANG-1052
