Re: [LANG] Things to look for when working on LANG

[Benedikt Ritter]

Pascal Schumacher  schrieb am Di., 20. Sep. 2016
um 18:23 Uhr:

> +1
>
> Is it possible to enable the javadoc check on travis-ci, so that it is
> also done for any pull request?
>

Yes, that would probably require a custome script hook in .travis.yml. Once
we have cleaned up the findbugs, pmd and checkstyle reports we can also add
those if we want to.

Benedikt


>
> Thanks,
> Pascal
>
> Am 19.09.2016 um 13:26 schrieb Benedikt Ritter:
> > Hi,
> >
> > I'm currently going through the code base to polish it for 3.5. There are
> > some things every developer should have a look for so that it is less
> work
> > to prepare a new release:
> >
> > - always add a @since tag when introducing new methods
> > - make sure the site build still works. I' ve added javadoc:javadoc to
> the
> > jenkins build so that it will fail if the JavaDoc is malformed
> > - keep an eye on FindBugs, PMD, checkstyle. You can generate the complete
> > site by running mvn site
> >
> > Thank you,
> > Benedikt
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [LANG] Things to look for when working on LANG

[Pascal Schumacher]

+1

Is it possible to enable the javadoc check on travis-ci, so that it is 
also done for any pull request?


Thanks,
Pascal

Am 19.09.2016 um 13:26 schrieb Benedikt Ritter:

Hi,

I'm currently going through the code base to polish it for 3.5. There are
some things every developer should have a look for so that it is less work
to prepare a new release:

- always add a @since tag when introducing new methods
- make sure the site build still works. I' ve added javadoc:javadoc to the
jenkins build so that it will fail if the JavaDoc is malformed
- keep an eye on FindBugs, PMD, checkstyle. You can generate the complete
site by running mvn site

Thank you,
Benedikt




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [LANG] Things to look for when working on LANG

[Gary Gregory]

Thanks Benedikt, good reminders!

Gary

On Sep 19, 2016 4:26 AM, "Benedikt Ritter"  wrote:

> Hi,
>
> I'm currently going through the code base to polish it for 3.5. There are
> some things every developer should have a look for so that it is less work
> to prepare a new release:
>
> - always add a @since tag when introducing new methods
> - make sure the site build still works. I' ve added javadoc:javadoc to the
> jenkins build so that it will fail if the JavaDoc is malformed
> - keep an eye on FindBugs, PMD, checkstyle. You can generate the complete
> site by running mvn site
>
> Thank you,
> Benedikt
>