Re: commons-rng git commit: accommodate for up to 4 re-runs of a failing test

2018-07-26 Thread Rob Tompkins


> On Jul 25, 2018, at 10:05 PM, Gilles  wrote:
> 
> Hello Rob.
> 
> On Thu, 26 Jul 2018 01:44:59 + (UTC), chtom...@apache.org 
>  wrote:
>> [...]
>> 
>> 
>> http://git-wip-us.apache.org/repos/asf/commons-rng/blob/1eb7ea49/commons-rng-sampling/pom.xml
>> --
>> diff --git a/commons-rng-sampling/pom.xml b/commons-rng-sampling/pom.xml
>> index bd1fb0d..6d0a80a 100644
>> --- a/commons-rng-sampling/pom.xml
>> +++ b/commons-rng-sampling/pom.xml
>> @@ -66,4 +66,16 @@
>> 
>>   
>> 
>> +  
>> +
>> +  
>> +maven-surefire-plugin
>> +2.22.0
>> +
>> +  4
>> +
>> +  
>> +
>> +  
>> +
>> 
> 
> Nice! [IIUC the number of "flakes" is per test, so allowing 2
> is already good as it's unlikely that the same sampler will
> fail twice in a row.]
> 
> Thanks for thinking about it and finding the workaround.

Right….I was psyched that I found that. :-)

-Rob

> 
> Regards,
> Gilles
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org 
> 
> For additional commands, e-mail: dev-h...@commons.apache.org 
> 


Re: commons-rng git commit: accommodate for up to 4 re-runs of a failing test

2018-07-25 Thread Gilles

Hello Rob.

On Thu, 26 Jul 2018 01:44:59 + (UTC), chtom...@apache.org wrote:

[...]



http://git-wip-us.apache.org/repos/asf/commons-rng/blob/1eb7ea49/commons-rng-sampling/pom.xml

--
diff --git a/commons-rng-sampling/pom.xml 
b/commons-rng-sampling/pom.xml

index bd1fb0d..6d0a80a 100644
--- a/commons-rng-sampling/pom.xml
+++ b/commons-rng-sampling/pom.xml
@@ -66,4 +66,16 @@
 
   

+  
+
+  
+maven-surefire-plugin
+2.22.0
+
+  4
+
+  
+
+  
+
 


Nice! [IIUC the number of "flakes" is per test, so allowing 2
is already good as it's unlikely that the same sampler will
fail twice in a row.]

Thanks for thinking about it and finding the workaround.

Regards,
Gilles



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org