Re: [math] Change on "master" (Was: [10/10] [math] Remove redundant ...)

2016-09-20 Thread Rob Tompkins


> On Sep 20, 2016, at 10:30 AM, Gilles  wrote:
> 
>> On Tue, 20 Sep 2016 06:40:40 -, ggreg...@apache.org wrote:
>> Remove redundant type arguments.
>> 
>> Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/8b5f4535
>> Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/8b5f4535
>> Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/8b5f4535
>> 
>> Branch: refs/heads/master
> 
> -1
> 
> This should have been done on branch "develop".[1]
> 
> Gilles
> 
> [1] After the revert, we should probably change "master" to
>"old_master" and "develop" to "master" to avoid confusion,
>as was done by Emmanuel (for "commons-rng").
>We'd still need to update the info in
>  doc/development/development.howto.txt
>[The contents of this file is also stale in "commons-rng".]
> 

+1. I can do that today if we want to. 

> 
>> Commit: 8b5f4535ec5a3983e655e5fc66a90fce657d4344
>> Parents: 598edc1
>> Author: Gary Gregory 
>> Authored: Mon Sep 19 23:40:15 2016 -0700
>> Committer: Gary Gregory 
>> Committed: Mon Sep 19 23:40:15 2016 -0700
>> 
>> --
>> .../analysis/differentiation/DSCompiler.java|  10 +-
>> .../differentiation/SparseGradient.java |   4 +-
>> .../integration/gauss/BaseRuleFactory.java  |   8 +-
>> .../gauss/GaussIntegratorFactory.java   |   2 +-
>> .../integration/gauss/HermiteRuleFactory.java   |   4 +-
>> .../gauss/LegendreHighPrecisionRuleFactory.java |   4 +-
>> .../integration/gauss/LegendreRuleFactory.java  |   4 +-
>> .../interpolation/FieldHermiteInterpolator.java |   6 +-
>> .../interpolation/HermiteInterpolator.java  |   6 +-
>> .../interpolation/InterpolatingMicrosphere.java |   6 +-
>> .../analysis/polynomials/PolynomialsUtils.java  |  12 +-
>> .../apache/commons/math4/complex/Complex.java   |   2 +-
>> .../distribution/EnumeratedDistribution.java |   6 +-
>> .../EnumeratedIntegerDistribution.java  |  10 +-
>> .../EnumeratedRealDistribution.java |  10 +-
>> .../MixtureMultivariateNormalDistribution.java  |   4 +-
>> .../MixtureMultivariateRealDistribution.java|   6 +-
>> ...ateNormalMixtureExpectationMaximization.java |   4 +-
>> .../commons/math4/exception/util/ArgUtils.java  |   2 +-
>> .../math4/exception/util/ExceptionContext.java  |  12 +-
>> .../math4/fitting/GaussianCurveFitter.java  |   2 +-
>> .../math4/fitting/HarmonicCurveFitter.java  |   2 +-
>> .../math4/fitting/WeightedObservedPoints.java   |   4 +-
>> .../leastsquares/GaussNewtonOptimizer.java  |   2 +-
>> .../leastsquares/LeastSquaresFactory.java   |   2 +-
>> .../math4/genetics/AbstractListChromosome.java  |   2 +-
>> .../math4/genetics/BinaryChromosome.java|   2 +-
>> .../commons/math4/genetics/BinaryMutation.java  |   2 +-
>> .../commons/math4/genetics/CycleCrossover.java  |   8 +-
>> .../commons/math4/genetics/ListPopulation.java  |   2 +-
>> .../commons/math4/genetics/NPointCrossover.java |   4 +-
>> .../math4/genetics/OnePointCrossover.java |   4 +-
>> .../math4/genetics/OrderedCrossover.java|   8 +-
>> .../commons/math4/genetics/RandomKey.java   |  16 +-
>> .../math4/genetics/RandomKeyMutation.java   |   2 +-
>> .../math4/genetics/TournamentSelection.java |   2 +-
>> .../math4/genetics/UniformCrossover.java|   4 +-
>> .../math4/geometry/enclosing/WelzlEncloser.java |   4 +-
>> .../geometry/euclidean/oned/IntervalsSet.java   |  22 +-
>> .../euclidean/oned/SubOrientedPoint.java|   6 +-
>> .../euclidean/threed/FieldRotation.java |  40 ++--
>> .../euclidean/threed/FieldVector3D.java |  42 ++--
>> .../euclidean/threed/OutlineExtractor.java  |   2 +-
>> .../euclidean/threed/PolyhedronsSet.java|   4 +-
>> .../euclidean/threed/SphereGenerator.java   |  10 +-
>> .../geometry/euclidean/threed/SubLine.java |   2 +-
>> .../geometry/euclidean/threed/SubPlane.java |  12 +-
>> .../geometry/euclidean/twod/DiskGenerator.java  |   8 +-
>> .../geometry/euclidean/twod/NestedLoops.java|   8 +-
>> .../geometry/euclidean/twod/PolygonsSet.java|  18 +-
>> .../math4/geometry/euclidean/twod/SubLine.java  |  14 +-
>> .../twod/hull/AklToussaintHeuristic.java|   4 +-
>> .../euclidean/twod/hull/ConvexHull2D.java   |   2 +-
>> .../euclidean/twod/hull/MonotoneChain.java  |   8 +-
>> .../geometry/partitioning/AbstractRegion.java   |  26 +--
>> .../partitioning/AbstractSubHyperplane.java |   8 +-
>> .../math4/geometry/partitioning/BSPTree.java|  34 +--
>> .../geometry/partitioning/BoundaryBuilder.java  |  12 +-
>> .../partitioning/BoundaryProjector.java |   4 +-
>> .../geometry/partitioning/Characterization.java |   4 +-
>> .../math4/geometry/partitioning/NodesSet.java   |   2 +-
>> 

Re: commons-io git commit: Remove redundant type arguments.

2016-09-20 Thread Gary Gregory
This annoying :-( it must be an EOL thing.

Gary

On Sep 20, 2016 7:18 AM, "Matt Sicker"  wrote:

> Did the line ending change?
>
> On 20 September 2016 at 01:59, Benedikt Ritter  wrote:
>
> > Hello Gary,
> >
> > why has the whole file changed?
> >
> > Regards,
> > Benedikt
> >
> >  schrieb am Di., 20. Sep. 2016 um 07:40 Uhr:
> >
> > > Repository: commons-io
> > > Updated Branches:
> > >   refs/heads/master 9ba9b49af -> 822bd135f
> > >
> > >
> > > Remove redundant type arguments.
> > >
> > > Project: http://git-wip-us.apache.org/repos/asf/commons-io/repo
> > > Commit: http://git-wip-us.apache.org/repos/asf/commons-io/commit/
> > 822bd135
> > > Tree: http://git-wip-us.apache.org/repos/asf/commons-io/tree/822bd135
> > > Diff: http://git-wip-us.apache.org/repos/asf/commons-io/diff/822bd135
> > >
> > > Branch: refs/heads/master
> > > Commit: 822bd135f3a54b8fbeb23c313535b13c18198c3a
> > > Parents: 9ba9b49
> > > Author: Gary Gregory 
> > > Authored: Mon Sep 19 22:40:29 2016 -0700
> > > Committer: Gary Gregory 
> > > Committed: Mon Sep 19 22:40:29 2016 -0700
> > >
> > > --
> > >  .../commons/io/input/ObservableInputStream.java | 476
> > +--
> > >  1 file changed, 238 insertions(+), 238 deletions(-)
> > > --
> > >
> > >
> > >
> > > http://git-wip-us.apache.org/repos/asf/commons-io/blob/
> > 822bd135/src/main/java/org/apache/commons/io/input/
> > ObservableInputStream.java
> > > --
> > > diff --git
> > > a/src/main/java/org/apache/commons/io/input/ObservableInputStream.java
> > > b/src/main/java/org/apache/commons/io/input/ObservableInputStream.java
> > > index 7d13472..c580ba4 100644
> > > --- a/src/main/java/org/apache/commons/io/input/
> > ObservableInputStream.java
> > > +++ b/src/main/java/org/apache/commons/io/input/
> > ObservableInputStream.java
> > > @@ -1,238 +1,238 @@
> > > -/*
> > > - * Licensed to the Apache Software Foundation (ASF) under one or more
> > > - * contributor license agreements.  See the NOTICE file distributed
> with
> > > - * this work for additional information regarding copyright ownership.
> > > - * The ASF licenses this file to You under the Apache License, Version
> > 2.0
> > > - * (the "License"); you may not use this file except in compliance
> with
> > > - * the License.  You may obtain a copy of the License at
> > > - *
> > > - *  http://www.apache.org/licenses/LICENSE-2.0
> > > - *
> > > - * Unless required by applicable law or agreed to in writing, software
> > > - * distributed under the License is distributed on an "AS IS" BASIS,
> > > - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> > > implied.
> > > - * See the License for the specific language governing permissions and
> > > - * limitations under the License.
> > > - */
> > > -package org.apache.commons.io.input;
> > > -
> > > -import java.io.IOException;
> > > -import java.io.InputStream;
> > > -import java.security.MessageDigest;
> > > -import java.util.ArrayList;
> > > -import java.util.List;
> > > -
> > > -
> > > -/**
> > > - * The {@link ObservableInputStream} allows, that an InputStream may
> be
> > > consumed
> > > - * by other receivers, apart from the thread, which is reading it.
> > > - * The other consumers are implemented as instances of {@link
> > Observer}. A
> > > - * typical application may be the generation of a {@link
> MessageDigest}
> > > on the
> > > - * fly.
> > > - * {@code Note}: The {@link ObservableInputStream} is not
> > thread
> > > safe,
> > > - * as instances of InputStream usually aren't.
> > > - * If you must access the stream from multiple threads, then
> > > synchronization, locking,
> > > - * or a similar means must be used.
> > > - * @see MessageDigestCalculatingInputStream
> > > - */
> > > -public class ObservableInputStream extends ProxyInputStream {
> > > -public static abstract class Observer {
> > > -/** Called to indicate, that {@link InputStream#read()} has
> been
> > > invoked
> > > - * on the {@link ObservableInputStream}, and will return a
> > value.
> > > - * @param pByte The value, which is being returned. This will
> > > never be -1 (EOF),
> > > - *because, in that case, {link #finished()} will be
> invoked
> > > instead.
> > > - */
> > > -void data(int pByte) throws IOException {}
> > > -/** Called to indicate, that {@link InputStream#read(byte[])},
> > or
> > > - * {@link InputStream#read(byte[], int, int)} have been
> called,
> > > and are about to
> > > - * invoke data.
> > > - * @param pBuffer The byte array, which has been passed to the
> > > read call, and where
> > > - *   data has been stored.
> > > - * @param pOffset 

Re: [LANG] Things to look for when working on LANG

2016-09-20 Thread Pascal Schumacher

+1

Is it possible to enable the javadoc check on travis-ci, so that it is 
also done for any pull request?


Thanks,
Pascal

Am 19.09.2016 um 13:26 schrieb Benedikt Ritter:

Hi,

I'm currently going through the code base to polish it for 3.5. There are
some things every developer should have a look for so that it is less work
to prepare a new release:

- always add a @since tag when introducing new methods
- make sure the site build still works. I' ve added javadoc:javadoc to the
jenkins build so that it will fail if the JavaDoc is malformed
- keep an eye on FindBugs, PMD, checkstyle. You can generate the complete
site by running mvn site

Thank you,
Benedikt




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: commons-io git commit: Remove redundant type arguments.

2016-09-20 Thread Benedikt Ritter
Hello Gary,

why has the whole file changed?

Regards,
Benedikt

 schrieb am Di., 20. Sep. 2016 um 07:40 Uhr:

> Repository: commons-io
> Updated Branches:
>   refs/heads/master 9ba9b49af -> 822bd135f
>
>
> Remove redundant type arguments.
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-io/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-io/commit/822bd135
> Tree: http://git-wip-us.apache.org/repos/asf/commons-io/tree/822bd135
> Diff: http://git-wip-us.apache.org/repos/asf/commons-io/diff/822bd135
>
> Branch: refs/heads/master
> Commit: 822bd135f3a54b8fbeb23c313535b13c18198c3a
> Parents: 9ba9b49
> Author: Gary Gregory 
> Authored: Mon Sep 19 22:40:29 2016 -0700
> Committer: Gary Gregory 
> Committed: Mon Sep 19 22:40:29 2016 -0700
>
> --
>  .../commons/io/input/ObservableInputStream.java | 476 +--
>  1 file changed, 238 insertions(+), 238 deletions(-)
> --
>
>
>
> http://git-wip-us.apache.org/repos/asf/commons-io/blob/822bd135/src/main/java/org/apache/commons/io/input/ObservableInputStream.java
> --
> diff --git
> a/src/main/java/org/apache/commons/io/input/ObservableInputStream.java
> b/src/main/java/org/apache/commons/io/input/ObservableInputStream.java
> index 7d13472..c580ba4 100644
> --- a/src/main/java/org/apache/commons/io/input/ObservableInputStream.java
> +++ b/src/main/java/org/apache/commons/io/input/ObservableInputStream.java
> @@ -1,238 +1,238 @@
> -/*
> - * Licensed to the Apache Software Foundation (ASF) under one or more
> - * contributor license agreements.  See the NOTICE file distributed with
> - * this work for additional information regarding copyright ownership.
> - * The ASF licenses this file to You under the Apache License, Version 2.0
> - * (the "License"); you may not use this file except in compliance with
> - * the License.  You may obtain a copy of the License at
> - *
> - *  http://www.apache.org/licenses/LICENSE-2.0
> - *
> - * Unless required by applicable law or agreed to in writing, software
> - * distributed under the License is distributed on an "AS IS" BASIS,
> - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> - * See the License for the specific language governing permissions and
> - * limitations under the License.
> - */
> -package org.apache.commons.io.input;
> -
> -import java.io.IOException;
> -import java.io.InputStream;
> -import java.security.MessageDigest;
> -import java.util.ArrayList;
> -import java.util.List;
> -
> -
> -/**
> - * The {@link ObservableInputStream} allows, that an InputStream may be
> consumed
> - * by other receivers, apart from the thread, which is reading it.
> - * The other consumers are implemented as instances of {@link Observer}. A
> - * typical application may be the generation of a {@link MessageDigest}
> on the
> - * fly.
> - * {@code Note}: The {@link ObservableInputStream} is not thread
> safe,
> - * as instances of InputStream usually aren't.
> - * If you must access the stream from multiple threads, then
> synchronization, locking,
> - * or a similar means must be used.
> - * @see MessageDigestCalculatingInputStream
> - */
> -public class ObservableInputStream extends ProxyInputStream {
> -public static abstract class Observer {
> -/** Called to indicate, that {@link InputStream#read()} has been
> invoked
> - * on the {@link ObservableInputStream}, and will return a value.
> - * @param pByte The value, which is being returned. This will
> never be -1 (EOF),
> - *because, in that case, {link #finished()} will be invoked
> instead.
> - */
> -void data(int pByte) throws IOException {}
> -/** Called to indicate, that {@link InputStream#read(byte[])}, or
> - * {@link InputStream#read(byte[], int, int)} have been called,
> and are about to
> - * invoke data.
> - * @param pBuffer The byte array, which has been passed to the
> read call, and where
> - *   data has been stored.
> - * @param pOffset The offset within the byte array, where data
> has been stored.
> - * @param pLength The number of bytes, which have been stored in
> the byte array.
> - */
> -void data(byte[] pBuffer, int pOffset, int pLength) throws
> IOException {}
> -/** Called to indicate, that EOF has been seen on the underlying
> stream.
> - * This method may be called multiple times, if the reader keeps
> invoking
> - * either of the read methods, and they will consequently keep
> returning
> - * EOF.
> - */
> -void finished() throws IOException {}
> -/** Called to indicate, that the {@link ObservableInputStream}
> has been closed.
> - */
> 

Early Access build 136 for JDK 9 & JDK 9 with Project Jigsaw are available on java.net

2016-09-20 Thread Rory O'Donnell


Hi Benedikt,

Early Access b136  for JDK 9 is 
available on java.net, summary of  changes are listed here 
.
Early Access b136  (#5506) for JDK 9 with 
Project Jigsaw is available on java.net, summary of  changes are listed 
here 
.


There have been a number of fixes to bugs reported by Open Source 
projects since the last availability email  :


 * 8165723 - b136 - core-libs JarFile::isMultiRelease() method returns
   false when it should return true
 * 8165116 - b136 - xml redirect function is not allowed even with
   enableExtensionFunctions

NOTE:-  Build 135 included a fix for JDK-8161016 which *has introduced a 
behavioral change to HttpURLConnection, more info:*


The behavior of HttpURLConnection when using a ProxySelector has been 
modified with this JDK release. Currently, HttpURLConnection.connect() 
call would fallback to a DIRECT connection attempt if the configured 
proxy/proxies failed to make a connection. This release introduces a 
change whereby no DIRECT connection will be attempted in such a 
scenario. Instead, the HttpURLConnection.connect() method will fail and 
throw an IOException which occurred from the last proxy tested. This 
behavior now matches with the HTTP connections made by popular web 
browsers. But this change will bring compatibility issues for the 
applications expecting a DIRECT connection when a proxy server is down 
or when wrong proxies are provided.

*

JDK 9 Outreach Survey*

In order to encourage and receive additional feedback from developers 
testing their applications with JDK 9,
the OpenJDK Quality Outreach effort has put together a very brief survey 
about your experiences with JDK 9 so far.


It is available at***https://www.surveymonkey.de/r/JDK9EA*

We would love to hear feedback from you!


Rgds,Rory

--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland



Re: [RDF] Include RDFParserBuilder in 0.3.0?

2016-09-20 Thread Stian Soiland-Reyes
On 15 September 2016 at 12:06, Stian Soiland-Reyes  wrote:
> [[ Cross-posting - let's try to reply to dev@commons. ]]

> b) Move RDFParserBuilder to package org.apache.commonsrdf.experimental
>  or similar (allowing us to fully change it for the next version)

> c) Same as b) - but also move RDFParserBuilder implementations to e.g.
> org.apache.commonsrdf.jena.experimental

> e) Remove RDFParserBuilder.rdfTermFactory()

These are my proposed changes - I'll go ahead on these unless I hear
otherwise :)


Commons folks - is the use of a ".experimental" sub-package (and
appropriate Javadoc) OK?

Suggested javadoc:

package org.commons.rdf.api.experimental;
/**
  * ...
  * 
  * NOTE: This interface/class is currently marked as
experimental,
  * meaning that it might change or be removed in the next minor version.
  */
public interface RDFParserBuilder {
  // ...
}


I'm not proposing we go all Guava style with lots of experimental
annotations (and the well known incompatibility issues following),
just for this 0.3.0-incubating version - so we can decide later on the
final form of that interface for the following (hopefully 1.0.0)
version under Commons proper.


-- 
Stian Soiland-Reyes
http://orcid.org/-0001-9842-9718

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [math] Change on "master" (Was: [10/10] [math] Remove redundant ...)

2016-09-20 Thread Rob Tompkins


> On Sep 20, 2016, at 1:55 PM, Gary Gregory  wrote:
> 
>> On Tue, Sep 20, 2016 at 8:16 AM, Rob Tompkins  wrote:
>> 
>> 
>> 
>>> On Sep 20, 2016, at 10:30 AM, Gilles 
>> wrote:
>>> 
 On Tue, 20 Sep 2016 06:40:40 -, ggreg...@apache.org wrote:
 Remove redundant type arguments.
 
 Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
 Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/
>> 8b5f4535
 Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/8b5f4535
 Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/8b5f4535
 
 Branch: refs/heads/master
>>> 
>>> -1
>>> 
>>> This should have been done on branch "develop".[1]
>> 
> 
> Reverted master and pushed on develop.
> 
> 
>>> 
>>> Gilles
>>> 
>>> [1] After the revert, we should probably change "master" to
>>>   "old_master" and "develop" to "master" to avoid confusion,
>>>   as was done by Emmanuel (for "commons-rng").
>>>   We'd still need to update the info in
>>> doc/development/development.howto.txt
>>>   [The contents of this file is also stale in "commons-rng".]
>>> 
>> 
>> +1. I can do that today if we want to.
>> 
> 
> Go for it.
> 

Done. From here I'll try to get Travis back working. 

-Rob

> Gary
> 
> 
>> 
>>> 
 Commit: 8b5f4535ec5a3983e655e5fc66a90fce657d4344
 Parents: 598edc1
 Author: Gary Gregory 
 Authored: Mon Sep 19 23:40:15 2016 -0700
 Committer: Gary Gregory 
 Committed: Mon Sep 19 23:40:15 2016 -0700
 
 --
 .../analysis/differentiation/DSCompiler.java|  10 +-
 .../differentiation/SparseGradient.java |   4 +-
 .../integration/gauss/BaseRuleFactory.java  |   8 +-
 .../gauss/GaussIntegratorFactory.java   |   2 +-
 .../integration/gauss/HermiteRuleFactory.java   |   4 +-
 .../gauss/LegendreHighPrecisionRuleFactory.java |   4 +-
 .../integration/gauss/LegendreRuleFactory.java  |   4 +-
 .../interpolation/FieldHermiteInterpolator.java |   6 +-
 .../interpolation/HermiteInterpolator.java  |   6 +-
 .../interpolation/InterpolatingMicrosphere.java |   6 +-
 .../analysis/polynomials/PolynomialsUtils.java  |  12 +-
 .../apache/commons/math4/complex/Complex.java   |   2 +-
 .../distribution/EnumeratedDistribution.java |   6 +-
 .../EnumeratedIntegerDistribution.java  |  10 +-
 .../EnumeratedRealDistribution.java |  10 +-
 .../MixtureMultivariateNormalDistribution.java  |   4 +-
 .../MixtureMultivariateRealDistribution.java|   6 +-
 ...ateNormalMixtureExpectationMaximization.java |   4 +-
 .../commons/math4/exception/util/ArgUtils.java  |   2 +-
 .../math4/exception/util/ExceptionContext.java  |  12 +-
 .../math4/fitting/GaussianCurveFitter.java  |   2 +-
 .../math4/fitting/HarmonicCurveFitter.java |   2 +-
 .../math4/fitting/WeightedObservedPoints.java   |   4 +-
 .../leastsquares/GaussNewtonOptimizer.java  |   2 +-
 .../leastsquares/LeastSquaresFactory.java |   2 +-
 .../math4/genetics/AbstractListChromosome.java  |   2 +-
 .../math4/genetics/BinaryChromosome.java|   2 +-
 .../commons/math4/genetics/BinaryMutation.java  |   2 +-
 .../commons/math4/genetics/CycleCrossover.java  |   8 +-
 .../commons/math4/genetics/ListPopulation.java  |   2 +-
 .../commons/math4/genetics/NPointCrossover.java |   4 +-
 .../math4/genetics/OnePointCrossover.java |   4 +-
 .../math4/genetics/OrderedCrossover.java|   8 +-
 .../commons/math4/genetics/RandomKey.java   |  16 +-
 .../math4/genetics/RandomKeyMutation.java   |   2 +-
 .../math4/genetics/TournamentSelection.java |   2 +-
 .../math4/genetics/UniformCrossover.java |   4 +-
 .../math4/geometry/enclosing/WelzlEncloser.java |   4 +-
 .../geometry/euclidean/oned/IntervalsSet.java   |  22 +-
 .../euclidean/oned/SubOrientedPoint.java|   6 +-
 .../euclidean/threed/FieldRotation.java |  40 ++--
 .../euclidean/threed/FieldVector3D.java |  42 ++--
 .../euclidean/threed/OutlineExtractor.java  |   2 +-
 .../euclidean/threed/PolyhedronsSet.java|   4 +-
 .../euclidean/threed/SphereGenerator.java   |  10 +-
 .../geometry/euclidean/threed/SubLine.java |   2 +-
 .../geometry/euclidean/threed/SubPlane.java |  12 +-
 .../geometry/euclidean/twod/DiskGenerator.java  |   8 +-
 .../geometry/euclidean/twod/NestedLoops.java|   8 +-
 .../geometry/euclidean/twod/PolygonsSet.java|  18 +-
 .../math4/geometry/euclidean/twod/SubLine.java  |  14 +-
 .../twod/hull/AklToussaintHeuristic.java|   4 +-
 .../euclidean/twod/hull/ConvexHull2D.java |   2 +-
 

Re: [math] Change on "master" (Was: [10/10] [math] Remove redundant ...)

2016-09-20 Thread Gary Gregory
On Tue, Sep 20, 2016 at 8:16 AM, Rob Tompkins  wrote:

>
>
> > On Sep 20, 2016, at 10:30 AM, Gilles 
> wrote:
> >
> >> On Tue, 20 Sep 2016 06:40:40 -, ggreg...@apache.org wrote:
> >> Remove redundant type arguments.
> >>
> >> Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
> >> Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/
> 8b5f4535
> >> Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/8b5f4535
> >> Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/8b5f4535
> >>
> >> Branch: refs/heads/master
> >
> > -1
> >
> > This should have been done on branch "develop".[1]
>

Reverted master and pushed on develop.


> >
> > Gilles
> >
> > [1] After the revert, we should probably change "master" to
> >"old_master" and "develop" to "master" to avoid confusion,
> >as was done by Emmanuel (for "commons-rng").
> >We'd still need to update the info in
> >  doc/development/development.howto.txt
> >[The contents of this file is also stale in "commons-rng".]
> >
>
> +1. I can do that today if we want to.
>

Go for it.

Gary


>
> >
> >> Commit: 8b5f4535ec5a3983e655e5fc66a90fce657d4344
> >> Parents: 598edc1
> >> Author: Gary Gregory 
> >> Authored: Mon Sep 19 23:40:15 2016 -0700
> >> Committer: Gary Gregory 
> >> Committed: Mon Sep 19 23:40:15 2016 -0700
> >>
> >> --
> >> .../analysis/differentiation/DSCompiler.java|  10 +-
> >> .../differentiation/SparseGradient.java |   4 +-
> >> .../integration/gauss/BaseRuleFactory.java  |   8 +-
> >> .../gauss/GaussIntegratorFactory.java   |   2 +-
> >> .../integration/gauss/HermiteRuleFactory.java   |   4 +-
> >> .../gauss/LegendreHighPrecisionRuleFactory.java |   4 +-
> >> .../integration/gauss/LegendreRuleFactory.java  |   4 +-
> >> .../interpolation/FieldHermiteInterpolator.java |   6 +-
> >> .../interpolation/HermiteInterpolator.java  |   6 +-
> >> .../interpolation/InterpolatingMicrosphere.java |   6 +-
> >> .../analysis/polynomials/PolynomialsUtils.java  |  12 +-
> >> .../apache/commons/math4/complex/Complex.java   |   2 +-
> >> .../distribution/EnumeratedDistribution.java |   6 +-
> >> .../EnumeratedIntegerDistribution.java  |  10 +-
> >> .../EnumeratedRealDistribution.java |  10 +-
> >> .../MixtureMultivariateNormalDistribution.java  |   4 +-
> >> .../MixtureMultivariateRealDistribution.java|   6 +-
> >> ...ateNormalMixtureExpectationMaximization.java |   4 +-
> >> .../commons/math4/exception/util/ArgUtils.java  |   2 +-
> >> .../math4/exception/util/ExceptionContext.java  |  12 +-
> >> .../math4/fitting/GaussianCurveFitter.java  |   2 +-
> >> .../math4/fitting/HarmonicCurveFitter.java  |   2 +-
> >> .../math4/fitting/WeightedObservedPoints.java   |   4 +-
> >> .../leastsquares/GaussNewtonOptimizer.java  |   2 +-
> >> .../leastsquares/LeastSquaresFactory.java   |   2 +-
> >> .../math4/genetics/AbstractListChromosome.java  |   2 +-
> >> .../math4/genetics/BinaryChromosome.java|   2 +-
> >> .../commons/math4/genetics/BinaryMutation.java  |   2 +-
> >> .../commons/math4/genetics/CycleCrossover.java  |   8 +-
> >> .../commons/math4/genetics/ListPopulation.java  |   2 +-
> >> .../commons/math4/genetics/NPointCrossover.java |   4 +-
> >> .../math4/genetics/OnePointCrossover.java |   4 +-
> >> .../math4/genetics/OrderedCrossover.java|   8 +-
> >> .../commons/math4/genetics/RandomKey.java   |  16 +-
> >> .../math4/genetics/RandomKeyMutation.java   |   2 +-
> >> .../math4/genetics/TournamentSelection.java |   2 +-
> >> .../math4/genetics/UniformCrossover.java|   4 +-
> >> .../math4/geometry/enclosing/WelzlEncloser.java |   4 +-
> >> .../geometry/euclidean/oned/IntervalsSet.java   |  22 +-
> >> .../euclidean/oned/SubOrientedPoint.java|   6 +-
> >> .../euclidean/threed/FieldRotation.java |  40 ++--
> >> .../euclidean/threed/FieldVector3D.java |  42 ++--
> >> .../euclidean/threed/OutlineExtractor.java  |   2 +-
> >> .../euclidean/threed/PolyhedronsSet.java|   4 +-
> >> .../euclidean/threed/SphereGenerator.java   |  10 +-
> >> .../geometry/euclidean/threed/SubLine.java |   2 +-
> >> .../geometry/euclidean/threed/SubPlane.java |  12 +-
> >> .../geometry/euclidean/twod/DiskGenerator.java  |   8 +-
> >> .../geometry/euclidean/twod/NestedLoops.java|   8 +-
> >> .../geometry/euclidean/twod/PolygonsSet.java|  18 +-
> >> .../math4/geometry/euclidean/twod/SubLine.java  |  14 +-
> >> .../twod/hull/AklToussaintHeuristic.java|   4 +-
> >> .../euclidean/twod/hull/ConvexHull2D.java   |   2 +-
> >> .../euclidean/twod/hull/MonotoneChain.java  |   8 +-
> >> .../geometry/partitioning/AbstractRegion.java   |  26 +--
> >> .../partitioning/AbstractSubHyperplane.java |   8 +-
> >> 

[math] Change on "master" (Was: [10/10] [math] Remove redundant ...)

2016-09-20 Thread Gilles

On Tue, 20 Sep 2016 06:40:40 -, ggreg...@apache.org wrote:

Remove redundant type arguments.

Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/commons-math/commit/8b5f4535
Tree: 
http://git-wip-us.apache.org/repos/asf/commons-math/tree/8b5f4535
Diff: 
http://git-wip-us.apache.org/repos/asf/commons-math/diff/8b5f4535


Branch: refs/heads/master


-1

This should have been done on branch "develop".[1]

Gilles

[1] After the revert, we should probably change "master" to
"old_master" and "develop" to "master" to avoid confusion,
as was done by Emmanuel (for "commons-rng").
We'd still need to update the info in
  doc/development/development.howto.txt
[The contents of this file is also stale in "commons-rng".]



Commit: 8b5f4535ec5a3983e655e5fc66a90fce657d4344
Parents: 598edc1
Author: Gary Gregory 
Authored: Mon Sep 19 23:40:15 2016 -0700
Committer: Gary Gregory 
Committed: Mon Sep 19 23:40:15 2016 -0700


--
 .../analysis/differentiation/DSCompiler.java|  10 +-
 .../differentiation/SparseGradient.java |   4 +-
 .../integration/gauss/BaseRuleFactory.java  |   8 +-
 .../gauss/GaussIntegratorFactory.java   |   2 +-
 .../integration/gauss/HermiteRuleFactory.java   |   4 +-
 .../gauss/LegendreHighPrecisionRuleFactory.java |   4 +-
 .../integration/gauss/LegendreRuleFactory.java  |   4 +-
 .../interpolation/FieldHermiteInterpolator.java |   6 +-
 .../interpolation/HermiteInterpolator.java  |   6 +-
 .../interpolation/InterpolatingMicrosphere.java |   6 +-
 .../analysis/polynomials/PolynomialsUtils.java  |  12 +-
 .../apache/commons/math4/complex/Complex.java   |   2 +-
 .../distribution/EnumeratedDistribution.java|   6 +-
 .../EnumeratedIntegerDistribution.java  |  10 +-
 .../EnumeratedRealDistribution.java |  10 +-
 .../MixtureMultivariateNormalDistribution.java  |   4 +-
 .../MixtureMultivariateRealDistribution.java|   6 +-
 ...ateNormalMixtureExpectationMaximization.java |   4 +-
 .../commons/math4/exception/util/ArgUtils.java  |   2 +-
 .../math4/exception/util/ExceptionContext.java  |  12 +-
 .../math4/fitting/GaussianCurveFitter.java  |   2 +-
 .../math4/fitting/HarmonicCurveFitter.java  |   2 +-
 .../math4/fitting/WeightedObservedPoints.java   |   4 +-
 .../leastsquares/GaussNewtonOptimizer.java  |   2 +-
 .../leastsquares/LeastSquaresFactory.java   |   2 +-
 .../math4/genetics/AbstractListChromosome.java  |   2 +-
 .../math4/genetics/BinaryChromosome.java|   2 +-
 .../commons/math4/genetics/BinaryMutation.java  |   2 +-
 .../commons/math4/genetics/CycleCrossover.java  |   8 +-
 .../commons/math4/genetics/ListPopulation.java  |   2 +-
 .../commons/math4/genetics/NPointCrossover.java |   4 +-
 .../math4/genetics/OnePointCrossover.java   |   4 +-
 .../math4/genetics/OrderedCrossover.java|   8 +-
 .../commons/math4/genetics/RandomKey.java   |  16 +-
 .../math4/genetics/RandomKeyMutation.java   |   2 +-
 .../math4/genetics/TournamentSelection.java |   2 +-
 .../math4/genetics/UniformCrossover.java|   4 +-
 .../math4/geometry/enclosing/WelzlEncloser.java |   4 +-
 .../geometry/euclidean/oned/IntervalsSet.java   |  22 +-
 .../euclidean/oned/SubOrientedPoint.java|   6 +-
 .../euclidean/threed/FieldRotation.java |  40 ++--
 .../euclidean/threed/FieldVector3D.java |  42 ++--
 .../euclidean/threed/OutlineExtractor.java  |   2 +-
 .../euclidean/threed/PolyhedronsSet.java|   4 +-
 .../euclidean/threed/SphereGenerator.java   |  10 +-
 .../geometry/euclidean/threed/SubLine.java  |   2 +-
 .../geometry/euclidean/threed/SubPlane.java |  12 +-
 .../geometry/euclidean/twod/DiskGenerator.java  |   8 +-
 .../geometry/euclidean/twod/NestedLoops.java|   8 +-
 .../geometry/euclidean/twod/PolygonsSet.java|  18 +-
 .../math4/geometry/euclidean/twod/SubLine.java  |  14 +-
 .../twod/hull/AklToussaintHeuristic.java|   4 +-
 .../euclidean/twod/hull/ConvexHull2D.java   |   2 +-
 .../euclidean/twod/hull/MonotoneChain.java  |   8 +-
 .../geometry/partitioning/AbstractRegion.java   |  26 +--
 .../partitioning/AbstractSubHyperplane.java |   8 +-
 .../math4/geometry/partitioning/BSPTree.java|  34 +--
 .../geometry/partitioning/BoundaryBuilder.java  |  12 +-
 .../partitioning/BoundaryProjector.java |   4 +-
 .../geometry/partitioning/Characterization.java |   4 +-
 .../math4/geometry/partitioning/NodesSet.java   |   2 +-
 .../geometry/partitioning/RegionFactory.java|  14 +-
 .../math4/geometry/spherical/oned/ArcsSet.java  |  36 +--
 .../geometry/spherical/oned/SubLimitAngle.java  |   4 +-
 .../geometry/spherical/twod/EdgesBuilder.java   |   6 +-
 .../spherical/twod/PropertiesComputer.java  |   2 +-
 .../spherical/twod/SphericalPolygonsSet.java 

Re: commons-io git commit: Remove redundant type arguments.

2016-09-20 Thread Matt Sicker
Did the line ending change?

On 20 September 2016 at 01:59, Benedikt Ritter  wrote:

> Hello Gary,
>
> why has the whole file changed?
>
> Regards,
> Benedikt
>
>  schrieb am Di., 20. Sep. 2016 um 07:40 Uhr:
>
> > Repository: commons-io
> > Updated Branches:
> >   refs/heads/master 9ba9b49af -> 822bd135f
> >
> >
> > Remove redundant type arguments.
> >
> > Project: http://git-wip-us.apache.org/repos/asf/commons-io/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/commons-io/commit/
> 822bd135
> > Tree: http://git-wip-us.apache.org/repos/asf/commons-io/tree/822bd135
> > Diff: http://git-wip-us.apache.org/repos/asf/commons-io/diff/822bd135
> >
> > Branch: refs/heads/master
> > Commit: 822bd135f3a54b8fbeb23c313535b13c18198c3a
> > Parents: 9ba9b49
> > Author: Gary Gregory 
> > Authored: Mon Sep 19 22:40:29 2016 -0700
> > Committer: Gary Gregory 
> > Committed: Mon Sep 19 22:40:29 2016 -0700
> >
> > --
> >  .../commons/io/input/ObservableInputStream.java | 476
> +--
> >  1 file changed, 238 insertions(+), 238 deletions(-)
> > --
> >
> >
> >
> > http://git-wip-us.apache.org/repos/asf/commons-io/blob/
> 822bd135/src/main/java/org/apache/commons/io/input/
> ObservableInputStream.java
> > --
> > diff --git
> > a/src/main/java/org/apache/commons/io/input/ObservableInputStream.java
> > b/src/main/java/org/apache/commons/io/input/ObservableInputStream.java
> > index 7d13472..c580ba4 100644
> > --- a/src/main/java/org/apache/commons/io/input/
> ObservableInputStream.java
> > +++ b/src/main/java/org/apache/commons/io/input/
> ObservableInputStream.java
> > @@ -1,238 +1,238 @@
> > -/*
> > - * Licensed to the Apache Software Foundation (ASF) under one or more
> > - * contributor license agreements.  See the NOTICE file distributed with
> > - * this work for additional information regarding copyright ownership.
> > - * The ASF licenses this file to You under the Apache License, Version
> 2.0
> > - * (the "License"); you may not use this file except in compliance with
> > - * the License.  You may obtain a copy of the License at
> > - *
> > - *  http://www.apache.org/licenses/LICENSE-2.0
> > - *
> > - * Unless required by applicable law or agreed to in writing, software
> > - * distributed under the License is distributed on an "AS IS" BASIS,
> > - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> > implied.
> > - * See the License for the specific language governing permissions and
> > - * limitations under the License.
> > - */
> > -package org.apache.commons.io.input;
> > -
> > -import java.io.IOException;
> > -import java.io.InputStream;
> > -import java.security.MessageDigest;
> > -import java.util.ArrayList;
> > -import java.util.List;
> > -
> > -
> > -/**
> > - * The {@link ObservableInputStream} allows, that an InputStream may be
> > consumed
> > - * by other receivers, apart from the thread, which is reading it.
> > - * The other consumers are implemented as instances of {@link
> Observer}. A
> > - * typical application may be the generation of a {@link MessageDigest}
> > on the
> > - * fly.
> > - * {@code Note}: The {@link ObservableInputStream} is not
> thread
> > safe,
> > - * as instances of InputStream usually aren't.
> > - * If you must access the stream from multiple threads, then
> > synchronization, locking,
> > - * or a similar means must be used.
> > - * @see MessageDigestCalculatingInputStream
> > - */
> > -public class ObservableInputStream extends ProxyInputStream {
> > -public static abstract class Observer {
> > -/** Called to indicate, that {@link InputStream#read()} has been
> > invoked
> > - * on the {@link ObservableInputStream}, and will return a
> value.
> > - * @param pByte The value, which is being returned. This will
> > never be -1 (EOF),
> > - *because, in that case, {link #finished()} will be invoked
> > instead.
> > - */
> > -void data(int pByte) throws IOException {}
> > -/** Called to indicate, that {@link InputStream#read(byte[])},
> or
> > - * {@link InputStream#read(byte[], int, int)} have been called,
> > and are about to
> > - * invoke data.
> > - * @param pBuffer The byte array, which has been passed to the
> > read call, and where
> > - *   data has been stored.
> > - * @param pOffset The offset within the byte array, where data
> > has been stored.
> > - * @param pLength The number of bytes, which have been stored in
> > the byte array.
> > - */
> > -void data(byte[] pBuffer, int pOffset, int pLength) throws
> > IOException {}
> > -/** Called to indicate, that EOF has been seen on the underlying
> > stream.
> > -