[GitHub] cordova-firefoxos pull request: [CB-4556] Add a ./cordova/clean pr...
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/18#issuecomment-49261707 Thanks! I'll test tomorrow, need to setup a windows machine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-camera pull request: StatusBar Hidden Fix
GitHub user DarioDP opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/37 StatusBar Hidden Fix If I click cancel on imagePicker and I have status bar hidden it re-appear, so I have to hide it also in this case. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DarioDP/cordova-plugin-camera patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 commit 9f8318fb318a285183c11a6b214449e895984ca2 Author: DarioDP dari...@users.noreply.github.com Date: 2014-07-17T08:03:22Z StatusBar Hidden Fix If I click cancel on imagePicker and I have status bar hidden it re-appear, so I have to hide it also in this case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-globalization pull request: CB-7102 - Initial imple...
Github user zalun commented on a diff in the pull request: https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r15045656 --- Diff: www/firefoxos/locales/get_files.sh --- @@ -0,0 +1,8 @@ +while read line --- End diff -- it's mine to download all the files from different directories and create a date.ini file :) But it can be deleted - certainly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-globalization pull request: CB-7102 - Initial imple...
Github user zalun closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-globalization pull request: CB-7102 - Initial imple...
GitHub user zalun reopened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/17 CB-7102 - Initial implementation of globalization plugin in Firefox OS Partial. No currency and number functions You can merge this pull request into a Git repository by running: $ git pull https://github.com/zalun/cordova-plugin-globalization ffos-initial Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-globalization/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit d405203d86eaacb382f8dcab2a14678d8833da21 Author: Piotr Zalewa pi...@zalewa.info Date: 2014-07-07T09:48:15Z Initial implementation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-globalization pull request: CB-7102 - Initial imple...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: build configuration for AppVeyor
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/60 build configuration for AppVeyor You can merge this pull request into a Git repository by running: $ git pull https://github.com/sgrebnov/cordova-lib appveyor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 commit c6e2c6d1e745e8afc616684285c55f4465e8699c Author: sgrebnov v-seg...@microsoft.com Date: 2014-07-17T10:48:01Z build configuration for AppVeyor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: build configurations for Travis
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/59 build configurations for Travis You can merge this pull request into a Git repository by running: $ git pull https://github.com/sgrebnov/cordova-lib travis Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit a44cc36e7ed8c886ffaa3f4e564dec233b24928c Author: sgrebnov v-seg...@microsoft.com Date: 2014-07-17T10:47:07Z build configurations for Travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
RE: Add build status to github
I've sent separate PRs for Travis and AppVeyor build configurations: https://github.com/apache/cordova-lib/pull/59 https://github.com/apache/cordova-lib/pull/60 #1 Both Travis and AppVeyor use very similar .yml based configuration files which are very easy to use/understand. #2 AppVeyor showed me Windows specific test failure related to paths so I think we should tun tests on both Linux and Windows https://ci.appveyor.com/project/sgrebnov/cordova-lib/build/1.0.2 1) lazy_load module custom method (loads custom cordova libs) local paths for libraries should return the local path, no symlink 862 Message: 863 Expected '\some\random\lib' to equal '/some/random/lib'. * PS. I have more failures on my local machine - will investigate this #3 Travis build sample https://travis-ci.org/sgrebnov/cordova-lib/builds/30154663 #4 Sample home page with both build badges integrated: https://github.com/sgrebnov/cordova-lib/ #5 Pull Requests. Tests are run on both services but github shows information for the only one of them - message is changed as per response from the build service, the last message is showed (not sure how it works if we have failure + then success - to be investigated). https://github.com/sgrebnov/cordova-lib/pull/4 Thx! Sergey -Original Message- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Tuesday, July 15, 2014 9:42 PM To: dev@cordova.apache.org Subject: Re: Add build status to github I see, it looks like our testing infra is going to be redunant/distributed regardless. (travis + X) No sense in fighting it! On Tue, Jul 15, 2014 at 9:31 AM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: Don't we still need Travis to drive the Saucelabs test? P.S: I have been investigating to see if I could use Appium to run Medic tests. No Windows support yet though :( -Original Message- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Tuesday, July 15, 2014 9:18 AM To: dev@cordova.apache.org Subject: RE: Add build status to github https://docs.saucelabs.com/reference/status-images/ On Jul 15, 2014 9:17 AM, Brian LeRoux b...@brian.io wrote: Or we could use SauceLabs (for all) On Jul 15, 2014 9:16 AM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: We would need both right? For covering Windows and Linux platforms for lib to build/run. -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Tuesday, July 15, 2014 7:55 AM To: dev@cordova.apache.org Subject: Re: Add build status to github Ok, let's ask here. Does anybody have any strong preferences for either AppVeyor or TravisCI or both for cordova-lib? note, this is only about running npm test in cordova-lib.
Change background color of Android Cordova app
Hello, how can I change background color, which is visible during orientation change until WebView is correctly resized. I specified it more at http:// stackoverflow.com/questions/24601226/change-background-color-of-app-visible- during-resizing-webview-due-to-device-ori But, it look stackoverflowers don't know solution to this problem, so I post it here. :-) I hope, someone have had different problem ;-)
[GitHub] cordova-mobile-spec pull request: Fix arguments order in contacts....
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/72#issuecomment-49305119 Closing this PR as it is no longer valid. The arguments order has been restored: https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js#L44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-mobile-spec pull request: Fix arguments order in contacts....
Github user mbektchiev closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: build configurations for Travis
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/59#issuecomment-49307412 Looks good. What's needed in terms of setting up the hooks on GitHub side? Do we need in INFRA ticket for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Add build status to github
+1 for running both, Travis and AppVeyor. What's needed in terms of setting up the hooks on GitHub side? Do we need in INFRA ticket for this? On Thu, Jul 17, 2014 at 6:56 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I've sent separate PRs for Travis and AppVeyor build configurations: https://github.com/apache/cordova-lib/pull/59 https://github.com/apache/cordova-lib/pull/60 #1 Both Travis and AppVeyor use very similar .yml based configuration files which are very easy to use/understand. #2 AppVeyor showed me Windows specific test failure related to paths so I think we should tun tests on both Linux and Windows https://ci.appveyor.com/project/sgrebnov/cordova-lib/build/1.0.2 1) lazy_load module custom method (loads custom cordova libs) local paths for libraries should return the local path, no symlink 862 Message: 863 Expected '\some\random\lib' to equal '/some/random/lib'. * PS. I have more failures on my local machine - will investigate this #3 Travis build sample https://travis-ci.org/sgrebnov/cordova-lib/builds/30154663 #4 Sample home page with both build badges integrated: https://github.com/sgrebnov/cordova-lib/ #5 Pull Requests. Tests are run on both services but github shows information for the only one of them - message is changed as per response from the build service, the last message is showed (not sure how it works if we have failure + then success - to be investigated). https://github.com/sgrebnov/cordova-lib/pull/4 Thx! Sergey -Original Message- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Tuesday, July 15, 2014 9:42 PM To: dev@cordova.apache.org Subject: Re: Add build status to github I see, it looks like our testing infra is going to be redunant/distributed regardless. (travis + X) No sense in fighting it! On Tue, Jul 15, 2014 at 9:31 AM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: Don't we still need Travis to drive the Saucelabs test? P.S: I have been investigating to see if I could use Appium to run Medic tests. No Windows support yet though :( -Original Message- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Tuesday, July 15, 2014 9:18 AM To: dev@cordova.apache.org Subject: RE: Add build status to github https://docs.saucelabs.com/reference/status-images/ On Jul 15, 2014 9:17 AM, Brian LeRoux b...@brian.io wrote: Or we could use SauceLabs (for all) On Jul 15, 2014 9:16 AM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: We would need both right? For covering Windows and Linux platforms for lib to build/run. -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Tuesday, July 15, 2014 7:55 AM To: dev@cordova.apache.org Subject: Re: Add build status to github Ok, let's ask here. Does anybody have any strong preferences for either AppVeyor or TravisCI or both for cordova-lib? note, this is only about running npm test in cordova-lib.
RE: Add build status to github
We require someone with github admin rights to login to both services using github account and activate build for cordova-lib repo. The rest of the work will be done by the services. Thx! Sergey -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Thursday, July 17, 2014 5:42 PM To: dev@cordova.apache.org Subject: Re: Add build status to github +1 for running both, Travis and AppVeyor. What's needed in terms of setting up the hooks on GitHub side? Do we need in INFRA ticket for this? On Thu, Jul 17, 2014 at 6:56 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I've sent separate PRs for Travis and AppVeyor build configurations: https://github.com/apache/cordova-lib/pull/59 https://github.com/apache/cordova-lib/pull/60 #1 Both Travis and AppVeyor use very similar .yml based configuration files which are very easy to use/understand. #2 AppVeyor showed me Windows specific test failure related to paths so I think we should tun tests on both Linux and Windows https://ci.appveyor.com/project/sgrebnov/cordova-lib/build/1.0.2 1) lazy_load module custom method (loads custom cordova libs) local paths for libraries should return the local path, no symlink 862 Message: 863 Expected '\some\random\lib' to equal '/some/random/lib'. * PS. I have more failures on my local machine - will investigate this #3 Travis build sample https://travis-ci.org/sgrebnov/cordova-lib/builds/30154663 #4 Sample home page with both build badges integrated: https://github.com/sgrebnov/cordova-lib/ #5 Pull Requests. Tests are run on both services but github shows information for the only one of them - message is changed as per response from the build service, the last message is showed (not sure how it works if we have failure + then success - to be investigated). https://github.com/sgrebnov/cordova-lib/pull/4 Thx! Sergey -Original Message- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Tuesday, July 15, 2014 9:42 PM To: dev@cordova.apache.org Subject: Re: Add build status to github I see, it looks like our testing infra is going to be redunant/distributed regardless. (travis + X) No sense in fighting it! On Tue, Jul 15, 2014 at 9:31 AM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: Don't we still need Travis to drive the Saucelabs test? P.S: I have been investigating to see if I could use Appium to run Medic tests. No Windows support yet though :( -Original Message- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Tuesday, July 15, 2014 9:18 AM To: dev@cordova.apache.org Subject: RE: Add build status to github https://docs.saucelabs.com/reference/status-images/ On Jul 15, 2014 9:17 AM, Brian LeRoux b...@brian.io wrote: Or we could use SauceLabs (for all) On Jul 15, 2014 9:16 AM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: We would need both right? For covering Windows and Linux platforms for lib to build/run. -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Tuesday, July 15, 2014 7:55 AM To: dev@cordova.apache.org Subject: Re: Add build status to github Ok, let's ask here. Does anybody have any strong preferences for either AppVeyor or TravisCI or both for cordova-lib? note, this is only about running npm test in cordova-lib.
RE: Change background color of Android Cordova app
I suppose this could be done by backgroundColor preference (config.xml) preference name=backgroundColor value=0xFFF / Thx! Sergey -Original Message- From: Jan Velecký [mailto:vve...@seznam.cz] Sent: Thursday, July 17, 2014 4:18 PM To: dev@cordova.apache.org Subject: Change background color of Android Cordova app Hello, how can I change background color, which is visible during orientation change until WebView is correctly resized. I specified it more at http:// stackoverflow.com/questions/24601226/change-background-color-of-app-visible- during-resizing-webview-due-to-device-ori But, it look stackoverflowers don't know solution to this problem, so I post it here. :-) I hope, someone have had different problem ;-)
Re: Change background color of Android Cordova app
I was actually looking at this recently and found that the backgroundColor preference is not being applied to the actual WebView element. Didn't want to change it because I was changing other things at the time, but likely this is just a bug that we should fix. Filed an issue: https://issues.apache.org/jira/browse/CB-7159 On Thu, Jul 17, 2014 at 9:56 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I suppose this could be done by backgroundColor preference (config.xml) preference name=backgroundColor value=0xFFF / Thx! Sergey -Original Message- From: Jan Velecký [mailto:vve...@seznam.cz] Sent: Thursday, July 17, 2014 4:18 PM To: dev@cordova.apache.org Subject: Change background color of Android Cordova app Hello, how can I change background color, which is visible during orientation change until WebView is correctly resized. I specified it more at http:// stackoverflow.com/questions/24601226/change-background-color-of-app-visible- during-resizing-webview-due-to-device-ori But, it look stackoverflowers don't know solution to this problem, so I post it here. :-) I hope, someone have had different problem ;-)
Re: Change background color of Android Cordova app
The WebView element isn't supposed to have the backgroundColor, it's the view behind the WebView that's supposed to have the backgroundColor. Also, I haven't seen this behaviour on any of the tests that we done. Unless we can reproduce the issue, we can't fix it, and shouldn't just throw things over the wall. On Thu, Jul 17, 2014 at 7:46 AM, Andrew Grieve agri...@chromium.org wrote: I was actually looking at this recently and found that the backgroundColor preference is not being applied to the actual WebView element. Didn't want to change it because I was changing other things at the time, but likely this is just a bug that we should fix. Filed an issue: https://issues.apache.org/jira/browse/CB-7159 On Thu, Jul 17, 2014 at 9:56 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I suppose this could be done by backgroundColor preference (config.xml) preference name=backgroundColor value=0xFFF / Thx! Sergey -Original Message- From: Jan Velecký [mailto:vve...@seznam.cz] Sent: Thursday, July 17, 2014 4:18 PM To: dev@cordova.apache.org Subject: Change background color of Android Cordova app Hello, how can I change background color, which is visible during orientation change until WebView is correctly resized. I specified it more at http:// stackoverflow.com/questions/24601226/change-background-color-of-app-visible- during-resizing-webview-due-to-device-ori But, it look stackoverflowers don't know solution to this problem, so I post it here. :-) I hope, someone have had different problem ;-)
Re: Change background color of Android Cordova app
Try setting opacity:0 on the html tag and you can reproduce white showing instead of your backgroundColor. On Thu, Jul 17, 2014 at 10:54 AM, Joe Bowser bows...@gmail.com wrote: The WebView element isn't supposed to have the backgroundColor, it's the view behind the WebView that's supposed to have the backgroundColor. Also, I haven't seen this behaviour on any of the tests that we done. Unless we can reproduce the issue, we can't fix it, and shouldn't just throw things over the wall. On Thu, Jul 17, 2014 at 7:46 AM, Andrew Grieve agri...@chromium.org wrote: I was actually looking at this recently and found that the backgroundColor preference is not being applied to the actual WebView element. Didn't want to change it because I was changing other things at the time, but likely this is just a bug that we should fix. Filed an issue: https://issues.apache.org/jira/browse/CB-7159 On Thu, Jul 17, 2014 at 9:56 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I suppose this could be done by backgroundColor preference (config.xml) preference name=backgroundColor value=0xFFF / Thx! Sergey -Original Message- From: Jan Velecký [mailto:vve...@seznam.cz] Sent: Thursday, July 17, 2014 4:18 PM To: dev@cordova.apache.org Subject: Change background color of Android Cordova app Hello, how can I change background color, which is visible during orientation change until WebView is correctly resized. I specified it more at http:// stackoverflow.com/questions/24601226/change-background-color-of-app-visible- during-resizing-webview-due-to-device-ori But, it look stackoverflowers don't know solution to this problem, so I post it here. :-) I hope, someone have had different problem ;-)
Re: Change background color of Android Cordova app
So, this is only an issue if you set the html tag opacity to 0? Why would anyone do this? On Thu, Jul 17, 2014 at 7:56 AM, Andrew Grieve agri...@chromium.org wrote: Try setting opacity:0 on the html tag and you can reproduce white showing instead of your backgroundColor. On Thu, Jul 17, 2014 at 10:54 AM, Joe Bowser bows...@gmail.com wrote: The WebView element isn't supposed to have the backgroundColor, it's the view behind the WebView that's supposed to have the backgroundColor. Also, I haven't seen this behaviour on any of the tests that we done. Unless we can reproduce the issue, we can't fix it, and shouldn't just throw things over the wall. On Thu, Jul 17, 2014 at 7:46 AM, Andrew Grieve agri...@chromium.org wrote: I was actually looking at this recently and found that the backgroundColor preference is not being applied to the actual WebView element. Didn't want to change it because I was changing other things at the time, but likely this is just a bug that we should fix. Filed an issue: https://issues.apache.org/jira/browse/CB-7159 On Thu, Jul 17, 2014 at 9:56 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I suppose this could be done by backgroundColor preference (config.xml) preference name=backgroundColor value=0xFFF / Thx! Sergey -Original Message- From: Jan Velecký [mailto:vve...@seznam.cz] Sent: Thursday, July 17, 2014 4:18 PM To: dev@cordova.apache.org Subject: Change background color of Android Cordova app Hello, how can I change background color, which is visible during orientation change until WebView is correctly resized. I specified it more at http:// stackoverflow.com/questions/24601226/change-background-color-of-app-visible- during-resizing-webview-due-to-device-ori But, it look stackoverflowers don't know solution to this problem, so I post it here. :-) I hope, someone have had different problem ;-)
Re: Pluggable webview design thread
Thanks Ian! Probably a good idea to discuss the heck of this. On Wed, Jul 16, 2014 at 4:23 PM, Ian Clelland iclell...@chromium.org wrote: [Opening this discussion up on the list, as it had previously been the domain of private conversations and limited-audience discussions] On the 4.0.x branch, we're developing an API for pluggable webviews. With Cordova-Android 4.0.0, we are going to be providing a reference implementation, AndroidWebView, which uses the system webview, and should be externally identical to the webview provided by Cordova 3.x (and earlier). The API is going to be made available for third parties to implement compatible WebViews against, such as Crosswalk and GeckoView. Since third parties are going to be coding against this API, it will be difficult to change once released, so we'd like to get it right the first time. This email thread is about defining that API, and getting consensus so that we can start to stabilize the 4.0.x branch. In the interest of backwards-compatibility, and of feature-parity with previous releases, I think that these things are important (but are all up for discussion): - The AndroidWebView implementation should be (i.e. java:extends) an actual android.webkit.WebView, for the sake of existing applications which assume that this is the case. - New webviews shouldn't have that restriction, since they *aren't* android.webkit.WebView's, there's no reason for them to extend one. - Because of Java's lack of multiple inheritance, this kinda means that CordovaWebView needs to be an interface. There are two clients that I think we need to consider: 1. CordovaActivity 2. Plugins Plugins are the more important case I think, because using plugins doesn't mean you understand how to edit your java. For CordovaActivity however, I think so long as we are backwards compatible with the default template, then other changes are more fair-game because they affect only developers who have some understanding of Java anyways. For AndroidWebView extending WebView, I don't see how doing this helps with backwards compatibility. Both CordovaActivity and Plugins hold a reference to the webview as a CordovaWebView interface, and so the inheritance structure of the implementing class is unknown to them. E.g. They would need to explicitly cast CordovaWebView - AndroidWebView to exploit the fact that it extends WebView. Might as well have the call .getView() so that their code works with any WebView. - It was previously possible for a subclass of CordovaActivity to provide a makeWebViewClient and/or makeChromeClient method, to override the default construction of these objects. This is a public API, for users who have specific needs from their webview, and we should maintain that. - By default, those methods should just defer to the instantiated WebView to create its own client objects (do the right thing), but it *should* be overridable by the application developer to provide whatever objects are appropriate for *their* application, without having to hack on the webview code. - It's okay that app developers would have to know the concrete class of the client objects they are creating. It's their app, and they know what engine they are choosing to use. - Making CordovaActivity do the right thing by default does involve some complicated logic in CordovaActivity and the engine WebViews, but I think it's worth it. - Before commit 'efcedabe', this was previously implemented. So - reason I think these functions don't make sense: they only apply to when the WebView is an AndroidWebView. Each engine has their own set of helper classes. What we *could* do is: - Use an instanceof check to see if the webview is an AndroidWebView - Only if it is, call these make*Client() functions However, I think this is a pretty confusing thing to have these hooks if they apply only to one engine. Instead, subclasses can override makeWebView() and hook up whatever Client subclasses they want as a part of that (or do any other initialization of it that they want). This means if anyone has overridden the make*Client() methods now, they'll need to update their code, but if this is the case, then we're dealing with people that already understand how to write Java, and the change is quite mechanical. I'm going to write up the actual API as I see it being implemented, and then we can discuss that to. I'll post it back to this thread. Ian
Re: Change background color of Android Cordova app
I did it to test whether the backgroundColor preference was working. Do you know another way to test that preference? On Thu, Jul 17, 2014 at 11:12 AM, Joe Bowser bows...@gmail.com wrote: So, this is only an issue if you set the html tag opacity to 0? Why would anyone do this? On Thu, Jul 17, 2014 at 7:56 AM, Andrew Grieve agri...@chromium.org wrote: Try setting opacity:0 on the html tag and you can reproduce white showing instead of your backgroundColor. On Thu, Jul 17, 2014 at 10:54 AM, Joe Bowser bows...@gmail.com wrote: The WebView element isn't supposed to have the backgroundColor, it's the view behind the WebView that's supposed to have the backgroundColor. Also, I haven't seen this behaviour on any of the tests that we done. Unless we can reproduce the issue, we can't fix it, and shouldn't just throw things over the wall. On Thu, Jul 17, 2014 at 7:46 AM, Andrew Grieve agri...@chromium.org wrote: I was actually looking at this recently and found that the backgroundColor preference is not being applied to the actual WebView element. Didn't want to change it because I was changing other things at the time, but likely this is just a bug that we should fix. Filed an issue: https://issues.apache.org/jira/browse/CB-7159 On Thu, Jul 17, 2014 at 9:56 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I suppose this could be done by backgroundColor preference (config.xml) preference name=backgroundColor value=0xFFF / Thx! Sergey -Original Message- From: Jan Velecký [mailto:vve...@seznam.cz] Sent: Thursday, July 17, 2014 4:18 PM To: dev@cordova.apache.org Subject: Change background color of Android Cordova app Hello, how can I change background color, which is visible during orientation change until WebView is correctly resized. I specified it more at http:// stackoverflow.com/questions/24601226/change-background-color-of-app-visible- during-resizing-webview-due-to-device-ori But, it look stackoverflowers don't know solution to this problem, so I post it here. :-) I hope, someone have had different problem ;-)
Re: Change background color of Android Cordova app
Delay the loading of the URL without a screenshot? Also, you could run the manual test application in test that's marked Test Background Color. This isn't automated because it would require the inclusion of a third party library like Robotium, and there's no way to programmatically test the colour blue that's worth writing. (Seriously, it'd be yet another library that'd take the screenshot within the 2 second delay, and then process the image to see if the pixels are blue, a non-trivial amount of work for something that someone can do when they need to.) On Thu, Jul 17, 2014 at 8:23 AM, Andrew Grieve agri...@chromium.org wrote: I did it to test whether the backgroundColor preference was working. Do you know another way to test that preference? On Thu, Jul 17, 2014 at 11:12 AM, Joe Bowser bows...@gmail.com wrote: So, this is only an issue if you set the html tag opacity to 0? Why would anyone do this? On Thu, Jul 17, 2014 at 7:56 AM, Andrew Grieve agri...@chromium.org wrote: Try setting opacity:0 on the html tag and you can reproduce white showing instead of your backgroundColor. On Thu, Jul 17, 2014 at 10:54 AM, Joe Bowser bows...@gmail.com wrote: The WebView element isn't supposed to have the backgroundColor, it's the view behind the WebView that's supposed to have the backgroundColor. Also, I haven't seen this behaviour on any of the tests that we done. Unless we can reproduce the issue, we can't fix it, and shouldn't just throw things over the wall. On Thu, Jul 17, 2014 at 7:46 AM, Andrew Grieve agri...@chromium.org wrote: I was actually looking at this recently and found that the backgroundColor preference is not being applied to the actual WebView element. Didn't want to change it because I was changing other things at the time, but likely this is just a bug that we should fix. Filed an issue: https://issues.apache.org/jira/browse/CB-7159 On Thu, Jul 17, 2014 at 9:56 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I suppose this could be done by backgroundColor preference (config.xml) preference name=backgroundColor value=0xFFF / Thx! Sergey -Original Message- From: Jan Velecký [mailto:vve...@seznam.cz] Sent: Thursday, July 17, 2014 4:18 PM To: dev@cordova.apache.org Subject: Change background color of Android Cordova app Hello, how can I change background color, which is visible during orientation change until WebView is correctly resized. I specified it more at http:// stackoverflow.com/questions/24601226/change-background-color-of-app-visible- during-resizing-webview-due-to-device-ori But, it look stackoverflowers don't know solution to this problem, so I post it here. :-) I hope, someone have had different problem ;-)
Re: sticker?
I'm speaking about Cordova on two upcoming conferences. [1] [2] I would also like to give away some cordova/phonegap swag to attendees. I always like to finish with ... here are different ways to contribute to Cordova..., here are some stickers boom! How do we order some swag, and does ASF cover the cost? [1]: NCDevCon (Sep 13-14) Raleigh, NC http://ncdevcon.com [2] All Things Open (Oct 22-23) Raleigh, NC http://allthingsopen.org --Carlos On Wed, Jul 16, 2014 at 5:42 PM, Marcel Kinard cmarc...@gmail.com wrote: Are there Cordova stickers available for purchase on Stickermule or other vendors? Or does setup need to be done from scratch? I’m just looking for a few for local use. I found this thread: [1] but don’t see any Cordova items in the Stickermule marketplace. 1: http://markmail.org/message/digaol7x74nzxsmo -- Carlos Santana csantan...@gmail.com
3.6.0 Release Discussion, Schedule + Planning
As has been mentioned in a few other threads, Windows 8.1 and WP 8.1 Universal apps will be supported in 3.6.0. This requires a release/publish of both the tooling, and the platforms as we have dependencies between them. Parashuram and I discussed this last week, and MSOpenTech would like to take a more active role in this release, as would I. I would like to assume the role of release manager this time around, and work closely with Sergey so we both can review/troubleshoot the process from a windows perspective. We will of course be getting help from the expert Steve, after he is back from vacay next week. My goal is to wrap up some loose ends today and tomorrow, and begin this process next Monday, hopefully starting a vote thread by the 24th. Thoughts? Cheers, Jesse @purplecabbage risingj.com
Re: 3.6.0 Release Discussion, Schedule + Planning
Thanks for volunteering! On Thu, Jul 17, 2014 at 1:49 PM, Jesse purplecabb...@gmail.com wrote: As has been mentioned in a few other threads, Windows 8.1 and WP 8.1 Universal apps will be supported in 3.6.0. This requires a release/publish of both the tooling, and the platforms as we have dependencies between them. Parashuram and I discussed this last week, and MSOpenTech would like to take a more active role in this release, as would I. I would like to assume the role of release manager this time around, and work closely with Sergey so we both can review/troubleshoot the process from a windows perspective. We will of course be getting help from the expert Steve, after he is back from vacay next week. My goal is to wrap up some loose ends today and tomorrow, and begin this process next Monday, hopefully starting a vote thread by the 24th. Thoughts? Cheers, Jesse @purplecabbage risingj.com
RE: Pluggable webview design thread
Ian, thanks for open this thread. Does the API design consider cookie sharing use case? For example, in current FileTransfer plugin, it uses android.webkit.CookieManager directly. It will cause issue when using third party webviews, such as Crosswalk. -ningxin -Original Message- From: iclell...@google.com [mailto:iclell...@google.com] On Behalf Of Ian Clelland Sent: Wednesday, July 16, 2014 1:23 PM To: dev@cordova.apache.org Subject: Pluggable webview design thread [Opening this discussion up on the list, as it had previously been the domain of private conversations and limited-audience discussions] On the 4.0.x branch, we're developing an API for pluggable webviews. With Cordova-Android 4.0.0, we are going to be providing a reference implementation, AndroidWebView, which uses the system webview, and should be externally identical to the webview provided by Cordova 3.x (and earlier). The API is going to be made available for third parties to implement compatible WebViews against, such as Crosswalk and GeckoView. Since third parties are going to be coding against this API, it will be difficult to change once released, so we'd like to get it right the first time. This email thread is about defining that API, and getting consensus so that we can start to stabilize the 4.0.x branch. In the interest of backwards-compatibility, and of feature-parity with previous releases, I think that these things are important (but are all up for discussion): - The AndroidWebView implementation should be (i.e. java:extends) an actual android.webkit.WebView, for the sake of existing applications which assume that this is the case. - New webviews shouldn't have that restriction, since they *aren't* android.webkit.WebView's, there's no reason for them to extend one. - Because of Java's lack of multiple inheritance, this kinda means that CordovaWebView needs to be an interface. - It was previously possible for a subclass of CordovaActivity to provide a makeWebViewClient and/or makeChromeClient method, to override the default construction of these objects. This is a public API, for users who have specific needs from their webview, and we should maintain that. - By default, those methods should just defer to the instantiated WebView to create its own client objects (do the right thing), but it *should* be overridable by the application developer to provide whatever objects are appropriate for *their* application, without having to hack on the webview code. - It's okay that app developers would have to know the concrete class of the client objects they are creating. It's their app, and they know what engine they are choosing to use. - Making CordovaActivity do the right thing by default does involve some complicated logic in CordovaActivity and the engine WebViews, but I think it's worth it. - Before commit 'efcedabe', this was previously implemented. I'm going to write up the actual API as I see it being implemented, and then we can discuss that to. I'll post it back to this thread. Ian
Re: 3.6.0 Release Discussion, Schedule + Planning
Glad to see some windows love :-). And again thanks to Jesse for being a great platform leader and the folks from MSOpenTech keep the good stuff coming On Thu, Jul 17, 2014 at 1:59 PM, Michal Mocny mmo...@chromium.org wrote: Thanks for volunteering! On Thu, Jul 17, 2014 at 1:49 PM, Jesse purplecabb...@gmail.com wrote: As has been mentioned in a few other threads, Windows 8.1 and WP 8.1 Universal apps will be supported in 3.6.0. This requires a release/publish of both the tooling, and the platforms as we have dependencies between them. Parashuram and I discussed this last week, and MSOpenTech would like to take a more active role in this release, as would I. I would like to assume the role of release manager this time around, and work closely with Sergey so we both can review/troubleshoot the process from a windows perspective. We will of course be getting help from the expert Steve, after he is back from vacay next week. My goal is to wrap up some loose ends today and tomorrow, and begin this process next Monday, hopefully starting a vote thread by the 24th. Thoughts? Cheers, Jesse @purplecabbage risingj.com -- Carlos Santana csantan...@gmail.com
[GitHub] cordova-lib pull request: CB-7124: Fix `cordova platform add plat...
GitHub user pascalw opened a pull request: https://github.com/apache/cordova-lib/pull/61 CB-7124: Fix `cordova platform add platform@version` with `--usegit` https://issues.apache.org/jira/browse/CB-7124 The `cordova_git` function didn't consider that platform strings can contain `@version` annotations. I refactored the code a bit to keep the `@version` check in a single place, namely in the `Platform` object. Please let me know if this patch is acceptable in this form. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pascalw/cordova-lib CB-7124 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit 3ae36ea2011d092769ca72db6b1e258f69a647a5 Author: Pascal Widdershoven pas...@kabisa.nl Date: 2014-07-12T14:32:47Z Wrap the cordova platform string in Platform object with name version This prevents having to duplicate the check wether or not the platform string specifies a version or not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-battery-status pull request: CB-6957 Ported Battery...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-device-motion pull request: CB-7160 manual tests fo...
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/14 CB-7160 manual tests for accelerometer Pulled out the changes to plugin.xml and added the manual tests. Can this be merged into cdvtest, and then cdvtest into master? You can merge this pull request into a Git repository by running: $ git pull https://github.com/stacic/cordova-plugin-device-motion CB-7160 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device-motion/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit 7880ada99b453799d5083b6ad3dc87b094a498fb Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-07-17T19:46:14Z CB-7160 added manual tests commit c16c6e426bcf8359b721ea3360ab8c9a0eb94119 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-07-17T19:47:20Z Removed js-module for tests from plugin.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-media pull request: CB-6963 Port Media automated te...
Github user martincgg closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-7094 Ported File manual tests
Github user martincgg closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-vibration pull request: CB-6963 Ported Vibration au...
Github user martincgg closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-device-orientation pull request: CB-6960
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/11 CB-6960 All tests for device-orientation ported to plugin-test-framework You can merge this pull request into a Git repository by running: $ git pull https://github.com/stacic/cordova-plugin-device-orientation CB-6960 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device-orientation/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit 6e44a4a9d21ea86b4af5063c5cfa4577cf7d8ff3 Author: Samir Silva ssric...@gmail.com Date: 2014-06-30T18:31:36Z [CB-6960] Port compass tests to plugin-test-framework Ported the compass plugin (device-orientation) from mobile-spec to the new test framework with Jasmine 2.0 -Added test folder -Added test.js file inside the test folder. commit 7457cba1c08cf2727f9c03eba5e376098be3c071 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-07-17T20:20:25Z CB-6960 Added manual tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file-transfer pull request: CB-6961 port file-trans...
Github user stacic commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/34#issuecomment-49363842 Closing momentarily to make an additional style change and rebase... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-7124: Fix `cordova platform add plat...
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/61#issuecomment-49363885 Looks good. Merging. You don't yet have commit rights, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file-transfer pull request: CB-6961 port file-trans...
Github user stacic closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-device-orientation pull request: [CB-6960] Port com...
Github user SSRico closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-7124: Fix `cordova platform add plat...
Github user pascalw commented on the pull request: https://github.com/apache/cordova-lib/pull/61#issuecomment-49365253 @kamrik awesome. I don't have commits right no. My ICLA did got acknowledged today so that should be good right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-7124: Fix `cordova platform add plat...
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/61#issuecomment-49366276 Yep, I can see you on the ICLA list here http://people.apache.org/committer-index.html Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-7124: Fix `cordova platform add plat...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Monthly Cordova hangouts
Or even people who doesn't contribute in code as of now, but still participates in the project somehow... What's the scope of the meetings, considering it's being discussed on an open mailing list? 2014-07-17 1:44 GMT-03:00 Puneet Kaur puneet.gk...@gmail.com: Hey all, Just wished to ask if the newcomers ( like me ) who wish to contribute to the code also join in the hangout or only the committers are allowed ? On Thu, Jul 17, 2014 at 3:34 AM, Tommy Williams to...@devgeeks.org wrote: Absolutely. 1pm/4pm in the USA is just 6am here. Barely even have to get up early. :) On 17 Jul 2014 04:39, Shazron shaz...@gmail.com wrote: If Tommy doesn't mind, my suggestion for the hangout is to have it during the window of PST and EST working hours :/ It's unfortunate that we can't cover everyone worldwide, but this time window captures the majority of the committers. We could do one once in a while to accommodate the other half of the world, but we need to plan for that way ahead of time so everyone can pencil it in to their calendars. On Tue, Jul 15, 2014 at 7:24 PM, Michal Mocny mmo...@chromium.org wrote: I deleted the event to make it clear it was cancelled. It was late notice for everyone, but there would not have been enough faces to be worth covering topics. -- *Frederico Galvão* Diretor de Tecnologia PontoGet Inovação Web ( +55(62) 8131-5720 * www.pontoget.com.br http://www.pontoget.com/
[GitHub] cordova-plugin-vibration pull request: CB-6963 Ported Vibration au...
GitHub user martincgg reopened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/14 CB-6963 Ported Vibration automated manual tests Ported tests from Mobilespec. Jasmine version: ported from v1.3 to v2.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-plugin-vibration CB-6963 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-vibration/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit 53760ccbf19964d20e9a6693cb1f52050f2c5391 Author: Martin Gonzalez martin.c.glez.g...@gmail.com Date: 2014-07-15T20:33:20Z CB-6963, ported vibration automated manual tests Ported tests from mobilespec. Jasmine version: ported from v1.3 to v2.0 commit d19f7539b2add88db649aa1f4fdbe5b032029f3f Author: Martin Gonzalez martin.c.glez.g...@gmail.com Date: 2014-07-15T22:41:54Z Adding comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Monthly Cordova hangouts
I'd personally prefer it if we limited it to committers. It's extremely difficult to fit all the current committers in these hangouts as it is. On Thu, Jul 17, 2014 at 2:12 PM, Frederico Galvão frederico.gal...@pontoget.com.br wrote: Or even people who doesn't contribute in code as of now, but still participates in the project somehow... What's the scope of the meetings, considering it's being discussed on an open mailing list? 2014-07-17 1:44 GMT-03:00 Puneet Kaur puneet.gk...@gmail.com: Hey all, Just wished to ask if the newcomers ( like me ) who wish to contribute to the code also join in the hangout or only the committers are allowed ? On Thu, Jul 17, 2014 at 3:34 AM, Tommy Williams to...@devgeeks.org wrote: Absolutely. 1pm/4pm in the USA is just 6am here. Barely even have to get up early. :) On 17 Jul 2014 04:39, Shazron shaz...@gmail.com wrote: If Tommy doesn't mind, my suggestion for the hangout is to have it during the window of PST and EST working hours :/ It's unfortunate that we can't cover everyone worldwide, but this time window captures the majority of the committers. We could do one once in a while to accommodate the other half of the world, but we need to plan for that way ahead of time so everyone can pencil it in to their calendars. On Tue, Jul 15, 2014 at 7:24 PM, Michal Mocny mmo...@chromium.org wrote: I deleted the event to make it clear it was cancelled. It was late notice for everyone, but there would not have been enough faces to be worth covering topics. -- *Frederico Galvão* Diretor de Tecnologia PontoGet Inovação Web ( +55(62) 8131-5720 * www.pontoget.com.br http://www.pontoget.com/
Re: Monthly Cordova hangouts
All are welcome, we are an open project. Currently we are using Google Hangouts, so video slots are limited to 10 and we would like to reserve that for committers talking about the agenda (usually multiple committers in a geographical location gather together and use one slot), and we may have to limit these video slots. There is also a view-only YouTube link (Hangouts on Air) for the others that only want to lurk. Example: https://www.youtube.com/watch?v=57MvuZctrOo and this will be communicated to dev@ before the actual meeting. http://wiki.apache.org/cordova/Google%20Hangout%20Discussion%20Notes On Thu, Jul 17, 2014 at 2:12 PM, Frederico Galvão frederico.gal...@pontoget.com.br wrote: Or even people who doesn't contribute in code as of now, but still participates in the project somehow... What's the scope of the meetings, considering it's being discussed on an open mailing list? 2014-07-17 1:44 GMT-03:00 Puneet Kaur puneet.gk...@gmail.com: Hey all, Just wished to ask if the newcomers ( like me ) who wish to contribute to the code also join in the hangout or only the committers are allowed ? On Thu, Jul 17, 2014 at 3:34 AM, Tommy Williams to...@devgeeks.org wrote: Absolutely. 1pm/4pm in the USA is just 6am here. Barely even have to get up early. :) On 17 Jul 2014 04:39, Shazron shaz...@gmail.com wrote: If Tommy doesn't mind, my suggestion for the hangout is to have it during the window of PST and EST working hours :/ It's unfortunate that we can't cover everyone worldwide, but this time window captures the majority of the committers. We could do one once in a while to accommodate the other half of the world, but we need to plan for that way ahead of time so everyone can pencil it in to their calendars. On Tue, Jul 15, 2014 at 7:24 PM, Michal Mocny mmo...@chromium.org wrote: I deleted the event to make it clear it was cancelled. It was late notice for everyone, but there would not have been enough faces to be worth covering topics. -- *Frederico Galvão* Diretor de Tecnologia PontoGet Inovação Web ( +55(62) 8131-5720 * www.pontoget.com.br http://www.pontoget.com/
Re: Monthly Cordova hangouts
I wouldn't try to participate actively on the meeting anyway, if that's what it seemed I was asking. I just like the possibility of watching it and keeping an eye on the future of the project, as I'm very much interested in it's future overall. Thanks Shazron, I'm looking foward to the youtube links. 2014-07-17 18:20 GMT-03:00 Shazron shaz...@gmail.com: All are welcome, we are an open project. Currently we are using Google Hangouts, so video slots are limited to 10 and we would like to reserve that for committers talking about the agenda (usually multiple committers in a geographical location gather together and use one slot), and we may have to limit these video slots. There is also a view-only YouTube link (Hangouts on Air) for the others that only want to lurk. Example: https://www.youtube.com/watch?v=57MvuZctrOo and this will be communicated to dev@ before the actual meeting. http://wiki.apache.org/cordova/Google%20Hangout%20Discussion%20Notes On Thu, Jul 17, 2014 at 2:12 PM, Frederico Galvão frederico.gal...@pontoget.com.br wrote: Or even people who doesn't contribute in code as of now, but still participates in the project somehow... What's the scope of the meetings, considering it's being discussed on an open mailing list? 2014-07-17 1:44 GMT-03:00 Puneet Kaur puneet.gk...@gmail.com: Hey all, Just wished to ask if the newcomers ( like me ) who wish to contribute to the code also join in the hangout or only the committers are allowed ? On Thu, Jul 17, 2014 at 3:34 AM, Tommy Williams to...@devgeeks.org wrote: Absolutely. 1pm/4pm in the USA is just 6am here. Barely even have to get up early. :) On 17 Jul 2014 04:39, Shazron shaz...@gmail.com wrote: If Tommy doesn't mind, my suggestion for the hangout is to have it during the window of PST and EST working hours :/ It's unfortunate that we can't cover everyone worldwide, but this time window captures the majority of the committers. We could do one once in a while to accommodate the other half of the world, but we need to plan for that way ahead of time so everyone can pencil it in to their calendars. On Tue, Jul 15, 2014 at 7:24 PM, Michal Mocny mmo...@chromium.org wrote: I deleted the event to make it clear it was cancelled. It was late notice for everyone, but there would not have been enough faces to be worth covering topics. -- *Frederico Galvão* Diretor de Tecnologia PontoGet Inovação Web ( +55(62) 8131-5720 * www.pontoget.com.br http://www.pontoget.com/ -- *Frederico Galvão* Diretor de Tecnologia PontoGet Inovação Web ( +55(62) 8131-5720 * www.pontoget.com.br http://www.pontoget.com/
[GitHub] cordova-plugin-battery-status pull request: CB-6957 Style improvem...
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/14 CB-6957 Style improvements on Manual tests Usage of info, which is wired a css class, aimed to only show results. Reorganization of titles and tables. Just organization of labes, and html elements. Requires the changes on this PR: https://github.com/apache/cordova-plugin-test-framework/pull/3 To get a better look.  You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-plugin-battery-status master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-battery-status/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit f6079cdb6a718ba03a6a5246a5fd0cd423dd2378 Author: Martin Gonzalez martin.c.glez.g...@gmail.com Date: 2014-07-17T21:27:57Z CB-6957 Style improvements on Manual tests Usage of info, which is wired a css class, aimed to only show results. Reorganization of titles and tables. Just organization of labes, and html elements. Requires the changes on this PR: https://github.com/apache/cordova-plugin-test-framework/pull/3 To get a better look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-7094 Ported File manual tests
GitHub user martincgg reopened a pull request: https://github.com/apache/cordova-plugin-file/pull/62 CB-7094 Ported File manual tests Only contains file manual tests for android and iOS. Both tested and validated. All outputs and results to log content. createActionButton it depends of this PR: https://github.com/apache/cordova-plugin-test-framework/pull/1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-plugin-file CB-7094 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 21b568f3a25d5a10f231fbf5989ca07242da6e81 Author: Martin Gonzalez martin.c.glez.g...@gmail.com Date: 2014-07-16T12:52:40Z CB-7094 Ported File manual tests Only contains file manual tests for android and iOS. Both tested and validated. All outputs and results to log content. createActionButton it depends of this PR: https://github.com/apache/cordova-plugin-test-framework/pull/1 commit 83041f438b9f58c5ee3c53496a2e0a41a7bf80ff Author: Martin Gonzalez martin.c.glez.g...@gmail.com Date: 2014-07-17T21:35:39Z Style improvements on Manual tests Usage of info, which is wired a css class, aimed to only show results. Reorganization of titles and tables. Just organization of labes, and html elements. Removed comment from automated tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-7094 Ported File manual tests
Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/62#issuecomment-49370393 Screenshot:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-vibration pull request: CB-6963 Ported Vibration au...
Github user martincgg closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-vibration pull request: CB-6966 Ported Vibration au...
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/15 CB-6966 Ported Vibration automated manual tests Ported tests from Mobilespec. Jasmine version: ported from v1.3 to v2.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-plugin-vibration CB-6966 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-vibration/pull/15.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15 commit 6c21d194f7caff17d8043065d685bc12577e4654 Author: Martin Gonzalez martin.c.glez.g...@gmail.com Date: 2014-07-17T21:47:01Z CB-6966 Ported Vibration automated manual tests Ported tests from Mobilespec. Jasmine version: ported from v1.3 to v2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: 3.6.0 Release Discussion, Schedule + Planning
+1 Thanks purplecabbage! On Thu, Jul 17, 2014 at 11:12 AM, Carlos Santana csantan...@gmail.com wrote: Glad to see some windows love :-). And again thanks to Jesse for being a great platform leader and the folks from MSOpenTech keep the good stuff coming On Thu, Jul 17, 2014 at 1:59 PM, Michal Mocny mmo...@chromium.org wrote: Thanks for volunteering! On Thu, Jul 17, 2014 at 1:49 PM, Jesse purplecabb...@gmail.com wrote: As has been mentioned in a few other threads, Windows 8.1 and WP 8.1 Universal apps will be supported in 3.6.0. This requires a release/publish of both the tooling, and the platforms as we have dependencies between them. Parashuram and I discussed this last week, and MSOpenTech would like to take a more active role in this release, as would I. I would like to assume the role of release manager this time around, and work closely with Sergey so we both can review/troubleshoot the process from a windows perspective. We will of course be getting help from the expert Steve, after he is back from vacay next week. My goal is to wrap up some loose ends today and tomorrow, and begin this process next Monday, hopefully starting a vote thread by the 24th. Thoughts? Cheers, Jesse @purplecabbage risingj.com -- Carlos Santana csantan...@gmail.com
[GitHub] cordova-docs pull request: CB-7113 - Document UseWKWebView config....
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/222 CB-7113 - Document UseWKWebView config.xml preference Pull in only when [CB-7093](https://issues.apache.org/jira/browse/CB-7090) is complete You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-docs CB-7113 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/222.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #222 commit 5307d7a0c5219eb63acdd3237f307a326499d0e9 Author: Shazron Abdullah shaz...@apache.org Date: 2014-07-17T22:50:49Z CB-7113 - Document UseWKWebView config.xml preference --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-docs pull request: CB-7121 - Document MinimumFontSize sett...
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/223 CB-7121 - Document MinimumFontSize setting for WKWebView preferences Pull in only when [CB-7090](https://issues.apache.org/jira/browse/CB-7090) is complete. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-docs CB-7121 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/223.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #223 commit 72779b7d71d81cdfbfe7607b3e66c38a05e3af4c Author: Shazron Abdullah shaz...@apache.org Date: 2014-07-17T22:56:12Z CB-7121 - Document MinimumFontSize setting for WKWebView preferences --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
RE: Add build status to github
We would need to raise an INFRA ticket for this, right ? -Original Message- From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] Sent: Thursday, July 17, 2014 6:53 AM To: dev@cordova.apache.org Subject: RE: Add build status to github We require someone with github admin rights to login to both services using github account and activate build for cordova-lib repo. The rest of the work will be done by the services. Thx! Sergey -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Thursday, July 17, 2014 5:42 PM To: dev@cordova.apache.org Subject: Re: Add build status to github +1 for running both, Travis and AppVeyor. What's needed in terms of setting up the hooks on GitHub side? Do we need in INFRA ticket for this? On Thu, Jul 17, 2014 at 6:56 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I've sent separate PRs for Travis and AppVeyor build configurations: https://github.com/apache/cordova-lib/pull/59 https://github.com/apache/cordova-lib/pull/60 #1 Both Travis and AppVeyor use very similar .yml based configuration files which are very easy to use/understand. #2 AppVeyor showed me Windows specific test failure related to paths so I think we should tun tests on both Linux and Windows https://ci.appveyor.com/project/sgrebnov/cordova-lib/build/1.0.2 1) lazy_load module custom method (loads custom cordova libs) local paths for libraries should return the local path, no symlink 862 Message: 863 Expected '\some\random\lib' to equal '/some/random/lib'. * PS. I have more failures on my local machine - will investigate this #3 Travis build sample https://travis-ci.org/sgrebnov/cordova-lib/builds/30154663 #4 Sample home page with both build badges integrated: https://github.com/sgrebnov/cordova-lib/ #5 Pull Requests. Tests are run on both services but github shows information for the only one of them - message is changed as per response from the build service, the last message is showed (not sure how it works if we have failure + then success - to be investigated). https://github.com/sgrebnov/cordova-lib/pull/4 Thx! Sergey -Original Message- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Tuesday, July 15, 2014 9:42 PM To: dev@cordova.apache.org Subject: Re: Add build status to github I see, it looks like our testing infra is going to be redunant/distributed regardless. (travis + X) No sense in fighting it! On Tue, Jul 15, 2014 at 9:31 AM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: Don't we still need Travis to drive the Saucelabs test? P.S: I have been investigating to see if I could use Appium to run Medic tests. No Windows support yet though :( -Original Message- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Tuesday, July 15, 2014 9:18 AM To: dev@cordova.apache.org Subject: RE: Add build status to github https://docs.saucelabs.com/reference/status-images/ On Jul 15, 2014 9:17 AM, Brian LeRoux b...@brian.io wrote: Or we could use SauceLabs (for all) On Jul 15, 2014 9:16 AM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: We would need both right? For covering Windows and Linux platforms for lib to build/run. -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Tuesday, July 15, 2014 7:55 AM To: dev@cordova.apache.org Subject: Re: Add build status to github Ok, let's ask here. Does anybody have any strong preferences for either AppVeyor or TravisCI or both for cordova-lib? note, this is only about running npm test in cordova-lib.
Re: Add build status to github
Yes, only INFRA ppl have the privileges on Github to add anything to the repos. On Thu, Jul 17, 2014 at 4:20 PM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: We would need to raise an INFRA ticket for this, right ? -Original Message- From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] Sent: Thursday, July 17, 2014 6:53 AM To: dev@cordova.apache.org Subject: RE: Add build status to github We require someone with github admin rights to login to both services using github account and activate build for cordova-lib repo. The rest of the work will be done by the services. Thx! Sergey -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Thursday, July 17, 2014 5:42 PM To: dev@cordova.apache.org Subject: Re: Add build status to github +1 for running both, Travis and AppVeyor. What's needed in terms of setting up the hooks on GitHub side? Do we need in INFRA ticket for this? On Thu, Jul 17, 2014 at 6:56 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I've sent separate PRs for Travis and AppVeyor build configurations: https://github.com/apache/cordova-lib/pull/59 https://github.com/apache/cordova-lib/pull/60 #1 Both Travis and AppVeyor use very similar .yml based configuration files which are very easy to use/understand. #2 AppVeyor showed me Windows specific test failure related to paths so I think we should tun tests on both Linux and Windows https://ci.appveyor.com/project/sgrebnov/cordova-lib/build/1.0.2 1) lazy_load module custom method (loads custom cordova libs) local paths for libraries should return the local path, no symlink 862 Message: 863 Expected '\some\random\lib' to equal '/some/random/lib'. * PS. I have more failures on my local machine - will investigate this #3 Travis build sample https://travis-ci.org/sgrebnov/cordova-lib/builds/30154663 #4 Sample home page with both build badges integrated: https://github.com/sgrebnov/cordova-lib/ #5 Pull Requests. Tests are run on both services but github shows information for the only one of them - message is changed as per response from the build service, the last message is showed (not sure how it works if we have failure + then success - to be investigated). https://github.com/sgrebnov/cordova-lib/pull/4 Thx! Sergey -Original Message- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Tuesday, July 15, 2014 9:42 PM To: dev@cordova.apache.org Subject: Re: Add build status to github I see, it looks like our testing infra is going to be redunant/distributed regardless. (travis + X) No sense in fighting it! On Tue, Jul 15, 2014 at 9:31 AM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: Don't we still need Travis to drive the Saucelabs test? P.S: I have been investigating to see if I could use Appium to run Medic tests. No Windows support yet though :( -Original Message- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Tuesday, July 15, 2014 9:18 AM To: dev@cordova.apache.org Subject: RE: Add build status to github https://docs.saucelabs.com/reference/status-images/ On Jul 15, 2014 9:17 AM, Brian LeRoux b...@brian.io wrote: Or we could use SauceLabs (for all) On Jul 15, 2014 9:16 AM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: We would need both right? For covering Windows and Linux platforms for lib to build/run. -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Tuesday, July 15, 2014 7:55 AM To: dev@cordova.apache.org Subject: Re: Add build status to github Ok, let's ask here. Does anybody have any strong preferences for either AppVeyor or TravisCI or both for cordova-lib? note, this is only about running npm test in cordova-lib.
[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...
GitHub user dylin opened a pull request: https://github.com/apache/cordova-blackberry/pull/169 Fixed issue: --buildId will disnable --no-signing 1. `webworks build --release --buildId 1234 --no-signing`: `--no-signing` will be ignored when a `--buildId` is provided 2. `webworks build [--debug] --buildId 1234`: `--buildId` won't effect, which should be set in manifest of bar file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry/cordova-blackberry dylin/fix-buildId-issue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-blackberry/pull/169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #169 commit 1beec8a1430f55470b476b152c32209c64cbc4e0 Author: Danyi Lin dany...@blackberry.com Date: 2014-07-18T00:06:02Z Fixed issue: --buildId will disnable --no-signing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15092256
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -81,10 +74,16 @@ try {
keystorepass = session.getKeyStorePass(command),
err;
+// buildId is specified
+if (command.buildId) {
+bbwpArgv.push(--buildId);
+bbwpArgv.push(command.buildId);
+}
if (command.release) {
-copyArgIfExists(buildId);
if (command.signing) {
-//Note: Packager refers to signing password as
password not keystorepass
+bbwpArgv.push(--signing);
+bbwpArgv.push(true);
+ //Note: Packager refers to signing password as
password not keystorepass
--- End diff --
// is under-indented
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15092273
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -108,8 +110,15 @@ try {
bbwpArgv.push(-d);
}
-copyArgIfExists(params);
-copyArgIfExists(loglevel);
+if (command.params) {
+bbwpArgv.push(params);
+bbwpArgv.push(command.params);
+}
+
+if (command.loglevel) {
+bbwpArgv.push(loglevel);
--- End diff --
wouldn't this be --loglevel?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15092271
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -108,8 +110,15 @@ try {
bbwpArgv.push(-d);
}
-copyArgIfExists(params);
-copyArgIfExists(loglevel);
+if (command.params) {
+bbwpArgv.push(params);
--- End diff --
wouldn't this be --params ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15092298
--- Diff: bin/templates/project/cordova/lib/cmdline.js ---
@@ -20,7 +20,7 @@ var command = require(commander),
command
.version('1.0.0.0')
-.usage('[drive:][path]archive [-s [dir]] [[ -g genpassword] [-buildId
num]] [-o dir] [-d] [-p paramsjsonfile]')
+.usage('[drive:][path]archive [-s [dir]] [[ -g genpassword] [-buildId
num]] [-o dir] [-d] [-p paramsjsonfile] [--signing true|false]')
.option('-s, --source [dir]', 'Save source. The default behavior is to
not save the source files. If dir is specified then creates dir\\src\\
directory structure. If no dir specified then the path of archive is assumed')
.option('-g, --password password', 'Signing key password')
--- End diff --
this is -g/--password...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15092316
--- Diff: bin/templates/project/cordova/lib/localize.js ---
@@ -29,10 +29,10 @@ var Localize = require(localize),
en: Build ID set in config.xml [version], but signing key
file was not found: $[1]
},
EXCEPTION_MISSING_SIGNING_PASSWORD: {
-en: Cannot sign application - No signing password provided
[-g]
+en: Cannot sign application - No signing password provided
[-k | --keystorepass]
--- End diff --
are you sure we mean -k/--keystorepass and not -g/--password?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15092332
--- Diff: bin/templates/project/cordova/lib/packager-validator.js ---
@@ -56,7 +57,7 @@ _self = {
};
//If -g password or --buildId is set, but signing key files are
missing, throw an error
-if (keysPassword || commandLinebuildId) {
+if ( (keysPassword || commandLinebuildId) signing) {
--- End diff --
I don't think we want the space between `(` and `(`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15092376
--- Diff: bin/templates/project/cordova/lib/packager-validator.js ---
@@ -67,18 +68,18 @@ _self = {
}
//If a buildId exists in config, but no keys were found, throw a
warning
-} else if (buildId) {
+} else if (buildId signing) {
--- End diff --
you should be able to do:
} else if (signing) {
if (buildId) {
...
} else if (...) ...
...
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: build configurations for Travis
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: build configurations for Travis
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/59#issuecomment-49383900 We still need INFRA to setup the hooks to travis. I did it in my fork, and the tests are failing, not sure what it is. You can see it here: https://github.com/purplecabbage/cordova-lib --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: build configurations for Travis
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/59#issuecomment-49384315 Slide#15 has some more apache+travis info : http://www.slideshare.net/jukka/apache-development-with-github-and-travis-ci --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: build configuration for AppVeyor
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-android pull request: 3.5.x
GitHub user daavenmessinger opened a pull request: https://github.com/apache/cordova-android/pull/107 3.5.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cordova-android 3.5.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/107.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #107 commit 6d40adfe33bac88f51514931b197da9f286b483e Author: Joe Bowser bows...@apache.org Date: 2014-05-06T22:51:13Z Update JS snapshot to version 3.5.0-rc1 (via coho) commit 7ec8d08c58d41e0cb1cea52030cf26279880c44d Author: Joe Bowser bows...@apache.org Date: 2014-05-06T22:51:13Z Set VERSION to 3.5.0-rc1 (via coho) commit a70191a9a4d15f41fdf411c92c71452c151d61bb Author: Joe Bowser bows...@apache.org Date: 2014-05-06T23:16:47Z OkHttp has broken headers. Updating for ASF compliance. commit df53dbdbc46f31916157ec44cb3b6fbc54e8ac9a Author: Joe Bowser bows...@apache.org Date: 2014-05-08T20:38:28Z package.json apparently needs to be updated before tagging, re-tagging manually commit 568d3b53329293af9089223cc652e1291d90db34 Author: Steven Gill stevengil...@gmail.com Date: 2014-05-08T22:32:23Z Update JS snapshot to version 3.5.0 (via coho) commit 82bc714ed9831c6a4376e12fdcf65f1a97b85a23 Author: Steven Gill stevengil...@gmail.com Date: 2014-05-08T22:32:23Z Set VERSION to 3.5.0 (via coho) commit d20d2781eff5439c8a7bc97cdf9b524d67991112 Author: Steven Gill stevengil...@gmail.com Date: 2014-05-27T21:11:37Z updated RELEASENOTES --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-android pull request: 3.5.x
Github user daavenmessinger commented on the pull request: https://github.com/apache/cordova-android/pull/107#issuecomment-49385317 https://github.com/apache/cordova-android/commit/d20d2781eff5439c8a7bc97cdf9b524d67991112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-android pull request: 3.5.x
Github user daavenmessinger closed the pull request at: https://github.com/apache/cordova-android/pull/107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: 4.0.x, efcedabe, Patch-Bombing and good faith
On Jul 16, 2014, at 3:11 PM, Andrew Grieve agri...@chromium.org wrote: Good call here. I should have made JIRAs for a bunch of these. I've now done so retroactively. Watching this, I very much agree that if Jira issues were created before the commit and included in the commit message, that would have been a communication improvement. The “before” benefit enables tracing a commit message back to a more detailed context description in Jira. Another potential miscommunication here could be the intended scope of the 4.0.x branch. The impression I get from Joe is that it was basically limited to enabling third-party webviews. The impression I get from Andrew is that is was more generally for breaking changes. If there is a mismatch in intention of scope, I think that is where most of the gear-grinding may be coming from. I believe that everyone is “trying to do the right thing”, just with a bit different goals.
[GitHub] cordova-docs pull request: Update links for 'Next guide'
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/221 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-docs pull request: Update links for 'Next guide'
Github user cmarcelk commented on the pull request: https://github.com/apache/cordova-docs/pull/221#issuecomment-49392139 Thanks for the contribution! Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: 4.0.x, efcedabe, Patch-Bombing and good faith
On Thu, Jul 17, 2014 at 8:10 PM, Marcel Kinard cmarc...@gmail.com wrote: On Jul 16, 2014, at 3:11 PM, Andrew Grieve agri...@chromium.org wrote: Good call here. I should have made JIRAs for a bunch of these. I've now done so retroactively. Watching this, I very much agree that if Jira issues were created before the commit and included in the commit message, that would have been a communication improvement. The “before” benefit enables tracing a commit message back to a more detailed context description in Jira. Another potential miscommunication here could be the intended scope of the 4.0.x branch. The impression I get from Joe is that it was basically limited to enabling third-party webviews. The impression I get from Andrew is that is was more generally for breaking changes. If there is a mismatch in intention of scope, I think that is where most of the gear-grinding may be coming from. The goal was to be where new features for 4.0.x wind up once we're done implementing them and generally agree upon them. When people said Let's merge the pluggable_webview branch into 4.0.x and other 4.0.x stuff into that branch I understood that to mean that this would be what 4.0.x would eventually look like. I didn't expect it to be somewhere that people could dump 50 commits into at once just because they wanted to try something and felt that they didn't have to create their own topic branch. That's what still irritates me. The big issue is that people believe they can make arbitrary changes without caring that it affects other people on both master and on 4.0.x, and I don't see this as being resolved. This project wasn't created yesterday, and it took the effort of a lot of people to get it this far, and to just dump these commits in without caring about those people is disrespectful. The number one reason my main gut reaction to any changes to this codebase is no is because I know that a lot of people depend on what we have as an API, and when we break it, they come to me to complain. If they don't talk to me, they'll go to Simon, Tommy or other visible committers, and not the people who actually break it. I know that merging in new features is a lot of work, and it's tempting to take the shortcut, but we really should actually at least try to make an effort to work together instead of just being glib and discounting what's being said. At this point, I'm not sure it's worth the effort because we've been down this road before numerous times. I don't think this will ever sink in.
Re: Monthly Cordova hangouts
So is the consensus 1pm PDT / 4pm EDT on Friday July 25? On Jul 16, 2014, at 6:04 PM, Tommy Williams to...@devgeeks.org wrote: Absolutely. 1pm/4pm in the USA is just 6am here. Barely even have to get up early. :)
Re: Monthly Cordova hangouts
+1 On 18 July 2014 at 14:00:59, Marcel Kinard (cmarc...@gmail.com) wrote: So is the consensus 1pm PDT / 4pm EDT on Friday July 25? On Jul 16, 2014, at 6:04 PM, Tommy Williams to...@devgeeks.org wrote: Absolutely. 1pm/4pm in the USA is just 6am here. Barely even have to get up early. :)
