[GitHub] cordova-lib pull request: fix CB-9145 prepare can lose data during...
Github user tony-- commented on the pull request: https://github.com/apache/cordova-lib/pull/242#issuecomment-112409200 Thanks @purplecabbage! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9122 Added tests for platform/plugin ...
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/246#discussion_r32515523
--- Diff: cordova-lib/spec-cordova/save.spec.js ---
@@ -0,0 +1,435 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+License); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+describe('(save flag)', function () {
+var rewire = require('rewire'),
+cordova = require('../src/cordova/cordova'),
+helpers = require('./helpers'),
+path= require('path'),
+Q = require('q'),
+fs = require('fs'),
+shell = require('shelljs'),
+util= require('../src/cordova/util'),
+platform= rewire('../src/cordova/platform.js');
+
+var appName = 'testApp',
+tempPath= path.join(__dirname, 'temp'),
+appPath = path.join(tempPath, appName),
+platformName= helpers.testPlatform,
+platformVersionOld = '4.0.0',
+platformVersionNew = '4.0.1',
+platformLocalPath = path.join(tempPath, 'cordova-' +
platformName),
+platformGitUrl = 'https://github.com/apache/cordova-' +
platformName,
+platformGitRef = '4.0.x',
+platformTgzUrl =
'https://git-wip-us.apache.org/repos/asf?p=cordova-' + platformName +
'.git;a=snapshot;h=' + platformVersionNew + ';sf=tgz',
+pluginName = 'cordova-plugin-console',
+pluginVersion = '1.0.0',
+pluginGitUrl=
'https://github.com/apache/cordova-plugin-console.git',
+pluginOldName = 'org.apache.cordova.console',
+pluginOldVersion= '0.2.11',
+variablePluginName = 'com.phonegap.plugins.facebookconnect',
+variablePluginUrl =
'https://github.com/Wizcorp/phonegap-facebook-plugin',
+localPluginName = 'org.apache.cordova.fakeplugin1',
+localPluginPath = path.join(__dirname, 'fixtures', 'plugins',
'fake1'),
+timeout = 60 * 1000;
+
+//mocks
+var is_cordova, cd_project_root, prepare,
+revert_copy_cordova_js, revert_copy_cordovajs_src,
revert_install_plugins_for_new_platform;
+
+beforeEach(function (done) {
+is_cordova = spyOn(util, 'isCordova').andReturn(appPath);
+cd_project_root = spyOn(util, 'cdProjectRoot').andReturn(appPath);
+prepare = spyOn(cordova.raw, 'prepare').andReturn(Q());
+
+fs.exists(appPath, function (exists) {
+if (exists) {
+cordova.raw.platform('rm', platformName).then(done, done);
+} else {
+done();
+}
+});
+});
+
+describe('(preparing fixtures)', function () {
+it('preparing temp dir', function () {
--- End diff --
If this is moved, then 'creating test app' should also be moved, but
creating test app before each test could significantly increase test run
duration (289 - 348 sec on my machine).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] 5.1.1 Docs Release?
Thanks Steven, just verified them On Mon, Jun 15, 2015 at 7:29 PM Steven Gill stevengil...@gmail.com wrote: docs have been released! On Fri, Jun 12, 2015 at 8:06 AM, Victor Sosa sosah.vic...@gmail.com wrote: Hi Steven. Translations are committed now and I did a quick check on the docs. Translations are there. Could you publish these docs, please? Thanks a lot. On Fri, Jun 12, 2015 at 8:21 AM Victor Sosa sosah.vic...@gmail.com wrote: Hi Andrey Actually working on the Russian documentation but not done. So, I'll stop here and will commit changes for the other languages. Please, let me know when you are done to update Russian docs in the repo. Yes, I'll be including the latest changes, including clean hook On Thu, Jun 11, 2015 at 11:54 PM Andrey Kurdumov kant2...@googlemail.com wrote: Hi, I would like that docs for `clean` hooks would be also included, so both English and Russian version would be exactly the same. This is require that docs would be updated, very easy fix - See ( https://github.com/apache/cordova-docs/pull/293/files) Also before releasing Russian docs, I have to verify that all markup is generated correctly, we don't have any missing links and so on. I need day or two for that to verify. @Victor, could you please not automatically update Russian docs with text from Bing, I lose all my progress constantly and have to reread all docs to find which places is not correctly translated. Please give me some notice in advance, so I at least could record what's left. Anyway I have to modify CrowdIn output in some places so all links would be in place and HTML would be generated correctly. @Stiven, could you please merge https://github.com/apache/cordova-docs/pull/289, this will greatly help me in translation process. 2015-06-12 3:16 GMT+06:00 Victor Sosa sosah.vic...@gmail.com: Hello Steven. I'm working on the translation right now, I expect to finish everything byt tomorrow evening. Will reply this thread when I'm done. On Thu, Jun 11, 2015 at 3:16 PM Steven Gill stevengil...@gmail.com wrote: Let me know when translations have been checked in and what languages need to get the new version. For example, only Russian and english docs have 5.0.0 currently. Edge for all of the other docs is recent though.
[GitHub] cordova-coho pull request: CB-8214 COHO. Rename windowsphone to wp...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: Handle multiple modules within a single...
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-coho/pull/85#issuecomment-112478743 Thanks @stevengill! Will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9122 Added tests for platform/plugin ...
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/246#discussion_r32539540
--- Diff: cordova-lib/spec-cordova/save.spec.js ---
@@ -0,0 +1,435 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+License); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+describe('(save flag)', function () {
+var rewire = require('rewire'),
+cordova = require('../src/cordova/cordova'),
+helpers = require('./helpers'),
+path= require('path'),
+Q = require('q'),
+fs = require('fs'),
+shell = require('shelljs'),
+util= require('../src/cordova/util'),
+platform= rewire('../src/cordova/platform.js');
+
+var appName = 'testApp',
+tempPath= path.join(__dirname, 'temp'),
+appPath = path.join(tempPath, appName),
+platformName= helpers.testPlatform,
+platformVersionOld = '4.0.0',
+platformVersionNew = '4.0.1',
+platformLocalPath = path.join(tempPath, 'cordova-' +
platformName),
+platformGitUrl = 'https://github.com/apache/cordova-' +
platformName,
+platformGitRef = '4.0.x',
+platformTgzUrl =
'https://git-wip-us.apache.org/repos/asf?p=cordova-' + platformName +
'.git;a=snapshot;h=' + platformVersionNew + ';sf=tgz',
+pluginName = 'cordova-plugin-console',
+pluginVersion = '1.0.0',
+pluginGitUrl=
'https://github.com/apache/cordova-plugin-console.git',
+pluginOldName = 'org.apache.cordova.console',
+pluginOldVersion= '0.2.11',
+variablePluginName = 'com.phonegap.plugins.facebookconnect',
+variablePluginUrl =
'https://github.com/Wizcorp/phonegap-facebook-plugin',
+localPluginName = 'org.apache.cordova.fakeplugin1',
+localPluginPath = path.join(__dirname, 'fixtures', 'plugins',
'fake1'),
+timeout = 60 * 1000;
+
+//mocks
+var is_cordova, cd_project_root, prepare,
+revert_copy_cordova_js, revert_copy_cordovajs_src,
revert_install_plugins_for_new_platform;
+
+beforeEach(function (done) {
+is_cordova = spyOn(util, 'isCordova').andReturn(appPath);
+cd_project_root = spyOn(util, 'cdProjectRoot').andReturn(appPath);
+prepare = spyOn(cordova.raw, 'prepare').andReturn(Q());
+
+fs.exists(appPath, function (exists) {
+if (exists) {
+cordova.raw.platform('rm', platformName).then(done, done);
+} else {
+done();
+}
+});
+});
+
+describe('(preparing fixtures)', function () {
+it('preparing temp dir', function () {
+shell.rm('-rf', tempPath);
+shell.mkdir(tempPath);
+});
+
+it('creating mocks', function () {
+revert_copy_cordova_js = platform.__set__('copy_cordova_js',
function () {});
+revert_copy_cordovajs_src =
platform.__set__('copy_cordovajs_src', function () {});
+revert_install_plugins_for_new_platform =
platform.__set__('installPluginsForNewPlatform', function () { return Q(); });
+});
+
+it('creating test app', function (done) {
+cordova.raw.create(appPath, undefined, undefined,
{}).then(function () {
+//removing unnecessary whitelist plugin from config
+helpers.removePlugin(appPath, 'cordova-plugin-whitelist');
+done();
+}, function (err) {
+expect(true).toBe(false);
+console.log(err);
+done();
+});
+});
+
+it('cloning platform', function (done) {
+shell.exec('git clone ' + platformGitUrl + ' --depth
[GitHub] cordova-lib pull request: fix CB-9145 prepare can lose data during...
Github user tony-- commented on the pull request: https://github.com/apache/cordova-lib/pull/242#issuecomment-112480771 AND I screwed up my first commit comment by prepending the word fix before the JIRA issue. I will adhere to the formatting guidelines in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/146#discussion_r32538324 --- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj --- @@ -374,7 +374,7 @@ ); runOnlyForDeploymentPostprocessing = 0; shellPath = /bin/sh; - shellScript = cordova/lib/copy-www-build-step.sh; + shellScript = node cordova/lib/copy-www-build-step.js; --- End diff -- This change assumes `node` to be in the $PATH for this to work. I'm not familiar with OS X and I'm assuming this assumption does not cause a problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-ios/pull/146#issuecomment-112483772 LGTM. Adding `glob` does increase the size of ios platform considerably. I'm assuming there is no other cheaper way to do this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: Handle multiple modules within a single...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/85 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/146#discussion_r32547846 --- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj --- @@ -374,7 +374,7 @@ ); runOnlyForDeploymentPostprocessing = 0; shellPath = /bin/sh; - shellScript = cordova/lib/copy-www-build-step.sh; + shellScript = node cordova/lib/copy-www-build-step.js; --- End diff -- I thought about this earlier when the PR came in and I think its a good assumption since it's a Cordova project and the user is using the CLI. The scenario where a user would take the project from platforms/ios and run it stand-alone is miniscule. Not sure if this is supported fully but Xcode.app does include node.js under `/Applications/Xcode.app/Contents/Developer/usr/share/xcs/Node/bin/node` You would dynamically get this path by using `xcode-select --print-path` then appending `/usr/share/xcs/Node/bin/node` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[iOS] Remove non-CLI template
I propose to remove the non-CLI template starting in cordova-ios 4.0.0. It was originally used to easily test your own plugins, but now we have the alternative using the CLI: cordova plugin add --link path/to/your/plugin
[GitHub] cordova-lib pull request: CB-9188 Confusing error after delete plu...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9188 Confusing error after delete plu...
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/249 CB-9188 Confusing error after delete plugin folder then prepare. Catch this scenario and display a useful message. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-9188 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/249.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #249 commit 7966f08c94cc64167c2f094c73202678f41576f2 Author: Tim Barham tim.bar...@microsoft.com Date: 2015-06-16T17:13:18Z CB-9188 Confusing error after delete plugin folder then prepare. Catch this scenario and display a useful message. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-console pull request: CB-9191 Add basic test
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-console/pull/11 CB-9191 Add basic test This pr is just to see if travis likes what it sees. I will be adding more tests shortly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-console CB-9191 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-console/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit 38cc8f7957c50886157e435d1381ce3f238d28ef Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-06-16T20:57:22Z CB-9191 Add basic test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9162 - Default Variables
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/247#issuecomment-112522204 Added missing test for variables parsing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9162 - Default Variables
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js
Github user jhampton commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-112565149 Ditto - our team is currently unable to build a project because of this bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9162 - Default Variables
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/247#issuecomment-112552487 Thanks for the update, @ogoguel. Squashed and merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: fix CB-9145 prepare can lose data during...
Github user tony-- closed the pull request at: https://github.com/apache/cordova-lib/pull/242 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: fix CB-9145 prepare can lose data during...
Github user tony-- commented on the pull request: https://github.com/apache/cordova-lib/pull/242#issuecomment-112557560 Merged commit [2598231](https://github.com/tony--/cordova-lib/commit/25982317b26c831dbea9d6b71dd57a90b933fc68) into apache:master, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Facebook infer on Cordova / plugins
Hi, I ran infer on one of my projects and get the output below. I looked only at the first issue reported and it I think it is an issue and easy to fix. http://fbinfer.com/docs/hello-world.html#hello-world-android Maybe this should be run on all Android plugins and Cordova Android code from time to time? cheers Axel Maybe I am using older versions on some plugins. Have not checked. /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:210: error: NULL_DEREFERENCE object returned by queryImgDB(this,whichContentStore(this)) could be null and is dereferenced at line 210 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:210: error: RESOURCE_LEAK resource acquired by call to queryImgDB(...) at line 210 is not released after line 210 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:1007: error: NULL_DEREFERENCE object cursor last assigned on line 1006 could be null and is dereferenced at line 1007 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:1024: error: RESOURCE_LEAK resource acquired by call to queryImgDB(...) at line 1006 is not released after line 1024 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/FileHelper.java:97: error: NULL_DEREFERENCE object cursor last assigned on line 94 could be null and is dereferenced at line 97 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/FileHelper.java:135: error: NULL_DEREFERENCE object cursor last assigned on line 134 could be null and is dereferenced at line 135 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/FileHelper.java:137: error: RESOURCE_LEAK resource acquired by call to query(...) at line 134 is not released after line 137 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/file/LocalFilesystem.java:340: error: RESOURCE_LEAK resource acquired to istream by call to FileInputStream(...) at line 327 is not released after line 340 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/file/LocalFilesystem.java:340: error: RESOURCE_LEAK resource acquired by call to FileOutputStream(...) at line 328 is not released after line 340 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/filetransfer/FileTransfer.java:554: error: RESOURCE_LEAK resource acquired by call to getInputStream() at line 554 is not released after line 554
Re: [VOTE] Cordova Serve 0.1.2 release
+1 * Verified archive using coho verify-archive command * Manually looked at files. Looks good. On Tue, Jun 16, 2015 at 12:34 AM, Vladimir Kotikov (Akvelon) v-vlk...@microsoft.com wrote: I vote +1 * Verified license headers for the cordova-serve * Verified archive from dist for cordova-serve * Installed cordova-serve@rc from npm and verified that it works correctly with corresponding cordova-lib version --- Best regards, Vladimir -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Tuesday, 16 June, 2015 3:45 To: 'dev@cordova.apache.org' Subject: [VOTE] Cordova Serve 0.1.2 release Please review and vote on this Cordova Serve Release by replying to this email. Release issue: https://issues.apache.org/jira/browse/CB-9181 Package has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9181/ I have uploaded the package to npm under the RC tag for testing purposes, and created cordova-lib update that uses it for the 'cordova serve' command [1]. The package was published from its corresponding git tag: cordova-lib: serve-0.1.2 (c87b48140a) (Note that this is the cordova-serve module in the cordova-lib repository) Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md I vote +1: * Ran 'coho audit-license-headers' on the cordova-serve module * Ran 'coho check-license' on the cordova-serve module to ensure all dependencies and sub-dependencies have Apache-compatible licenses * Uploaded to NPM with RC tag, installed and verified it works as expected with version of cordova-lib modified to use it. To use coho tools to verify the this release, you will need to sync with a coho update that knows how to work with multiple modules within a repo (this update is not yet checked in) [2]. With this update, you will be able to use 'serve' as a repo name. [1] https://github.com/MSOpenTech/cordova-lib/tree/tb-use-cordova-serve [2] https://github.com/MSOpenTech/cordova-coho/tree/tb-coho-modules Thanks! Tim - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: CB-9194 Created faq page and ad...
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-registry-web/pull/13 CB-9194 Created faq page and added header Live demo at: http://people.apache.org/~muratsu/index.html You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-registry-web CB-9194 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-registry-web/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit d9349eea71195b4e74bc5dba11c636f234c94d23 Author: Murat Sutunc sut...@gmail.com Date: 2015-06-16T23:31:21Z CB-9194 Created faq page and added header --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-console pull request: CB-9191 Add basic test
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-console/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112614600 Argh, Just merged it in haha. I am going to revert it so we have more time to test. Looks like it is causing problems. I'd say we stick with keeping it in the loop for now. I am not super familiar with this plugin. It looks like `allowedNavigations == null` is for giving default access to `file` and `data`. I could see content fitting in there. Don't think we need cdvfile:// unless removing it breaks the file plugin for you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112614830 Reverted it. Hopefully this PR opens agian --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Github user agamemnus commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112615378 It is still closed. You have to re-open it manually. (button below comment textbox) My changes did fix the issue for me, but only because I had the origin at *. I will read more about whitelist stuff myself and see where the best place is to put it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112615358 This is a pretty big problem IMO. File plugin not working. I am going to test it to see if I can reproduce the issues. A better solution would be if the file plugin added an exception to config.xml when getting installed. Doesn't seem to be doing that right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112615819 I think only you or apache infra people can re-open it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112616193 Any chance you can give me some steps to reproduce it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Github user agamemnus commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112616455 I can't re-open it. Reproduce steps would be to use any Google Expansion File plugin (like mine here, and see these steps to update to Cordova 5: https://github.com/agamemnus/cordova-plugin-xapkreader/issues/22) or use file-transfer plugin to try to add files I suppose. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112617030 Sweet! Thanks. I'll take a look tonight/tomorrow and see if we can figure this out. Let me know if you come up with any findings. We may have to open a new PR :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-coho/pull/86 CB-9109 Switching to using .ratignores Switched to using a repository's `.ratignore` file instead of the `ratExcludes` property inside of coho. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-coho CB-9109 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/86.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #86 commit 50f99e52d40b94cd2e62bd911aab07ab2ea43d2e Author: Dmitry Blotsky dmitry.blot...@gmail.com Date: 2015-06-17T01:29:54Z CB-9109 Switched to using a repository's .ratignore file instead of the ratExcludes property inside of coho. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: CB-9195 Sorting platforms and a...
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-registry-web/pull/14 CB-9195 Sorting platforms and adding more option You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakatyal/cordova-registry-web raghav/platforms Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-registry-web/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit b847def0174e9db074c64002e1b0cbf9671594fa Author: Raghav Katyal rakat...@microsoft.com Date: 2015-06-16T23:40:31Z Sorting platforms and adding more option --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...
Github user uareurapid commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/56#issuecomment-112604611 Ok thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: CB-9194 Created faq page and ad...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-registry-web/pull/13#issuecomment-112604724 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Cordova Serve 0.1.2 release
I would say no. We can point to the release notes during the next tools release or something. On Tue, Jun 16, 2015 at 5:07 PM, Tim Barham tim.bar...@microsoft.com wrote: The vote has now closed. The results are: Positive binding votes: 4 Tim Barham Vladimir Kotikov Steven Gill Jesse MacFadyen The vote has passed. Thanks all! I will publish to dist and npm. Question: Does a release like this require a blog post? Thanks, Tim -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, June 16, 2015 4:39 PM To: dev@cordova.apache.org Subject: Re: [VOTE] Cordova Serve 0.1.2 release +1 ran coho verify-archive reviewed code @purplecabbage risingj.com On Tue, Jun 16, 2015 at 4:27 PM, Steven Gill stevengil...@gmail.com wrote: +1 * Verified archive using coho verify-archive command * Manually looked at files. Looks good. On Tue, Jun 16, 2015 at 12:34 AM, Vladimir Kotikov (Akvelon) v-vlk...@microsoft.com wrote: I vote +1 * Verified license headers for the cordova-serve * Verified archive from dist for cordova-serve * Installed cordova-serve@rc from npm and verified that it works correctly with corresponding cordova-lib version --- Best regards, Vladimir -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Tuesday, 16 June, 2015 3:45 To: 'dev@cordova.apache.org' Subject: [VOTE] Cordova Serve 0.1.2 release Please review and vote on this Cordova Serve Release by replying to this email. Release issue: https://issues.apache.org/jira/browse/CB-9181 Package has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9181/ I have uploaded the package to npm under the RC tag for testing purposes, and created cordova-lib update that uses it for the 'cordova serve' command [1]. The package was published from its corresponding git tag: cordova-lib: serve-0.1.2 (c87b48140a) (Note that this is the cordova-serve module in the cordova-lib repository) Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md I vote +1: * Ran 'coho audit-license-headers' on the cordova-serve module * Ran 'coho check-license' on the cordova-serve module to ensure all dependencies and sub-dependencies have Apache-compatible licenses * Uploaded to NPM with RC tag, installed and verified it works as expected with version of cordova-lib modified to use it. To use coho tools to verify the this release, you will need to sync with a coho update that knows how to work with multiple modules within a repo (this update is not yet checked in) [2]. With this update, you will be able to use 'serve' as a repo name. [1] https://github.com/MSOpenTech/cordova-lib/tree/tb-use-cordova-serve [2] https://github.com/MSOpenTech/cordova-coho/tree/tb-coho-modules Thanks! Tim - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112609463 This looks good to me. I'll merge it in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Cordova Serve 0.1.2 release
You need to leave the vote open longer than 23 hours ... 72 is the usual, as there may be -1s coming ( not likely, but we have to leave the window open ) @purplecabbage risingj.com On Tue, Jun 16, 2015 at 5:08 PM, Steven Gill stevengil...@gmail.com wrote: I would say no. We can point to the release notes during the next tools release or something. On Tue, Jun 16, 2015 at 5:07 PM, Tim Barham tim.bar...@microsoft.com wrote: The vote has now closed. The results are: Positive binding votes: 4 Tim Barham Vladimir Kotikov Steven Gill Jesse MacFadyen The vote has passed. Thanks all! I will publish to dist and npm. Question: Does a release like this require a blog post? Thanks, Tim -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, June 16, 2015 4:39 PM To: dev@cordova.apache.org Subject: Re: [VOTE] Cordova Serve 0.1.2 release +1 ran coho verify-archive reviewed code @purplecabbage risingj.com On Tue, Jun 16, 2015 at 4:27 PM, Steven Gill stevengil...@gmail.com wrote: +1 * Verified archive using coho verify-archive command * Manually looked at files. Looks good. On Tue, Jun 16, 2015 at 12:34 AM, Vladimir Kotikov (Akvelon) v-vlk...@microsoft.com wrote: I vote +1 * Verified license headers for the cordova-serve * Verified archive from dist for cordova-serve * Installed cordova-serve@rc from npm and verified that it works correctly with corresponding cordova-lib version --- Best regards, Vladimir -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Tuesday, 16 June, 2015 3:45 To: 'dev@cordova.apache.org' Subject: [VOTE] Cordova Serve 0.1.2 release Please review and vote on this Cordova Serve Release by replying to this email. Release issue: https://issues.apache.org/jira/browse/CB-9181 Package has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9181/ I have uploaded the package to npm under the RC tag for testing purposes, and created cordova-lib update that uses it for the 'cordova serve' command [1]. The package was published from its corresponding git tag: cordova-lib: serve-0.1.2 (c87b48140a) (Note that this is the cordova-serve module in the cordova-lib repository) Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md I vote +1: * Ran 'coho audit-license-headers' on the cordova-serve module * Ran 'coho check-license' on the cordova-serve module to ensure all dependencies and sub-dependencies have Apache-compatible licenses * Uploaded to NPM with RC tag, installed and verified it works as expected with version of cordova-lib modified to use it. To use coho tools to verify the this release, you will need to sync with a coho update that knows how to work with multiple modules within a repo (this update is not yet checked in) [2]. With this update, you will be able to use 'serve' as a repo name. [1] https://github.com/MSOpenTech/cordova-lib/tree/tb-use-cordova-serve [2] https://github.com/MSOpenTech/cordova-coho/tree/tb-coho-modules Thanks! Tim - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Github user agamemnus commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112611004 Actually, hold on a second. The change is not quite what the title says. It only automatically whitelists ``content://``, ``cdvfile://``, and ``file://`` for ``allowedNavigations`` if there is a ``*`` origin. What do you think of adding those regardless of the origin? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Github user agamemnus commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112611552 (And to be honest, I am fuzzy about what ``allowedNavigations``, ``allowedRequests``, and ``allowedIntents`` exactly mean.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [VOTE] Cordova Serve 0.1.2 release
The vote has now closed. The results are: Positive binding votes: 4 Tim Barham Vladimir Kotikov Steven Gill Jesse MacFadyen The vote has passed. Thanks all! I will publish to dist and npm. Question: Does a release like this require a blog post? Thanks, Tim -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, June 16, 2015 4:39 PM To: dev@cordova.apache.org Subject: Re: [VOTE] Cordova Serve 0.1.2 release +1 ran coho verify-archive reviewed code @purplecabbage risingj.com On Tue, Jun 16, 2015 at 4:27 PM, Steven Gill stevengil...@gmail.com wrote: +1 * Verified archive using coho verify-archive command * Manually looked at files. Looks good. On Tue, Jun 16, 2015 at 12:34 AM, Vladimir Kotikov (Akvelon) v-vlk...@microsoft.com wrote: I vote +1 * Verified license headers for the cordova-serve * Verified archive from dist for cordova-serve * Installed cordova-serve@rc from npm and verified that it works correctly with corresponding cordova-lib version --- Best regards, Vladimir -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Tuesday, 16 June, 2015 3:45 To: 'dev@cordova.apache.org' Subject: [VOTE] Cordova Serve 0.1.2 release Please review and vote on this Cordova Serve Release by replying to this email. Release issue: https://issues.apache.org/jira/browse/CB-9181 Package has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9181/ I have uploaded the package to npm under the RC tag for testing purposes, and created cordova-lib update that uses it for the 'cordova serve' command [1]. The package was published from its corresponding git tag: cordova-lib: serve-0.1.2 (c87b48140a) (Note that this is the cordova-serve module in the cordova-lib repository) Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md I vote +1: * Ran 'coho audit-license-headers' on the cordova-serve module * Ran 'coho check-license' on the cordova-serve module to ensure all dependencies and sub-dependencies have Apache-compatible licenses * Uploaded to NPM with RC tag, installed and verified it works as expected with version of cordova-lib modified to use it. To use coho tools to verify the this release, you will need to sync with a coho update that knows how to work with multiple modules within a repo (this update is not yet checked in) [2]. With this update, you will be able to use 'serve' as a repo name. [1] https://github.com/MSOpenTech/cordova-lib/tree/tb-use-cordova-serve [2] https://github.com/MSOpenTech/cordova-coho/tree/tb-coho-modules Thanks! Tim - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [VOTE] Cordova Serve 0.1.2 release
I vote +1 * Verified license headers for the cordova-serve * Verified archive from dist for cordova-serve * Installed cordova-serve@rc from npm and verified that it works correctly with corresponding cordova-lib version --- Best regards, Vladimir -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Tuesday, 16 June, 2015 3:45 To: 'dev@cordova.apache.org' Subject: [VOTE] Cordova Serve 0.1.2 release Please review and vote on this Cordova Serve Release by replying to this email. Release issue: https://issues.apache.org/jira/browse/CB-9181 Package has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9181/ I have uploaded the package to npm under the RC tag for testing purposes, and created cordova-lib update that uses it for the 'cordova serve' command [1]. The package was published from its corresponding git tag: cordova-lib: serve-0.1.2 (c87b48140a) (Note that this is the cordova-serve module in the cordova-lib repository) Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md I vote +1: * Ran 'coho audit-license-headers' on the cordova-serve module * Ran 'coho check-license' on the cordova-serve module to ensure all dependencies and sub-dependencies have Apache-compatible licenses * Uploaded to NPM with RC tag, installed and verified it works as expected with version of cordova-lib modified to use it. To use coho tools to verify the this release, you will need to sync with a coho update that knows how to work with multiple modules within a repo (this update is not yet checked in) [2]. With this update, you will be able to use 'serve' as a repo name. [1] https://github.com/MSOpenTech/cordova-lib/tree/tb-use-cordova-serve [2] https://github.com/MSOpenTech/cordova-coho/tree/tb-coho-modules Thanks! Tim - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...
Github user syndbg commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112385310 The white spaces are automatically stripped by my text editor. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Fix/wp8 browser cookies
GitHub user mlaponder opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/90 Fix/wp8 browser cookies [wp8] Make it possible to use the webview's cookiestore to do HTTP requests On the wp8 platform, cookies used to be always copied from the webview when performing a request. However, only the cookies for the currently loaded URL could be copied. This made it impossible to pass cookies cross-origin. This commit introduces a flag `useBrowserHttp` which when `false` keeps the same behavior. When `true`, it creates the WebRequest through a different factory method, reusing the cookies of the webview. Using this option comes at a price though: it makes it impossible to add cookies manually by setting headers and it can't perform GET requests with headers set. Therefore this functionality is put behind a flag. Because we had to change the API between the JS and native code to add the flag, this commit also includes platform changes. Code was tested on ios, android and wp8 platforms. Co-Authored-By: Leroy van Engelen leroy.van.enge...@mendix.com You can merge this pull request into a Git repository by running: $ git pull https://github.com/mlaponder/cordova-plugin-file-transfer fix/wp8-browser-cookies Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file-transfer/pull/90.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #90 commit fc1a60c0ee8c049c1d659ee275bbf3ced8c0a682 Author: Marco Laponder marco.lapon...@mendix.com Date: 2015-06-15T14:15:29Z Add useBrowserHttp argument to native interfaces commit c70c3aa8b94d8e87f525d66ecdd1888b69b66fd1 Author: Marco Laponder marco.lapon...@mendix.com Date: 2015-06-15T14:27:40Z Use cookies directly from the webview Originally, cookies from the webview were always copied to the WebRequest. When getting the cookies from the webiew only those for the current URL can be retrieved. This means that cookies of other domains were never copied to the WebRequest for upload and download. This commit adds the option to use a HTTP request constructed by the webview, which automatically adds any available cookies for that request. Fixed by using the BrowserHttp implementation of IWebRequestCreate which shares the cookie store with the webview. See also http://stackoverflow.com/questions/4212713/grabbing-cookies-in-web-browser-control-wp7 This functionality is enabled by a new useBrowserHttp flag. We need this to be optional because: - It removes the possibility of adding cookie headers manually - It makes it impossible to perform GET requests with manually set headers commit 78d216a94e02a15faee81b008aa4662151344b3b Author: Marco Laponder marco.lapon...@mendix.com Date: 2015-06-15T14:55:30Z Move Uri exception handling to outer catch block This will make it easier to unify the WebRequest creation code later. commit 58fcc98e7ffa79650d2900c8d16cbea1a19c3d77 Author: Marco Laponder marco.lapon...@mendix.com Date: 2015-06-15T14:56:50Z Use an Uri to create WebRequest in download as well commit e63d707445d0c03a4b0065e5e5d11a7d4e978896 Author: Marco Laponder marco.lapon...@mendix.com Date: 2015-06-15T15:06:22Z Extract WebRequest creation Share the WebRequest creation code between download and upload. commit fdaa1cf5a8df18fd0f2a8feefe90d54babbbc457 Author: Marco Laponder marco.lapon...@mendix.com Date: 2015-06-16T11:34:02Z Add documentation for `useBrowserHttp` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
