[GitHub] cordova-plugin-camera pull request: Browser - Camera on top of all...

[aliokan]

Github user aliokan commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-158002551
  
I have signed Apache Individual Contributor License Agreement :) 
https://people.apache.org/committer-index.html#unlistedclas Laurent 
Deketelaere


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [VOTE] 3.8.2 WP8 Release (Attempt 2)

[Alexander Sorokin (Akvelon)]

I vote +1

* Verified archives via 'coho verify-archive'
* Verified tags
* Verified platform version
* Verified that blank app creates correctly with platform
* Verified that blank app can be successfully ran and built
* Verified update scenario
* Verified compatibility with core plugins (released versions)
* Checked for whitespace issues
* Checked for Unicode issues

Thanks,
Alexander Sorokin

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Wednesday, November 18, 2015 10:18 PM
To: dev@cordova.apache.org
Subject: [VOTE] 3.8.2 WP8 Release (Attempt 2)

Please review and vote on this 3.8.2 WP8 Release by replying to this email (and 
keep discussion on the DISCUSS thread)

Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10012=01%7c01%7cv-alsoro%40microsoft.com%7c2f6b7a20553348dcc1e108d2f04d03ac%7c72f988bf86f141af91ab2d7cd011db47%7c1=N2p%2bH31H96%2fP8UMdzZtUhyp6fmnfFr5Gv5fKW5f6jBU%3d

The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10012

The package was published from its corresponding git tag:
cordova-wp8: 3.8.2 (270a671993)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-wp8#3.8.2

Upon a successful vote I will upload the archive to dist/, publish it to npm.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Ensured continuous build was green when repo was tagged

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

[luofan189]

Github user luofan189 commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158174054
  
I have added options to that JIRA issue, @riknoll 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/240#discussion_r45386856
  
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +212,54 @@ module.exports = GradleBuilder;
 function isAutoGenerated(file) {
 return fs.existsSync(file) && fs.readFileSync(file, 
'utf8').indexOf(MARKER) > 0;
 }
+
+/**
+ * A special superspawn-like implementation, required to workaround the 
issue
+ *   with java printing some necessary information to stderr instead of 
stdout.
+ *   This function redirects all stderr messages to current process 
stdout. See
+ *   https://issues.apache.org/jira/browse/CB-9971 for explanation.
+ *
+ * @param   {String}cmd   A command to spawn
+ * @param   {String[]}  args  Command arguments. Note that on Windows 
arguments
+ *   will be concatenated into string and passed to 'cmd.exe' along with 
'/s'
+ *   and '/c' swithces for proper space-in-path handling
+ *
+ * @return  {Promise}A promise, rejected with error message, if
+ *   underlying command exits with nonzero exit code, fulfilled otherwise
+ */
+function spawnWithStderrRedirect(cmd, args) {
+var opts = { stdio: 'pipe' };
+
+if (process.platform === 'win32') {
+// Work around spawn not being able to find .bat files.
+var joinedArgs = [cmd]
+.concat(args)
+.map(function(a){
+// Add quotes to arguments which contains whitespaces
+if (/^[^"].* .*[^"]/.test(a)) return '"' + a + '"';
+return a;
+}).join(' ');
+
+args = ['/s', '/c'].concat('"' + joinedArgs + '"');
+cmd = 'cmd';
+opts.windowsVerbatimArguments = true;
+}
+
+return Q.Promise(function (resolve, reject) {
+var proc = child_process.spawn(cmd, args, opts);
+
+proc.stdout.on('data', process.stdout.write.bind(process.stdout));
+proc.stderr.on('data', function (data) {
+var isRedirectNeeded = data.toString().match(/^Picked up 
_JAVA_OPTIONS: /i);
+process[isRedirectNeeded ? 'stdout' : 'stderr'].write(data);
--- End diff --

Are we sure that putting that line on stdout will not cause different 
problems? Would it be better to completely suppress it? I don't think anyone 
actually cares to see it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/240#discussion_r45386261
  
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +209,46 @@ module.exports = GradleBuilder;
 function isAutoGenerated(file) {
 return fs.existsSync(file) && fs.readFileSync(file, 
'utf8').indexOf(MARKER) > 0;
 }
+
+/**
+ * A special superspawn-like implementation, required to workaround the 
issue
--- End diff --

This is not really a consideration anymore now that the redirection has to 
be more specialized to this particular case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/240#discussion_r45385875
  
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +212,54 @@ module.exports = GradleBuilder;
 function isAutoGenerated(file) {
 return fs.existsSync(file) && fs.readFileSync(file, 
'utf8').indexOf(MARKER) > 0;
 }
+
+/**
+ * A special superspawn-like implementation, required to workaround the 
issue
+ *   with java printing some necessary information to stderr instead of 
stdout.
+ *   This function redirects all stderr messages to current process 
stdout. See
+ *   https://issues.apache.org/jira/browse/CB-9971 for explanation.
+ *
+ * @param   {String}cmd   A command to spawn
+ * @param   {String[]}  args  Command arguments. Note that on Windows 
arguments
+ *   will be concatenated into string and passed to 'cmd.exe' along with 
'/s'
+ *   and '/c' swithces for proper space-in-path handling
+ *
+ * @return  {Promise}A promise, rejected with error message, if
+ *   underlying command exits with nonzero exit code, fulfilled otherwise
+ */
+function spawnWithStderrRedirect(cmd, args) {
+var opts = { stdio: 'pipe' };
+
+if (process.platform === 'win32') {
+// Work around spawn not being able to find .bat files.
+var joinedArgs = [cmd]
+.concat(args)
+.map(function(a){
+// Add quotes to arguments which contains whitespaces
+if (/^[^"].* .*[^"]/.test(a)) return '"' + a + '"';
+return a;
+}).join(' ');
+
+args = ['/s', '/c'].concat('"' + joinedArgs + '"');
+cmd = 'cmd';
+opts.windowsVerbatimArguments = true;
+}
+
+return Q.Promise(function (resolve, reject) {
+var proc = child_process.spawn(cmd, args, opts);
+
+proc.stdout.on('data', process.stdout.write.bind(process.stdout));
+proc.stderr.on('data', function (data) {
+var isRedirectNeeded = data.toString().match(/^Picked up 
_JAVA_OPTIONS: /i);
--- End diff --

/regex/.test(str) is faster when all you need is a boolean result, not the 
detailed info that match() returns.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ubuntu pull request: Cordova-Ubuntu Platform Release 4.3.1...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ubuntu/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ubuntu pull request: build: fix mechanism for additional d...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ubuntu/pull/15


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-8940 Setting z-index values...

[dblotsky]

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158243037
  
You could place the value into a constant named `HIGHEST_POSSIBLE_Z_INDEX`, 
and then it would be both documented and easier to maintain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-8940 Setting z-index values...

[rakatyal]

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158243766
  
Good suggestion. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-8940 Setting z-index values...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158245865
  
Agree with above. Otherwise, LGTM. Tested on an 8.1 device (and by tested I 
mean I took a picture, not really sure what else to do here). I don't really 
see how this can mess anything up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-8940 Setting z-index values...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/140


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: CB-8863 Fix block usage...

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/49

CB-8863 Fix block usage of self



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-plugin-media-capture 
CB-8863

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media-capture/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #49


commit d19ce1a3fe5302a92a66c9d7d4e4c68f5c759534
Author: Jesse MacFadyen 
Date:   2015-11-20T00:22:30Z

CB-8863 Fix block usage of self




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

[Steven Gill]

Alright, 5.4.1 vote thread is out.

Release notes:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/RELEASENOTES.md#541-nov-19-2015

Mainly, these three issues have been resolved:
* https://issues.apache.org/jira/browse/CB-9975
* https://issues.apache.org/jira/browse/CB-9976
* https://issues.apache.org/jira/browse/CB-9987

Please keep these in mind as you test the RC.

@David, I can review those changes. Can you send it as PRs and send me the
links. They can go out in the next tools release (soon)!



On Tue, Nov 17, 2015 at 11:54 AM, Frederico Galvão <
frederico.gal...@pontoget.com.br> wrote:

> +1 please.
>
> 2015-11-17 15:36 GMT-02:00 David Barth :
>
> > And if there is a release, there are 2 fixes i'd love to get in for
> Ubuntu:
> >
> > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9590 - to be
> > compaitble with the new registry at last
> > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9618 - fix the
> > www
> > non-sense in icon paths
> >
> > I can re-do pull-requests if those 2 are eligible for that patch release.
> > Let me know
> >
> > David
> >
> > On Tue, Nov 17, 2015 at 6:24 PM, David Barth 
> > wrote:
> >
> > > Yeah, +1 for https://issues.apache.org/jira/browse/CB-9987 to help
> > manage
> > > the transition of platforms to the 5.x world
> > >
> > >
> > > On Tue, Nov 17, 2015 at 3:24 AM, Steven Gill 
> > > wrote:
> > >
> > >> Need to do a patch release for Lib & CLI.
> > >>
> > >> Fixing these 3 issues:
> > >> https://issues.apache.org/jira/browse/CB-9976
> > >> https://issues.apache.org/jira/browse/CB-9987
> > >> https://issues.apache.org/jira/browse/CB-9975
> > >>
> > >> Thoughts?
> > >>
> > >
> > >
> >
>
>
>
> --
>
> *Frederico Galvão*
>
> Diretor de Tecnologia
>
> PontoGet Inovação Web
>
>
> ( +55(62) 8131-5720
>
> * www.pontoget.com.br 
>

Introduction

[Marco Antonio Ortega Moulin]

Hello, I want to contribute to the cordova project since we are trying to 
implement a resumable feature for file uploading. I already did a fork of the 
FileTransfer plugin and want to send a pull request.

I already joined the mailing list, signed the ICLA, created an account in 
Apache Jira and this is my email for a brief introduction.

I’m a 15+ years experienced PHP/MySQL web developer, I’m from México and I’m 33 
years old.

Thank you for adding me to the contributors.

Marco Antonio Ortega Moulin
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] Plugins Release!

[Joe Bowser]

I vote +1

* Ran coho audit-license-headers over the relevant repos
* Ran mobilespec on android and ios

On Thu, Nov 19, 2015 at 12:11 PM, Steven Gill 
wrote:

> Please review and vote on the release of this plugins release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10035
>
> The plugins have been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10035/
>
> The packages were published from their corresponding git tags:
> cordova-plugin-battery-status: 1.1.0 (8f3f8a8d66)
> cordova-plugin-camera: 1.2.0 (437cf3d93a)
> cordova-plugin-console: 1.0.1 (f055daec45)
> cordova-plugin-contacts: 1.1.0 (e47559b0d4)
> cordova-plugin-device: 1.0.1 (b3da8484ec)
> cordova-plugin-device-motion: 1.1.1 (28394c4607)
> cordova-plugin-device-orientation: 1.0.1 (427d49f612)
> cordova-plugin-dialogs: 1.1.1 (b698f3a7b5)
> cordova-plugin-file: 3.0.0 (cba009c1e3)
> cordova-plugin-file-transfer: 1.3.0 (05873a07fd)
> cordova-plugin-geolocation: 1.0.1 (e529db6abd)
> cordova-plugin-globalization: 1.0.1 (cd9d52355a)
> cordova-plugin-inappbrowser: 1.0.1 (47e332fc92)
> cordova-plugin-legacy-whitelist: 1.1.0 (d5af95b3ab)
> cordova-plugin-media: 1.0.1 (b3056343fc)
> cordova-plugin-media-capture: 1.0.1 (9af90d8540)
> cordova-plugin-network-information: 1.0.1 (d8bdb0e953)
> cordova-plugin-splashscreen: 2.1.0 (4b1df233ae)
> cordova-plugin-statusbar: 1.0.1 (5e96b2a345)
> cordova-plugin-test-framework: 1.0.1 (0167a2f9ab)
> cordova-plugin-vibration: 1.2.0 (274003cb33)
> cordova-plugin-whitelist: 1.1.0 (521e62b0fd)
>
> Upon a successful vote I will upload the archives to dist/, upload
> them to npm and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ran mobilespec on android and ios
>

[GitHub] cordova-docs pull request: CB-10045: Made table elements in docs e...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/427

CB-10045: Made table elements in docs extend bootstrap table classes

I'm adding a docs page and need table styles. This affects the platform 
support table FYI. @dblotsky please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/riknoll/cordova-docs CB-10045

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/427.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #427


commit 604519009c02e7d13a1fa106984ad7c119799980
Author: riknoll 
Date:   2015-11-19T20:44:46Z

CB-10045: Made table elements in docs extend bootstrap table classes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[VOTE] Plugins Release!

[Steven Gill]

Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10035

The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10035/

The packages were published from their corresponding git tags:
cordova-plugin-battery-status: 1.1.0 (8f3f8a8d66)
cordova-plugin-camera: 1.2.0 (437cf3d93a)
cordova-plugin-console: 1.0.1 (f055daec45)
cordova-plugin-contacts: 1.1.0 (e47559b0d4)
cordova-plugin-device: 1.0.1 (b3da8484ec)
cordova-plugin-device-motion: 1.1.1 (28394c4607)
cordova-plugin-device-orientation: 1.0.1 (427d49f612)
cordova-plugin-dialogs: 1.1.1 (b698f3a7b5)
cordova-plugin-file: 3.0.0 (cba009c1e3)
cordova-plugin-file-transfer: 1.3.0 (05873a07fd)
cordova-plugin-geolocation: 1.0.1 (e529db6abd)
cordova-plugin-globalization: 1.0.1 (cd9d52355a)
cordova-plugin-inappbrowser: 1.0.1 (47e332fc92)
cordova-plugin-legacy-whitelist: 1.1.0 (d5af95b3ab)
cordova-plugin-media: 1.0.1 (b3056343fc)
cordova-plugin-media-capture: 1.0.1 (9af90d8540)
cordova-plugin-network-information: 1.0.1 (d8bdb0e953)
cordova-plugin-splashscreen: 2.1.0 (4b1df233ae)
cordova-plugin-statusbar: 1.0.1 (5e96b2a345)
cordova-plugin-test-framework: 1.0.1 (0167a2f9ab)
cordova-plugin-vibration: 1.2.0 (274003cb33)
cordova-plugin-whitelist: 1.1.0 (521e62b0fd)

Upon a successful vote I will upload the archives to dist/, upload
them to npm and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran mobilespec on android and ios

[GitHub] cordova-plugin-file-transfer pull request: CB-10044 FileTransfer p...

[stevengill]

Github user stevengill commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-158201106
  
Could you add a test for this new usecase?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Introduction

[Steven Gill]

Welcome Marco!

If you need any assistance, feel free to ask us on the list or on slack (
slack.cordova.io)

Cheers,
-Steve

On Thu, Nov 19, 2015 at 12:07 PM, Marco Antonio Ortega Moulin <
ma...@marksoftsolutions.com> wrote:

> Hello, I want to contribute to the cordova project since we are trying to
> implement a resumable feature for file uploading. I already did a fork of
> the FileTransfer plugin and want to send a pull request.
>
> I already joined the mailing list, signed the ICLA, created an account in
> Apache Jira and this is my email for a brief introduction.
>
> I’m a 15+ years experienced PHP/MySQL web developer, I’m from México and
> I’m 33 years old.
>
> Thank you for adding me to the contributors.
>
> Marco Antonio Ortega Moulin
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158134364
  
@luofan189 I would also appreciate it if you could post the camera options 
you are passing to the plugin and the versions of iOS and the plugin you're 
using. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins release

[Joe Bowser]

I just did the test again on this end, and the only test failures I got
were the ones where I was expected to approve permissions.  It seems that
these tests will keep running and that the permission dialog won't block
the UI.  This is the correct behaviour, but it does mean that we have to
make sure that we give the permissions for the tests to work before we run
them.

After I approved all the permissions, I just get three Contacts failures
and a Media plugin failure.  One of the Contacts failures comes from
running on a device that I use day-to-day, since I don't get that one on
the HTC One M8, but the other three errors are consistent.

Furthermore, the manual tests for Media work fine, so I don't think that
this should block the release.

On Wed, Nov 18, 2015 at 11:24 PM, Steven Gill 
wrote:

> Oh and 1 failing cordova-plugin-file-transfer test.
>
> I'll look more into the failures tomorrow.
>
>
> On Wed, Nov 18, 2015 at 11:12 PM, Steven Gill 
> wrote:
>
> > all the plugins have been updated and are ready to be voted on.
> >
> > I am getting 10 failing tests on my nexus 5X (cordova-android@5.0.0,
> > running marshmallow on phone).
> > * contacts (always failing for me)
> > * media
> >
> > Can someone else try running mobile spec and tell me what they are
> seeing?
> >
> > I can start the vote thread once these are resolved or we decide they are
> > expected. Everything has been tagged but I can easily update tags if
> needed.
> >
> >
> >
> > On Tue, Nov 10, 2015 at 11:50 PM, julio cesar sanchez <
> > jcesarmob...@gmail.com> wrote:
> >
> >> Any more iOS experts can review my pull request?
> >>
> >> 2015-11-11 6:59 GMT+01:00 Steven Gill :
> >>
> >> > Going to move forward with this tomorrow. Any holdups, let me know.
> >> Here or
> >> > #plugins on slack.
> >> >
> >> > On Fri, Nov 6, 2015 at 2:51 PM, Richard Knoll 
> >> > wrote:
> >> >
> >> > > I plan on merging in
> >> > > https://github.com/apache/cordova-plugin-camera/pull/135 for the
> >> camera
> >> > > plugin if there are no objections.
> >> > >
> >> > > Thanks,
> >> > > Richard
> >> > >
> >> > > -Original Message-
> >> > > From: Steven Gill [mailto:stevengil...@gmail.com]
> >> > > Sent: Friday, November 6, 2015 11:38 AM
> >> > > To: dev@cordova.apache.org
> >> > > Subject: Re: [DISCUSS] Plugins release
> >> > >
> >> > > With plugin changes, it is always nice to get reviews since it could
> >> > > affect every platform.
> >> > >
> >> > > file:146 is merged
> >> > > file: 119 LGTM
> >> > > Statusbar: 38 could use a review by iOS experts
> >> > >
> >> > > Keep em coming in!
> >> > >
> >> > > -Steve
> >> > >
> >> > > On Fri, Nov 6, 2015 at 5:53 AM, Simon MacDonald <
> >> > simon.macdon...@gmail.com
> >> > > >
> >> > > wrote:
> >> > >
> >> > > > I agree with Jason,
> >> > > >
> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> >> > > > b.com
> >> > > %2fapache%2fcordova-plugin-file%2fpull%2f146=01%7c01%7cRIKNOLL%
> >> > > 40exchange.microsoft.com
> >> >
> >>
> %7c1e652e1ff1074570a66908d2e6e1e10f%7c72f988bf86f141af91ab2d7cd011db47%7c1=HU0E%2fMPc3C2cD%2fNEtQlLGStzqfDX4Sm%2f3OdrdACiHb8%3d
> >> > > should be merged.
> >> > > >
> >> > > > Simon Mac Donald
> >> > > >
> >> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%
> >> > > > 2fsimonmacdonald=01%7c01%7cRIKNOLL%40exchange.microsoft.com
> >> %7c1e6
> >> > > >
> >> 52e1ff1074570a66908d2e6e1e10f%7c72f988bf86f141af91ab2d7cd011db47%7c1
> >> > > > data=MXNVR%2bXGeH703bFkFHohHk6EwL8amOj4btn2kNuUPiU%3d
> >> > > >
> >> > > > On Thu, Nov 5, 2015 at 8:07 PM, Jason Ginchereau
> >> > > > 
> >> > > > wrote:
> >> > > > > I think this PR should get in the release:
> >> > > >
> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> >> > > > b.com
> >> %2fapache%2fcordova-plugin-file%2fpull%2f146=01%7c01%7cRIKNO
> >> > > > LL%40exchange.microsoft.com
> >> %7c1e652e1ff1074570a66908d2e6e1e10f%7c72f98
> >> > > >
> >> 8bf86f141af91ab2d7cd011db47%7c1=HU0E%2fMPc3C2cD%2fNEtQlLGStzqfDX
> >> > > > 4Sm%2f3OdrdACiHb8%3d
> >> > > > > It might be considered a blocker, because it is a regression
> that
> >> > > > > could
> >> > > > cause loss of data when upgrading apps which relied on the default
> >> > > > AndroidPersistentFileLocation value.
> >> > > > >
> >> > > > > This would be a good one also, as it fixes a significant failure
> >> > > > > working
> >> > > > with some kinds of files on Android 5.0:
> >> > > >
> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> >> > > > b.com
> >> %2fapache%2fcordova-plugin-file%2fpull%2f119=01%7c01%7cRIKNO
> >> > > > LL%40exchange.microsoft.com
> >> %7c1e652e1ff1074570a66908d2e6e1e10f%7c72f98
> >> > > >
> >> 8bf86f141af91ab2d7cd011db47%7c1=TxHgwQq3dyT4Qlo7PM%2fQ0iU3KhtoMP
> >> > > > J5uU3UqGcY6yA%3d
> >> > > > >
> >> > > > > Jason
> >> > > > >
> >> > > > > -Original 

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/240#discussion_r45385577
  
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +212,54 @@ module.exports = GradleBuilder;
 function isAutoGenerated(file) {
 return fs.existsSync(file) && fs.readFileSync(file, 
'utf8').indexOf(MARKER) > 0;
 }
+
+/**
+ * A special superspawn-like implementation, required to workaround the 
issue
+ *   with java printing some necessary information to stderr instead of 
stdout.
+ *   This function redirects all stderr messages to current process 
stdout. See
--- End diff --

Update the comments based on the revised code that only redirects the one 
line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-10044 FileTransfer p...

[maortega]

GitHub user maortega opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/116

CB-10044 FileTransfer plug in can upload parts of a file to implement 
resumablejs

By sending the startByte and endByte to the FileTransfer plugin we are able 
to upload parts of a file therefore we can integrate this with ResumableJS

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maortega/cordova-plugin-file-transfer master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #116


commit 2cf7acb9023bedc6d23e7ff765a78522b1677d5a
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-18T20:36:33Z

Optionally receive startByte and endByte

commit 824a5b223d02e12ab21430184486ed3d4b3ca7cc
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-19T16:37:05Z

Use byte range to send a portion of a file to be able to be compatible with 
resumablejs

commit 38cc769dc92b7f32e727021508b535f3ba42e402
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-19T16:47:19Z

Send byte range of file.

commit 8a642151a16c0aa275adf5b971b180c964e9bb8d
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-19T16:47:31Z

Merge branch 'feature/Accept_file_ranges' into develop

commit 33774fd8c8b1b493a92fd6dc5bcaf531ab7c6371
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-19T16:49:41Z

Merge branch 'release/1.1'




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

[infil00p]

Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158217697
  
@Titoine Are you having problems after the patch or before? I'm not sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8

[jordancardwell]

Github user jordancardwell commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158219287
  
Hey folks.. will this one get some love any time soon?

Just checking.. I updated to latest plugin version and thought it didn't 
actually update since I was still getting those deprecation warnings.

I also created a [JIRA 
issue](https://issues.apache.org/jira/browse/CB-10047) to maybe give some 
traction


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

[Bnaya]

Github user Bnaya commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158226691
  
I will extend the scope of that issue.

This change can/should also help the apps developers to recover from 
situations that the app sent to the background not only by activity from the 
app, but also if the user hit the home button/notifications etc
And lets say the app had several IO ongoing operations by plugins. even 2 
operations by the same plugin.
The operating system can kill the activity also in such case, and then if 
the user navigates back to the app and the webview will be reloaded with resume 
event.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158217175
  
Hey all, I've added a PR to the docs repo that documents the result 
callback part of this change as well as general Android lifecycle 
considerations: https://github.com/apache/cordova-docs/pull/428


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[VOTE] Plugins Release! (attempt 2)

[Steven Gill]

Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10035

The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10035/

The packages were published from their corresponding git tags:
cordova-plugin-battery-status: 1.1.1 (946f15f5be)
cordova-plugin-camera: 2.0.0 (b3376e2389)
cordova-plugin-console: 1.0.2 (5800c5c5dc)
cordova-plugin-contacts: 2.0.0 (f282464d1d)
cordova-plugin-device: 1.1.0 (aa6a1d3be6)
cordova-plugin-device-motion: 1.2.0 (e0ca894347)
cordova-plugin-device-orientation: 1.0.2 (5c9ca663e2)
cordova-plugin-dialogs: 1.2.0 (c36d1c040d)
cordova-plugin-file: 4.0.0 (0b9d826416)
cordova-plugin-file-transfer: 1.4.0 (97031b2d75)
cordova-plugin-geolocation: 2.0.0 (57eb4dc550)
cordova-plugin-globalization: 1.0.2 (4e6174a299)
cordova-plugin-inappbrowser: 1.1.0 (1cd9205eb5)
cordova-plugin-legacy-whitelist: 1.1.1 (84f4e1242b)
cordova-plugin-media: 2.0.0 (229ba599b7)
cordova-plugin-media-capture: 1.1.0 (e1bc40b83f)
cordova-plugin-network-information: 1.1.0 (f6d2782780)
cordova-plugin-splashscreen: 3.0.0 (e2239306d6)
cordova-plugin-statusbar: 2.0.0 (7c27000b3a)
cordova-plugin-test-framework: 1.1.0 (3ad9964967)
cordova-plugin-vibration: 2.0.0 (db5313a019)
cordova-plugin-whitelist: 1.2.0 (9792fc5365)

Upon a successful vote I will upload the archives to dist/, upload
them to npm and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran mobilespec on android and ios

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

[infil00p]

Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158229277
  
@Bnaya @riknoll Unless you're getting a result back from an Activity, the 
plugin processes belong to the activity that was put in the background, and the 
plugins would die with the activity that was killed.  Therefore, there could 
only be one result returning to the application.  This issue is related to 
communication between two activities, not trying to resurrect plugin code, 
which is really just class that's not even guaranteed to have its own thread 
(although it should).

I think the problems are different enough that the scope shouldn't be 
changed here, and that the second problem that your mentioning needs to be 
fleshed out more.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-10044 FileTransfer p...

[maortega]

Github user maortega commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-158229415
  
Sure, test added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-8917: adding docs for Android lifecy...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/428

CB-8917: adding docs for Android lifecycle considerations

***Don't Merge! Dependent on [CB-8917 
PR](https://github.com/apache/cordova-android/pull/239) in cordova-android!***

@infil00p @jasongin I'd appreciate if you could look this over to make sure 
it's accurate. It adds documentation for my proposed API change, but also gives 
a general guide for handling the Activity lifecycle in Cordova apps on Android. 
I think everything before the last section applies to cordova-android as it 
currently stands, and could be useful independent of CB-8917. Any feedback is 
appreciated.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/riknoll/cordova-docs CB-8917-docs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #428


commit 46e6127053e69bdf718e4726a0247f6362bd68c7
Author: riknoll 
Date:   2015-11-19T20:37:46Z

CB-8917: adding docs for Android lifecycle considerations




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

[Titoine]

Github user Titoine commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158219586
  
@infil00p Before the patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158225021
  
Also, I don't think you can get into a situation where you have two 
Activity results pending (correct me if I'm wrong on that one).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] Plugins Release!

[Steven Gill]

Sorry these tags seem to be wrong. I have to cancel this vote and restart
once I get the write output for tags.

On Thu, Nov 19, 2015 at 12:43 PM, Joe Bowser  wrote:

> I vote +1
>
> * Ran coho audit-license-headers over the relevant repos
> * Ran mobilespec on android and ios
>
> On Thu, Nov 19, 2015 at 12:11 PM, Steven Gill 
> wrote:
>
> > Please review and vote on the release of this plugins release
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-10035
> >
> > The plugins have been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10035/
> >
> > The packages were published from their corresponding git tags:
> > cordova-plugin-battery-status: 1.1.0 (8f3f8a8d66)
> > cordova-plugin-camera: 1.2.0 (437cf3d93a)
> > cordova-plugin-console: 1.0.1 (f055daec45)
> > cordova-plugin-contacts: 1.1.0 (e47559b0d4)
> > cordova-plugin-device: 1.0.1 (b3da8484ec)
> > cordova-plugin-device-motion: 1.1.1 (28394c4607)
> > cordova-plugin-device-orientation: 1.0.1 (427d49f612)
> > cordova-plugin-dialogs: 1.1.1 (b698f3a7b5)
> > cordova-plugin-file: 3.0.0 (cba009c1e3)
> > cordova-plugin-file-transfer: 1.3.0 (05873a07fd)
> > cordova-plugin-geolocation: 1.0.1 (e529db6abd)
> > cordova-plugin-globalization: 1.0.1 (cd9d52355a)
> > cordova-plugin-inappbrowser: 1.0.1 (47e332fc92)
> > cordova-plugin-legacy-whitelist: 1.1.0 (d5af95b3ab)
> > cordova-plugin-media: 1.0.1 (b3056343fc)
> > cordova-plugin-media-capture: 1.0.1 (9af90d8540)
> > cordova-plugin-network-information: 1.0.1 (d8bdb0e953)
> > cordova-plugin-splashscreen: 2.1.0 (4b1df233ae)
> > cordova-plugin-statusbar: 1.0.1 (5e96b2a345)
> > cordova-plugin-test-framework: 1.0.1 (0167a2f9ab)
> > cordova-plugin-vibration: 1.2.0 (274003cb33)
> > cordova-plugin-whitelist: 1.1.0 (521e62b0fd)
> >
> > Upon a successful vote I will upload the archives to dist/, upload
> > them to npm and post the corresponding blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ran mobilespec on android and ios
> >
>

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

[Bnaya]

Github user Bnaya commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158220594
  
@riknoll, after going over the docs (which looks great btw) its seems it 
supports only single plugin result
What if you wait for two or more plugins responses? like file system 
operation and camera plugin result?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8

[jcesarmobile]

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158220443
  
you updated from the github url? or just with a cordova plugin add 
cordova-plugin-statusbar?
I suppose you did the latest, because the warnings were fixed and the 
changes were merged some time ago, but the plugin hasn't been released yet, 
it's on the release proccess right now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8

[jcesarmobile]

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158222576
  
Oh, sorry, I'm talking about iOS 7 deprecated warnings, not iOS 8 warnings

Anyway, I already told that [[UIDevice currentDevice] orientation] isn't 
reliable, [[UIApplication sharedApplication] statusBarOrientation] should be 
used instead, I've assigned the issue to myself and I'll create a new pull 
request this weekend


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158224722
  
@Bnaya That is correct and it was intentional. Is there a need for 
extending this to all plugin callbacks currently pending? The way I see it, the 
burden is on the app developer for being careful about what plugins are 
launching external Activities and maintaining their state accordingly (for 
example, not launching the camera activity while waiting on a file transfer). 
Plugins have access to the Activity lifecycle on the native side, so they 
should be able to handle whatever is happening. I guess plugins lose the 
ability to notify the javascript side about what's going on, (like a file 
transfer failing) but hopefully the app developer is being careful so that 
those situations don't occur.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins release

[Steven Gill]

Thanks Joe!

P.S. The "r" prefixed tags messed up my coho commands to create the tgz and
print the corresponding tags. I have now fixed that problem by not
stripping the "r" for plugin tags so those tags fail the semver check.

Attempt 2 for plugins vote is now out.


On Thu, Nov 19, 2015 at 11:03 AM, Joe Bowser  wrote:

> I just did the test again on this end, and the only test failures I got
> were the ones where I was expected to approve permissions.  It seems that
> these tests will keep running and that the permission dialog won't block
> the UI.  This is the correct behaviour, but it does mean that we have to
> make sure that we give the permissions for the tests to work before we run
> them.
>
> After I approved all the permissions, I just get three Contacts failures
> and a Media plugin failure.  One of the Contacts failures comes from
> running on a device that I use day-to-day, since I don't get that one on
> the HTC One M8, but the other three errors are consistent.
>
> Furthermore, the manual tests for Media work fine, so I don't think that
> this should block the release.
>
> On Wed, Nov 18, 2015 at 11:24 PM, Steven Gill 
> wrote:
>
> > Oh and 1 failing cordova-plugin-file-transfer test.
> >
> > I'll look more into the failures tomorrow.
> >
> >
> > On Wed, Nov 18, 2015 at 11:12 PM, Steven Gill 
> > wrote:
> >
> > > all the plugins have been updated and are ready to be voted on.
> > >
> > > I am getting 10 failing tests on my nexus 5X (cordova-android@5.0.0,
> > > running marshmallow on phone).
> > > * contacts (always failing for me)
> > > * media
> > >
> > > Can someone else try running mobile spec and tell me what they are
> > seeing?
> > >
> > > I can start the vote thread once these are resolved or we decide they
> are
> > > expected. Everything has been tagged but I can easily update tags if
> > needed.
> > >
> > >
> > >
> > > On Tue, Nov 10, 2015 at 11:50 PM, julio cesar sanchez <
> > > jcesarmob...@gmail.com> wrote:
> > >
> > >> Any more iOS experts can review my pull request?
> > >>
> > >> 2015-11-11 6:59 GMT+01:00 Steven Gill :
> > >>
> > >> > Going to move forward with this tomorrow. Any holdups, let me know.
> > >> Here or
> > >> > #plugins on slack.
> > >> >
> > >> > On Fri, Nov 6, 2015 at 2:51 PM, Richard Knoll <
> rikn...@microsoft.com>
> > >> > wrote:
> > >> >
> > >> > > I plan on merging in
> > >> > > https://github.com/apache/cordova-plugin-camera/pull/135 for the
> > >> camera
> > >> > > plugin if there are no objections.
> > >> > >
> > >> > > Thanks,
> > >> > > Richard
> > >> > >
> > >> > > -Original Message-
> > >> > > From: Steven Gill [mailto:stevengil...@gmail.com]
> > >> > > Sent: Friday, November 6, 2015 11:38 AM
> > >> > > To: dev@cordova.apache.org
> > >> > > Subject: Re: [DISCUSS] Plugins release
> > >> > >
> > >> > > With plugin changes, it is always nice to get reviews since it
> could
> > >> > > affect every platform.
> > >> > >
> > >> > > file:146 is merged
> > >> > > file: 119 LGTM
> > >> > > Statusbar: 38 could use a review by iOS experts
> > >> > >
> > >> > > Keep em coming in!
> > >> > >
> > >> > > -Steve
> > >> > >
> > >> > > On Fri, Nov 6, 2015 at 5:53 AM, Simon MacDonald <
> > >> > simon.macdon...@gmail.com
> > >> > > >
> > >> > > wrote:
> > >> > >
> > >> > > > I agree with Jason,
> > >> > > >
> > >>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> > >> > > > b.com
> > >> > >
> %2fapache%2fcordova-plugin-file%2fpull%2f146=01%7c01%7cRIKNOLL%
> > >> > > 40exchange.microsoft.com
> > >> >
> > >>
> >
> %7c1e652e1ff1074570a66908d2e6e1e10f%7c72f988bf86f141af91ab2d7cd011db47%7c1=HU0E%2fMPc3C2cD%2fNEtQlLGStzqfDX4Sm%2f3OdrdACiHb8%3d
> > >> > > should be merged.
> > >> > > >
> > >> > > > Simon Mac Donald
> > >> > > >
> > >>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%
> > >> > > > 2fsimonmacdonald=01%7c01%7cRIKNOLL%
> 40exchange.microsoft.com
> > >> %7c1e6
> > >> > > >
> > >> 52e1ff1074570a66908d2e6e1e10f%7c72f988bf86f141af91ab2d7cd011db47%7c1
> > >> > > > data=MXNVR%2bXGeH703bFkFHohHk6EwL8amOj4btn2kNuUPiU%3d
> > >> > > >
> > >> > > > On Thu, Nov 5, 2015 at 8:07 PM, Jason Ginchereau
> > >> > > > 
> > >> > > > wrote:
> > >> > > > > I think this PR should get in the release:
> > >> > > >
> > >>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> > >> > > > b.com
> > >> %2fapache%2fcordova-plugin-file%2fpull%2f146=01%7c01%7cRIKNO
> > >> > > > LL%40exchange.microsoft.com
> > >> %7c1e652e1ff1074570a66908d2e6e1e10f%7c72f98
> > >> > > >
> > >> 8bf86f141af91ab2d7cd011db47%7c1=HU0E%2fMPc3C2cD%2fNEtQlLGStzqfDX
> > >> > > > 4Sm%2f3OdrdACiHb8%3d
> > >> > > > > It might be considered a blocker, because it is a regression
> > that
> > >> > > > > could
> > >> > > > cause loss of data when upgrading apps which relied on the
> default
> > >> > > > AndroidPersistentFileLocation value.

Re: Removal of r prefix on plugin tags

[Carlos Santana]

For existing tags I think it doesn't hurt to have both the r and without the r 
to avoid braking someone on the same commit/release

For new releases then do not have the r

- Carlos
@csantanapr

> On Nov 19, 2015, at 1:20 AM, Steven Gill  wrote:
> 
> Hey everyone
> 
> I made new tags for all of our plugins on github replacing the prefixed r.
> 
> Example, cordova-plugin-camera had a tag r0.3.0. I know replaced that with
> an identical tag 0.3.0.
> 
> I initially removed the r prefixed tags but have been contacted by people
> using cocoapods [1] about them breaking. I added them back for now.
> 
> I'm planning on contacting the maintainers of the pods and seeing if they
> can update their spec to use the non r prefixed version.
> 
> Would removing the r prefixed tags impact anyone else?
> 
> [1] https://cocoapods.org/pods/CordovaPlugin-console

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

[Titoine]

Github user Titoine commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158017890
  
Hi,
First of all, thanks from the great work!
But I'm getting a lot of crash from this problem.

Do you have any idea when this will be merge ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10029: rename edge to dev

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/426


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10029: rename edge to dev

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/426#issuecomment-158266198
  
LGTM. Rebasing first actually made this surprisingly easy,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10045: Made table elements in docs e...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/427#issuecomment-158266219
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ubuntu pull request: Cordova-Ubuntu Platform Release 4.3.1...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-ubuntu/pull/19

Cordova-Ubuntu Platform Release 4.3.1 

From the RELEASENOTES.md

* default icon name www/img/logo.png
* add defaut icon parameter to config.xml
* use QUrl::fromLocalFile()
* set mainUrl when the file exists
* fix critical issue introduced by general URL support changes earlier
* check if content src points to a url or local file
* fix typo
* better info msg
* don't check deps at create time and propose to auto-install once at build 
time; this is for the native/desktop build

See release preparation logs at 
https://issues.apache.org/jira/browse/CB-10030

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-ubuntu 4.3.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ubuntu/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit d3a674f2a07ab269bfb2e2acaa60dc2ab25c4d50
Author: Alberto Mardegan 
Date:   2015-10-08T06:36:31Z

build: fix mechanism for additional dependencies

Instead of expecting plugins to store their configuration files in
a "configs/" directory, read the dependencies from the config.xml file.
The reason why the old method does not work is that the 
element of the plugin.xml file doesn't support a "target-dir" attribute.

By using the  element, instead, we don't need to do any
changes to cordova lib, and all the plugin configuration can now be
stored in the plugin.xml file.

Example:


  




  ["signond", "libsignon-qt5"]
  ["signond-dev:ARCH", "libsignon-qt5-dev:ARCH"]

  


commit 576fca86f5bc51df285ad5b3a94332039bf75161
Author: David Barth 
Date:   2015-09-30T16:20:19Z

add defaut icon parameter to config.xml

commit 7a5ac6dbc046bb9fd75c5de313723ee90907f7d6
Author: david-barth-canonical 
Date:   2015-10-27T11:24:55Z

Merge pull request #1 from mardy/additional-dependencies

build: fix mechanism for additional plugin dependencies

commit 33f61c7fb7d2370c907beec51a604026b62a57ea
Author: David Barth 
Date:   2015-10-28T14:30:39Z

default icon name www/img/logo.png

commit aaf201b289119f498866b4dbc16e6c581b15c2ac
Author: David Barth 
Date:   2015-11-12T16:42:04Z

Merge branch 'master' of 
https://git-wip-us.apache.org/repos/asf/cordova-ubuntu

commit 75819c8186476c7d7534e6e19c6faebecd7fc9cd
Author: David Barth 
Date:   2015-09-30T14:51:05Z

check if content src points to a url or local file

commit 86e994affa1d7406295952bfac2d2af634485d2c
Author: David Barth 
Date:   2015-11-12T15:07:06Z

fix critical issue introduced by general URL support changes earlier

commit ac27c286c124776c2c4b938ccf86f2beaa20ac7e
Author: David Barth 
Date:   2015-11-12T16:02:26Z

set mainUrl when the file exists

commit 6fe31e7cb0568bee263cdf4c39c829f9e9bf4c97
Author: David Barth 
Date:   2015-10-28T18:50:38Z

don't check deps at create time and propose to auto-install once at build 
time; this is for the native/desktop build

commit 8eeea8d71dabfa43bbaab240ecf666d1e89efa88
Author: David Barth 
Date:   2015-11-12T15:06:16Z

better info msg

commit eea201221e2cc2cdaef06a9187f4c7f0a8af754d
Author: David Barth 
Date:   2015-11-18T10:29:12Z

Merge remote-tracking branch 'apache/master'

commit 91f655d03047583919582e841fb51c1f0df1ff63
Author: David Barth 
Date:   2015-11-18T11:19:02Z

Set VERSION to 4.4.0-dev (via coho)

commit 63d740326f2191de3bf568a06d8013395733ca2c
Author: David Barth 
Date:   2015-11-18T11:19:04Z

Update JS snapshot to version 4.4.0-dev (via coho)

commit 6630211fd507766176b2f1a1ba9a7619339a486a
Author: David Barth 
Date:   2015-11-18T13:51:34Z

fix typo

commit 51f8f3ce5204beb731d0ea8c708c9c0c533232c1
Author: david-barth-canonical 
Date:   2015-11-18T13:52:56Z

Merge pull request #4 from cordova-ubuntu/CB-9868

Cb 9868 - Should propose to install missing Ubuntu dependencies on platform 
add

commit cf5bbb6343aab3f0662550554c580bc464dc95d2
Author: David Barth 
Date:   2015-11-18T13:56:36Z

use QUrl::fromLocalFile()

commit e4a3c9e363b9d0ecda7536cc9b18342e3dfa1ab3
Author: david-barth-canonical 
Date:   2015-11-18T13:57:26Z

Merge pull 

[GitHub] cordova-plugin-contacts pull request: CB-7021 Adds manual test for...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/83#issuecomment-158055883
  
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-7696 Document target=...

[sgrebnov]

GitHub user sgrebnov opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/124

CB-7696 Document target=_self behavior for Windows

Documenting Windows behavior as per 
https://issues.apache.org/jira/browse/CB-7696

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser CB-7696

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #124


commit 8c0487f0d7a2098ff6308af6c82288388f085873
Author: Sergey Grebnov 
Date:   2015-11-19T13:27:11Z

CB-7696 Document target=_self behavior for Windows




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

[luofan189]

Github user luofan189 commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158082173
  
Is this issue only fixed on Android side? I am seeing the same issue on iOS 
with the latest release as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-7021 Adds manual test for...

[daserge]

Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/83#discussion_r45337850
  
--- Diff: tests/tests.js ---
@@ -525,6 +525,28 @@ exports.defineManualTests = function(contentEl, 
createActionButton) {
 }, obj);
 }
 
+function pickContact() {
+var results = document.getElementById('contact_results');
+navigator.contacts.pickContact(
+function (contact) {
+var s = "";
+if (!contact)
--- End diff --

Nit: Embrace into curly braces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-7021 Adds manual test for...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/83


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-7021 Adds manual test for...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/83#issuecomment-158054090
  
@daserge, updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158127870
  
@luofan189 What issue are you seeing? I can take a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

[luofan189]

Github user luofan189 commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158132005
  
@riknoll only the low resolution image is saved on iOS device as well. I 
set the targetWidth and targetHeight to 1024x768


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158133797
  
@luofan189 I'll try and reproduce this. If you don't mind, let's move this 
conversation to the JIRA issue:

https://issues.apache.org/jira/browse/CB-5479


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org