[GitHub] cordova-plugin-geolocation pull request: CB-10278 geolocation watc...

[sgrebnov]

GitHub user sgrebnov opened a pull request:

https://github.com/apache/cordova-plugin-geolocation/pull/63

CB-10278 geolocation watchPosition doesn't return watchID string

https://issues.apache.org/jira/browse/CB-10278

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-geolocation CB-10278

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-geolocation/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #63


commit e9626e5d66ba94d7eea9938a7d018592872d247d
Author: sgrebnov 
Date:   2015-12-29T16:52:56Z

CB-10278 geolocation watchPosition doesn't return watchID string




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-7754 - [Geolocation] S...

[MrMotski]

Github user MrMotski commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/28#issuecomment-167848233
  
Is there any update to @Zorgatone's question? I'm also very interested to 
know the answer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-9240 Cordova splash s...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/72

CB-9240 Cordova splash screen plugin iPad landscape mode issue

[Jira issue](https://issues.apache.org/jira/browse/CB-9240)

Aligns `shouldAutoRotate` default value with [parent CDVViewController 
behavior](https://github.com/apache/cordova-ios/blob/d3c5519719d172bfcf6d994c740615b6fdfa91e6/CordovaLib/Classes/Public/CDVViewController.m#L352-L355).

This fix also does not break iPhone rotation behavior - it's being turned 
on after splashscreen hide and swizzling dismissal.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-9240

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/72.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #72


commit 3b2e9e59124e345c61235ca132e8f519d7df8ead
Author: daserge 
Date:   2015-12-29T19:08:02Z

CB-9240 Cordova splash screen plugin iPad landscape mode issue

Aligns shouldRotate default value with parent CDVViewController behavior




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-9240 Cordova splash s...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/72#issuecomment-167857941
  
@shazron, could you please take a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request:

[bradleyjames]

Github user bradleyjames commented on the pull request:


https://github.com/apache/cordova-lib/commit/07271a5c6162c0b2bee55e1ea23f91ebdfbbb34c#commitcomment-15193029
  
In cordova-lib/src/plugman/install.js:
In cordova-lib/src/plugman/install.js on line 573:
This breaks plugman's support for the --www option.  The comment above is 
only true if the --www property is not provided.  This also breaks the platform 
centric development model outlined 
[here](http://cordova.apache.org/docs/en/latest/plugin_ref/plugman.html).

I logged [an issue](https://issues.apache.org/jira/browse/CB-10274) for 
this on the cordova jira.

I'll try to submit a patch but I'm new to nodejs and cordova development.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10274 Honor --www parameter in plugma...

[bradleyjames]

GitHub user bradleyjames opened a pull request:

https://github.com/apache/cordova-lib/pull/359

CB-10274 Honor --www parameter in plugman.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bradleyjames/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/359.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #359


commit e2f622942f4db1954d9603b3249f83e7f4678e6b
Author: Brad Reynolds 
Date:   2015-12-29T18:41:08Z

CB-10274 Honor --www parameter in plugman.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10263 Fix splashscree...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/69


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-10277 Error callback s...

[sgrebnov]

GitHub user sgrebnov opened a pull request:

https://github.com/apache/cordova-plugin-geolocation/pull/62

CB-10277 Error callback should be called w/ PositionError if deny location 
access

https://issues.apache.org/jira/browse/CB-10277

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-geolocation CB-10277

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-geolocation/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #62


commit 9fcdcfc88a17c10c701aa36f18a06a74e6fce831
Author: sgrebnov 
Date:   2015-12-29T09:26:25Z

CB-10277 Error callback should be called w/ PositionError when location 
access is denied




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: Fix crash on deny permiss...

[sgrebnov]

Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/57#issuecomment-167757946
  
@ochakov could you please create associated JIRA issue or post repro steps 
here.
http://cordova.apache.org/contribute/issues.html

I don't see app crash when I deny location access and can see error 
callback is correctly called in this case. From the code `context` is set in 
`execute` method so technically this should never happen or there is some 
tricky case (background/foreground or something) and should be investigated 
further to find root cause.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Running tests

[Alexander Sorokin (Akvelon)]

Hi Sean,

Welcome!

You'll need cordova-plugin-test-framework to run plugin tests.
We also have a "mobile spec" tool which can be used to create a test app:
https://github.com/apache/cordova-mobile-spec/tree/master/createmobilespec

You can create test app which will include the tests for inappbrowser plugin 
and Android platform using the following command:

node cordova-mobile-spec/createmobilespec/createmobilespec.js mobilespec 
--android --plugins "cordova-plugin-inappbrowser"

Then just "cd mobilespec" and "cordova run".

Please note that the inappbrowser plugin doesn't have automated tests so you 
can run only manual ones.

Tread Carefully!
Alexander Sorokin

-Original Message-
From: seank@gmail.com [mailto:seank@gmail.com] On Behalf Of Sean Kelly
Sent: Tuesday, December 29, 2015 4:19 AM
To: dev@cordova.apache.org
Subject: Running tests

I'm interested in contributing to cordova-plugin-inappbrowser

I read in the contributor guidelines:

When we say "run the test suites" this includes:

   - All automated tests in cordova-mobilespec
   - Manual tests in cordova-mobilespec that might be affected by the change
   - npm test for JS linting
   - Any platform-specific unit tests
  - cordova-android/test
  - cordova-ios/CordovaLibTests
  - cordova-js: jake test
  - cordova-plugman: npm test

The package.json for the rpo does not have the test command above hooked up. 
There is a test folder with a plugin.xml that looks promising but I can't 
figure out how to run it. None of the markdown files point to anything helpful. 
Is there a doc with steps for getting started testing plugins somewhere?

Go Carefully,

SeanK

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org