[GitHub] cordova-lib pull request: CB-10654 make hooks fire when platforms ...

[bso-intel]

Github user bso-intel commented on the pull request:

https://github.com/apache/cordova-lib/pull/395#issuecomment-186517246
  
It looks great assuming that before_platform_add and after_platform_add 
hooks could be platform specific.
My understanding about the current convention is a little different, though.
Thanks, Tony.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10654 make hooks fire when platforms ...

[bso-intel]

Github user bso-intel commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/395#discussion_r53545261
  
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot, 
targets, opts) {
 var platformsDir = path.join(projectRoot, 'platforms');
 shell.mkdir('-p', platformsDir);
 
-return hooksRunner.fire('before_platform_' + cmd, opts)
-.then(function() {
-return promiseutil.Q_chainmap(targets, function(target) {
-// For each platform, download it and call its helper script.
-var parts = target.split('@');
-var platform = parts[0];
-var spec = parts[1];
-
-return Q.when().then(function() {
-if (!(platform in platforms)) {
-spec = platform;
-platform = null;
-}
+return promiseutil.Q_chainmap(targets, function(target) {
+// For each platform, download it and call its helper script.
+var parts = target.split('@');
+var platform = parts[0];
+var spec = parts[1];
+var platDetails = '';
+
+return Q.when().then(function() {
+if (!(platform in platforms)) {
+spec = platform;
+platform = null;
+}
 
-if(platform === 'amazon-fireos') {
-events.emit('warn', 'amazon-fireos has been 
deprecated. Please use android instead.');
-}
-if(platform === 'wp8') {
-events.emit('warn', 'wp8 has been deprecated. Please 
use windows instead.');
-}
-if (platform && !spec && cmd == 'add') {
-events.emit('verbose', 'No version supplied. 
Retrieving version from config.xml...');
-spec = getVersionFromConfigFile(platform, cfg);
-}
+if(platform === 'amazon-fireos') {
+events.emit('warn', 'amazon-fireos has been deprecated. 
Please use android instead.');
+}
+if(platform === 'wp8') {
+events.emit('warn', 'wp8 has been deprecated. Please use 
windows instead.');
+}
+if (platform && !spec && cmd == 'add') {
+events.emit('verbose', 'No version supplied. Retrieving 
version from config.xml...');
+spec = getVersionFromConfigFile(platform, cfg);
+}
+
+// If --save/autosave on && no version specified, use the 
pinned version
+// e.g: 'cordova platform add android --save', 'cordova 
platform update android --save'
+if( (opts.save || autosave) && !spec ){
+spec = platforms[platform].version;
+}
 
-// If --save/autosave on && no version specified, use the 
pinned version
-// e.g: 'cordova platform add android --save', 'cordova 
platform update android --save'
-if( (opts.save || autosave) && !spec ){
-spec = platforms[platform].version;
+if (spec) {
+var maybeDir = cordova_util.fixRelativePath(spec);
+if (cordova_util.isDirectory(maybeDir)) {
+return getPlatformDetailsFromDir(maybeDir, platform);
+}
+}
+return downloadPlatform(projectRoot, platform, spec, opts);
+}).then(function(platformDetails) {
+platDetails = platformDetails;
+var hookOpts = {
+platforms :[platDetails.platform],
+nohooks :[opts.nohooks]
+};
+return hooksRunner.fire('before_platform_' + cmd, hookOpts);
--- End diff --

Now, the behavior is a little different than before.
Previously, the before_platform_add hook ran only once for all target 
platforms.
This hook could be platform agnostic.
However, by moving the hookRunner inside per platform, this hook will run 
every time each platform is added.
Not sure whether this is an issue or not, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10654 make hooks fire when platforms ...

[bso-intel]

Github user bso-intel commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/395#discussion_r53545199
  
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot, 
targets, opts) {
 var platformsDir = path.join(projectRoot, 'platforms');
 shell.mkdir('-p', platformsDir);
 
-return hooksRunner.fire('before_platform_' + cmd, opts)
-.then(function() {
-return promiseutil.Q_chainmap(targets, function(target) {
-// For each platform, download it and call its helper script.
-var parts = target.split('@');
-var platform = parts[0];
-var spec = parts[1];
-
-return Q.when().then(function() {
-if (!(platform in platforms)) {
-spec = platform;
-platform = null;
-}
+return promiseutil.Q_chainmap(targets, function(target) {
+// For each platform, download it and call its helper script.
+var parts = target.split('@');
+var platform = parts[0];
+var spec = parts[1];
+var platDetails = '';
+
+return Q.when().then(function() {
+if (!(platform in platforms)) {
+spec = platform;
+platform = null;
+}
 
-if(platform === 'amazon-fireos') {
-events.emit('warn', 'amazon-fireos has been 
deprecated. Please use android instead.');
-}
-if(platform === 'wp8') {
-events.emit('warn', 'wp8 has been deprecated. Please 
use windows instead.');
-}
-if (platform && !spec && cmd == 'add') {
-events.emit('verbose', 'No version supplied. 
Retrieving version from config.xml...');
-spec = getVersionFromConfigFile(platform, cfg);
-}
+if(platform === 'amazon-fireos') {
+events.emit('warn', 'amazon-fireos has been deprecated. 
Please use android instead.');
+}
+if(platform === 'wp8') {
+events.emit('warn', 'wp8 has been deprecated. Please use 
windows instead.');
+}
+if (platform && !spec && cmd == 'add') {
+events.emit('verbose', 'No version supplied. Retrieving 
version from config.xml...');
+spec = getVersionFromConfigFile(platform, cfg);
+}
+
+// If --save/autosave on && no version specified, use the 
pinned version
+// e.g: 'cordova platform add android --save', 'cordova 
platform update android --save'
+if( (opts.save || autosave) && !spec ){
+spec = platforms[platform].version;
+}
 
-// If --save/autosave on && no version specified, use the 
pinned version
-// e.g: 'cordova platform add android --save', 'cordova 
platform update android --save'
-if( (opts.save || autosave) && !spec ){
-spec = platforms[platform].version;
+if (spec) {
+var maybeDir = cordova_util.fixRelativePath(spec);
+if (cordova_util.isDirectory(maybeDir)) {
+return getPlatformDetailsFromDir(maybeDir, platform);
+}
+}
+return downloadPlatform(projectRoot, platform, spec, opts);
+}).then(function(platformDetails) {
+platDetails = platformDetails;
+var hookOpts = {
+platforms :[platDetails.platform],
+nohooks :[opts.nohooks]
+};
+return hooksRunner.fire('before_platform_' + cmd, hookOpts);
+}).then(function() {
+platform = platDetails.platform;
+var platformPath = path.join(projectRoot, 'platforms', 
platform);
+var platformAlreadyAdded = fs.existsSync(platformPath);
+
+if (cmd == 'add') {
+if (platformAlreadyAdded) {
+throw new CordovaError('Platform ' + platform + ' 
already added.');
 }
 
-if (spec) {
-var maybeDir = cordova_util.fixRelativePath(spec);
-if (cordova_util.isDirectory(maybeDir)) {
-return getPlatformDetailsFromDir(maybeDir, 
platform);
-}
+// Remove the .json file from the plugins 
directory, so we start clean (otherwise we
+// can get into trouble not installing plugins if 

[GitHub] cordova-lib pull request: CB-10654 make hooks fire when platforms ...

[bso-intel]

Github user bso-intel commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/395#discussion_r53545185
  
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot, 
targets, opts) {
 var platformsDir = path.join(projectRoot, 'platforms');
 shell.mkdir('-p', platformsDir);
 
-return hooksRunner.fire('before_platform_' + cmd, opts)
-.then(function() {
-return promiseutil.Q_chainmap(targets, function(target) {
-// For each platform, download it and call its helper script.
-var parts = target.split('@');
-var platform = parts[0];
-var spec = parts[1];
-
-return Q.when().then(function() {
-if (!(platform in platforms)) {
-spec = platform;
-platform = null;
-}
+return promiseutil.Q_chainmap(targets, function(target) {
+// For each platform, download it and call its helper script.
+var parts = target.split('@');
+var platform = parts[0];
+var spec = parts[1];
+var platDetails = '';
+
+return Q.when().then(function() {
+if (!(platform in platforms)) {
+spec = platform;
+platform = null;
+}
 
-if(platform === 'amazon-fireos') {
-events.emit('warn', 'amazon-fireos has been 
deprecated. Please use android instead.');
-}
-if(platform === 'wp8') {
-events.emit('warn', 'wp8 has been deprecated. Please 
use windows instead.');
-}
-if (platform && !spec && cmd == 'add') {
-events.emit('verbose', 'No version supplied. 
Retrieving version from config.xml...');
-spec = getVersionFromConfigFile(platform, cfg);
-}
+if(platform === 'amazon-fireos') {
+events.emit('warn', 'amazon-fireos has been deprecated. 
Please use android instead.');
+}
+if(platform === 'wp8') {
+events.emit('warn', 'wp8 has been deprecated. Please use 
windows instead.');
+}
+if (platform && !spec && cmd == 'add') {
+events.emit('verbose', 'No version supplied. Retrieving 
version from config.xml...');
+spec = getVersionFromConfigFile(platform, cfg);
+}
+
+// If --save/autosave on && no version specified, use the 
pinned version
+// e.g: 'cordova platform add android --save', 'cordova 
platform update android --save'
+if( (opts.save || autosave) && !spec ){
+spec = platforms[platform].version;
+}
 
-// If --save/autosave on && no version specified, use the 
pinned version
-// e.g: 'cordova platform add android --save', 'cordova 
platform update android --save'
-if( (opts.save || autosave) && !spec ){
-spec = platforms[platform].version;
+if (spec) {
+var maybeDir = cordova_util.fixRelativePath(spec);
+if (cordova_util.isDirectory(maybeDir)) {
+return getPlatformDetailsFromDir(maybeDir, platform);
+}
+}
+return downloadPlatform(projectRoot, platform, spec, opts);
+}).then(function(platformDetails) {
+platDetails = platformDetails;
+var hookOpts = {
+platforms :[platDetails.platform],
+nohooks :[opts.nohooks]
--- End diff --

opts.nohooks is already an array.
So you can change this line to the following
nohooks: opts.nohooks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10552 Replacing images in R...

[dblotsky]

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/172#issuecomment-186493087
  
@daserge Thanks for pointing me to the discussion. I forgot about it! I 
think right now the process is unintuitive. Now that the plugin docs are moving 
to the main site, perhaps we can rethink this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Cb 10637

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/504#issuecomment-186486786
  
@dhams Thanks for the PR! This is no longer an issue in master because the 
android `config.md` file was removed as part of the Android Guide improvements 
in 21afd07d1e14ff4b6dc524738ffaa4fc7594de1f. Would you mind closing this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/511#discussion_r53542149
  
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -118,72 +113,8 @@ Windows
   
  
 
-## Configuring Splash Screens in the CLI
-
-In the top-level `config.xml` file (not the one in `platforms`), add 
configuration elements like those specified here.
-
-# Example configuration
-
-Please notice that the value of the "src" attribute is relative to the 
project directory and not to the www directory.
-You can name the source image whatever you like. The internal name in the 
app are determined by Cordova.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-# Supported platforms
-
-As of now (Cordova 3.5.0 July 2014) the following platforms support splash 
screens.
-
-android
-ios
-wp8
-windows
-blackberry10
 
-# Splashscreen Plugin
+Looking for Splash screen configuration? Visit [Splashscreen 
plugin][splashscreen_plugin].
--- End diff --

I wouldn't start with "Looking for ...". Just say that the splashscreen 
plugin gives more nuanced configuration options and maybe list a few examples.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/511#discussion_r53542106
  
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -52,7 +48,7 @@ which will be used for all platforms.
 For each platform you can also define a pixel-perfect icons set to fit
 different screen resolutions.
 
-Android
+**Android**
--- End diff --

Why not headings for these instead of bold?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10263 Fix splashscree...

[dpolivy]

Github user dpolivy commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-186485912
  
@daserge Have you tested this and verified it's working? I have the 
splashscreen plugin v3.2.0, and have manually converted my existing 
`cordova-ios@4.0.1` project to using the asset catalogs. The splashscreen 
plugin appears to be looking for the `Default` filename instead of 
`LaunchImage`.

I do not have a `UILaunchImageFile` key in my plist anymore (and note the 
template does not either). Isn't the logic here backwards -- if the 
`UILaunchImageFile` key exists then that's the filename to use, otherwise it 
should use `LaunchImage` and assume it's in an asset catalog? Or will that 
break compatibility for folks who assume the default filenames are used without 
adding it to the plist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/511#discussion_r53542087
  
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -34,15 +31,14 @@ If you do not specify an icon then the Apache Cordova 
logo is used.
 
 
 
-src: (required) specifies the location of the image file, relative to your 
project directory
+Attribute |  Requirement   |Description
--- End diff --

The requirement information should be listed in the description column. See 
the example here: 
https://github.com/apache/cordova-docs/blob/master/doc/docs-STYLEGUIDE.md#xml-references


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10332 Android Guide Improvements

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/471


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53539872
  
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -132,20 +203,20 @@ To preview the app in the iOS emulator:
 
 4. Press the __Run__ button that appears in the same toolbar to the
left of the __Scheme__. That builds, deploys and runs the
-   application in the emulator. A separate emulator application opens
+   application in the simulator. A separate simulator application opens
to display the app:
 
![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/HelloWorldStandard.png)
 
-   Only one emulator may run at a time, so if you want to test the app
-   in a different emulator, you need to quit the emulator application
+   Only one simulator may run at a time, so if you want to test the app
+   in a different simulator, you need to quit the simulator application
and run a different target within Xcode.
 
-Xcode comes bundled with emulators for the latest versions of iPhone
+Xcode comes bundled with simulators for the latest versions of iPhone
 and iPad. Older versions may be available from the __Xcode 
 Preferences  Downloads  Components__ panel.
 
-## Deploy to Device
+## Deploying to Device
--- End diff --

These sections should be moved under 'Project Configuration' above. We 
should not be speaking of deployment after having a section on 'Signing the 
app'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

[sarangan12]

GitHub user sarangan12 opened a pull request:

https://github.com/apache/cordova-docs/pull/511

CB-10347: Remove 'Add icons and splash screen' article

Icons page cleanup

@nikhilkh @rakatyal @dblotsky Can you please review and merge this PR?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarangan12/cordova-docs CB-10347

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/511.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #511


commit a04c7c8c364c12ad02217ed914c7e825dd10b318
Author: Sarangan Rajamanickam 
Date:   2016-02-20T00:56:51Z

CB-10347: Remove 'Add icons and splash screen' article

Icons page cleanup




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-9478, CB-9973: Minor fixes to next s...

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/510#discussion_r53539639
  
--- Diff: www/docs/en/dev/guide/next/index.md ---
@@ -62,7 +62,7 @@ And many, many, more.
 
 One of the biggest mistakes a new Cordova developer can make is to assume 
that the performance they get on a desktop machine is the same they will get on 
a mobile device. While our mobile devices have gotten more powerful every year, 
they still lack the power and performance of a desktop. Mobile devices 
typically have much less RAM and a GPU that is a far cry from their desktop (or 
even laptop) brethren. A full list of tips here would be too much, but here are 
a few things to keep in mind (with a list of longer resources at the end for 
further research).
--- End diff --

Yeah this article is not written in a good way, but since we will be 
deleting this in near future, I only concentrated on removing the bugs and not 
changing the style of writing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-9478, CB-9973: Minor fixes to next s...

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/510#discussion_r53539593
  
--- Diff: www/docs/en/dev/guide/next/index.md ---
@@ -141,7 +144,7 @@ Debugging Cordova requires some setup. Unlike a desktop 
application, you can't s
 ## iOS Debugging
 
 ### Xcode
-With Xcode you can debug the iOS native side of your Cordova application. 
Make sure the Debug Area is showing (View -> Debug Area). Once your app is 
running on the device (or simulator), you can view log output in the debug 
area. This is where any errors or warnings will print. You can also set 
breakpoints within the source files. This will allow you to step through the 
code one line at a time and view the state of the variables at that time. The 
state of the variables is shown in the debug area when a breakpoint is hit. 
Once your app is up and running on the device, you can bring up Safari's web 
inspector (as described below) to debug the webview and js side of your 
application. For more details and help, see the Xcode guide: [Xcode Debugging 
Guide](https://developer.apple.com/library/mac/documentation/ToolsLanguages/Conceptual/Xcode_Overview/DebugYourApp/DebugYourApp.html#//apple_ref/doc/uid/TP40010215-CH18-SW1)
+With Xcode you can debug the iOS native side of your Cordova application. 
Make sure the Debug Area is showing (View -> Debug Area). Once your app is 
running on the device (or simulator), you can view log output in the debug 
area. This is where any errors or warnings will print. You can also set 
breakpoints within the source files. This will allow you to step through the 
code one line at a time and view the state of the variables at that time. The 
state of the variables is shown in the debug area when a breakpoint is hit. 
Once your app is up and running on the device, you can bring up Safari's web 
inspector (as described below) to debug the webview and js side of your 
application. For more details and help refer 
[here](https://developer.apple.com/support/debugging/).
 
 ### Safari Remote Debugging with Web Inspector
 With Safari's web inspector you can debug the webview and js code in your 
Cordova application. This works only on OSX and only with iOS 6 (and higher). 
It uses Safari to connect to your device (or the simulator) and will connect 
the browser's dev tools to the Cordova application. You get what you expect 
from dev tools - DOM inspection/manipulation, a JavaScript debugger, network 
inspection, the console, and more. Like Xcode, with Safari's web inspector you 
can set breakpoints in the JavaScript code and view the state of the variables 
at that time. You can view any errors, warnings or messages that are printed to 
the console. You can also run JavaScript commands directly from the console as 
your app is running. For more details on how to set it up and what you can do, 
see this excellent blog post: 
[http://moduscreate.com/enable-remote-web-inspector-in-ios-6/](http://moduscreate.com/enable-remote-web-inspector-in-ios-6/)
 and this guide: [Safari Web Inspector Guide](https://develop
 
er.apple.com/library/safari/documentation/AppleApplications/Conceptual/Safari_Developer_Guide/Introduction/Introduction.html)
--- End diff --

You don't have to give the entire blog URL in the text. You can just use 
the heading and make it a reference link


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-9478, CB-9973: Minor fixes to next s...

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/510#discussion_r53539495
  
--- Diff: www/docs/en/dev/guide/next/index.md ---
@@ -141,7 +144,7 @@ Debugging Cordova requires some setup. Unlike a desktop 
application, you can't s
 ## iOS Debugging
 
 ### Xcode
-With Xcode you can debug the iOS native side of your Cordova application. 
Make sure the Debug Area is showing (View -> Debug Area). Once your app is 
running on the device (or simulator), you can view log output in the debug 
area. This is where any errors or warnings will print. You can also set 
breakpoints within the source files. This will allow you to step through the 
code one line at a time and view the state of the variables at that time. The 
state of the variables is shown in the debug area when a breakpoint is hit. 
Once your app is up and running on the device, you can bring up Safari's web 
inspector (as described below) to debug the webview and js side of your 
application. For more details and help, see the Xcode guide: [Xcode Debugging 
Guide](https://developer.apple.com/library/mac/documentation/ToolsLanguages/Conceptual/Xcode_Overview/DebugYourApp/DebugYourApp.html#//apple_ref/doc/uid/TP40010215-CH18-SW1)
+With Xcode you can debug the iOS native side of your Cordova application. 
Make sure the Debug Area is showing (View -> Debug Area). Once your app is 
running on the device (or simulator), you can view log output in the debug 
area. This is where any errors or warnings will print. You can also set 
breakpoints within the source files. This will allow you to step through the 
code one line at a time and view the state of the variables at that time. The 
state of the variables is shown in the debug area when a breakpoint is hit. 
Once your app is up and running on the device, you can bring up Safari's web 
inspector (as described below) to debug the webview and js side of your 
application. For more details and help refer 
[here](https://developer.apple.com/support/debugging/).
--- End diff --

Reference link here also


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-9478, CB-9973: Minor fixes to next s...

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/510#discussion_r53539472
  
--- Diff: www/docs/en/dev/guide/next/index.md ---
@@ -132,7 +135,7 @@ It’s not uncommon to use desktop browsers and device 
simulators/emulators when
 
 It is, of course, impossible to test on every possible device on the 
market. For this reason, it’s wise to recruit many testers who have different 
devices. Although they won’t catch every problem, chances are good that they 
will discover quirks and issues that you would never find alone.
 
-Tip: It is possible on Android Nexus devices to easily flash different 
versions of Android onto the device. This simple process will allow you to 
easily test your application on different levels of Android with a single 
device, without voiding your warranty or requiring you to “jailbreak” or 
“root” your device. The Google Android factory images and instructions are 
located at: https://developers.google.com/android/nexus/images#instructions
+Tip: It is possible on Android Nexus devices to easily flash different 
versions of Android onto the device. This simple process will allow you to 
easily test your application on different levels of Android with a single 
device, without voiding your warranty or requiring you to “jailbreak” or 
“root” your device. The Google Android factory images and instructions are 
located 
[here](https://developers.google.com/android/nexus/images#instructions). 
--- End diff --

Can you please change it to reference link


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-9478, CB-9973: Minor fixes to next s...

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/510#discussion_r53539411
  
--- Diff: www/docs/en/dev/guide/next/index.md ---
@@ -62,7 +62,7 @@ And many, many, more.
 
 One of the biggest mistakes a new Cordova developer can make is to assume 
that the performance they get on a desktop machine is the same they will get on 
a mobile device. While our mobile devices have gotten more powerful every year, 
they still lack the power and performance of a desktop. Mobile devices 
typically have much less RAM and a GPU that is a far cry from their desktop (or 
even laptop) brethren. A full list of tips here would be too much, but here are 
a few things to keep in mind (with a list of longer resources at the end for 
further research).
--- End diff --

Can we rephrase this somehow? Like: "Use the following tips to improve the 
performance in mobile..." instead of comparing it with desktops,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-docs/pull/505#issuecomment-186469445
  
- Rebased on top of master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-lib/pull/363#issuecomment-186466203
  
@TimBarham addressed your other feedback


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53536875
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
 
 return null;
 }
+
+/**
+ * Gets the version of a plugin that should be fetched for a given project 
based
+ * on the plugin's engine information from NPM and the platforms/plugins 
installed
+ * in the project
+ *
+ * @param {string}  projectRoot The path to the root directory of the 
project
+ * @param {object}  pluginInfo  The NPM info of the plugin be fetched 
(e.g. the
+ *  result of calling `registry.info()`)
+ * @param {string}  cordovaVersion  The semver version of cordova-lib
+ *
+ * @return {Promise}A promise that will resolve to either 
a string
+ *  if there is a version of the plugin 
that this
+ *  project satisfies or null if there is 
not
+ */
+function getFetchVersion(projectRoot, pluginInfo, cordovaVersion) {
+// Figure out the project requirements
+if (pluginInfo.engines && pluginInfo.engines.cordovaDependencies) {
+var pluginList = getInstalledPlugins(projectRoot);
+var pluginMap = {};
+
+for(var i = 0; i < pluginList.length; i++) {
+pluginMap[pluginList[i].id] = pluginList[i].version;
+}
+
+return cordova_util.getInstalledPlatformsWithVersions(projectRoot)
+.then(function(platformVersions) {
+return determinePluginVersionToFetch(
+pluginInfo.versions,
+pluginInfo.engines.cordovaDependencies,
+pluginMap,
+platformVersions,
+cordovaVersion);
+});
+} else {
+// If we have no engine, we want to fall back to the default 
behavior
+return Q.fcall(function() {
+return null;
+});
+}
+}
+
+function determinePluginVersionToFetch(allVersions, engine, pluginMap, 
platformMap, cordovaVersion) {
+var upperBounds = [];
+var versions = [];
+
+for(var version in engine) {
+if(version.indexOf('<') === 0 && 
semver.valid(version.substring(1))) {
+// We only care about upper bounds that our project does not 
support
+if(!satisfiesProjectRequirements(engine[version], pluginMap, 
platformMap, cordovaVersion)) {
+upperBounds.push(version);
+}
+} else if(semver.valid(version) && allVersions.indexOf(version) 
!== -1) {
+versions.push(version);
+}
+}
+
+// Sort in descending order; we want to start at latest and work back
+versions.sort(semver.rcompare);
+
+for(var i = 0; i < versions.length; i++) {
+for(var j = 0; j < upperBounds.length; j++) {
+if(semver.satisfies(versions[i], upperBounds[j])) {
+// Because we sorted in desc. order, if we find an upper 
bound
+// that applies to this version (and the ones below) we 
can just
+// quit (we already filtered out ones that our project 
supports)
+return null;
+}
+}
+
+// Check the version constraint
+if(satisfiesProjectRequirements(engine[versions[i]], pluginMap, 
platformMap, cordovaVersion)) {
+// Because we sorted in descending order, we can stop 
searching once
+// we hit a satisfied constraint
+var index = versions.indexOf(versions[i]);
+if(index > 0) {
+// Return the highest plugin version below the next highest
+// constrainted version
+var nextHighest = versions[index - 1];
+return allVersions[allVersions.indexOf(nextHighest) - 1];
+} else {
+// Return the latest plugin version
+return allVersions[allVersions.length - 1];
+}
+}
+}
+
+// No constraints were satisfied
+return null;
+}
+
+function satisfiesProjectRequirements(reqs, pluginMap, platformMap, 
cordovaVersion) {
+for (var req in reqs) {
+var okay = true;
+
+if(pluginMap[req]) {
+okay = semver.satisfies(pluginMap[req], reqs[req]);
+} else if(req === 'cordova') {
+okay = semver.satisfies(cordovaVersion, reqs[req]);
+} else if(req.indexOf('cordova-') === 0) {
+// Might be a platform constraint
--- End diff --

Sure, 

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

[sarangan12]

Github user sarangan12 commented on the pull request:

https://github.com/apache/cordova-windows/pull/152#issuecomment-186449043
  
+1 to remove the lines. @alsorokin your thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53532560
  
--- Diff: www/docs/en/dev/guide/platforms/index.md ---
@@ -61,11 +61,8 @@ a lower-level alternative to the `cordova` command-line 
utility.
 ## iOS
 
 * [iOS Platform Guide](ios/index.html)
-* [iOS Shell Tool Guide](ios/tools.html)
-* [iOS Configuration](ios/config.html)
 * [iOS Plugins](ios/plugin.html)
 * [iOS WebViews](ios/webview.html)
-* [Upgrading iOS](ios/upgrade.html)
--- End diff --

deleted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-windows/pull/152#issuecomment-186445524
  
@alsorokin: is there a reason that the code under [this line][line] is even 
necessary?

[line]: 
https://github.com/apache/cordova-windows/blob/master/template/cordova/lib/log.js#L68


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-windows/pull/152#issuecomment-186444637
  
@alsorokin yep, I ran those and now it works. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/152


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53531598
  
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
   which requires registration as an Apple Developer.
 
 Once Xcode is installed, several command-line tools need to be enabled
-for Cordova to run. From the __Xcode__ menu, select __Preferences__,
-then the __Downloads__ tab. From the __Components__ panel, press the
-__Install__ button next to the __Command Line Tools__ listing.
+for Cordova to run. From the command line, run: 
+``` xcode-select --install``` 
 
-## Install Deploy Tools
+### Deployment Tools
 
-Run from comman-line terminal:
+The [ios-sim](https://www.npmjs.org/package/ios-sim) and 
+[ios-deploy](https://www.npmjs.org/package/ios-deploy) tools - allows you
+to launch iOS apps into the iOS Simulator and iOS Device from the 
command-line.
+
+To install them, run the following from command-line terminal:
 
 $ npm install -g ios-sim
 $ npm install -g ios-deploy
 
-## Create a New Project
-
-Use the `cordova` utility to set up a new project, as described in The
-Cordova [The Command-Line Interface](../../cli/index.html). For example, 
in a source-code directory:
+## Project Configuration
 
-$ cordova create hello com.example.hello "HelloWorld"
-$ cd hello
-$ cordova platform add ios
-$ cordova prepare  # or "cordova build"
+Installing Xcode will mostly set everything needed to get started.
 
-## Deploy the app
-
-To deploy the app on a connected iOS device:
-
-$ cordova run ios --device
-To deploy the app on a default iOS emulator:
-
-$ cordova emulate ios
-
-You can use __cordova run ios --list__ to see all available targets and 
-__cordova run ios --target=target_name__ to run application on a specific 
-device or emulator (for example,  `cordova run ios --target="iPhone-6"`).
-
-You can also use __cordova run --help__ to see additional build and run
-options.
-
-## Open a Project in the SDK
-
-Once ios platform is added to your project, you can open it from 
-within Xcode. Double-click to open the 
`hello/platforms/ios/hello.xcodeproj`
-file. The screen should look like this:
-
-![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/helloworld_project.png)
+## Signing an App
 
-## Deploy to Emulator
+First, you should read through the [Code Signing Support 
Page](https://developer.apple.com/support/code-signing/) 
+and the [App Distribution 
Workflows](https://developer.apple.com/library/prerelease/ios/documentation/IDEs/Conceptual/AppDistributionGuide/Introduction/Introduction.html).
 
-To preview the app in the iOS emulator:
+### Using Flags
 
-1. Make sure the _.xcodeproj_ file is selected in the left panel.
+To sign an app, you need the following parameters:
 
-2. Select the __hello__ app in the panel immediately to the right.
+| Parameter| Flag | Description

+|--|--|---
+| Code Sign Identity   | `--codeSignIdentity` | Code signing 
identity to use for signing. It can be created with Xcode and added to your 
keychain.
+| Provisioning Profile | `--provisioningProfile`  | GUID of the 
provisioning profile to be used for signing. It is copied here on your Mac: 
~/Library/MobileDevice/Provisioning\ Profiles/. Opening it in a text editor, 
you can find the GUID which needs to be specified here.
+| Code Sign Resource Rules | `--codesignResourceRules`| (Optional) Used to 
control which files in a bundle should be sealed by a code signature. For more 
details, read [The OS X Code Signing In Depth 
article](https://developer.apple.com/library/mac/technotes/tn2206/_index.html#//apple_ref/doc/uid/DTS40007919-CH1-TNTAG206)
 
 
-3. Select the intended device from the toolbar's __Scheme__ menu, such
-   as the iPhone 6.0 Simulator as highlighted here:
+### Using build.json
 
-   ![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/select_xcode_scheme.png)
+Alternatively, you could specify them in a build configuration file 
(`build.json`)
+using the `--buildConfig` argument to the same commands. Here's a sample 
of a
+build configuration file:
 
-4. Press the __Run__ button that appears in the same toolbar to the
-   left of the __Scheme__. That builds, deploys and runs the
-   application in the emulator. A separate emulator application opens
-   to display the app:
+{
+ "ios": {
+ "debug": {
+ 

[GitHub] cordova-docs pull request: CB-10337: Changing whitelist guide to r...

[sarangan12]

Github user sarangan12 commented on the pull request:

https://github.com/apache/cordova-docs/pull/509#issuecomment-186442942
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53531200
  
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
   which requires registration as an Apple Developer.
 
 Once Xcode is installed, several command-line tools need to be enabled
-for Cordova to run. From the __Xcode__ menu, select __Preferences__,
-then the __Downloads__ tab. From the __Components__ panel, press the
-__Install__ button next to the __Command Line Tools__ listing.
+for Cordova to run. From the command line, run: 
+``` xcode-select --install``` 
 
-## Install Deploy Tools
+### Deployment Tools
 
-Run from comman-line terminal:
+The [ios-sim](https://www.npmjs.org/package/ios-sim) and 
+[ios-deploy](https://www.npmjs.org/package/ios-deploy) tools - allows you
+to launch iOS apps into the iOS Simulator and iOS Device from the 
command-line.
+
+To install them, run the following from command-line terminal:
 
 $ npm install -g ios-sim
 $ npm install -g ios-deploy
 
-## Create a New Project
-
-Use the `cordova` utility to set up a new project, as described in The
-Cordova [The Command-Line Interface](../../cli/index.html). For example, 
in a source-code directory:
+## Project Configuration
 
-$ cordova create hello com.example.hello "HelloWorld"
-$ cd hello
-$ cordova platform add ios
-$ cordova prepare  # or "cordova build"
+Installing Xcode will mostly set everything needed to get started.
 
-## Deploy the app
-
-To deploy the app on a connected iOS device:
-
-$ cordova run ios --device
-To deploy the app on a default iOS emulator:
-
-$ cordova emulate ios
-
-You can use __cordova run ios --list__ to see all available targets and 
-__cordova run ios --target=target_name__ to run application on a specific 
-device or emulator (for example,  `cordova run ios --target="iPhone-6"`).
-
-You can also use __cordova run --help__ to see additional build and run
-options.
-
-## Open a Project in the SDK
-
-Once ios platform is added to your project, you can open it from 
-within Xcode. Double-click to open the 
`hello/platforms/ios/hello.xcodeproj`
-file. The screen should look like this:
-
-![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/helloworld_project.png)
+## Signing an App
 
-## Deploy to Emulator
+First, you should read through the [Code Signing Support 
Page](https://developer.apple.com/support/code-signing/) 
+and the [App Distribution 
Workflows](https://developer.apple.com/library/prerelease/ios/documentation/IDEs/Conceptual/AppDistributionGuide/Introduction/Introduction.html).
 
-To preview the app in the iOS emulator:
+### Using Flags
 
-1. Make sure the _.xcodeproj_ file is selected in the left panel.
+To sign an app, you need the following parameters:
 
-2. Select the __hello__ app in the panel immediately to the right.
+| Parameter| Flag | Description

+|--|--|---
+| Code Sign Identity   | `--codeSignIdentity` | Code signing 
identity to use for signing. It can be created with Xcode and added to your 
keychain.
+| Provisioning Profile | `--provisioningProfile`  | GUID of the 
provisioning profile to be used for signing. It is copied here on your Mac: 
~/Library/MobileDevice/Provisioning\ Profiles/. Opening it in a text editor, 
you can find the GUID which needs to be specified here.
+| Code Sign Resource Rules | `--codesignResourceRules`| (Optional) Used to 
control which files in a bundle should be sealed by a code signature. For more 
details, read [The OS X Code Signing In Depth 
article](https://developer.apple.com/library/mac/technotes/tn2206/_index.html#//apple_ref/doc/uid/DTS40007919-CH1-TNTAG206)
 
 
-3. Select the intended device from the toolbar's __Scheme__ menu, such
-   as the iPhone 6.0 Simulator as highlighted here:
+### Using build.json
 
-   ![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/select_xcode_scheme.png)
+Alternatively, you could specify them in a build configuration file 
(`build.json`)
+using the `--buildConfig` argument to the same commands. Here's a sample 
of a
+build configuration file:
 
-4. Press the __Run__ button that appears in the same toolbar to the
-   left of the __Scheme__. That builds, deploys and runs the
-   application in the emulator. A separate emulator application opens
-   to display the app:
+{
+ "ios": {
+ "debug": {
+ 

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53531054
  
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
   which requires registration as an Apple Developer.
 
 Once Xcode is installed, several command-line tools need to be enabled
-for Cordova to run. From the __Xcode__ menu, select __Preferences__,
-then the __Downloads__ tab. From the __Components__ panel, press the
-__Install__ button next to the __Command Line Tools__ listing.
+for Cordova to run. From the command line, run: 
+``` xcode-select --install``` 
 
-## Install Deploy Tools
+### Deployment Tools
 
-Run from comman-line terminal:
+The [ios-sim](https://www.npmjs.org/package/ios-sim) and 
+[ios-deploy](https://www.npmjs.org/package/ios-deploy) tools - allows you
+to launch iOS apps into the iOS Simulator and iOS Device from the 
command-line.
+
+To install them, run the following from command-line terminal:
 
 $ npm install -g ios-sim
 $ npm install -g ios-deploy
 
-## Create a New Project
-
-Use the `cordova` utility to set up a new project, as described in The
-Cordova [The Command-Line Interface](../../cli/index.html). For example, 
in a source-code directory:
+## Project Configuration
 
-$ cordova create hello com.example.hello "HelloWorld"
-$ cd hello
-$ cordova platform add ios
-$ cordova prepare  # or "cordova build"
+Installing Xcode will mostly set everything needed to get started.
 
-## Deploy the app
-
-To deploy the app on a connected iOS device:
-
-$ cordova run ios --device
-To deploy the app on a default iOS emulator:
-
-$ cordova emulate ios
-
-You can use __cordova run ios --list__ to see all available targets and 
-__cordova run ios --target=target_name__ to run application on a specific 
-device or emulator (for example,  `cordova run ios --target="iPhone-6"`).
-
-You can also use __cordova run --help__ to see additional build and run
-options.
-
-## Open a Project in the SDK
-
-Once ios platform is added to your project, you can open it from 
-within Xcode. Double-click to open the 
`hello/platforms/ios/hello.xcodeproj`
-file. The screen should look like this:
-
-![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/helloworld_project.png)
+## Signing an App
 
-## Deploy to Emulator
+First, you should read through the [Code Signing Support 
Page](https://developer.apple.com/support/code-signing/) 
+and the [App Distribution 
Workflows](https://developer.apple.com/library/prerelease/ios/documentation/IDEs/Conceptual/AppDistributionGuide/Introduction/Introduction.html).
 
-To preview the app in the iOS emulator:
+### Using Flags
 
-1. Make sure the _.xcodeproj_ file is selected in the left panel.
+To sign an app, you need the following parameters:
 
-2. Select the __hello__ app in the panel immediately to the right.
+| Parameter| Flag | Description

+|--|--|---
+| Code Sign Identity   | `--codeSignIdentity` | Code signing 
identity to use for signing. It can be created with Xcode and added to your 
keychain.
+| Provisioning Profile | `--provisioningProfile`  | GUID of the 
provisioning profile to be used for signing. It is copied here on your Mac: 
~/Library/MobileDevice/Provisioning\ Profiles/. Opening it in a text editor, 
you can find the GUID which needs to be specified here.
+| Code Sign Resource Rules | `--codesignResourceRules`| (Optional) Used to 
control which files in a bundle should be sealed by a code signature. For more 
details, read [The OS X Code Signing In Depth 
article](https://developer.apple.com/library/mac/technotes/tn2206/_index.html#//apple_ref/doc/uid/DTS40007919-CH1-TNTAG206)
 
 
-3. Select the intended device from the toolbar's __Scheme__ menu, such
-   as the iPhone 6.0 Simulator as highlighted here:
+### Using build.json
 
-   ![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/select_xcode_scheme.png)
+Alternatively, you could specify them in a build configuration file 
(`build.json`)
+using the `--buildConfig` argument to the same commands. Here's a sample 
of a
+build configuration file:
 
-4. Press the __Run__ button that appears in the same toolbar to the
-   left of the __Scheme__. That builds, deploys and runs the
-   application in the emulator. A separate emulator application opens
-   to display the app:
+{
+ "ios": {
+ "debug": {
+ 

[GitHub] cordova-docs pull request: Removing keyword index.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/508


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10333: Improving windows guide

[rakatyal]

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/506#issuecomment-186440666
  
Addressed comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53529433
  
--- Diff: cordova-lib/spec-cordova/plugin_fetch.spec.js ---
@@ -0,0 +1,203 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var plugin  = require('../src/cordova/plugin'),
+helpers = require('./helpers'),
+path= require('path'),
+shell   = require('shelljs');
+
+var testPluginVersions = [
+'0.0.0',
+'0.0.2',
+'0.7.0',
+'1.0.0',
+'1.1.0',
+'1.1.3',
+'1.3.0',
+'1.7.0',
+'1.7.1',
+'2.0.0-rc.1',
+'2.0.0-rc.2',
+'2.0.0',
+'2.3.0'
+];
+
+var cordovaVersion = '3.4.2';
+
+var tempDir = helpers.tmpDir('plugin_fetch_spec');
+var project = path.join(tempDir, 'project');
+
+function testEngineWithProject(done, testEngine, testResult) {
+plugin.getFetchVersion(project,
+{
+'engines': { 'cordovaDependencies': testEngine },
+'versions': testPluginVersions
+}, cordovaVersion)
+.then(function(toFetch) {
+expect(toFetch).toBe(testResult);
+})
+.fail(function(err) {
+console.log(err);
+expect(true).toBe(false);
+}).fin(done);
+}
+
+function createTestProject() {
+// Get the base project
+shell.cp('-R', path.join(__dirname, 'fixtures', 'base'), tempDir);
+shell.mv(path.join(tempDir, 'base'), project);
+
+// Copy a platform and a plugin to our sample project
+shell.cp('-R',
+path.join(__dirname, 'fixtures', 'platforms', 
helpers.testPlatform),
+path.join(project, 'platforms'));
+shell.cp('-R',
+path.join(__dirname, 'fixtures', 'plugins', 'android'),
+path.join(project, 'plugins'));
+}
+
+function removeTestProject() {
+shell.rm('-rf', tempDir);
+}
+
+describe('plugin fetching version selection', function(done) {
+createTestProject();
+
+it('should properly handle a mix of upper bounds and single versions', 
function() {
+var testEngine = {
+'0.0.0' : { 'cordova-android': '1.0.0' },
+'0.0.2' : { 'cordova-android': '>1.0.0' },
+'<1.0.0': { 'cordova-android': '<2.0.0' },
+'1.0.0' : { 'cordova-android': '>2.0.0' },
+'1.7.0' : { 'cordova-android': '>4.0.0' },
+'<2.3.0': { 'cordova-android': '<6.0.0' },
+'2.3.0' : { 'cordova-android': '6.0.0' }
+};
+
+testEngineWithProject(done, testEngine, '1.3.0');
+});
+
+it('should properly apply upper bound engine constraints', 
function(done) {
+var testEngine = {
+'1.0.0' : { 'cordova-android': '>2.0.0' },
+'1.7.0' : { 'cordova-android': '>4.0.0' },
+'<2.3.0': {
+'cordova-android': '<6.0.0',
+'ca.filmaj.AndroidPlugin': '<1.0.0'
+},
+'2.3.0' : { 'cordova-android': '6.0.0' }
+};
+
+testEngineWithProject(done, testEngine, null);
+});
+
+it('should ignore upperbounds if no version constraints are given', 
function(done) {
+var testEngine = {
+'<1.0.0': { 'cordova-android': '<2.0.0' }
+};
+
+testEngineWithProject(done, testEngine, null);
+});
+
+it('should apply upper bounds greater than highest version', 
function(done) {
+var testEngine = {
+'0.0.0' : {},
+'<5.0.0': { 'cordova-android': '<2.0.0' }
+};
+
+testEngineWithProject(done, testEngine, null);
+});
+
+it('should treat empty constraints as satisfied', function(done) {
+var testEngine = {
+'1.0.0' : {},
+'1.1.0' : { 

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53529097
  
--- Diff: cordova-lib/spec-cordova/plugin_fetch.spec.js ---
@@ -0,0 +1,203 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var plugin  = require('../src/cordova/plugin'),
+helpers = require('./helpers'),
+path= require('path'),
+shell   = require('shelljs');
+
+var testPluginVersions = [
+'0.0.0',
+'0.0.2',
+'0.7.0',
+'1.0.0',
+'1.1.0',
+'1.1.3',
+'1.3.0',
+'1.7.0',
+'1.7.1',
+'2.0.0-rc.1',
+'2.0.0-rc.2',
+'2.0.0',
+'2.3.0'
+];
+
+var cordovaVersion = '3.4.2';
+
+var tempDir = helpers.tmpDir('plugin_fetch_spec');
+var project = path.join(tempDir, 'project');
+
+function testEngineWithProject(done, testEngine, testResult) {
+plugin.getFetchVersion(project,
+{
+'engines': { 'cordovaDependencies': testEngine },
+'versions': testPluginVersions
+}, cordovaVersion)
+.then(function(toFetch) {
+expect(toFetch).toBe(testResult);
+})
+.fail(function(err) {
+console.log(err);
+expect(true).toBe(false);
+}).fin(done);
+}
+
+function createTestProject() {
+// Get the base project
+shell.cp('-R', path.join(__dirname, 'fixtures', 'base'), tempDir);
+shell.mv(path.join(tempDir, 'base'), project);
+
+// Copy a platform and a plugin to our sample project
+shell.cp('-R',
+path.join(__dirname, 'fixtures', 'platforms', 
helpers.testPlatform),
+path.join(project, 'platforms'));
+shell.cp('-R',
+path.join(__dirname, 'fixtures', 'plugins', 'android'),
+path.join(project, 'plugins'));
+}
+
+function removeTestProject() {
+shell.rm('-rf', tempDir);
+}
+
+describe('plugin fetching version selection', function(done) {
+createTestProject();
+
+it('should properly handle a mix of upper bounds and single versions', 
function() {
+var testEngine = {
+'0.0.0' : { 'cordova-android': '1.0.0' },
+'0.0.2' : { 'cordova-android': '>1.0.0' },
+'<1.0.0': { 'cordova-android': '<2.0.0' },
+'1.0.0' : { 'cordova-android': '>2.0.0' },
+'1.7.0' : { 'cordova-android': '>4.0.0' },
+'<2.3.0': { 'cordova-android': '<6.0.0' },
+'2.3.0' : { 'cordova-android': '6.0.0' }
+};
+
+testEngineWithProject(done, testEngine, '1.3.0');
+});
+
+it('should properly apply upper bound engine constraints', 
function(done) {
+var testEngine = {
+'1.0.0' : { 'cordova-android': '>2.0.0' },
+'1.7.0' : { 'cordova-android': '>4.0.0' },
+'<2.3.0': {
+'cordova-android': '<6.0.0',
+'ca.filmaj.AndroidPlugin': '<1.0.0'
+},
+'2.3.0' : { 'cordova-android': '6.0.0' }
+};
+
+testEngineWithProject(done, testEngine, null);
+});
+
+it('should ignore upperbounds if no version constraints are given', 
function(done) {
+var testEngine = {
+'<1.0.0': { 'cordova-android': '<2.0.0' }
+};
+
+testEngineWithProject(done, testEngine, null);
+});
+
+it('should apply upper bounds greater than highest version', 
function(done) {
+var testEngine = {
+'0.0.0' : {},
+'<5.0.0': { 'cordova-android': '<2.0.0' }
+};
+
+testEngineWithProject(done, testEngine, null);
+});
+
+it('should treat empty constraints as satisfied', function(done) {
+var testEngine = {
+'1.0.0' : {},
+'1.1.0' : { 

[GitHub] cordova-docs pull request: CB-10332 Android Guide Improvements

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/471#discussion_r53528143
  
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -23,24 +23,17 @@ title: Android Plugins
 # Android Plugins
 
 This section provides details for how to implement native plugin code
-on the Android platform. Before reading this, see Application Plugins
+on the Android platform. Before reading this, see the [Plugin Development 
Guide][plugin-dev]
--- End diff --

Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10654 make hooks fire when platforms ...

[tony--]

Github user tony-- commented on the pull request:

https://github.com/apache/cordova-lib/pull/395#issuecomment-186428877
  
@bso-intel will you take a look, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10654 make hooks fire when platforms ...

[tony--]

Github user tony-- commented on the pull request:

https://github.com/apache/cordova-lib/pull/395#issuecomment-186425912
  
I'd like to see this get fixed, so I thought I'd submit a PR, but I'm a 
node noob - this definitely needs to be reviewed before being merged in.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10654 make hooks fire when platforms ...

[tony--]

GitHub user tony-- opened a pull request:

https://github.com/apache/cordova-lib/pull/395

CB-10654 make hooks fire when platforms added from repo or dir

move `hooksRunner.fire('before_platform_'...) ` till after platform has 
been resolved, pass resolved platform instead of target.
move `hooksRunner.fire('after_platform_'...) ` into platform loop, pass 
resolved platform instead of target.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tony--/cordova-lib CB-10654

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #395


commit 045ab1ace5666a7d06752d9691e3e8298ec032bd
Author: Tony Homer 
Date:   2016-02-19T21:43:09Z

CB-10654 make hooks fire when platforms added from repo or dir




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10337: Changing whitelist guide to r...

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/509#discussion_r53513087
  
--- Diff: www/docs/en/dev/guide/appdev/whitelist/index.md ---
@@ -29,7 +29,7 @@ accessed.  By default, new apps are configured to allow 
access to any site.
 Before moving your application to production, you should formulate a 
whitelist
 and allow access to specific network domains and subdomains.
 
-For Android and iOS (as of their 4.0 releases), Cordova's security policy 
is extensible via a plugin
+For Android (as of it's 4.0 releases), Cordova's security policy is 
extensible via a plugin
--- End diff --

Corrected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-9478, CB-9973: Minor fixes to next s...

[rakatyal]

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-docs/pull/510

CB-9478, CB-9973: Minor fixes to next steps article



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs raghav-next

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/510.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #510


commit 5f5c28ecc019e2d4990ef8f10247b5e64474c82d
Author: Raghav Katyal 
Date:   2016-02-19T20:16:01Z

CB-9478, CB-9973 Minor fixes to next steps article




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10337: Changing whitelist guide to r...

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/509#discussion_r53510678
  
--- Diff: www/docs/en/dev/guide/appdev/whitelist/index.md ---
@@ -29,7 +29,7 @@ accessed.  By default, new apps are configured to allow 
access to any site.
 Before moving your application to production, you should formulate a 
whitelist
 and allow access to specific network domains and subdomains.
 
-For Android and iOS (as of their 4.0 releases), Cordova's security policy 
is extensible via a plugin
+For Android (as of it's 4.0 releases), Cordova's security policy is 
extensible via a plugin
--- End diff --

and release not releases


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10337: Changing whitelist guide to r...

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/509#discussion_r53510644
  
--- Diff: www/docs/en/dev/guide/appdev/whitelist/index.md ---
@@ -29,7 +29,7 @@ accessed.  By default, new apps are configured to allow 
access to any site.
 Before moving your application to production, you should formulate a 
whitelist
 and allow access to specific network domains and subdomains.
 
-For Android and iOS (as of their 4.0 releases), Cordova's security policy 
is extensible via a plugin
+For Android (as of it's 4.0 releases), Cordova's security policy is 
extensible via a plugin
--- End diff --

its not it's


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10337: Changing whitelist guide to r...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/509#issuecomment-186380426
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10337: Changing whitelist guide to r...

[rakatyal]

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-docs/pull/509

CB-10337: Changing whitelist guide to remove confusion about iOS



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs raghav-whitelist

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #509


commit 9b1c6e1dfb2eccbac6feaa0b837fbca48c92507c
Author: Raghav Katyal 
Date:   2016-02-19T19:21:25Z

CB-10337: Changing whitelist guide to remove confusion about iOS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...

[daserge]

Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/85#discussion_r53503210
  
--- Diff: src/android/SplashScreen.java ---
@@ -341,7 +341,11 @@ public void onCancel(DialogInterface dialog) {
 }
 });
 
-spinnerDialog.setCancelable(false);
+if(preferences.getBoolean("spinnerCancelable",true)){
--- End diff --

Why a user would need to cancel the spinner? This will not dismiss the 
splashscreen itself.
Could you please explain what is your scenario?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10332 Android Guide Improvements

[rakatyal]

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/471#issuecomment-186362161
  
:ship: it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53500398
  
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
   which requires registration as an Apple Developer.
 
 Once Xcode is installed, several command-line tools need to be enabled
-for Cordova to run. From the __Xcode__ menu, select __Preferences__,
-then the __Downloads__ tab. From the __Components__ panel, press the
-__Install__ button next to the __Command Line Tools__ listing.
+for Cordova to run. From the command line, run: 
+``` xcode-select --install``` 
 
-## Install Deploy Tools
+### Deployment Tools
 
-Run from comman-line terminal:
+The [ios-sim](https://www.npmjs.org/package/ios-sim) and 
+[ios-deploy](https://www.npmjs.org/package/ios-deploy) tools - allows you
+to launch iOS apps into the iOS Simulator and iOS Device from the 
command-line.
+
+To install them, run the following from command-line terminal:
 
 $ npm install -g ios-sim
 $ npm install -g ios-deploy
 
-## Create a New Project
-
-Use the `cordova` utility to set up a new project, as described in The
-Cordova [The Command-Line Interface](../../cli/index.html). For example, 
in a source-code directory:
+## Project Configuration
 
-$ cordova create hello com.example.hello "HelloWorld"
-$ cd hello
-$ cordova platform add ios
-$ cordova prepare  # or "cordova build"
+Installing Xcode will mostly set everything needed to get started.
 
-## Deploy the app
-
-To deploy the app on a connected iOS device:
-
-$ cordova run ios --device
-To deploy the app on a default iOS emulator:
-
-$ cordova emulate ios
-
-You can use __cordova run ios --list__ to see all available targets and 
-__cordova run ios --target=target_name__ to run application on a specific 
-device or emulator (for example,  `cordova run ios --target="iPhone-6"`).
-
-You can also use __cordova run --help__ to see additional build and run
-options.
-
-## Open a Project in the SDK
-
-Once ios platform is added to your project, you can open it from 
-within Xcode. Double-click to open the 
`hello/platforms/ios/hello.xcodeproj`
-file. The screen should look like this:
-
-![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/helloworld_project.png)
+## Signing an App
 
-## Deploy to Emulator
+First, you should read through the [Code Signing Support 
Page](https://developer.apple.com/support/code-signing/) 
+and the [App Distribution 
Workflows](https://developer.apple.com/library/prerelease/ios/documentation/IDEs/Conceptual/AppDistributionGuide/Introduction/Introduction.html).
 
-To preview the app in the iOS emulator:
+### Using Flags
 
-1. Make sure the _.xcodeproj_ file is selected in the left panel.
+To sign an app, you need the following parameters:
 
-2. Select the __hello__ app in the panel immediately to the right.
+| Parameter| Flag | Description

+|--|--|---
+| Code Sign Identity   | `--codeSignIdentity` | Code signing 
identity to use for signing. It can be created with Xcode and added to your 
keychain.
+| Provisioning Profile | `--provisioningProfile`  | GUID of the 
provisioning profile to be used for signing. It is copied here on your Mac: 
~/Library/MobileDevice/Provisioning\ Profiles/. Opening it in a text editor, 
you can find the GUID which needs to be specified here.
+| Code Sign Resource Rules | `--codesignResourceRules`| (Optional) Used to 
control which files in a bundle should be sealed by a code signature. For more 
details, read [The OS X Code Signing In Depth 
article](https://developer.apple.com/library/mac/technotes/tn2206/_index.html#//apple_ref/doc/uid/DTS40007919-CH1-TNTAG206)
 
 
-3. Select the intended device from the toolbar's __Scheme__ menu, such
-   as the iPhone 6.0 Simulator as highlighted here:
+### Using build.json
 
-   ![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/select_xcode_scheme.png)
+Alternatively, you could specify them in a build configuration file 
(`build.json`)
+using the `--buildConfig` argument to the same commands. Here's a sample 
of a
+build configuration file:
 
-4. Press the __Run__ button that appears in the same toolbar to the
-   left of the __Scheme__. That builds, deploys and runs the
-   application in the emulator. A separate emulator application opens
-   to display the app:
+{
+ "ios": {
+ "debug": {
+

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r5358
  
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
   which requires registration as an Apple Developer.
 
 Once Xcode is installed, several command-line tools need to be enabled
-for Cordova to run. From the __Xcode__ menu, select __Preferences__,
-then the __Downloads__ tab. From the __Components__ panel, press the
-__Install__ button next to the __Command Line Tools__ listing.
+for Cordova to run. From the command line, run: 
+``` xcode-select --install``` 
 
-## Install Deploy Tools
+### Deployment Tools
 
-Run from comman-line terminal:
+The [ios-sim](https://www.npmjs.org/package/ios-sim) and 
+[ios-deploy](https://www.npmjs.org/package/ios-deploy) tools - allows you
+to launch iOS apps into the iOS Simulator and iOS Device from the 
command-line.
+
+To install them, run the following from command-line terminal:
 
 $ npm install -g ios-sim
 $ npm install -g ios-deploy
 
-## Create a New Project
-
-Use the `cordova` utility to set up a new project, as described in The
-Cordova [The Command-Line Interface](../../cli/index.html). For example, 
in a source-code directory:
+## Project Configuration
 
-$ cordova create hello com.example.hello "HelloWorld"
-$ cd hello
-$ cordova platform add ios
-$ cordova prepare  # or "cordova build"
+Installing Xcode will mostly set everything needed to get started.
 
-## Deploy the app
-
-To deploy the app on a connected iOS device:
-
-$ cordova run ios --device
-To deploy the app on a default iOS emulator:
-
-$ cordova emulate ios
-
-You can use __cordova run ios --list__ to see all available targets and 
-__cordova run ios --target=target_name__ to run application on a specific 
-device or emulator (for example,  `cordova run ios --target="iPhone-6"`).
-
-You can also use __cordova run --help__ to see additional build and run
-options.
-
-## Open a Project in the SDK
-
-Once ios platform is added to your project, you can open it from 
-within Xcode. Double-click to open the 
`hello/platforms/ios/hello.xcodeproj`
-file. The screen should look like this:
-
-![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/helloworld_project.png)
+## Signing an App
 
-## Deploy to Emulator
+First, you should read through the [Code Signing Support 
Page](https://developer.apple.com/support/code-signing/) 
+and the [App Distribution 
Workflows](https://developer.apple.com/library/prerelease/ios/documentation/IDEs/Conceptual/AppDistributionGuide/Introduction/Introduction.html).
 
-To preview the app in the iOS emulator:
+### Using Flags
 
-1. Make sure the _.xcodeproj_ file is selected in the left panel.
+To sign an app, you need the following parameters:
 
-2. Select the __hello__ app in the panel immediately to the right.
+| Parameter| Flag | Description

+|--|--|---
+| Code Sign Identity   | `--codeSignIdentity` | Code signing 
identity to use for signing. It can be created with Xcode and added to your 
keychain.
+| Provisioning Profile | `--provisioningProfile`  | GUID of the 
provisioning profile to be used for signing. It is copied here on your Mac: 
~/Library/MobileDevice/Provisioning\ Profiles/. Opening it in a text editor, 
you can find the GUID which needs to be specified here.
+| Code Sign Resource Rules | `--codesignResourceRules`| (Optional) Used to 
control which files in a bundle should be sealed by a code signature. For more 
details, read [The OS X Code Signing In Depth 
article](https://developer.apple.com/library/mac/technotes/tn2206/_index.html#//apple_ref/doc/uid/DTS40007919-CH1-TNTAG206)
 
 
-3. Select the intended device from the toolbar's __Scheme__ menu, such
-   as the iPhone 6.0 Simulator as highlighted here:
+### Using build.json
 
-   ![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/select_xcode_scheme.png)
+Alternatively, you could specify them in a build configuration file 
(`build.json`)
+using the `--buildConfig` argument to the same commands. Here's a sample 
of a
+build configuration file:
 
-4. Press the __Run__ button that appears in the same toolbar to the
-   left of the __Scheme__. That builds, deploys and runs the
-   application in the emulator. A separate emulator application opens
-   to display the app:
+{
+ "ios": {
+ "debug": {
+

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53499455
  
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
   which requires registration as an Apple Developer.
 
 Once Xcode is installed, several command-line tools need to be enabled
-for Cordova to run. From the __Xcode__ menu, select __Preferences__,
-then the __Downloads__ tab. From the __Components__ panel, press the
-__Install__ button next to the __Command Line Tools__ listing.
+for Cordova to run. From the command line, run: 
+``` xcode-select --install``` 
 
-## Install Deploy Tools
+### Deployment Tools
 
-Run from comman-line terminal:
+The [ios-sim](https://www.npmjs.org/package/ios-sim) and 
+[ios-deploy](https://www.npmjs.org/package/ios-deploy) tools - allows you
+to launch iOS apps into the iOS Simulator and iOS Device from the 
command-line.
+
+To install them, run the following from command-line terminal:
 
 $ npm install -g ios-sim
 $ npm install -g ios-deploy
 
-## Create a New Project
-
-Use the `cordova` utility to set up a new project, as described in The
-Cordova [The Command-Line Interface](../../cli/index.html). For example, 
in a source-code directory:
+## Project Configuration
 
-$ cordova create hello com.example.hello "HelloWorld"
-$ cd hello
-$ cordova platform add ios
-$ cordova prepare  # or "cordova build"
+Installing Xcode will mostly set everything needed to get started.
 
-## Deploy the app
-
-To deploy the app on a connected iOS device:
-
-$ cordova run ios --device
-To deploy the app on a default iOS emulator:
-
-$ cordova emulate ios
-
-You can use __cordova run ios --list__ to see all available targets and 
-__cordova run ios --target=target_name__ to run application on a specific 
-device or emulator (for example,  `cordova run ios --target="iPhone-6"`).
-
-You can also use __cordova run --help__ to see additional build and run
-options.
-
-## Open a Project in the SDK
-
-Once ios platform is added to your project, you can open it from 
-within Xcode. Double-click to open the 
`hello/platforms/ios/hello.xcodeproj`
-file. The screen should look like this:
-
-![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/helloworld_project.png)
+## Signing an App
 
-## Deploy to Emulator
+First, you should read through the [Code Signing Support 
Page](https://developer.apple.com/support/code-signing/) 
+and the [App Distribution 
Workflows](https://developer.apple.com/library/prerelease/ios/documentation/IDEs/Conceptual/AppDistributionGuide/Introduction/Introduction.html).
 
-To preview the app in the iOS emulator:
+### Using Flags
 
-1. Make sure the _.xcodeproj_ file is selected in the left panel.
+To sign an app, you need the following parameters:
 
-2. Select the __hello__ app in the panel immediately to the right.
+| Parameter| Flag | Description

+|--|--|---
+| Code Sign Identity   | `--codeSignIdentity` | Code signing 
identity to use for signing. It can be created with Xcode and added to your 
keychain.
+| Provisioning Profile | `--provisioningProfile`  | GUID of the 
provisioning profile to be used for signing. It is copied here on your Mac: 
~/Library/MobileDevice/Provisioning\ Profiles/. Opening it in a text editor, 
you can find the GUID which needs to be specified here.
+| Code Sign Resource Rules | `--codesignResourceRules`| (Optional) Used to 
control which files in a bundle should be sealed by a code signature. For more 
details, read [The OS X Code Signing In Depth 
article](https://developer.apple.com/library/mac/technotes/tn2206/_index.html#//apple_ref/doc/uid/DTS40007919-CH1-TNTAG206)
 
 
-3. Select the intended device from the toolbar's __Scheme__ menu, such
-   as the iPhone 6.0 Simulator as highlighted here:
+### Using build.json
 
-   ![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/select_xcode_scheme.png)
+Alternatively, you could specify them in a build configuration file 
(`build.json`)
+using the `--buildConfig` argument to the same commands. Here's a sample 
of a
+build configuration file:
 
-4. Press the __Run__ button that appears in the same toolbar to the
-   left of the __Scheme__. That builds, deploys and runs the
-   application in the emulator. A separate emulator application opens
-   to display the app:
+{
+ "ios": {
+ "debug": {
+

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53499272
  
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
   which requires registration as an Apple Developer.
 
 Once Xcode is installed, several command-line tools need to be enabled
-for Cordova to run. From the __Xcode__ menu, select __Preferences__,
-then the __Downloads__ tab. From the __Components__ panel, press the
-__Install__ button next to the __Command Line Tools__ listing.
+for Cordova to run. From the command line, run: 
+``` xcode-select --install``` 
 
-## Install Deploy Tools
+### Deployment Tools
 
-Run from comman-line terminal:
+The [ios-sim](https://www.npmjs.org/package/ios-sim) and 
+[ios-deploy](https://www.npmjs.org/package/ios-deploy) tools - allows you
+to launch iOS apps into the iOS Simulator and iOS Device from the 
command-line.
+
+To install them, run the following from command-line terminal:
 
 $ npm install -g ios-sim
 $ npm install -g ios-deploy
 
-## Create a New Project
-
-Use the `cordova` utility to set up a new project, as described in The
-Cordova [The Command-Line Interface](../../cli/index.html). For example, 
in a source-code directory:
+## Project Configuration
 
-$ cordova create hello com.example.hello "HelloWorld"
-$ cd hello
-$ cordova platform add ios
-$ cordova prepare  # or "cordova build"
+Installing Xcode will mostly set everything needed to get started.
 
-## Deploy the app
-
-To deploy the app on a connected iOS device:
-
-$ cordova run ios --device
-To deploy the app on a default iOS emulator:
-
-$ cordova emulate ios
-
-You can use __cordova run ios --list__ to see all available targets and 
-__cordova run ios --target=target_name__ to run application on a specific 
-device or emulator (for example,  `cordova run ios --target="iPhone-6"`).
-
-You can also use __cordova run --help__ to see additional build and run
-options.
-
-## Open a Project in the SDK
-
-Once ios platform is added to your project, you can open it from 
-within Xcode. Double-click to open the 
`hello/platforms/ios/hello.xcodeproj`
-file. The screen should look like this:
-
-![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/helloworld_project.png)
+## Signing an App
 
-## Deploy to Emulator
+First, you should read through the [Code Signing Support 
Page](https://developer.apple.com/support/code-signing/) 
+and the [App Distribution 
Workflows](https://developer.apple.com/library/prerelease/ios/documentation/IDEs/Conceptual/AppDistributionGuide/Introduction/Introduction.html).
 
-To preview the app in the iOS emulator:
+### Using Flags
 
-1. Make sure the _.xcodeproj_ file is selected in the left panel.
+To sign an app, you need the following parameters:
 
-2. Select the __hello__ app in the panel immediately to the right.
+| Parameter| Flag | Description

+|--|--|---
+| Code Sign Identity   | `--codeSignIdentity` | Code signing 
identity to use for signing. It can be created with Xcode and added to your 
keychain.
+| Provisioning Profile | `--provisioningProfile`  | GUID of the 
provisioning profile to be used for signing. It is copied here on your Mac: 
~/Library/MobileDevice/Provisioning\ Profiles/. Opening it in a text editor, 
you can find the GUID which needs to be specified here.
+| Code Sign Resource Rules | `--codesignResourceRules`| (Optional) Used to 
control which files in a bundle should be sealed by a code signature. For more 
details, read [The OS X Code Signing In Depth 
article](https://developer.apple.com/library/mac/technotes/tn2206/_index.html#//apple_ref/doc/uid/DTS40007919-CH1-TNTAG206)
 
 
-3. Select the intended device from the toolbar's __Scheme__ menu, such
-   as the iPhone 6.0 Simulator as highlighted here:
+### Using build.json
 
-   ![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/select_xcode_scheme.png)
+Alternatively, you could specify them in a build configuration file 
(`build.json`)
+using the `--buildConfig` argument to the same commands. Here's a sample 
of a
+build configuration file:
 
-4. Press the __Run__ button that appears in the same toolbar to the
-   left of the __Scheme__. That builds, deploys and runs the
-   application in the emulator. A separate emulator application opens
-   to display the app:
+{
+ "ios": {
+ "debug": {
+

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53498542
  
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
   which requires registration as an Apple Developer.
 
 Once Xcode is installed, several command-line tools need to be enabled
-for Cordova to run. From the __Xcode__ menu, select __Preferences__,
-then the __Downloads__ tab. From the __Components__ panel, press the
-__Install__ button next to the __Command Line Tools__ listing.
+for Cordova to run. From the command line, run: 
+``` xcode-select --install``` 
 
-## Install Deploy Tools
+### Deployment Tools
 
-Run from comman-line terminal:
+The [ios-sim](https://www.npmjs.org/package/ios-sim) and 
+[ios-deploy](https://www.npmjs.org/package/ios-deploy) tools - allows you
+to launch iOS apps into the iOS Simulator and iOS Device from the 
command-line.
+
+To install them, run the following from command-line terminal:
 
 $ npm install -g ios-sim
 $ npm install -g ios-deploy
 
-## Create a New Project
-
-Use the `cordova` utility to set up a new project, as described in The
-Cordova [The Command-Line Interface](../../cli/index.html). For example, 
in a source-code directory:
+## Project Configuration
 
-$ cordova create hello com.example.hello "HelloWorld"
-$ cd hello
-$ cordova platform add ios
-$ cordova prepare  # or "cordova build"
+Installing Xcode will mostly set everything needed to get started.
 
-## Deploy the app
-
-To deploy the app on a connected iOS device:
-
-$ cordova run ios --device
-To deploy the app on a default iOS emulator:
-
-$ cordova emulate ios
-
-You can use __cordova run ios --list__ to see all available targets and 
-__cordova run ios --target=target_name__ to run application on a specific 
-device or emulator (for example,  `cordova run ios --target="iPhone-6"`).
-
-You can also use __cordova run --help__ to see additional build and run
-options.
-
-## Open a Project in the SDK
-
-Once ios platform is added to your project, you can open it from 
-within Xcode. Double-click to open the 
`hello/platforms/ios/hello.xcodeproj`
-file. The screen should look like this:
-
-![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/helloworld_project.png)
+## Signing an App
 
-## Deploy to Emulator
+First, you should read through the [Code Signing Support 
Page](https://developer.apple.com/support/code-signing/) 
+and the [App Distribution 
Workflows](https://developer.apple.com/library/prerelease/ios/documentation/IDEs/Conceptual/AppDistributionGuide/Introduction/Introduction.html).
 
-To preview the app in the iOS emulator:
+### Using Flags
 
-1. Make sure the _.xcodeproj_ file is selected in the left panel.
+To sign an app, you need the following parameters:
 
-2. Select the __hello__ app in the panel immediately to the right.
+| Parameter| Flag | Description

+|--|--|---
+| Code Sign Identity   | `--codeSignIdentity` | Code signing 
identity to use for signing. It can be created with Xcode and added to your 
keychain.
+| Provisioning Profile | `--provisioningProfile`  | GUID of the 
provisioning profile to be used for signing. It is copied here on your Mac: 
~/Library/MobileDevice/Provisioning\ Profiles/. Opening it in a text editor, 
you can find the GUID which needs to be specified here.
--- End diff --

Path should be in inline quotes. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53498288
  
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
   which requires registration as an Apple Developer.
 
 Once Xcode is installed, several command-line tools need to be enabled
-for Cordova to run. From the __Xcode__ menu, select __Preferences__,
-then the __Downloads__ tab. From the __Components__ panel, press the
-__Install__ button next to the __Command Line Tools__ listing.
+for Cordova to run. From the command line, run: 
+``` xcode-select --install``` 
 
-## Install Deploy Tools
+### Deployment Tools
 
-Run from comman-line terminal:
+The [ios-sim](https://www.npmjs.org/package/ios-sim) and 
+[ios-deploy](https://www.npmjs.org/package/ios-deploy) tools - allows you
+to launch iOS apps into the iOS Simulator and iOS Device from the 
command-line.
+
+To install them, run the following from command-line terminal:
 
 $ npm install -g ios-sim
 $ npm install -g ios-deploy
 
-## Create a New Project
-
-Use the `cordova` utility to set up a new project, as described in The
-Cordova [The Command-Line Interface](../../cli/index.html). For example, 
in a source-code directory:
+## Project Configuration
 
-$ cordova create hello com.example.hello "HelloWorld"
-$ cd hello
-$ cordova platform add ios
-$ cordova prepare  # or "cordova build"
+Installing Xcode will mostly set everything needed to get started.
--- End diff --

We can also give a link here to the CLI, something like 'You should be able 
to create a cordova project now. For more details refer to the CLI"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-lib/pull/363#issuecomment-186352413
  
Responded to most the feedback. Also added warnings and verbose logging 
which I completely forgot in my original PR. I will rebase this branch soon


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53497631
  
--- Diff: www/docs/en/dev/guide/platforms/index.md ---
@@ -61,11 +61,8 @@ a lower-level alternative to the `cordova` command-line 
utility.
 ## iOS
 
 * [iOS Platform Guide](ios/index.html)
-* [iOS Shell Tool Guide](ios/tools.html)
-* [iOS Configuration](ios/config.html)
 * [iOS Plugins](ios/plugin.html)
 * [iOS WebViews](ios/webview.html)
-* [Upgrading iOS](ios/upgrade.html)
--- End diff --

We can actually get rid of this file all together. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Removing keyword index.

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/508#issuecomment-186334602
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-186325651
  
This needs to use the new PermissionHelper class instead of the 
CordovaInterface methods for requestPermission and hasPermission


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10644 Adds deprecation message about ...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-lib/pull/394#issuecomment-186313374
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

[MatthewBooth]

Github user MatthewBooth commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-186313033
  
This is in response to @infil00p's comments here: 
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186300094

I've tested in my project and this works as expected, both file permissions 
and camera permissions are requested and fufilled as necessary. Good work 
@ochakov.

I honestly don't know the codebase that well so you guys will want to check 
it, but it looks legit, and builds fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[MatthewBooth]

Github user MatthewBooth commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186312333
  
@infil00p I've rebased here: 
https://github.com/apache/cordova-plugin-camera/pull/174


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

[MatthewBooth]

GitHub user MatthewBooth opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/174

Rebased ochakov's branch to the latest as of writing



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MatthewBooth/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #174


commit 91dd693623ae17c84d5d8e3e27139247b2b59690
Author: ochakov 
Date:   2015-12-01T21:10:43Z

Fix missing CAMERA permission for Android M

Fixing a bug where for Android M new permissions model, only external 
storage permission was asked, while camera permission was not, causing camera 
to fail on Android 6.0

commit 70fcf30423946ec9d3299be1495ddd44cacff3c1
Author: ochakov 
Date:   2015-12-01T21:34:08Z

Fix requiring both Camera and Storage permissions

To take a picture on Android M, both Camera and Storage access permissions 
are required. Now asking for both permissions simultaneously.

commit c4618a894eec92349371221fe18b5572151bff6f
Author: ochakov 
Date:   2015-12-02T23:51:22Z

Check android.permission.CAMERA in the package

According to the PR conversation, when android.permission.CAMERA is not set 
in the package, there is no need to ask for the camera permission. Also, 
checking now camera and storage permissions separately, so if only one of them 
is missing, the other one will be requested and not both.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[infil00p]

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186300094
  
WTF? I thought this was merged weeks ago, or we decided not to merge it or 
something.  We need to get the conflicts resolved and this thing pulled in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[MatthewBooth]

Github user MatthewBooth commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186290675
  
This should be merged ASAP. It fixes this very issue for a project I'm 
working on. 

You absolutely should be declaring the permissions in the manifest so that 
the user can see them on the Google Play Store, or while installing manually. 
It's poor practice to deny the user the chance to remove, revoke or review 
permissions.

I'm using @ochakov's fork currently, but it would obviously be better if 
this was in the official channels.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10652 Added the instruction on how ...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-medic/pull/81

CB-10652 Added the instruction on how to prepare a slave for Appium t…

…ests

https://issues.apache.org/jira/browse/CB-10652

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-medic CB-10652

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-medic/pull/81.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #81


commit 70bd723bf8ec35b3a673a91ffccfcb693efafaed
Author: Alexander Sorokin 
Date:   2016-02-19T15:03:42Z

CB-10652 Added the instruction on how to prepare a slave for Appium tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10652 Added the instruction on how ...

[alsorokin]

Github user alsorokin commented on the pull request:

https://github.com/apache/cordova-medic/pull/81#issuecomment-186250451
  
@dblotsky please take a look


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10636 Add JSHint for ...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/151

CB-10636 Add JSHint for plugins

[Jira issue](https://issues.apache.org/jira/browse/CB-10636)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-10636

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/151.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #151


commit ea1253963bc5d8a0e7b0684c7ecb7e231444a140
Author: daserge 
Date:   2016-02-19T12:39:28Z

CB-10636 Add JSHint for plugins




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...

[dhams]

Github user dhams commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/85#discussion_r53453538
  
--- Diff: src/android/SplashScreen.java ---
@@ -341,7 +341,11 @@ public void onCancel(DialogInterface dialog) {
 }
 });
 
-spinnerDialog.setCancelable(false);
+if(preferences.getBoolean("spinnerCancelable",true)){
--- End diff --

That may give a more privilege to developer I guess. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...

[daserge]

Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/85#discussion_r53451788
  
--- Diff: src/android/SplashScreen.java ---
@@ -341,7 +341,11 @@ public void onCancel(DialogInterface dialog) {
 }
 });
 
-spinnerDialog.setCancelable(false);
+if(preferences.getBoolean("spinnerCancelable",true)){
--- End diff --

Should not the property be `false` by default (noncancellable)?
You are changing the default plugin behavior as it is optional.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/85#issuecomment-186184171
  
Thanks!
Could you please explain your use case why the spinner should be 
cancellable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...

[dhams]

GitHub user dhams opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/85

CB-10643cordova plugin splashscreen : Added new preference to choose 
whether dialog is cancelable or not.

Added option to choose whether developer wants cancelable dialog or not 
while loading splashscreen.
I added preference ` ` in config.xml where user can set appropriate value.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accenture/cordova-plugin-splashscreen 
CB-10643cordova-plugin-splashscreen

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #85


commit d82b76cba98915612be960d9f66891584dfb215b
Author: bbadrinath 
Date:   2016-02-10T06:56:29Z

Merge pull request #1 from apache/master

Rebasing the forked branch from 3.1.1 to current master branch 3.2.0

commit cef829bac947f734f3d50e727d91eb41827fdc57
Author: Sharma 
Date:   2016-02-19T11:32:19Z

Added new preference to choose whether dialog is cancelable or not.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10519 Wrap all sync calls inside of `...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/384


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Add fix for iOS file upl...

[spedmo]

Github user spedmo commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/139#issuecomment-186174071
  
Why isnt this in?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js pull request: CB-10650 Non-index content.src causes Spl...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-js/pull/132

CB-10650 Non-index content.src causes Splashscreen to be not displaye…

…d on browser

[Jira issue](https://issues.apache.org/jira/browse/CB-10650)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-js CB-10650

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-js/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #132


commit c517ca811b4948b630e0b74dbae6c9637939da24
Author: daserge 
Date:   2016-02-19T10:28:20Z

CB-10650 Non-index content.src causes Splashscreen to be not displayed on 
browser




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10636 CB-10650 Add JS...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/84#issuecomment-186160148
  
Associated with PR https://github.com/apache/cordova-browser/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10636 CB-10650 Add JS...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/84

CB-10636 CB-10650 Add JSHint for plugins

[CB-10636 Add JSHint for 
plugins](https://issues.apache.org/jira/browse/CB-10636)
[CB-10650 Non-index content.src causes Splashscreen to be not displayed on 
browser](https://issues.apache.org/jira/browse/CB-10650)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-plugin-splashscreen CB-10636

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #84


commit 5ea854d8c3671751778a67095b3ec36a55e0c71b
Author: daserge 
Date:   2016-02-19T09:04:40Z

CB-10636 Add JSHint for plugins

Fixed autotests

commit c77e8e013ce99fd9b821eb7abb95fd65995e55c1
Author: daserge 
Date:   2016-02-19T09:46:29Z

CB-10650 Non-index content.src causes Splashscreen to be not displayed on 
browser




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request: CB-10650 Non-index content.src cause...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-browser/pull/23

CB-10650 Non-index content.src causes Splashscreen to be not displaye…

…d on browser

[Jira issue](https://issues.apache.org/jira/browse/CB-10650)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-browser CB-10650

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-browser/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #23


commit b54c7e08a38c08079acbc83f293df1a560f6329c
Author: daserge 
Date:   2016-02-19T10:22:16Z

CB-10650 Non-index content.src causes Splashscreen to be not displayed on 
browser




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10641 Run prepare _after_ plugins wer...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/393


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10641 Run prepare _after_ plugins wer...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/393#issuecomment-186137795
  
@nikhilkh, will do that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10644 Adds deprecation message about ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/394#issuecomment-186135548
  
@nikhilkh, updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

[alsorokin]

Github user alsorokin commented on the pull request:

https://github.com/apache/cordova-windows/pull/152#issuecomment-186125182
  
@dblotsky as far as I remember, this script can run without administrator 
privileges, but you'll need to enable the needed channels first:

`wevtutil set-log "Microsoft-Windows-AppHost/Admin" /e:true /rt:true 
/ms:4194304`
`wevtutil set-log "Microsoft-Windows-AppHost/ApplicationTracing" /e:true 
/rt:true /ms:4194304`


https://github.com/apache/cordova-medic/blob/master/SLAVES.md#windows-8-and-windows-81


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org