[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...

[bso-intel]

Github user bso-intel commented on the pull request:

https://github.com/apache/cordova-lib/pull/396#issuecomment-192567709
  
@vladimir-kotikov ,
Just a friendly reminder. This is still not merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10328 set top-level property of plugi...

[bso-intel]

Github user bso-intel commented on the pull request:

https://github.com/apache/cordova-lib/pull/402#issuecomment-19288
  
@vladimir-kotikov ,
I added an e2e test that is described in CB-10328.
The test fails without my fix, and passes with my fix.
Could you merge this pull request?
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10577: Android resolveLocalFi...

[rakatyal]

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/167#issuecomment-192543406
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Moving dev to 6.x

[rakatyal]

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/537#issuecomment-192542631
  
Yes. They were added as part of 
[this](https://github.com/apache/cordova-docs/pull/507/files) commit. We added 
landing pages for guides which we didn't make single page.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10577: Android resolveLocalFi...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/167#issuecomment-192542492
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Moving dev to 6.x

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/537#issuecomment-192540964
  
@rakatyal it looks like some pages were added to other languages than 
English. Was this intentional?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Moving dev to 6.x

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/537#discussion_r55110503
  
--- Diff: www/docs/de/6.x/guide/platforms/blackberry10/home.md ---
@@ -0,0 +1,29 @@
+---
+license: >
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+title: Blackberry 10 Guides
+---
+
+# Blackberry 10 Guides
+
+* [BlackBerry 10 Platform Guide](index.html)
+* [BlackBerry 10 Shell Tool Guide](tools.html)
+* [BlackBerry 10 Configuration](config.html)
+* [BlackBerry 10 Plugins](plugin.html)
+* [Upgrading BlackBerry 10](upgrade.html)
--- End diff --

Why is there a new page in German?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Discuss: Moving current 'dev' documentation to 6.x

[Dmitry Blotsky]

Hey folks,

Just bringing up an important note: this change is only coming to English. 
Other languages will not get the change and they will still have older content 
that looks different even though the version is the same (6.x). Are we okay 
with this change in user experience?

Kindly,
Dmitry

On Mar 3, 2016, at 3:15 PM, Raghav Katyal 
> wrote:

Hi everyone!

I am planning to move the current dev version of our documentation to 
6.x(latest) version. We have done a significant amount of work to improve our 
documentation and I have also written a blog post summarizing them. Please 
review them if you would like.

Blog PR: https://github.com/apache/cordova-docs/pull/527/files
Docs PR: https://github.com/apache/cordova-docs/pull/537

-Raghav

[GitHub] cordova-docs pull request: CB-8976: Restoring documentation for an...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/540#issuecomment-192534567
  
@infil00p @nikhilkh please review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-8976: Restoring documentation for an...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/540

CB-8976: Restoring documentation for android version code

The version code documentation was lost in the update to the config.xml 
reference. This restores that old information and moves it to the Android 
guide. I also tried to clarify how we modify the version code because there was 
some confusion over that in the 
[CB-8976](https://issues.apache.org/jira/browse/CB-8976) thread.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-8976

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/540.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #540


commit 4cccbc700fecf6f0a9f2a796df9f136a72d05fb2
Author: riknoll 
Date:   2016-03-05T00:10:59Z

CB-8976: Restoring documentation for android version code




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10577: Android resolveLocalFi...

[jasongin]

GitHub user jasongin opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/167

CB-10577: Android resolveLocalFileSystemURL should detect directory

@rakatyal or @riknoll please review

There were two places in the Android file plugin code that didn't do the 
right thing when resolving a URI whose trailing slash didn't match the 
directory vs file status.

1. In LocalFileSystem.toLocalUri(), the returned path should never have a 
terminating slash if the path does not point to a directory.

2. In FileUtils.resolveLocalFileSystemUri(), resolving a cdvfile:// (aka 
"local") URI now converts to native URI and back to a local URI (making use of 
the change above) in order to force resolution of whether the path points to a 
file or a directory and fix the terminating slash character accordingly. This 
is only done for local URIs, because for native URIs the resolveNativeUri() 
call would already have called toLocalUri() so doing it again would be 
redundant in that case.

I added automated test cases for resolving native URI files and directories 
using mismatched trailing slashes. As for cdvfile:// URIs, we currently only 
have manual test cases for those (at the bottom of tests.js) and they aren't 
very thorough. I manually tested this fix with cdvfile:// URIs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jasongin/cordova-plugin-file CB-10577

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/167.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #167


commit 89ccaf2d4c3b2ffbdbdc79804238c083ce9f2c30
Author: Jason Ginchereau 
Date:   2016-03-04T20:02:10Z

CB-10577: Android resolveLocalFileSystemURL should detect directory vs file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Test Plugin on npm

[Carlos Santana]

Thanks Shaz for keeping us legit

#2legit2quit  [1]

[1]: https://www.youtube.com/watch?v=wiyYozeOoKs


On Fri, Mar 4, 2016 at 4:49 PM Richard Knoll  wrote:

> Great! I think I will actually put the source for the plugin into the
> cordova-lib test folder to make it clear that it is only intended for
> testing.
>
> Thanks,
> Richard
>
> -Original Message-
> From: Shazron [mailto:shaz...@gmail.com]
> Sent: Friday, March 4, 2016 12:58 PM
> To: dev@cordova.apache.org
> Subject: Re: Test Plugin on npm
>
> Here are the guidelines:
>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.apache.org%2fdev%2frelease.html%23what=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7c749612995086426c3d1f08d3446fc0fb%7c72f988bf86f141af91ab2d7cd011db47%7c1=9OtPzgIxlszlAMjys7rKyzySnrsjrsIupkkxNdilRrs%3d
>
> In short, what others have said is correct. Test packages do not require a
> vote as long as they follow the (bolded) guidelines in the link I cited
> above.
>
> On Fri, Mar 4, 2016 at 10:30 AM, Richard Knoll 
> wrote:
> > Hey all,
> >
> > I'd like to have some better end-to-end tests for "cordova plugin add"
> in cordova-lib, so I wanted to publish a test plugin to npm. The plugin
> itself will be empty besides a plugin.xml, I just need it to exist and have
> engine information I can test against. Do we have an official npm account
> that I should be using for the publishing? I can store the plugin itself in
> cordova-plugins.
> >
> > Thanks,
> > Richard
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

RE: DISCUSS cordova-paramedic

[Nikhil Khandelwal]

Thanks, Jesse!

-Nikhil

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Friday, March 4, 2016 1:58 PM
To: dev@cordova.apache.org
Subject: Re: DISCUSS cordova-paramedic

+1 Jesse for the contribution

On Fri, Mar 4, 2016 at 4:01 PM Jesse  wrote:

> Repo created here:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit-w
> ip-us.apache.org%2frepos%2fasf%3fp%3dcordova-paramedic.git=01%7c0
> 1%7cnikhilkh%40microsoft.com%7c6620abb4e0ce4610593708d34478d05c%7c72f9
> 88bf86f141af91ab2d7cd011db47%7c1=zaYIE1U%2frw4LzP2LACCfGFABxGPX2
> 9hWESb%2fgxzJUXM%3d
> and github mirror here:
> https://github.com/apache/cordova-paramedic
>
>
> @purplecabbage
> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01
> %7c01%7cnikhilkh%40microsoft.com%7c6620abb4e0ce4610593708d34478d05c%7c
> 72f988bf86f141af91ab2d7cd011db47%7c1=lfQjstYvcfeC%2fhH2SDsZBD6gS
> L%2ber9o%2f1hia7xWMuDo%3d
>
> On Thu, Mar 3, 2016 at 3:59 PM, Jesse  wrote:
>
> > Nikhil and team have expressed interest in using cordova-paramedic 
> > for more of our cordova CI work. This is approach that I explored 
> > last year
> but
> > ultimately dropped because I couldn't keep up with changes needed to 
> > keep it running as a CI. The main issue I had was that TravisCI 
> > could only
> build
> > for iOS OR Android, and could not do both.  Similarily, AppVeyor 
> > could do Windows OR Android, but not both.  This lead to tests that 
> > looked as if they had passed, even though changes had been committed 
> > to untested platforms. Given that there is more interest, we can 
> > probably find a way
> to
> > push through these issues, and have true github integration so we 
> > can see if a pull request is failing tests. I was also not able to 
> > get the WP8 emulator running in a CI environment, although this is 
> > now not a much of
> a
> > concern as it is deprecated. Some stuff is also harder to test in a 
> > CI emulator/simulator, like camera, where some user interaction is needed.
> >
> > Currently cordova-paramedic is managed through my own repo, although 
> > Apache licenced. This was so that I could iterate quickly, and 
> > publish to npm without going through voting procedures. Given that 
> > others will be committing, I have asked infra to create a new repo 
> > [1] for it to live
> in.
> > This way we can all commit without legal hurdles.
> >
> >
> >
> > [1] 
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss
> > ues.apache.org%2fjira%2fbrowse%2fINFRA-11371=01%7c01%7cnikhilkh
> > %40microsoft.com%7c6620abb4e0ce4610593708d34478d05c%7c72f988bf86f141
> > af91ab2d7cd011db47%7c1=WatUkF01A0PuGXb4ncTmKrsmqTkGIkFBUeBsMTd
> > mGbY%3d
> >
> > @purplecabbage
> > https://na01.safelinks.protection.outlook.com/?url=risingj.com=
> > 01%7c01%7cnikhilkh%40microsoft.com%7c6620abb4e0ce4610593708d34478d05
> > c%7c72f988bf86f141af91ab2d7cd011db47%7c1=lfQjstYvcfeC%2fhH2SDs
> > ZBD6gSL%2ber9o%2f1hia7xWMuDo%3d
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Test Plugin on npm

[Richard Knoll]

Great! I think I will actually put the source for the plugin into the 
cordova-lib test folder to make it clear that it is only intended for testing.

Thanks,
Richard

-Original Message-
From: Shazron [mailto:shaz...@gmail.com] 
Sent: Friday, March 4, 2016 12:58 PM
To: dev@cordova.apache.org
Subject: Re: Test Plugin on npm

Here are the guidelines:
https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.apache.org%2fdev%2frelease.html%23what=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7c749612995086426c3d1f08d3446fc0fb%7c72f988bf86f141af91ab2d7cd011db47%7c1=9OtPzgIxlszlAMjys7rKyzySnrsjrsIupkkxNdilRrs%3d

In short, what others have said is correct. Test packages do not require a vote 
as long as they follow the (bolded) guidelines in the link I cited above.

On Fri, Mar 4, 2016 at 10:30 AM, Richard Knoll  wrote:
> Hey all,
>
> I'd like to have some better end-to-end tests for "cordova plugin add" in 
> cordova-lib, so I wanted to publish a test plugin to npm. The plugin itself 
> will be empty besides a plugin.xml, I just need it to exist and have engine 
> information I can test against. Do we have an official npm account that I 
> should be using for the publishing? I can store the plugin itself in 
> cordova-plugins.
>
> Thanks,
> Richard

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-globalization pull request: CB-10792 -Cannot instal...

[csantanapr]

Github user csantanapr commented on the pull request:


https://github.com/apache/cordova-plugin-globalization/pull/47#issuecomment-192465550
  
@dubeejw  I meant not the file itself but the path, I think you know what I 
meant :laughing: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: DISCUSS cordova-paramedic

[Jesse]

Repo created here:
https://git-wip-us.apache.org/repos/asf?p=cordova-paramedic.git
and github mirror here:
https://github.com/apache/cordova-paramedic


@purplecabbage
risingj.com

On Thu, Mar 3, 2016 at 3:59 PM, Jesse  wrote:

> Nikhil and team have expressed interest in using cordova-paramedic for
> more of our cordova CI work. This is approach that I explored last year but
> ultimately dropped because I couldn't keep up with changes needed to keep
> it running as a CI. The main issue I had was that TravisCI could only build
> for iOS OR Android, and could not do both.  Similarily, AppVeyor could do
> Windows OR Android, but not both.  This lead to tests that looked as if
> they had passed, even though changes had been committed to untested
> platforms. Given that there is more interest, we can probably find a way to
> push through these issues, and have true github integration so we can see
> if a pull request is failing tests. I was also not able to get the WP8
> emulator running in a CI environment, although this is now not a much of a
> concern as it is deprecated. Some stuff is also harder to test in a CI
> emulator/simulator, like camera, where some user interaction is needed.
>
> Currently cordova-paramedic is managed through my own repo, although
> Apache licenced. This was so that I could iterate quickly, and publish to
> npm without going through voting procedures. Given that others will be
> committing, I have asked infra to create a new repo [1] for it to live in.
> This way we can all commit without legal hurdles.
>
>
>
> [1] https://issues.apache.org/jira/browse/INFRA-11371
>
> @purplecabbage
> risingj.com
>

[GitHub] cordova-plugin-globalization pull request: CB-10792 -Cannot instal...

[csantanapr]

Github user csantanapr commented on the pull request:


https://github.com/apache/cordova-plugin-globalization/pull/47#issuecomment-192465283
  
Hi @dubeejw it would be good to go over all the cordova plugins plugin.xml 
and check which one have this bug of not using lower case for source files 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Test Plugin on npm

[Shazron]

Here are the guidelines:
http://www.apache.org/dev/release.html#what

In short, what others have said is correct. Test packages do not
require a vote as long as they follow the (bolded) guidelines in the
link I cited above.

On Fri, Mar 4, 2016 at 10:30 AM, Richard Knoll  wrote:
> Hey all,
>
> I'd like to have some better end-to-end tests for "cordova plugin add" in 
> cordova-lib, so I wanted to publish a test plugin to npm. The plugin itself 
> will be empty besides a plugin.xml, I just need it to exist and have engine 
> information I can test against. Do we have an official npm account that I 
> should be using for the publishing? I can store the plugin itself in 
> cordova-plugins.
>
> Thanks,
> Richard

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Test Plugin on npm

[Carlos Santana]

I vote that you don't need a vote :-)

- Carlos
@csantanapr

> On Mar 4, 2016, at 2:18 PM, Nikhil Khandelwal  wrote:
> 
> I agree - this is for testing purposes only - no VOTE required.
> 
> -Nikhil
> 
> 
> 
> 
>> On 3/4/16, 11:08 AM, "Steven Gill"  wrote:
>> 
>> The real question is do we vote on it before posting to npm.
>> 
>> Since it isn't for general release distribution, but just for testing, I
>> would say you don't have to vote on it.
>> 
>> Thoughts?
>> 
>> -Steve
>> 
>> On Fri, Mar 4, 2016 at 10:43 AM, Richard Knoll 
>> wrote:
>> 
>>> Yep, I would like to test with a plugin on npm to support the new version
>>> selection feature I'm about to merge.
>>> 
>>> Thanks,
>>> Richard
>>> 
>>> -Original Message-
>>> From: Steven Gill [mailto:stevengil...@gmail.com]
>>> Sent: Friday, March 4, 2016 10:41 AM
>>> To: dev@cordova.apache.org
>>> Subject: Re: Test Plugin on npm
>>> 
>>> Hey Byoungro,
>>> 
>>> We already test local plugins. I think the point of Richard asking is so
>>> we actually test our npm fetching and installing.
>>> 
>>> Cheers,
>>> -Steve
>>> 
>>> On Fri, Mar 4, 2016 at 10:37 AM, So, Byoungro 
>>> wrote:
>>> 
 Hi Richard,
 
 Do you know you can add the plugin from your local disk path?
 “cordova plugin add ” might be easier for you than publishing
 your test plugin on the NPM registry and test using NPM.
 
 Byoungro So
 SSG / DPD / Mobile Computing and Compilers Intel Corporation
 
 From: Richard Knoll
 >
 Reply-To: "dev@cordova.apache.org" <
 dev@cordova.apache.org>
 Date: Friday, March 4, 2016 at 10:30 AM
 To: "dev@cordova.apache.org" <
 dev@cordova.apache.org>
 Subject: Test Plugin on npm
 
 Hey all,
 
 I'd like to have some better end-to-end tests for "cordova plugin add"
 in cordova-lib, so I wanted to publish a test plugin to npm. The
 plugin itself will be empty besides a plugin.xml, I just need it to
 exist and have engine information I can test against. Do we have an
 official npm account that I should be using for the publishing? I can
 store the plugin itself in cordova-plugins.
 
 Thanks,
 Richard
> B‹CB•È[œÝXœØÜšX™KK[XZ[ˆ]‹][œÝXœØÜšX™PÛÜ™ݘK˜\XÚK›Ü™ÃB‘›ÜˆY][Û˜[ÛÛ[X[™ËK[XZ[ˆ]‹Z[ÛÜ™ݘK˜\XÚK›Ü™ÃB

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] 4.0.1 OSX Release (attempt 2)

[Steven Gill]

Please review and vote on this 4.0.1 OSX Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10779

The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10779

The package was published from its corresponding git tag:
cordova-osx: 4.0.1 (f4e00b50d7)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-osx#4.0.1

Upon a successful vote I will upload the archive to dist/ and publish it to npm.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran mobilespec & built hello world

Re: [DISCUSS] OSX 4.0.1 release

[Steven Gill]

fixed it. Updated coho so it will update that file for osx.

On Fri, Mar 4, 2016 at 7:35 AM, Steven Gill  wrote:

> I'll resend it in a bit. Coho should have updated it. I'll investigate.
> On Mar 4, 2016 4:16 AM, "Alexander Sorokin (Akvelon)" <
> v-als...@microsoft.com> wrote:
>
>> Hi Steven,
>>
>> There is a small issue with this release:
>> The file 'bin/templates/scripts/cordova/version' doesn't seem to be
>> updated by coho and contains the following line:
>> var VERSION="4.0.0-dev";
>>
>> I don't know if that's a blocker so I'm just reporting it here. What do
>> you think?
>>
>> Thanks,
>> Alexander Sorokin
>>
>> -Original Message-
>> From: Tobias Bocanegra [mailto:tri...@apache.org]
>> Sent: Saturday, February 27, 2016 3:08 AM
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] OSX 4.0.1 release
>>
>> not from my side.
>>
>> thanks!
>>
>> On Fri, Feb 26, 2016 at 3:51 PM, Steven Gill 
>> wrote:
>> > We need to do a update since the package on npm is missing some
>> > bundled node modules.
>> >
>> > Any blockers?
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>

Re: [Vote] 4.0.1 OSX Release

[Steven Gill]

This vote has failed. Resending

On Thu, Mar 3, 2016 at 4:01 PM, Steven Gill  wrote:

> Please review and vote on this 4.0.1 OSX Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10779
>
> The archive has been published to 
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10779
>
> The package was published from its corresponding git tag:
> cordova-osx: 4.0.1 (a8e7d75aaa)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-osx#4.0.1
>
> Upon a successful vote I will upload the archive to dist/ and publish it to 
> npm.
>
> Voting guidelines: 
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies have 
> Apache-compatible licenses
> * Ran mobilespec & built hello world
>
>

Re: [DISCUSS] Plugins release

[julio cesar sanchez]

cordova-plugin-camera should be released too, right now picking images from
the gallery doesn't work on android 4.4+



2016-03-04 19:42 GMT+01:00 Edna Y Morales :

>
> Hi,
>
> There are some fixes we are wanting to get released for
> cordova-plugin-globalization and cordova-plugin-splashscreen. Any thoughts
> on when we can do the next release for these?
>
> For cordova-plugin-globalization there are several deprecation warnings
> that we need to get rid of. Addressed by
> https://issues.apache.org/jira/browse/CB-10605
>
> For cordova-plugin-splashscreen there is also a deprecation warning.
> Addressed by https://issues.apache.org/jira/browse/CB-10606
>
> Thanks,
> Edna Morales
>

Re: Test Plugin on npm

[Nikhil Khandelwal]

I agree - this is for testing purposes only - no VOTE required.

-Nikhil




On 3/4/16, 11:08 AM, "Steven Gill"  wrote:

>The real question is do we vote on it before posting to npm.
>
>Since it isn't for general release distribution, but just for testing, I
>would say you don't have to vote on it.
>
>Thoughts?
>
>-Steve
>
>On Fri, Mar 4, 2016 at 10:43 AM, Richard Knoll 
>wrote:
>
>> Yep, I would like to test with a plugin on npm to support the new version
>> selection feature I'm about to merge.
>>
>> Thanks,
>> Richard
>>
>> -Original Message-
>> From: Steven Gill [mailto:stevengil...@gmail.com]
>> Sent: Friday, March 4, 2016 10:41 AM
>> To: dev@cordova.apache.org
>> Subject: Re: Test Plugin on npm
>>
>> Hey Byoungro,
>>
>> We already test local plugins. I think the point of Richard asking is so
>> we actually test our npm fetching and installing.
>>
>> Cheers,
>> -Steve
>>
>> On Fri, Mar 4, 2016 at 10:37 AM, So, Byoungro 
>> wrote:
>>
>> > Hi Richard,
>> >
>> > Do you know you can add the plugin from your local disk path?
>> > “cordova plugin add ” might be easier for you than publishing
>> > your test plugin on the NPM registry and test using NPM.
>> >
>> > Byoungro So
>> > SSG / DPD / Mobile Computing and Compilers Intel Corporation
>> >
>> > From: Richard Knoll
>> > >
>> > Reply-To: "dev@cordova.apache.org" <
>> > dev@cordova.apache.org>
>> > Date: Friday, March 4, 2016 at 10:30 AM
>> > To: "dev@cordova.apache.org" <
>> > dev@cordova.apache.org>
>> > Subject: Test Plugin on npm
>> >
>> > Hey all,
>> >
>> > I'd like to have some better end-to-end tests for "cordova plugin add"
>> > in cordova-lib, so I wanted to publish a test plugin to npm. The
>> > plugin itself will be empty besides a plugin.xml, I just need it to
>> > exist and have engine information I can test against. Do we have an
>> > official npm account that I should be using for the publishing? I can
>> > store the plugin itself in cordova-plugins.
>> >
>> > Thanks,
>> > Richard
>> >
>> >
>>

Re: Test Plugin on npm

[Steven Gill]

The real question is do we vote on it before posting to npm.

Since it isn't for general release distribution, but just for testing, I
would say you don't have to vote on it.

Thoughts?

-Steve

On Fri, Mar 4, 2016 at 10:43 AM, Richard Knoll 
wrote:

> Yep, I would like to test with a plugin on npm to support the new version
> selection feature I'm about to merge.
>
> Thanks,
> Richard
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Friday, March 4, 2016 10:41 AM
> To: dev@cordova.apache.org
> Subject: Re: Test Plugin on npm
>
> Hey Byoungro,
>
> We already test local plugins. I think the point of Richard asking is so
> we actually test our npm fetching and installing.
>
> Cheers,
> -Steve
>
> On Fri, Mar 4, 2016 at 10:37 AM, So, Byoungro 
> wrote:
>
> > Hi Richard,
> >
> > Do you know you can add the plugin from your local disk path?
> > “cordova plugin add ” might be easier for you than publishing
> > your test plugin on the NPM registry and test using NPM.
> >
> > Byoungro So
> > SSG / DPD / Mobile Computing and Compilers Intel Corporation
> >
> > From: Richard Knoll
> > >
> > Reply-To: "dev@cordova.apache.org" <
> > dev@cordova.apache.org>
> > Date: Friday, March 4, 2016 at 10:30 AM
> > To: "dev@cordova.apache.org" <
> > dev@cordova.apache.org>
> > Subject: Test Plugin on npm
> >
> > Hey all,
> >
> > I'd like to have some better end-to-end tests for "cordova plugin add"
> > in cordova-lib, so I wanted to publish a test plugin to npm. The
> > plugin itself will be empty besides a plugin.xml, I just need it to
> > exist and have engine information I can test against. Do we have an
> > official npm account that I should be using for the publishing? I can
> > store the plugin itself in cordova-plugins.
> >
> > Thanks,
> > Richard
> >
> >
>

[DISCUSS] Plugins release

[Edna Y Morales]

Hi,

There are some fixes we are wanting to get released for
cordova-plugin-globalization and cordova-plugin-splashscreen. Any thoughts
on when we can do the next release for these?

For cordova-plugin-globalization there are several deprecation warnings
that we need to get rid of. Addressed by
https://issues.apache.org/jira/browse/CB-10605

For cordova-plugin-splashscreen there is also a deprecation warning.
Addressed by https://issues.apache.org/jira/browse/CB-10606

Thanks,
Edna Morales

Re: Test Plugin on npm

[Steven Gill]

Hey Byoungro,

We already test local plugins. I think the point of Richard asking is so we
actually test our npm fetching and installing.

Cheers,
-Steve

On Fri, Mar 4, 2016 at 10:37 AM, So, Byoungro  wrote:

> Hi Richard,
>
> Do you know you can add the plugin from your local disk path?
> “cordova plugin add ” might be easier for you than publishing your
> test plugin on the NPM registry and test using NPM.
>
> Byoungro So
> SSG / DPD / Mobile Computing and Compilers
> Intel Corporation
>
> From: Richard Knoll >
> Reply-To: "dev@cordova.apache.org" <
> dev@cordova.apache.org>
> Date: Friday, March 4, 2016 at 10:30 AM
> To: "dev@cordova.apache.org" <
> dev@cordova.apache.org>
> Subject: Test Plugin on npm
>
> Hey all,
>
> I'd like to have some better end-to-end tests for "cordova plugin add" in
> cordova-lib, so I wanted to publish a test plugin to npm. The plugin itself
> will be empty besides a plugin.xml, I just need it to exist and have engine
> information I can test against. Do we have an official npm account that I
> should be using for the publishing? I can store the plugin itself in
> cordova-plugins.
>
> Thanks,
> Richard
>
>

Re: Test Plugin on npm

[So, Byoungro]

Hi Richard,

Do you know you can add the plugin from your local disk path?
“cordova plugin add ” might be easier for you than publishing your test 
plugin on the NPM registry and test using NPM.

Byoungro So
SSG / DPD / Mobile Computing and Compilers
Intel Corporation

From: Richard Knoll >
Reply-To: "dev@cordova.apache.org" 
>
Date: Friday, March 4, 2016 at 10:30 AM
To: "dev@cordova.apache.org" 
>
Subject: Test Plugin on npm

Hey all,

I'd like to have some better end-to-end tests for "cordova plugin add" in 
cordova-lib, so I wanted to publish a test plugin to npm. The plugin itself 
will be empty besides a plugin.xml, I just need it to exist and have engine 
information I can test against. Do we have an official npm account that I 
should be using for the publishing? I can store the plugin itself in 
cordova-plugins.

Thanks,
Richard

Re: Test Plugin on npm

[Steven Gill]

We all just your our own accounts to publish. Publish away

On Fri, Mar 4, 2016 at 10:30 AM, Richard Knoll 
wrote:

> Hey all,
>
> I'd like to have some better end-to-end tests for "cordova plugin add" in
> cordova-lib, so I wanted to publish a test plugin to npm. The plugin itself
> will be empty besides a plugin.xml, I just need it to exist and have engine
> information I can test against. Do we have an official npm account that I
> should be using for the publishing? I can store the plugin itself in
> cordova-plugins.
>
> Thanks,
> Richard
>

Test Plugin on npm

[Richard Knoll]

Hey all,

I'd like to have some better end-to-end tests for "cordova plugin add" in 
cordova-lib, so I wanted to publish a test plugin to npm. The plugin itself 
will be empty besides a plugin.xml, I just need it to exist and have engine 
information I can test against. Do we have an official npm account that I 
should be using for the publishing? I can store the plugin itself in 
cordova-plugins.

Thanks,
Richard

[GitHub] cordova-windows pull request: CB-10673 fixed conflicting plugin in...

[bso-intel]

Github user bso-intel commented on the pull request:

https://github.com/apache/cordova-windows/pull/154#issuecomment-192389824
  
@nikhilkh,
Could you review this?
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10673 added --force-copying-src optio...

[bso-intel]

Github user bso-intel commented on the pull request:

https://github.com/apache/cordova-lib/pull/404#issuecomment-192389465
  
@nikhilkh,
Could you review this?
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10673 fixed conflicting plugin instal...

[bso-intel]

Github user bso-intel commented on the pull request:

https://github.com/apache/cordova-ios/pull/199#issuecomment-192389706
  
@nikhilkh,
Could you review this?
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/270


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-cli/pull/235#issuecomment-192373606
  
Are there still some test failures? @daserge Could you also add the travis 
badge for cordova-cli


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-globalization pull request: CB-10792 -Cannot instal...

[dubeejw]

GitHub user dubeejw opened a pull request:

https://github.com/apache/cordova-plugin-globalization/pull/47

CB-10792 -Cannot install cordova-plugin-globalization with cordova-windows 
on Ubuntu

- Make Windows lower-case in plugin.xml

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dubeejw/cordova-plugin-globalization master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-globalization/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #47


commit 5cc6dd6764918e45409f5670f9b6710bde798f44
Author: dubeejw 
Date:   2016-03-04T16:50:35Z

CB-10792 -Cannot install cordova-plugin-globalization with cordova-windows
on Ubuntu

- Make Windows lower-case in plugin.xml




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Vote] Cordova-browser 4.1.0 Release

[Carlos Santana]

I vote +1

coho verify-tags -r browser

coho verify-archive --tag 4.1.0 -r browser
vote-browser/cordova-browser-4.1.0.tgz

coho create-archive -r browser --tag 4.1.0 --dest test-browser/

compare contents of archives

tested with hello app


On Fri, Mar 4, 2016 at 9:39 AM Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:

> Please review and vote on this Cordova-browser 4.1.0 Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10788
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/CB-10788
>
> The package was published from its corresponding git tag:
> cordova-browser: 4.1.0 (2269c901fa)
>
> Note that you can test it out via:
> cordova platform add https://github.com/apache/cordova-browser#4.1.0
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the repo
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ensured that blank app created and ran successfully using CLI and
> platform scripts
> * Ensured that platform updates successfully from previous version
> * Created and ran mobilespec app
>
> -
> Best regards, Vladimir
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-android/pull/270#issuecomment-192333002
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10788 Add blog post about browser@4....

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-docs/pull/539

CB-10788 Add blog post about browser@4.1.0 release



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-10788

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/539.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #539


commit f3749e21dcd6d99eae26ff1c7b2ce33bff045a97
Author: Vladimir Kotikov 
Date:   2016-03-04T14:50:04Z

CB-10788 Add blog post about browser@4.1.0 release




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] Cordova-browser 4.1.0 Release

[Vladimir Kotikov (Akvelon)]

Please review and vote on this Cordova-browser 4.1.0 Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10788

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-10788

The package was published from its corresponding git tag:
cordova-browser: 4.1.0 (2269c901fa)

Note that you can test it out via:
cordova platform add https://github.com/apache/cordova-browser#4.1.0

Upon a successful vote I will upload the archive to dist/, publish it to npm, 
and post the blog post.

Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md 

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the repo
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Ensured that blank app created and ran successfully using CLI and platform 
scripts
* Ensured that platform updates successfully from previous version
* Created and ran mobilespec app

-
Best regards, Vladimir


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10791 Add adjustLoggerLevel to cordov...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/405#discussion_r55035943
  
--- Diff: cordova-common/src/CordovaLogger.js ---
@@ -153,6 +153,30 @@ CordovaLogger.prototype.setLevel = function (logLevel) 
{
 };
 
 /**
+ * Adjusts the current logger level according to the passed options.
+ *
+ * @param   {Object|Array}  opts  An object or args array with options
+ *
+ * @return  {CordovaLogger} Current instance, to allow calls chaining.
+ */
+CordovaLogger.prototype.adjustLoggerLevel = function (opts) {
+if (opts instanceof Array) {
+opts.silent = opts.indexOf('--silent') !== -1;
+opts.verbose = opts.indexOf('--verbose') !== -1 || 
opts.indexOf('-d') !== -1;
+}
+
+if (opts.silent) {
+this.setLevel('error');
+}
+
+if (opts.verbose || opts.d) {
--- End diff --

I think that `opts.d` is not needed because nopt converts `-d` to 
`{verbose: true}` if `-d` is a shortcut for `-verbose`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-android/pull/268#issuecomment-192302740
  
Thanks for the review!
Added https://issues.apache.org/jira/browse/CB-10791 and 
https://github.com/apache/cordova-lib/pull/405 for the `adjustLoggerLevel` 
method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-android/pull/268#issuecomment-192302388
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10791 Add adjustLoggerLevel to cordov...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-lib/pull/405

CB-10791 Add adjustLoggerLevel to cordova-common.CordovaLogger

[Jira issue](https://issues.apache.org/jira/browse/CB-10791)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-10791

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/405.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #405


commit 5fb7c3461814bba42e528773b38693a30b3fcc74
Author: daserge 
Date:   2016-03-04T14:27:42Z

CB-10791 Add adjustLoggerLevel to cordova-common.CordovaLogger




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

[daserge]

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/268#discussion_r55032086
  
--- Diff: bin/templates/cordova/Api.js ---
@@ -29,11 +29,23 @@ var AndroidProject = require('./lib/AndroidProject');
 var PlatformMunger = 
require('cordova-common').ConfigChanges.PlatformMunger;
 var PluginInfoProvider = require('cordova-common').PluginInfoProvider;
 
-var ConsoleLogger = require('./lib/ConsoleLogger');
 var pluginHandlers = require('./lib/pluginHandlers');
+var CordovaLogger = require('cordova-common').CordovaLogger;
+var selfEvents = require('cordova-common').events;
 
 var PLATFORM = 'android';
 
+function setupEvents(externalEventEmitter) {
--- End diff --

Updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/268#discussion_r55029692
  
--- Diff: bin/templates/cordova/Api.js ---
@@ -91,8 +102,11 @@ function Api(platform, platformRootDir, events) {
  *   instance or rejected with CordovaError.
  */
 Api.createPlatform = function (destination, config, options, events) {
+setupEvents(events);
--- End diff --

See previous comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/268#discussion_r55029727
  
--- Diff: bin/templates/cordova/Api.js ---
@@ -91,8 +102,11 @@ function Api(platform, platformRootDir, events) {
  *   instance or rejected with CordovaError.
  */
 Api.createPlatform = function (destination, config, options, events) {
+setupEvents(events);
+events = events || selfEvents;
--- End diff --

See previous comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/268#discussion_r55029617
  
--- Diff: bin/templates/cordova/Api.js ---
@@ -29,11 +29,23 @@ var AndroidProject = require('./lib/AndroidProject');
 var PlatformMunger = 
require('cordova-common').ConfigChanges.PlatformMunger;
 var PluginInfoProvider = require('cordova-common').PluginInfoProvider;
 
-var ConsoleLogger = require('./lib/ConsoleLogger');
 var pluginHandlers = require('./lib/pluginHandlers');
+var CordovaLogger = require('cordova-common').CordovaLogger;
+var selfEvents = require('cordova-common').events;
 
 var PLATFORM = 'android';
 
+function setupEvents(externalEventEmitter) {
--- End diff --

Could you make this function return the emitter instance? 
`setupEvents(events); events = events || selfEvents;` -> `events = 
setupEvents(events);`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/268#discussion_r55029308
  
--- Diff: bin/templates/cordova/loggingHelper.js ---
@@ -0,0 +1,18 @@
+var CordovaLogger = require('cordova-common').CordovaLogger;
+
+module.exports = {
+adjustLoggerLevel: function (opts) {
+if (opts instanceof Array) {
+opts.silent = opts.indexOf('--silent') !== -1;
+opts.verbose = opts.indexOf('--verbose') !== -1;
--- End diff --

We also have `-d` shortcut for `--verbose`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10768 Use cordova-common.superspa...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/269


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Cordova-browser release

[Vladimir Kotikov (Akvelon)]

Hey, guys.

Here is a release notes for this release:

### 4.1.0 (Mar 04, 2016)
* CB-10788 Updated checked in node_modules
* CB-10650 Non-index content.src causes Splashscreen to be not displayed on 
browser
* CB-9836 Add .gitattributes to prevent CRLF line endings in repos
* CB-9669 Browser exec should have more failsafes 
* Update to use new 'express' implementation of cordova-serve.
* CB-9658 Improve 'cordova run browser' when browser not installed.
* CB-9654 'cordova run browser' -> duplicate 'CTRL + C' messages.

Also while testing I've found that there are some failed tests, incl. contacts, 
device, device-motion, etc. I don't think this is a blocker, so just FYI.

-
Best regards, Vladimir 

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Wednesday, March 2, 2016 8:37 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-browser release

+1 to ^

On Wed, Mar 2, 2016 at 1:21 AM Steven Gill  wrote:

> Yes, follow semver!
>
> If we can get a good track record of following semver, I'd like to see 
> us switch to ^ with our pinned platforms and plugins so minors get 
> picked up automatically.
>
> On Tue, Mar 1, 2016 at 7:01 PM, Tim Barham 
> wrote:
>
> > It's been a long time since we did a cordova-browser release, and 
> > there have been many improvements since then. Should we get a 
> > release out
> before
> > the next tools release?
> >
> > If so, what should the version be? Proper npm versioning would 
> > suggest we go with 4.1.0 (since it is more than just bug fixes), but 
> > since we currently pin ~4.0.0 in cordova-lib, that will mean people 
> > won't get it automatically, and it's very unlikely there are backward 
> > compat issues.
> > Still, I guess 4.1.0 is the right thing to do.
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] OSX 4.0.1 release

[Alexander Sorokin (Akvelon)]

Hi Steven,

There is a small issue with this release:
The file 'bin/templates/scripts/cordova/version' doesn't seem to be updated by 
coho and contains the following line:
var VERSION="4.0.0-dev";

I don't know if that's a blocker so I'm just reporting it here. What do you 
think?

Thanks,
Alexander Sorokin

-Original Message-
From: Tobias Bocanegra [mailto:tri...@apache.org] 
Sent: Saturday, February 27, 2016 3:08 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] OSX 4.0.1 release

not from my side.

thanks!

On Fri, Feb 26, 2016 at 3:51 PM, Steven Gill  wrote:
> We need to do a update since the package on npm is missing some 
> bundled node modules.
>
> Any blockers?

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/235


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

[ghenry22]

Github user ghenry22 commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-192183151
  
cool I'll test this out when I have a chance and see if it still behaves as 
expected in my app as it uses a mix of local and streaming content



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org