[GitHub] cordova-plugin-camera pull request: [CB-10388] - Added correctOrie...

[swbradshaw]

Github user swbradshaw commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-215291931
  
@morioma  - Take a look at #197 again. I completely rewrote the 
implementation. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

[swbradshaw]

Github user swbradshaw commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-215290093
  
Re-opening with cleaned up fork. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

[swbradshaw]

GitHub user swbradshaw reopened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/197

CB-4078: correctOrientation not working on camera.getPicture for 
PHOTOLIBRARY

This fixes the orientation bug for Android 4.4+ devices when choosing a 
picture from the photo library.

This fixes both DATA_URL and FILE_URI requests.

Tested on Android 4.0.4,  Android 5.02, and Android 5.1 devices.






You can merge this pull request into a Git repository by running:

$ git pull https://github.com/swbradshaw/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #197


commit f2b4eeded069d791aec0670b369bab8fb3bfd0eb
Author: swbradshaw 
Date:   2016-04-28T02:27:37Z

CB-4078: Fix for orientation/scaling on Android 4.4+ devices

The only way to get rotation for photos in library (Gallery, File
System, Google Drive,etc) is to first create a temporary file from the
provider. Only then can we determine the orientation and scale the
bitmap correctly. By doing it in a central place, it eliminates reading
the inputstream repetitively in the plugin.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

[swbradshaw]

Github user swbradshaw closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/197


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

[swbradshaw]

Github user swbradshaw commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-215287391
  
@unbeatableDeepak My changes have been committed. I did a rebase from the 
master since I was weeks behind. Since this is my first PR, I'm not sure if 
that was correct or not. Anyway, you can test now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Update plugman.md

[darylldawn]

GitHub user darylldawn opened a pull request:

https://github.com/apache/cordova-docs/pull/587

Update plugman.md

In installing plugins using Plugman, command install is required.
Without the command install, the plugin install fails and shows About 
Plugman instead.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/darylldawn/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/587.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #587


commit d277f823dc6ad9128f4ba190d855ba68f91021a3
Author: darylldawn 
Date:   2016-04-28T01:18:51Z

Update plugman.md

In installing plugins using Plugman, command install is required.
Without the command install, the plugin install fails and shows About 
Plugman instead.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-android/pull/300#issuecomment-215272746
  
Sure, I'll try it out


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] CI Builds on PRs submitted for cordova plugins

[Sarangan Rajamanickam]

Hi All,

I have created a proposal for adding CI builds on PRs submitted for cordova 
plugins. You could find the details in this PR: 
https://github.com/cordova/cordova-discuss/pull/42. Please review the proposal 
and provide your feedback.

Thanks in advance.

Regards
Sarangan Rajamanickam

Re: [DISCUSS] Faster incremental builds

[Carlos Santana]

+1 also minor bump

- Carlos
@csantanapr

> On Apr 27, 2016, at 5:24 PM, Jason Ginchereau  wrote:
> 
> OK, I think there is a solution that will make everyone happy, while 
> maintaining compatibility with existing after_prepare hooks: An incremental 
> prepare can copy both files that are newer AND FILES THAT ARE OLDER than the 
> target files in the platform's www directory, while skipping any files which 
> have an identical last-modified time. That way, any after_prepare hook that 
> modifies a prepared file will still see the file refreshed on every prepare, 
> as it does today, while all the unchanged files will be skipped, greatly 
> speeding up the prepare.
> 
> With this approach, I think there is no need to put the incremental prepare 
> behind a --incremental option; it can just be the default behavior. (I am 
> still adding prepared files to cordova clean also.) And since this shouldn't 
> break anything, it won't require a major version bump. But I suppose it 
> should be a minor version bump, since it's new functionality.
> 
> Jason
> 
> 
> -Original Message-
> From: Jason Ginchereau [mailto:jason...@microsoft.com] 
> Sent: Tuesday, April 26, 2016 9:39 AM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] Faster incremental builds
> 
> I don't understand how adding a file list to the hook parameters will help 
> solve this problem. Any hook that currently fails after an incremental 
> prepare would need to be updated either way. It would be simpler to just 
> update it to correctly handle the case when a file wasn't updated by prepare.
> 
> We still don't have any real examples of hooks where this is a problem, do 
> we? But it still seems safest to save this change for a major version update, 
> unfortunately.
> 
> Jason
> 
> 
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Friday, April 22, 2016 5:03 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Faster incremental builds
> 
> Why your saying is more complicated?
> Complicated for hook authors? 
> for the hooks that don't need they don't have to do anything just ignore the 
> argument in context. 
> 
> "cordova prepare --clean" == "cordova clean && cordova prepare"
> 
> 
> 
> - Carlos
> @csantanapr
> 
>> On Apr 22, 2016, at 7:45 PM, Jason Ginchereau  wrote:
>> 
>> I don't think making the after_prepare hook API more complicated is a good 
>> design. Instead can we just document that after_prepare hooks should be 
>> designed to handle the files being copied only sometimes? Most of them 
>> probably are anyway, because Cordova never made an explicit guarantee about 
>> the files being fresh every time the hook is called. Anyway I guess it could 
>> still be considered a breaking change so maybe it should trigger a 
>> major-version bump?
>> 
>> I don't understand what you are suggesting with "cordova prepare --clean".
>> 
>> -Original Message-
>> From: Carlos Santana [mailto:csantan...@gmail.com]
>> Sent: Thursday, April 21, 2016 17:16
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] Faster incremental builds
>> 
>> I guess it's fine to have default to be faster, we just need to pass the 
>> files to be copied to feed the hook to be aware. It's kind of a break API on 
>> CLI so maybe CLI 7.x but not sure. 
>> 
>> Also for folks that want the conversation approach with one command we can 
>> also have a flag --clean "cordova prepare --clean"
>> 
>> 
>> - Carlos
>> @csantanapr
>> 
>>> On Apr 21, 2016, at 7:42 PM, Jason Ginchereau  
>>> wrote:
>>> 
>>> Thanks Carlos, that's a good point.
>>> 
>>> The Ionic add_platform_class hook 
>>> (https://github.com/driftyco/ionic-package-hooks) actually would be fine; 
>>> it doesn't do anything if the CSS class to be added is already there.
>>> 
>>> But I guess it's possible some other after_prepare hooks might not be as 
>>> smart. I'm not sure what to do about that.
>>> 
>>> 
>>> -Original Message-
>>> From: Carlos Santana [mailto:csantan...@gmail.com]
>>> Sent: Thursday, April 21, 2016 2:25 PM
>>> To: dev@cordova.apache.org
>>> Subject: Re: [DISCUSS] Faster incremental builds
>>> 
>>> The only thing to watch out is folks modified files during after_prepare 
>>> event, then they will be broken if the file have not changed and they 
>>> modified/add content to the file a second time. 
>>> 
>>> To make this work the hook event will need to inform batch/node and plugins 
>>> hooks on before_prepare and after_prepare the list of files that are going 
>>> to be copy, so the hook owner can know not to modified the file if their 
>>> file is not I the list. 
>>> 
>>> One real use case is Ionic and I think MobileFirst. 
>>> For MobileForst I think we don't modified I think we just recreate 
>>> new file ok every prepare
>>> 
>>> For Ionic they edit the index.html to a class to to the body element 
>>> to for platform identification
>>> 
>>> - Carlos
>>> 

[GitHub] cordova-plugin-splashscreen pull request: CB-11156 Change default ...

[RobPosener]

Github user RobPosener commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/99#issuecomment-215261001
  
I played around with this and found 1300 "looked the nicest".
Also, you need to update the splashscreen plugin documentation to whatever 
the new value is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/429#issuecomment-215260110
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-11117: Use FileUpdater to optimiz...

[codecov-io]

Github user codecov-io commented on the pull request:

https://github.com/apache/cordova-android/pull/295#issuecomment-215259559
  
## [Current coverage][cc-pull] is **100%**
> Merging [#295][cc-pull] into [master][cc-base-branch] will not change 
coverage

```diff
@@master  #295   diff @@

  Files   1111  
  Lines 1707  1710 +3   
  Methods207   208 +1   
  Messages 0 0  
  Branches   169   169  

+ Hits  1707  1710 +3   
  Misses   0 0  
  Partials 0 0  
```



> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 610fa4a
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-android/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-android/pull/295?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-11117: Use FileUpdater to optimiz...

[jasongin]

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-android/pull/295#issuecomment-215256784
  
@vladimir-kotikov @infil00p please review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: Create jenkins-access.md

[shazron]

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-coho/pull/117

Create jenkins-access.md

Added instructions on how to give a committer Jenkins access.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-coho patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #117


commit 30c81abbb92b182678f8d0871a65aaa0150af00f
Author: Shazron Abdullah 
Date:   2016-04-27T22:52:44Z

Create jenkins-access.md

Added instructions on how to give a committer Jenkins access.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

[jasongin]

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-lib/pull/429#issuecomment-215255548
  
@vladimir-kotikov I think this is ready to go after the latest update. 
Please let me know if you have any further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

[infil00p]

GitHub user infil00p opened a pull request:

https://github.com/apache/cordova-android/pull/300

CB-10096: Upgrading to Gradle Plugin 2.1.0

This is a minor change, but I need people running stable to make sure it 
works. @riknoll Can you take a quick look?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/infil00p/cordova-android InstantRun

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/300.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #300


commit 6b7dce0cfd381e75cf4afd8256a502b2bf8d328e
Author: Joe Bowser 
Date:   2016-04-27T22:00:18Z

CB-10096: Upgrading to Gradle Plugin 2.1.0




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Adding links to the top ...

[normesta]

GitHub user normesta opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/163

Adding links to the top of the readme file to point to samples and 
reference content



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/normesta/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #163


commit bbf8345d705253c56b7ca5aafd9117219d686fef
Author: Norm Estabrook 
Date:   2016-03-31T22:00:59Z

adding a sample

commit f62576bab9e8a811abc397d95f0b8a11865061e6
Author: Norm Estabrook 
Date:   2016-03-31T23:45:24Z

removing sample link and including sample

commit 1412bb9862722c281a46227309362f3fa6917358
Author: Norm Estabrook 
Date:   2016-04-14T22:21:43Z

removing global variable

commit 0601d69bbaf84099be2a3d8405aaa51285cf4943
Author: Norm Estabrook 
Date:   2016-04-15T22:02:34Z

Merge branch 'master' of 
https://github.com/apache/cordova-plugin-inappbrowser

commit aeeb054daa1b08764465321ea51fca02ebd581e8
Author: Norm Estabrook 
Date:   2016-04-15T22:09:32Z

adding links to subsections

commit bdabd9940fda99910fc9e5da59fafc527210dc69
Author: Norm Estabrook 
Date:   2016-04-27T20:34:11Z

Merge branch 'master' of 
https://github.com/apache/cordova-plugin-inappbrowser

commit 42e38e68c286b990dc7ffb6c709f38309e5d38be
Author: Norm Estabrook 
Date:   2016-04-27T21:31:18Z

adding links to guide content and reference content at the top of the 
readme file:




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: added CVE announcement blog post

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/586


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: Adding links to reference...

[normesta]

GitHub user normesta opened a pull request:

https://github.com/apache/cordova-plugin-geolocation/pull/76

Adding links to reference content and sample content to the top of th…

…e readme file

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/normesta/cordova-plugin-geolocation master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-geolocation/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #76


commit 20b3d95b558ccf152d0fd82cb742c83a8b54180f
Author: Norm Estabrook 
Date:   2016-04-27T21:31:55Z

Adding links to reference content and sample content to the top of the 
readme file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Faster incremental builds

[Jason Ginchereau]

OK, I think there is a solution that will make everyone happy, while 
maintaining compatibility with existing after_prepare hooks: An incremental 
prepare can copy both files that are newer AND FILES THAT ARE OLDER than the 
target files in the platform's www directory, while skipping any files which 
have an identical last-modified time. That way, any after_prepare hook that 
modifies a prepared file will still see the file refreshed on every prepare, as 
it does today, while all the unchanged files will be skipped, greatly speeding 
up the prepare.

With this approach, I think there is no need to put the incremental prepare 
behind a --incremental option; it can just be the default behavior. (I am still 
adding prepared files to cordova clean also.) And since this shouldn't break 
anything, it won't require a major version bump. But I suppose it should be a 
minor version bump, since it's new functionality.

Jason


-Original Message-
From: Jason Ginchereau [mailto:jason...@microsoft.com] 
Sent: Tuesday, April 26, 2016 9:39 AM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Faster incremental builds

I don't understand how adding a file list to the hook parameters will help 
solve this problem. Any hook that currently fails after an incremental prepare 
would need to be updated either way. It would be simpler to just update it to 
correctly handle the case when a file wasn't updated by prepare.

We still don't have any real examples of hooks where this is a problem, do we? 
But it still seems safest to save this change for a major version update, 
unfortunately.

Jason


-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Friday, April 22, 2016 5:03 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Faster incremental builds

Why your saying is more complicated?
Complicated for hook authors? 
for the hooks that don't need they don't have to do anything just ignore the 
argument in context. 

"cordova prepare --clean" == "cordova clean && cordova prepare"



- Carlos
@csantanapr

> On Apr 22, 2016, at 7:45 PM, Jason Ginchereau  wrote:
> 
> I don't think making the after_prepare hook API more complicated is a good 
> design. Instead can we just document that after_prepare hooks should be 
> designed to handle the files being copied only sometimes? Most of them 
> probably are anyway, because Cordova never made an explicit guarantee about 
> the files being fresh every time the hook is called. Anyway I guess it could 
> still be considered a breaking change so maybe it should trigger a 
> major-version bump?
> 
> I don't understand what you are suggesting with "cordova prepare --clean".
> 
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Thursday, April 21, 2016 17:16
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Faster incremental builds
> 
> I guess it's fine to have default to be faster, we just need to pass the 
> files to be copied to feed the hook to be aware. It's kind of a break API on 
> CLI so maybe CLI 7.x but not sure. 
> 
> Also for folks that want the conversation approach with one command we can 
> also have a flag --clean "cordova prepare --clean"
> 
> 
> - Carlos
> @csantanapr
> 
>> On Apr 21, 2016, at 7:42 PM, Jason Ginchereau  wrote:
>> 
>> Thanks Carlos, that's a good point.
>> 
>> The Ionic add_platform_class hook 
>> (https://github.com/driftyco/ionic-package-hooks) actually would be fine; it 
>> doesn't do anything if the CSS class to be added is already there.
>> 
>> But I guess it's possible some other after_prepare hooks might not be as 
>> smart. I'm not sure what to do about that.
>> 
>> 
>> -Original Message-
>> From: Carlos Santana [mailto:csantan...@gmail.com]
>> Sent: Thursday, April 21, 2016 2:25 PM
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] Faster incremental builds
>> 
>> The only thing to watch out is folks modified files during after_prepare 
>> event, then they will be broken if the file have not changed and they 
>> modified/add content to the file a second time. 
>> 
>> To make this work the hook event will need to inform batch/node and plugins 
>> hooks on before_prepare and after_prepare the list of files that are going 
>> to be copy, so the hook owner can know not to modified the file if their 
>> file is not I the list. 
>> 
>> One real use case is Ionic and I think MobileFirst. 
>> For MobileForst I think we don't modified I think we just recreate 
>> new file ok every prepare
>> 
>> For Ionic they edit the index.html to a class to to the body element 
>> to for platform identification
>> 
>> - Carlos
>> @csantanapr
>> 
>>> On Apr 21, 2016, at 5:12 PM, Jason Ginchereau  
>>> wrote:
>>> 
>>> If "cordova clean" would also take care of deleting the files copied by 
>>> prepare, then I'd be confident in making prepare incremental by default. 
>>> Then if anyone was ever concerned 

[GitHub] cordova-docs pull request: added CVE announcement blog post

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-docs/pull/586#issuecomment-215230160
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: added CVE announcement blog post

[tony--]

GitHub user tony-- opened a pull request:

https://github.com/apache/cordova-docs/pull/586

added CVE announcement blog post



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tony--/cordova-docs blog-post-27April2016

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/586.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #586


commit bdf815c3f8709b5ff122e509e95e9a9d347e70cd
Author: Tony Homer 
Date:   2016-04-27T21:06:33Z

added CVE announcement blog post




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/4#discussion_r61334254
  
--- Diff: lib/ParamediciOSPermissions.js ---
@@ -0,0 +1,43 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path = require('path');
+var fs   = require('fs');
+var shelljs  = require("shelljs");
+var logger   = require('./utils').logger;
+var util = require('./utils').utilities;
+
+var TCC_FOLDER_PERMISSION = 0777;
+
+function ParamediciOSPermissions(appName, tccDbPath) {
+this.appName = appName;
+this.tccDbPath = tccDbPath;
+}
+
+ParamediciOSPermissions.prototype.updatePermissions = 
function(serviceList){
+var simulatorsFolder   = util.getSimulatorsFolder();
+var simId  = util.getSimId();
+logger.info('Sim Id is: ' + simId);
+var destinationTCCFile = path.join(simulatorsFolder, simId, 
'/data/Library/TCC/TCC.db');
+
+if(!util.doesFileExist(destinationTCCFile)) {
+// No TCC.db file exists by default. So, Copy the new TCC.db file
+var destinationTCCFolder = path.join(simulatorsFolder, simId, 
'/data/Library/TCC');
+if(!util.doesFileExist(destinationTCCFolder)){
+fs.mkdir(destinationTCCFolder, TCC_FOLDER_PERMISSION);
+}
+var command = "cp " + this.tccDbPath + " " + destinationTCCFolder;
+logger.info("Running Command: " + command);
+shelljs.exec(command, {silent: true, async: false});
+}
--- End diff --

DOne


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/4#discussion_r61334214
  
--- Diff: lib/ParamedicConfig.js ---
@@ -36,8 +36,10 @@ ParamedicConfig.parseFromArguments = function (argv) {
 startPort: argv.startport || argv.port,
 endPort:   argv.endport || argv.port,
 externalServerUrl: argv.externalServerUrl,
-reportSavePath:!!argv.reportSavePath? argv.reportSavePath: 
undefined,
-cleanUpAfterRun:   !!argv.cleanUpAfterRun? true: false
+outputDir: !!argv.outputDir? argv.outputDir: null,
+cleanUpAfterRun:   !!argv.cleanUpAfterRun? true: false,
+logMins:   !!argv.logMins? argv.logMins: null,
--- End diff --

We are initializing it in paramedic.js


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/4#discussion_r61334368
  
--- Diff: lib/utils/utilities.js ---
@@ -0,0 +1,123 @@
+#!/usr/bin/env node
+
+var shelljs = require('shelljs');
+var verbose = undefined;
+var fs  = require('fs');
+var os  = require("os");
+var util= require('util');
+var path= require("path-extra");
+var logger  = require('cordova-common').CordovaLogger.get();
+
+var HEADING_LINE_PATTERN = /List of devices/m;
+var DEVICE_ROW_PATTERN   = /(emulator|device|host)/m;
+
+function isWindows () {
+return /^win/.test(os.platform());
+}
+
+function countAndroidDevices() {
+var listCommand = "adb devices";
+
+logger.info("running:");
+logger.info("" + listCommand);
+
+var numDevices = 0;
+var result = shelljs.exec(listCommand, {silent: false, async: false});
+result.output.split('\n').forEach(function (line) {
+if (!HEADING_LINE_PATTERN.test(line) && 
DEVICE_ROW_PATTERN.test(line)) {
+numDevices += 1;
+}
+});
+return numDevices;
+}
+
+function secToMin (seconds) {
+return Math.ceil(seconds / 60);
+}
+
+function getSimulatorsFolder() {
+var simulatorsFolderPath = path.join(path.homedir(), "Library", 
"Developer", "CoreSimulator", "Devices");
+return simulatorsFolderPath;
+}
+
+function getSimId() {
+var findSimCommand = "cordova run --list --emulator | grep ^iPhone | 
tail -n1";
+
+logger.info("running:");
+logger.info("" + findSimCommand);
+
+var findSimResult = shelljs.exec(findSimCommand, {silent: true, async: 
false});
+
+if (findSimResult.code > 0) {
+logger.error("Failed to find simulator we deployed to");
+return;
+}
+
+var split = findSimResult.output.split(", ");
+
+// Format of the output is "iPhone-6s-Plus, 9.1"
+// Extract the device name and the version number
+var device = split[0].replace(/-/g, " ").trim();
+var version = split[1].trim();
+
+// Next, figure out the ID of the simulator we found
+var instrCommand = "instruments -s devices | grep ^iPhone";
+logger.info("running:");
+logger.info("" + instrCommand);
+
+var instrResult = shelljs.exec(instrCommand, {silent: true, async: 
false});
+
+if (instrResult.code > 0) {
+logger.error("Failed to get the list of simulators");
+return;
+}
+
+// This matches  () []
+var simIdRegex = /^([a-zA-Z\d ]+) \(([\d.]+)\) \[([a-zA-Z\d\-]*)\]$/;
+
+var simId = null;
+var lines = instrResult.output.split(/\n/);
+lines.forEach(function(line) {
+var simIdMatch = simIdRegex.exec(line);
+if (simIdMatch && simIdMatch.length === 4 && simIdMatch[1] === 
device && simIdMatch[2] === version) {
+simId = encodeURIComponent(simIdMatch[3]);
+}
+});
+
+return simId;
+}
+
+function doesFileExist(filePath) {
+var fileExists = false;
+try {
+stats = fs.statSync(filePath);
+fileExists = true;
+} catch (e) {
+fileExists = false;
+}
+return fileExists;
+}
+
+function getSqlite3InsertionCommand(destinationTCCFile, service, appName) {
+return util.format( 'sqlite3 %s "insert into access'
+  + '(service, client, client_type, allowed, 
prompt_count, csreq) values(\'%s\', \'%s\', '
+  + '0,1,1,NULL)"', destinationTCCFile, service, 
appName);
+}
+
+module.exports = {
+ANDROID:"android",
+IOS:"ios",
+WINDOWS:"windows",
+PARAMEDIC_DEFAULT_APP_NAME: "io.cordova.hellocordova",
+
+DEFAULT_LOG_TIME: 15,
+DEFAULT_LOG_TIME_ADDITIONAL: 2,
+
+secToMin: secToMin,
+isWindows:  isWindows,
+countAndroidDevices: countAndroidDevices,
+getSimulatorsFolder: getSimulatorsFolder,
+getSimId: getSimId,
+doesFileExist: doesFileExist,
+getSqlite3InsertionCommand: getSqlite3InsertionCommand
+};
--- End diff --

This seems to be fine


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, 

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/4#discussion_r61334311
  
--- Diff: lib/utils/utilities.js ---
@@ -0,0 +1,123 @@
+#!/usr/bin/env node
+
+var shelljs = require('shelljs');
+var verbose = undefined;
+var fs  = require('fs');
+var os  = require("os");
+var util= require('util');
+var path= require("path-extra");
+var logger  = require('cordova-common').CordovaLogger.get();
+
+var HEADING_LINE_PATTERN = /List of devices/m;
+var DEVICE_ROW_PATTERN   = /(emulator|device|host)/m;
+
+function isWindows () {
+return /^win/.test(os.platform());
+}
+
+function countAndroidDevices() {
+var listCommand = "adb devices";
+
+logger.info("running:");
+logger.info("" + listCommand);
+
+var numDevices = 0;
+var result = shelljs.exec(listCommand, {silent: false, async: false});
+result.output.split('\n').forEach(function (line) {
+if (!HEADING_LINE_PATTERN.test(line) && 
DEVICE_ROW_PATTERN.test(line)) {
+numDevices += 1;
+}
+});
+return numDevices;
+}
+
+function secToMin (seconds) {
+return Math.ceil(seconds / 60);
+}
+
+function getSimulatorsFolder() {
+var simulatorsFolderPath = path.join(path.homedir(), "Library", 
"Developer", "CoreSimulator", "Devices");
+return simulatorsFolderPath;
+}
+
+function getSimId() {
+var findSimCommand = "cordova run --list --emulator | grep ^iPhone | 
tail -n1";
+
+logger.info("running:");
+logger.info("" + findSimCommand);
+
+var findSimResult = shelljs.exec(findSimCommand, {silent: true, async: 
false});
+
+if (findSimResult.code > 0) {
+logger.error("Failed to find simulator we deployed to");
+return;
+}
+
+var split = findSimResult.output.split(", ");
+
+// Format of the output is "iPhone-6s-Plus, 9.1"
+// Extract the device name and the version number
+var device = split[0].replace(/-/g, " ").trim();
+var version = split[1].trim();
+
+// Next, figure out the ID of the simulator we found
+var instrCommand = "instruments -s devices | grep ^iPhone";
+logger.info("running:");
+logger.info("" + instrCommand);
+
+var instrResult = shelljs.exec(instrCommand, {silent: true, async: 
false});
+
+if (instrResult.code > 0) {
+logger.error("Failed to get the list of simulators");
+return;
+}
+
+// This matches  () []
+var simIdRegex = /^([a-zA-Z\d ]+) \(([\d.]+)\) \[([a-zA-Z\d\-]*)\]$/;
+
+var simId = null;
+var lines = instrResult.output.split(/\n/);
+lines.forEach(function(line) {
+var simIdMatch = simIdRegex.exec(line);
+if (simIdMatch && simIdMatch.length === 4 && simIdMatch[1] === 
device && simIdMatch[2] === version) {
+simId = encodeURIComponent(simIdMatch[3]);
+}
+});
+
+return simId;
+}
--- End diff --

Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/4#discussion_r61334228
  
--- Diff: lib/ParamedicConfig.js ---
@@ -36,8 +36,10 @@ ParamedicConfig.parseFromArguments = function (argv) {
 startPort: argv.startport || argv.port,
 endPort:   argv.endport || argv.port,
 externalServerUrl: argv.externalServerUrl,
-reportSavePath:!!argv.reportSavePath? argv.reportSavePath: 
undefined,
-cleanUpAfterRun:   !!argv.cleanUpAfterRun? true: false
+outputDir: !!argv.outputDir? argv.outputDir: null,
+cleanUpAfterRun:   !!argv.cleanUpAfterRun? true: false,
+logMins:   !!argv.logMins? argv.logMins: null,
+tccDbPath: !!argv.tccDbPath? argv.tccDbPath: null
--- End diff --

DOne


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/4#discussion_r61334170
  
--- Diff: lib/ParamediciOSPermissions.js ---
@@ -0,0 +1,43 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path = require('path');
+var fs   = require('fs');
+var shelljs  = require("shelljs");
+var logger   = require('./utils').logger;
+var util = require('./utils').utilities;
+
+var TCC_FOLDER_PERMISSION = 0777;
--- End diff --

Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Patch release for Cordova Plugin File

[Raghav Katyal]

Though it isn't a common scenario, I thought of prioritizing this since it 
would cause an app crash. Thoughts?

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com] 
Sent: Wednesday, April 27, 2016 11:24 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Patch release for Cordova Plugin File

How critical is this?  How many devices have removable external storage?
Why can't this wait for a full plugins release?

On Wed, Apr 27, 2016, 11:08 AM Raghav Katyal  wrote:

> Recent release of cordova-plugin-file introduced an app crash scenario 
> when external storage is not mounted on Android.  I think we need to 
> do a patch release for it.
>
> JIRA:  
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-11142=01%7c01%7crakatyal%40micr
> osoft.com%7c0e35568063264be39c1a08d36ec930c5%7c72f988bf86f141af91ab2d7
> cd011db47%7c1=LISEMfv7OMgHQnbKFB6j%2bYTqASzcDJD4SGV8OPhLGrw%3d
>
> PR: https://github.com/apache/cordova-plugin-file/pull/179
>
>
>
> Are there any other changes we need to loop in? I plan to start the 
> release next week.
>
>
>
> Thanks,
>
> Raghav
>
>

[GitHub] cordova-plugin-media-capture pull request: CB-10554: Implementing ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/60#issuecomment-215216238
  
@adamduren @nikhilkh @infil00p I'd appreciate some feedback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: CB-10554: Implementing ...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/60

CB-10554: Implementing plugin save/restore API for Android

The purpose of this PR is to handle the case where the Webview gets 
destroyed in the background while a capture activity is in the foreground. #51 
was invalidated by some updates that were recently made to the plugin to handle 
overlapping permission and activity requests.

Also worth noting is that I did something different than the usual resume 
event API for getting pending plugin callback results. Instead of returning the 
native result to the javascript directly, this plugin needs to first wrap the 
results returned by the native code in a `MediaFile` object for those results 
to be useful. For that reason, I altered the plugin to expose two document 
events on Android that the user can subscribe to rather than the 
cordova-android generated resume event. These events directly return the 
wrapped result rather than the raw native one. It ends up looking like this:

```javascript
function onDeviceReady() {
// pendingcaptureresult is fired if the capture call is successful
document.addEventListener('pendingcaptureresult', function(mediaFiles) {
// Do something with result
});

// pendingcaptureerror is fired if the capture call is unsuccessful
document.addEventListener('pendingcaptureerror', function(error) {
// Handle error case
});
}
document.addEventListener('deviceready', onDeviceReady);
```

Whereas using the resume event directly would require us to expose a helper 
API on Android:

```javascript
function onDeviceReady() {
document.addEventListener(resume, function(event) {
if(event.pendingResult && event.pendingResult.pluginServiceName === 
"Capture") {
if(event.pendingResult.pluginStatus === "OK") {
var rawMediaFiles = event.pendingResult.result;
// Here, we would need to expose some weird helper function 
to deal with the native result
var mediaFiles = capture.wrapMediaFiles(mediaFiles);
// Do something with result
} else {
var error = event.pendingResult.result;
// Handle the error case
}
}
});
}
document.addEventListener('deviceready', onDeviceReady);
```

I think this makes the API a bit cleaner and also opens the way for plugins 
that do much more heavy javascript work before returning callback results. This 
hasn't really come up before because the other two core plugins that had this 
issue (camera and contacts) could just pass the native result directly to the 
javascript.

I'd appreciate some feedback on this API and if it seems okay I might 
update the Android plugin guide with an example so that other plugins can use 
this pattern.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-media-capture 
CB-10554

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media-capture/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #60






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine pull request: [CB-10818] Support t...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10817 The webView...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

CVE-2015-5207 - Bypass of Access Restrictions in Apache Cordova iOS

[Tony Homer]

CVE-2015-5207 - Bypass of Access Restrictions in Apache Cordova iOS

Severity:
High

Vendor:
The Apache Software Foundation

Versions Affected:
cordova-ios 3.9.1 and below

Description:
Apache Cordova iOS contains 2 methods to bypass the URL access
restrictions provided by the whitelist. An attacker can use any of the
2 methods to load malicious resources in an app that uses a whitelist
to only load trusted resources.

Upgrade path:
Developers who are concerned about this issue should install version
4.0.0 or higher of the cordova-ios platform.

Credit:
This issue was discovered by Muneaki Nishimura (nishimunea) of Recruit
Technologies Co.,Ltd.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

CVE-2015-5208 - Arbitrary plugin execution issue in Apache Cordova iOS

[Tony Homer]

CVE-2015-5208 - Arbitrary plugin execution issue in Apache Cordova iOS

Severity:
High

Vendor:
The Apache Software Foundation

Versions Affected:
cordova-ios 3.9.1 and below

Description:
An arbitrary plugin can be executed when a user clicks on a link.

Upgrade path:
Developers who are concerned about this issue should install version
4.0.0 or higher of the cordova-ios platform.

Credit:
This issue was discovered by Muneaki Nishimura (nishimunea) of Recruit
Technologies Co.,Ltd.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

CVE-2015-5207 - Bypass of Access Restrictions in Apache Cordova iOS

[Tony Homer]

CVE-2015-5207 - Bypass of Access Restrictions in Apache Cordova iOS
Severity: High
Vendor: The Apache Software Foundation
Versions Affected:cordova-ios 3.9.1 and below
Description:Apache Cordova iOS contains 2 methods to bypass the URL access
restrictions provided by the whitelist. An attacker can use any of the 2
methods to load malicious resources in an app that uses a whitelist to only
load trusted resources.
Upgrade path:Developers who are concerned about this issue should install
version 4.0.0 or higher of the cordova-ios platform.
Credit:This issue was discovered by Muneaki Nishimura (nishimunea) of
Recruit Technologies Co.,Ltd.

Re: [DISCUSS] Patch release for Cordova Plugin File

[Darryl Pogue]

Not a plugin, but I'd appreciate a tools release (or at least a cordova-lib
release).

On 27 April 2016 at 11:26, Steven Gill  wrote:

> I'm fine with you doing a plugins release next week. Anyone else have any
> plugins that need a release?
>
> On Wed, Apr 27, 2016 at 11:24 AM, Joe Bowser  wrote:
>
> > How critical is this?  How many devices have removable external storage?
> > Why can't this wait for a full plugins release?
> >
> > On Wed, Apr 27, 2016, 11:08 AM Raghav Katyal 
> > wrote:
> >
> > > Recent release of cordova-plugin-file introduced an app crash scenario
> > > when external storage is not mounted on Android.  I think we need to
> do a
> > > patch release for it.
> > >
> > > JIRA:  https://issues.apache.org/jira/browse/CB-11142
> > >
> > > PR: https://github.com/apache/cordova-plugin-file/pull/179
> > >
> > >
> > >
> > > Are there any other changes we need to loop in? I plan to start the
> > > release next week.
> > >
> > >
> > >
> > > Thanks,
> > >
> > > Raghav
> > >
> > >
> >
>

Re: [DISCUSS] Patch release for Cordova Plugin File

[Shazron]

I'm integrating two patches for cordova-plugin-wkwebview-engine today, that
can go in next week's release.

On Wed, Apr 27, 2016 at 11:26 AM, Steven Gill 
wrote:

> I'm fine with you doing a plugins release next week. Anyone else have any
> plugins that need a release?
>
> On Wed, Apr 27, 2016 at 11:24 AM, Joe Bowser  wrote:
>
> > How critical is this?  How many devices have removable external storage?
> > Why can't this wait for a full plugins release?
> >
> > On Wed, Apr 27, 2016, 11:08 AM Raghav Katyal 
> > wrote:
> >
> > > Recent release of cordova-plugin-file introduced an app crash scenario
> > > when external storage is not mounted on Android.  I think we need to
> do a
> > > patch release for it.
> > >
> > > JIRA:  https://issues.apache.org/jira/browse/CB-11142
> > >
> > > PR: https://github.com/apache/cordova-plugin-file/pull/179
> > >
> > >
> > >
> > > Are there any other changes we need to loop in? I plan to start the
> > > release next week.
> > >
> > >
> > >
> > > Thanks,
> > >
> > > Raghav
> > >
> > >
> >
>

[GitHub] cordova-plugin-splashscreen pull request: CB-11156 Change default ...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/99#issuecomment-215191026
  
Defaults for windows is being changed in 
https://github.com/apache/cordova-windows/pull/170.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Patch release for Cordova Plugin File

[Steven Gill]

I'm fine with you doing a plugins release next week. Anyone else have any
plugins that need a release?

On Wed, Apr 27, 2016 at 11:24 AM, Joe Bowser  wrote:

> How critical is this?  How many devices have removable external storage?
> Why can't this wait for a full plugins release?
>
> On Wed, Apr 27, 2016, 11:08 AM Raghav Katyal 
> wrote:
>
> > Recent release of cordova-plugin-file introduced an app crash scenario
> > when external storage is not mounted on Android.  I think we need to do a
> > patch release for it.
> >
> > JIRA:  https://issues.apache.org/jira/browse/CB-11142
> >
> > PR: https://github.com/apache/cordova-plugin-file/pull/179
> >
> >
> >
> > Are there any other changes we need to loop in? I plan to start the
> > release next week.
> >
> >
> >
> > Thanks,
> >
> > Raghav
> >
> >
>

Re: [DISCUSS] Patch release for Cordova Plugin File

[Joe Bowser]

How critical is this?  How many devices have removable external storage?
Why can't this wait for a full plugins release?

On Wed, Apr 27, 2016, 11:08 AM Raghav Katyal  wrote:

> Recent release of cordova-plugin-file introduced an app crash scenario
> when external storage is not mounted on Android.  I think we need to do a
> patch release for it.
>
> JIRA:  https://issues.apache.org/jira/browse/CB-11142
>
> PR: https://github.com/apache/cordova-plugin-file/pull/179
>
>
>
> Are there any other changes we need to loop in? I plan to start the
> release next week.
>
>
>
> Thanks,
>
> Raghav
>
>

[DISCUSS] Patch release for Cordova Plugin File

[Raghav Katyal]

Recent release of cordova-plugin-file introduced an app crash scenario when 
external storage is not mounted on Android.  I think we need to do a patch 
release for it.

JIRA:  https://issues.apache.org/jira/browse/CB-11142

PR: https://github.com/apache/cordova-plugin-file/pull/179



Are there any other changes we need to loop in? I plan to start the release 
next week.



Thanks,

Raghav

[GitHub] cordova-plugin-splashscreen pull request: CB-11156 Change default ...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/99#issuecomment-215144537
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-11156 Change default ...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/99#issuecomment-215144520
  
I'm assuming the default for Windows is already 500?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-11162 Appium tests: retry s...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/208

CB-11162 Appium tests: retry spec on failure

https://issues.apache.org/jira/browse/CB-11162

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-11162

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #208


commit f91578ce0128f6ba51f2ddd79c6ec3fd022d0a84
Author: Alexander Sorokin 
Date:   2016-04-27T15:02:48Z

CB-11162 Appium tests: retry spec on failure




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-coho/pull/116

CB-7904 Built nightly releases using coho

Updates code for the current version
Fixed the date format

[Jira issue](https://issues.apache.org/jira/browse/CB-7904)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-coho CB-7904

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #116


commit ac43416ac3c75e686bd6dd86a42d6123c0821c49
Author: daserge 
Date:   2016-04-27T14:30:16Z

CB-7904 Built nightly releases using coho

Updates code for the current version
Fixed the date format




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

[osvso]

Github user osvso commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-215002415
  
I've changed the implementation a bit. Currently defining additional 
property with custom application scheme is not required anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11156 Change default FadeSplashSc...

[rakatyal]

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-windows/pull/170#issuecomment-214996602
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: iOS: Add support for playing no...

[vintage]

Github user vintage commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/39#issuecomment-214994434
  
That's the one of the features which is needed in my project. Unfortunately 
I failed to merge current master into this branch. Will try again later, but I 
need to fully understand what is going on in the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-11156 Change default ...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/99

CB-11156 Change default FadeSplashScreenDuration value

Updated the docs

[Jira issue](https://issues.apache.org/jira/browse/CB-11156)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen 
CB-11156

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/99.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #99


commit 8761fa779993a0feac7677a0e6f0b3439adb198a
Author: daserge 
Date:   2016-04-26T15:50:39Z

CB-11156 Change default FadeSplashScreenDuration value




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11156 Change default FadeSplashSc...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-windows/pull/170

CB-11156 Change default FadeSplashScreenDuration value

[Jira issue](https://issues.apache.org/jira/browse/CB-11156)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-11156

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/170.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #170


commit 15ca96121f69e7b81a4aed08646c4b8a49e3e2cb
Author: daserge 
Date:   2016-04-26T16:14:34Z

CB-11156 Change default FadeSplashScreenDuration value




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org