[GitHub] cordova-cli pull request: CB-11284 Telemetry: Track platforms/plug...

2016-05-20 Thread nikhilkh 
Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/253#discussion_r64108237
  
--- Diff: src/cli.js ---
@@ -143,20 +143,27 @@ module.exports = function (inputArgs, cb) {
 return cli(inputArgs);
 }).then(function () {
 if (shouldCollectTelemetry && !isTelemetryCmd) {
-telemetry.track(cmd, 'successful');
+telemetry.track(cmd, subcommand, 'successful');
 }
 // call cb with error as arg if something failed
 cb(null);
 }).fail(function (err) {
 if (shouldCollectTelemetry && !isTelemetryCmd) {
-telemetry.track(cmd, 'unsuccessful');
+telemetry.track(cmd, subcommand, 'unsuccessful');
 }
 // call cb with error as arg if something failed
 cb(err);
 throw err;
 }).done();
 };
 
+function getSubCommand(args, cmd) {
+if(cmd === 'platform' || cmd === 'platforms' || cmd === 'plugin' || 
cmd === 'plugins' || cmd === 'telemetry') {
+return args[3]; // e.g: args='node cordova platform rm ios', 'node 
cordova telemetry on'
+}
+return "";
--- End diff --

Instead of empty string - you might want to return null


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11284 Telemetry: Track platforms/plug...

2016-05-20 Thread nikhilkh 
Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-cli/pull/253#issuecomment-220719536
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-11292 fix broken MessageChannel a...

2016-05-20 Thread codecov-io 
Github user codecov-io commented on the pull request:

https://github.com/apache/cordova-android/pull/307#issuecomment-220714174
  
## [Current coverage][cc-pull] is **34.21%**
> Merging [#307][cc-pull] into [master][cc-base-branch] will not change 
coverage

```diff
@@ master   #307   diff @@
==
  Files11 11  
  Lines   947947  
  Methods 194194  
  Messages  0  0  
  Branches153153  
==
  Hits324324  
  Misses  623623  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[9738079...e37c1f4][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-android/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-android/compare/9738079c4299455b1b251febdd5b16c07c86...e37c1f471e4138cdbdc7edcad1bda868749c94e8
[cc-pull]: https://codecov.io/gh/apache/cordova-android/pull/307?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-11292 fix broken MessageChannel a...

2016-05-20 Thread tony-- 
GitHub user tony-- opened a pull request:

https://github.com/apache/cordova-android/pull/307

CB-11292 fix broken MessageChannel after plugins are recreated

also added a new test to prevent regression - probably overkill but the 
issue was hard to isolate

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tony--/cordova-android CB-11292

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #307


commit a5d0e2778c07ca9b6075debe3385981272e1721a
Author: Tony Homer 
Date:   2016-05-20T20:13:46Z

CB-11292 fix broken MessageChannel after plugins are recreated




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10096: Upgrade test project to Gr...

2016-05-20 Thread tony-- 
GitHub user tony-- opened a pull request:

https://github.com/apache/cordova-android/pull/306

CB-10096: Upgrade test project to Gradle Plugin 2.1.0



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tony--/cordova-android CB-10096-more

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #306


commit 48b45497d575a5ecf749e24a99e6b91ce409f3cb
Author: Tony Homer 
Date:   2016-05-20T20:15:49Z

CB-10096: Upgrade test project to Gradle Plugin 2.1.0




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11284 Telemetry: Track platforms/plug...

2016-05-20 Thread riknoll 
Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/253#discussion_r64092365
  
--- Diff: src/cli.js ---
@@ -143,20 +143,27 @@ module.exports = function (inputArgs, cb) {
 return cli(inputArgs);
 }).then(function () {
 if (shouldCollectTelemetry && !isTelemetryCmd) {
-telemetry.track(cmd, 'successful');
+telemetry.track(cmd, subcommand, 'successful');
 }
 // call cb with error as arg if something failed
 cb(null);
 }).fail(function (err) {
 if (shouldCollectTelemetry && !isTelemetryCmd) {
-telemetry.track(cmd, 'unsuccessful');
+telemetry.track(cmd, subcommand, 'unsuccessful');
--- End diff --

Ah, I see you check for it below. I think the code might be cleaner/easier 
to understand if you just do the check here rather than manually deleting null 
values from the arguments array.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11284 Telemetry: Track platforms/plug...

2016-05-20 Thread riknoll 
Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/253#discussion_r64091935
  
--- Diff: src/cli.js ---
@@ -143,20 +143,27 @@ module.exports = function (inputArgs, cb) {
 return cli(inputArgs);
 }).then(function () {
 if (shouldCollectTelemetry && !isTelemetryCmd) {
-telemetry.track(cmd, 'successful');
+telemetry.track(cmd, subcommand, 'successful');
 }
 // call cb with error as arg if something failed
 cb(null);
 }).fail(function (err) {
 if (shouldCollectTelemetry && !isTelemetryCmd) {
-telemetry.track(cmd, 'unsuccessful');
+telemetry.track(cmd, subcommand, 'unsuccessful');
--- End diff --

Is there no need to check if subcommand is undefined? E.g. if the user runs 
`cordova platform`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11284 Telemetry: Track platforms/plug...

2016-05-20 Thread omefire 
GitHub user omefire opened a pull request:

https://github.com/apache/cordova-cli/pull/253

CB-11284 Telemetry: Track platforms/plugins subcommands(add/rm/etc...)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-cli CB-11284-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #253


commit 10b08ae956388774dd3216254906f82bd1404619
Author: Omar Mefire 
Date:   2016-05-20T16:32:55Z

CB-11284 Telemetry: Track platforms/plugins subcommands(add/rm/etc...)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

2016-05-20 Thread ktop 
Github user ktop commented on the pull request:

https://github.com/apache/cordova-lib/pull/432#issuecomment-220647997
  
I'd like to clear up some confusion I have on adding attributes. 
Before, we had decided on going with this syntax where the child elements 
of config-file tag would point to the child tags of the parent we want to add 
attributes to, so that we could add attributes to more than one child in a 
single config-file tag.

With the following syntax, I wouldn't be able to at add to the second 
activity. 
```xml



```

Now with your suggestion, the tag would look like this:
Here, I would be able to specify the second activity, but this contradicts 
with what we had before since activity tag isn't a child of the parent. 
```xml



```

Would we lose the ability to add attributes to more than one child? Or 
should we try to do both? Detect that we want to add to the tag that is the 
same as the parent as well as child tags. (Not sure if this makes sense)
```xml




```
Or any other ideas?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-11280 Pin nightly platforms versions

2016-05-20 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/124


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-11296: Appium: Better eleme...

2016-05-20 Thread cordova-qa 
Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/218#issuecomment-220544861
  
Cordova CI Build has completed successfully. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/218/commits/a05f169984aff9b1db1ddf4f04618b78c2b81664)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=windows-slave,platformName=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=windows-slave,platformName=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=windows-slave,platformName=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=windows-slave,platformName=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=windows-slave,platformName=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=windows-slave,platformName=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=windows-slave,platformName=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=windows-slave,platformName=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=windows-slave,platformName=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=windows-slave,platformName=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=windows-slave,platformName=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=mac-slave,platformName=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=mac-slave,platformName=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=mac-slave,platformName=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=mac-slave,platformName=ios/artifact/)
 |
| [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=mac-slave,platformName=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=mac-slave,platformName=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=mac-slave,platformName=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/16//label=mac-slave,platformName=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-11296: Appium: Better ele...

2016-05-20 Thread cordova-qa 
Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/127#issuecomment-220544301
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/127/commits/4454da77cfe1ba1859c8df248575aad6948cffa6)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=windows-slave,platformName=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=windows-slave,platformName=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=windows-slave,platformName=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=windows-slave,platformName=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=windows-slave,platformName=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=windows-slave,platformName=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=windows-slave,platformName=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=windows-slave,platformName=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=windows-slave,platformName=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=windows-slave,platformName=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=windows-slave,platformName=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=mac-slave,platformName=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=mac-slave,platformName=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=mac-slave,platformName=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=mac-slave,platformName=ios/artifact/)
 |
| [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=mac-slave,platformName=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=mac-slave,platformName=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=mac-slave,platformName=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/14//label=mac-slave,platformName=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-11296: Appium: Better ele...

2016-05-20 Thread alsorokin 
GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/127

CB-11296: Appium: Better element clicking and session error handling



### Platforms affected
Android, iOS

### What does this PR do?
https://issues.apache.org/jira/browse/CB-11296
* (iOS) Adds a workaround for Appium bug when it clicks the wrong element.
* Tests fail fast if couldn't create a session

### What testing has been done on this change?
Ran Appium tests on iOS real device (8.1) / simulator (8.4) and on Android 
(5.0 and 4.4) emulators

### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [x] [Reported an issue](https://issues.apache.org/jira/browse/CB-11296) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-11296

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #127


commit 4454da77cfe1ba1859c8df248575aad6948cffa6
Author: Alexander Sorokin 
Date:   2016-05-19T13:23:57Z

CB-11296: Appium: Better element clicking and session error handling




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org