[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/237
  
## [Current coverage][cc-pull] is 34.72% (diff: 100%)
> Merging [#237][cc-pull] into [master][cc-base-branch] will decrease 
coverage by **17.08%**

```diff
@@ master   #237   diff @@
==
  Files11 11  
  Lines   882884 +2   
  Methods 132132  
  Messages  0  0  
  Branches143144 +1   
==
- Hits457307   -150   
- Misses  425577   +152   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[5c3885b...e3cfdb2][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-ios/compare/5c3885b807f4c9556bf350c72400827a333f78d3...e3cfdb2b09099b5a1fa33cf041cb4d48b9db5697?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-ios/pull/237?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #466: Add general purpose ConfigParser.getAttribute API

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/466
  
## [Current coverage][cc-pull] is 80.62% (diff: 100%)
> Merging [#466][cc-pull] into [master][cc-base-branch] will not change 
coverage

```diff
@@ master   #466   diff @@
==
  Files68 68  
  Lines  5394   5394  
  Methods 855855  
  Messages  0  0  
  Branches   1040   1040  
==
  Hits   4349   4349  
  Misses 1045   1045  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[29382ca...f7af1ab][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-lib/compare/29382ca2bf67e17337845feb4360980df99fe3d2...f7af1abf19488242effb574ab20314fec4709229?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/466?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #237: CB-9789: Support setting the default app loca...

[dpogue]

GitHub user dpogue opened a pull request:

https://github.com/apache/cordova-ios/pull/237

CB-9789: Support setting the default app locale

This allows adding a `defaultlocale="XX"` attribute to the `widget` tag in 
config.xml to set the CFBundleDevelopmentRegion to a different language. This 
allows native UI (like the camera plugin) to use a non-English locale.

Requires https://github.com/apache/cordova-lib/pull/466
References https://github.com/cordova/cordova-discuss/issues/25

/cc @jasongin for the bugfix in `cleanIcons` and `cleanSplashScreens`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpogue/cordova-ios defaultlocale

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #237


commit 088fdaa62f8b67f0e46a2458553194d796875641
Author: Darryl Pogue 
Date:   2016-07-22T03:10:30Z

Fix wrong platform name in asset cleanup

commit e4f3cf9a5889d9230f2e4032d0a1037cdb783844
Author: Darryl Pogue 
Date:   2016-07-22T03:10:55Z

CB-9789: Allow setting the default locale




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #466: Add general purpose ConfigParser.getAttribute...

[dpogue]

GitHub user dpogue opened a pull request:

https://github.com/apache/cordova-lib/pull/466

Add general purpose ConfigParser.getAttribute API

This allows platform to have their specific override attributes without 
needing to update this file and worry about syncing platform versions against 
cordova-common versions.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpogue/cordova-lib config-getAttr

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #466


commit 12c0858d4fc6ccd45e34605623d6ec6d2be6c326
Author: Darryl Pogue 
Date:   2016-07-22T03:03:33Z

Add general purpose ConfigParser.getAttribute API




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #78 for cordova has failed

[Apache Jenkins Server]

Nightly build #78 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/78/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/78/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #188: Fix issues where MSBuild cannot be found due to ...

[TimBarham]

Github user TimBarham commented on the issue:

https://github.com/apache/cordova-windows/pull/188
  
Thanks @jicongw - I just had one comment, plus fixing the commit message as 
I mentioned offline.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

[julio cesar sanchez]

That issue is about adding an attribute to an existing element of the
AndroidManifest from plugin.xml, this topic is about adding the whole
functionality of writing/editing the .xml/.plist files from config.xml
instead of using a "silly" plugin

2016-07-21 23:24 GMT+02:00 Jesse :

> CB-11023 is what it was submitted under. afaik
>
>
>
>
>
> @purplecabbage
> risingj.com
>
> On Thu, Jul 21, 2016 at 2:22 PM, julio cesar sanchez <
> jcesarmob...@gmail.com
> > wrote:
>
> > We still don't have an issue for this, right?
> >
> > I've been searching and found those three:
> >
> > https://issues.apache.org/jira/browse/CB-7232 (iOS)
> > https://issues.apache.org/jira/browse/CB-11604 (Android)
> > https://issues.apache.org/jira/browse/CB-10832 (Windows)
> >
> >
> >
> > 2016-04-29 17:13 GMT+02:00 Karen Tran :
> >
> > > Can I get someone to review my PR?
> > > https://github.com/apache/cordova-lib/pull/432
> > >
> > > Thanks,
> > > Karen Tran
> > >
> > > On Thu, Apr 21, 2016 at 11:02 AM, Vladimir Kotikov (Akvelon) <
> > > v-vlk...@microsoft.com> wrote:
> > >
> > > > Exactly. Multiple tags is also possible with this syntax.
> > > >
> > > > -
> > > > Best regards, Vladimir
> > > >
> > > > -Original Message-
> > > > From: Karen Tran [mailto:ktop...@gmail.com]
> > > > Sent: Thursday, April 21, 2016 5:20 PM
> > > > To: dev@cordova.apache.org
> > > > Subject: Re: [Android] Need a solution to config.xml and
> > > > AndroidManifest.xml feature requests
> > > >
> > > > @Vladimir, in your suggestion, is this what you were going for? Being
> > > able
> > > > to add multiple attributes to any direct children node of the parent?
> > > >
> > > >  > attr="true">
> > > >  > > android:debuggable="true"
> > > > />
> > > >  
> > > >
> > > >
> > > >
> > > > Regards,
> > > > Karen Tran
> > > >
> > > > On Thu, Apr 21, 2016 at 3:58 AM, Vladimir Kotikov (Akvelon) <
> > > > v-vlk...@microsoft.com> wrote:
> > > >
> > > > > Another proposal about syntax which allows to specify multiple
> > > > > attributes at once and does not require parsing attributes from
> plain
> > > > text:
> > > > >
> > > > >  > > attr="true">
> > > > >  
> > > > >
> > > > > Also I've took a quick look at the implementation and it looks good
> > > > > apart from one minor issue - when we're grafting attributes we
> > > > > probably do not need to create an element to graft attributes to if
> > it
> > > > > doesn't exist, otherwise after adding and then removing  the plugin
> > > > > created xml element will remain in modified file.
> > > > >
> > > > > -
> > > > > Best regards, Vladimir
> > > > >
> > > > > -Original Message-
> > > > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> > > > > Sent: Thursday, April 21, 2016 3:24 AM
> > > > > To: dev@cordova.apache.org
> > > > > Subject: RE: [Android] Need a solution to config.xml and
> > > > > AndroidManifest.xml feature requests
> > > > >
> > > > > Oh great! I have not taken a close look at the implementation
> itself.
> > > > > Perhaps you already had some of this in mind.
> > > > >
> > > > > As for the syntax for changing attributes, I would recommend
> > something
> > > > > like this:
> > > > >
> > > > >  > > parent="/manifest/application"
> > > > > attributeName="android:name" attirbuteValue="MyApplication"/>
> > > > >
> > > > > Also, we should always prioritize config.xml edits over plugin.xml
> > > > > (giving the end developer the full control). In case of conflicts,
> > > > > between plugins & config.xml we should warn and mention which one
> we
> > > > > picked (config.xml)
> > > > >
> > > > > Thanks,
> > > > > Nikhil
> > > > >
> > > > > -Original Message-
> > > > > From: Karen Tran [mailto:ktop...@gmail.com]
> > > > > Sent: Wednesday, April 20, 2016 12:40 PM
> > > > > To: dev@cordova.apache.org
> > > > > Subject: Re: [Android] Need a solution to config.xml and
> > > > > AndroidManifest.xml feature requests
> > > > >
> > > > > Hi,
> > > > >
> > > > > I made an attempt at the functionality of being able to add
> > attributes
> > > > > with the config-file tag. It's not completed yet, but I wanted to
> get
> > > > > some review before I proceed.
> > > > > With my changes, you can add an attribute through the config-file
> tag
> > > > > in plugin.xml when the plugin is added, and when the plugin is
> > > > > removed, the attribute will get removed.
> > > > > https://github.com/ktop/cordova-lib/tree/cb-11023
> > > > >
> > > > > This is what the tag looks like:
> > > > > * > > > > parent="/manifest/application" attr="true">*
> > > > > *android:name="MyApplication"*
> > > > >
> > > > > **
> > > > >
> > > > > Added *attr* attribute to let Config-File know that we want to add
> an
> > > > > attribute. Default should be false and will expect an element
> rather
> > > > > than an attribute.
> > > > >
> > > > > One issue I have is that it can only add 1 attribute per
> config-file
> > > tag.
> > > > > This 

[GitHub] cordova-windows pull request #188: Fix issues where MSBuild cannot be found ...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/188#discussion_r71791061
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -93,6 +93,20 @@ module.exports.findAllAvailableVersions = function () {
 return !!item;
 });
 });
+}
+
+module.exports.findAllAvailableVersions = function () {
+// CB-11548 use VSINSTALLDIR environment if defined to find MSBuild. 
If VSINSTALLDIR
+// is not specified or incorrect - fall back to default discovery 
mechanism.
--- End diff --

It is quite likely that `VSINSTALLDIR` is specified and *correct*, but just 
doesn't contain the msbuild path we're looking for (this will be the case for 
previous versions of VS, for example). So I think it would be clearer to say 
here something like "not specified or doesn't contain the MSBuild path we are 
looking for".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Proposal - New Feature] Add tag to config.xml to handle images

[julio cesar sanchez]

Resurrecting this old thread

I think we need a resource-file tag on the config.xml (as the one on
plugin.xml) to copy resources to the projects, not just images as this
thread started.
Examples:
Images for push notifications
Sounds for push notifications
.plist and .json files with user data now required by google frameworks
(analytics, FCM, etc)


There is a discussion about this in Cordova discuss

https://github.com/cordova/cordova-discuss/issues/6


2015-05-04 15:44 GMT+02:00 Karen Tran :

> Yes, I agree, and the notification icon is a good example. There is nothing
> in config.xml that currently does just a copy over, which is why I'm
> proposing to add this functionality in. I am actually just using a hook
> script to copy the images over right now, but I figure it might be
> beneficial to add this feature in since it's very common to have other
> sorts of icon images that aren't the main application icon.
>
> Your suggestion of using a name attribute would work, and might be better
> than have a new tag since it would be redundant to have two separate icon
> tags doing almost the same thing.
>
> What did you mean by one-off asset problems on other platforms?
>
> On Sun, May 3, 2015 at 7:36 PM, Darryl Pogue  wrote:
>
> > One example that comes to mind is notification icons for Android. It
> > used to be fine to reuse the app icon, but as of Lollipop notification
> > icons are only transparent and white. If your app icon is square, your
> > notification icon will be a white square unless you provide a
> > different one.
> >
> > Currently there's no way to use config.xml to copy a notification icon
> > (or any other non-app icon). If you're treating your platforms as
> > build artifacts, this means you have to write hooks to copy stuff in
> > manually.
> >
> > Something like
> >  > name="ic_notification">
> > would be ideal for that use case.
> >
> >
> > I do think this turns into a slippery slope pretty quickly though,
> > because a case can probably be made for all sorts of one-off asset
> > problems on other platforms and we probably don't want all of those
> > things ending up in config.xml.
> >
> > On 3 May 2015 at 16:30, Karen Tran  wrote:
> > > Buttons were just an example. The image could really be of anything the
> > > user wants in the application.
> > >
> > > What's in cordova now in config.xml is:
> > >
> > > 
> > >
> > > The line above will copy button.png into the drawable-mdpi directory
> and
> > > rename it to icon.png, thus replacing the icon.png that is already
> there.
> > > Of course as a result, my application will be using button.png as the
> > main
> > > icon.
> > > I don't want this.
> > >
> > > I want a new tag, which is similar to icon, but all it does is copy the
> > > image over. No renaming to icon.png. Just plain old copy.
> > >
> > > <*image* src="res/android/button.png" platform="android" density="mdpi"
> > />
> > >
> > > In cordova-lib/cordova-lib/src/cordova/metadata/android-parser.js is
> > where
> > > config.xml gets parsed to handle the icon tag. I believe I can just
> reuse
> > > the code there for this new tag that I want to create, but I just
> wanted
> > to
> > > see if anyone had any objections.
> > >
> > >
> > > On Sat, May 2, 2015 at 5:12 PM, julio cesar sanchez <
> > jcesarmob...@gmail.com>
> > > wrote:
> > >
> > >> But you want it for native buttons?
> > >> If not, you can just put the images on the www folder
> > >>
> > >> El viernes, 1 de mayo de 2015, Karen Tran 
> escribió:
> > >>
> > >> > I am looking for a way to be able to specify an image in the
> > config.xml
> > >> and
> > >> > have it be placed in the drawable directory. Under my
> circumstances, I
> > >> have
> > >> > to assume that when the user creates a cordova project, he/she only
> > knows
> > >> > how to modify the config.xml, so that's why I'm pushing for a way to
> > do
> > >> it
> > >> > this way.
> > >> >
> > >> > I do have a hackish way of doing it by using the preferences tag and
> > >> > getting the path to the image, and then having a script copy it
> over,
> > >> but I
> > >> > know the better way to do it would be to just make a tag to take
> care
> > of
> > >> > images that are not going to be the main icon or splash image and
> have
> > >> > cordova-cli handle it for me when I call cordova prepare.
> > >> >
> > >> > This isn't really for a plugin, though maybe an app template, but I
> > just
> > >> > wanted to add this functionality to be able to specify non-icon and
> > >> > non-splash images through the config.xml.
> > >> >
> > >> > I've found where in cordova-lib that the parsing happens for the
> icon
> > and
> > >> > splash tags, so I was proposing to add a new tag for "general
> images".
> > >> The
> > >> > images could be anything that a user might want in his or her app.
> An
> > >> > example would be a customized button. The user can specify the path
> to
> > >> the
> > >> > image file, and 

Re: Excited to join the group

[Steven Gill]

Welcome Jason!!

Let us know if you have any questions.

I recommend reading http://cordova.apache.org/contribute/ and join us on
slack http://slack.cordova.io/

On Thu, Jul 21, 2016 at 1:10 PM, Jason Wang (DEVDIV) <
jicong.w...@microsoft.com> wrote:

> Hi all,
>
> My name is Jason. I am a developer at Microsoft working on Visual Studio
> Tools for Apache Cordova.
> I have submitted my ICLA form and am looking forward to contributing to
> Cordova.
>
> Best,
> Jason
>

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

[Jesse]

CB-11023 is what it was submitted under. afaik





@purplecabbage
risingj.com

On Thu, Jul 21, 2016 at 2:22 PM, julio cesar sanchez  wrote:

> We still don't have an issue for this, right?
>
> I've been searching and found those three:
>
> https://issues.apache.org/jira/browse/CB-7232 (iOS)
> https://issues.apache.org/jira/browse/CB-11604 (Android)
> https://issues.apache.org/jira/browse/CB-10832 (Windows)
>
>
>
> 2016-04-29 17:13 GMT+02:00 Karen Tran :
>
> > Can I get someone to review my PR?
> > https://github.com/apache/cordova-lib/pull/432
> >
> > Thanks,
> > Karen Tran
> >
> > On Thu, Apr 21, 2016 at 11:02 AM, Vladimir Kotikov (Akvelon) <
> > v-vlk...@microsoft.com> wrote:
> >
> > > Exactly. Multiple tags is also possible with this syntax.
> > >
> > > -
> > > Best regards, Vladimir
> > >
> > > -Original Message-
> > > From: Karen Tran [mailto:ktop...@gmail.com]
> > > Sent: Thursday, April 21, 2016 5:20 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [Android] Need a solution to config.xml and
> > > AndroidManifest.xml feature requests
> > >
> > > @Vladimir, in your suggestion, is this what you were going for? Being
> > able
> > > to add multiple attributes to any direct children node of the parent?
> > >
> > >  attr="true">
> > >  > android:debuggable="true"
> > > />
> > >  
> > >
> > >
> > >
> > > Regards,
> > > Karen Tran
> > >
> > > On Thu, Apr 21, 2016 at 3:58 AM, Vladimir Kotikov (Akvelon) <
> > > v-vlk...@microsoft.com> wrote:
> > >
> > > > Another proposal about syntax which allows to specify multiple
> > > > attributes at once and does not require parsing attributes from plain
> > > text:
> > > >
> > > >  > attr="true">
> > > >  
> > > >
> > > > Also I've took a quick look at the implementation and it looks good
> > > > apart from one minor issue - when we're grafting attributes we
> > > > probably do not need to create an element to graft attributes to if
> it
> > > > doesn't exist, otherwise after adding and then removing  the plugin
> > > > created xml element will remain in modified file.
> > > >
> > > > -
> > > > Best regards, Vladimir
> > > >
> > > > -Original Message-
> > > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> > > > Sent: Thursday, April 21, 2016 3:24 AM
> > > > To: dev@cordova.apache.org
> > > > Subject: RE: [Android] Need a solution to config.xml and
> > > > AndroidManifest.xml feature requests
> > > >
> > > > Oh great! I have not taken a close look at the implementation itself.
> > > > Perhaps you already had some of this in mind.
> > > >
> > > > As for the syntax for changing attributes, I would recommend
> something
> > > > like this:
> > > >
> > > >  > parent="/manifest/application"
> > > > attributeName="android:name" attirbuteValue="MyApplication"/>
> > > >
> > > > Also, we should always prioritize config.xml edits over plugin.xml
> > > > (giving the end developer the full control). In case of conflicts,
> > > > between plugins & config.xml we should warn and mention which one we
> > > > picked (config.xml)
> > > >
> > > > Thanks,
> > > > Nikhil
> > > >
> > > > -Original Message-
> > > > From: Karen Tran [mailto:ktop...@gmail.com]
> > > > Sent: Wednesday, April 20, 2016 12:40 PM
> > > > To: dev@cordova.apache.org
> > > > Subject: Re: [Android] Need a solution to config.xml and
> > > > AndroidManifest.xml feature requests
> > > >
> > > > Hi,
> > > >
> > > > I made an attempt at the functionality of being able to add
> attributes
> > > > with the config-file tag. It's not completed yet, but I wanted to get
> > > > some review before I proceed.
> > > > With my changes, you can add an attribute through the config-file tag
> > > > in plugin.xml when the plugin is added, and when the plugin is
> > > > removed, the attribute will get removed.
> > > > https://github.com/ktop/cordova-lib/tree/cb-11023
> > > >
> > > > This is what the tag looks like:
> > > > * > > > parent="/manifest/application" attr="true">*
> > > > *android:name="MyApplication"*
> > > >
> > > > **
> > > >
> > > > Added *attr* attribute to let Config-File know that we want to add an
> > > > attribute. Default should be false and will expect an element rather
> > > > than an attribute.
> > > >
> > > > One issue I have is that it can only add 1 attribute per config-file
> > tag.
> > > > This is the part that I still need to fix.
> > > >
> > > > Can someone review what I have so far?
> > > >
> > > > Thanks,
> > > > Karen
> > > >
> > > > On Tue, Apr 5, 2016 at 6:54 PM, Simon MacDonald
> > > >  > > > >
> > > > wrote:
> > > >
> > > > > I would love to but I have a few other things to handle first. If
> > > > > someone else picks it up before I get to it then that's cool with
> me.
> > > > >
> > > > >
> > > > > Simon Mac Donald
> > > > >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.i
> > > > > m%
> > > > > 

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

[julio cesar sanchez]

We still don't have an issue for this, right?

I've been searching and found those three:

https://issues.apache.org/jira/browse/CB-7232 (iOS)
https://issues.apache.org/jira/browse/CB-11604 (Android)
https://issues.apache.org/jira/browse/CB-10832 (Windows)



2016-04-29 17:13 GMT+02:00 Karen Tran :

> Can I get someone to review my PR?
> https://github.com/apache/cordova-lib/pull/432
>
> Thanks,
> Karen Tran
>
> On Thu, Apr 21, 2016 at 11:02 AM, Vladimir Kotikov (Akvelon) <
> v-vlk...@microsoft.com> wrote:
>
> > Exactly. Multiple tags is also possible with this syntax.
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Karen Tran [mailto:ktop...@gmail.com]
> > Sent: Thursday, April 21, 2016 5:20 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [Android] Need a solution to config.xml and
> > AndroidManifest.xml feature requests
> >
> > @Vladimir, in your suggestion, is this what you were going for? Being
> able
> > to add multiple attributes to any direct children node of the parent?
> >
> > 
> >  android:debuggable="true"
> > />
> >  
> >
> >
> >
> > Regards,
> > Karen Tran
> >
> > On Thu, Apr 21, 2016 at 3:58 AM, Vladimir Kotikov (Akvelon) <
> > v-vlk...@microsoft.com> wrote:
> >
> > > Another proposal about syntax which allows to specify multiple
> > > attributes at once and does not require parsing attributes from plain
> > text:
> > >
> > >  attr="true">
> > >  
> > >
> > > Also I've took a quick look at the implementation and it looks good
> > > apart from one minor issue - when we're grafting attributes we
> > > probably do not need to create an element to graft attributes to if it
> > > doesn't exist, otherwise after adding and then removing  the plugin
> > > created xml element will remain in modified file.
> > >
> > > -
> > > Best regards, Vladimir
> > >
> > > -Original Message-
> > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> > > Sent: Thursday, April 21, 2016 3:24 AM
> > > To: dev@cordova.apache.org
> > > Subject: RE: [Android] Need a solution to config.xml and
> > > AndroidManifest.xml feature requests
> > >
> > > Oh great! I have not taken a close look at the implementation itself.
> > > Perhaps you already had some of this in mind.
> > >
> > > As for the syntax for changing attributes, I would recommend something
> > > like this:
> > >
> > >  parent="/manifest/application"
> > > attributeName="android:name" attirbuteValue="MyApplication"/>
> > >
> > > Also, we should always prioritize config.xml edits over plugin.xml
> > > (giving the end developer the full control). In case of conflicts,
> > > between plugins & config.xml we should warn and mention which one we
> > > picked (config.xml)
> > >
> > > Thanks,
> > > Nikhil
> > >
> > > -Original Message-
> > > From: Karen Tran [mailto:ktop...@gmail.com]
> > > Sent: Wednesday, April 20, 2016 12:40 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [Android] Need a solution to config.xml and
> > > AndroidManifest.xml feature requests
> > >
> > > Hi,
> > >
> > > I made an attempt at the functionality of being able to add attributes
> > > with the config-file tag. It's not completed yet, but I wanted to get
> > > some review before I proceed.
> > > With my changes, you can add an attribute through the config-file tag
> > > in plugin.xml when the plugin is added, and when the plugin is
> > > removed, the attribute will get removed.
> > > https://github.com/ktop/cordova-lib/tree/cb-11023
> > >
> > > This is what the tag looks like:
> > > * > > parent="/manifest/application" attr="true">*
> > > *android:name="MyApplication"*
> > >
> > > **
> > >
> > > Added *attr* attribute to let Config-File know that we want to add an
> > > attribute. Default should be false and will expect an element rather
> > > than an attribute.
> > >
> > > One issue I have is that it can only add 1 attribute per config-file
> tag.
> > > This is the part that I still need to fix.
> > >
> > > Can someone review what I have so far?
> > >
> > > Thanks,
> > > Karen
> > >
> > > On Tue, Apr 5, 2016 at 6:54 PM, Simon MacDonald
> > >  > > >
> > > wrote:
> > >
> > > > I would love to but I have a few other things to handle first. If
> > > > someone else picks it up before I get to it then that's cool with me.
> > > >
> > > >
> > > > Simon Mac Donald
> > > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.i
> > > > m%
> > > > 2fsimonmacdonald=01%7c01%7cnikhilkh%40microsoft.com%7c379bf4c2d
> > > > ae
> > > > 4454ee13008d369539a2b%7c72f988bf86f141af91ab2d7cd011db47%7c1=T
> > > > vJ lf2LDyl%2bfSbRMDPjmLe%2fMBQf7PnAzRao5QANRrH4%3d
> > > >
> > > > On Tue, Apr 5, 2016 at 6:51 PM, Carlos Santana
> > > > 
> > > > wrote:
> > > >
> > > > > Oh so it means you don't want to work on the code :-p
> > > > >
> > > > >
> > > > > On Tue, Apr 5, 2016 at 6:50 PM Simon MacDonald <
> > > > 

Excited to join the group

[Jason Wang (DEVDIV)]

Hi all,

My name is Jason. I am a developer at Microsoft working on Visual Studio Tools 
for Apache Cordova.
I have submitted my ICLA form and am looking forward to contributing to Cordova.

Best,
Jason

[GitHub] cordova-plugin-inappbrowser pull request #152: Should the README designate w...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/152


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #188: Fix issues where MSBuild cannot be found due to ...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-windows/pull/188
  
## [Current coverage][cc-pull] is 73.05% (diff: 100%)
> Merging [#188][cc-pull] into [master][cc-base-branch] will increase 
coverage by **0.47%**

```diff
@@ master   #188   diff @@
==
  Files14 14  
  Lines  1929   1937 +8   
  Methods 359360 +1   
  Messages  0  0  
  Branches387390 +3   
==
+ Hits   1400   1415+15   
+ Misses  529522 -7   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[58080c4...2eba4e2][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-windows/compare/58080c4c48f6496dc21fa7b9ae85c189f8eeb1d9...2eba4e221c530d3682109e0856353926e564c78b?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/188?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #188: Fix issues where MSBuild cannot be found ...

[jicongw]

GitHub user jicongw opened a pull request:

https://github.com/apache/cordova-windows/pull/188

Fix issues where MSBuild cannot be found due to VS installation chang…

…e. Let Cordova Windows look for MSBuild under VSINSTALLDIR process 
environment variable. Also, make Cordova Windows more resilient to MSBuild 
version change. This commit contains work by Vladimir and Jason. Code is 
reviewed by Vladimir and Tim Barham. Commits are squashed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jicongw/cordova-windows CB-11548

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/188.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #188


commit b765a6adb40040a6fe3549b6fc8618233fe3e16d
Author: Jason Wang (DEVDIV) 
Date:   2016-07-21T20:47:49Z

Fix issues where MSBuild cannot be found due to VS installation change. Let 
Cordova Windows look for MSBuild under VSINSTALLDIR process environment 
variable. Also, make Cordova Windows more resilient to MSBuild version change. 
This commit contains work by Vladimir and Jason. Code is reviewed by Vladimir 
and Tim Barham. Commits are squashed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[ANNOUNCE] Cordova 6.3.0 released

[Vladimir Kotikov (Akvelon)]

Blog post: http://cordova.apache.org/news/2016/07/13/tools-release.html
Tweet: https://twitter.com/apachecordova/status/756222009495859200

-
Best regards, Vladimir

[GitHub] cordova-plugin-splashscreen issue #104: CB-11326 Prevent crash when initiali...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/104
  
Thanks, @jcesarmobile 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #104: CB-11326 Prevent crash when i...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/104


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #170: CB-11578 fix some calls which...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/170


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #170: CB-11578 fix some calls which used a...

[jcesarmobile]

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/170
  
As it's a small fix I'm going to merge it without the ICLA, but you should 
consider filling the Apache's Contributor License Agreement 
http://www.apache.org/licenses/#clas for future contributions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #104: CB-11326 Prevent crash when initiali...

[jcesarmobile]

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/104
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #106: CB-7497: (iOS) Fix bug with applicat...

[jcesarmobile]

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/106
  
Hi.
Thanks for your Pull Request.

I've just merged 
https://github.com/apache/cordova-plugin-splashscreen/pull/110/ that solves 
this problem in a similar way. 
Can you close this issue?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #110: Fix crash on iOS when reloadi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/110


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #110: Fix crash on iOS when reloading page...

[jcesarmobile]

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/110
  
Thanks for the PR, it looks good and as it's a small fix I'm going to merge 
it.

But you should consider filling the Apache's Contributor License Agreement 
http://www.apache.org/licenses/#clas for future contributions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #105: Fix app halt when an audio ends w/ another ...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/105
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media/pull/105/commits/aaf937dda8f372433f2b319f3fe1375fa4fed2e1)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/53//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #621: CB-11569 Add tools release blog post

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #110: Fix crash on iOS when reloading page...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/110
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-splashscreen/pull/110/commits/16eceaa170aae27c992728337bee3090ebed0e0d)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/22//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #105: Fix app halt when an audio ends w/ a...

[liruqi]

GitHub user liruqi opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/105

Fix app halt when an audio ends w/ another playing

### Platforms affected
iOS 9

### What does this PR do?
Fix app halt when an audio ends with another playing

### What testing has been done on this change?
My T-Rex runner for iOS based on 
https://github.com/riccardo-forina/chromium-dyno-crossbrowser

### Checklist
- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liruqi/cordova-plugin-media master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #105






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Platforms and tools releases

[Steven Gill]

Added!

On Thu, Jul 21, 2016 at 2:30 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:

> It seems that I can't do that :( I don't have rights to publish
> cordova-fetch.
> Asked Steve to give me an access
>
> -
> Best regards, Vladimir
>
> -Original Message-
> From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> Sent: Wednesday, July 20, 2016 11:36 PM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] Platforms and tools releases
>
> Sorry for delay, Jesse. I will publish it tomorrow morning.
> Also could you please take a look at the blog post here:
> https://github.com/apache/cordova-docs/pull/621
>
> -
> Best regards, Vladimir
>
> -Original Message-
> From: Jesse [mailto:purplecabb...@gmail.com]
> Sent: Wednesday, July 20, 2016 10:29 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Platforms and tools releases
>
> Where are we with the tools release?
> CB-11023 has landed in cordova-lib master but has not been released yet.
>
> It would be great to get this out.
>
>
>
> @purplecabbage
> risingj.com
>
> On Mon, Jul 11, 2016 at 5:27 PM, Steven Gill 
> wrote:
>
> > LGTM.
> >
> > Published the android 5.2.0 blog post. I published cordova-android
> > 5.2.0 on npm and dist before I left for the week off.
> >
> > For tools, I'd say include those two changes and make it a minor
> > instead of patch release.
> >
> > -Steve
> >
> >
> >
> > On Mon, Jul 11, 2016 at 9:00 AM, Vladimir Kotikov (Akvelon) <
> > v-vlk...@microsoft.com> wrote:
> >
> > > Please review blog post for Android:
> > > https://github.com/apache/cordova-docs/pull/619
> > > Also I noticed that we still didn't announce Android 5.2.0 - the PR
> > > is
> > not
> > > yet merged: https://github.com/apache/cordova-docs/pull/617
> > >
> > > -
> > > Best regards, Vladimir
> > >
> > > -Original Message-
> > > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> > > Sent: Monday, July 11, 2016 3:52 PM
> > > To: dev@cordova.apache.org
> > > Subject: RE: [DISCUSS] Platforms and tools releases
> > >
> > > Nope. I didn't include this into the list of patches to release
> > > because I was thinking of a patch release that will not include new
> features.
> > However
> > > we could do a minor release instead, as we have 2 features live in
> > master:
> > > 'edit-config' and improved 'template' functionality.
> > >
> > > Thoughts?
> > >
> > > -
> > > Best regards, Vladimir
> > >
> > > -Original Message-
> > > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> > > Sent: Monday, July 11, 2016 3:35 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [DISCUSS] Platforms and tools releases
> > >
> > > Has CB-11023 - plugin.xml should be able to add attribute to an
> > > existing element in AndroidManifest.xml been merged into a release?
> > > Apologies if I missed it.
> > >
> > > Simon Mac Donald
> > >
> > >
> > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%
> > 2fsimonmacdonald=01%7c01%7cv-vlkoti%40microsoft.com%7c0582012e3bc
> > e4d42b79708d3a987e9e9%7c72f988bf86f141af91ab2d7cd011db47%7c1=8XH
> > Sb45049MNOgI6fkOwPA0CUge0X8kV0jXlkl%2bAdIE%3d
> > >
> > > On Mon, Jul 11, 2016 at 12:00 AM, Steven Gill
> > > 
> > > wrote:
> > >
> > > > Do it!
> > > >
> > > > On Fri, Jul 8, 2016 at 7:07 AM, Vladimir Kotikov (Akvelon) <
> > > > v-vlk...@microsoft.com> wrote:
> > > >
> > > > > Hi guys,
> > > > >
> > > > > Next week I'd like to do a tools release (cordova-cli and
> > > > > cordova-lib) to update pinned versions of platforms and to get
> > > > > patch releases for 2 of 3 main platforms - Android (5.2.1) and
> > > > > Windows
> > > (4.4.1).
> > > > >
> > > > > Here is the list of platforms' patches we're interested in:
> > > > > Android:
> > > > >   - CB-9489 Fixed "endless waiting for emulator" issue
> > > > > Windows:
> > > > >   - CB-11548 windows: Respect user-specified msbuild location
> > > > >   - CB-11516 windows: Preparing icons w/ target fails
> > > > >   - CB-11470 App crashes when trying to open from another app
> > > > > using
> > > > Custom
> > > > > URL
> > > > >   - CB-11443 Splashscreen is created the second time on resume
> > > > > on Windows
> > > > >
> > > > > For tools if we're going to do a patch release here is also the
> > > > > list of important changes to include:
> > > > > Cordova-cli:
> > > > >   - CB-11284 Telemetry: Track platforms/plugins
> > > > subcommands(add/rm/etc...)
> > > > >   - CB-11263: 'cordova telemetry help' should display help text
> > > > > Cordova-lib:
> > > > >   - CB-11412 template support for www folders
> > > > >   - Fix config.xml path in PlatformApi.prepare
> > > > >   - CB-11412 improve template implementation
> > > > >   - CB-11164 Allow forced dependent plugin removal
> > > > >   - CB-11349 added --fetch and cordova fetch to create --template
> > > > >   - CB-11274 Platform browser: wrong path for config.xml
> > > > >   - CB-11274 Make serve dashboard 

[GitHub] cordova-plugin-splashscreen pull request #110: Fix crash on iOS when reloadi...

[bugnano]

GitHub user bugnano opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/110

Fix crash on iOS when reloading page from remote Safari



### Platforms affected
iOS

### What does this PR do?
Fix a crash when calling navigator.splashscreen.hide() after reloading the 
page from a remote Safari

### What testing has been done on this change?
- Create an application with AutoHideSplashScreen set to false
- Call navigator.splashscreen.hide() from the application
- Connect Safari from a Mac to debug the application
- Hit the reload button from Safari
- Without this patch, the application crashes
- With this patch, the page is reloaded without any problem

### Checklist
- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bugnano/cordova-plugin-splashscreen master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #110


commit 16eceaa170aae27c992728337bee3090ebed0e0d
Author: Franco Bugnano 
Date:   2016-07-21T15:14:42Z

Fix crash on iOS when reloading page from remote Safari




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #187: CB-11241 Return adding BOM to www back to...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/187


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Platforms and tools releases

[Vladimir Kotikov (Akvelon)]

It seems that I can't do that :( I don't have rights to publish cordova-fetch.
Asked Steve to give me an access

-
Best regards, Vladimir

-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] 
Sent: Wednesday, July 20, 2016 11:36 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Platforms and tools releases

Sorry for delay, Jesse. I will publish it tomorrow morning.
Also could you please take a look at the blog post here: 
https://github.com/apache/cordova-docs/pull/621 

-
Best regards, Vladimir

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Wednesday, July 20, 2016 10:29 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Platforms and tools releases

Where are we with the tools release?
CB-11023 has landed in cordova-lib master but has not been released yet.

It would be great to get this out.



@purplecabbage
risingj.com

On Mon, Jul 11, 2016 at 5:27 PM, Steven Gill  wrote:

> LGTM.
>
> Published the android 5.2.0 blog post. I published cordova-android
> 5.2.0 on npm and dist before I left for the week off.
>
> For tools, I'd say include those two changes and make it a minor 
> instead of patch release.
>
> -Steve
>
>
>
> On Mon, Jul 11, 2016 at 9:00 AM, Vladimir Kotikov (Akvelon) < 
> v-vlk...@microsoft.com> wrote:
>
> > Please review blog post for Android:
> > https://github.com/apache/cordova-docs/pull/619
> > Also I noticed that we still didn't announce Android 5.2.0 - the PR 
> > is
> not
> > yet merged: https://github.com/apache/cordova-docs/pull/617
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> > Sent: Monday, July 11, 2016 3:52 PM
> > To: dev@cordova.apache.org
> > Subject: RE: [DISCUSS] Platforms and tools releases
> >
> > Nope. I didn't include this into the list of patches to release 
> > because I was thinking of a patch release that will not include new 
> > features.
> However
> > we could do a minor release instead, as we have 2 features live in
> master:
> > 'edit-config' and improved 'template' functionality.
> >
> > Thoughts?
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> > Sent: Monday, July 11, 2016 3:35 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Platforms and tools releases
> >
> > Has CB-11023 - plugin.xml should be able to add attribute to an 
> > existing element in AndroidManifest.xml been merged into a release?
> > Apologies if I missed it.
> >
> > Simon Mac Donald
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%
> 2fsimonmacdonald=01%7c01%7cv-vlkoti%40microsoft.com%7c0582012e3bc
> e4d42b79708d3a987e9e9%7c72f988bf86f141af91ab2d7cd011db47%7c1=8XH
> Sb45049MNOgI6fkOwPA0CUge0X8kV0jXlkl%2bAdIE%3d
> >
> > On Mon, Jul 11, 2016 at 12:00 AM, Steven Gill 
> > 
> > wrote:
> >
> > > Do it!
> > >
> > > On Fri, Jul 8, 2016 at 7:07 AM, Vladimir Kotikov (Akvelon) < 
> > > v-vlk...@microsoft.com> wrote:
> > >
> > > > Hi guys,
> > > >
> > > > Next week I'd like to do a tools release (cordova-cli and
> > > > cordova-lib) to update pinned versions of platforms and to get 
> > > > patch releases for 2 of 3 main platforms - Android (5.2.1) and 
> > > > Windows
> > (4.4.1).
> > > >
> > > > Here is the list of platforms' patches we're interested in:
> > > > Android:
> > > >   - CB-9489 Fixed "endless waiting for emulator" issue
> > > > Windows:
> > > >   - CB-11548 windows: Respect user-specified msbuild location
> > > >   - CB-11516 windows: Preparing icons w/ target fails
> > > >   - CB-11470 App crashes when trying to open from another app 
> > > > using
> > > Custom
> > > > URL
> > > >   - CB-11443 Splashscreen is created the second time on resume 
> > > > on Windows
> > > >
> > > > For tools if we're going to do a patch release here is also the 
> > > > list of important changes to include:
> > > > Cordova-cli:
> > > >   - CB-11284 Telemetry: Track platforms/plugins
> > > subcommands(add/rm/etc...)
> > > >   - CB-11263: 'cordova telemetry help' should display help text
> > > > Cordova-lib:
> > > >   - CB-11412 template support for www folders
> > > >   - Fix config.xml path in PlatformApi.prepare
> > > >   - CB-11412 improve template implementation
> > > >   - CB-11164 Allow forced dependent plugin removal
> > > >   - CB-11349 added --fetch and cordova fetch to create --template
> > > >   - CB-11274 Platform browser: wrong path for config.xml
> > > >   - CB-11274 Make serve dashboard take config.xml -> content.src 
> > > > entry point into account
> > > >   - CB-11261 Cut out '-nightly' prerelease tag when checking 
> > > > plugin
> > > engines
> > > >
> > > > Does anyone have any reason to delay a these releases? Any other 
> > > > patches to land?
> > > > If not, I will start the release Monday next week.
> > > >
> > > > -
> > > > Best 

[GitHub] cordova-android issue #318: Android Keyboard

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-android/pull/318
  
@jedofus, this is not the best place to report issues. Try to search for an 
existing issue in project's JIRA or file a new one as described 
[here](http://cordova.apache.org/contribute/issues.html). Also you can ask your 
questions on [Slack](http://slack.cordova.io/)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [Vote] Tools Release

[Vladimir Kotikov (Akvelon)]

The vote has now closed. The results are:

Positive Binding Votes: 3

Vladimir Kotikov
Alexander Sorokin
Sergey Grebnov

Negative Binding Votes: 0

The vote has passed.

-
Best regards, Vladimir

-Original Message-
From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] 
Sent: Monday, July 18, 2016 5:34 PM
To: dev@cordova.apache.org
Subject: RE: [Vote] Tools Release

I vote +1

* Reviewed Release notes
* Verified ability to create blank app
* Verified ability to add, build and run iOS, Android and Windows

Thanks,
Sergey

-Original Message-
From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] 
Sent: Wednesday, July 13, 2016 7:27 PM
To: dev@cordova.apache.org
Subject: RE: [Vote] Tools Release

I vote +1.

* Verified tags
* Ability to install/uninstall Cordova
* Ability to update Cordova
* Ability to create blank app for Windows, Android
* Ability to build/run apps
* Reviewed release notes
* Verified versions
* Verified line breaks
* Verified 'cordova serve'
* Verified that browserified app builds and runs correctly

Thanks,
Alexander Sorokin

-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] 
Sent: Wednesday, July 13, 2016 7:10 PM
To: dev@cordova.apache.org
Subject: [Vote] Tools Release

Please review and vote on this Tools Release by replying to this email (and 
keep discussion on the DISCUSS thread)

Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-11569=01%7c01%7cv-alsoro%40microsoft.com%7c64d48c9385cc4835adde08d3ab3828a3%7c72f988bf86f141af91ab2d7cd011db47%7c1=aZkrPsikAdidLiM0OWcVeQ1iDf9UJx8mdOy1H5TlDWg%3d
 

Both tools have been published to dist/dev:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-11569=01%7c01%7cv-alsoro%40microsoft.com%7c64d48c9385cc4835adde08d3ab3828a3%7c72f988bf86f141af91ab2d7cd011db47%7c1=6gbx1%2fdmGPMPj3AX6%2fZKbK6YsS32Cm0sj%2fJVG6qt3mg%3d
 

The packages were published from their corresponding git tags:
cordova-lib: 6.3.0 (09ab5bbc73)
cordova-cli: 6.3.0 (d316576e1f)
cordova-lib: fetch-1.0.1 (09ab5bbc73)
cordova-lib: common-1.4.0 (09ab5bbc73)

Upon a successful vote I will upload the archives to dist/, publish them to 
npm, and post the corresponding blog post.

Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ensured continuous build was green when repos were tagged
* Created and build mobilespec app
* Ran mobilespec tests to ensure there are no regressions
* Ran unit tests for all relevant repos

-
Best regards, Vladimir

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #318: Android Keyboard

[jedofus]

GitHub user jedofus opened a pull request:

https://github.com/apache/cordova-android/pull/318

Android Keyboard

Hello , i have a problem on my Android app , 
when i have input field in my content and i click on my input field , 
the Android keyboard cover my input field, and I do not see what I write.
How can i resolved it ? 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cordova-android 5.2.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/318.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #318


commit fd1d3006c0f656091e6c45068f8653775eaa65d7
Author: Steve Gill 
Date:   2016-06-29T19:39:42Z

CB-11444 Updated RELEASENOTES and Version for release 5.2.0

commit b32b8c89c6061ffe86161f4ab641cbab605a7aba
Author: Steve Gill 
Date:   2016-06-29T19:51:05Z

Update JS snapshot to version 5.2.0 (via coho)

commit 97ce7dd417ea0e5baf0348d8a267ef3d723bb1a8
Author: Steve Gill 
Date:   2016-06-29T19:51:05Z

Set VERSION to 5.2.0 (via coho)

commit 8416c4e5e9908aeee1445a107bb89decd69954b3
Author: Vivek Kiran 
Date:   2016-06-24T05:08:23Z

CB-11481: android-library is deprecated use com.android.library instead

commit 40d3cdc0d646364c2d118758049f73b78503c68f
Author: Alexander Sorokin 
Date:   2016-07-06T12:12:36Z

CB-9489 Fixed "endless waiting for emulator" issue

commit 89a00c02a40cae162708fd20e93c958ecaa3dbf9
Author: Vladimir Kotikov 
Date:   2016-07-11T10:41:00Z

CB-11550 Updated and checked-in node_modules

commit 81b2bccd977b4237ad2ac10c5e89c9051969b311
Author: Vladimir Kotikov 
Date:   2016-07-11T10:41:30Z

CB-11550 Update JS snapshot to version 5.2.1 (via coho)

commit cbed234069080331084689bfff3354d3b26dbf32
Author: Vladimir Kotikov 
Date:   2016-07-11T10:41:31Z

CB-11550 Set VERSION to 5.2.1 (via coho)

commit 35dfdece12aa0791a081c33af75dbc3f8d4b0c76
Author: Vladimir Kotikov 
Date:   2016-07-11T10:43:38Z

CB-11550 Updated RELEASENOTES for release 5.2.1




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org