[GitHub] cordova-plugin-contacts pull request #134: CB-11855: (ios) Allow iOS to use ...
Github user soonahn closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request #134: CB-11855: (ios) Allow iOS to use ...
GitHub user soonahn opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/134 CB-11855: (ios) Allow iOS to use hasPhoneNumber ### Platforms affected iOS ### What does this PR do? Fixes https://issues.apache.org/jira/browse/CB-11855 ### What testing has been done on this change? Tested on iOS 9.3 - iPhone 6. As well as iOS Simulator of iPhone 6S ### Checklist - [ Yes ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [ Yes ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ Yes ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ No ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/soonahn/cordova-plugin-contacts allow_ios_to_filter_for_phone_number_only Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/134.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #134 commit 85b52d354caeb41ed79269cc9dce690ef41917c8 Author: Justin Ahn Date: 2016-09-15T06:39:33Z Capturing the default like the multiple option, and then continuing through the array if there are no phone numbers for the user --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Nightly build #146 for cordova has succeeded!
Nightly build #146 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/146/consoleFull - Jenkins for Apache Cordova - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[ANNOUNCE] Plugins release!
Tweet: https://twitter.com/apachecordova/status/776224554108620800 Blog: http://cordova.apache.org/news/2016/09/14/plugins-release.html
[GitHub] cordova-plugin-wkwebview-engine issue #17: [CB-11818] Avoid retain cycle cau...
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 Do you know if this was fixed in iOS 10? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #635: CB-11851 - Docs for developmentTeam key in b...
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/635 CB-11851 - Docs for developmentTeam key in build.json You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-docs CB-11851 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/635.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #635 commit ed7c943daafabe2d95bc955023417b10b7663d23 Author: Shazron Abdullah Date: 2016-09-15T00:53:47Z CB-11851 - Docs for developmentTeam key in build.json --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #138: Added script to pull changes from RELEASENOT...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #138: Added script to pull changes from RELEASENOT...
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/138 Added script to pull changes from RELEASENOTES.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-58 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/138.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #138 commit ca28bb57bd0494a978dc8b052ad419cc653d4c56 Author: Steve Gill Date: 2016-09-14T23:28:14Z Added script to pull changes from RELEASENOTES.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DRAFT] Apache Cordova Board Report for Sept 2016
Great. Not quite EOD, but close enough! Filing it now. On Wed, Sep 14, 2016 at 7:14 AM, Kerri Shotts wrote: > LGTM > > Sent from my iPad > > > On Sep 13, 2016, at 19:09, Shazron wrote: > > > > Please review, comment on it, etc: > > https://github.com/cordova/apache-board-reports/blob/ > master/2016/2016-09.md >
[GitHub] cordova-coho pull request #137: Added steps to vote on a plugins release
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #137: Added steps to vote on a plugins release
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/137 Added steps to vote on a plugins release You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-57 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/137.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #137 commit 31ea5d0d3f2d06e75afd826e65a087de47e48953 Author: Steve Gill Date: 2016-09-14T18:35:08Z Added steps to vote on a plugins release --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Discuss] plugins release
We're good to go On Wed, Sep 14, 2016 at 11:31 AM, julio cesar sanchez < jcesarmob...@gmail.com> wrote: > I don't think we fixed all the plugins for iOS 10, only contacts, camera > and media-capture, but probably others might crash > Do you still need a vote or 3 are enough? > > 2016-09-14 20:13 GMT+02:00 Steven Gill : > > > Need one more! It is important to get these out asap. Getting contacted > > about certain plugins not working on ios10 already! > > > > > > > > On Tue, Sep 13, 2016 at 3:30 PM, Steven Gill > > wrote: > > > > > Bump! Please vote on the release > > > > > > On Thu, Sep 8, 2016 at 9:06 AM, Steven Gill > > > wrote: > > > > > >> I can review and merge > > >> > > >> On Sep 8, 2016 9:00 AM, "David Barth" > > wrote: > > >> > > >>> Hey guys, > > >>> > > >>> Alex has a set of fixes for ubuntu code in the following plugins: > > >>> > > >>>- https://github.com/apache/cordova-plugin-inappbrowser/pull/174 > > >>>- https://github.com/apache/cordova-plugin-battery-status/pull/38 > > >>>- https://github.com/cordova-ubuntu/cordova-plugin- > > geolocation/pull/2 > > >>> > > >>> Should we get another review from plugin maintainers or should i > merge > > to > > >>> get that in time for the release ? > > >>> > > >>> David > > >>> > > >>> > > >>> > > >>> On Wed, Sep 7, 2016 at 4:47 PM, julio cesar sanchez < > > >>> jcesarmob...@gmail.com> > > >>> wrote: > > >>> > > >>> > Or maybe we should wait for the corodvaDependencies update? I think > > >>> there > > >>> > are PRs for all the plugins > > >>> > > > >>> > 2016-09-07 16:21 GMT+02:00 Steven Gill : > > >>> > > > >>> > > Yes. I'll move forward with it > > >>> > > > > >>> > > On Sep 7, 2016 6:25 AM, "julio cesar sanchez" < > > >>> jcesarmob...@gmail.com> > > >>> > > wrote: > > >>> > > > > >>> > > > Issues won't stop coming, should we do the release this week? > > >>> > > > > > >>> > > > 2016-08-29 13:26 GMT+02:00 Kerri Shotts >: > > >>> > > > > > >>> > > > > I've got iPads that support multitasking, so I'll take a > look. > > >>> > > > > > > >>> > > > > ~ Kerri > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > On Mon, Aug 29, 2016 at 5:57 AM -0500, "julio cesar sanchez" > < > > >>> > > > > jcesarmob...@gmail.com> wrote: > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > If somebody with an iPad that supports multitasking can test > > this > > >>> > PR... > > >>> > > > > https://github.com/apache/cordova-plugin-statusbar/pull/62 > > >>> > > > > > > >>> > > > > I have reviewed the code and looks good, bud I don't have an > > iPad > > >>> > that > > >>> > > > > supports multitasking to test it, and I don't trust the > > >>> simulator in > > >>> > > this > > >>> > > > > case as I tried to fix that issue in a different way, got it > > >>> working > > >>> > on > > >>> > > > the > > >>> > > > > simulator but the reporter said that it didn't work as > expected > > >>> on a > > >>> > > real > > >>> > > > > device. > > >>> > > > > > > >>> > > > > 2016-08-25 0:54 GMT+02:00 julio cesar sanchez : > > >>> > > > > > > >>> > > > > > PRs to review > > >>> > > > > > https://github.com/apache/cordova-plugin-contacts/pull/131 > > >>> > > > > > https://github.com/apache/cordova-plugin-camera/pull/229 > > >>> > > > > > > > >>> > > > > > 2016-08-24 20:20 GMT+02:00 Steven Gill : > > >>> > > > > > > > >>> > > > > >> Hey Scott, > > >>> > > > > >> > > >>> > > > > >> Thanks for pointing out the PR. I'll take a look. > > >>> > > > > >> > > >>> > > > > >> The reality of the situation is that cordova has many > repos > > >>> and > > >>> > not > > >>> > > > > enough > > >>> > > > > >> committers currently. This leads to PRs sitting > unreviewed. > > >>> Plugin > > >>> > > PRs > > >>> > > > > are > > >>> > > > > >> unique in that they can involve various different native > > >>> language > > >>> > > > > changes. > > >>> > > > > >> This could require more than 1 committer needing to > review. > > >>> For > > >>> > > > example, > > >>> > > > > >> some committers are more experienced with android vs ios, > so > > >>> they > > >>> > > > won't > > >>> > > > > be > > >>> > > > > >> able to review the ios portion of the plugin PR. Another > > issue > > >>> > with > > >>> > > > > plugin > > >>> > > > > >> PRs is that they may try to add a new feature (without > > >>> discussion) > > >>> > > and > > >>> > > > > may > > >>> > > > > >> not add similar functionality for other platforms that > > >>> support the > > >>> > > > > plugin. > > >>> > > > > >> And of course lots of PRs don't include tests. > > >>> > > > > >> > > >>> > > > > >> The name being attached to component doesn't mean > anything. > > >>> Issues > > >>> > > by > > >>> > > > > >> default go unassigned. > > >>> > > > > >> > > >>> > > > > >> I can only speak on behalf of the regular Adobe cordova > > >>> commiters > > >>> > (4 > > >>> > > > of > > >>> > > > > >> us). Our focus is usually
Re: [Discuss] plugins release
3 are good! I'll publish shortly On Wed, Sep 14, 2016 at 11:31 AM, julio cesar sanchez < jcesarmob...@gmail.com> wrote: > I don't think we fixed all the plugins for iOS 10, only contacts, camera > and media-capture, but probably others might crash > Do you still need a vote or 3 are enough? > > 2016-09-14 20:13 GMT+02:00 Steven Gill : > > > Need one more! It is important to get these out asap. Getting contacted > > about certain plugins not working on ios10 already! > > > > > > > > On Tue, Sep 13, 2016 at 3:30 PM, Steven Gill > > wrote: > > > > > Bump! Please vote on the release > > > > > > On Thu, Sep 8, 2016 at 9:06 AM, Steven Gill > > > wrote: > > > > > >> I can review and merge > > >> > > >> On Sep 8, 2016 9:00 AM, "David Barth" > > wrote: > > >> > > >>> Hey guys, > > >>> > > >>> Alex has a set of fixes for ubuntu code in the following plugins: > > >>> > > >>>- https://github.com/apache/cordova-plugin-inappbrowser/pull/174 > > >>>- https://github.com/apache/cordova-plugin-battery-status/pull/38 > > >>>- https://github.com/cordova-ubuntu/cordova-plugin- > > geolocation/pull/2 > > >>> > > >>> Should we get another review from plugin maintainers or should i > merge > > to > > >>> get that in time for the release ? > > >>> > > >>> David > > >>> > > >>> > > >>> > > >>> On Wed, Sep 7, 2016 at 4:47 PM, julio cesar sanchez < > > >>> jcesarmob...@gmail.com> > > >>> wrote: > > >>> > > >>> > Or maybe we should wait for the corodvaDependencies update? I think > > >>> there > > >>> > are PRs for all the plugins > > >>> > > > >>> > 2016-09-07 16:21 GMT+02:00 Steven Gill : > > >>> > > > >>> > > Yes. I'll move forward with it > > >>> > > > > >>> > > On Sep 7, 2016 6:25 AM, "julio cesar sanchez" < > > >>> jcesarmob...@gmail.com> > > >>> > > wrote: > > >>> > > > > >>> > > > Issues won't stop coming, should we do the release this week? > > >>> > > > > > >>> > > > 2016-08-29 13:26 GMT+02:00 Kerri Shotts >: > > >>> > > > > > >>> > > > > I've got iPads that support multitasking, so I'll take a > look. > > >>> > > > > > > >>> > > > > ~ Kerri > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > On Mon, Aug 29, 2016 at 5:57 AM -0500, "julio cesar sanchez" > < > > >>> > > > > jcesarmob...@gmail.com> wrote: > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > If somebody with an iPad that supports multitasking can test > > this > > >>> > PR... > > >>> > > > > https://github.com/apache/cordova-plugin-statusbar/pull/62 > > >>> > > > > > > >>> > > > > I have reviewed the code and looks good, bud I don't have an > > iPad > > >>> > that > > >>> > > > > supports multitasking to test it, and I don't trust the > > >>> simulator in > > >>> > > this > > >>> > > > > case as I tried to fix that issue in a different way, got it > > >>> working > > >>> > on > > >>> > > > the > > >>> > > > > simulator but the reporter said that it didn't work as > expected > > >>> on a > > >>> > > real > > >>> > > > > device. > > >>> > > > > > > >>> > > > > 2016-08-25 0:54 GMT+02:00 julio cesar sanchez : > > >>> > > > > > > >>> > > > > > PRs to review > > >>> > > > > > https://github.com/apache/cordova-plugin-contacts/pull/131 > > >>> > > > > > https://github.com/apache/cordova-plugin-camera/pull/229 > > >>> > > > > > > > >>> > > > > > 2016-08-24 20:20 GMT+02:00 Steven Gill : > > >>> > > > > > > > >>> > > > > >> Hey Scott, > > >>> > > > > >> > > >>> > > > > >> Thanks for pointing out the PR. I'll take a look. > > >>> > > > > >> > > >>> > > > > >> The reality of the situation is that cordova has many > repos > > >>> and > > >>> > not > > >>> > > > > enough > > >>> > > > > >> committers currently. This leads to PRs sitting > unreviewed. > > >>> Plugin > > >>> > > PRs > > >>> > > > > are > > >>> > > > > >> unique in that they can involve various different native > > >>> language > > >>> > > > > changes. > > >>> > > > > >> This could require more than 1 committer needing to > review. > > >>> For > > >>> > > > example, > > >>> > > > > >> some committers are more experienced with android vs ios, > so > > >>> they > > >>> > > > won't > > >>> > > > > be > > >>> > > > > >> able to review the ios portion of the plugin PR. Another > > issue > > >>> > with > > >>> > > > > plugin > > >>> > > > > >> PRs is that they may try to add a new feature (without > > >>> discussion) > > >>> > > and > > >>> > > > > may > > >>> > > > > >> not add similar functionality for other platforms that > > >>> support the > > >>> > > > > plugin. > > >>> > > > > >> And of course lots of PRs don't include tests. > > >>> > > > > >> > > >>> > > > > >> The name being attached to component doesn't mean > anything. > > >>> Issues > > >>> > > by > > >>> > > > > >> default go unassigned. > > >>> > > > > >> > > >>> > > > > >> I can only speak on behalf of the regular Adobe cordova > > >>> commiters > > >>> > (4 > > >>> > > > of > > >>> > > > > >> us). Our
Re: [Discuss] plugins release
I don't think we fixed all the plugins for iOS 10, only contacts, camera and media-capture, but probably others might crash Do you still need a vote or 3 are enough? 2016-09-14 20:13 GMT+02:00 Steven Gill : > Need one more! It is important to get these out asap. Getting contacted > about certain plugins not working on ios10 already! > > > > On Tue, Sep 13, 2016 at 3:30 PM, Steven Gill > wrote: > > > Bump! Please vote on the release > > > > On Thu, Sep 8, 2016 at 9:06 AM, Steven Gill > > wrote: > > > >> I can review and merge > >> > >> On Sep 8, 2016 9:00 AM, "David Barth" > wrote: > >> > >>> Hey guys, > >>> > >>> Alex has a set of fixes for ubuntu code in the following plugins: > >>> > >>>- https://github.com/apache/cordova-plugin-inappbrowser/pull/174 > >>>- https://github.com/apache/cordova-plugin-battery-status/pull/38 > >>>- https://github.com/cordova-ubuntu/cordova-plugin- > geolocation/pull/2 > >>> > >>> Should we get another review from plugin maintainers or should i merge > to > >>> get that in time for the release ? > >>> > >>> David > >>> > >>> > >>> > >>> On Wed, Sep 7, 2016 at 4:47 PM, julio cesar sanchez < > >>> jcesarmob...@gmail.com> > >>> wrote: > >>> > >>> > Or maybe we should wait for the corodvaDependencies update? I think > >>> there > >>> > are PRs for all the plugins > >>> > > >>> > 2016-09-07 16:21 GMT+02:00 Steven Gill : > >>> > > >>> > > Yes. I'll move forward with it > >>> > > > >>> > > On Sep 7, 2016 6:25 AM, "julio cesar sanchez" < > >>> jcesarmob...@gmail.com> > >>> > > wrote: > >>> > > > >>> > > > Issues won't stop coming, should we do the release this week? > >>> > > > > >>> > > > 2016-08-29 13:26 GMT+02:00 Kerri Shotts : > >>> > > > > >>> > > > > I've got iPads that support multitasking, so I'll take a look. > >>> > > > > > >>> > > > > ~ Kerri > >>> > > > > > >>> > > > > > >>> > > > > > >>> > > > > On Mon, Aug 29, 2016 at 5:57 AM -0500, "julio cesar sanchez" < > >>> > > > > jcesarmob...@gmail.com> wrote: > >>> > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>> > > > > If somebody with an iPad that supports multitasking can test > this > >>> > PR... > >>> > > > > https://github.com/apache/cordova-plugin-statusbar/pull/62 > >>> > > > > > >>> > > > > I have reviewed the code and looks good, bud I don't have an > iPad > >>> > that > >>> > > > > supports multitasking to test it, and I don't trust the > >>> simulator in > >>> > > this > >>> > > > > case as I tried to fix that issue in a different way, got it > >>> working > >>> > on > >>> > > > the > >>> > > > > simulator but the reporter said that it didn't work as expected > >>> on a > >>> > > real > >>> > > > > device. > >>> > > > > > >>> > > > > 2016-08-25 0:54 GMT+02:00 julio cesar sanchez : > >>> > > > > > >>> > > > > > PRs to review > >>> > > > > > https://github.com/apache/cordova-plugin-contacts/pull/131 > >>> > > > > > https://github.com/apache/cordova-plugin-camera/pull/229 > >>> > > > > > > >>> > > > > > 2016-08-24 20:20 GMT+02:00 Steven Gill : > >>> > > > > > > >>> > > > > >> Hey Scott, > >>> > > > > >> > >>> > > > > >> Thanks for pointing out the PR. I'll take a look. > >>> > > > > >> > >>> > > > > >> The reality of the situation is that cordova has many repos > >>> and > >>> > not > >>> > > > > enough > >>> > > > > >> committers currently. This leads to PRs sitting unreviewed. > >>> Plugin > >>> > > PRs > >>> > > > > are > >>> > > > > >> unique in that they can involve various different native > >>> language > >>> > > > > changes. > >>> > > > > >> This could require more than 1 committer needing to review. > >>> For > >>> > > > example, > >>> > > > > >> some committers are more experienced with android vs ios, so > >>> they > >>> > > > won't > >>> > > > > be > >>> > > > > >> able to review the ios portion of the plugin PR. Another > issue > >>> > with > >>> > > > > plugin > >>> > > > > >> PRs is that they may try to add a new feature (without > >>> discussion) > >>> > > and > >>> > > > > may > >>> > > > > >> not add similar functionality for other platforms that > >>> support the > >>> > > > > plugin. > >>> > > > > >> And of course lots of PRs don't include tests. > >>> > > > > >> > >>> > > > > >> The name being attached to component doesn't mean anything. > >>> Issues > >>> > > by > >>> > > > > >> default go unassigned. > >>> > > > > >> > >>> > > > > >> I can only speak on behalf of the regular Adobe cordova > >>> commiters > >>> > (4 > >>> > > > of > >>> > > > > >> us). Our focus is usually spent on platforms + tools fixes > and > >>> > > > > >> improvements. > >>> > > > > >> > >>> > > > > >> The best way to get attention for your PR is to post it to > >>> slack + > >>> > > > > here. I > >>> > > > > >> usually do a review of PRs when I do a plugins release, but > I > >>> > won't > >>> > > be > >>> > > > > >> able > >>> > > > > >> to go through them all. This is why I ask for people to > bring > >>> some > >>>
Re: [VOTE] Plugins Release
+1 * Ran coho audit-license-headers over the relevant repos (all ok) * Ran coho verify-archive on all the archives (all verified) @purplecabbage risingj.com On Wed, Sep 14, 2016 at 11:07 AM, Shazron wrote: > I vote +1: > * Ran coho audit-license-headers over the relevant repos (all ok) > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ran coho verify-archive on all the archives (all verified) > > On Fri, Sep 9, 2016 at 4:34 PM, Steven Gill > wrote: > > > Please review and vote on the release of this plugins release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: https://issues.apache.org/jira/browse/CB-11832 > > > > The plugins have been published to > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11832/ > > > > The packages were published from their corresponding git tags: > > cordova-plugin-battery-status: 1.2.0 (4f9044ec32) > > cordova-plugin-camera: 2.3.0 (cc1076d3cb) > > cordova-plugin-console: 1.0.4 (e4deaa235c) > > cordova-plugin-contacts: 2.2.0 (31b8545e9c) > > cordova-plugin-device: 1.1.3 (b90d1ddf9b) > > cordova-plugin-device-motion: 1.2.2 (bf41b516cb) > > cordova-plugin-device-orientation: 1.0.4 (c3ccdbcf48) > > cordova-plugin-dialogs: 1.3.0 (fef904c728) > > cordova-plugin-file: 4.3.0 (5c0f68d1cc) > > cordova-plugin-file-transfer: 1.6.0 (60b2cd324e) > > cordova-plugin-geolocation: 2.3.0 (b913653214) > > cordova-plugin-globalization: 1.0.4 (6042184e3c) > > cordova-plugin-inappbrowser: 1.5.0 (6c8106a706) > > cordova-plugin-media: 2.4.0 (978c038603) > > cordova-plugin-media-capture: 1.4.0 (c5b9cacf9d) > > cordova-plugin-network-information: 1.3.0 (0e6889a09e) > > cordova-plugin-splashscreen: 4.0.0 (6e43615e25) > > cordova-plugin-statusbar: 2.2.0 (ad5f7d912c) > > cordova-plugin-test-framework: 1.1.3 (d6e0248035) > > cordova-plugin-vibration: 2.1.2 (591e034213) > > cordova-plugin-whitelist: 1.3.0 (d51a360052) > > cordova-plugin-wkwebview-engine: 1.1.0 (d97b63bd7a) > > > > Upon a successful vote I will upload the archives to dist/, upload > > them to npm, and post the corresponding blog post. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/ > release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Ran mobile-spec, all passing except expected failing file-transfer > tests. > > >
Re: [Discuss] plugins release
Need one more! It is important to get these out asap. Getting contacted about certain plugins not working on ios10 already! On Tue, Sep 13, 2016 at 3:30 PM, Steven Gill wrote: > Bump! Please vote on the release > > On Thu, Sep 8, 2016 at 9:06 AM, Steven Gill > wrote: > >> I can review and merge >> >> On Sep 8, 2016 9:00 AM, "David Barth" wrote: >> >>> Hey guys, >>> >>> Alex has a set of fixes for ubuntu code in the following plugins: >>> >>>- https://github.com/apache/cordova-plugin-inappbrowser/pull/174 >>>- https://github.com/apache/cordova-plugin-battery-status/pull/38 >>>- https://github.com/cordova-ubuntu/cordova-plugin-geolocation/pull/2 >>> >>> Should we get another review from plugin maintainers or should i merge to >>> get that in time for the release ? >>> >>> David >>> >>> >>> >>> On Wed, Sep 7, 2016 at 4:47 PM, julio cesar sanchez < >>> jcesarmob...@gmail.com> >>> wrote: >>> >>> > Or maybe we should wait for the corodvaDependencies update? I think >>> there >>> > are PRs for all the plugins >>> > >>> > 2016-09-07 16:21 GMT+02:00 Steven Gill : >>> > >>> > > Yes. I'll move forward with it >>> > > >>> > > On Sep 7, 2016 6:25 AM, "julio cesar sanchez" < >>> jcesarmob...@gmail.com> >>> > > wrote: >>> > > >>> > > > Issues won't stop coming, should we do the release this week? >>> > > > >>> > > > 2016-08-29 13:26 GMT+02:00 Kerri Shotts : >>> > > > >>> > > > > I've got iPads that support multitasking, so I'll take a look. >>> > > > > >>> > > > > ~ Kerri >>> > > > > >>> > > > > >>> > > > > >>> > > > > On Mon, Aug 29, 2016 at 5:57 AM -0500, "julio cesar sanchez" < >>> > > > > jcesarmob...@gmail.com> wrote: >>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > > If somebody with an iPad that supports multitasking can test this >>> > PR... >>> > > > > https://github.com/apache/cordova-plugin-statusbar/pull/62 >>> > > > > >>> > > > > I have reviewed the code and looks good, bud I don't have an iPad >>> > that >>> > > > > supports multitasking to test it, and I don't trust the >>> simulator in >>> > > this >>> > > > > case as I tried to fix that issue in a different way, got it >>> working >>> > on >>> > > > the >>> > > > > simulator but the reporter said that it didn't work as expected >>> on a >>> > > real >>> > > > > device. >>> > > > > >>> > > > > 2016-08-25 0:54 GMT+02:00 julio cesar sanchez : >>> > > > > >>> > > > > > PRs to review >>> > > > > > https://github.com/apache/cordova-plugin-contacts/pull/131 >>> > > > > > https://github.com/apache/cordova-plugin-camera/pull/229 >>> > > > > > >>> > > > > > 2016-08-24 20:20 GMT+02:00 Steven Gill : >>> > > > > > >>> > > > > >> Hey Scott, >>> > > > > >> >>> > > > > >> Thanks for pointing out the PR. I'll take a look. >>> > > > > >> >>> > > > > >> The reality of the situation is that cordova has many repos >>> and >>> > not >>> > > > > enough >>> > > > > >> committers currently. This leads to PRs sitting unreviewed. >>> Plugin >>> > > PRs >>> > > > > are >>> > > > > >> unique in that they can involve various different native >>> language >>> > > > > changes. >>> > > > > >> This could require more than 1 committer needing to review. >>> For >>> > > > example, >>> > > > > >> some committers are more experienced with android vs ios, so >>> they >>> > > > won't >>> > > > > be >>> > > > > >> able to review the ios portion of the plugin PR. Another issue >>> > with >>> > > > > plugin >>> > > > > >> PRs is that they may try to add a new feature (without >>> discussion) >>> > > and >>> > > > > may >>> > > > > >> not add similar functionality for other platforms that >>> support the >>> > > > > plugin. >>> > > > > >> And of course lots of PRs don't include tests. >>> > > > > >> >>> > > > > >> The name being attached to component doesn't mean anything. >>> Issues >>> > > by >>> > > > > >> default go unassigned. >>> > > > > >> >>> > > > > >> I can only speak on behalf of the regular Adobe cordova >>> commiters >>> > (4 >>> > > > of >>> > > > > >> us). Our focus is usually spent on platforms + tools fixes and >>> > > > > >> improvements. >>> > > > > >> >>> > > > > >> The best way to get attention for your PR is to post it to >>> slack + >>> > > > > here. I >>> > > > > >> usually do a review of PRs when I do a plugins release, but I >>> > won't >>> > > be >>> > > > > >> able >>> > > > > >> to go through them all. This is why I ask for people to bring >>> some >>> > > to >>> > > > my >>> > > > > >> attention during releases. >>> > > > > >> >>> > > > > >> Lastly, we would love to help onboard new committers to help >>> > manage >>> > > > > >> plugins. If you are interested in such a role, LMK! >>> > > > > >> >>> > > > > >> Cheers, >>> > > > > >> -Steve >>> > > > > >> >>> > > > > >> On Wed, Aug 24, 2016 at 6:14 AM, Scott Bradshaw >>> > > > > >> wrote: >>> > > > > >> >>> > > > > >> > Hi Steven - Can you look at camera PR 197 >>> > > > > >> > ? This >>> > > > > >> addresses >>> > > > >
Re: [VOTE] Plugins Release
I vote +1: * Ran coho audit-license-headers over the relevant repos (all ok) * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran coho verify-archive on all the archives (all verified) On Fri, Sep 9, 2016 at 4:34 PM, Steven Gill wrote: > Please review and vote on the release of this plugins release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-11832 > > The plugins have been published to > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11832/ > > The packages were published from their corresponding git tags: > cordova-plugin-battery-status: 1.2.0 (4f9044ec32) > cordova-plugin-camera: 2.3.0 (cc1076d3cb) > cordova-plugin-console: 1.0.4 (e4deaa235c) > cordova-plugin-contacts: 2.2.0 (31b8545e9c) > cordova-plugin-device: 1.1.3 (b90d1ddf9b) > cordova-plugin-device-motion: 1.2.2 (bf41b516cb) > cordova-plugin-device-orientation: 1.0.4 (c3ccdbcf48) > cordova-plugin-dialogs: 1.3.0 (fef904c728) > cordova-plugin-file: 4.3.0 (5c0f68d1cc) > cordova-plugin-file-transfer: 1.6.0 (60b2cd324e) > cordova-plugin-geolocation: 2.3.0 (b913653214) > cordova-plugin-globalization: 1.0.4 (6042184e3c) > cordova-plugin-inappbrowser: 1.5.0 (6c8106a706) > cordova-plugin-media: 2.4.0 (978c038603) > cordova-plugin-media-capture: 1.4.0 (c5b9cacf9d) > cordova-plugin-network-information: 1.3.0 (0e6889a09e) > cordova-plugin-splashscreen: 4.0.0 (6e43615e25) > cordova-plugin-statusbar: 2.2.0 (ad5f7d912c) > cordova-plugin-test-framework: 1.1.3 (d6e0248035) > cordova-plugin-vibration: 2.1.2 (591e034213) > cordova-plugin-whitelist: 1.3.0 (d51a360052) > cordova-plugin-wkwebview-engine: 1.1.0 (d97b63bd7a) > > Upon a successful vote I will upload the archives to dist/, upload > them to npm, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ran mobile-spec, all passing except expected failing file-transfer tests. >
[GitHub] cordova-coho pull request #136: Update plugins-release-process.md
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #136: Update plugins-release-process.md
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/136 Update plugins-release-process.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-56 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/136.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #136 commit 3b68b401df8f78e0306b182c745f3e4a96b8c7ce Author: Steve Gill Date: 2016-09-14T18:06:29Z Update plugins-release-process.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows issue #197: CB-11522 [windows] Make cordova-js clone handle ...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/197 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/197?src=pr) is 74.25% (diff: 100%) > Merging [#197](https://codecov.io/gh/apache/cordova-windows/pull/197?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will not change coverage ```diff @@ master #197 diff @@ == Files14 14 Lines 1942 1942 Methods 362362 Messages 0 0 Branches391391 == Hits 1442 1442 Misses 500500 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [0855feb...bd5dbc9](https://codecov.io/gh/apache/cordova-windows/compare/0855feb13aa5de334d5a7cdedea646f31bf8ddfe...bd5dbc9fe476dd4d941a0bcd68a449ac5ba9a323?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #197: CB-11522 [windows] Make cordova-js clone ...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/197 CB-11522 [windows] Make cordova-js clone handle 'unknown' type See details in [CB-11522](https://issues.apache.org/jira/browse/CB-11522?focusedCommentId=15469653&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15469653) You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-windows CB-11522-type-unknown Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/197.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #197 commit bd5dbc9fe476dd4d941a0bcd68a449ac5ba9a323 Author: daserge Date: 2016-09-14T16:31:28Z CB-11522 [windows] Make cordova-js handle 'unknown' type --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #137: CB-11522 [windows] Make cordova-js handle 'unk...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-js/pull/137 CB-11522 [windows] Make cordova-js handle 'unknown' type See details in [CB-11522](https://issues.apache.org/jira/browse/CB-11522?focusedCommentId=15469653&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15469653) You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-js CB-11522-type-unknown Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/137.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #137 commit 9aada3bf8122e8527507e902134af8736b9b1b1d Author: daserge Date: 2016-09-14T16:28:15Z CB-11522 [windows] Make cordova-js handle 'unknown' type --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/196 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/196?src=pr) is 74.25% (diff: 75.00%) > Merging [#196](https://codecov.io/gh/apache/cordova-windows/pull/196?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will not change coverage ```diff @@ master #196 diff @@ == Files14 14 Lines 1942 1942 Methods 362362 Messages 0 0 Branches391391 == Hits 1442 1442 Misses 500500 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [0855feb...0d36e3f](https://codecov.io/gh/apache/cordova-windows/compare/0855feb13aa5de334d5a7cdedea646f31bf8ddfe...0d36e3fd782cd69798c65c57f39f0d4aaecb1717?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #196: Fix setSplashBgColor exception when no sp...
GitHub user giuseppelt opened a pull request: https://github.com/apache/cordova-windows/pull/196 Fix setSplashBgColor exception when no splashscreen is found WindowsPhone allows to unset splashscreen (img) to avoid it to be shown. This patch fixes whenever the "splashscreen" node is not present. You can merge this pull request into a Git repository by running: $ git pull https://github.com/giuseppelt/cordova-windows patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/196.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #196 commit 0d36e3fd782cd69798c65c57f39f0d4aaecb1717 Author: giuseppelt Date: 2016-09-14T16:06:25Z Fix setSplashBgColor exception when no splashscreen is found WindowsPhone allows to unset splashscreen (img) to avoid it to be shown. This patch fixes whenever the "splashscreen" node is not present. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DRAFT] Apache Cordova Board Report for Sept 2016
LGTM Sent from my iPad > On Sep 13, 2016, at 19:09, Shazron wrote: > > Please review, comment on it, etc: > https://github.com/cordova/apache-board-reports/blob/master/2016/2016-09.md
[GitHub] cordova-plugin-inappbrowser issue #186: CB-11946: window.open mailto: consis...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/186 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/186/commits/6fc55bc7bf25a155bf5c1e9d5de155364e778d82) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/68//PLATFORM=android/artifact/) | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #186: CB-11946: window.open mailto:...
GitHub user lexaurin opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/186 CB-11946: window.open mailto: consistency ### Platforms affected Android and WP ### What does this PR do? Fixes mailto links opening with window.open() ### What testing has been done on this change? Tested in emulator. ### Checklist - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. Fixed opening mailto: links on Android and WP and tel: on WP, for consistency. You can merge this pull request into a Git repository by running: $ git pull https://github.com/saphocom/cordova-plugin-inappbrowser cb-11846 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/186.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #186 commit 6fc55bc7bf25a155bf5c1e9d5de155364e778d82 Author: Lex Mourek Date: 2016-09-14T12:48:15Z CB-11946: window.open mailto: consistency Fixed opening mailto: links on Android and WP and tel: on WP, for consistency. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DRAFT] Apache Cordova Board Report for Sept 2016
LGTM 2016-09-14 10:54 GMT+02:00 Shazron : > I'll submit this by end of day 5pm PDT Wednesday Sept 14. > > On Tue, Sep 13, 2016 at 5:09 PM, Shazron wrote: > > > Please review, comment on it, etc: > > https://github.com/cordova/apache-board-reports/blob/ > > master/2016/2016-09.md > > > > > > >
Re: [DRAFT] Apache Cordova Board Report for Sept 2016
I'll submit this by end of day 5pm PDT Wednesday Sept 14. On Tue, Sep 13, 2016 at 5:09 PM, Shazron wrote: > Please review, comment on it, etc: > https://github.com/cordova/apache-board-reports/blob/ > master/2016/2016-09.md > > >
[GitHub] cordova-ios issue #255: Undefined error when calling run directly (not via t...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/255 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/255?src=pr) is 56.80% (diff: 0.00%) > Merging [#255](https://codecov.io/gh/apache/cordova-ios/pull/255?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will decrease coverage by **0.15%** ```diff @@ master #255 diff @@ == Files12 12 Lines 1085 1088 +3 Methods 169169 Messages 0 0 Branches174175 +1 == Hits618618 - Misses 467470 +3 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [4975a1f...4639e72](https://codecov.io/gh/apache/cordova-ios/compare/4975a1fd95ff6fa62cfeaa486362d607b4b30dec...4639e72c8caf73e79e4949e6ba7bb8a3fcca31e5?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #255: Undefined error when calling run directly (no...
GitHub user DaveByBox opened a pull request: https://github.com/apache/cordova-ios/pull/255 Undefined error when calling run directly (not via the CLI) runOptions.argv is only supplied by the CLI. This proposed change will prevent issues for projects which call this library directly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaveByBox/cordova-ios patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/255.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #255 commit 4639e72c8caf73e79e4949e6ba7bb8a3fcca31e5 Author: DaveByBox Date: 2016-09-14T08:24:45Z Undefined error runOptions.argv is only supplied by the CLI. This proposed change will prevent issues for projects which call this library directly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #299: Corrected preference name in example
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/299 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #449: Add Schweepes Connect to showcase
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/449 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #626: Added AppStudio to the Cordova Tools listing
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/626 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
