Nightly build #174 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #174 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/174/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #263: CB-11913 - Re-fix appveyor.yml to use specific node ...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-cli/pull/263
  
Now that I've got appveyor node versions "working", it reflects the node 6 
failures on Travis. Now to get node 6 working (npm link shenanigans).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #499: Cb 11960

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/499

Cb 11960



### Platforms affected
Will work when adding all platforms.

### What does this PR do?
When adding or removing a platform (with --save), the specified platform 
will be added or removed from the package.json file.

### What testing has been done on this change?
Added and removed platforms to see if package.json updates properly.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-11960

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/499.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #499


commit 16576d90145be4de6dd628227f3e65b9a4f4545c
Author: audreyso 
Date:   2016-10-04T00:50:51Z

CB-8995 renamed start to plugman install/uninstall start to make CordovaLib 
tests more descriptive

commit 7fc9f3c2f74353033e1c64178ec86b71d16b1bc9
Author: audreyso 
Date:   2016-10-07T21:19:06Z

CB-11960 specified platform is now added to both a config.xml and 
package.json file when saved




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #263: CB-11913 - Re-fix appveyor.yml to use specifi...

[shazron]

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-cli/pull/263

CB-11913 - Re-fix appveyor.yml to use specific node versions

### Platforms affected

All

### What does this PR do?

Fix appveyor.yml node versions, they were incorrect previously

### What testing has been done on this change?

The test will be on Appveyor (automated with this PR)

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-cli CB-11913

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #263


commit 9b669a37dcf5d6ff876c698cc42e1a1e91840f5a
Author: Shazron Abdullah 
Date:   2016-10-10T18:50:54Z

CB-11913 - Re-fix appveyor.yml to use specific node versions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: camera plugin - target bigger than original picture

[Shazron]

+1 but with caveats as I outlined in the PR.

On Mon, Oct 10, 2016 at 10:16 AM, julio cesar sanchez <
jcesarmob...@gmail.com> wrote:

> I was the one who asked for the email as I think we should discuss it
> before merging.
>
> I agree with Fares idea, if the height or width are greater than the
> originals then I think we shouldn't upscale the image and return the
> original image instead.
> But that should be documented (current PR doesn't document it).
>
> So +1 for the PR.
>
>
>
> 2016-10-10 11:34 GMT+02:00 Fares de Marki :
>
> > Hi,
> >
> > I sent a pull request for the cordova camera plugin :
> > https://github.com/apache/cordova-plugin-camera/pull/238
> >
> > I was asked to send you an email.
> > This pull request prevents the plugin from creating bigger pictures than
> > original ones.
> >
> > Thanks
> >
> >
> > Fares Hantous
> > Marki
> > http://markiapp.com/ 
> >
> >
> >
> >
>

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/238
  
This makes sense, but is a backwards incompatible change since the 
behaviour changes, and some may be using that behaviour.

Either:
1. Increment the major version number, document the breaking change. Users 
using the old behaviour won't be surprised with this change because we follow 
semver.
OR
2. Keep the current behaviour, but add a new option "upscale" (suggested) 
that defaults to `true`. This would be a minor version change since its a new 
feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Vote] Cordova-common@1.5.0 Release

[Steven Gill]

The vote has now closed. The results are:

Positive Binding Votes: 4

Steve Gill
Shazron Abdullah
Vladimir Kotikov
Jesse MacFadyen


The vote has passed.


On Fri, Oct 7, 2016 at 11:36 AM, Jesse  wrote:

> I vote +1:
> * Ran coho audit-license-headers
> * Ran coho check-license
> * Ran npm test
>
>
> @purplecabbage
> risingj.com
>
> On Fri, Oct 7, 2016 at 12:38 AM, Shazron  wrote:
>
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ran npm test
> >
> > On Thu, Oct 6, 2016 at 10:04 PM, Steven Gill 
> > wrote:
> >
> > > Please review and vote on this cordova-common Release
> > > by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-11969
> > >
> > > Both tools have been published to
> > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11969/
> > >
> > > The packages were published from their corresponding git tags:
> > >
> > > cordova-lib: common-1.5.0 (0b56f9c6e5)
> > >
> > > Upon a successful vote I will upload the archives to dist/, publish
> > > them to npm, and post the corresponding blog post.
> > >
> > > Voting guidelines:
> > > https://github.com/apache/cordova-coho/blob/master/docs/
> > release-voting.md
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> > > subdependencies have Apache-compatible licenses
> > > * Ran npm test
> > >
> >
>

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/238
  
LGTM. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #262: CB-11976 - Add deprecated node version warning for 0...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-cli/pull/262
  
@stevengill yes, it should be `>=4.0.0` and remove the `engineStrict` key 
as well. I'll add it soon


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #262: CB-11976 - Add deprecated node version warning for 0...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-cli/pull/262
  
LGTM

Should we update 
https://github.com/apache/cordova-cli/blob/master/package.json#L8 in this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #497: CB-11976 - Add deprecated node version warning for 0...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-lib/pull/497
  
@vladimir-kotikov good idea, I'll update it to >=4.0.0 since engineStrict 
is not used anymore in npm@3 -- and we should remove engineStrict anyways. This 
PR has moved to https://github.com/apache/cordova-cli/pull/262


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: camera plugin - target bigger than original picture

[julio cesar sanchez]

I was the one who asked for the email as I think we should discuss it
before merging.

I agree with Fares idea, if the height or width are greater than the
originals then I think we shouldn't upscale the image and return the
original image instead.
But that should be documented (current PR doesn't document it).

So +1 for the PR.



2016-10-10 11:34 GMT+02:00 Fares de Marki :

> Hi,
>
> I sent a pull request for the cordova camera plugin :
> https://github.com/apache/cordova-plugin-camera/pull/238
>
> I was asked to send you an email.
> This pull request prevents the plugin from creating bigger pictures than
> original ones.
>
> Thanks
>
>
> Fares Hantous
> Marki
> http://markiapp.com/ 
>
>
>
>

camera plugin - target bigger than original picture

[Fares de Marki]

Hi,

I sent a pull request for the cordova camera plugin :
https://github.com/apache/cordova-plugin-camera/pull/238

I was asked to send you an email.
This pull request prevents the plugin from creating bigger pictures than 
original ones.

Thanks


Fares Hantous
Marki
http://markiapp.com/ 

[GitHub] cordova-plugin-geolocation issue #83: CB-11962: (ios) Added variable NSLocat...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-geolocation/pull/83
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-geolocation/pull/83/commits/041228eac66e58a2d2e339228d87d439e831ac8e)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/238
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/238/commits/67755254fca55bd1a6ea1a38ebb835cf972617db)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/84//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #265: CB-11952 - Introduce buildFlag option

[adzellman]

Github user adzellman commented on the issue:

https://github.com/apache/cordova-ios/pull/265
  
@shazron All checks have passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

[adzellman]

GitHub user adzellman reopened a pull request:

https://github.com/apache/cordova-ios/pull/265

CB-11952 - Introduce buildFlag option

### Platforms affected
iOS

### What does this PR do?

- adds buildFlag option for passing args to xcodebuild
- There can be multiple --buildFlag declarations
- Warns if buildFlag would override a built-in setting

### What testing has been done on this change?

- Added unit tests for build.js
- I have tried this out with by passing various legal and illegal flags 
using the --buildFlag option. I used the xcodebuild man page to develop test 
cases.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adzellman/aemm-ios CB-11952

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #265


commit e393738fe1f26824555bd090d1e08a725ed75f88
Author: Andrew Zellman 
Date:   2016-10-05T22:14:59Z

CB-11952 - Introduce buildFlag option
- adds buildFlag option for passing args to xcodebuild
- There can be multiple --buildFlag declarations
- Warns if buildFlag would override a built-in setting

commit d614152e7eafd57527de7f37dee757250c3fa3ad
Author: Andrew Zellman 
Date:   2016-10-06T23:20:14Z

Remove the optional import of check_reqs.
 - Use a try-catch instead, because it actually works.

commit 6d0cc7c56dc4e4e9c93e0a842e92c24964cc6d0e
Author: Andrew Zellman 
Date:   2016-10-06T23:26:30Z

Use util for string formatting of warning.

commit cbf4bac766467c150657d09fd9b5956bbf285b9d
Author: Andrew Zellman 
Date:   2016-10-07T17:09:29Z

Make changes for using workspace instead of project.

commit 68ab00a474ef947e5b2796e596cf23e5c3d8af75
Author: Andrew Zellman 
Date:   2016-10-08T01:12:03Z

Merge branch 'master' of https://github.com/apache/cordova-ios into CB-11952

commit 2b221fd38170486756bc0667fdc62acc0ce8d011
Author: Andrew Zellman 
Date:   2016-10-08T03:04:10Z

Fix up options in response to PR #257




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

[adzellman]

Github user adzellman closed the pull request at:

https://github.com/apache/cordova-ios/pull/265


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #498: CB-11985 Check if cached platform/plugin exists befo...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-lib/pull/498
  
Looks good! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

[fareshan]

Github user fareshan commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/238
  
I just sent the email.

I can complete the documentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/498#discussion_r82568768
  
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -114,19 +113,11 @@ function initThenLoadSettingsWithRestore(promises) {
 }
 
 /**
-* @param {Array} with one element - the plugin id or "id@version"
+* @param {string} plugin - the plugin id or "id@version"
 * @return {Promise.} Promised path to fetched package.
 */
 function fetchPlugin(plugin) {
-return initThenLoadSettingsWithRestore(function () {
-events.emit('log', 'Fetching plugin "' + plugin + '" via npm');
-return Q.ninvoke(npm.commands, 'cache', ['add', plugin])
-.then(function (info) {
-var unpack = require('../../util/unpack');
-var pluginDir = path.resolve(npm.cache, info.name, 
info.version, 'package');
-// Unpack the plugin that was added to the cache (CB-8154)
-var package_tgz = path.resolve(npm.cache, info.name, 
info.version, 'package.tgz');
-return unpack.unpackTgz(package_tgz, pluginDir);
-});
-});
+events.emit('log', 'Fetching plugin "' + plugin + '" via npm');
+var pluginSplit = plugin.split('@');
+return npmhelper.fetchPackage(pluginSplit[0], pluginSplit[1]);
--- End diff --

Hah, look at that. I didn't know @riknoll had added support for scoped 
packages. I'll switch this to use `plugin-spec-parser`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #498: CB-11985 Check if cached platform/plugin exists befo...

[brodybits]

Github user brodybits commented on the issue:

https://github.com/apache/cordova-lib/pull/498
  
Thanks @TimBarham for the explanation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

[jcesarmobile]

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/238
  
I think this should discussed before merging. Can you send an email to 
dev@cordova.apache.org?

Also, if we decide to merge it, you should document the behaviour for 
targetWidth and targetHeight being bigger than the original image (in 
jsdoc2md/TEMPLATE.md)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #498: CB-11985 Check if cached platform/plugin exists befo...

[TimBarham]

Github user TimBarham commented on the issue:

https://github.com/apache/cordova-lib/pull/498
  
@brodybits - that hasn't changed. At the point where we're looking for a 
cached version, we have already determined the latest version that matches the 
requested range (for both platforms and plugins). If a version range is 
specified, we have to hit the internet to determine the latest version that 
matches that range (and this change doesn't provide any real benefit). If a 
specific version is specified (which will be the case in VS), then that is the 
version we'll get (cached if it is there, otherwise have to download).

The only change here from a user's perspective should be that plugins are 
cached in the same place as platforms (in the `.cordova` directory).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...

[shazron]

GitHub user shazron reopened a pull request:

https://github.com/apache/cordova-cli/pull/262

CB-11976 - Add deprecated node version warning for 0.x

### Platforms affected

All.

### What does this PR do?

Before running each command, it will check if the node version is 0.x. If 
it is, it prints out a warning.

### What testing has been done on this change?

Tested locally.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-cli CB-11976

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #262


commit 0814fe06c7851103ea321873cd160b47481596cd
Author: Shazron Abdullah 
Date:   2016-10-10T07:53:58Z

CB-11976 - Add deprecated node version warning for 0.x




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...

[shazron]

Github user shazron closed the pull request at:

https://github.com/apache/cordova-cli/pull/262


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #498: CB-11985 Check if cached platform/plugin exists befo...

[brodybits]

Github user brodybits commented on the issue:

https://github.com/apache/cordova-lib/pull/498
  
I would personally favor this change to be "opt-in". I like the idea that 
npm checks for a newer release before using the cached version of a package.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/498#discussion_r82566198
  
--- Diff: cordova-lib/src/util/npm-helper.js ---
@@ -72,4 +75,53 @@ function restoreSettings() {
 }
 }
 
+/**
+ * Fetches the latest version of a package from NPM that matches the 
specified version. Returns a promise that
+ * resolves to the directory the NPM package is located in.
+ * @param packageName - name of an npm package
+ * @param packageVersion - requested version or version range
+ */
+function fetchPackage(packageName, packageVersion) {
+// Get the latest matching version from NPM if a version range is 
specified
+return util.getLatestMatchingNpmVersion(packageName, 
packageVersion).then(
+function (latestVersion) {
+return cachePackage(packageName, latestVersion);
+}
+);
+}
+
+/**
+ * Invokes "npm cache add," and then returns a promise that resolves to a 
directory containing the downloaded,
+ * or cached package.
+ * @param packageName - name of an npm package
+ * @param packageVersion - requested version (not a version range)
+ */
+function cachePackage(packageName, packageVersion) {
+var cacheDir = path.join(util.libDirectory, 'npm_cache');
+
+// If already cached, use that rather than calling 'npm cache add' 
again.
+var packageCacheDir = path.resolve(cacheDir, packageName, 
packageVersion);
--- End diff --

Sure I'll wrap the whole method in a promise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #497: CB-11976 - Add deprecated node version warning for 0...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-lib/pull/497
  
@shazron, we still have `"node": ">=0.9.9"` in 
[package.json](https://github.com/apache/cordova-lib/blob/master/cordova-lib/package.json#L16).
 Might want to update it, so the users will see a warning at install time


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/498#discussion_r82563323
  
--- Diff: cordova-lib/src/util/npm-helper.js ---
@@ -72,4 +75,53 @@ function restoreSettings() {
 }
 }
 
+/**
+ * Fetches the latest version of a package from NPM that matches the 
specified version. Returns a promise that
+ * resolves to the directory the NPM package is located in.
+ * @param packageName - name of an npm package
+ * @param packageVersion - requested version or version range
+ */
+function fetchPackage(packageName, packageVersion) {
+// Get the latest matching version from NPM if a version range is 
specified
+return util.getLatestMatchingNpmVersion(packageName, 
packageVersion).then(
+function (latestVersion) {
+return cachePackage(packageName, latestVersion);
+}
+);
+}
+
+/**
+ * Invokes "npm cache add," and then returns a promise that resolves to a 
directory containing the downloaded,
+ * or cached package.
+ * @param packageName - name of an npm package
+ * @param packageVersion - requested version (not a version range)
+ */
+function cachePackage(packageName, packageVersion) {
+var cacheDir = path.join(util.libDirectory, 'npm_cache');
+
+// If already cached, use that rather than calling 'npm cache add' 
again.
+var packageCacheDir = path.resolve(cacheDir, packageName, 
packageVersion);
--- End diff --

If `packageVersion` is not provided, this will throw the following error: 
'TypeError: Path must be a string. Received undefined'. IMO while this is 
legitimate error, it probably needs to be wrapped into promise, since this 
function return a promised result.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/498#discussion_r82563870
  
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -114,19 +113,11 @@ function initThenLoadSettingsWithRestore(promises) {
 }
 
 /**
-* @param {Array} with one element - the plugin id or "id@version"
+* @param {string} plugin - the plugin id or "id@version"
 * @return {Promise.} Promised path to fetched package.
 */
 function fetchPlugin(plugin) {
-return initThenLoadSettingsWithRestore(function () {
-events.emit('log', 'Fetching plugin "' + plugin + '" via npm');
-return Q.ninvoke(npm.commands, 'cache', ['add', plugin])
-.then(function (info) {
-var unpack = require('../../util/unpack');
-var pluginDir = path.resolve(npm.cache, info.name, 
info.version, 'package');
-// Unpack the plugin that was added to the cache (CB-8154)
-var package_tgz = path.resolve(npm.cache, info.name, 
info.version, 'package.tgz');
-return unpack.unpackTgz(package_tgz, pluginDir);
-});
-});
+events.emit('log', 'Fetching plugin "' + plugin + '" via npm');
+var pluginSplit = plugin.split('@');
+return npmhelper.fetchPackage(pluginSplit[0], pluginSplit[1]);
--- End diff --

Looks like this will not work for scoped NPM packages (like 
`@scope/cordova-plugin-camera@2.0.0`). `pluginSplit[0]` and `pluginSplit[1]` 
would become `''` and `'scope/cordova-plugin-camera'` in this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #64: CB-11858: Add possibility to utilize And...

[tobiasviehweger]

Github user tobiasviehweger commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/64
  
Just read up again on the expected behaviour here: 
http://devgirl.org/2014/07/31/phonegap-developers-guid/
It seems blacktranslucent & blackopaque should not be used anymore, so it 
would be probably good to deprecate them - I did not quite understood that they 
are the same as default & lightcontent.

Also, implemented the following methods:
- styleDefault
- styleBlackTranslucent
- styleLightContent
- styleBlackOpaque


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...

[shazron]

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-cli/pull/262

CB-11976 - Add deprecated node version warning for 0.x

### Platforms affected

All.

### What does this PR do?

Before running each command, it will check if the node version is 0.x. If 
it is, it prints out a warning.

### What testing has been done on this change?

Tested locally.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-cli CB-11976

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #262


commit 0814fe06c7851103ea321873cd160b47481596cd
Author: Shazron Abdullah 
Date:   2016-10-10T07:53:58Z

CB-11976 - Add deprecated node version warning for 0.x




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #497: CB-11976 - Add deprecated node version warnin...

[shazron]

Github user shazron closed the pull request at:

https://github.com/apache/cordova-lib/pull/497


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #497: CB-11976 - Add deprecated node version warning for 0...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-lib/pull/497
  
Closing. Can't have an effective warn in here, moving to cordova-cli.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-dialogs pull request #88: /!\ Alert on startapp

[jedofus]

Github user jedofus closed the pull request at:

https://github.com/apache/cordova-plugin-dialogs/pull/88


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org