date:20161129

[GitHub] cordova-plugin-device issue #58: CB-12199: (android) Add SDK version propert...

2016-11-29 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-device/pull/58
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-device/pull/58/commits/ef9d50ef50ba7e26a40c93a5fe0a78287b6bae11)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request #58: CB-12199: (android) Add SDK version ...

2016-11-29 Thread yamane-dsys

GitHub user yamane-dsys opened a pull request:

https://github.com/apache/cordova-plugin-device/pull/58

CB-12199: (android) Add SDK version property for Android



### Platforms affected

Android

### What does this PR do?

Add device.sdkversion property.

### What testing has been done on this change?

Add AutoTest for sdkversion to 'tests/tests.js' 
Done AutoTests and ManualTests with cordova-plugin-test-framework

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yamane-dsys/cordova-plugin-device master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-device/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #58


commit ab595695e57bd9a8bde8132f5d210424f3439c8c
Author: YAMANE Takaaki 
Date:   2016-11-24T09:49:55Z

Use SDK_INT value for Android sdkversion, instead of SDK

(which was deprecated in API level 4)

commit 3634cad8a3ee60c91d76e48a1ef5cd4732cbd8d0
Author: YAMANE Takaaki 
Date:   2016-11-24T09:54:08Z

Add property device.sdkversion (Android)

commit ef9d50ef50ba7e26a40c93a5fe0a78287b6bae11
Author: YAMANE Takaaki 
Date:   2016-11-30T05:10:44Z

Add AutoTest for "sdkversion"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #242 for cordova has succeeded!

2016-11-29 Thread Apache Jenkins Server

Nightly build #242 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/242/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine pull request #23: CB-11997: Add crash recove...

2016-11-29 Thread shazron

Github user shazron commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23#discussion_r90091089
  
--- Diff: src/ios/CDVWKWebViewEngine.m ---
@@ -123,6 +123,32 @@ - (void)pluginInitialize
name:UIApplicationWillEnterForegroundNotification 
object:nil];
 
 NSLog(@"Using WKWebView");
+
+[self addURLObserver];
+}
+
+- (void)onReset {
+[self addURLObserver];
+}
+
+static void * KVOContext = 
+
+- (void)addURLObserver {
+if(![[NSProcessInfo processInfo] 
isOperatingSystemAtLeastVersion:(NSOperatingSystemVersion){.majorVersion = 9, 
.minorVersion = 0, .patchVersion = 0 }]){
--- End diff --

To make it simpler, you can use `IsAtLeastiOSVersion(@"9.0")`  (from 
CDVAvailability.h)
I'm not sure how this whole patch would work for iOS 8, because of this 
note: https://github.com/apache/cordova-plugin-wkwebview-engine#notes

Is this for a "using a local webserver" context?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine pull request #23: CB-11997: Add crash recove...

2016-11-29 Thread shazron

Github user shazron commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23#discussion_r90092299
  
--- Diff: src/ios/CDVWKWebViewEngine.m ---
@@ -123,6 +123,32 @@ - (void)pluginInitialize
name:UIApplicationWillEnterForegroundNotification 
object:nil];
 
 NSLog(@"Using WKWebView");
+
+[self addURLObserver];
+}
+
+- (void)onReset {
+[self addURLObserver];
+}
+
+static void * KVOContext = 
+
+- (void)addURLObserver {
+if(![[NSProcessInfo processInfo] 
isOperatingSystemAtLeastVersion:(NSOperatingSystemVersion){.majorVersion = 9, 
.minorVersion = 0, .patchVersion = 0 }]){
+[self.webView addObserver:self forKeyPath:@"URL" options:0 
context:KVOContext];
+}
+}
+
+- (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object 
change:(NSDictionary *)change context:(void *)context
+{
+if (context == KVOContext) {
+if (object == [self webView] && [keyPath isEqualToString: @"URL"] 
&& [object valueForKeyPath:keyPath] == nil){
+NSLog(@"URL is nil. Reloading WebView");
--- End diff --

Change WebView to WKWebView to give more clarity in the log here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #24: CB-10228:(iOS) AppendUserAgent no...

2016-11-29 Thread shazron

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24
  
Note: this passes tests when run locally (the CI has a known issue that it 
fails).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #73: Added editablelocation option for and...

2016-11-29 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/73
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/73/commits/0e8195c185a9498e4996c78e02da9a6c9a966b9c)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/100//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #73: Added editablelocation option for and...

2016-11-29 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/73
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/73/commits/eb0977102e4de10836e2d9c8a5af5d8e86a7a669)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/99//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

2016-11-29 Thread jcesarmobile

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
Then looks good to me, I can't think any example right now where the same 
file should be needed for all platforms


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Hello again!

2016-11-29 Thread Anis KADRI

Welcome back Fil!

On Tue, Nov 29, 2016 at 12:28 AM  wrote:

> Hi again Filip, you are most welcome!
>
> >> - cordova-paramedic configs are pulled from cordova-medic repo.
> >> (?) requires an extra pull in CI.
> Yeah. This is kind of rudimentary thing, I think we can safely transfer
> them to cordova-paramedic repo. This will require some Jenkins jobs
> changes, I can assist with that.
>
> > >  - paramedic setup for individual plugins install latest HEAD of
> > > master of platform code (at least, cordova-android + device plugin)
> What makes you think so? I double-checked, our current CI setup for per-PR
> jobs is using the released versions of all the platforms. Master versions
> are used only for periodic build.
>
> > >  - there are plugins tests that run via a jenkins instance on
> > > cloudapp.net, and there are travis tests too. travis is pull-req
> > > triggered, cloud app runs nightly. why?
> Regarding cloudapp (Jenkins) builds:
> The goal of nightly tests is to verify the master versions of plugins
> against the master versions of platforms and CLI. We also run per-PR jobs
> against the released versions of platform and CLI, you can find them here:
> http://cordova-ci.cloudapp.net:8080/view/Pull%20requests/
>
> Feel free to contact me via email or Slack if you have any questions
> regarding our current CI setup or need an assistance.
>
> Thanks,
> Alexander Sorokin
>
> -Original Message-
> From: Jesse [mailto:purplecabb...@gmail.com]
> Sent: Monday, November 28, 2016 11:00 PM
> To: dev@cordova.apache.org
> Subject: Re: Hello again!
>
> Welcome back!
>
>
> @purplecabbage
> risingj.com
>
> On Mon, Nov 28, 2016 at 11:50 AM, Simon MacDonald <
> simon.macdon...@gmail.com
> > wrote:
>
> > Never heard of this guy.
> > Simon Mac Donald
> > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsimonm
> > acdonald.com=02%7C01%7Cv-alsoro%40microsoft.com%7Cdcdee276682a4ff
> > 9353408d417c92e87%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6361596
> > 00215033744=zPpzT0F5p5rlW71wFWe0DtB2cG8rednMPQyiqtUw%2BZg%3D
> > erved=0
> >
> >
> > On Mon, Nov 28, 2016 at 2:48 PM, Filip Maj  wrote:
> > > Hi everyone!
> > >
> > > Just wanted to (re)introduce myself after a 3 year or so hiatus :)
> > >
> > > I used to be an active member of the group between 2011 and 2013
> > > when I was on the Adobe PhoneGap team. I took a 3 year detour
> > > focusing on mobile testing infrastructure at Sauce Labs, but
> > > recently rejoined the Adobe PhoneGap team. I have been lurking more
> > > intently on this list for the past month or so and aim to be more
> involved these days.
> > >
> > > I've been poking around and getting my bearings around the testing
> > > suites, infrastructure and CI in Cordova the past week or so. I
> > > think I will try to contribute in that area initially. In
> > > particular, I am interested in enabling functional end-to-end
> > > testing for all repos in cordova that could benefit from that sort
> > > of testing, and seamlessly integrating running the tests and
> > > reporting their results back into the standard Cordova dev workflow
> > > (I assume that is focussed around GitHub?). I see there are
> > > different kinds of test coverage and CI systems at play (cloudapp,
> > > travis, appveyor, plus unit and functional tests), so initially just
> wrapping my head around all that.
> > >
> > > If anyone here has suggestions on areas that need work, have
> > > grievances around how they are frustrated by manually needing to
> > > test something, or having any other helpful tips on what needs work
> > > or what could be improved, feel free to reply to this thread!
> > >
> > > My generic notes on this topic so far, in case that is helpful:
> > >
> > > cordova testing overview
> > > ———
> > > notes / weird things:
> > >  - cordova-paramedic configs are pulled from cordova-medic repo. (?)
> > > requires an extra pull in CI.
> > >  - paramedic setup for individual plugins install latest HEAD of
> > > master of platform code (at least, cordova-android + device plugin)
> > >  - there are plugins tests that run via a jenkins instance on
> > > cloudapp.net, and there are travis tests too. travis is pull-req
> > > triggered, cloud app runs nightly. why?
> > >
> > > road to testing utopia:
> > >  - how do platforms get tested? integration tests with what: tooling?
> > plugins?
> > >- unit tests run on travis/appveyor?
> > >- understand what needs to be tested for a release. work
> > > backwards to automate that from there. Steve sent some helpful links
> my way:
> > >  - platform:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
> > > hub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2F=02%7C
> > > 01%7Cv-alsoro%40microsoft.com%7Cdcdee276682a4ff9353408d417c92e87%7C7
> > > 2f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636159600215033744=q
> > > oBxneF1%2FwzJTPwFxp7CsvbdEUUq8u5ALYCqXbjyuzM%3D=0
> >

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

2016-11-29 Thread dpogue

Github user dpogue commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
For clarity, "top-level support" means allowing `resource-file` tags that 
aren't scoped to a particular platform.

i.e.,
```xml



```
This would copy `./foo.xml` to `./platforms/ios/bar.xml`, 
`./platforms/windows/bar.xml`, etc.

It's not clear if there's a use case for files that get copied into every 
platform.

---

What will definitely be supported is platform-scoped `resource-file` tags:
```xml






```
This would copy `./gservices.json` to 
`./platforms/android/google-services.json` and copy 
`./icons/notification-mdpi.png` to 
`./platforms/android/res/drawable-mdpi/ic_notification.png`

This does not require files to go under the www folder, the target can be 
anywhere in the platform directory (same as with plugin `resource-file` tags)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSSION] Windows tag, what should it be doing?

2016-11-29 Thread Karen Tran

I want to get some discussion on what the plugin.xml  tag
should be doing in Windows because I didn't know that it had been changed
for a while now.

jira issue: https://issues.apache.org/jira/browse/CB-12163

Current behavior: Doesn't copy resource file from src to target. Instead,
it will use a reference to the src location. This is the snippet from
PluginHandler.js explaining this behavior, which was not added to the docs.
(https://issues.apache.org/jira/browse/CB-10326)

// do not copy, but reference the file in the plugin folder. This
allows to// have multiple source files map to the same target and
select the appropriate// one based on the current build settings, e.g.
architecture.// also, we don't check for existence. This allows to
insert build variables// into the source file name, e.g.//



This is greatly different from the original intent of a the 
tag since it doesn't do a copy. I don't think that this new behavior really
should have replaced the copy functionality. It's a little unintuitive to
reference resources from outside the application. Not all resource files
are .dll, and there's no other reasonable tag to do a copy for files that
are not source files, lib files, or assets. (e.g, I'm using resource-file
tag with a .properties file, but because it does not get copied over, I
can't reference my properties).

These are the points I think we should come to a decision on
1. What should be the default behavior of  tag? Should it
simply be copy resources as it was originally intended to, or should it be
doing what it is now, which is making a reference to the resource files.
2. Should  tag handle both functionalities, or should one be
separated out into another tag?

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

2016-11-29 Thread jcesarmobile

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
I think top level might make sense here if it's a file that the IDE needs 
but not the app (configuration file like google-services.json/plist)

Can the launch images and icons be outside the www folder?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

2016-11-29 Thread ktop

Github user ktop commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
SGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...

2016-11-29 Thread daserge

Github user daserge commented on the issue:

https://github.com/apache/cordova-windows/pull/212
  
@vladimir-kotikov addressed, thanks! It is good to go?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-29 Thread daserge

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/212#discussion_r90007897
  
--- Diff: template/cordova/lib/AppxManifest.js ---
@@ -416,6 +417,18 @@ AppxManifest.prototype.getVisualElements = function () 
{
 }
 return this;
 },
+getSplashScreenExtension: function (extension) {
--- End diff --

Please see 
https://github.com/apache/cordova-windows/pull/212#discussion_r90006200


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #170: CB-12154 file-transfer progressEven...

2016-11-29 Thread erikramalho

Github user erikramalho commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/170
  
+1 for to merge it ASAP! cheers @daserge 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-29 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/212#discussion_r89992916
  
--- Diff: template/cordova/lib/prepare.js ---
@@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest) {
 manifest.getApplication().setAccessRules(whitelistRules);
 }
 
-function mapImageResources(images, imagesDir) {
-var pathMap = {};
+// Platform default images
+var platformImages = [
+{dest: 'Square150x150Logo.scale-100', width: 150, height: 150},
+{dest: 'Square30x30Logo.scale-100', width: 30, height: 30},
+{dest: 'StoreLogo.scale-100', width: 50, height: 50},
+{dest: 'SplashScreen.scale-100', width: 620, height: 300, 
targetProject: TARGET_PROJECT_10},
+{dest: 'SplashScreen.scale-125', width: 775, height: 375, 
targetProject: TARGET_PROJECT_10},
+{dest: 'SplashScreen.scale-140', width: 868, height: 420, 
targetProject: TARGET_PROJECT_81},
+{dest: 'SplashScreen.scale-150', width: 930, height: 450, 
targetProject: TARGET_PROJECT_10},
+{dest: 'SplashScreen.scale-180', width: 1116, height: 540, 
targetProject: TARGET_PROJECT_81},
+{dest: 'SplashScreen.scale-200', width: 1240, height: 600, 
targetProject: TARGET_PROJECT_10},
+{dest: 'SplashScreen.scale-400', width: 2480, height: 1200, 
targetProject: TARGET_PROJECT_10},
+// scaled images are specified here for backward compatibility only so 
we can find them by size
+{dest: 'StoreLogo.scale-240', width: 120, height: 120},
+{dest: 'Square44x44Logo.scale-100', width: 44, height: 44},
+{dest: 'Square44x44Logo.scale-240', width: 106, height: 106},
+{dest: 'Square70x70Logo.scale-100', width: 70, height: 70},
+{dest: 'Square71x71Logo.scale-100', width: 71, height: 71},
+{dest: 'Square71x71Logo.scale-240', width: 170, height: 170},
+{dest: 'Square150x150Logo.scale-240', width: 360, height: 360},
+{dest: 'Square310x310Logo.scale-100', width: 310, height: 310},
+{dest: 'Wide310x150Logo.scale-100', width: 310, height: 150},
+{dest: 'Wide310x150Logo.scale-240', width: 744, height: 360},
+{dest: 'SplashScreenPhone.scale-100', width: 480, height: 800, 
targetProject: TARGET_PROJECT_WP81},
+{dest: 'SplashScreenPhone.scale-140', width: 672, height: 1120, 
targetProject: TARGET_PROJECT_WP81},
+{dest: 'SplashScreenPhone.scale-240', width: 1152, height: 1920, 
targetProject: TARGET_PROJECT_WP81}
+];
+
+function findPlatformImage(width, height) {
+if (!width && !height){
+// this could be default image,
+// Windows requires specific image dimension so we can't apply it
+return null;
+}
+for (var idx in platformImages){
+var res = platformImages[idx];
+// If only one of width or height is not specified, use another 
parameter for comparation
+// If both specified, compare both.
+if ((!width || (width == res.width)) &&
+(!height || (height == res.height))){
+return res;
+}
+}
+return null;
+}
 
-// Platform default images
-var platformImages = [
-{dest: 'Square150x150Logo.scale-100.png', width: 150, height: 150},
-{dest: 'Square30x30Logo.scale-100.png', width: 30, height: 30},
-{dest: 'StoreLogo.scale-100.png', width: 50, height: 50},
-{dest: 'SplashScreen.scale-100.png', width: 620, height: 300},
-// scaled images are specified here for backward compatibility 
only so we can find them by size
-{dest: 'StoreLogo.scale-240.png', width: 120, height: 120},
-{dest: 'Square44x44Logo.scale-100.png', width: 44, height: 44},
-{dest: 'Square44x44Logo.scale-240.png', width: 106, height: 106},
-{dest: 'Square70x70Logo.scale-100.png', width: 70, height: 70},
-{dest: 'Square71x71Logo.scale-100.png', width: 71, height: 71},
-{dest: 'Square71x71Logo.scale-240.png', width: 170, height: 170},
-{dest: 'Square150x150Logo.scale-240.png', width: 360, height: 360},
-{dest: 'Square310x310Logo.scale-100.png', width: 310, height: 310},
-{dest: 'Wide310x150Logo.scale-100.png', width: 310, height: 150},
-{dest: 'Wide310x150Logo.scale-240.png', width: 744, height: 360},
-{dest: 'SplashScreenPhone.scale-240.png', width: 1152, height: 
1920}
-];
+/** Maps MRT splashscreen image to its target project defined in 
platformImages -> 8.1|WP8.1|10
+ * This assumes we have different scales used for 8.1 and 10 projects.
+ * The only intersection is scale-100, which is treated as Win10 project' 
splashscreen (because
+ * size limit applies to Win10 project so we'll need to check it).
+ */
+function

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-29 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/212#discussion_r89994632
  
--- Diff: template/cordova/lib/prepare.js ---
@@ -439,6 +492,107 @@ function getUAPVersions(config) {
 };
 }
 
+/** Checks if a targetProject matches splashscreen target name */
+function splashScreenTargetProjectMatchesTargetName(targetProject, 
targetName) {
+if (targetName === SPLASH_SCREEN_DESKTOP_TARGET_NAME) {
+return targetProject === TARGET_PROJECT_81 || targetProject === 
TARGET_PROJECT_10;
+}
+
+return targetProject === TARGET_PROJECT_WP81;
+}
+
+/**
+ * Checks if the splash screen matches the target project
+ * @param  {Object} splash SplashScreen object to check
+ * @param  {String} targetName SplashScreen target name: 
'SplashScreen'|'SplashScreenPhone'
+ * @returns {Boolean} True if the splash screen matches the target project
+ */
+function splashScreenTargetIs(splash, targetName) {
+var targetImg;
+
+if (splash.target) {
+// MRT syntax:
+return splash.target === targetName;
+} 
+
+// Fall back on find by size for old non-MRT syntax:
+targetImg = findPlatformImage(splash.width, splash.height);
+return 
splashScreenTargetProjectMatchesTargetName(targetImg.targetProject, targetName);
+}
+
+// Updates manifests to match the app splash screen image types 
(PNG/JPG/JPEG)
+function updateSplashScreenImageExtensions(cordovaProject, locations) {
+
+// Saving all extensions used for targets to verify them later
+var extensionsUsed = {};
+
+function checkThatExtensionsAreNotMixed() {
+for (var target in extensionsUsed) {
+/*jshint loopfunc: true */
+if (extensionsUsed.hasOwnProperty(target)) {
+var extensionsUsedForTarget = extensionsUsed[target];
+
+// Check that extensions are not mixed:
+if (extensionsUsedForTarget.length > 1 && 
extensionsUsedForTarget.some(function(item) {
+return item !== extensionsUsedForTarget[0];
+})) {
+events.emit('warn', '"' + target + '" splash screens 
have mixed file extensions which is not supported. Some of the images will not 
be used.');
+}
+}
+}
+}
+
+function checkTargetMatchAndUpdateUsedExtensions(img, target) {
+var matchesTarget = splashScreenTargetIs(img, target);
--- End diff --

IMO it's not very clear, what is `splashScreenTargetIs` function for and 
what values it can return. I'd suggest to rework this in the following way:
1. have a function that returns a target project based on image `target` or 
dimensions (e.g. `getTargetForImage`)
2. do a comparison of that function's result and `target` variable here so 
it's be clear that we expect result to match target



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-29 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/212#discussion_r89990562
  
--- Diff: cordova-js-src/splashscreen.js ---
@@ -58,8 +58,45 @@ function readBoolFromCfg(preferenceName, defaultValue, 
cfg) {
 }
 }
 
+// Refine splashscreen file extension to match what is in config.xml
+function refineSplashScreenExtension(cfg) {
--- End diff --

> Then we'll need to manipulate the Image.src anyway as it is in different 
format.

Why? Isn't the logic in 'prepare' supposed to update splash screen file 
name to actual value? The benefit IMO is that you'll have one place where 
you're trying to infer splashscreen real filename based on `splashscreen` 
preferences


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-29 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/212#discussion_r89991437
  
--- Diff: template/cordova/lib/prepare.js ---
@@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest) {
 manifest.getApplication().setAccessRules(whitelistRules);
 }
 
-function mapImageResources(images, imagesDir) {
-var pathMap = {};
+// Platform default images
+var platformImages = [
--- End diff --

nit: could you please make it uppercase, so i'd be easy to understand in 
code that we're using some constant value


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-29 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/212#discussion_r89993606
  
--- Diff: template/cordova/lib/prepare.js ---
@@ -353,6 +391,13 @@ function mapImageResources(images, imagesDir) {
 events.emit('warn', 'No images found for target: ' + 
img.target);
 } else {
 candidates.forEach(function(mrtImage) {
+if (img.target === SPLASH_SCREEN_DESKTOP_TARGET_NAME &&
+mrtSplashScreenToTargetProject(mrtImage) === 
TARGET_PROJECT_10 &&
+exceedsSizeLimit(mrtImage.path)) {
--- End diff --

Makes sense


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-29 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/212#discussion_r89991151
  
--- Diff: template/cordova/lib/AppxManifest.js ---
@@ -416,6 +417,18 @@ AppxManifest.prototype.getVisualElements = function () 
{
 }
 return this;
 },
+getSplashScreenExtension: function (extension) {
--- End diff --

Instead of very specific to this issue `get/setSplashScreenExtension` can 
we have more generic `get/setSplashScreen` to set the filename?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-29 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/212#discussion_r89991524
  
--- Diff: template/cordova/lib/prepare.js ---
@@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest) {
 manifest.getApplication().setAccessRules(whitelistRules);
 }
 
-function mapImageResources(images, imagesDir) {
-var pathMap = {};
+// Platform default images
+var platformImages = [
+{dest: 'Square150x150Logo.scale-100', width: 150, height: 150},
+{dest: 'Square30x30Logo.scale-100', width: 30, height: 30},
+{dest: 'StoreLogo.scale-100', width: 50, height: 50},
+{dest: 'SplashScreen.scale-100', width: 620, height: 300, 
targetProject: TARGET_PROJECT_10},
+{dest: 'SplashScreen.scale-125', width: 775, height: 375, 
targetProject: TARGET_PROJECT_10},
+{dest: 'SplashScreen.scale-140', width: 868, height: 420, 
targetProject: TARGET_PROJECT_81},
+{dest: 'SplashScreen.scale-150', width: 930, height: 450, 
targetProject: TARGET_PROJECT_10},
+{dest: 'SplashScreen.scale-180', width: 1116, height: 540, 
targetProject: TARGET_PROJECT_81},
+{dest: 'SplashScreen.scale-200', width: 1240, height: 600, 
targetProject: TARGET_PROJECT_10},
+{dest: 'SplashScreen.scale-400', width: 2480, height: 1200, 
targetProject: TARGET_PROJECT_10},
+// scaled images are specified here for backward compatibility only so 
we can find them by size
+{dest: 'StoreLogo.scale-240', width: 120, height: 120},
+{dest: 'Square44x44Logo.scale-100', width: 44, height: 44},
+{dest: 'Square44x44Logo.scale-240', width: 106, height: 106},
+{dest: 'Square70x70Logo.scale-100', width: 70, height: 70},
+{dest: 'Square71x71Logo.scale-100', width: 71, height: 71},
+{dest: 'Square71x71Logo.scale-240', width: 170, height: 170},
+{dest: 'Square150x150Logo.scale-240', width: 360, height: 360},
+{dest: 'Square310x310Logo.scale-100', width: 310, height: 310},
+{dest: 'Wide310x150Logo.scale-100', width: 310, height: 150},
+{dest: 'Wide310x150Logo.scale-240', width: 744, height: 360},
+{dest: 'SplashScreenPhone.scale-100', width: 480, height: 800, 
targetProject: TARGET_PROJECT_WP81},
+{dest: 'SplashScreenPhone.scale-140', width: 672, height: 1120, 
targetProject: TARGET_PROJECT_WP81},
+{dest: 'SplashScreenPhone.scale-240', width: 1152, height: 1920, 
targetProject: TARGET_PROJECT_WP81}
+];
+
+function findPlatformImage(width, height) {
+if (!width && !height){
+// this could be default image,
+// Windows requires specific image dimension so we can't apply it
+return null;
+}
+for (var idx in platformImages){
+var res = platformImages[idx];
+// If only one of width or height is not specified, use another 
parameter for comparation
+// If both specified, compare both.
+if ((!width || (width == res.width)) &&
+(!height || (height == res.height))){
+return res;
+}
+}
+return null;
+}
 
-// Platform default images
-var platformImages = [
-{dest: 'Square150x150Logo.scale-100.png', width: 150, height: 150},
-{dest: 'Square30x30Logo.scale-100.png', width: 30, height: 30},
-{dest: 'StoreLogo.scale-100.png', width: 50, height: 50},
-{dest: 'SplashScreen.scale-100.png', width: 620, height: 300},
-// scaled images are specified here for backward compatibility 
only so we can find them by size
-{dest: 'StoreLogo.scale-240.png', width: 120, height: 120},
-{dest: 'Square44x44Logo.scale-100.png', width: 44, height: 44},
-{dest: 'Square44x44Logo.scale-240.png', width: 106, height: 106},
-{dest: 'Square70x70Logo.scale-100.png', width: 70, height: 70},
-{dest: 'Square71x71Logo.scale-100.png', width: 71, height: 71},
-{dest: 'Square71x71Logo.scale-240.png', width: 170, height: 170},
-{dest: 'Square150x150Logo.scale-240.png', width: 360, height: 360},
-{dest: 'Square310x310Logo.scale-100.png', width: 310, height: 310},
-{dest: 'Wide310x150Logo.scale-100.png', width: 310, height: 150},
-{dest: 'Wide310x150Logo.scale-240.png', width: 744, height: 360},
-{dest: 'SplashScreenPhone.scale-240.png', width: 1152, height: 
1920}
-];
+/** Maps MRT splashscreen image to its target project defined in 
platformImages -> 8.1|WP8.1|10
--- End diff --

nit: another JSDoc format issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-29 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/212#discussion_r89996388
  
--- Diff: template/cordova/lib/prepare.js ---
@@ -439,6 +490,109 @@ function getUAPVersions(config) {
 };
 }
 
+/** Checks if a targetProject matches splashscreen target name */
+function splashScreenTargetProjectMatchesTargetName(targetProject, 
targetName) {
+if (targetName === SPLASH_SCREEN_DESKTOP_TARGET_NAME) {
+return targetProject === TARGET_PROJECT_81 || targetProject === 
TARGET_PROJECT_10;
+}
+
+return targetProject === TARGET_PROJECT_WP81;
+}
+
+/** Checks if the splash screen matches the target project
+ * @param targetName 'SplashScreen'|'SplashScreenPhone'
+ * @returns boolean */ 
+function splashScreenTargetIs(splash, targetName) {
+var matchesTarget, targetImg;
+
+if (splash.target) {
+// MRT syntax:
+matchesTarget = splash.target === targetName;
+} else {
+// Fall back on find by size for old non-MRT syntax:
+targetImg = findPlatformImage(splash.width, splash.height);
+matchesTarget = 
splashScreenTargetProjectMatchesTargetName(targetImg.targetProject, targetName);
+}
+
+return matchesTarget;
+}
+
+// Updates manifests to match the app splash screen image types 
(PNG/JPG/JPEG)
+function updateSplashScreenImageExtensions(cordovaProject, locations) {
+
+// Saving all extensions used for targets to verify them later
+var extensionsUsed = {};
+
+function checkThatExtensionsAreNotMixed() {
+for (var target in extensionsUsed) {
+/*jshint loopfunc: true */
+if (extensionsUsed.hasOwnProperty(target)) {
+var extensionsUsedForTarget = extensionsUsed[target];
+
+// Check that extensions are not mixed:
+if (extensionsUsedForTarget.length > 1 && 
extensionsUsedForTarget.some(function(item) {
+return item !== extensionsUsedForTarget[0];
+})) {
+events.emit('warn', '"' + target + '" splash screens 
have mixed file extensions which is not supported. Some of the images will not 
be used.');
+}
+}
+}
+}
+
+function checkTargetMatchAndUpdateUsedExtensions(img, target) {
+var matchesTarget = splashScreenTargetIs(img, target);
+
+if (matchesTarget === true) {
+extensionsUsed[target] = extensionsUsed[target] || [];
+
extensionsUsed[target].push(path.extname(img.src.toLowerCase()));
+}
+
+return matchesTarget;
+}
+
+function updateSplashExtensionInManifest(manifestFileName, 
splashScreen) {
+var manifest = AppxManifest.get(path.join(locations.root, 
manifestFileName));
+var newExtension = path.extname(splashScreen.src);
+
+if (manifest.getVisualElements().getSplashScreenExtension() !== 
newExtension) {
+events.emit('verbose', 'Set ' + manifestFileName + ' 
SplashScreen image extension to "' + newExtension + '"');
+
manifest.getVisualElements().setSplashScreenExtension(newExtension);
+manifest.write();
+}
+}
+
+var splashScreens = 
cordovaProject.projectConfig.getSplashScreens('windows');
+
+var desktopSplashScreen = splashScreens.filter(function(img) { 
+return checkTargetMatchAndUpdateUsedExtensions(img, 
SPLASH_SCREEN_DESKTOP_TARGET_NAME);
+})[0];
+
+var phoneSplashScreen = splashScreens.filter(function(img) { 
+return checkTargetMatchAndUpdateUsedExtensions(img, 
SPLASH_SCREEN_PHONE_TARGET_NAME);
+})[0];
+
+checkThatExtensionsAreNotMixed();
--- End diff --

> You should not mix image extensions for non-MRT syntax inside one project 
group

I thought it's pretty obvious :)

> in this case ^ the second JPG image will not be used as AppxManifest will 
have PNG for SplashScreen.Image' extension

Yep. If you specify the same splascreens using MRT and 'target' attribute, 
`splashscreen.scale-125.jpg` also would be silently ignored because 
`mapImageResources` requires extensions to match. That said I don't think we 
need to care about this at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To

[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...

2016-11-29 Thread daserge

Github user daserge commented on the issue:

https://github.com/apache/cordova-windows/pull/212
  
@vladimir-kotikov could you please take a look again?
I've also added a fix for [CB-12192 - No SplashScreen on Windows when 
content.src is subpage](https://issues.apache.org/jira/browse/CB-12192) - the 
issue occured while testing splashscreen API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine pull request #24: CB-10228:(iOS) AppendUserA...

2016-11-29 Thread kelvinhokk

GitHub user kelvinhokk opened a pull request:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24

CB-10228:(iOS) AppendUserAgent not working with WKWebView



### Platforms affected
iOS: Currently the wkWebview users the default user agent, ignoring 
Cordova's OverrideUserAgent and AppendUserAgent in config.xml

### What does this PR do?
This attempts to set the customUserAgent property of the wkWebview to what 
is already computed in the CDVViewController

### What testing has been done on this change?
Npm tests have been run.  User agents verified changed on Cordova iOS 4.3.0 
and Cordova 6.4.0.

### Checklist
- [ X] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kelvinhokk/cordova-plugin-wkwebview-engine 
master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit 8014757681d79fc83d96bff00ca1b262f0b4b25b
Author: kelvinho 
Date:   2016-11-29T09:20:02Z

CB-10228:(iOS) AppendUserAgent not working with WKWebView




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Hello again!

2016-11-29 Thread alsorokin

Hi again Filip, you are most welcome!

>> - cordova-paramedic configs are pulled from cordova-medic repo. 
>> (?) requires an extra pull in CI.
Yeah. This is kind of rudimentary thing, I think we can safely transfer them to 
cordova-paramedic repo. This will require some Jenkins jobs changes, I can 
assist with that.

> >  - paramedic setup for individual plugins install latest HEAD of 
> > master of platform code (at least, cordova-android + device plugin)
What makes you think so? I double-checked, our current CI setup for per-PR jobs 
is using the released versions of all the platforms. Master versions are used 
only for periodic build.

> >  - there are plugins tests that run via a jenkins instance on 
> > cloudapp.net, and there are travis tests too. travis is pull-req 
> > triggered, cloud app runs nightly. why?
Regarding cloudapp (Jenkins) builds:
The goal of nightly tests is to verify the master versions of plugins against 
the master versions of platforms and CLI. We also run per-PR jobs against the 
released versions of platform and CLI, you can find them here:
http://cordova-ci.cloudapp.net:8080/view/Pull%20requests/

Feel free to contact me via email or Slack if you have any questions regarding 
our current CI setup or need an assistance.

Thanks,
Alexander Sorokin

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com] 
Sent: Monday, November 28, 2016 11:00 PM
To: dev@cordova.apache.org
Subject: Re: Hello again!

Welcome back!


@purplecabbage
risingj.com

On Mon, Nov 28, 2016 at 11:50 AM, Simon MacDonald  wrote:

> Never heard of this guy.
> Simon Mac Donald
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsimonm
> acdonald.com=02%7C01%7Cv-alsoro%40microsoft.com%7Cdcdee276682a4ff
> 9353408d417c92e87%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6361596
> 00215033744=zPpzT0F5p5rlW71wFWe0DtB2cG8rednMPQyiqtUw%2BZg%3D
> erved=0
>
>
> On Mon, Nov 28, 2016 at 2:48 PM, Filip Maj  wrote:
> > Hi everyone!
> >
> > Just wanted to (re)introduce myself after a 3 year or so hiatus :)
> >
> > I used to be an active member of the group between 2011 and 2013 
> > when I was on the Adobe PhoneGap team. I took a 3 year detour 
> > focusing on mobile testing infrastructure at Sauce Labs, but 
> > recently rejoined the Adobe PhoneGap team. I have been lurking more 
> > intently on this list for the past month or so and aim to be more involved 
> > these days.
> >
> > I've been poking around and getting my bearings around the testing 
> > suites, infrastructure and CI in Cordova the past week or so. I 
> > think I will try to contribute in that area initially. In 
> > particular, I am interested in enabling functional end-to-end 
> > testing for all repos in cordova that could benefit from that sort 
> > of testing, and seamlessly integrating running the tests and 
> > reporting their results back into the standard Cordova dev workflow 
> > (I assume that is focussed around GitHub?). I see there are 
> > different kinds of test coverage and CI systems at play (cloudapp, 
> > travis, appveyor, plus unit and functional tests), so initially just 
> > wrapping my head around all that.
> >
> > If anyone here has suggestions on areas that need work, have 
> > grievances around how they are frustrated by manually needing to 
> > test something, or having any other helpful tips on what needs work 
> > or what could be improved, feel free to reply to this thread!
> >
> > My generic notes on this topic so far, in case that is helpful:
> >
> > cordova testing overview
> > ———
> > notes / weird things:
> >  - cordova-paramedic configs are pulled from cordova-medic repo. (?) 
> > requires an extra pull in CI.
> >  - paramedic setup for individual plugins install latest HEAD of 
> > master of platform code (at least, cordova-android + device plugin)
> >  - there are plugins tests that run via a jenkins instance on 
> > cloudapp.net, and there are travis tests too. travis is pull-req 
> > triggered, cloud app runs nightly. why?
> >
> > road to testing utopia:
> >  - how do platforms get tested? integration tests with what: tooling?
> plugins?
> >- unit tests run on travis/appveyor?
> >- understand what needs to be tested for a release. work 
> > backwards to automate that from there. Steve sent some helpful links my way:
> >  - platform:
> > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
> > hub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2F=02%7C
> > 01%7Cv-alsoro%40microsoft.com%7Cdcdee276682a4ff9353408d417c92e87%7C7
> > 2f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636159600215033744=q
> > oBxneF1%2FwzJTPwFxp7CsvbdEUUq8u5ALYCqXbjyuzM%3D=0
> platforms-release-process.md#testing
> >  - plugins:
> > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
> > hub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2F=02%7C
> >

[GitHub] cordova-plugin-device issue #58: CB-12199: (android) Add SDK version propert...

[GitHub] cordova-plugin-device pull request #58: CB-12199: (android) Add SDK version ...

Nightly build #242 for cordova has succeeded!

[GitHub] cordova-plugin-wkwebview-engine pull request #23: CB-11997: Add crash recove...

[GitHub] cordova-plugin-wkwebview-engine pull request #23: CB-11997: Add crash recove...

[GitHub] cordova-plugin-wkwebview-engine issue #24: CB-10228:(iOS) AppendUserAgent no...

[GitHub] cordova-plugin-inappbrowser issue #73: Added editablelocation option for and...

[GitHub] cordova-plugin-inappbrowser issue #73: Added editablelocation option for and...

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Re: Hello again!

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

[DISCUSSION] Windows tag, what should it be doing?

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

[GitHub] cordova-plugin-file-transfer issue #170: CB-12154 file-transfer progressEven...

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...

[GitHub] cordova-plugin-wkwebview-engine pull request #24: CB-10228:(iOS) AppendUserA...

RE: Hello again!

28 matches

Site Navigation

Mail list logo

Footer information