[GitHub] cordova-plugin-contacts issue #144: [Appium] Add support for iOS' XCUITest a...

2016-12-15 Thread alsorokin 
Github user alsorokin commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/144
  
Looks good to me! :shipit: 
I wonder why didn't I use getting elements by accessibility id right from 
the start...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-15 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r92756760
  
--- Diff: cordova-lib/spec-cordova/helpers.js ---
@@ -148,7 +148,7 @@ module.exports.writeConfigContent = function (appPath, 
configContent) {
 
 // Add the toExist matcher.
 beforeEach(function () {
-this.addMatchers({
+jasmine.addMatchers({
 'toExist': function () {
--- End diff --

I rewrote `toExist` with the new [custom matcher 
syntax](https://jasmine.github.io/2.0/custom_matcher.html). This should fix 
some of your failing specs. 

Replace this `toExist` with:

```
jasmine.addMatchers({
'toExist': function () {
return {
compare: function(actual, expected) {
var notText = this.isNot ? ' not' : '';
var result = {};

result.pass = fs.existsSync(actual);

if(result.pass) {
result.message = "expected " + actual + " to not 
exist";
} else {
result.message = "expected " + actual + " to exist";
}

return result;
}
}
}
});
```




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] Plugins Release (Dec 12th 2016)

2016-12-15 Thread Filip Maj 
I vote +1:
 - successfully created android and ios projects with the plugins
 - ran through the manual tests for both plugins on Android 5.1 and
iOS 9.3 emusims.

On Thu, Dec 15, 2016 at 2:13 AM,   wrote:
> I vote +1
>
> * Verified signatures and hashes
> * Verified tags
> * Verified that plugins can be added correctly to blank app
> * Verified that blank app can be successfully built and ran (windows, ios and 
> android)
> * Verified that browserified app can be successfully built and ran (windows, 
> ios and android)
> * Ran smoke testing of paramedic app (windows, ios and android)
>
> -Original Message-
> From: Shazron [mailto:shaz...@apache.org]
> Sent: Wednesday, December 14, 2016 11:35 PM
> To: dev@cordova.apache.org
> Subject: [VOTE] Plugins Release (Dec 12th 2016)
>
> Please review and vote on the release of this plugins release by replying to 
> this email (and keep discussion on the DISCUSS thread)
>
> Release issue: 
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-12237=02%7C01%7Cv-alsoro%40microsoft.com%7C0aad75fd82434a2f2fa008d42460cc10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636173445531475387=dXJxLumDRghnCq3LfybY3ru%2ByIe2t%2FTlWthNDn2IHkU%3D=0
>
> The plugins have been published to dist/dev:
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-12237%2F=02%7C01%7Cv-alsoro%40microsoft.com%7C0aad75fd82434a2f2fa008d42460cc10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636173445531475387=JnMywcZKS1gAGjNeJ%2BeEEktHPxDD6tmZuR9hc4l938Q%3D=0
>
> The packages were published from their corresponding git tags:
> cordova-plugin-inappbrowser: 1.6.1 (b6e575be32)
> cordova-plugin-battery-status: 1.2.2 (ee2388710d)
>
> Upon a successful vote I will upload the archives to dist/, upload them to 
> npm, and post the corresponding blog post.
>
> Voting guidelines:
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting.md=02%7C01%7Cv-alsoro%40microsoft.com%7C0aad75fd82434a2f2fa008d42460cc10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636173445531475387=yqsclPrWPStZ49EH4QeY88ULbU7sLmLPFCgOm3h%2BC8U%3D=0
>
> How to vote on a plugins release at
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Fplugins-release-process.md%23voting=02%7C01%7Cv-alsoro%40microsoft.com%7C0aad75fd82434a2f2fa008d42460cc10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636173445531475387=L%2BvUXLPr9qWtslHcjQDKnUMP2pnNw0R0%2FXqsRl%2F9b%2Fs%3D=0
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies have 
> Apache-compatible licenses
> * Ensured continuous build was green when repos were tagged
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts issue #144: [Appium] Add support for iOS' XCUITest a...

2016-12-15 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/144
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/144/commits/58d4612f90682453fa59329892440738c73c842b)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/68//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts issue #144: [Appium] Add support for iOS' XCUITest a...

2016-12-15 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/144
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/144/commits/5f1069a1b53ceae109084381ceebefcbe0900daa)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/67//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #73: CB-12141 (ios) fix white app scre...

2016-12-15 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/73


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #72: Update plugin.xml

2016-12-15 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/72


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #73: CB-12141 (ios) fix white app screen afte...

2016-12-15 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/73
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/73/commits/579a5a692b718a4bcabb255d9e4a7b59b3334b1d)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/39//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts issue #144: [Appium] Add support for iOS' XCUITest a...

2016-12-15 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/144
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/144/commits/35876c1f65add9872e26c7e6927d37230a53350d)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/66//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #73: CB-12141 (ios) fix white app scre...

2016-12-15 Thread jcesarmobile 
GitHub user jcesarmobile opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/73

CB-12141 (ios) fix white app screen after camera overlay shown on iPad



### Platforms affected
iOS

### What does this PR do?
fix white app screen after camera overlay shown on iPad.
removes all the hackish code we added to fix specific cases, this simpler 
code seems to fix all of them.

### What testing has been done on this change?


### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jcesarmobile/cordova-plugin-statusbar 
CB-12141-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #73


commit 579a5a692b718a4bcabb255d9e4a7b59b3334b1d
Author: Julio César 
Date:   2016-12-08T23:18:23Z

CB-12141




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-15 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r92713582
  
--- Diff: cordova-lib/spec-cordova/HooksRunner.spec.js ---
@@ -472,7 +472,7 @@ describe('HooksRunner', function() {
 hookOptions.nohooks = ['before_build'];
 
 return hooksRunner.fire(test_event, 
hookOptions).then(function (msg) {
-expect(msg).toBeDefined();
+expect(msg).toExist();
--- End diff --

looks like some of these were originally toBeDefinied. 475, 512, 538, 548, 
641


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts issue #144: [Appium] Add support for iOS' XCUITest a...

2016-12-15 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/144
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/144/commits/2de7bfea3fc49774b1472f7a2af9af0cbc3aca10)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/65//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Schedule to drop iOS 8 support in cordova-ios@5.x

2016-12-15 Thread Shazron 
This removal of iOS 8 support will be for cordova-ios@4.4.0 (in the new
year) and not cordova-ios@5.0.0 -- to coincide with the node 0.x removal as
well.

I'm not sure this is a "breaking" change.

On Sat, Nov 5, 2016 at 7:15 AM, Simon MacDonald 
wrote:

> +1
> I've created an issue on the push plugin as well. I can finally retire
> that iPhone 4 with iOS 8 when this is done.
>
> Simon Mac Donald
> http://simonmacdonald.com
>
>
> On Sat, Nov 5, 2016 at 7:57 AM, julio cesar sanchez
>  wrote:
> > +1
> > Still have my iPad 2 with iOS 8, so let me know if you need any help with
> > testing/fixing something for iOS 8 before removing the support.
> >
> > 2016-11-05 1:52 GMT+01:00 Jesse :
> >
> >> Sooner would be better, but I'll take it.
> >>
> >>
> >> @purplecabbage
> >> risingj.com
> >>
> >> On Fri, Nov 4, 2016 at 2:20 PM, Shazron  wrote:
> >>
> >> > We've always only supported the currently released iOS, and the
> previous
> >> > iOS release because of test device OS constraints. Currently our
> support
> >> is
> >> > for iOS 10 and iOS 9. iOS 9+10 support is at 92% of users according to
> >> > Apple: https://developer.apple.com/support/app-store/
> >> >
> >> > Coinciding with the drop of node 0.x support (see
> >> > http://cordova.apache.org/news/2016/10/01/0.x-4.x-
> >> > deprecation-timeline.html)
> >> > which we are bumping a major version of the platform for, we will drop
> >> iOS
> >> > 8 support at the same time.
> >> >
> >> > The timeframe for cordova-ios@5.0 release containing these two
> changes
> >> > (among others) is Jan 2017.
> >> >
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-15 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r92707789
  
--- Diff: cordova-lib/package.json ---
@@ -20,15 +20,16 @@
   "dependencies": {
 "aliasify": "^1.7.2",
 "cordova-common": "1.5.x",
-"cordova-fetch": "^1.0.1",
 "cordova-create": "^1.0.1",
+"cordova-fetch": "^1.0.1",
 "cordova-js": "4.2.0",
 "cordova-registry-mapper": "1.x",
 "cordova-serve": "^1.0.0",
 "dep-graph": "1.1.0",
 "elementtree": "0.1.6",
 "glob": "^5.0.3",
 "init-package-json": "^1.2.0",
+"jasmine": "^2.5.2",
--- End diff --

same as my previous comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-15 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r92707699
  
--- Diff: cordova-common/package.json ---
@@ -28,6 +28,7 @@
 "cordova-registry-mapper": "^1.1.8",
 "elementtree": "^0.1.6",
 "glob": "^5.0.13",
+"jasmine": "^2.5.2",
--- End diff --

can you move this down to devDependencies instead and also remove 
jasmine-node from there


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-15 Thread audreyso 
Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r92707427
  
--- Diff: cordova-lib/spec-cordova/build.spec.js ---
@@ -67,7 +67,7 @@ describe('build command', function() {
 describe('success', function() {
 it('should run inside a Cordova-based project with at least one 
added platform and call both prepare and compile', function(done) {
 cordova.raw.build(['android','ios']).then(function() {
-var opts = {verbose: false, platforms: ['android', 'ios'], 
options: []};
+var opts = Object({ platforms: [ 'android', 'ios' ], 
verbose: false, options: Object({  }) })
--- End diff --

Wasn't sure about this change because the expect was failing... and 
expecting what I changed here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request #144: [Appium] Add support for iOS' XCU...

2016-12-15 Thread filmaj 
GitHub user filmaj opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/144

[Appium] Add support for iOS' XCUITest automation library

Please review @alsorokin !

### Platforms affected

iOS.

### What does this PR do?

When running UI automation tests in iOS, if you are running Xcode 8 or 
newer (which you must have to run tests on iOS 10), you _must_ leverage Apple's 
new UI automation framework, XCUITest. The current tests are written assuming 
the older iOS UI automation framework, UIAutomation. 

These changes move the appium test code so it is compatible with both:
 - 9.3 and earlier iOS automation framework, UIAutomation
 - 10.0+ iOS automation framework, XCUITest

The main changes include:
 - leverages finding elements in native iOS land using the name selector, 
which also happens to be faster than XPath selectors. This was required as the 
test case for Unicode-based elements with XPath-based selection did _not_ work 
under XCUITest.
 - Appium has a handy capability called "autoAcceptDialogs" which [by 
default we 
use](https://github.com/apache/cordova-paramedic/blob/master/lib/appium/helpers/wdHelper.js#L80).
 This feature allowed us to not have to worry about automating dismissing the 
native permission dialogs around certain native API device accesses (such as, 
in this plugin's case, contacts or Address Book access). However, this 
capability is no longer supported under XCUITest. Thus, the code changes 
included here also offer a transitionary method of explicitly automating 
dismissing this dialog. It is robust enough to be able to work with both a 
functioning `autoAcceptDialogs` capability, or not. Comments are included to 
give hints on when the functionality could be simplified (once we move to iOS 
10+ only).

### What testing has been done on this change?

Tested and working on local Xcode 8.1 + Appium 1.6.3 environment, on the 
following simulators:
 - iOS 9.3 iPhone 6S Plus
 - iOS 10.0 iPhone 6S Plus
 - iOs 10.1 iPhone 6S Plus

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/filmaj/cordova-plugin-contacts 
xcuitest-support

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #144


commit 2de7bfea3fc49774b1472f7a2af9af0cbc3aca10
Author: filmaj 
Date:   2016-12-15T21:12:01Z

[Appium] Add forward-compatibility support for XCUITest automation in iOS. 
Is backwards-compatible with UIAutomation-based test runs. Leverages finding 
elements in native iOS land using the name selector, which also happens to be 
faster than XPath selectors.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins Release Dec 12th, 2016

2016-12-15 Thread Shazron 
Ping pong. Need one more vote to wrap this up tomorrow before the weekend :D

On Wed, Dec 14, 2016 at 1:21 PM, Filip Maj  wrote:

> +1
>
> On Wed, Dec 14, 2016 at 12:19 PM, julio cesar sanchez
>  wrote:
> > +1
> >
> > 2016-12-14 20:01 GMT+01:00 Shazron :
> >
> >> Two plugins that were omitted from the last released are planned for
> this
> >> one:
> >> 1) Updates in cordova-plugin-battery-status that we discussed
> (--browserify
> >> fixes for Windows)
> >> 2) The package.json update in cordova-plugin-inappbrowser (same version,
> >> 1.6.0)
> >>
> >> cordova-plugin-screen-orientation release has been postponed for the
> next
> >> one.
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugin-splashscreen issue #109: CB-11602: (android) Fix bug AutoHide...

2016-12-15 Thread daserge 
Github user daserge commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/109
  
@jcesarmobile, @infil00p, @kerrishotts could you please also take a look if 
you have a chance?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #125: CB-9445 Improves executeScript callb...

2016-12-15 Thread yggi49 
Github user yggi49 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/125
  
@wanjochan @bash88 @mathiasmuller4sh I had the same problem, and after some 
research I finally found one possible culprit: If the site within the 
inAppBrowser is served via HTTPS and sends a `Content-Security-Policy` header, 
make sure that the `default-src` directive contains the `gap:` and `gap-iab:` 
schemes.  That solved it for me.

http://stackoverflow.com/a/41170752/192916


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: (CB-12241) Cordova Device plugin: device.serial value does not match the phone's serial number

2016-12-15 Thread Kerri Shotts 
Thanks all! I’ve closed the issue.

~ Kerri

> On Dec 15, 2016, at 01:02, Jesse  wrote:
> 
> I am replying on the issue in JIRA, because there is no way to know if the
> issue creator is on the dev list, and these replies don't seem to make it
> back.
> 
> 
> 
> @purplecabbage
> risingj.com
> 
> On Wed, Dec 14, 2016 at 8:13 PM, Kerri Shotts  wrote:
> 
>> Please see https://issues.apache.org/jira/browse/CB-12241 <
>> https://issues.apache.org/jira/browse/CB-12241>.
>> 
>> Based on a quick Google search, I turned this up:
>> http://stackoverflow.com/questions/14161282/serial-
>> number-from-samsung-device-running-android > questions/14161282/serial-number-from-samsung-device-running-android>,
>> which implies there’s no standard here, which would make creating a
>> solution that works correctly all the time problematic and a bug magnet (to
>> me, anyway). Given that, I’m inclined to close this issue as “not a
>> problem” and suggest the user fork as needed.
>> 
>> BUT, I’m far from an android expert, so thought I would ask for any
>> Android dev’s out there and see what they think. Thoughts on leaving the
>> bug open or closing it?
>> 
>> ~ Kerri
>> 
>>

[GitHub] cordova-windows pull request #218: CB-12238 [Windows] Colorize titlebar to m...

2016-12-15 Thread vladimir-kotikov 
Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/218#discussion_r92604767
  
--- Diff: cordova-js-src/splashscreen.js ---
@@ -203,10 +212,30 @@ function enableUserInteraction() {
 document.body.style['-ms-content-zooming'] = origZooming;
 }
 
+// Make title bg color match splashscreen bg color
+function colorizeTitleBar() {
+var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
+if (appView.titleBar) {
+titleInitialBgColor = appView.titleBar.backgroundColor;
+
+appView.titleBar.backgroundColor = titleBgColor;
+appView.titleBar.buttonBackgroundColor = titleBgColor;
+}
+}
+
+// Revert title bg color
+function revertTitleBarColor() {
+var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
+if (appView.titleBar) {
--- End diff --

Is this guaranteed that title bar would exist when you're leaving 
fullscreen? otherwise you may end up not reverting title bar color due to this 
condition. I'm mostly speculating and trying to find really edge cases, but 
still.
Perhaps might be better to subscribe to 
[`ApplicationView.VisibleBoundsChanged`](https://msdn.microsoft.com/en-us/library/windows/apps/windows.ui.viewmanagement.applicationview.visibleboundschanged.aspx)
 and revert the color in the handler?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

2016-12-15 Thread vladimir-kotikov 
Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/216#discussion_r92601539
  
--- Diff: cordova-js-src/splashscreen.js ---
@@ -30,7 +30,8 @@ var schema = (isHosted || isWin10UWP && isMsAppxWeb) ? 
'ms-appx-web' : 'ms-appx'
 var fileName = isPhone ? 'splashscreenphone.png' : 'splashscreen.png';
 var splashImageSrc = schema + ':///images/' + fileName;
 
-var splashElement = null, extendedSplashImage = null, 
extendedSplashProgress = null;
+var splashElement = null, extendedSplashImage = null, 
extendedSplashProgress = null,
--- End diff --

nit: please put each definition on its own line - IMO it's be much easier 
to read


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

2016-12-15 Thread vladimir-kotikov 
Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/216#discussion_r92603101
  
--- Diff: cordova-js-src/splashscreen.js ---
@@ -148,29 +152,27 @@ function init(config, manifest) {
 extendedSplashProgress.classList.add('win-medium');
 extendedSplashProgress.classList.add('win-ring');
 
+extendedSplashImage.style.maxWidth = "100%";
+extendedSplashImage.style.maxHeight = "100%";
+extendedSplashImage.src = splashImageSrc;
+
 if (isWp81 || isWp10) {
-extendedSplashImage.style.maxWidth = "100%";
-extendedSplashImage.style.maxHeight = "100%";
-extendedSplashImage.src = splashImageSrc;
 // center horizontally
 extendedSplashImage.style.margin = "0 auto";
-extendedSplashImage.style.display = "block";
+extendedSplashImage.style.display = "inline-block";
--- End diff --

Can we move this to CSS using the same technique as for 
`extendedSplashProgress` (additional css classes based on whether we're running 
on desktop/phone)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

2016-12-15 Thread vladimir-kotikov 
Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/216#discussion_r92602532
  
--- Diff: cordova-js-src/splashscreen.js ---
@@ -148,29 +152,27 @@ function init(config, manifest) {
 extendedSplashProgress.classList.add('win-medium');
 extendedSplashProgress.classList.add('win-ring');
 
+extendedSplashImage.style.maxWidth = "100%";
--- End diff --

Could you please explain, what's the point in having `maxWidth` and 
`maxHeight`  defined twice - here and in css file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

2016-12-15 Thread vladimir-kotikov 
Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/216#discussion_r92601889
  
--- Diff: cordova-js-src/splashscreen.js ---
@@ -148,29 +152,27 @@ function init(config, manifest) {
 extendedSplashProgress.classList.add('win-medium');
 extendedSplashProgress.classList.add('win-ring');
 
+extendedSplashImage.style.maxWidth = "100%";
+extendedSplashImage.style.maxHeight = "100%";
+extendedSplashImage.src = splashImageSrc;
+
 if (isWp81 || isWp10) {
--- End diff --

nit: Maybe change this condition to `if (isPhoneDevice) {...` where 
`isPhoneDevice = isWp81 || isWp10` - just to improve readability


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #109: CB-11602: (android) Fix bug AutoHide...

2016-12-15 Thread daserge 
Github user daserge commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/109
  
@nbabanov thanks for the contribution and sorry it took so long to review 
this.

Could you please describe your scenario - I could not reproduce the issue 
with latest cordova-android and master version of crosswalk-webview (splash 
gets hidden when I press Home or Power button with or without this change).
How do you get the activity to be paused?

As an alternative I can suggest to listen to onRestart event and restore 
the previous splash screen state - I would be grateful if you could test 
whether this works for you:
https://github.com/daserge/cordova-android/tree/CB-11602
https://github.com/daserge/cordova-plugin-splashscreen/tree/CB-11602


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [VOTE] Plugins Release (Dec 12th 2016)

2016-12-15 Thread alsorokin 
I vote +1

* Verified signatures and hashes
* Verified tags
* Verified that plugins can be added correctly to blank app
* Verified that blank app can be successfully built and ran (windows, ios and 
android)
* Verified that browserified app can be successfully built and ran (windows, 
ios and android)
* Ran smoke testing of paramedic app (windows, ios and android)

-Original Message-
From: Shazron [mailto:shaz...@apache.org] 
Sent: Wednesday, December 14, 2016 11:35 PM
To: dev@cordova.apache.org
Subject: [VOTE] Plugins Release (Dec 12th 2016)

Please review and vote on the release of this plugins release by replying to 
this email (and keep discussion on the DISCUSS thread)

Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-12237=02%7C01%7Cv-alsoro%40microsoft.com%7C0aad75fd82434a2f2fa008d42460cc10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636173445531475387=dXJxLumDRghnCq3LfybY3ru%2ByIe2t%2FTlWthNDn2IHkU%3D=0

The plugins have been published to dist/dev:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-12237%2F=02%7C01%7Cv-alsoro%40microsoft.com%7C0aad75fd82434a2f2fa008d42460cc10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636173445531475387=JnMywcZKS1gAGjNeJ%2BeEEktHPxDD6tmZuR9hc4l938Q%3D=0

The packages were published from their corresponding git tags:
cordova-plugin-inappbrowser: 1.6.1 (b6e575be32)
cordova-plugin-battery-status: 1.2.2 (ee2388710d)

Upon a successful vote I will upload the archives to dist/, upload them to npm, 
and post the corresponding blog post.

Voting guidelines:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting.md=02%7C01%7Cv-alsoro%40microsoft.com%7C0aad75fd82434a2f2fa008d42460cc10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636173445531475387=yqsclPrWPStZ49EH4QeY88ULbU7sLmLPFCgOm3h%2BC8U%3D=0

How to vote on a plugins release at
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Fplugins-release-process.md%23voting=02%7C01%7Cv-alsoro%40microsoft.com%7C0aad75fd82434a2f2fa008d42460cc10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636173445531475387=L%2BvUXLPr9qWtslHcjQDKnUMP2pnNw0R0%2FXqsRl%2F9b%2Fs%3D=0

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Ensured continuous build was green when repos were tagged


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org