[GitHub] cordova-plugin-wkwebview-engine issue #5: CB-10817 The webView should reload...

[alexfoxy]

Github user alexfoxy commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5
  
Do you think it would be possible to show the launch screen when this 
happens to provide a more seamless experience? For example my app sometimes 
experiences a crash when you open it from the background resulting in a white 
screen flashing up for a few seconds. Perhaps we could fire an event via the 
notification centre when a crash is detected? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #265: CB-12018 : updated tests to function with jasmine in...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-cli/pull/265
  
Yeah, not a big deal and probably not worth renaming all test cases back 
now, It just reminded me file transfer tests where we have 'spec.11' then 
`spec.9` then `spec.10`, etc. :) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/510


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #355: CB-12018 : updated tests to work with jasmine (p...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/355
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/355?src=pr) is 
35.58% (diff: 100%)
> Merging 
[#355](https://codecov.io/gh/apache/cordova-android/pull/355?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #355   diff @@
==
  Files12 12  
  Lines  1037   1037  
  Methods 205205  
  Messages  0  0  
  Branches173173  
==
  Hits369369  
  Misses  668668  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[c7ff24b...b504dc4](https://codecov.io/gh/apache/cordova-android/compare/c7ff24b98397bff389a7bf1fd5fef96a3602cab1...b504dc4ec2c1bf95e8f3cc3f8ae46b9b49e45ce7?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #265: CB-12018 : updated tests to function with jasmine in...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-cli/pull/265
  
@vladimir-kotikov hey! You make a good point about it being annoying to add 
tests later and have to update all the numbers. And I agree the stack trace is 
more useful. We ran into issues where the stack trace wasn't useful (especially 
with Q errors). That is why Audrey started labeling tests. 

I'm not too concerned with the numbers staying in order. If it does become 
annoying, we will go remove it. 

Appreciate your feedback :)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/265


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #287: Delete the correct build output folder

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/287
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-ios/pull/287?src=pr) is 64.11% 
(diff: 0.00%)
> Merging [#287](https://codecov.io/gh/apache/cordova-ios/pull/287?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #287   diff @@
==
  Files12 12  
  Lines  1360   1360  
  Methods 208208  
  Messages  0  0  
  Branches229230 +1   
==
  Hits872872  
  Misses  488488  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[6df46b7...1a6c4ed](https://codecov.io/gh/apache/cordova-ios/compare/6df46b7bad8da2f49560389a38a6d3929fabfe01...1a6c4edb527fcc9cbcaf43e299f5e8c117e335d4?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #287: Delete the correct build output folder

[dpogue]

GitHub user dpogue opened a pull request:

https://github.com/apache/cordova-ios/pull/287

Delete the correct build output folder

JIRA is down, so no JIRA ticket 🙊 

### Platforms affected
iOS (Simulator, mostly)

### What does this PR do?
Ensures that when building for the simulator, device builds are not deleted.

### What testing has been done on this change?
All unit tests passing.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpogue/cordova-ios build-dir-clean

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/287.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #287


commit 1a6c4edb527fcc9cbcaf43e299f5e8c117e335d4
Author: Darryl Pogue 
Date:   2017-01-11T18:59:20Z

Delete the correct build output folder




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/265#discussion_r95645698
  
--- Diff: spec/cli.spec.js ---
@@ -134,11 +134,11 @@ describe("cordova cli", function () {
 
 describe("create", function () {
 beforeEach(function () {
-spyOn(cordova.raw, "create").andReturn(Q());
-spyOn(cordova_lib, "CordovaError");
+spyOn(cordova.raw, "create").and.returnValue(Q());
+// spyOn(cordova_lib, "CordovaError");
--- End diff --

yes @stevengill ... it gives this error
``` Error:  : CordovaError is not declared writable or has no 
setter
Usage: spyOn(, ) ```
Is this line still needed? I tried using this to fix it, but that did not 
work.
``` Object.defineProperty(cordova_lib, "CordovaError", { writable: true }); 
```

I've seen some people fix it like this too, but not sure if this is correct.

```   var descriptor = Object.getOwnPropertyDescriptor(obj, methodName);
 if (!(descriptor.writable || descriptor.set)) {
throw new Error(methodName + ' is not declared writable or has no setter');
} ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/265#discussion_r95635545
  
--- Diff: package.json ---
@@ -11,8 +11,8 @@
 "cordova": "./bin/cordova"
   },
   "scripts": {
-"test": "node node_modules/jasmine-node/bin/jasmine-node 
--captureExceptions --color spec",
-"cover": "node node_modules/istanbul/lib/cli.js cover --root src 
--print detail node_modules/jasmine-node/bin/jasmine-node -- spec"
+"test": "jasmine --captureExceptions --color",
+"cover": "jasmine"
--- End diff --

Thank you! Updated to ...  ``` "cover": "istanbul cover --root src --print 
detail jasmine" ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r95627089
  
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function () {
 
 projectsAddedToSpies.forEach(function (spy) {
 expect(spy).toHaveBeenCalled();
+spy.calls.reset();
--- End diff --

Thanks @stevengill ! All comments have been addressed. Let me know if there 
is anything else!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r95625647
  
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function () {
 
 projectsAddedToSpies.forEach(function (spy) {
 expect(spy).toHaveBeenCalled();
+spy.calls.reset();
--- End diff --

I took out all of the resets.. everything still seems to be working when I 
test the file individually and also when I run npm test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #220: CB-12298 [Windows] bundle.appxupload not generat...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-windows/pull/220
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-windows/pull/220?src=pr) is 
76.93% (diff: 0.00%)
> Merging 
[#220](https://codecov.io/gh/apache/cordova-windows/pull/220?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) 
will decrease coverage by **0.06%**

```diff
@@ master   #220   diff @@
==
  Files16 16  
  Lines     2224 +2   
  Methods 415415  
  Messages  0  0  
  Branches438439 +1   
==
  Hits   1711   1711  
- Misses  511513 +2   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[ae433f6...a925ed5](https://codecov.io/gh/apache/cordova-windows/compare/ae433f67579d7ca4dbec8d0da419b66b2a9bccf5...a925ed5b012618cfc21249739dcd636fd6f772fd?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #220: CB-12298 [Windows] bundle.appxupload not ...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-windows/pull/220

CB-12298 [Windows] bundle.appxupload not generated for Windows 10 target



### Platforms affected
Windows

### What does this PR do?
Adds a MSBuild flag to get appxupload generated for Windows 10 release 
builds.

### What testing has been done on this change?
Auto and manual tests

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-windows CB-12298

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #220


commit a925ed5b012618cfc21249739dcd636fd6f772fd
Author: daserge 
Date:   2017-01-11T15:06:52Z

CB-12298 [Windows] bundle.appxupload not generated for Windows 10 target




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #171: CB-12336 (android) Do not call win ...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/171
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/171/commits/27b10b89fb5fdf9a1927746f7bb764101b84d10b)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=windows-10-store/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=ios/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/52//PLATFORM=android-5.1/artifact/)
 |
 212 tests run, 12 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #171: CB-12336 (android) Do not call win ...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/171
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/171/commits/c218b26b32e7372e522996f792344daff242c490)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=windows-10-store/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=ios/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/51//PLATFORM=android-5.1/artifact/)
 |
 212 tests run, 12 skipped, 1 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #674: CB-8486 Corrected the docs on signing

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-docs/pull/674

CB-8486 Corrected the docs on signing



### Platforms affected
Windows

### What does this PR do?
- Certificate Thumbprint was being extracted from wrong path
- Documented WindowsStoreIdentityName, WindowsStorePublisherName, 
WindowsStoreDisplayName and windows-packageVersion

### What testing has been done on this change?
Previewed markdown

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-docs CB-8486

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/674.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #674


commit 4018342d36c2bea2a860d9e699ce536972a35ec9
Author: daserge 
Date:   2017-01-11T09:52:53Z

CB-8486 Corrected the docs on signing
Certificate Thumbprint was being extracted from wrong path
Documented WindowsStoreIdentityName, WindowsStorePublisherName, 
WindowsStoreDisplayName and windows-packageVersion




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #248: Fix number for sdk comparison.

[tomchiverton]

Github user tomchiverton commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/248
  
FYI I opened https://issues.apache.org/jira/browse/CB-12343 to track this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-globalization pull request #54: CB-11154 (Windows) Return IAN...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-globalization/pull/54


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-globalization issue #54: CB-11154 (Windows) Return IANA timez...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-globalization/pull/54
  
🚢  it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org