[GitHub] cordova-plugin-inappbrowser issue #206: CB-12320: (iOS) WIP Add support for ...

2017-01-17 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/206
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/206/commits/af70ef3175ca8b60a7ea51d5ae8ab16af6a01d35)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=windows-10-store/artifact/)
 |
| [iOS 9.3]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=ios-9.3/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=ios-9.3/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=ios-9.3/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=ios-9.3/artifact/)
 |
| [iOS 10.0]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=ios-10.0/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=ios-10.0/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=ios-10.0/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=ios-10.0/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/113//PLATFORM=android-5.1/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file issue #199: CB-12355: (iOS) fix FileEntry.file.type

2017-01-17 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/199
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file/pull/199/commits/667ddfa40a4056c40624ba8d5bdac7c8a28ec98c)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=windows-10-store/artifact/)
 |
| [iOS 9.3]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=ios-9.3/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=ios-9.3/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=ios-9.3/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=ios-9.3/artifact/)
 |
| [iOS 10.0]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=ios-10.0/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=ios-10.0/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=ios-10.0/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=ios-10.0/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/50//PLATFORM=android-5.1/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file issue #199: CB-12355: (iOS) fix FileEntry.file.type

2017-01-17 Thread LightZam
Github user LightZam commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/199
  
@stevengill could you help me find a code reviewer, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: iOS: Cordova framework target

2017-01-17 Thread Kevin Hawkins
I guess CB-12050  would be
related, as far as that goes.

On Tue, Jan 17, 2017 at 3:13 PM, Kevin Hawkins <
kevin.hawkins.cord...@gmail.com> wrote:

> I've been long out of the day-to-day happenings of the Cordova project, so
> I apologize if this ground has been covered before; I searched back through
> my archive and didn't immediately see anything related.  I'll see if I can
> keep this description as concise as possible.
>
> For our iOS SDK, we ship a dynamic framework that depends on Cordova.  We
> have consumers who depend on both our framework and directly upon Cordova.
> They would like to be able to manage their Cordova dependency themselves.
> The cleanest way to do this would be if we could both build a
> "Cordova.framework" out of the CordovaLib project, and manage the Cordova
> dependency itself as a dynamic framework.
>
> I know this isn't the way most people consume Cordova—the approach is more
> of a traditional native iOS app with hybrid dependencies.  But it also
> doesn't seem like a huge stretch to provide the additional target in the
> CordovaLib project.  It's something we could probably take a look at
> contributing, but I wanted to float the idea to the list first, to get a
> sense of any reservations.
>
> Thanks!
> Kevin
>
>


iOS: Cordova framework target

2017-01-17 Thread Kevin Hawkins
I've been long out of the day-to-day happenings of the Cordova project, so
I apologize if this ground has been covered before; I searched back through
my archive and didn't immediately see anything related.  I'll see if I can
keep this description as concise as possible.

For our iOS SDK, we ship a dynamic framework that depends on Cordova.  We
have consumers who depend on both our framework and directly upon Cordova.
They would like to be able to manage their Cordova dependency themselves.
The cleanest way to do this would be if we could both build a
"Cordova.framework" out of the CordovaLib project, and manage the Cordova
dependency itself as a dynamic framework.

I know this isn't the way most people consume Cordova—the approach is more
of a traditional native iOS app with hybrid dependencies.  But it also
doesn't seem like a huge stretch to provide the additional target in the
CordovaLib project.  It's something we could probably take a look at
contributing, but I wanted to float the idea to the list first, to get a
sense of any reservations.

Thanks!
Kevin


[GitHub] cordova-windows pull request #221: CB-12018 : updated tests to work with jas...

2017-01-17 Thread audreyso
GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-windows/pull/221

CB-12018 : updated tests to work with jasmine instead of jasmine-node

*Not ready for review yet.. thanks! 



### Platforms affected


### What does this PR do?
Uses jasmine to test instead of jasmine-node.

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-windows CB-12018

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #221


commit 22dff992c90e40df9e7df20596d7a787cbdeae96
Author: audreyso 
Date:   2017-01-17T19:05:25Z

CB-12018 : updated tests to work with jasmine instead of jasmine-node




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #206: CB-12320: (iOS) WIP Add support for ...

2017-01-17 Thread spongessuck
Github user spongessuck commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/206
  
@reidab Thanks, fixed in af70ef3.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #206: CB-12320: (iOS) WIP Add support for ...

2017-01-17 Thread reidab
Github user reidab commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/206
  
Pulled down this PR and in my local testing with `navigationbar=yes` and 
`navigationbuttons=yes` the back/forward buttons appear to be reversed.

![screen shot 2017-01-17 at 12 59 53 
pm](https://cloud.githubusercontent.com/assets/13192/22039629/e5144790-dcb4-11e6-81cc-f6b109f71d3c.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Include TypeScript definitions in plugins

2017-01-17 Thread Котиков Владимир
Hey guys!

I’m excited to see such positive feedback ☺ This sounds like a consensus, so 
we’re going to publish the PRs to the core plugins in a couple of days.

Also, a bit of technical details: 
  - as Mike mentioned, typescript definitions are not necessarily need to be 
placed at the root of package – the package just need to have “types” entry in 
package.json, pointing to the typings location – so the proposed approach is to 
have “types”/”typings” directory at the root with “index.d.ts” file in it
  - the typings in core plugins will coexist with the ones from DefinitelyTyped 
repository – this shouldn’t be a big deal from maintenance perspective as the 
plugin APIs are already stable and I suspect they won’t be changing often. We 
just need to make sure that if anyone changes the public API of the plugin, 
he/she will need to update DefinitelyTyped as well as typings in the plugin.

-
Best regards, Vladimir


On 1/10/17, 05:02, "Steven Gill"  wrote:

DO ITTT

On Mon, Jan 9, 2017 at 5:04 PM, Frederico Galvão <
frederico.gal...@pontoget.com.br> wrote:

> Please do!
>
> 2017-01-09 20:40 GMT-02:00 Mike Hartington :
>
> > Types can be in sub-folder.
> > As long as the type entried just points to the path
> >
> > 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.typescriptlang.org%2Fdocs%2Fhandbook%2Fdeclaration-=02%7C01%7Cv-vlkoti%40microsoft.com%7C7f41d67cc4be48efc86308d438fcbd92%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636196105543207234=hqPuvVmtxIujvkxHMBKOLjcUkblK1SASy68AtA9Nr7k%3D=0
> > files/publishing.html 
 > org/docs/handbook/declaration-files/publishing.html>
> >
> >
> > Mike Hartington
> >
> >
> >
> > > On Jan 9, 2017, at 5:38 PM, Victor Sosa 
> wrote:
> > >
> > > +1... I love this idea! Will help a lot to static analysis tools and
> > IDEs.
> > >
> > > On Mon, Jan 9, 2017 at 3:56 PM Shazron  wrote:
> > >
> > >> Thanks for bringing this up Vladimir,
> > >> +1 -- but does the .ts definition need to be in the root? I'd rather
> it
> > be
> > >> in a subfolder (either an existing one like 'www' or a new one)
> > >>
> > >> On Mon, Jan 9, 2017 at 5:23 AM, Vladimir Kotikov (Akvelon) <
> > >> v-vlk...@microsoft.com> wrote:
> > >>
> > >>> Hey, everybody!
> > >>>
> > >>> I’d like to propose/discuss the idea of redistributing Typescript
> > >>> definitions along with core plugins, so that users who write their
> apps
> > >> in
> > >>> Typescript would get the typings in their projects without 
additional
> > >> mess
> > >>> with 'tsd'/'typings' (these all are the package managers for
> typescript
> > >>> declarations) or manual installation from '@types' NPM org.
> > >>>
> > >>> As mentioned above, our main goal - to reduce the number of
> additional
> > >>> actions needed to either add the plugin to Typescript project or get
> > the
> > >>> types information and intellisense for JavaScript projects. Also,
> this
> > >>> would reduce the number of network calls to other services (typings
> > >>> registry, NPM registry) which are known as common points of denial
> (per
> > >>> telemetry data).
> > >>>
> > >>> The changes are pretty minimal and include adding a d.ts file with
> type
> > >>> definitions (taken from DefinitelyTyped[1]) and 'types' entry to
> > >>> package.json according to Typescript convention [2]. The sample
> > >>> implementation for camera plugin is here: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2F=02%7C01%7Cv-vlkoti%40microsoft.com%7C7f41d67cc4be48efc86308d438fcbd92%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636196105543207234=AIkoLA7FNpc9ZYHmWt5kDcX0OgSY%2FgcRp4GJziC3Pno%3D=0
> > >>> cordova-plugin-camera/compare/master...vladimir-kotikov:add-typings
> > >>>
> > >>> Does anyone have any considerations/objections about this proposal?
> > >>>
> > >>> -
> > >>> [1] 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDefinitelyTyped%2FDefinitelyTyped%2Fblob%2Fmaster%2F=02%7C01%7Cv-vlkoti%40microsoft.com%7C7f41d67cc4be48efc86308d438fcbd92%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636196105543207234=MyYfRRBvGglmjg%2B6eJNW6jJkwk2BiFBQMjw4LOfo%2FMI%3D=0
> > >>> cordova-plugin-camera/index.d.ts
> > >>> [2] 

[GitHub] cordova-lib issue #453: Support a display name via config.xml

2017-01-17 Thread dpogue
Github user dpogue commented on the issue:

https://github.com/apache/cordova-lib/pull/453
  
Windows has a `WindowsStoreDisplayName` preference, but I'm not clear if 
it's the same concept or not.

In any case, the proper place for the platform changes should happen in 
each of the platforms with PlatformApi. I only updated the Android/iOS ones 
here because it wasn't as clear at the time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #453: Support a display name via config.xml

2017-01-17 Thread stevengill
Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/453
  
Hmm. `edit-config` still hasn't been implemented for `config.xml` and might 
not for a while. I can see both sides of the argument. 

One of the main goals for `edit-config` was to have a generic way to add 
elements to config files and not have to create new config elements for every 
new preference that pops up. Adding this is counter-intuitive to that goal.

On the other hand, for `edit-config` this would require multiple lines to 
do. One for Android, one for ios, etc. Most users probably wouldn't use/set 
shortname in this scenario. If this is a feature we want many users to use, it 
might be better to make it its own preference. 

What are others peoples thoughts? I'm going to hold off including this in 
6.5.0 so we can discuss it more. Thoughts @macdonst @purplecabbage @infil00p 
@shazron?

Side note: Does windows not support a shortname type attribute? I only see 
additions to iOS & Android in this PR. 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android issue #321: CB-8978 Prepare copy resource-files from config....

2017-01-17 Thread dpogue
Github user dpogue commented on the issue:

https://github.com/apache/cordova-android/pull/321
  
Yeah, I'm going to try to get it set up locally with cordova-common master 
and ensure it's all working as intended


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android issue #321: CB-8978 Prepare copy resource-files from config....

2017-01-17 Thread stevengill
Github user stevengill commented on the issue:

https://github.com/apache/cordova-android/pull/321
  
Needs review with master cordova-common. Aka cordova-common@2 (releasing 
soon)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #214: CB-8978 Added new image element tag for config.xml

2017-01-17 Thread ktop
Github user ktop commented on the issue:

https://github.com/apache/cordova-lib/pull/214
  
Yep, thanks. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #214: CB-8978 Added new image element tag for confi...

2017-01-17 Thread ktop
Github user ktop closed the pull request at:

https://github.com/apache/cordova-lib/pull/214


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #214: CB-8978 Added new image element tag for config.xml

2017-01-17 Thread stevengill
Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/214
  
I've merged https://github.com/apache/cordova-lib/pull/468 in. @ktop can 
you close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #468: CB-8978 Add resource-file parsing to config.x...

2017-01-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/468


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request #355: CB-12018 : updated tests to work with jas...

2017-01-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/355


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request #284: CB-12018 : updated tests to work with jasmine...

2017-01-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/284


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android issue #355: CB-12018 : updated tests to work with jasmine (p...

2017-01-17 Thread infil00p
Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/355
  
Looks fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #115: Support for passing request headers ...

2017-01-17 Thread julienmartin
Github user julienmartin commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/115
  
Any news on this ? 
I can't build on Xcode (missing .h declaration for navigateToNew method).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request #675: CB-6275 Added iOS support icon for Backgroun...

2017-01-17 Thread mdoelker
GitHub user mdoelker opened a pull request:

https://github.com/apache/cordova-docs/pull/675

CB-6275 Added iOS support icon for BackgroundColor preference

iOS support was added in CB-6274 / 
https://github.com/apache/cordova-ios/pull/283

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mdoelker/cordova-docs master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #675


commit 92db4fc596a5b14442f7e077b8b62a5f0b747345
Author: Malte Dölker 
Date:   2017-01-17T11:26:58Z

CB-6275 Added iOS support icon for BackgroundColor preference




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Buildbot: buildslave cordova-osx-slave was lost

2017-01-17 Thread buildbot
The Buildbot working for ''
has noticed that the buildslave named cordova-osx-slave went away

It last disconnected at Tue Jan 17 11:12:06 2017 (buildmaster-local time)

The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Richard Knoll 
'.

Sincerely,
 The Buildbot
 https://ci.apache.org/

https://ci.apache.org/buildslaves/cordova-osx-slave

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Buildbot: buildslave cordova-windows-slave was lost

2017-01-17 Thread buildbot
The Buildbot working for ''
has noticed that the buildslave named cordova-windows-slave went away

It last disconnected at Tue Jan 17 11:12:06 2017 (buildmaster-local time)

The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Richard Knoll '.

Sincerely,
 The Buildbot
 https://ci.apache.org/

https://ci.apache.org/buildslaves/cordova-windows-slave

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file pull request #199: CB-12355: (iOS) fix FileEntry.file.ty...

2017-01-17 Thread LightZam
GitHub user LightZam opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/199

CB-12355: (iOS) fix FileEntry.file.type

### Platforms affected
iOS

### What does this PR do?
fix iOS FileEntry.file callback return a null type

### What testing has been done on this change?
install to project and install on real device (iPhone 5, 6, 6s) and 
simulator

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/LightZam/cordova-plugin-file master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #199


commit 667ddfa40a4056c40624ba8d5bdac7c8a28ec98c
Author: Zam 
Date:   2017-01-17T10:35:25Z

CB-12355: (iOS) fix FileEntry.file.type




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org