[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

[shanesmith]

Github user shanesmith commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/116
  
This change has broken recording from what I'm seeing. 

The plugin requires the file to have a "wav" extension, however now that 
the audio is being encoded as "kAudioFormatMPEG4AAC" it doesn't work, the 
extension needs to be "m4a" or "aac" (at least those are the two that I've 
tested successfully).

Seems like an update here 
(https://github.com/apache/cordova-plugin-media/blob/master/src/ios/CDVSound.m#L41)
 and in the documentation would be needed to resolve this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #276 for cordova has failed

[Apache Jenkins Server]

Nightly build #276 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/276/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/276/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #12: Follows spec w3 c

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/12
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/12/commits/60f639b5538a53ce056f14e2a70894247126b279)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=windows-10-store/artifact/)
 |
| [iOS 9.3]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=ios-9.3/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=ios-9.3/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=ios-9.3/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=ios-9.3/artifact/)
 |
| [iOS 10.0]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=ios-10.0/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=ios-10.0/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=ios-10.0/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=ios-10.0/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/18//PLATFORM=android-5.1/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #12: Follows spec w3 c

[maverickmishra]

GitHub user maverickmishra opened a pull request:

https://github.com/apache/cordova-plugin-screen-orientation/pull/12

Follows spec w3 c



### Platforms affected
iOS, Android, Windows
### What does this PR do?
 The PR makes the plugin conform to exact W3C specs. 
screen.orientation.angle and screen.orientation.onchange attributes implemented.

### What testing has been done on this change?
Tested on android and iOS devices and also using unit tests.


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull 
https://github.com/maverickmishra/cordova-plugin-screen-orientation 
FollowSpecW3C

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12


commit 6b07847d9aab5c18d49d59a9cf88f98bba67bcf0
Author: Jesse MacFadyen 
Date:   2017-02-22T19:34:21Z

added missing tests, fixed indentation of js file

commit 60f639b5538a53ce056f14e2a70894247126b279
Author: maverickmishra 
Date:   2017-03-09T01:45:24Z

The plugin now follows W 3 specs ; tests for screen.orientation.onchange 
pending




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #365: CB-12524: Fix the GradleBuilder so that it build...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/365
  
Closing this PR because we can't distribute JARs, we have to find another 
solution.  Apologies.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #365: CB-12524: Fix the GradleBuilder so that i...

[infil00p]

Github user infil00p closed the pull request at:

https://github.com/apache/cordova-android/pull/365


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/289
  
Thanks @khawkins ! I'll let the CI run, then merge these in. No worries, I 
can squash on my end


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Cordova 7 Prep

[Steven Gill]

Hey Folks,

We got many cordova@7 related prs waiting to be merged. I've held off on
merging them incase we wanted to do another 6.x release.

I am going to start merging them. If we need another 6.x release, we can
branch off the previous release branch. 6.5.x

Some Prs to review/merge
* https://github.com/apache/cordova-lib/pull/523
* https://github.com/apache/cordova-lib/pull/522
* https://github.com/apache/cordova-lib/pull/521
* https://github.com/apache/cordova-lib/pull/520
* https://github.com/apache/cordova-cli/pull/270
* https://github.com/apache/cordova-cli/pull/268
* https://github.com/apache/cordova-cli/pull/267
* https://github.com/apache/cordova-cli/pull/266

[GitHub] cordova-lib issue #524: CB-12528 use fs instead of our own existsSync

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/524
  
It was deprecated for a time but then got undeprecated. Great find! 
https://github.com/nodejs/node/issues/1592


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

[khawkins]

Github user khawkins commented on the issue:

https://github.com/apache/cordova-ios/pull/289
  
Okay @shazron , I've rebased and updated the deployment target of the 
framework to 9.0.  All tests are passing.  Let me know if you'd like me to 
squash these review commits down.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #131: CB-1254: (ios) Fix wav file recording, add ...

[chmac]

Github user chmac commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/131
  
Would be awesome to get this merged, just took me several hours to figure 
out why this wasn't working until I eventually found this PR.

Thanks @leopatras for posting. 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

[khawkins]

Github user khawkins commented on the issue:

https://github.com/apache/cordova-ios/pull/289
  
Actually, I end up seeing a ton of warnings now complaining about the fact 
that I didn't otherwise do that, so that probably answers my question. 😉  
I'll have the update pushed shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #366: CB-12546: More robust support spawning the emula...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/366
  
Ah, I forgot to ping you: please review @infil00p 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

[khawkins]

Github user khawkins commented on the issue:

https://github.com/apache/cordova-ios/pull/289
  
No worries @shazron !  Question: I see that 
2a323fad2156a434e928eb570e7f272921b75d6a moved the iOS deployment target up to 
9.0.  I presume I should amend the framework target to do the same?  It's 
currently set to 8.0 (before this change came in).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #366: CB-12546: More robust support spawning th...

[filmaj]

GitHub user filmaj opened a pull request:

https://github.com/apache/cordova-android/pull/366

CB-12546: More robust support spawning the emulator with newer Android SDK



### Platforms affected

Android

### What does this PR do?

Two things related to starting emulator:

1. Adds more versatile support for the changing structure of the Android 
SDK. In particular, if spawning the `android` command exits with a non-zero 
status code (as it does in SDK Tools 25.3.1), attempts to use `avdmanager` and 
massages its output to conform to the old output of `android list avd`.
2. Ensures to spawn the emulator with a `cwd` parameter, to workaround the 
SDK bug described here: 
https://code.google.com/p/android/issues/detail?id=235461

### What testing has been done on this change?

Not enough! Unfortunately, I cannot downgrade my Android SDK to test that 
this works on older SDK versions. Thus why I attempted not to change any of the 
old logic leveraging the `android` binary, and rather just built support for 
the new SDK on top of the old one, trying to use feature / failure detection 
along the way.

### Checklist
- [X] [CB-12546](https://issues.apache.org/jira/browse/CB-12546)
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/filmaj/cordova-android CB-12546

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/366.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #366


commit 73f28541abf9bd372cb2a5402e2ac3b326c15b94
Author: filmaj 
Date:   2017-03-08T01:04:11Z

CB-12546: start of work on parsing emulator info from `avdmanager` output. 
work in progress.

commit 8fc099b8f1b4f7bfb748eb6655d6cd1d0aa3dbdf
Author: filmaj 
Date:   2017-03-08T17:12:44Z

CB-12546: tweak parsing of `avdmanager` output to match the old output from 
`android list avd`. also explicitly set the CWD of the spawned emulator process 
to workaround a recent google android sdk bug.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org