[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/529
  
Now to add tests! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #284 for cordova has failed

[Apache Jenkins Server]

Nightly build #284 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/284/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/284/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #296: CB-12571 - Podfile gets overwritten and some ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/296


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #298: CB-12577 - Fix module import warnings when using Cor...

[khawkins]

Github user khawkins commented on the issue:

https://github.com/apache/cordova-ios/pull/298
  
Thanks @shazron .  I could have sworn those were in there initially, but I 
guess not?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Saving file with cordova-plugin-file(file-transfer) on device

[Jesse]

Moved dev list to bcc

Hi Andrew,
This list is for development of the cordova framework itself, and not
really for user support.

That said, I will attempt to help you, or steer you in the right direction.
What platform are you seeing the issue in, and are you using the camera api?
If you are attempting to download a video file and add it to camera roll,
the file plugin would not allow this.

Cheers,
  Jesse





@purplecabbage
risingj.com

On Thu, Mar 16, 2017 at 9:46 AM, Andrew Kucheruk 
wrote:

> Hello.
> I`m developer.
> Right know i trying to download file and make it visible in device gallery.
> With first step all good i download it in cordova.file.
> externalRootDirectory
> and I can see it with file manager but in gallery i don`t see it.
> Help me with that.
> How Can i make that video file visible in gallery?
>
> 2017-03-16 18:43 GMT+02:00 Andrew Kucheruk :
>
> > Hello.
> > I`m developer.
> > Right know i trying to download file and make it visible in device
> gallery.
> > With first step all good i download it in cordova.file.
> > externalRootDirectory
> > and I can see it with file manager but in gallery i don`t see it.
> > Help me with that.
> > How Can i make that video file visible in gallery?
> >
>

[GitHub] cordova-docs pull request #686: CB-12559: documentation updates for new Andr...

[dpogue]

Github user dpogue commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/686#discussion_r106557529
  
--- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
@@ -62,19 +63,20 @@ they dip below 5% on Google's
 
 ### Java Development Kit (JDK)
 
-Install [Java Development Kit (JDK) 
7](http://www.oracle.com/technetwork/java/javase/downloads/jdk7-downloads-1880260.html)
+Install [Java Development Kit (JDK) 
8](http://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html)
 or later.
 
 When installing on Windows you also need to set `JAVA_HOME` Environment 
Variable
 according to your JDK installation path (see [Setting Environment 
Variables](#setting-environment-variables))
 
  Android SDK
 
-Install the [Android Stand-alone SDK 
Tools](http://developer.android.com/sdk/installing/index.html?pkg=tools) or 
[Android 
Studio](http://developer.android.com/sdk/installing/index.html?pkg=studio).
-Proceed with Android Studio if you plan on
-developing new Cordova for Android plugins or using native tools to
-run and debug the Android platform. Otherwise, the Android Stand-alone SDK 
Tools
-are enough to build and deploy Android applications.
+Install [Android Studio](reference/cordova-plugin-camera/index.html) or the
--- End diff --

Seems like the wrong link here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/529
  
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=h1) 
Report
> Merging 
[#529](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr=desc)
 will **increase** coverage by `<.01%`.
> The diff coverage is `92.68%`.


```diff
@@Coverage Diff@@
##   master#529  +/-   ##
=
+ Coverage81.9%   81.9%   +<.01% 
=
  Files  68  68  
  Lines54985499   +1 
  Branches 10901086   -4 
=
+ Hits 45034504   +1 
  Misses995 995
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=)
 | `93.75% <ø> (-0.44%)` | :x: |
| 
[cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==)
 | `87.07% <ø> (-0.09%)` | :x: |
| 
[cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==)
 | `97.2% <100%> (ø)` | :white_check_mark: |
| 
[cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=)
 | `78.42% <88.88%> (+0.17%)` | :white_check_mark: |
| 
[cordova-lib/src/platforms/platforms.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9wbGF0Zm9ybXMuanM=)
 | `97.14% <94.73%> (+0.59%)` | :white_check_mark: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=footer). 
Last update 
[07001dc...56d0746](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?el=footer=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/529
  
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=h1) 
Report
> Merging 
[#529](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr=desc)
 will **increase** coverage by `<.01%`.
> The diff coverage is `92.68%`.


```diff
@@Coverage Diff@@
##   master#529  +/-   ##
=
+ Coverage81.9%   81.9%   +<.01% 
=
  Files  68  68  
  Lines54985499   +1 
  Branches 10901086   -4 
=
+ Hits 45034504   +1 
  Misses995 995
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==)
 | `87.07% <ø> (-0.09%)` | :x: |
| 
[cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=)
 | `93.75% <ø> (-0.44%)` | :x: |
| 
[cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==)
 | `97.2% <100%> (ø)` | :white_check_mark: |
| 
[cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=)
 | `78.42% <88.88%> (+0.17%)` | :white_check_mark: |
| 
[cordova-lib/src/platforms/platforms.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9wbGF0Zm9ybXMuanM=)
 | `97.14% <94.73%> (+0.59%)` | :white_check_mark: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=footer). 
Last update 
[07001dc...56d0746](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?el=footer=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[VOTE] plugin release : cordova-plugin-screen-orientation (attempt 2)

[Jesse]

Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-12568

The plugins have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-12568/

The packages were published from their corresponding git tags:
cordova-plugin-screen-orientation: 2.0.0 (6bda75f2b7)

Upon a successful vote I will upload the archives to dist/, upload them to
npm, and post the corresponding blog post.

Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/
release-voting.md
How to vote on a plugins release at https://github.com/apache/
cordova-coho/blob/master/docs/plugins-release-process.md#voting

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Ensured continuous build was green when repos were tagged

@purplecabbage
risingj.com

[GitHub] cordova-docs pull request #686: CB-12559: documentation updates for new Andr...

[filmaj]

GitHub user filmaj opened a pull request:

https://github.com/apache/cordova-docs/pull/686

CB-12559: documentation updates for new Android SDK Tools



Ping @infil00p, @shazron, @dpogue, @purplecabbage for review, please and 
thank you.

Please do not merge this until apache/cordova-android#369 is merged in.

### Platforms affected

Android

### What does this PR do?

Documents changes to set up introduced with the new Android SDK Tools.

Also once-over'ed all the links and updated some of the ones to 
developer.android.com to avoid redirects.

This incorporates / is related to #678. 

### What testing has been done on this change?

Simply ran generated docs - seemed to work.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database: 
[CB-12559](https://issues.apache.org/jira/browse/CB-12559), 
[CB-12391](https://issues.apache.org/jira/browse/CB-12391), and related to the 
changes in [CB-12546](https://issues.apache.org/jira/browse/CB-12546) and 
[CB-12554](https://issues.apache.org/jira/browse/CB-12554).
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/filmaj/cordova-docs CB-12559

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/686.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #686


commit 55d356a4c96ec904d3028ba6a0e3846cb2fe3de8
Author: filmaj 
Date:   2017-03-16T23:34:26Z

CB-12559: updates for new android SDK Tools. also updated links to avoid 
redirects. 80-character width limit honouring.

commit 176c03ca47b629d11550729b1da67a233669a517
Author: filmaj 
Date:   2017-03-16T23:37:18Z

CB-12391: update android target levels for cordova-android 6.x.x




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] plugin release : cordova-plugin-screen-orientation

[Jesse]

I am closing this vote.
It has come to my attention (thanks @alsorokin) that the archive does not
include the tests ( because of a .npmignore )
I have retagged, updated, re-archived the release, and will be starting a
new vote thread momentarily.
Thanks for your patience!



@purplecabbage
risingj.com

On Wed, Mar 15, 2017 at 2:32 PM, Jesse  wrote:

> Please review and vote on the release of this plugins release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-12568
>
> The plugins have been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/CB-12568/
>
> The packages were published from their corresponding git tags:
> cordova-plugin-screen-orientation: 2.0.0 (22fdcf68d6)
>
> Upon a successful vote I will upload the archives to dist/, upload them to
> npm, and post the corresponding blog post.
>
> Voting guidelines: https://github.com/apache/
> cordova-coho/blob/master/docs/release-voting.md
> How to vote on a plugins release at https://github.com/apache/
> cordova-coho/blob/master/docs/plugins-release-process.md#voting
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ensured continuous build was green when repos were tagged
>
> @purplecabbage
> risingj.com
>

[GitHub] cordova-ios pull request #298: CB-12577 - Fix module import warnings when us...

[shazron]

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-ios/pull/298

CB-12577 - Fix module import warnings when using Cordova.framework 
(Carthage)

### Platforms affected

self

### What does this PR do?

Remove warnings related to incomplete umbrella headers when using `@import 
Cordova` after compiling Cordova.framework using Carthage.

### What testing has been done on this change?

Added Cordova.framework from the repo using Carthage, added the import, 
added a reference to CDVViewController, and built an iOS View app.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-12577

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #298


commit c7b422c5bd7a45e37df5945ca336bab58a1263a2
Author: Shazron Abdullah 
Date:   2017-03-16T23:35:02Z

CB-12577 - Fix module import warnings when using Cordova.framework 
(Carthage)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #297: CB-12050 ios: Create shared scheme for framework tar...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/297
  
Posted #298 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #297: CB-12050 ios: Create shared scheme for framew...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/297


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #297: CB-12050 ios: Create shared scheme for framework tar...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/297
  
Good stuff, tested it, it works as you described.
Two issues related to using module import using `@import Cordova;` which I 
will address in a separate PR though:
![screen shot 2017-03-16 at 3 53 02 
pm](https://cloud.githubusercontent.com/assets/36107/24021947/cad8c278-0a60-11e7-85a7-46dc1138a6b8.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Remove cordova-android's `android_sdk_version` script

[Filip Maj]

I recently issued a pull request to update the cordova-android CLI
scripts to work with Android SDK Tools 25.3.1 [1]. As part of the
discussion in there, it came up that, in particular cases where one's
environment was not set up with proper environment variables, running
`./bin/android_sdk_version` or `./cordova/android_sdk_version` would
fail.

This script solely prints out the most-recent Android API level or
target installed on the user's machine. It is not used in any other
scripts.

I propose we remove it. I believe it is a non-standard CLI script,
that is, no other platform provides a similar script as far as I can
tell.

Thoughts?

[1] https://github.com/apache/cordova-android/pull/369

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #296: CB-12571 - Podfile gets overwritten and some depende...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/296
  
For reference, it passed on my personal repo here: 
https://travis-ci.org/shazron/cordova-ios/builds/211143535


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #296: CB-12571 - Podfile gets overwritten and some ...

[shazron]

GitHub user shazron reopened a pull request:

https://github.com/apache/cordova-ios/pull/296

CB-12571 - Podfile gets overwritten and some dependencies disappear.

### Platforms affected

self

### What does this PR do?

Fix reading of pods with non-alphanumeric characters in the name from 
Podfile

### What testing has been done on this change?

Added unit tests

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-12571

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/296.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #296


commit 303bb5480c225ffa3a374fb592dfc560dabf0804
Author: Shazron Abdullah 
Date:   2017-03-14T22:17:09Z

CB-12571 - Podfile gets overwritten and some dependencies disappear.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #296: CB-12571 - Podfile gets overwritten and some ...

[shazron]

Github user shazron closed the pull request at:

https://github.com/apache/cordova-ios/pull/296


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-android/pull/369
  
@filmaj as usual, perhaps we need to keep it around, and set a deprecation 
period of three releases (we had a discussion in dev@)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/369
  
@shazron I think that's expected and will happen if you also try it with 
the `master` branch. It is because `android_sdk_version` does not leverage 
`check_reqs`, which will modify your `PATH` and `ANDROID_HOME` environment 
variables.

I can update it, though, to use `check_reqs`? It would then work unless you 
have _neither_ `ANDROID_HOME` _nor_ any of the Android SDK tooling on your 
`PATH`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-android/pull/369
  
I have the same results as @dpogue. Tested macOS Sierra with Android SDK 
25.3.1 and Windows 10 with Android SDK 25.3.1.

For `android_sdk_version` on Windows I got this error:
```
> bin\android_sdk_version
{ [Error: cmd: Command failed with exit code 1 Error output:
'android' is not recognized as an internal or external command,
operable program or batch file.]
  stderr: '\'android\' is not recognized as an internal or external 
command,\r\noperable program or batch file.\r\n',
  code: 1 }
```

Not sure how to downgrade (possible?) if not I would have tested that.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #134: CB-12542: (ios) Fix wav file recording, add...

[LoneyGG]

Github user LoneyGG commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/134
  
Why this hasn't been merged yet? its a pain to apply the fix manually and 
remove this plugin from the gitignore in order to share my code with my 
partners.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Saving file with cordova-plugin-file(file-transfer) on device

[Andrew Kucheruk]

Hello.
I`m developer.
Right know i trying to download file and make it visible in device gallery.
With first step all good i download it in cordova.file.externalRootDirectory
and I can see it with file manager but in gallery i don`t see it.
Help me with that.
How Can i make that video file visible in gallery?

2017-03-16 18:43 GMT+02:00 Andrew Kucheruk :

> Hello.
> I`m developer.
> Right know i trying to download file and make it visible in device gallery.
> With first step all good i download it in cordova.file.
> externalRootDirectory
> and I can see it with file manager but in gallery i don`t see it.
> Help me with that.
> How Can i make that video file visible in gallery?
>

[GitHub] cordova-cli issue #266: CB-12008 : made autosave the default for platform an...

[audreyso]

Github user audreyso commented on the issue:

https://github.com/apache/cordova-cli/pull/266
  
Thanks! @stevengill  ...Rebased cli PR's! Let me know if I need to make any 
additional changes! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation issue #86: Add required=false to the uses-feature

[patrickbussmann]

Github user patrickbussmann commented on the issue:

https://github.com/apache/cordova-plugin-geolocation/pull/86
  
You can add this line to your `config.xml`.



With this content.

  #!/usr/bin/env node
  
  module.exports = function (context) {
var
  Q = context.requireCordovaModule('q'),
  deferral = new Q.defer(),
  fs = context.requireCordovaModule('fs'),
  path = context.requireCordovaModule('path'),
  platformRoot = path.join(context.opts.projectRoot, 
'platforms/android'),
  manifestFile = path.join(platformRoot, 'AndroidManifest.xml')
;
  
if (fs.existsSync(manifestFile)) {
  fs.readFile(manifestFile, 'utf8', function (err, data) {
if (err) {
  deferral.resolve();
  throw new Error('Unable to find AndroidManifest.xml: ' + err);
}
  
fs.writeFile(manifestFile, (function (str) {
  str = str.replace(/android:required="true"/ig, 
'android:required="false"');
  str = str.replace(//ig, 
'');
  return str;
})(data), 'utf8', function (err) {
  deferral.resolve();
  if (err) throw new Error('Unable to write into 
AndroidManifest.xml: ' + err);
});
  });
} else {
  deferral.resolve();
}
  
return deferral.promise;
  };

Then it will work fine and you will have no more dependencies :+1: 

But yes your pull request should be merged as soon as possible :+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #216: Update README.md

[murphy85]

GitHub user murphy85 opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/216

Update README.md

Changed options description from string to object



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murphy85/cordova-plugin-inappbrowser patch-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #216


commit e027ec51bb77e93858dd918a407431d11bc1f3fc
Author: murphy85 
Date:   2017-03-16T14:55:20Z

Update README.md

Changed options description from string to object




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

[alsorokin]

Github user alsorokin commented on the issue:

https://github.com/apache/cordova-android/pull/369
  
I'll create a test job that uses this code when our slaves are back up 
(some Microsoft infra permutations are underway ATM).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/369
  
Oh yes, and ping @alsorokin - not sure if the changes to the android CLI 
scripts affect the CI in any way? But in any case, probably worth getting your 
eyes on this change too :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/369
  
@dpogue thanks for checking! So I think `android_sdk_version` failing in 
this case is kind of expected, as that script, historically, did not do any 
environment checking, and I tried keeping the same behaviour.

The other commands that are part of `Api.js`, like `build` and `clean` and 
`run`, [always call through to 
`check_reqs`](https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/Api.js#L344-L346).
 Part of that functionality in this pull request now [automatically adds the 
new SDK tools to your 
`PATH`](https://github.com/filmaj/cordova-android/blob/CB-12546/bin/templates/cordova/lib/check_reqs.js#L295-L297)
 if they are missing. That's why the `build` command worked for you, but the 
`android_sdk_version` command did not.

We could tweak the behaviour of `android_sdk_version` so that it calls 
through to `check_reqs` as well? This change would fix that command failing in 
your case, and provide more meaningful errors for people who don't have their 
environments configured properly (i.e. will check for missing `ANDROID_HOME`, 
will munge `PATH` based on what kinds of Android tooling it will find, etc.). 
What do you think?

The deeper question that rises out of this is: is `android_sdk_version` 
useful? Is it worth keeping around? It is not part of the platform API and is 
still hanging around due to history more than anything else.

Let me know what y'all think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation issue #85: Android: handle location service is of...

[Menardi]

Github user Menardi commented on the issue:

https://github.com/apache/cordova-plugin-geolocation/pull/85
  
@stevengill Is there anything else that needs to be done to get this 
merged? It seems like quite a key feature to me!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #266: CB-12008 : made autosave the default for platform an...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-cli/pull/266
  
Your cordova-cli PRs are ready to rebase now :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #270: CB-11346 Remove known platforms check

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/270


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #529: CB-11346 Remove known platforms check

[stevengill]

GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-lib/pull/529

CB-11346 Remove known platforms check

Building on top of the work by @purplecabbage and @shazron.

Still need to fix failing tests + add some new tests.

Also, need to run through plugin install steps.

work in progress



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/529.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #529


commit 3a810d1887bc488e8e9e9dfacdc6e86a80b4b318
Author: Shazron Abdullah 
Date:   2017-02-21T01:47:14Z

CB-11346 - Remove known platforms check for Platform API

commit faf54779fd6e02f23d2a302629599e578fd5d02a
Author: Jesse MacFadyen 
Date:   2017-02-28T00:13:43Z

CB-11346: Remove known platforms check

This closes #523, This closes #519

commit 5a5d02898dc3286c8494c5986edf0e5f439d8215
Author: Steve Gill 
Date:   2017-03-11T00:43:56Z

CB-11346: fixed remove platform to work with unknown platforms




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #136: mediaFile.play(); its not working

[ghenry22]

Github user ghenry22 commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/136
  
This is not a pull request.  Please close this and try the Cordova slack 
channel or search around on stack overflow or similar resources for issues and 
support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org