[GitHub] cordova-browser pull request #30: CB-12804 : manifest.json added to browser ...

2017-05-30 Thread macdonst 
Github user macdonst commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/30#discussion_r119261228
  
--- Diff: bin/template/cordova/Api.js ---
@@ -96,6 +96,42 @@ Api.createPlatform = function (dest, config, options, 
events) {
 events.emit('error','createPlatform is not callable from the 
browser project API.');
 throw(e);
 }
+
+// Create manifest.json
+var manifestJson;
+var manifestJsonPath = path.join(dest,'manifest.json');
+
+// Check if path exists and require manifestJsonPath.
+if(fs.existsSync(manifestJsonPath)) {
+try {
+manifestJson = require(manifestJsonPath);
+} 
+catch (e) {
+console.log("error : " + e);
+events.emit('error', 'unable to require manifest.json path.');
+}
+} else if (manifestJson === undefined) {
+manifestJson = {};
+if(config){
+if(config.name()) {
+manifestJson.name = config.name();
+}
+if(config.shortName()) {
+manifestJson.short_name = config.shortName();
+}
+if(config.packageName()) {
+manifestJson.version = config.packageName();
+}
+if(config.description()) {
+manifestJson.description = config.description();
+}
+if(config.author()) {
+manifestJson.author = config.author();
+}
+}
--- End diff --

Also, it may make sense to pull `manifest.theme_color` from ``


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #360 for cordova has failed

2017-05-30 Thread Apache Jenkins Server 
Nightly build #360 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/360/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/360/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #315: CB-12675 - Travis xcode 8.3. os-x image fails...

2017-05-30 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/315


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #315: CB-12675 - Travis xcode 8.3. os-x image fails...

2017-05-30 Thread shazron 
GitHub user shazron opened a pull request:

https://github.com/apache/cordova-ios/pull/315

CB-12675 - Travis xcode 8.3. os-x image fails an e2e test

### Platforms affected

self

### What does this PR do?

Updates the os-x image on Travis to Xcode 8.3

### What testing has been done on this change?

this PR is the test. 

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-12675

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #315


commit 537397343bf72f4c00019379b122cc9e6c5eebcb
Author: Shazron Abdullah 
Date:   2017-05-30T23:15:11Z

CB-12675 - Travis xcode 8.3. os-x image fails an e2e test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #314: CB-12869 - Update bundled ios-sim to 5.0.13

2017-05-30 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/314


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #314: CB-12869 - Update bundled ios-sim to 5.0.13

2017-05-30 Thread shazron 
GitHub user shazron opened a pull request:

https://github.com/apache/cordova-ios/pull/314

CB-12869 - Update bundled ios-sim to 5.0.13

### Platforms affected

self

### What does this PR do?

Update ios-sim to 5.0.13 (new release has a bug fix)

### What testing has been done on this change?
```
cordova create foo
cd foo
cordova platform add [path_to_this_repo]
cordova emulate ios
```

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-12869

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/314.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #314


commit bb0dfeef12060b77d4482e3238fb068f8343146a
Author: Shazron Abdullah 
Date:   2017-05-30T22:27:24Z

CB-12869 - Update bundled ios-sim to 5.0.13




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #313: CB-12856 - Skip CocoaPods check_reqs if on no...

2017-05-30 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/313


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [CORE PLUGINS][DISCUSS] Roadmap 2017

2017-05-30 Thread Shazron 
Good point, I can imagine that after June 5 they will possibly bake things
into Safari and improve WKWebView, but that will only apply to iOS 11
onwards and would not affect most decisions since we need to be backwards
compat for quite a while.

For June 1st, it looks like consensus is there for the majority of the
plugins. I'm comfortable to move the deadline to June 6th. If there are any
earth-shattering announcements from Apple, we can bump it up one more week.


On Tue, May 30, 2017 at 2:07 AM, julio cesar sanchez  wrote:

> With the WWDC being next week, should we wait a few more days before making
> the final decision?
> After a sneak peek into iOS 11 announcements maybe we can make a better
> decision
>
> 2017-05-22 18:47 GMT+02:00 Shazron :
>
> > Deadline of June 1st is in 11 days, so get your comments in.
> >
> > On Wed, Apr 26, 2017 at 1:01 PM, Shazron  wrote:
> >
> > > I'm going to put a deadline of June 1st, 2017 to wrap up discussion of
> > the
> > > Roadmap, we need it to be finalized by then if not it will just be left
> > in
> > > the wind like previous proposals.
> > >
> > > This gives us a month, more than enough I think, to nail this down --
> > also
> > > since most of the Adobe team will be away on conferences (like PhoneGap
> > Day
> > > EU 2017 http://pgday.phonegap.com/eu2017/ -- see you there if you are
> > > going) so this extra time will help.
> > >
> > >
> > >
> > > On Tue, Apr 25, 2017 at 7:11 PM, Shazron  wrote:
> > >
> > >> The PR for the Plugin Audit is originally here:
> > https://github.com/cordo
> > >> va/cordova-discuss/pull/58
> > >>
> > >> On Tue, Apr 25, 2017 at 6:55 PM, Shazron  wrote:
> > >>
> > >>> This is the start of a conversation:
> > >>> https://issues.apache.org/jira/browse/CB-12708
> > >>>
> > >>> Take these two issues below into consideration:
> > >>>
> > >>> 1. Cordova's plugin audit sometime back:
> > >>> https://github.com/stevengill/cordova-discuss/blob/836ce2c07
> > >>> d7c28ee09509cd8a676886aebc21a28/proposals/PluginsAudit2015/audit.md
> > >>>
> > >>> 2. The Adobe team's commitment statement w.r.t core plugins:
> > >>> https://blog.phonegap.com/our-continued-commitment-bca4121f5d39
> > >>>
> > >>>
> > >>>
> > >>>
> > >>
> > >
> >
>

[GitHub] cordova-plugin-file issue #153: Allow setting data protection metadata on iO...

2017-05-30 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/153
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file/pull/153/commits/50f558675173e9af639ec044a71c3283e4c0b8ea)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/59/)

 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [CORE PLUGINS][DISCUSS] Roadmap 2017

2017-05-30 Thread julio cesar sanchez 
With the WWDC being next week, should we wait a few more days before making
the final decision?
After a sneak peek into iOS 11 announcements maybe we can make a better
decision

2017-05-22 18:47 GMT+02:00 Shazron :

> Deadline of June 1st is in 11 days, so get your comments in.
>
> On Wed, Apr 26, 2017 at 1:01 PM, Shazron  wrote:
>
> > I'm going to put a deadline of June 1st, 2017 to wrap up discussion of
> the
> > Roadmap, we need it to be finalized by then if not it will just be left
> in
> > the wind like previous proposals.
> >
> > This gives us a month, more than enough I think, to nail this down --
> also
> > since most of the Adobe team will be away on conferences (like PhoneGap
> Day
> > EU 2017 http://pgday.phonegap.com/eu2017/ -- see you there if you are
> > going) so this extra time will help.
> >
> >
> >
> > On Tue, Apr 25, 2017 at 7:11 PM, Shazron  wrote:
> >
> >> The PR for the Plugin Audit is originally here:
> https://github.com/cordo
> >> va/cordova-discuss/pull/58
> >>
> >> On Tue, Apr 25, 2017 at 6:55 PM, Shazron  wrote:
> >>
> >>> This is the start of a conversation:
> >>> https://issues.apache.org/jira/browse/CB-12708
> >>>
> >>> Take these two issues below into consideration:
> >>>
> >>> 1. Cordova's plugin audit sometime back:
> >>> https://github.com/stevengill/cordova-discuss/blob/836ce2c07
> >>> d7c28ee09509cd8a676886aebc21a28/proposals/PluginsAudit2015/audit.md
> >>>
> >>> 2. The Adobe team's commitment statement w.r.t core plugins:
> >>> https://blog.phonegap.com/our-continued-commitment-bca4121f5d39
> >>>
> >>>
> >>>
> >>>
> >>
> >
>