Nightly build #366 for cordova has succeeded!

2017-06-05 Thread Apache Jenkins Server
Nightly build #366 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/366/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #561: Cb 12870 - Check that all use cases are caugh...

2017-06-05 Thread audreyso
GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/561

Cb 12870 - Check that all use cases are caught in Api.js

Not ready for review yet, still updating tests. Thanks!


### Platforms affected


### What does this PR do?

Check that all use cases are caught in Api.js

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12870

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/561.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #561


commit 5ccbba28764faa675b65d26429e9685c76b98825
Author: Audrey So 
Date:   2017-05-31T17:41:22Z

CB-12870 : catch all use cases for getPlatformApiFunc and update tests 
accordingly

commit f051199236e85a546236891303147a11d0b123ee
Author: Audrey So 
Date:   2017-06-03T00:24:32Z

CB-12870 : checks if platformapi.createplatform func exists and throws 
error if api is not compatible

commit 75c8d8b9bb4c3caecdd518de77a01ba95397aa0a
Author: Audrey So 
Date:   2017-06-05T18:47:11Z

CB-12870 : added util tests to check getPlatformApiFunction

commit c8c8e626e698d8c742c40b2f7c8932aa52f880a1
Author: Audrey So 
Date:   2017-06-06T00:23:35Z

CB-12870 : removed checkPlatformApiCompatible function and update tests in 
platforms.spec"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[NOTICE] Intent on moving to Github

2017-06-05 Thread Shazron
The Apache Cordova Project Management Committee (PMC) has consensus that we
should move primary development of Apache Cordova to Github, from Apache's
servers (role would be reversed, Apache would then be the mirror now).

We are already processing pull requests through Github, although without
write access we couldn't label, or close PRs directly. Enabling of Issues
in Github (to replace JIRA) would be a separate matter, and would likely be
on a per-repo basis.

Moving is achieved by invitation to the Apache Gitbox project:
https://gitbox.apache.org/ (don't get excited if you can log in and link,
your repo needs to be whitelisted)

We would have to file INFRA issues in JIRA to get approval for the move.

We are suggesting a multi-part migration:

1. Top platforms (ios, android, windows, browser)
2. Tools (lib, cli, coho, fetch, common etc) --> we might need a lib
breakout first, this is ongoing work
3. All plugins

The rest would be on a "as needed" basis.

Comments, if any?


[GitHub] cordova-lib pull request #555: CB-12786: Improve logic for searching plugin ...

2017-06-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/555


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios issue #317: Add logging for malformed data

2017-06-05 Thread rafael-chavez
Github user rafael-chavez commented on the issue:

https://github.com/apache/cordova-ios/pull/317
  
Logged a ticket @shazron! https://issues.apache.org/jira/browse/CB-12883


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-media-capture issue #79: CB-12882: (ios): adds support for pe...

2017-06-05 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media-capture/pull/79
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media-capture/pull/79/commits/db0842798ac21eaf3b19931390fbe04008007b95)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/41/)

 72 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-media-capture issue #79: CB-12882: (ios): adds support for pe...

2017-06-05 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media-capture/pull/79
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media-capture/pull/79/commits/13a5135e1defee4afd0fd38cd3c34d1dcec87580)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/40/)

 72 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-06-05 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/150
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/150/commits/640bd7150ebc994ea0398ee186be3b334b006080)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/82/)

 306 tests run, 15 skipped, 148 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-media-capture pull request #79: CB-12882: (ios): adds support...

2017-06-05 Thread stalniy
GitHub user stalniy opened a pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/79

CB-12882: (ios): adds support for permissions checks for camera capturing

### Platforms affected
iOS

### What does this PR do?
adds support for checking camera permission and if camera was prohibited 
shows alert message with information and 2 buttons: OK and Settings. The same 
`cordova-plugin-camera` does

### What testing has been done on this change?
I ran all automated tests, they passed. Also did manual testing and added 2 
additional cases in manual tests for checking presence of alert when camera 
access was prohibited

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stalniy/cordova-plugin-media-capture 
fix/permissions-request

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media-capture/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit 13a5135e1defee4afd0fd38cd3c34d1dcec87580
Author: Sergii Stotskyi 
Date:   2017-06-05T10:02:29Z

CB-12882: (ios): adds support for permissions checks for captureVideo and 
captureImage methods




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-06-05 Thread homen
Github user homen commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/150
  
Hi all,
I have done the required changes. It can be merged now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #555: CB-12786: Improve logic for searching plugin ...

2017-06-05 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/555#discussion_r120073277
  
--- Diff: cordova-fetch/index.js ---
@@ -148,9 +148,15 @@ function trimID(target) {
 target = parts[1];
 }
 
-//If local path exists, set target to final directory
+// If local path exists, try to get plugin id from package.json or set 
target to final directory
 if (fs.existsSync(target)) {
-target = path.basename(target);
+var pluginId, pkgJsonPath = path.join(target, 'package.json');
+
+if (fs.existsSync(pkgJsonPath)) {
+pluginId = JSON.parse(fs.readFileSync(pkgJsonPath)).cordova.id;
--- End diff --

@stevengill, I could not find plugins in which `cordova.id` differs from 
the `name`. PR has been updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...

2017-06-05 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/262
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/262/commits/f4d4c8cd8903fbe1d80d9bd793b7105fed325ad1)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/174/)

 316 tests run, 28 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-06-05 Thread stalniy
Github user stalniy commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/150
  
@homen  do you plan to fix the PR in the nearest future? :) 
It's really annoying for me... And I want to have this fix in my codebase!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-media issue #120: CB-11513: (ios) Fixed: iOS memory warning s...

2017-06-05 Thread ghenry22
Github user ghenry22 commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/120
  
I have merged this into my project and tested and confirm that it does what 
it says on the box.

Before: simulate memory warning on the iOS simulator and audio stops 
instantly on the native side.  App continues to function otherwise but no 
longer plays any audio

After: simulate a memory warning on the iOS simulator and audio continues 
to play as expected, all works as normal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org