Nightly build #368 for cordova has failed

[Apache Jenkins Server]

Nightly build #368 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/368/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/368/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

[Lazza]

Github user Lazza commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/125
  
@karlachavez 

> we have to remove the splashscreen of our app

In the meantime:

cordova plugins remove cordova-plugin-splashscreen
cordova plugins add 
https://github.com/Lazza/cordova-plugin-splashscreen#bulletproof-fix --save


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15/commits/56df01a38843445eb8c83c11af24e34267789259)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/20/)

 0 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #142: documentation: setRate method

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/142
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media/pull/142/commits/0ff223093044d3e6d993b6eee36af2e92b40f90b)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/127/)

 162 tests run, 24 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #130: CB-8098 & CB-7810:(android) Added media rat...

[dellagustin]

Github user dellagustin commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/130
  
@ghenry22, I'm interested on using this feature as well in android, but I 
think some adaptations on the code are needed, can you take a look a my 
comments?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #130: CB-8098 & CB-7810:(android) Added media rat...

[dellagustin]

Github user dellagustin commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/130
  
@filmaj @AshishMehra I created pull request 
https://github.com/apache/cordova-plugin-media/pull/142 to document the 
existing setRate method for iOS platform.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #142: documentation: setRate method

[dellagustin]

GitHub user dellagustin opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/142

documentation: setRate method



### Platforms affected
iOS

### What does this PR do?
Adds documentation for the setRate method

### What testing has been done on this change?
No testing required

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dellagustin/cordova-plugin-media 
set_rate_documentation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #142


commit 0ff223093044d3e6d993b6eee36af2e92b40f90b
Author: Guilherme Dellagustin 
Date:   2017-06-07T22:08:07Z

documentation: setRate method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #141: Fixed link to issue tracker

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/141
  
Thanks for the PR!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #141: Fixed link to issue tracker

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/141


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #130: CB-8098 & CB-7810:(android) Added me...

[dellagustin]

Github user dellagustin commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-media/pull/130#discussion_r120737624
  
--- Diff: src/android/AudioPlayer.java ---
@@ -271,7 +272,6 @@ public void stopRecording(boolean stop) {
 this.moveFile(this.audioFile);
 } else {
 LOG.d(LOG_TAG, "pause recording");
-this.setState(STATE.MEDIA_PAUSED);
--- End diff --

This does not look related to changing the playback rate, was possibly 
removed by mistake, or aimed as part of solving a different issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #130: CB-8098 & CB-7810:(android) Added me...

[dellagustin]

Github user dellagustin commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-media/pull/130#discussion_r120745011
  
--- Diff: src/android/AudioPlayer.java ---
@@ -532,6 +532,27 @@ public void setVolume(float volume) {
 }
 }
 
+ /**
+ * Set the rate for audio player
+ *
+ * @param rate
+ */
+
+public void setRate(float rate) {
+if (this.player != null) {
+  
+if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
--- End diff --

I'm not sure if there is a guideline here, or what is the standard behavior 
in this cases, but should whe not send an error stats or something when the 
version does not meet the minimum requirement?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #130: CB-8098 & CB-7810:(android) Added me...

[dellagustin]

Github user dellagustin commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-media/pull/130#discussion_r119812195
  
--- Diff: www/Media.js ---
@@ -173,7 +173,9 @@ Media.prototype.setRate = function(rate) {
 if (cordova.platformId === 'ios'){
--- End diff --

I think some polishing would be good here:

1. As the current code is, the if/else is not necessary, as both blocks 
execute the exact same instruction
2. This pull request says it enables the set rate for Android, but the else 
block is now executed for any other platform then iOS, this looks wrong. Am I 
missing something?

It looks to me the result should look like:
```javascript
  if (cordova.platformId === 'ios' || cordova.platformId === 'android'){
  exec(null, null, "Media", "setRate", [this.id, rate]);
  } else {
console.warn('media.setRate method is currently not supported for', 
cordova.platformId, 'platform.');
  }
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

[karlachavez]

Github user karlachavez commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/125
  
We can reproduce this issue on a Samsung S6 with the following tech specs:

http://www.samsung.com/ca/business/business-products/smartphones/smartphones/SM-G920WZWABMC

Due to it, we have to remove the splashscreen of our app.

It's important to mention that the issue is presents since the device was 
updated from Android 6 to Android 7. 

Do someone know when the fix proposed is going to be applied?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #141: Fixed link to issue tracker

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/141
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media/pull/141/commits/b05c66c51f29cd31fda0f2ca58a04ea47da9af7c)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/126/)

 162 tests run, 24 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #141: Fixed link to issue tracker

[dellagustin]

Github user dellagustin commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/141
  
This pull request replaces 
https://github.com/apache/cordova-plugin-media/pull/140/commits/5e6cfb628f7a2e9d1a867ea223dfd7fd6212734f

I had some mess with the commits of that one. This one has a single commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #141: Fixed link to issue tracker

[dellagustin]

GitHub user dellagustin opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/141

Fixed link to issue tracker



### Platforms affected
none

### What does this PR do?
Fix the link to the issue tracker.
The component Plugin Media was beingused instead of cordova-plugin-media

### What testing has been done on this change?
Click on the link from README.md

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dellagustin/cordova-plugin-media 
fix_link_to_issue_tracker

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #141


commit b05c66c51f29cd31fda0f2ca58a04ea47da9af7c
Author: Guilherme Dellagustin 
Date:   2017-06-07T20:02:52Z

Fixed link to issue tracker




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #140: Fixed the link to report issues

[dellagustin]

Github user dellagustin closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/140


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #175: Fix build result when using --bundle and ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/175


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #231: Fix broken headings in Markdown files

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/231


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #229: Allow build when using --bundle and multi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/229


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #230: CB-12617 Removed node 0.x

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/230


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #383: CB-12762 : pointed package.json repo item...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/383


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-device-orientation/pull/34
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-device-orientation/pull/34/commits/a77b4fa0a410d22a0d36edddb0cc0a603d8dea43)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/25/)

 66 tests run, 9 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/212
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/212/commits/b6ed0bbaca9c3dfde83e0322e4efcf5d826f5791)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/148/)

 36 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-whitelist pull request #25: CB-12847: added `bugs` entry to p...

[filmaj]

Github user filmaj closed the pull request at:

https://github.com/apache/cordova-plugin-whitelist/pull/25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #233: CB-12847: fixed `bugs` entry in package.j...

[filmaj]

Github user filmaj closed the pull request at:

https://github.com/apache/cordova-windows/pull/233


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #212: Add 'hide' method in typing d...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/212


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-orientation pull request #34: CB-12667 android: Added ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device-orientation/pull/34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

[matrosov-nikita]

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/212
  
@filmaj, done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

[matrosov-nikita]

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-device-orientation/pull/34
  
@filmaj, done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-test-framework pull request #25: CB-12847: added `bugs` entry...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-test-framework/pull/25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/212
  
Same thing - can you rebase with latest master here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-device-orientation/pull/34
  
@matrosov-nikita can you rebase with latest master first, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-device-orientation/pull/34
  
Just realized you don't have committer rights - I will merge this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/212
  
Huh, strange. Perhaps we should nominate you :)

I will merge this in, then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [NOTICE] Intent on moving to Github

[Filip Maj]

That's really helpful Carlos, thanks!

On Wed, Jun 7, 2017 at 12:47 AM, Steven Gill  wrote:
> Thanks Carlos! Very useful information!
>
> On Tue, Jun 6, 2017 at 5:28 PM, Carlos Santana  wrote:
>
>> ASF will allow it, other projects already showed interest and at ApacheCon
>> they made it public that they will allow it to any project
>>
>> My incubator project OpenWhisk is the first one to work out all the kinks
>>
>> For now let know everyone that wants write access, specially those that are
>> repo owners and usually in charge of merging PRs to:
>> 1. associate your github id in id.apache.org profile
>> 2. enable 2FA in Github.com
>> 3. show up properly under whimsy
>> https://whimsy.apache.org/roster/committee/cordova
>>
>> Once the repos are transferred, a Github team will be created
>> cordova-committers and folks that go thru gitbox setup will be added to
>> this team,  this team will have write access to all
>> github.com/apache/cordova* repos
>>
>> Once transferred need to make it clear to all committers to reconfigure
>> their git upstream, and no longer write to git-wip
>>
>> other projects that moved over like traffic server, went ahead and migrated
>> all the JIRA Issues to Github Issues, a topic for another thread :-)
>>
>> let me know how I can help, will be glad
>>
>> --Carlos
>>
>>
>> On Tue, Jun 6, 2017 at 6:30 PM Steven Gill  wrote:
>>
>> > Yay! Hope ASF allows us to finally do this!
>> >
>> > On Tue, Jun 6, 2017 at 3:28 PM, Filip Maj  wrote:
>> >
>> > > My one comment is OMG YISS!
>> > >
>> > > On Mon, Jun 5, 2017 at 6:41 PM, Shazron  wrote:
>> > > > The Apache Cordova Project Management Committee (PMC) has consensus
>> > that
>> > > we
>> > > > should move primary development of Apache Cordova to Github, from
>> > > Apache's
>> > > > servers (role would be reversed, Apache would then be the mirror
>> now).
>> > > >
>> > > > We are already processing pull requests through Github, although
>> > without
>> > > > write access we couldn't label, or close PRs directly. Enabling of
>> > Issues
>> > > > in Github (to replace JIRA) would be a separate matter, and would
>> > likely
>> > > be
>> > > > on a per-repo basis.
>> > > >
>> > > > Moving is achieved by invitation to the Apache Gitbox project:
>> > > > https://gitbox.apache.org/ (don't get excited if you can log in and
>> > > link,
>> > > > your repo needs to be whitelisted)
>> > > >
>> > > > We would have to file INFRA issues in JIRA to get approval for the
>> > move.
>> > > >
>> > > > We are suggesting a multi-part migration:
>> > > >
>> > > > 1. Top platforms (ios, android, windows, browser)
>> > > > 2. Tools (lib, cli, coho, fetch, common etc) --> we might need a lib
>> > > > breakout first, this is ongoing work
>> > > > 3. All plugins
>> > > >
>> > > > The rest would be on a "as needed" basis.
>> > > >
>> > > > Comments, if any?
>> > >
>> > > -
>> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> > > For additional commands, e-mail: dev-h...@cordova.apache.org
>> > >
>> > >
>> >
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

[matrosov-nikita]

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/212
  
@filmaj, I don't have committer rights.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-device-orientation/pull/34
  
@matrosov-nikita as long as you tested this on one of the real devices 
affected by the issue, and confirmed the fix, I am good to have this merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/212
  
@matrosov-nikita go for it, then. You have committer rights, yes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/150
  
Thanks. I will need to test this manually as the file-transfer CI is super 
broken.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/262
  
Thanks for the PR and the quick responses!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #262: fix(error): changes error message f...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/262


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

[matrosov-nikita]

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-device-orientation/pull/34
  
@filmaj, @infil00p, do I need to do something else on this issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #79: Browser: Check callback exists before ca...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/79
  
Thank you for the PR and the quick responses!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #79: Browser: Check callback exists be...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/79


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

[matrosov-nikita]

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/212
  
@filmaj, no, the same pr was merged into DefinitelyTyped repo 
(https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14138)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture issue #79: CB-12882: (ios): adds support for pe...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media-capture/pull/79
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media-capture/pull/79/commits/d19be5be1fa5dfbc30fbd997f5e780a056616138)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/43/)

 72 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request #79: CB-12882: (ios): adds support...

[stalniy]

Github user stalniy commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120596224
  
--- Diff: src/ios/CDVCapture.m ---
@@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath 
forCallbackId:(NSString*)c
 return [CDVPluginResult resultWithStatus:CDVCommandStatus_OK 
messageAsArray:fileArray];
 }
 
+- (void)showAlertIfAccessProhibeted
+{
+if (![self hasCameraAccess]) {
+[self showPermissionsAlert];
+}
+}
+
+- (BOOL)hasCameraAccess
+{
+if (![AVCaptureDevice 
respondsToSelector:@selector(authorizationStatusForMediaType:)]) {
+return YES;
+}
--- End diff --

Fixed, please check whether I put cordova-ios dependency correctly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #140: Fixed the link to report issues

[dellagustin]

Github user dellagustin commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-media/pull/140#discussion_r120577449
  
--- Diff: README.md ---
@@ -46,7 +46,7 @@ function onDeviceReady() {
 }
 ```
 
-Report issues with this plugin on the [Apache Cordova issue 
tracker](https://issues.apache.org/jira/issues/?jql=project%20%3D%20CB%20AND%20status%20in%20%28Open%2C%20%22In%20Progress%22%2C%20Reopened%29%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Plugin%20Media%22%20ORDER%20BY%20priority%20DESC%2C%20summary%20ASC%2C%20updatedDate%20DESC)
+Report issues with this plugin on the [Apache Cordova issue 
tracker](https://issues.apache.org/jira/browse/CB-12851?jql=project%20%3D%20CB%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22cordova-plugin-media%22%20ORDER%20BY%20priority%20DESC%2C%20summary%20ASC%2C%20updatedDate%20DESC)
--- End diff --

No, that is a mistake, when I fixed the query, the URL was automatically 
redirected to the fist issue resulting from the query and I did not notice it.

I'll change it to:

https://issues.apache.org/jira/issues/?jql=project%20%3D%20CB%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22cordova-plugin-media%22%20ORDER%20BY%20priority%20DESC%2C%20summary%20ASC%2C%20updatedDate%20DESC

and amend my commit.

Thanks for the review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/150
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/150/commits/eaabd8e84e08ef0090d67f32b504d1ff20c75f9d)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/85/)

 306 tests run, 15 skipped, 153 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

[dpogue]

Github user dpogue commented on the issue:

https://github.com/apache/cordova-ios/pull/228
  
@shazron All good now :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS

[dpogue]

Github user dpogue closed the pull request at:

https://github.com/apache/cordova-ios/pull/228


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS

[dpogue]

GitHub user dpogue reopened a pull request:

https://github.com/apache/cordova-ios/pull/228

[CB-10916] Support display name for iOS

This is the iOS Platform API support side of 
https://github.com/apache/cordova-lib/pull/453.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpogue/cordova-ios short-name

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #228


commit 92d9cdaacc698f23100df500edf35ff7f3c17fd1
Author: Darryl Pogue 
Date:   2016-06-07T22:47:38Z

[CB-10916] Support display name for iOS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/150
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/150/commits/f4669ec2f5b20dfeb9aaba3cc3bf4c49cf553abf)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/84/)

 306 tests run, 15 skipped, 148 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: move common, fetch and serve to their own repo

[Shazron]

I will have to prep a new coho release as well.
Can we add coho as a nightly as well or is that too much work?

On Tue, Jun 6, 2017 at 11:16 PM, Steven Gill  wrote:

> I have lifted the code freeze. Feel free to commit again in cordova-lib.
> The modules have officially been broken out. cordova-lib has been moved to
> top level in its existing git repo.
>
> coho repo-clone -r common -r fetch -r serve will clone the modules from
> their new repo
>
> Still have a bit of CI flakiness in cordova-lib repo now (mainly with node
> 6, npm linking). I'll continue to investigate that. Also, still need to
> update nightlies.
>
> https://github.com/apache/cordova-common
> https://github.com/apache/cordova-fetch
> https://github.com/apache/cordova-serve
>
>
> On Tue, Jun 6, 2017 at 3:46 PM, Steven Gill 
> wrote:
>
> > no one make any commits to common, fetch or serve (in cordova-lib) until
> > i'm done ripping it out please
> >
> > On Tue, Jun 6, 2017 at 3:29 PM, Filip Maj  wrote:
> >
> >> Friendly reminder that we will have to update the CI scripts to handle
> >> this now. I believe we are mid-transition away from cloudapp Jenkins
> >> to Travis/AppVeyor now (ping Alex Sorokin).
> >>
> >> On Tue, Jun 6, 2017 at 1:03 AM, Steven Gill 
> >> wrote:
> >> > I've started moving cordova-common, cordova-fetch and cordova-serve
> into
> >> > their own repos.
> >> >
> >> > ISSUE: https://issues.apache.org/jira/browse/CB-11980
> >> >
> >> > It is causing some extra jira notifications. Sorry about that!
> >> >
> >> > -Steve
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>
> >>
> >
>

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/150
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/150/commits/4be0f089431427aad2aa6c42146d45c31fdcb6b6)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/83/)

 306 tests run, 15 skipped, 149 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: move common, fetch and serve to their own repo

[Steven Gill]

I have lifted the code freeze. Feel free to commit again in cordova-lib.
The modules have officially been broken out. cordova-lib has been moved to
top level in its existing git repo.

coho repo-clone -r common -r fetch -r serve will clone the modules from
their new repo

Still have a bit of CI flakiness in cordova-lib repo now (mainly with node
6, npm linking). I'll continue to investigate that. Also, still need to
update nightlies.

https://github.com/apache/cordova-common
https://github.com/apache/cordova-fetch
https://github.com/apache/cordova-serve


On Tue, Jun 6, 2017 at 3:46 PM, Steven Gill  wrote:

> no one make any commits to common, fetch or serve (in cordova-lib) until
> i'm done ripping it out please
>
> On Tue, Jun 6, 2017 at 3:29 PM, Filip Maj  wrote:
>
>> Friendly reminder that we will have to update the CI scripts to handle
>> this now. I believe we are mid-transition away from cloudapp Jenkins
>> to Travis/AppVeyor now (ping Alex Sorokin).
>>
>> On Tue, Jun 6, 2017 at 1:03 AM, Steven Gill 
>> wrote:
>> > I've started moving cordova-common, cordova-fetch and cordova-serve into
>> > their own repos.
>> >
>> > ISSUE: https://issues.apache.org/jira/browse/CB-11980
>> >
>> > It is causing some extra jira notifications. Sorry about that!
>> >
>> > -Steve
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>
>

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/228
  
@dpogue bah, same timeout error. Please do the close and re-open PR dance 
again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

[homen]

Github user homen commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/150
  
@filmaj All my editors showing correct alignment. Anyhow I fixed this with 
five commits :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/262
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/262/commits/c3d7e55ad428bd154fa6bf5bcd38ee53b152)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/175/)

 316 tests run, 34 skipped, 1 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org