Nightly build #375 for cordova has failed

[Apache Jenkins Server]

Nightly build #375 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/375/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/375/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37/commits/fddccc4dce724b51aea662221150501a672e0382)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/31/)

 2 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38/commits/410b6cf4adc544e9d62c59e1fe5875d57bc3b2cc)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/30/)

 2 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine pull request #38: Dynamic Swipe Preference

[ccorcos]

GitHub user ccorcos opened a pull request:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38

Dynamic Swipe Preference

This PR lets you dynamically change whether or not you can swipe navigation 
using `window.WkWebView.allowsBackForwardNavigationGestures(boolean)`

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ccorcos/cordova-plugin-wkwebview-engine 
dynamic-swipe-pref

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #38


commit 1109a1ace113579e76ad2384f966d8442ce14b4f
Author: Chet Corcos 
Date:   2017-06-15T01:04:14Z

Dynamically set allowsBackForwardNavigationGestures

commit 0b6b29f9dee9cf326313639bf197c09c19c9dd18
Author: Chet Corcos 
Date:   2017-06-15T01:35:16Z

Move code into proper @implementation

commit cf1cb7b82516d4103f9913868183e829eab3b912
Author: Chet Corcos 
Date:   2017-06-15T01:46:51Z

Separate window.WkWebView js module into another file

commit 410b6cf4adc544e9d62c59e1fe5875d57bc3b2cc
Author: Chet Corcos 
Date:   2017-06-15T01:50:55Z

Readme




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37/commits/25dbc3d5019ab0f2efc3e9a41c9d6bd95c35ebdf)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/29/)

 2 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37/commits/c6e82965d20afe0733d271418b1f14ab3273d92b)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/28/)

 0 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #562: Removing lazy load, platform command refactor...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/562#discussion_r122097628
  
--- Diff: spec-cordova/platform.spec.ios.js ---
@@ -1,137 +0,0 @@
-/**
--- End diff --

These tests got moved out to cordova-ios?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #562: Removing lazy load, platform command refactor...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/562#discussion_r122101116
  
--- Diff: src/cordova/platform.js ---
@@ -1,769 +0,0 @@
-/**
--- End diff --

to confirm, you ripped out this file into multpile smaller files. I like 
it. It has been replaced by addHelper.js, check.js, 
getPlatformDetailsFromDir.js, index.js, list.js, remove.js and save.js

I see tests for addHelper. Do the other modules need new unit tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #562: Removing lazy load, platform command refactor...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/562#discussion_r122097578
  
--- Diff: spec-cordova/platform/addHelper.spec.js ---
@@ -0,0 +1,515 @@
+/**
--- End diff --

This file is just a placeholder for now right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37/commits/22cbc6f2379b4176bc25e2572ce6592ae646704c)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/27/)

 0 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37/commits/5d2acc772d564e11b3d9c525b3be4c7ebb0936f1)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/26/)

 2 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

[cjpearson]

Github user cjpearson commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37
  
Since this plugin just swizzles the WKWebView class, you can make it 
separate plugin instead of a fork. It might make maintenance easier. Look in 
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30 for an 
example.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #563: CB-11713 and CB-11961

[goya]

Github user goya commented on the issue:

https://github.com/apache/cordova-lib/pull/563
  
should be fixed now.  got bit by false git documentation on git < 2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #563: CB-11713 and CB-11961

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/563
  
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr=h1) 
Report
> Merging 
[#563](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-lib/commit/e69b9e4efc69054e22b40d89db9f310ec4ec3ba9?src=pr=desc)
 will **increase** coverage by `0.04%`.
> The diff coverage is `100%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-lib/pull/563/graphs/tree.svg?token=KwBjKMXLqA=pr=650=150)](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr=tree)

```diff
@@Coverage Diff @@
##   master #563  +/-   ##
==
+ Coverage   80.12%   80.17%   +0.04% 
==
  Files  57   57  
  Lines3960 3969   +9 
  Branches  832  832  
==
+ Hits 3173 3182   +9 
  Misses787  787
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[src/gitclone.js](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr=tree#diff-c3JjL2dpdGNsb25lLmpz)
 | `100% <100%> (ø)` | :arrow_up: |
| 
[src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr=tree#diff-c3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==)
 | `84.59% <100%> (ø)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr=footer). 
Last update 
[e69b9e4...1c820da](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #386: CB-12895 : added eslint and removed jshin...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-android/pull/386

CB-12895 : added eslint and removed jshint / reformatted with eslint 



### Platforms affected


### What does this PR do?

Added eslint and removed jshint / reformatted with eslint.

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-android CB-12895

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #386


commit 8e4e071e5d6f3427feaf6e216db9757c42c0f0ea
Author: Audrey So 
Date:   2017-06-09T18:18:57Z

CB-12895 : added eslint and removed jshint

commit 4e19a0ce08a2a117990ba20d7ef1fbb0f6ebcd5b
Author: Audrey So 
Date:   2017-06-13T18:42:20Z

CB-12895 : fixed eslint errors




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #32: Cb 12804

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-browser/pull/32

Cb 12804

### Platforms affected
cordova-browser

### What does this PR do?
adds manifest.json support

### What testing has been done on this change?
added tests

This pr includes all commits from #30 which can be closed.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-browser CB-12804

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-browser/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #32


commit eec8c5398440f6fcbbd4e5c1178c46c3d12df688
Author: Audrey So 
Date:   2017-05-26T16:38:09Z

CB-12804 : manifest.json added to browser during create

commit 4a52f045e4beb0d991db613937061757df9638f9
Author: Jesse MacFadyen 
Date:   2017-06-01T20:21:32Z

work in progress

commit b85f06ba6a17f8cbd551ef5f827e24384084a72f
Author: Jesse MacFadyen 
Date:   2017-06-02T18:50:58Z

Updated images to improve lighthouse score. Added orientation to manifest.

commit 3052805af944a38fa54926393d4f49e49c8cae11
Author: Jesse MacFadyen 
Date:   2017-06-04T06:51:49Z

add link rel=manifest, more manifest specs to check

commit 012191c3011076f995f4ec2af8f8729d153fd4e7
Author: Jesse MacFadyen 
Date:   2017-06-04T07:00:04Z

remove console.log to stop whining CI

commit 146fb74b69e0c24e56ecff38f0e38aad8353e9fd
Author: Jesse MacFadyen 
Date:   2017-06-06T18:47:08Z

remove old xhr-activex windows bs, update to use pagevisibility instead of 
webkitpagevisibility

commit 5b837270c26d0ee8856ebbf018f516f5998136c9
Author: Jesse MacFadyen 
Date:   2017-06-07T22:55:11Z

output create events, copy manifest.json from template to platform_www

commit c4511806452014fd99f5cce6f5ce73614402063a
Author: Jesse MacFadyen 
Date:   2017-06-09T18:54:09Z

clean up some cruft, create emit errors, removed old ActiveX seeking xhr 
code

commit 2e63f9fe43d0e927f9d2ab9cfc2aedd1c2f74f36
Author: Jesse MacFadyen 
Date:   2017-06-14T23:23:58Z

run gets start_url from manifest, spec verifies manifest, Api delays 
writing to manifest and uses platform_www/




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #319: Updating unit tests + unit test runner and ad...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/319


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec issue #144: Use path.sep instead of Unix separator.

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-mobile-spec/pull/144
  
Thank you very much for the PR!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request #144: Use path.sep instead of Unix separato...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-mobile-spec/pull/144


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request #144: Use path.sep instead of Unix separato...

[halton]

Github user halton commented on a diff in the pull request:

https://github.com/apache/cordova-mobile-spec/pull/144#discussion_r122075324
  
--- Diff: createmobilespec/createmobilespec.js ---
@@ -365,7 +365,7 @@ shelljs.config.fatal = true;
 if (argv.clearnpmcache) {
 // clean out cached platforms and plugins and app-hello-world
 var home_dir = process.env.HOME || process.env.HOMEPATH || 
process.env.USERPROFILE;
-shelljs.rm("-rf", path.join(home_dir, ".cordova/npm_cache"));
+shelljs.rm("-rf", path.join(home_dir, ".cordova" + path.sep + 
"npm_cache"));
--- End diff --

Updated and pushed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request #144: Use path.sep instead of Unix separato...

[filmaj]

Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-mobile-spec/pull/144#discussion_r122072468
  
--- Diff: createmobilespec/createmobilespec.js ---
@@ -365,7 +365,7 @@ shelljs.config.fatal = true;
 if (argv.clearnpmcache) {
 // clean out cached platforms and plugins and app-hello-world
 var home_dir = process.env.HOME || process.env.HOMEPATH || 
process.env.USERPROFILE;
-shelljs.rm("-rf", path.join(home_dir, ".cordova/npm_cache"));
+shelljs.rm("-rf", path.join(home_dir, ".cordova" + path.sep + 
"npm_cache"));
--- End diff --

you can just use provide ".cordova" and "npm_cache" as separate arguments 
to `path.join` here - `join` will handle using the proper separator. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request #144: Use path.sep instead of Unix separato...

[halton]

GitHub user halton opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/144

Use path.sep instead of Unix separator.



### Platforms affected


### What does this PR do?
Fix the unix format patch on Windows host

### What testing has been done on this change?
jshint

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/halton/cordova-mobile-spec sep

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #144


commit 3088eb80c8fddaea1a18f0b11a7981dfe726c8fb
Author: Halton Huo 
Date:   2017-06-14T18:35:04Z

CB-12920 Use path.sep instead of Unix seperator.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-ios/pull/319
  
Yay, green! And looks like the codecov reporting is fixed too ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/319
  
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=h1) 
Report
> :exclamation: No coverage uploaded for pull request base 
(`master@8c77a0b`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `63.63%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/319/graphs/tree.svg?src=pr=650=WomDD5jInz=150)](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=tree)

```diff
@@Coverage Diff@@
## master #319   +/-   ##
=
  Coverage  ?   63.77%   
=
  Files ?   14   
  Lines ? 1623   
  Branches  ?  277   
=
  Hits  ? 1035   
  Misses?  588   
  Partials  ?0
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[bin/templates/scripts/cordova/lib/versions.js](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ZlcnNpb25zLmpz)
 | `11.9% <ø> (ø)` | |
| 
[bin/templates/scripts/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NoZWNrX3JlcXMuanM=)
 | `40% <ø> (ø)` | |
| 
[bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz)
 | `36.84% <100%> (ø)` | |
| 
[bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz)
 | `53.89% <40%> (ø)` | |
| 
[bin/templates/scripts/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3J1bi5qcw==)
 | `22.41% <68.75%> (ø)` | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=footer). 
Last update 
[8c77a0b...82aaf01](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file issue #199: CB-12355: (iOS) fix FileEntry.file.type

[rodreiser]

Github user rodreiser commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/199
  
someone can merge this? i really need it !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-ios/pull/319
  
Made some more changes, rebased, confirmed the unit tests now run on my 
Windows 10 VM.

Sucks to be running tests conditionally but I'm not sure what other option 
we have.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #384: CB-11244: Studio project cleanup

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/384
  
# 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=h1) 
Report
> Merging 
[#384](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/3a6e898b12eac31dfc16a4c526dfba8fab158723?src=pr=desc)
 will **decrease** coverage by `0.29%`.
> The diff coverage is `20.58%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/384/graphs/tree.svg?token=q14nMf6C5a=pr=650=150)](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree)

```diff
@@Coverage Diff@@
##   master #384 +/-   ##
=
- Coverage   39.52%   39.22%   -0.3% 
=
  Files  16   16 
  Lines1551 1555  +4 
  Branches  277  279  +2 
=
- Hits  613  610  -3 
- Misses938  945  +7
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `33.33% <ø> (ø)` | :arrow_up: |
| 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `28.84% <0%> (-1.3%)` | :arrow_down: |
| 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `10.13% <0%> (-0.21%)` | :arrow_down: |
| 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `18.18% <0%> (ø)` | :arrow_up: |
| 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (ø)` | :arrow_up: |
| 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `19.62% <15.78%> (-0.38%)` | :arrow_down: |
| 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `42.37% <33.33%> (-0.61%)` | :arrow_down: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=footer).
 Last update 
[3a6e898...49b76f5](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #712: CB-11373 - document config.xml widget attrib...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/712


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #712: CB-11373 - document config.xml widget attributes an...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-docs/pull/712
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15/commits/ff18817cac25f9be6c652756fb84f8be080fb3cd)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/25/)

 0 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #270: CB-12912 - Incorrect 'Report Bugs' link in...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/270
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/270/commits/dfa5392de0e4c9608fd6e0207111b2434e58d26b)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/176/)

 316 tests run, 34 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request #22: CB-12168(ios):"Fix to upgrade to io...

[sruthakeerthikotla]

Github user sruthakeerthikotla closed the pull request at:

https://github.com/apache/cordova-plugin-console/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #270: CB-12912 - Incorrect 'Report Bugs' ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/270


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #270: CB-12912 - Incorrect 'Report Bugs' ...

[shazron]

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/270

CB-12912 - Incorrect 'Report Bugs' link in README

### What does this PR do?

Fix broken link.

### What testing has been done on this change?

Tested new link by clicking on it

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-plugin-camera CB-12912

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #270


commit dfa5392de0e4c9608fd6e0207111b2434e58d26b
Author: Shazron Abdullah 
Date:   2017-06-14T08:52:14Z

CB-12912 - Incorrect 'Report Bugs' link in README




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #712: CB-11373 - document config.xml widget attrib...

[shazron]

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-docs/pull/712

CB-11373 - document config.xml widget attributes android-packageName, 
android-activityName, ios-CFBundleIdentifier

### What testing has been done on this change?

Generated the docs. 

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.

### Preview:

![screen shot 2017-06-14 at 1 18 49 
am](https://user-images.githubusercontent.com/36107/27123248-24aff6ea-50a2-11e7-8f3d-a32a82fe77f4.png)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-docs CB-11373

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/712.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #712


commit 173044e09e171343f28c884c5fbd8b864b0d7a90
Author: Shazron Abdullah 
Date:   2017-06-14T08:37:13Z

CB-11373 - document config.xml widget attributes android-packageName, 
android-activityName, ios-CFBundleIdentifier




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org