[GitHub] cordova-ios pull request #322: CB-12948 - Add a warning to updateProject for...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/322


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #408 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #408 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/408/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #322: CB-12948 - Add a warning to updateProject for iOS

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/322
  
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr=h1) 
Report
> Merging 
[#322](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-ios/commit/4490abf273ec6d12810c8ff5ea16d197c58ecd4b?src=pr=desc)
 will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/322/graphs/tree.svg?width=650=150=pr=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr=tree)

```diff
@@   Coverage Diff   @@
##   master #322   +/-   ##
===
  Coverage   63.77%   63.77%   
===
  Files  14   14   
  Lines1623 1623   
  Branches  277  277   
===
  Hits 1035 1035   
  Misses588  588
```



--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr=footer). 
Last update 
[4490abf...4fbaebd](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #322: CB-12948 - Add a warning to updateProject for...

[shazron]

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-ios/pull/322

CB-12948 - Add a warning to updateProject for iOS

### Platforms affected

self

### What does this PR do?

Remove the `cordova platform update` functionality of this platform, and 
provide text on what to do instead (remove, then add the platform). We treat 
the platforms folder as a build artifact.

### What testing has been done on this change?

Created a project, added an older platform, and updated to the platform in 
this PR. It prints out the error text expected.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-12948

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/322.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #322


commit 2b8d9d251571f043b58d5649b7a0d21b345c9222
Author: Shazron Abdullah 
Date:   2017-06-24T00:57:48Z

CB-12948 - Add a warning to updateProject for iOS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

[Shazron]

In the interim, I filed: https://issues.apache.org/jira/browse/CB-12948 and
will send a PR for comment

On Fri, Dec 2, 2016 at 4:56 PM, Shazron  wrote:

> This has not been resolved yet. We'll discuss more next week.
>
> Archive link to this thread just in case you don't have it:
> https://lists.apache.org/thread.html/dfeaab003cf67e915e342ebbf38268
> 88c3b604d151e01dbaf9ab9950@1457466905@%3Cdev.cordova.apache.org%3E
>
> Jesse's proposal to help fix this:
> https://github.com/cordova/cordova-discuss/issues/50
>
>
> On Sun, Mar 20, 2016 at 12:06 PM, julio cesar sanchez <
> jcesarmob...@gmail.com> wrote:
>
>> Not sure how many people still uses the non CLI approach, but the
>> phonegap.com tutorial for android embedded webviews it uses it.
>>
>> 2016-03-19 2:34 GMT+01:00 Shazron :
>>
>> > Another issue: we still document the non-CLI way to update projects.
>> > This was brought to my attention in a comment [1] in CB-10775.
>> >
>> > The platform specific way is still mentioned [2], and update
>> > instructions for iOS [3] and android [4] still exist.
>> >
>> > I think we should not have any more "update" docs that don't involve
>> > the CLI. What do you think?
>> >
>> > [1]
>> > https://issues.apache.org/jira/browse/CB-10775?focusedCommen
>> tId=15200735=com.atlassian.jira.plugin.system.
>> issuetabpanels:comment-tabpanel#comment-15200735
>> > [2]
>> > https://cordova.apache.org/docs/en/latest/guide/overview/ind
>> ex.html#development-paths
>> > [3]
>> > http://cordova.apache.org/docs/en/latest/guide/platforms/
>> ios/upgrade.html
>> > [4]
>> > http://cordova.apache.org/docs/en/latest/guide/platforms/
>> android/upgrade.html
>> >
>> >
>> > On Wed, Mar 16, 2016 at 7:44 AM, Carlos Santana 
>> > wrote:
>> > > yep  I agree Julio about adding more power to config.xml, that's
>> > basically
>> > > what Mike's hook those allow  tag in config.xml
>> > >
>> > >
>> > > On Wed, Mar 16, 2016 at 10:23 AM julio cesar sanchez <
>> > jcesarmob...@gmail.com>
>> > > wrote:
>> > >
>> > >> I like Jesse's proposal
>> > >>
>> > >> for #3 I think we should use a new command, I like cordova
>> *downgrade*
>> > >> platform
>> > >>
>> > >> As I usually read most cordova questions on stackoverflow, most
>> people
>> > is
>> > >> editing and tellign others to edit the .plist manually and doing some
>> > other
>> > >> manual changes. I always point them to use hooks or plugins to do
>> that,
>> > but
>> > >> as it's harder they don't want to do it.
>> > >>
>> > >> BTW, I think we should add a way to write on the AndroidManifest.xml
>> and
>> > >> info.plist from the config.xml as phonegap build does, using the
>> > >> config-file tag. Right now it's possible to use the config-file tag
>> on
>> > >> plugin.xml but not on config.xml
>> > >>
>> > >>
>> > >>
>> > >>
>> > >> 2016-03-16 14:54 GMT+01:00 Carlos Santana :
>> > >>
>> > >> > Here is an example [1] of hooks created by ionic team member
>> extending
>> > >> > config.xml to allow user to configure their native sdk settings
>> > allowing
>> > >> > have platforms as build artifacts.
>> > >> >
>> > >> > This could be a start at looking at some basic configuration
>> settings
>> > via
>> > >> > hooks cordova provides or just in cordova tooling (i.e. platformAPI
>> > >> parser)
>> > >> >
>> > >> > [1]: https://github.com/mhartington/cordova-config-utils
>> > >> >
>> > >> >
>> > >> > On Tue, Mar 15, 2016 at 10:31 PM Carlos Santana <
>> csantan...@gmail.com
>> > >
>> > >> > wrote:
>> > >> >
>> > >> > > Scratch the "migrate cli command" idea. Now I think about it
>> really
>> > >> messy
>> > >> > > and it will be another hackHooks.
>> > >> > >
>> > >> > > I think we concentrate to provide more capabilities thru
>> config.xml
>> > and
>> > >> > > hooks for making migration more smooth.
>> > >> > >
>> > >> > > Like a running hooks on after_platform_update event and providing
>> > more
>> > >> > > information in the hook context argument with from to platform
>> info
>> > >> > >
>> > >> > >
>> > >> > >
>> > >> > > On Tue, Mar 15, 2016 at 9:52 PM Carlos Santana <
>> > csantan...@gmail.com>
>> > >> > > wrote:
>> > >> > >
>> > >> > >> By "I like the proposal and deleting all previous versions I
>> don't
>> > see
>> > >> > as
>> > >> > >> an issue." I meant that I don't have an issue if we don't have
>> this
>> > >> > feature
>> > >> > >> to clean old. I prefer not to have it
>> > >> > >>
>> > >> > >> On Tue, Mar 15, 2016 at 9:51 PM Carlos Santana <
>> > csantan...@gmail.com>
>> > >> > >> wrote:
>> > >> > >>
>> > >> > >>> I like the proposal and deleting all previous versions I don't
>> > see as
>> > >> > an
>> > >> > >>> issue.
>> > >> > >>>
>> > >> > >>> I didn't get the part of using symlinks, I don't symlinks they
>> > bring
>> > >> a
>> > >> > >>> lot of problems to implement correctly I prefer we stick to
>> real
>> > >> > directory
>> > >> > >>> and rename directories, user can choose to create symlinks on
>> > 

[GitHub] cordova-plugin-network-information issue #54: CB-12751: (ios) Fix connection...

[kylemellander]

Github user kylemellander commented on the issue:

https://github.com/apache/cordova-plugin-network-information/pull/54
  
Just as a note and I don't seem to have permissions to post to jira, it 
seems that this error is happening on android as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #128: Fix CB-12947 (incorrect documentatio...

[jab]

Github user jab commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/128
  
Thanks for merging and for Cordova!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup

[imhotep]

Github user imhotep commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123851340
  
--- Diff: bin/lib/create.js ---
@@ -259,41 +273,53 @@ exports.create = function(project_path, config, 
options, events) {
 
 setShellFatal(true, function() {
 var project_template_dir = options.customTemplate || 
path.join(ROOT, 'bin', 'templates', 'project');
+var app_path = path.join(project_path, 'app', 'src', 'main');
--- End diff --

Is this default? do you plan on having a way to create old project 
structure still? or is the plan to just support managing the old 
structures while only being able to create the new (Android Studio) structure?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup

[imhotep]

Github user imhotep commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123850564
  
--- Diff: bin/templates/cordova/Api.js ---
@@ -343,6 +349,8 @@ Api.prototype.removePlugin = function (plugin, 
uninstallOptions) {
  */
 Api.prototype.build = function (buildOptions) {
 var self = this;
+if(this.android_studio)
+  buildOptions.studio = true;
--- End diff --

I think it makes to have abstracted somewhere else as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup

[imhotep]

Github user imhotep commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123850098
  
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -148,6 +152,7 @@ module.exports.runClean = function(options) {
  */
 module.exports.run = function(options, optResolvedTarget) {
 var opts = parseOpts(options, optResolvedTarget, this.root);
+console.log(opts.buildMethod);
--- End diff --

another one :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup

[imhotep]

Github user imhotep commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123849628
  
--- Diff: bin/templates/cordova/lib/builders/GenericBuilder.js ---
@@ -53,43 +48,13 @@ GenericBuilder.prototype.findOutputApks = 
function(build_type, arch) {
 var self = this;
 return Object.keys(this.binDirs)
 .reduce(function (result, builderName) {
+console.log('builderName:'+ builderName);
--- End diff --

don't forget this in there ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...

[imhotep]

Github user imhotep commented on the issue:

https://github.com/apache/cordova-lib/pull/568
  
I support this change. I believe it will make writing tests for new 
features easier if each source file has a matching spec file and all 
source/spec folders are mirrored.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup

[infil00p]

Github user infil00p commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123844605
  
--- Diff: bin/lib/create.js ---
@@ -125,16 +131,24 @@ function writeProjectProperties(projectPath, 
target_api) {
 fs.writeFileSync(dstPath, data);
 }
 
-function prepBuildFiles(projectPath) {
+// This makes no sense, what if you're building with a different build 
system?
--- End diff --

We're already doing that in the next two lines? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup

[filmaj]

Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123835148
  
--- Diff: bin/templates/cordova/Api.js ---
@@ -81,10 +83,13 @@ function Api(platform, platformRootDir, events) {
 // XXX Override some locations for Android Studio projects
 if(AndroidStudio.isAndroidStudioProject(self.root) === true) {
   selfEvents.emit('log', 'Android Studio project detected');
+  this.builder='studio';
   this.android_studio = true;
   this.locations.configXml = path.join(self.root, 
'app/src/main/res/xml/config.xml');
-  this.locations.strings = path.join(self.root, 
'app/src/main/res/xml/strings.xml');
+  this.locations.strings = path.join(self.root, 
'app/src/main/res/values/strings.xml');
   this.locations.manifest = path.join(self.root, 
'app/src/main/AndroidManifest.xml');
+  //We could have Java Source, we could have other languages
+  this.locations.javaSrc = path.join(self.root, 'app/src/main/java/');
--- End diff --

Same sort of deal, we could push the responsibility for figuring out the 
locations to the builders, rather than have the Api function worry about each 
possible implementation of a project structure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #34: CB-11710 Add missing 'clean.bat' file

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-browser/pull/34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #34: CB-11710 Add missing 'clean.bat' file

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-browser/pull/34

CB-11710 Add missing 'clean.bat' file


### Platforms affected
browser ( when run on windows )

### What does this PR do?
adds missing clean.bat file

### What testing has been done on this change?


### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-browser CB-11710

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-browser/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #34


commit 7944f46521ddfe1559443c848f3e8a6d50b34bb8
Author: Jesse MacFadyen 
Date:   2017-06-23T20:09:40Z

CB-11710 Add missing 'clean.bat' file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup

[filmaj]

Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123834608
  
--- Diff: bin/lib/create.js ---
@@ -314,7 +340,18 @@ exports.update = function(projectPath, options, 
events) {
 return Q()
 .then(function() {
 
-var manifest = new AndroidManifest(path.join(projectPath, 
'AndroidManifest.xml'));
+var isAndroidStudio = 
AndroidStudio.isAndroidStudioProject(projectPath);
+var isLegacy = !isAndroidStudio;
+var manifest = null;
+var builder = 'gradle';
+
+if(isAndroidStudio) {
+  manifest = new AndroidManifest(path.join(projectPath, 'app', 
'main', 'AndroidManifest.xml'));
+  builder = 'studio';
+} else {
+  manifest = new AndroidManifest(path.join(projectPath, 
'AndroidManifest.xml'));
+  builder = 'gradle';
+}
--- End diff --

Same thing here, this may be better folded up into the Builders?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup

[filmaj]

Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/384#discussion_r123834356
  
--- Diff: bin/lib/create.js ---
@@ -125,16 +131,24 @@ function writeProjectProperties(projectPath, 
target_api) {
 fs.writeFileSync(dstPath, data);
 }
 
-function prepBuildFiles(projectPath) {
+// This makes no sense, what if you're building with a different build 
system?
--- End diff --

Would folding this functionality up into the Builder abstraction make sense 
here? Would different project structures require different building different 
things at create time as well? Put otherwise: do the Builders have to do 
specific things at create-time as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #128: Fix CB-12947 (incorrect documentatio...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/128
  
Thanks for the PR!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #386: CB-12895 : added eslint and removed jshin...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/386


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #128: Fix CB-12947 (incorrect docum...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/128


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/386
  
I believe in you, you can do it!


![i-have-hope](https://user-images.githubusercontent.com/52645/27492826-38aa9a02-580d-11e7-88f6-5e238542f2b5.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...

[audreyso]

Github user audreyso commented on the issue:

https://github.com/apache/cordova-android/pull/386
  
I think I have permission, but haven't ever done it before! @filmaj 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/386
  
Do you not have permissions to merge, or do you have your hands full with 
other work? Happy to merge this in for you but if it's a permission issue 
please let me know so that I can fix that :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-lib/pull/561
  
Your experience going through the integration tests in here is valuable 
with respect to understanding what code these tests exercise, so armed with 
that knowledge, I think you have the right context to add unit tests for that 
code (and instead, delete the integration tests relevant to that code).

As for whether it's in this PR or a separate one, your call. There will 
probably end up being extraneous commits in this PR. I would probably issue a 
new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...

[audreyso]

Github user audreyso commented on the issue:

https://github.com/apache/cordova-lib/pull/561
  
@filmaj I rebased this for now. If we change the tests to unit tests, 
should it be in this PR or in a separate one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...

[audreyso]

Github user audreyso commented on the issue:

https://github.com/apache/cordova-android/pull/386
  
I rebased this morning! @filmaj @infil00p If anyone has time to merge it 
in, that would be great :)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #128: Fix CB-12947 (incorrect docum...

[jab]

GitHub user jab opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/128

Fix CB-12947 (incorrect documentation of iPhone 5 and 5s resolution)

iPhone 5, 5s, and SE have resolution 640x1136, not 640x960 as currently 
documented.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jab/cordova-plugin-splashscreen patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #128


commit c81df6f274d08f3214ba8a692f74741fa0cfe1a1
Author: jab 
Date:   2017-06-23T15:39:29Z

CB-12947: (docs) Fix iPhone 5 and 5s resolution

(and add iPhone SE which was missing)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #385: CB-12835: add a Context getter in CordovaInterfa...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/385
  
Does anything need to change in the plugin authoring documentation for 
Android as a result of this?


https://cordova.apache.org/docs/en/latest/guide/platforms/android/plugin.html

Maybe the Android Integration section needs updating? It references that 
the context is no longer available?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Cloudapp CI is down, builds moving to Travis

[Filip Maj]

Nice! It's also awesome to have the CI code end up in the yml files
inside the repositories, rather than jenkins job configs on cloudapps.

On Fri, Jun 23, 2017 at 1:38 AM,   wrote:
> So I've finally managed to get it working, here's an example of PR for 
> battery-status plugin:
> https://github.com/apache/cordova-plugin-battery-status/pull/55
>
> Now I'm working to propagate it through other plugin repositories. Soon we'll 
> have plugin PRs covered again!
>
> -Original Message-
> From: Filip Maj [mailto:maj@gmail.com]
> Sent: Wednesday, June 21, 2017 7:49 PM
> To: dev@cordova.apache.org
> Subject: Re: Cloudapp CI is down, builds moving to Travis
>
> I know Sauce Connect pretty well from my days working at Sauce Labs :)
>
> Not sure if appropriate for the dev list - if not, message me on slack and 
> I'd be happy to help any way I can.
>
> On Wed, Jun 21, 2017 at 11:34 AM,   wrote:
>> Yeah, forgot to give a link to JIRA issue:
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissue
>> s.apache.org%2Fjira%2Fbrowse%2FCB-12935=02%7C01%7Cv-alsoro%40micr
>> osoft.com%7C0a08a8f1a3124373201b08d4b8c57105%7C72f988bf86f141af91ab2d7
>> cd011db47%7C1%7C0%7C636336605526115838=YOC2cn07fgQxDZ8dgOAl%2Frd
>> RsLMvgJGUm%2B%2BTHmol54M%3D=0
>>
>> For now, I'm wrestling with Sauce Connect and jwt plugins for Travis in an 
>> attempt to make secure variables work for PRs from external forks. Besides 
>> that, there is nothing holding us from running these builds, so if you have 
>> any insight on that, I'd be glad to hear it.
>>
>> -Original Message-
>> From: Filip Maj [mailto:maj@gmail.com]
>> Sent: Wednesday, June 21, 2017 4:33 PM
>> To: dev@cordova.apache.org
>> Subject: Re: Cloudapp CI is down, builds moving to Travis
>>
>> Any JIRA issues we should look at to track progress?
>>
>> Alex, what can we do to assist? seems like a lot of work - let us know!
>>
>> On Wed, Jun 21, 2017 at 5:39 AM,   wrote:
>>> Our Plugins testing CI (Jenkins) is officially dead now.
>>> We're migrating all the jobs to Travis and AppVeyor, but for the time
>>> being, all PRs to the plugin repos are not being tested. I'm working
>>> to enable Travis and AppVeyor builds as soon as possible, but there
>>> are some unexpected hassle with encrypted env.variables.
>>>
>>> Will keep you posted.
>>>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request #54: CB-12935: (ios, android) Enab...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-device-motion/pull/54

CB-12935: (ios, android) Enable paramedic builds on Travis CI

### Platforms affected
iOS, Android

### What does this PR do?
https://issues.apache.org/jira/browse/CB-12935
Enables paramedic builds on Travis CI for device plugin repo.

### What testing has been done on this change?
The Travis CI run which is going to start after the PR is submitted.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-device-motion master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-device-motion/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54


commit 4beac4e977fbb1941eabd00abe5eb9f895494030
Author: Alexander Sorokin 
Date:   2017-06-23T11:37:57Z

CB-12935: (ios, android) Enable paramedic builds on Travis CI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request #64: CB-12935: (ios, android) Enable para...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/64


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request #64: CB-12935: (ios, android) Enable para...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-device/pull/64

CB-12935: (ios, android) Enable paramedic builds on Travis CI

### Platforms affected
iOS, Android

### What does this PR do?
https://issues.apache.org/jira/browse/CB-12935
Enables paramedic builds on Travis CI for device plugin repo.

### What testing has been done on this change?
The Travis CI run which is going to start after the PR is submitted.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-device master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-device/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #64


commit 2d845036befa5152ab9b87011c0970cc95833e69
Author: Alexander Sorokin 
Date:   2017-06-23T11:12:13Z

CB-12935: (ios, android) Enable paramedic builds on Travis CI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request #153: CB-12935: (ios, android) Enable p...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/153


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request #153: CB-12935: (ios, android) Enable p...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/153

CB-12935: (ios, android) Enable paramedic builds on Travis CI

### Platforms affected
Android, iOS

### What does this PR do?
https://issues.apache.org/jira/browse/CB-12935
Enables paramedic builds on TravisCI.

### What testing has been done on this change?
This PR will trigger a Travis build.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-contacts master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #153






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request #23: CB-12935: (ios, android) Run parame...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-console/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request #23: CB-12935: (ios, android) Run parame...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-console/pull/23

CB-12935: (ios, android) Run paramedic builds on Travis

### Platforms affected
Android, iOS

### What does this PR do?
https://issues.apache.org/jira/browse/CB-12935
Enables Paramedic builds on Travis CI for cordova-plugin-console

### What testing has been done on this change?
This PR is going to trigger the test run

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-console master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-console/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #23


commit 45d4e38b5d807aa3eb5e19c712cb387414a80239
Author: Alexander Sorokin 
Date:   2017-06-23T09:17:35Z

CB-12935: (ios, android) Run paramedic builds on Travis




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request #56: CB-12935: (CI) Travis should...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-battery-status/pull/56


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request #56: CB-12935: (CI) Travis should...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/56

CB-12935: (CI) Travis should use Node 4.2 instead of 0.10

### Platforms affected
Android

### What does this PR do?
Makes Travis install Node 4.2 instead of default 0.x

### What testing has been done on this change?
The Travis build just under this PR

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-battery-status master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #56


commit 8ca07a96fa3907496462d3da33246c878fc4cd90
Author: Alexander Sorokin 
Date:   2017-06-23T08:01:44Z

CB-12935: (CI) Travis should use Node 4.2 instead of 0.10




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #272: CB-12935: (android, ios) Run parame...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/272


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status issue #55: CB-12935 Run paramedic builds on Tr...

[alsorokin]

Github user alsorokin commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/55
  
Oh, and we need to encode sauce access key for each repository separately.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status issue #55: CB-12935 Run paramedic builds on Tr...

[alsorokin]

Github user alsorokin commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/55
  
Mostly, yes, with some modifications (for example, Camera tests require 
Android support repository and have other tests to run, which are needed to be 
brought out to a separate job).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status issue #55: CB-12935 Run paramedic builds on Tr...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/55
  
Awesome! 
Is the next step to just copy this to the other plugin repos?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Cloudapp CI is down, builds moving to Travis

[alsorokin]

So I've finally managed to get it working, here's an example of PR for 
battery-status plugin:
https://github.com/apache/cordova-plugin-battery-status/pull/55

Now I'm working to propagate it through other plugin repositories. Soon we'll 
have plugin PRs covered again!

-Original Message-
From: Filip Maj [mailto:maj@gmail.com] 
Sent: Wednesday, June 21, 2017 7:49 PM
To: dev@cordova.apache.org
Subject: Re: Cloudapp CI is down, builds moving to Travis

I know Sauce Connect pretty well from my days working at Sauce Labs :)

Not sure if appropriate for the dev list - if not, message me on slack and I'd 
be happy to help any way I can.

On Wed, Jun 21, 2017 at 11:34 AM,   wrote:
> Yeah, forgot to give a link to JIRA issue:
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissue
> s.apache.org%2Fjira%2Fbrowse%2FCB-12935=02%7C01%7Cv-alsoro%40micr
> osoft.com%7C0a08a8f1a3124373201b08d4b8c57105%7C72f988bf86f141af91ab2d7
> cd011db47%7C1%7C0%7C636336605526115838=YOC2cn07fgQxDZ8dgOAl%2Frd
> RsLMvgJGUm%2B%2BTHmol54M%3D=0
>
> For now, I'm wrestling with Sauce Connect and jwt plugins for Travis in an 
> attempt to make secure variables work for PRs from external forks. Besides 
> that, there is nothing holding us from running these builds, so if you have 
> any insight on that, I'd be glad to hear it.
>
> -Original Message-
> From: Filip Maj [mailto:maj@gmail.com]
> Sent: Wednesday, June 21, 2017 4:33 PM
> To: dev@cordova.apache.org
> Subject: Re: Cloudapp CI is down, builds moving to Travis
>
> Any JIRA issues we should look at to track progress?
>
> Alex, what can we do to assist? seems like a lot of work - let us know!
>
> On Wed, Jun 21, 2017 at 5:39 AM,   wrote:
>> Our Plugins testing CI (Jenkins) is officially dead now.
>> We're migrating all the jobs to Travis and AppVeyor, but for the time 
>> being, all PRs to the plugin repos are not being tested. I'm working 
>> to enable Travis and AppVeyor builds as soon as possible, but there 
>> are some unexpected hassle with encrypted env.variables.
>>
>> Will keep you posted.
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org