[GitHub] cordova-plugin-inappbrowser pull request #225: CB-12975: (docs) Resort and r...
GitHub user janpio opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 CB-12975: (docs) Resort and reword cordova.InAppBrowser.open `options` lists ### Platforms affected n/a, only docs changes ### What does this PR do? Resort and reword cordova.InAppBrowser.open `options` lists for better developer experience ### What testing has been done on this change? n/a ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - n/a Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/janpio/cordova-plugin-inappbrowser patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/225.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #225 commit 89573d90a2c32c21537362229948b12bad531cdf Author: Jan PiotrowskiDate: 2017-07-01T00:41:04Z Resort and reword cordova.InAppBrowser.open `options` lists for better developer experience --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #274: CB-12593: (android) Fix potential FileProv...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/274 Thanks, Joe. I messed up the commit and issue linking. https://github.com/apache/cordova-plugin-camera/pull/275 has the same change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #274: CB-12593: (android) Fix potential FileProv...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/274 THIS IS BRILLIANT! Why is this a closed issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #324: CB-12966: (ios) Fix bug by escaping project name in ...
Github user joshdholtz commented on the issue: https://github.com/apache/cordova-ios/pull/324 @renatoalencar I have no idea why the tests are not passing. It seems like other tests aren't passing either. You can use this by doing something like... ``` ionic platform add https://github.com/joshdholtz/cordova-ios.git ``` or ``` cordova platform add https://github.com/joshdholtz/cordova-ios.git ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #275: CB-12593: (android) Fix potential F...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/275 CB-12593: (android) Fix potential FileProvider conflicts ### Platforms affected Android ### What does this PR do? Allows more than one plugin to use a FileProvider ### What testing has been done on this change? Tested with cordova-android 6.1.2 ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-camera CB12953 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/275.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #275 commit cfefa53272d48c0067bd4a71345f1d6b328ff96f Author: Connor PearsonDate: 2017-06-30T13:59:27Z CB-12593: (android) Fix potential FileProvider conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #274: CB-12593: (android) Fix potential F...
Github user cjpearson closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12593: (android) move management of Fil...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/257 I think https://github.com/apache/cordova-plugin-camera/pull/274 may be a better solution. Closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #257: CB-12593: (android) move management...
Github user cjpearson closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #274: CB-12959: (android) Fix potential F...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/274 CB-12959: (android) Fix potential FileProvider conflicts ### Platforms affected Android ### What does this PR do? Allows more than one plugin to use a FileProvider ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-camera CB12959 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/274.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #274 commit 94b6ba3d0687990c148f91ef83a33c53f8f8d4da Author: Connor PearsonDate: 2017-06-30T13:59:27Z CB-12959: (android) Fix potential FileProvider conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #324: CB-12966: (ios) Fix bug by escaping project name in ...
Github user renatoalencar commented on the issue: https://github.com/apache/cordova-ios/pull/324 I really need this bug fix, did you understand why this is not passing in tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-screen-orientation issue #15: fix(plugin): add es6-promise-pl...
Github user rpdiss commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/15 add as repo https://github.com/Exilz/cordova-plugin-screen-orientation gonna work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-screen-orientation pull request #20: Do not rotate if orienta...
GitHub user sbatezat opened a pull request: https://github.com/apache/cordova-plugin-screen-orientation/pull/20 Do not rotate if orientation is OK ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sbatezat/cordova-plugin-screen-orientation patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-screen-orientation/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit 10f44f3f1a7025ed90e73fe53fec7e0a0d8bcea7 Author: sbatezatDate: 2017-06-27T15:15:02Z Update CDVOrientation.m Update orientation only if needed. Prevent switch from UIInterfaceOrientationLandscapeLeft to UIInterfaceOrientationLandscapeRight and from UIInterfaceOrientationPortraitUpsideDown to UIInterfaceOrientationPortrait commit 7347c5edba79f02c7d770cca1f06a839aab8ac51 Author: sbatezat Date: 2017-06-29T15:36:57Z Update CDVOrientation.m Using of [UIApplication sharedApplication].statusBarOrientation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #153: CB-12963: npm-link all dependencies
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org