[GitHub] cordova-docs issue #728: CB-13025 Remove use of React in plugins.cordova.io
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/728 LGTM. Did a build of the site and tested the Plugin Search, copy to clipboard, platform filter, sort, etc, all seems to work --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Nightly build #483 for cordova has succeeded!
Nightly build #483 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/483/consoleFull - Jenkins for Apache Cordova - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #729: Fixed up 'deployment' docs in README.md.
Github user dblotsky commented on the issue: https://github.com/apache/cordova-docs/pull/729 @stevesgill @audreyso @shazron please review when you have a moment. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #729: Fixed up 'deployment' docs in README.md.
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/729 Fixed up 'deployment' docs in README.md. - Restored `gulp build` command in lieu of `npm run serve` command. - Tested and fixed suggested deployment commands. - Removed redundant text. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dblotsky/cordova-docs dblotsky-deploy-docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/729.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #729 commit a08fe2eb086c5f1d7f224659b92975381a7159dd Author: Dmitry BlotskyDate: 2017-09-13T00:21:44Z Fixed up 'deployment' docs in README.md. Restored 'gulp build' command in lieu of 'npm run serve' command. Tested and fixed suggested deployment commands. Removed redundant text. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #728: CB-13025 Remove use of React in plugins.cord...
GitHub user devgeeks opened a pull request: https://github.com/apache/cordova-docs/pull/728 CB-13025 Remove use of React in plugins.cordova.io ### Platforms affected Docs ### What does this PR do? Switches https://plugins.cordova.io from React to Preact to comply with Apache Legal. - uses `preact-compat` for API compatibility (tried to make the smallest changes possible) - uses `babel` via `babelify` instead of the deprecated `reactify` to transform the JSX - no longer re-renders the entire app when filtering by platforms or sorting has changed ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/devgeeks/cordova-docs CB-13025 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/728.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #728 commit adf96528f7f4b57ecae40b98d61c14aeff93d0b8 Author: tommy-carlos williamsDate: 2017-09-12T23:47:41Z CB-13025 Remove use of React in plugins.cordova.io Switched to Preact - uses `preact-compat` for API compatibility (tried to make the smallest changes possible) - uses `babel` via `babelify` instead of the deprecated `reactify` to transform the JSX - no longer re-renders the entire app when filtering by platforms or sorting has changed --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #198: CB-12145: (android) Allow third part...
Github user shaggy8871 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/198 This patch works well when applied manually. To enable, pass `acceptThirdPartyCookies` as an option to `open()`: ``` cordova.InAppBrowser.open('', '_blank', 'acceptThirdPartyCookies=yes'); ``` --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #719: CB-13076,CB-13068 : Removed references of cordova d...
Github user filmaj commented on the issue: https://github.com/apache/cordova-docs/pull/719 It is. We need the docs updated to remove references to plugins that are being integrated/removed - we have more of these kinds of changes coming down the pipeline. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #727: CB-13247 - Blog post for Cordova iOS 4.5.0 Release
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/727 @janpio spin up a PR to add it. But the site won't likely be updated for some time so it may be stale by then (it takes over an hour to generate and deploy a site) --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #719: CB-13076,CB-13068 : Removed references of cordova d...
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/719 @maverickmishra is this PR still relevant/updated? --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #727: CB-13247 - Blog post for Cordova iOS 4.5.0 Release
Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/727 Now that it's published I noticed that it would have been good to include the CLI command to remove `cordova-plugin-console`: `cordova plugin rm cordova-plugin-console`. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org