Re: [DISCUSS] Plugin release

2017-09-19 Thread Steven Gill 
Plugin vote is going to fail it seems due to the issue simon found.

Simons  message:
"Failed
* Added cordova-plugin-camera to a project with cordova-android 6.3.0 which
depends on cordova-plugin-compat and the build fails.

The reason the build fails is that all of the cordova plugins that depend
on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0. Since
compat was bumped to 2.0.0 when you install cordova-plugin-camera on your
cordova-android 6.3.0 project it fails the semver and it pulls in the 1.1.0
version. Now both compat and cordova-android deliver the same classes and
the build fails."

I actually have 1.2.0 version of the plugin already tagged from when I ran
the plugin process on Monday. It is identical to the 2.0.0 version that is
being voted on. We can either stop the current vote thread and start a new
one with 1.2.0 instead of 2.0.0, or we could continue the current vote
thread and start a new one just for compat@1.2.0. If we go with option 2,
we can release both 1.2.0 and 2.0.0.

This is a good point to remember in the future. Deprecation should be minor
not major bumps.


On Tue, Sep 12, 2017 at 11:43 PM, Shazron  wrote:

> Created PR for CB-13170 cordova-plugin-console
> https://github.com/apache/cordova-plugin-console/pull/25
>
> On Tue, Sep 12, 2017 at 7:20 AM, Simon MacDonald <
> simon.macdon...@gmail.com>
> wrote:
>
> > Both of:
> >
> > cordova-plugin-device-motion
> > cordova-plugin-device-orientation
> >
> > should get their deprecation PR's merge and also released.
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> >
> > On Mon, Sep 11, 2017 at 7:03 PM, Shazron  wrote:
> > > +1 on console. No PRs for that yet though so it's not ready.
> > >
> > > On Tue, Sep 12, 2017 at 5:46 AM, Steven Gill 
> > wrote:
> > >
> > >> Console should be released too since it has been moved back into ios
> for
> > >> next release. https://issues.apache.org/jira/browse/CB-13170
> > >>
> > >> On Sep 11, 2017 2:04 PM, "Jesse"  wrote:
> > >>
> > >> > Android release is dependent on us releasing an
> > >> > updated cordova-plugin-compat
> > >> >
> > >> > Anyone have any reasons to not do a release? Anything outstanding
> > >> > anyone wants to get merged in before moving ahead with a plugins
> > >> > release? Any other comments on the topic?
> > >> >
> > >> > Cheers,
> > >> >   Jesse
> > >> >
> > >> >
> > >> > @purplecabbage
> > >> > risingj.com
> > >> >
> > >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

Re: [VOTE] Plugins Release

2017-09-19 Thread Steven Gill 
nice catch.

On Tue, Sep 19, 2017 at 8:10 PM, Simon MacDonald 
wrote:

> I vote - 1
>
> Passed
> * Checked for deprecation notices for plugin-device-motion & orientation
> * Tested that cordova-plugin-console is not added for ios when cordova-ios
> >= 4.5.0
> * Tested that cordova-plugin-compat is not added for android when
> cordova-android >= 6.3.0
>
> Failed
> * Added cordova-plugin-camera to a project with cordova-android 6.3.0 which
> depends on cordova-plugin-compat and the build fails.
>
> The reason the build fails is that all of the cordova plugins that depend
> on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0. Since
> compat was bumped to 2.0.0 when you install cordova-plugin-camera on your
> cordova-android 6.3.0 project it fails the semver and it pulls in the 1.1.0
> version. Now both compat and cordova-android deliver the same classes and
> the build fails.
>
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Mon, Sep 18, 2017 at 7:05 PM, Audrey So  wrote:
>
> > I vote + 1
> >
> > * Verified signatures
> >
> > * Checked for deprecation notices for plugin-device-motion & orientation
> > * Tested that cordova-plugin-console is not added for ios
> > * Tested that cordova-plugin-compat is not added for android
> > * Added plugins to cordova project
> >
> >
> >
> >
> > On 9/18/17, 3:05 PM, "Joe Bowser"  wrote:
> >
> > >I vote +1
> > >
> > >* Tested cordova-plugin-compat installation to make sure it doesn't
> > install
> > >on cordova-android master
> > >* Ran mobilespec locally
> > >* Verified signatures
> > >
> > >
> > >On Mon, Sep 18, 2017 at 2:08 PM, Steven Gill 
> > wrote:
> > >
> > >> Please review and vote on the release of this plugins release
> > >> by replying to this email (and keep discussion on the DISCUSS thread)
> > >>
> > >> Release issue: https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> > 13294=02%7C01%7C%7C14e404d7c0e7454c718b08d4fee1591a%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636413691211640629=%
> > 2B2sZF4YE7bcA8vA4%2BqZgknBBArYMn0mbzXFQMlwkGR4%3D=0
> > >>
> > >> The plugins have been published to
> > >> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/
> > >>
> > >> The packages were published from their corresponding git tags:
> > >> cordova-plugin-console: 2.0.0 (f0e113bdf4)
> > >> cordova-plugin-compat: 2.0.0 (0df201c24d)
> > >> cordova-plugin-device-motion: 2.0.0 (1236b957af)
> > >> cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)
> > >>
> > >> Upon a successful vote I will upload the archives to dist/, upload
> > >> them to npm, and post the corresponding blog post.
> > >>
> > >> Voting guidelines:
> > >> https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> > 2Frelease-voting.md=02%7C01%7C%7C14e404d7c0e7454c718b08d4fee1591a%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636413691211640629=
> > TH5HU27%2FrfoPu6ZjCmQ8ZsLHx2W8LwUCwzSsQ0VCMhA%3D=0
> > >> How to vote on a plugins release at
> > >> https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%
> > 2Fblob%2Fmaster%2Fdocs%2Fplug=02%7C01%7C%
> > 7C14e404d7c0e7454c718b08d4fee1591a%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C636413691211640629=QpsOtFm7U0IYm0RjMC4RQxThr0vb9u
> > nJ5YuXH6yrrjc%3D=0
> > >> ins-release-process.md#voting
> > >>
> > >> Voting will go on for a minimum of 48 hours.
> > >>
> > >> I vote +1:
> > >> * Ran coho audit-license-headers over the relevant repos
> > >> * Ran coho check-license to ensure all dependencies and
> > >> subdependencies have Apache-compatible licenses
> > >> * Ensured continuous build was green when repos were tagged
> > >>
> >
>

Re: [VOTE] Plugins Release

2017-09-19 Thread Simon MacDonald 
I vote - 1

Passed
* Checked for deprecation notices for plugin-device-motion & orientation
* Tested that cordova-plugin-console is not added for ios when cordova-ios
>= 4.5.0
* Tested that cordova-plugin-compat is not added for android when
cordova-android >= 6.3.0

Failed
* Added cordova-plugin-camera to a project with cordova-android 6.3.0 which
depends on cordova-plugin-compat and the build fails.

The reason the build fails is that all of the cordova plugins that depend
on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0. Since
compat was bumped to 2.0.0 when you install cordova-plugin-camera on your
cordova-android 6.3.0 project it fails the semver and it pulls in the 1.1.0
version. Now both compat and cordova-android deliver the same classes and
the build fails.



Simon Mac Donald
http://simonmacdonald.com

On Mon, Sep 18, 2017 at 7:05 PM, Audrey So  wrote:

> I vote + 1
>
> * Verified signatures
>
> * Checked for deprecation notices for plugin-device-motion & orientation
> * Tested that cordova-plugin-console is not added for ios
> * Tested that cordova-plugin-compat is not added for android
> * Added plugins to cordova project
>
>
>
>
> On 9/18/17, 3:05 PM, "Joe Bowser"  wrote:
>
> >I vote +1
> >
> >* Tested cordova-plugin-compat installation to make sure it doesn't
> install
> >on cordova-android master
> >* Ran mobilespec locally
> >* Verified signatures
> >
> >
> >On Mon, Sep 18, 2017 at 2:08 PM, Steven Gill 
> wrote:
> >
> >> Please review and vote on the release of this plugins release
> >> by replying to this email (and keep discussion on the DISCUSS thread)
> >>
> >> Release issue: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 13294=02%7C01%7C%7C14e404d7c0e7454c718b08d4fee1591a%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636413691211640629=%
> 2B2sZF4YE7bcA8vA4%2BqZgknBBArYMn0mbzXFQMlwkGR4%3D=0
> >>
> >> The plugins have been published to
> >> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/
> >>
> >> The packages were published from their corresponding git tags:
> >> cordova-plugin-console: 2.0.0 (f0e113bdf4)
> >> cordova-plugin-compat: 2.0.0 (0df201c24d)
> >> cordova-plugin-device-motion: 2.0.0 (1236b957af)
> >> cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)
> >>
> >> Upon a successful vote I will upload the archives to dist/, upload
> >> them to npm, and post the corresponding blog post.
> >>
> >> Voting guidelines:
> >> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> 2Frelease-voting.md=02%7C01%7C%7C14e404d7c0e7454c718b08d4fee1591a%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636413691211640629=
> TH5HU27%2FrfoPu6ZjCmQ8ZsLHx2W8LwUCwzSsQ0VCMhA%3D=0
> >> How to vote on a plugins release at
> >> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%
> 2Fblob%2Fmaster%2Fdocs%2Fplug=02%7C01%7C%
> 7C14e404d7c0e7454c718b08d4fee1591a%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636413691211640629=QpsOtFm7U0IYm0RjMC4RQxThr0vb9u
> nJ5YuXH6yrrjc%3D=0
> >> ins-release-process.md#voting
> >>
> >> Voting will go on for a minimum of 48 hours.
> >>
> >> I vote +1:
> >> * Ran coho audit-license-headers over the relevant repos
> >> * Ran coho check-license to ensure all dependencies and
> >> subdependencies have Apache-compatible licenses
> >> * Ensured continuous build was green when repos were tagged
> >>
>

Nightly build #490 for cordova has failed

2017-09-19 Thread Apache Jenkins Server 
Nightly build #490 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/490/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/490/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova iOS 4.5.1 release

2017-09-19 Thread Suraj Pindoria 
 I have just tested all the above issues with the official release versions of 
iOS 11 and Xcode 9 and can confirm that they are all fixed. We just need to 
merge in https://issues.apache.org/jira/browse/CB-13191, and then we should be 
good to release cordova-ios@4.5.1.
Suraj.On Friday, September 15, 2017, 4:58:41 PM PDT, Simon MacDonald 
 wrote:  
 
 Nope because compat only has Android code.


Simon Mac Donald
http://simonmacdonald.com

On Fri, Sep 15, 2017 at 7:55 PM, Joe Bowser  wrote:

> Is the iOS release blocked by the plugin release that is currently blocking
> Android?
>
> On Fri, Sep 15, 2017 at 4:54 PM, Mike Hartington  >
> wrote:
>
> > Regarding the Viewport and iPhoneX notch, I sent this earlier today.
> >
> > https://github.com/apache/cordova-plugin-statusbar/pull/85 <
> > https://github.com/apache/cordova-plugin-statusbar/pull/85>
> >
> >
> > > On Sep 15, 2017, at 7:36 PM, Shazron  wrote:
> > >
> > > We need a 4.5.1 release soon to address iOS 11 issues.
> > >
> > > Here’s the things that are pending or have been fixed:
> > >
> > > - cordova-ios@4.5.0 has been released which fixes a bunch of things.
> > Now of
> > > course, we need to have a cordova-ios@4.5.1 release because of the
> other
> > > points below…
> > >
> > > - ios-sim is broken, it doesn’t list the new 2017 iPhones. Apple
> released
> > > Xcode 9 with a buggy listing of devices using `xcrun simctl` (i.e.
> > listing
> > > iPhone 8 as iPhone2017-A for example) so we can’t list them properly. I
> > > have fixed this with a workaround:
> > > https://github.com/phonegap/ios-sim/issues/218 and
> > > https://github.com/phonegap/ios-sim/issues/219 - This new ios-sim when
> > > released needs to go in a new cordova-ios release asap
> > >
> > > - simctl is broken, it doesn’t launch the Simulator (so `cordova
> emulate
> > > ios` is affected). I have filed issues:
> > > https://github.com/phonegap/ios-sim/issues/209 and
> > > https://github.com/phonegap/simctl/issues/14 . Of course I will have
> to
> > > work on those, and no surprise Apple changed things again… This will go
> > in
> > > the new ios-sim which in turn will go in the new cordova-ios
> > >
> > > - Viewport and iPhone X notch issues – with the help of the community.
> > Need
> > > to be addressed properly (blog post only?). Summarized by Darryl Pogue:
> > >    - status bar plugin -- Has a PR to use the safeArea height instead
> of
> > > 20px
> > >    - iPhone X letterboxing -- Requires the use of LaunchStoryboards,
> not
> > > really a "bug"
> > >    - viewport-fit stuff -- Up to the HTML author, not really a "bug",
> and
> > > a few blogs posts about it
> > >
> > > - ios-deploy couldn’t compile under Xcode 9. Apple either prevents or
> > had a
> > > bug where it couldn’t link to Private Frameworks. Workaround added:
> > > https://github.com/phonegap/ios-deploy/issues/308 . This should have
> > been
> > > in 4.5.0 already
> >
> >
>

[GitHub] cordova-plugin-camera issue #200: CB-9852: cordova-plugin-camera file picker...

2017-09-19 Thread Lianite 
Github user Lianite commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/200
  
Is there an ETA for this getting merged in?

This still appears to be a problem as of v.2.4.1.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #595: CB-12361 : updated and added unit tests for a...

2017-09-19 Thread audreyso 
GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/595

CB-12361 : updated and added unit tests for add.spec.js



### Platforms affected


### What does this PR do?

Updated and added "to-do" unit tests for add.spec.js

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12361-plugin_fetch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/595.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #595


commit ec07983d1ed587358a30fc003e9f86edd47e9bce
Author: Audrey So 
Date:   2017-09-18T20:37:45Z

CB-12361 : updated and added unit tests for add.spec.js




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org