[GitHub] cordova-osx issue #41: CB-13304: forward non file:// URLs to system

[tripodsan]

Github user tripodsan commented on the issue:

https://github.com/apache/cordova-osx/pull/41
  
or maybe depend on: 
https://cordova.apache.org/docs/en/latest/config_ref/#allow-navigation ?


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx issue #41: CB-13304: forward non file:// URLs to system

[tripodsan]

Github user tripodsan commented on the issue:

https://github.com/apache/cordova-osx/pull/41
  
config option would be fine :-)


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx issue #41: CB-13304: forward non file:// URLs to system

[albertolalama]

Github user albertolalama commented on the issue:

https://github.com/apache/cordova-osx/pull/41
  
thank you for the suggestion, I will use inappbrowser.

you're right about the kiosk app. my aim was to replicate the behavior I 
have seen in cordova iOS and Android, where the system handles URLs by default. 
this change also attempts to secure the main app window from potentially 
loading unsafe content.

would you reconsider if I made it a config option?


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #491 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #491 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/491/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx issue #41: CB-13304: forward non file:// URLs to system

[tripodsan]

Github user tripodsan commented on the issue:

https://github.com/apache/cordova-osx/pull/41
  
-1

I don't like this approach, since it will not be possible to create a kiosk 
application that loads the content from an external site. if you want to open 
urls in the system browser, use the inappbroswer plugin.

see also: 
https://stackoverflow.com/questions/20011753/phonegap-open-external-link-in-default-browser-outside-the-app


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugin release

[Steven Gill]

Yeah I only released the plugins that people mentioned in this thread to
release. I can fire up another plugins release next week. What plugins do
people want reviewed/released?

On Wed, Sep 20, 2017 at 4:36 PM, Simon MacDonald 
wrote:

> Just realized that cordova-plugin-file-transfer was never bumped. It
> includes an important fix for apps. Without it new apps may be rejected
> from the Play Store.
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Wed, Sep 20, 2017 at 1:33 PM, Steven Gill 
> wrote:
>
> > the ios release blog post tells users about the console plugin.
> > http://cordova.apache.org/announcements/2017/09/08/ios-release.html
> >
> > I'll make sure to highlight these changes in the plugins release blog
> post.
> >
> > Starting a new vote with console + compat only having minor bumps
> >
> > On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez <
> > jcesarmob...@gmail.com
> > > wrote:
> >
> > > There has been already a few people asking about the duplicate symbols
> on
> > > slack
> > >
> > > 2017-09-20 17:06 GMT+02:00 Simon MacDonald  >:
> > >
> > > > IMHO both cordova-plugin-compat and cordova-plugin-console should
> > receive
> > > > minor version bumps. Neither breaks backwards compatibility so I
> don't
> > > feel
> > > > like a major version bump is warranted.
> > > >
> > > > As well all of our core plugins that depend on cordova-plugin-compat
> > use
> > > > the ^1.x in their semver so they would pull in the earlier version of
> > the
> > > > compat plugin and in combination with the upcoming cordova-android
> > 6.3.0
> > > > pretty much all apps will fail to build.
> > > >
> > > > When it comes to cordova-plugin-console we should also err on the
> side
> > of
> > > > caution when it comes to the version number bump. I spent some time
> > this
> > > > morning debugging an internal app that was using cordova-ios 4.5.0
> and
> > > > cordova-plugin-console. It was failing to build because of duplicate
> > > code.
> > > > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release before
> > > > cordova-ios 4.5.0 the problem would not have existed.
> > > >
> > > > I think we need to be ready to start answering that question as to
> why
> > > apps
> > > > using cordova-ios 4.5.0 don't build. Perhaps a quick blog post is in
> > > order?
> > > >
> > > > My recommendations is to restart this vote thread with the four
> plugins
> > > but
> > > > tag their versions as cordova-plugin-compat@1.2.0,
> > > > cordova-plugin-console@1.1.0. The device motion and device
> orientation
> > > > plugins can have any version number we want as they will not run into
> > the
> > > > above problems.
> > > >
> > > >
> > > > Simon Mac Donald
> > > > http://simonmacdonald.com
> > > >
> > > > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill  >
> > > > wrote:
> > > >
> > > > > Plugin vote is going to fail it seems due to the issue simon found.
> > > > >
> > > > > Simons  message:
> > > > > "Failed
> > > > > * Added cordova-plugin-camera to a project with cordova-android
> 6.3.0
> > > > which
> > > > > depends on cordova-plugin-compat and the build fails.
> > > > >
> > > > > The reason the build fails is that all of the cordova plugins that
> > > depend
> > > > > on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0.
> > > Since
> > > > > compat was bumped to 2.0.0 when you install cordova-plugin-camera
> on
> > > your
> > > > > cordova-android 6.3.0 project it fails the semver and it pulls in
> the
> > > > 1.1.0
> > > > > version. Now both compat and cordova-android deliver the same
> classes
> > > and
> > > > > the build fails."
> > > > >
> > > > > I actually have 1.2.0 version of the plugin already tagged from
> when
> > I
> > > > ran
> > > > > the plugin process on Monday. It is identical to the 2.0.0 version
> > that
> > > > is
> > > > > being voted on. We can either stop the current vote thread and
> start
> > a
> > > > new
> > > > > one with 1.2.0 instead of 2.0.0, or we could continue the current
> > vote
> > > > > thread and start a new one just for compat@1.2.0. If we go with
> > option
> > > > 2,
> > > > > we can release both 1.2.0 and 2.0.0.
> > > > >
> > > > > This is a good point to remember in the future. Deprecation should
> be
> > > > minor
> > > > > not major bumps.
> > > > >
> > > > >
> > > > > On Tue, Sep 12, 2017 at 11:43 PM, Shazron 
> wrote:
> > > > >
> > > > > > Created PR for CB-13170 cordova-plugin-console
> > > > > > https://github.com/apache/cordova-plugin-console/pull/25
> > > > > >
> > > > > > On Tue, Sep 12, 2017 at 7:20 AM, Simon MacDonald <
> > > > > > simon.macdon...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Both of:
> > > > > > >
> > > > > > > cordova-plugin-device-motion
> > > > > > > cordova-plugin-device-orientation
> > > > > > >
> > > > > > > should get their deprecation PR's merge and also released.
> > > > > > >
> > > > > > 

Re: [DISCUSS] Plugin release

[Simon MacDonald]

Just realized that cordova-plugin-file-transfer was never bumped. It
includes an important fix for apps. Without it new apps may be rejected
from the Play Store.


Simon Mac Donald
http://simonmacdonald.com

On Wed, Sep 20, 2017 at 1:33 PM, Steven Gill  wrote:

> the ios release blog post tells users about the console plugin.
> http://cordova.apache.org/announcements/2017/09/08/ios-release.html
>
> I'll make sure to highlight these changes in the plugins release blog post.
>
> Starting a new vote with console + compat only having minor bumps
>
> On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez <
> jcesarmob...@gmail.com
> > wrote:
>
> > There has been already a few people asking about the duplicate symbols on
> > slack
> >
> > 2017-09-20 17:06 GMT+02:00 Simon MacDonald :
> >
> > > IMHO both cordova-plugin-compat and cordova-plugin-console should
> receive
> > > minor version bumps. Neither breaks backwards compatibility so I don't
> > feel
> > > like a major version bump is warranted.
> > >
> > > As well all of our core plugins that depend on cordova-plugin-compat
> use
> > > the ^1.x in their semver so they would pull in the earlier version of
> the
> > > compat plugin and in combination with the upcoming cordova-android
> 6.3.0
> > > pretty much all apps will fail to build.
> > >
> > > When it comes to cordova-plugin-console we should also err on the side
> of
> > > caution when it comes to the version number bump. I spent some time
> this
> > > morning debugging an internal app that was using cordova-ios 4.5.0 and
> > > cordova-plugin-console. It was failing to build because of duplicate
> > code.
> > > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release before
> > > cordova-ios 4.5.0 the problem would not have existed.
> > >
> > > I think we need to be ready to start answering that question as to why
> > apps
> > > using cordova-ios 4.5.0 don't build. Perhaps a quick blog post is in
> > order?
> > >
> > > My recommendations is to restart this vote thread with the four plugins
> > but
> > > tag their versions as cordova-plugin-compat@1.2.0,
> > > cordova-plugin-console@1.1.0. The device motion and device orientation
> > > plugins can have any version number we want as they will not run into
> the
> > > above problems.
> > >
> > >
> > > Simon Mac Donald
> > > http://simonmacdonald.com
> > >
> > > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill 
> > > wrote:
> > >
> > > > Plugin vote is going to fail it seems due to the issue simon found.
> > > >
> > > > Simons  message:
> > > > "Failed
> > > > * Added cordova-plugin-camera to a project with cordova-android 6.3.0
> > > which
> > > > depends on cordova-plugin-compat and the build fails.
> > > >
> > > > The reason the build fails is that all of the cordova plugins that
> > depend
> > > > on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0.
> > Since
> > > > compat was bumped to 2.0.0 when you install cordova-plugin-camera on
> > your
> > > > cordova-android 6.3.0 project it fails the semver and it pulls in the
> > > 1.1.0
> > > > version. Now both compat and cordova-android deliver the same classes
> > and
> > > > the build fails."
> > > >
> > > > I actually have 1.2.0 version of the plugin already tagged from when
> I
> > > ran
> > > > the plugin process on Monday. It is identical to the 2.0.0 version
> that
> > > is
> > > > being voted on. We can either stop the current vote thread and start
> a
> > > new
> > > > one with 1.2.0 instead of 2.0.0, or we could continue the current
> vote
> > > > thread and start a new one just for compat@1.2.0. If we go with
> option
> > > 2,
> > > > we can release both 1.2.0 and 2.0.0.
> > > >
> > > > This is a good point to remember in the future. Deprecation should be
> > > minor
> > > > not major bumps.
> > > >
> > > >
> > > > On Tue, Sep 12, 2017 at 11:43 PM, Shazron  wrote:
> > > >
> > > > > Created PR for CB-13170 cordova-plugin-console
> > > > > https://github.com/apache/cordova-plugin-console/pull/25
> > > > >
> > > > > On Tue, Sep 12, 2017 at 7:20 AM, Simon MacDonald <
> > > > > simon.macdon...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Both of:
> > > > > >
> > > > > > cordova-plugin-device-motion
> > > > > > cordova-plugin-device-orientation
> > > > > >
> > > > > > should get their deprecation PR's merge and also released.
> > > > > >
> > > > > > Simon Mac Donald
> > > > > > http://simonmacdonald.com
> > > > > >
> > > > > >
> > > > > > On Mon, Sep 11, 2017 at 7:03 PM, Shazron 
> > wrote:
> > > > > > > +1 on console. No PRs for that yet though so it's not ready.
> > > > > > >
> > > > > > > On Tue, Sep 12, 2017 at 5:46 AM, Steven Gill <
> > > stevengil...@gmail.com
> > > > >
> > > > > > wrote:
> > > > > > >
> > > > > > >> Console should be released too since it has been moved back
> into
> > > ios
> > > > > for
> > > > > > >> next release. 

Re: [VOTE] Plugins Release (attempt 2)

[Steven Gill]

discuss thread Simon!

On Wed, Sep 20, 2017 at 4:21 PM, Simon MacDonald 
wrote:

> Just realized that cordova-plugin-file-transfer was never bumped. It
> includes an important fix for apps. Without it new apps may be rejected
> from the Play Store.
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Wed, Sep 20, 2017 at 6:01 PM, Joe Bowser  wrote:
>
> > I vote +1
> >
> > * Verified Archives
> > * Tested MobileSpec and made sure that Camera actually got installed
> > * Tested against master of cordova-android (cordova-android >= 6.3.0)
> >
> > On Wed, Sep 20, 2017 at 11:25 AM, Simon MacDonald <
> > simon.macdon...@gmail.com
> > > wrote:
> >
> > > I vote + 1
> > >
> > > Passed
> > > * Checked for deprecation notices for plugin-device-motion &
> orientation
> > > * Tested that cordova-plugin-console is not added for ios when
> > cordova-ios
> > > >= 4.5.0
> > > * Tested that cordova-plugin-compat is not added for android when
> > > cordova-android >= 6.3.0
> > > * Added cordova-plugin-camera to a project with cordova-android 6.3.0
> > which
> > > depends on cordova-plugin-compat (from github master) and the build
> > passes.
> > >
> > >
> > > Simon Mac Donald
> > > http://simonmacdonald.com
> > >
> > > On Wed, Sep 20, 2017 at 1:57 PM, Steven Gill 
> > > wrote:
> > >
> > > > Please review and vote on the release of this plugins release
> > > > by replying to this email (and keep discussion on the DISCUSS thread)
> > > >
> > > > Release issue: https://issues.apache.org/jira/browse/CB-13294
> > > >
> > > > The plugins have been published to
> > > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/
> > > >
> > > > The packages were published from their corresponding git tags:
> > > > cordova-plugin-console: 1.1.0 (ef9bd9ceb4)
> > > > cordova-plugin-compat: 1.2.0 (be2a46be8d)
> > > > cordova-plugin-device-motion: 2.0.0 (1236b957af)
> > > > cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)
> > > >
> > > > Upon a successful vote I will upload the archives to dist/, upload
> > > > them to npm, and post the corresponding blog post.
> > > >
> > > > Voting guidelines:
> > > > https://github.com/apache/cordova-coho/blob/master/docs/
> > > release-voting.md
> > > > How to vote on a plugins release at
> > > > https://github.com/apache/cordova-coho/blob/master/docs/
> > > > plugins-release-process.md#voting
> > > >
> > > > Voting will go on for a minimum of 48 hours.
> > > >
> > > > I vote +1:
> > > > * Ran coho audit-license-headers over the relevant repos
> > > > * Ran coho check-license to ensure all dependencies and
> > > > subdependencies have Apache-compatible licenses
> > > > * Ensured continuous build was green when repos were tagged
> > > >
> > >
> >
>

Re: [VOTE] Plugins Release (attempt 2)

[Simon MacDonald]

Just realized that cordova-plugin-file-transfer was never bumped. It
includes an important fix for apps. Without it new apps may be rejected
from the Play Store.


Simon Mac Donald
http://simonmacdonald.com

On Wed, Sep 20, 2017 at 6:01 PM, Joe Bowser  wrote:

> I vote +1
>
> * Verified Archives
> * Tested MobileSpec and made sure that Camera actually got installed
> * Tested against master of cordova-android (cordova-android >= 6.3.0)
>
> On Wed, Sep 20, 2017 at 11:25 AM, Simon MacDonald <
> simon.macdon...@gmail.com
> > wrote:
>
> > I vote + 1
> >
> > Passed
> > * Checked for deprecation notices for plugin-device-motion & orientation
> > * Tested that cordova-plugin-console is not added for ios when
> cordova-ios
> > >= 4.5.0
> > * Tested that cordova-plugin-compat is not added for android when
> > cordova-android >= 6.3.0
> > * Added cordova-plugin-camera to a project with cordova-android 6.3.0
> which
> > depends on cordova-plugin-compat (from github master) and the build
> passes.
> >
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> > On Wed, Sep 20, 2017 at 1:57 PM, Steven Gill 
> > wrote:
> >
> > > Please review and vote on the release of this plugins release
> > > by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-13294
> > >
> > > The plugins have been published to
> > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/
> > >
> > > The packages were published from their corresponding git tags:
> > > cordova-plugin-console: 1.1.0 (ef9bd9ceb4)
> > > cordova-plugin-compat: 1.2.0 (be2a46be8d)
> > > cordova-plugin-device-motion: 2.0.0 (1236b957af)
> > > cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)
> > >
> > > Upon a successful vote I will upload the archives to dist/, upload
> > > them to npm, and post the corresponding blog post.
> > >
> > > Voting guidelines:
> > > https://github.com/apache/cordova-coho/blob/master/docs/
> > release-voting.md
> > > How to vote on a plugins release at
> > > https://github.com/apache/cordova-coho/blob/master/docs/
> > > plugins-release-process.md#voting
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> > > subdependencies have Apache-compatible licenses
> > > * Ensured continuous build was green when repos were tagged
> > >
> >
>

[GitHub] cordova-osx pull request #41: CB-13304: open file:// URLs in-app, forward ot...

[albertolalama]

GitHub user albertolalama opened a pull request:

https://github.com/apache/cordova-osx/pull/41

CB-13304: open file:// URLs in-app, forward others to the system



### Platforms affected
OSX

### What does this PR do?
Forwards non file:// URL requests to the system instead of opening them 
inside the application.

### What testing has been done on this change?
Tested locally.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/albertolalama/cordova-osx 
alalama-url-navigation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-osx/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #41


commit 402acb1d682bec7b06fd7664a61a58fe5e288e69
Author: alberto lalama 
Date:   2017-09-20T22:48:59Z

CB-13304: open file:// URLs in-app, forward others to the system




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] Plugins Release (attempt 2)

[Joe Bowser]

I vote +1

* Verified Archives
* Tested MobileSpec and made sure that Camera actually got installed
* Tested against master of cordova-android (cordova-android >= 6.3.0)

On Wed, Sep 20, 2017 at 11:25 AM, Simon MacDonald  wrote:

> I vote + 1
>
> Passed
> * Checked for deprecation notices for plugin-device-motion & orientation
> * Tested that cordova-plugin-console is not added for ios when cordova-ios
> >= 4.5.0
> * Tested that cordova-plugin-compat is not added for android when
> cordova-android >= 6.3.0
> * Added cordova-plugin-camera to a project with cordova-android 6.3.0 which
> depends on cordova-plugin-compat (from github master) and the build passes.
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Wed, Sep 20, 2017 at 1:57 PM, Steven Gill 
> wrote:
>
> > Please review and vote on the release of this plugins release
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-13294
> >
> > The plugins have been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/
> >
> > The packages were published from their corresponding git tags:
> > cordova-plugin-console: 1.1.0 (ef9bd9ceb4)
> > cordova-plugin-compat: 1.2.0 (be2a46be8d)
> > cordova-plugin-device-motion: 2.0.0 (1236b957af)
> > cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)
> >
> > Upon a successful vote I will upload the archives to dist/, upload
> > them to npm, and post the corresponding blog post.
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/
> release-voting.md
> > How to vote on a plugins release at
> > https://github.com/apache/cordova-coho/blob/master/docs/
> > plugins-release-process.md#voting
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ensured continuous build was green when repos were tagged
> >
>

[GitHub] cordova-plugin-inappbrowser pull request #99: inAppBrowser custom applicatio...

[varunkumarm]

Github user varunkumarm commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/99#discussion_r140076603
  
--- Diff: src/ios/CDVInAppBrowser.m ---
@@ -783,6 +793,16 @@ - (void)showToolBar:(BOOL)show : (NSString *) 
toolbarPosition
 
 - (void)viewDidLoad
 {
+CGRect frame = [UIApplication sharedApplication].statusBarFrame;
+UIToolbar* bgToolbar = [[UIToolbar alloc] initWithFrame:frame];
+bgToolbar.barStyle = UIBarStyleDefault;
+bgToolbar.tintColor = [UIColor whiteColor];
+bgToolbar.barTintColor = [UIColor whiteColor];
+//[[UIBarItem appearance] 
setTitleTextAttributes:@{UITextAttributeTextColor : [UIColor whiteColor]}];
+
+
+[self.view addSubview:bgToolbar];
+
--- End diff --

@steinwelberg Can you please create the new merge request to get the 
essential part in? Clearly it looks like the extra code is causing the delay. 
It really helps to have the changes in the official branch than to fork and 
use. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] Plugins Release (attempt 2)

[Simon MacDonald]

I vote + 1

Passed
* Checked for deprecation notices for plugin-device-motion & orientation
* Tested that cordova-plugin-console is not added for ios when cordova-ios
>= 4.5.0
* Tested that cordova-plugin-compat is not added for android when
cordova-android >= 6.3.0
* Added cordova-plugin-camera to a project with cordova-android 6.3.0 which
depends on cordova-plugin-compat (from github master) and the build passes.


Simon Mac Donald
http://simonmacdonald.com

On Wed, Sep 20, 2017 at 1:57 PM, Steven Gill  wrote:

> Please review and vote on the release of this plugins release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-13294
>
> The plugins have been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/
>
> The packages were published from their corresponding git tags:
> cordova-plugin-console: 1.1.0 (ef9bd9ceb4)
> cordova-plugin-compat: 1.2.0 (be2a46be8d)
> cordova-plugin-device-motion: 2.0.0 (1236b957af)
> cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)
>
> Upon a successful vote I will upload the archives to dist/, upload
> them to npm, and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> How to vote on a plugins release at
> https://github.com/apache/cordova-coho/blob/master/docs/
> plugins-release-process.md#voting
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ensured continuous build was green when repos were tagged
>

[VOTE] Plugins Release (attempt 2)

[Steven Gill]

Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13294

The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/

The packages were published from their corresponding git tags:
cordova-plugin-console: 1.1.0 (ef9bd9ceb4)
cordova-plugin-compat: 1.2.0 (be2a46be8d)
cordova-plugin-device-motion: 2.0.0 (1236b957af)
cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)

Upon a successful vote I will upload the archives to dist/, upload
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
How to vote on a plugins release at
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ensured continuous build was green when repos were tagged

Re: [DISCUSS] Plugin release

[Steven Gill]

the ios release blog post tells users about the console plugin.
http://cordova.apache.org/announcements/2017/09/08/ios-release.html

I'll make sure to highlight these changes in the plugins release blog post.

Starting a new vote with console + compat only having minor bumps

On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez  wrote:

> There has been already a few people asking about the duplicate symbols on
> slack
>
> 2017-09-20 17:06 GMT+02:00 Simon MacDonald :
>
> > IMHO both cordova-plugin-compat and cordova-plugin-console should receive
> > minor version bumps. Neither breaks backwards compatibility so I don't
> feel
> > like a major version bump is warranted.
> >
> > As well all of our core plugins that depend on cordova-plugin-compat use
> > the ^1.x in their semver so they would pull in the earlier version of the
> > compat plugin and in combination with the upcoming cordova-android 6.3.0
> > pretty much all apps will fail to build.
> >
> > When it comes to cordova-plugin-console we should also err on the side of
> > caution when it comes to the version number bump. I spent some time this
> > morning debugging an internal app that was using cordova-ios 4.5.0 and
> > cordova-plugin-console. It was failing to build because of duplicate
> code.
> > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release before
> > cordova-ios 4.5.0 the problem would not have existed.
> >
> > I think we need to be ready to start answering that question as to why
> apps
> > using cordova-ios 4.5.0 don't build. Perhaps a quick blog post is in
> order?
> >
> > My recommendations is to restart this vote thread with the four plugins
> but
> > tag their versions as cordova-plugin-compat@1.2.0,
> > cordova-plugin-console@1.1.0. The device motion and device orientation
> > plugins can have any version number we want as they will not run into the
> > above problems.
> >
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill 
> > wrote:
> >
> > > Plugin vote is going to fail it seems due to the issue simon found.
> > >
> > > Simons  message:
> > > "Failed
> > > * Added cordova-plugin-camera to a project with cordova-android 6.3.0
> > which
> > > depends on cordova-plugin-compat and the build fails.
> > >
> > > The reason the build fails is that all of the cordova plugins that
> depend
> > > on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0.
> Since
> > > compat was bumped to 2.0.0 when you install cordova-plugin-camera on
> your
> > > cordova-android 6.3.0 project it fails the semver and it pulls in the
> > 1.1.0
> > > version. Now both compat and cordova-android deliver the same classes
> and
> > > the build fails."
> > >
> > > I actually have 1.2.0 version of the plugin already tagged from when I
> > ran
> > > the plugin process on Monday. It is identical to the 2.0.0 version that
> > is
> > > being voted on. We can either stop the current vote thread and start a
> > new
> > > one with 1.2.0 instead of 2.0.0, or we could continue the current vote
> > > thread and start a new one just for compat@1.2.0. If we go with option
> > 2,
> > > we can release both 1.2.0 and 2.0.0.
> > >
> > > This is a good point to remember in the future. Deprecation should be
> > minor
> > > not major bumps.
> > >
> > >
> > > On Tue, Sep 12, 2017 at 11:43 PM, Shazron  wrote:
> > >
> > > > Created PR for CB-13170 cordova-plugin-console
> > > > https://github.com/apache/cordova-plugin-console/pull/25
> > > >
> > > > On Tue, Sep 12, 2017 at 7:20 AM, Simon MacDonald <
> > > > simon.macdon...@gmail.com>
> > > > wrote:
> > > >
> > > > > Both of:
> > > > >
> > > > > cordova-plugin-device-motion
> > > > > cordova-plugin-device-orientation
> > > > >
> > > > > should get their deprecation PR's merge and also released.
> > > > >
> > > > > Simon Mac Donald
> > > > > http://simonmacdonald.com
> > > > >
> > > > >
> > > > > On Mon, Sep 11, 2017 at 7:03 PM, Shazron 
> wrote:
> > > > > > +1 on console. No PRs for that yet though so it's not ready.
> > > > > >
> > > > > > On Tue, Sep 12, 2017 at 5:46 AM, Steven Gill <
> > stevengil...@gmail.com
> > > >
> > > > > wrote:
> > > > > >
> > > > > >> Console should be released too since it has been moved back into
> > ios
> > > > for
> > > > > >> next release. https://issues.apache.org/jira/browse/CB-13170
> > > > > >>
> > > > > >> On Sep 11, 2017 2:04 PM, "Jesse" 
> wrote:
> > > > > >>
> > > > > >> > Android release is dependent on us releasing an
> > > > > >> > updated cordova-plugin-compat
> > > > > >> >
> > > > > >> > Anyone have any reasons to not do a release? Anything
> > outstanding
> > > > > >> > anyone wants to get merged in before moving ahead with a
> plugins
> > > > > >> > release? Any other comments on the topic?
> > > > > >> >
> > > > > >> > Cheers,
> > > > > >> >   Jesse
> > > > > >> >
> > > > > 

Re: [VOTE] Plugins Release

[Steven Gill]

This vote has failed. I will send out a new one shortly

On Tue, Sep 19, 2017 at 10:28 PM, Steven Gill 
wrote:

> nice catch.
>
> On Tue, Sep 19, 2017 at 8:10 PM, Simon MacDonald <
> simon.macdon...@gmail.com> wrote:
>
>> I vote - 1
>>
>> Passed
>> * Checked for deprecation notices for plugin-device-motion & orientation
>> * Tested that cordova-plugin-console is not added for ios when cordova-ios
>> >= 4.5.0
>> * Tested that cordova-plugin-compat is not added for android when
>> cordova-android >= 6.3.0
>>
>> Failed
>> * Added cordova-plugin-camera to a project with cordova-android 6.3.0
>> which
>> depends on cordova-plugin-compat and the build fails.
>>
>> The reason the build fails is that all of the cordova plugins that depend
>> on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0. Since
>> compat was bumped to 2.0.0 when you install cordova-plugin-camera on your
>> cordova-android 6.3.0 project it fails the semver and it pulls in the
>> 1.1.0
>> version. Now both compat and cordova-android deliver the same classes and
>> the build fails.
>>
>>
>>
>> Simon Mac Donald
>> http://simonmacdonald.com
>>
>> On Mon, Sep 18, 2017 at 7:05 PM, Audrey So 
>> wrote:
>>
>> > I vote + 1
>> >
>> > * Verified signatures
>> >
>> > * Checked for deprecation notices for plugin-device-motion & orientation
>> > * Tested that cordova-plugin-console is not added for ios
>> > * Tested that cordova-plugin-compat is not added for android
>> > * Added plugins to cordova project
>> >
>> >
>> >
>> >
>> > On 9/18/17, 3:05 PM, "Joe Bowser"  wrote:
>> >
>> > >I vote +1
>> > >
>> > >* Tested cordova-plugin-compat installation to make sure it doesn't
>> > install
>> > >on cordova-android master
>> > >* Ran mobilespec locally
>> > >* Verified signatures
>> > >
>> > >
>> > >On Mon, Sep 18, 2017 at 2:08 PM, Steven Gill 
>> > wrote:
>> > >
>> > >> Please review and vote on the release of this plugins release
>> > >> by replying to this email (and keep discussion on the DISCUSS thread)
>> > >>
>> > >> Release issue: https://na01.safelinks.protection.outlook.com/?url=
>> > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
>> > 13294=02%7C01%7C%7C14e404d7c0e7454c718b08d4fee1591a%
>> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636413691211640629=%
>> > 2B2sZF4YE7bcA8vA4%2BqZgknBBArYMn0mbzXFQMlwkGR4%3D=0
>> > >>
>> > >> The plugins have been published to
>> > >> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/
>> > >>
>> > >> The packages were published from their corresponding git tags:
>> > >> cordova-plugin-console: 2.0.0 (f0e113bdf4)
>> > >> cordova-plugin-compat: 2.0.0 (0df201c24d)
>> > >> cordova-plugin-device-motion: 2.0.0 (1236b957af)
>> > >> cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)
>> > >>
>> > >> Upon a successful vote I will upload the archives to dist/, upload
>> > >> them to npm, and post the corresponding blog post.
>> > >>
>> > >> Voting guidelines:
>> > >> https://na01.safelinks.protection.outlook.com/?url=
>> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%
>> 2Fmaster%2Fdocs%
>> > 2Frelease-voting.md=02%7C01%7C%7C14e404d7c0e7454c718b08d4fee1591a%
>> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636413691211640629=
>> > TH5HU27%2FrfoPu6ZjCmQ8ZsLHx2W8LwUCwzSsQ0VCMhA%3D=0
>> > >> How to vote on a plugins release at
>> > >> https://na01.safelinks.protection.outlook.com/?url=
>> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%
>> > 2Fblob%2Fmaster%2Fdocs%2Fplug=02%7C01%7C%
>> > 7C14e404d7c0e7454c718b08d4fee1591a%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C636413691211640629=QpsOtFm7U0IYm0RjMC4RQxThr0vb9u
>> > nJ5YuXH6yrrjc%3D=0
>> > >> ins-release-process.md#voting
>> > >>
>> > >> Voting will go on for a minimum of 48 hours.
>> > >>
>> > >> I vote +1:
>> > >> * Ran coho audit-license-headers over the relevant repos
>> > >> * Ran coho check-license to ensure all dependencies and
>> > >> subdependencies have Apache-compatible licenses
>> > >> * Ensured continuous build was green when repos were tagged
>> > >>
>> >
>>
>
>

Re: [DISCUSS] Plugin release

[julio cesar sanchez]

There has been already a few people asking about the duplicate symbols on
slack

2017-09-20 17:06 GMT+02:00 Simon MacDonald :

> IMHO both cordova-plugin-compat and cordova-plugin-console should receive
> minor version bumps. Neither breaks backwards compatibility so I don't feel
> like a major version bump is warranted.
>
> As well all of our core plugins that depend on cordova-plugin-compat use
> the ^1.x in their semver so they would pull in the earlier version of the
> compat plugin and in combination with the upcoming cordova-android 6.3.0
> pretty much all apps will fail to build.
>
> When it comes to cordova-plugin-console we should also err on the side of
> caution when it comes to the version number bump. I spent some time this
> morning debugging an internal app that was using cordova-ios 4.5.0 and
> cordova-plugin-console. It was failing to build because of duplicate code.
> If cordova-plugin-console 1.1.0 (not 2.0.0) has been release before
> cordova-ios 4.5.0 the problem would not have existed.
>
> I think we need to be ready to start answering that question as to why apps
> using cordova-ios 4.5.0 don't build. Perhaps a quick blog post is in order?
>
> My recommendations is to restart this vote thread with the four plugins but
> tag their versions as cordova-plugin-compat@1.2.0,
> cordova-plugin-console@1.1.0. The device motion and device orientation
> plugins can have any version number we want as they will not run into the
> above problems.
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill 
> wrote:
>
> > Plugin vote is going to fail it seems due to the issue simon found.
> >
> > Simons  message:
> > "Failed
> > * Added cordova-plugin-camera to a project with cordova-android 6.3.0
> which
> > depends on cordova-plugin-compat and the build fails.
> >
> > The reason the build fails is that all of the cordova plugins that depend
> > on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0. Since
> > compat was bumped to 2.0.0 when you install cordova-plugin-camera on your
> > cordova-android 6.3.0 project it fails the semver and it pulls in the
> 1.1.0
> > version. Now both compat and cordova-android deliver the same classes and
> > the build fails."
> >
> > I actually have 1.2.0 version of the plugin already tagged from when I
> ran
> > the plugin process on Monday. It is identical to the 2.0.0 version that
> is
> > being voted on. We can either stop the current vote thread and start a
> new
> > one with 1.2.0 instead of 2.0.0, or we could continue the current vote
> > thread and start a new one just for compat@1.2.0. If we go with option
> 2,
> > we can release both 1.2.0 and 2.0.0.
> >
> > This is a good point to remember in the future. Deprecation should be
> minor
> > not major bumps.
> >
> >
> > On Tue, Sep 12, 2017 at 11:43 PM, Shazron  wrote:
> >
> > > Created PR for CB-13170 cordova-plugin-console
> > > https://github.com/apache/cordova-plugin-console/pull/25
> > >
> > > On Tue, Sep 12, 2017 at 7:20 AM, Simon MacDonald <
> > > simon.macdon...@gmail.com>
> > > wrote:
> > >
> > > > Both of:
> > > >
> > > > cordova-plugin-device-motion
> > > > cordova-plugin-device-orientation
> > > >
> > > > should get their deprecation PR's merge and also released.
> > > >
> > > > Simon Mac Donald
> > > > http://simonmacdonald.com
> > > >
> > > >
> > > > On Mon, Sep 11, 2017 at 7:03 PM, Shazron  wrote:
> > > > > +1 on console. No PRs for that yet though so it's not ready.
> > > > >
> > > > > On Tue, Sep 12, 2017 at 5:46 AM, Steven Gill <
> stevengil...@gmail.com
> > >
> > > > wrote:
> > > > >
> > > > >> Console should be released too since it has been moved back into
> ios
> > > for
> > > > >> next release. https://issues.apache.org/jira/browse/CB-13170
> > > > >>
> > > > >> On Sep 11, 2017 2:04 PM, "Jesse"  wrote:
> > > > >>
> > > > >> > Android release is dependent on us releasing an
> > > > >> > updated cordova-plugin-compat
> > > > >> >
> > > > >> > Anyone have any reasons to not do a release? Anything
> outstanding
> > > > >> > anyone wants to get merged in before moving ahead with a plugins
> > > > >> > release? Any other comments on the topic?
> > > > >> >
> > > > >> > Cheers,
> > > > >> >   Jesse
> > > > >> >
> > > > >> >
> > > > >> > @purplecabbage
> > > > >> > risingj.com
> > > > >> >
> > > > >>
> > > >
> > > > 
> -
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > > >
> > >
> >
>

Re: [DISCUSS] Plugin release

[Simon MacDonald]

IMHO both cordova-plugin-compat and cordova-plugin-console should receive
minor version bumps. Neither breaks backwards compatibility so I don't feel
like a major version bump is warranted.

As well all of our core plugins that depend on cordova-plugin-compat use
the ^1.x in their semver so they would pull in the earlier version of the
compat plugin and in combination with the upcoming cordova-android 6.3.0
pretty much all apps will fail to build.

When it comes to cordova-plugin-console we should also err on the side of
caution when it comes to the version number bump. I spent some time this
morning debugging an internal app that was using cordova-ios 4.5.0 and
cordova-plugin-console. It was failing to build because of duplicate code.
If cordova-plugin-console 1.1.0 (not 2.0.0) has been release before
cordova-ios 4.5.0 the problem would not have existed.

I think we need to be ready to start answering that question as to why apps
using cordova-ios 4.5.0 don't build. Perhaps a quick blog post is in order?

My recommendations is to restart this vote thread with the four plugins but
tag their versions as cordova-plugin-compat@1.2.0,
cordova-plugin-console@1.1.0. The device motion and device orientation
plugins can have any version number we want as they will not run into the
above problems.


Simon Mac Donald
http://simonmacdonald.com

On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill  wrote:

> Plugin vote is going to fail it seems due to the issue simon found.
>
> Simons  message:
> "Failed
> * Added cordova-plugin-camera to a project with cordova-android 6.3.0 which
> depends on cordova-plugin-compat and the build fails.
>
> The reason the build fails is that all of the cordova plugins that depend
> on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0. Since
> compat was bumped to 2.0.0 when you install cordova-plugin-camera on your
> cordova-android 6.3.0 project it fails the semver and it pulls in the 1.1.0
> version. Now both compat and cordova-android deliver the same classes and
> the build fails."
>
> I actually have 1.2.0 version of the plugin already tagged from when I ran
> the plugin process on Monday. It is identical to the 2.0.0 version that is
> being voted on. We can either stop the current vote thread and start a new
> one with 1.2.0 instead of 2.0.0, or we could continue the current vote
> thread and start a new one just for compat@1.2.0. If we go with option 2,
> we can release both 1.2.0 and 2.0.0.
>
> This is a good point to remember in the future. Deprecation should be minor
> not major bumps.
>
>
> On Tue, Sep 12, 2017 at 11:43 PM, Shazron  wrote:
>
> > Created PR for CB-13170 cordova-plugin-console
> > https://github.com/apache/cordova-plugin-console/pull/25
> >
> > On Tue, Sep 12, 2017 at 7:20 AM, Simon MacDonald <
> > simon.macdon...@gmail.com>
> > wrote:
> >
> > > Both of:
> > >
> > > cordova-plugin-device-motion
> > > cordova-plugin-device-orientation
> > >
> > > should get their deprecation PR's merge and also released.
> > >
> > > Simon Mac Donald
> > > http://simonmacdonald.com
> > >
> > >
> > > On Mon, Sep 11, 2017 at 7:03 PM, Shazron  wrote:
> > > > +1 on console. No PRs for that yet though so it's not ready.
> > > >
> > > > On Tue, Sep 12, 2017 at 5:46 AM, Steven Gill  >
> > > wrote:
> > > >
> > > >> Console should be released too since it has been moved back into ios
> > for
> > > >> next release. https://issues.apache.org/jira/browse/CB-13170
> > > >>
> > > >> On Sep 11, 2017 2:04 PM, "Jesse"  wrote:
> > > >>
> > > >> > Android release is dependent on us releasing an
> > > >> > updated cordova-plugin-compat
> > > >> >
> > > >> > Anyone have any reasons to not do a release? Anything outstanding
> > > >> > anyone wants to get merged in before moving ahead with a plugins
> > > >> > release? Any other comments on the topic?
> > > >> >
> > > >> > Cheers,
> > > >> >   Jesse
> > > >> >
> > > >> >
> > > >> > @purplecabbage
> > > >> > risingj.com
> > > >> >
> > > >>
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>