Re: [DISCUSS] Plugins release
Blog post for review: https://github.com/apache/cordova-docs/pull/812 On Thu, Apr 12, 2018 at 1:34 PM, Steven Gill wrote: > I've reviewed the PRs. > > Julio, for vibration plugin, I'm thinking it gets documented as a quirk. > I'll do that and start the release now. > > > On Tue, Apr 10, 2018 at 12:42 AM, Niklas Merz > wrote: > >> Not a really an important one, but I would like to see my first PR to >> InAppBrowser merged, so I can switch the plugin in our project back to >> a released version. >> >> I added an option to the InAppBrowser >> https://github.com/apache/cordova-plugin-inappbrowser/pull/254. >> >> Thanks >> >> Quoting julio cesar sanchez : >> >> > I have this one removing navigator.notification from vibration plugin >> as it >> > has been deprecated for a long time and even removed from the docs >> > https://github.com/apache/cordova-plugin-vibration/pull/67. >> > So it might require minor or major version bump? >> > >> > Also, related issue, on Android, vibration plugin uses the browser >> > implementation, but looks like Google doesn't allow to vibrate without >> user >> > interaction first, so we should document it or go back to the native >> > implementation. https://issues.apache.org/jira/browse/CB-14022. >> > If going back to the native implementation, then we should do it for >> this >> > release, if just documenting, probably can wait. >> > >> > And I have this one for InAppBrowser plugin, was going to merge it but >> > travis is failing on one of the Android tests >> > https://github.com/apache/cordova-plugin-inappbrowser/pull/264 >> > >> > >> > 2018-04-09 19:52 GMT+02:00 Steven Gill : >> > >> >> Going to aim to do a plugins release this Wed, April 11th. Let me know >> if >> >> there are any important PRs I should look at before than. >> >> >> >> >> >
[VOTE] Plugins Release
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-14030 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-14030/ The packages were published from their corresponding git tags: cordova-plugin-camera: 4.0.3 (6ce1443622) cordova-plugin-vibration: 3.1.0 (0b323409f9) cordova-plugin-statusbar: 2.4.2 (fbc4862dbd) cordova-plugin-media-capture: 3.0.2 (288a47eee1) cordova-plugin-inappbrowser: 3.0.0 (200f7c1923) cordova-plugin-globalization: 1.11.0 (65331146ca) cordova-plugin-device: 2.0.2 (e83c1afd84) cordova-plugin-battery-status: 2.0.2 (aebf1a1445) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md How to vote on a plugins release at https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ensured continuous build was green when repos were tagged
Re: [DISCUSS] Plugins release
I've reviewed the PRs. Julio, for vibration plugin, I'm thinking it gets documented as a quirk. I'll do that and start the release now. On Tue, Apr 10, 2018 at 12:42 AM, Niklas Merz wrote: > Not a really an important one, but I would like to see my first PR to > InAppBrowser merged, so I can switch the plugin in our project back to > a released version. > > I added an option to the InAppBrowser > https://github.com/apache/cordova-plugin-inappbrowser/pull/254. > > Thanks > > Quoting julio cesar sanchez : > > > I have this one removing navigator.notification from vibration plugin as > it > > has been deprecated for a long time and even removed from the docs > > https://github.com/apache/cordova-plugin-vibration/pull/67. > > So it might require minor or major version bump? > > > > Also, related issue, on Android, vibration plugin uses the browser > > implementation, but looks like Google doesn't allow to vibrate without > user > > interaction first, so we should document it or go back to the native > > implementation. https://issues.apache.org/jira/browse/CB-14022. > > If going back to the native implementation, then we should do it for this > > release, if just documenting, probably can wait. > > > > And I have this one for InAppBrowser plugin, was going to merge it but > > travis is failing on one of the Android tests > > https://github.com/apache/cordova-plugin-inappbrowser/pull/264 > > > > > > 2018-04-09 19:52 GMT+02:00 Steven Gill : > > > >> Going to aim to do a plugins release this Wed, April 11th. Let me know > if > >> there are any important PRs I should look at before than. > >> > > >
