[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @uj does my fix work on that device as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Are there any news on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @karlachavez > we have to remove the splashscreen of our app In the meantime: cordova plugins remove cordova-plugin-splashscreen cordova plugins add https://github.com/Lazza/cordova-plugin-splashscreen#bulletproof-fix --save --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @filmaj, @infil00p unfortunately I do not have access to many Samsung devices. I was able to test this plug-in only with the models mentioned in the PR. As @SamDelgado confirmed, I think the best bet is to test on a Samsung Galaxy S7 Edge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #77: CB-10879: (android) Enable overlaysWebVi...
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/77 I don't understand... why is the repository empty now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Yeah, but unfortunately... I am not even sure how I got that one to crash! ð Most of my tests in the emulators where either working or simply not showing the splash (but not crashing). If you want to be sure about getting a crash, it's better to try a Samsung device if you can get your hands on one. ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @filmaj I see. ð Just to be clear, my PR is released under the Apache Version 2.0 license as anything else in this repo (it is also the license mentioned in the project and the file header). I am not transferring copyright to someone else that could decide to prevent my code from being under the Apache License, but I am contributing the code giving all the rights specified in the license. Regarding the devices, I suggest to try those written in the first message above, especially the Samsung ones because they exhibited the crashes consistently and repeatably. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @filmaj I don't think I have. Why? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Great! Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @alsorokin, sure, go ahead. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 > Cordova CI Build has one or more failures This doesn't make sense. The build log states that the failure is on the Windows build. This PR **does not make any modification to the Windows part** of the plug-in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request #125: CB-12626: (android) Fix crash...
GitHub user Lazza opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/125 CB-12626: (android) Fix crash on Samsung devices and splash screen not showing on some other devices ### Platforms affected Android, all versions. ### What does this PR do? This PR drops the strategy of relying on the app preferences to store the `drawableId` for the splash screen. This approach causes crashes on Samsung devices and prevents the splash screen from working correctly on some other devices. ### What testing has been done on this change? This change has been tested on all devices reported in the JIRA issue: - Samsung Galaxy 7 Edge, Android 7.0 - Samsung Galaxy Note 4, Android 6.0.1 - Lenovo/Zuk Z1, Android 5.1.1 - Official Android Emulator with Nexus S simulated hardware, API 25 ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Lazza/cordova-plugin-splashscreen master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/125.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #125 commit f94a2c27e5c1082c8b73949e3bf18d0ec4609f9e Author: Andrea Lazzarotto <andrea.lazzaro...@gmail.com> Date: 2017-03-15T12:03:00Z Samsung crash quick-n-dirty fix commit f6aab146a45e172151fe931436534ba143238ec5 Author: Andrea Lazzarotto <andrea.lazzaro...@gmail.com> Date: 2017-04-01T13:22:23Z Updated Android plugin Prefer a slightly slower, but bulletproof, way to check for the splashscreen instead of relying on the Cordova preferences. This fixes the splash screen on several phones. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #77: CB-10879: (android) Enable overla...
Github user Lazza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103163815
--- Diff: src/android/StatusBar.java ---
@@ -164,4 +181,21 @@ private void setStatusBarBackgroundColor(final String
colorPref) {
}
}
}
+
+private void setStatusBarTransparent(final boolean transparent) {
+if (Build.VERSION.SDK_INT >= 21) {
+final Window window = cordova.getActivity().getWindow();
+if (transparent) {
+window.getDecorView().setSystemUiVisibility(
+View.SYSTEM_UI_FLAG_LAYOUT_STABLE
+| View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN);
+window.setStatusBarColor(Color.TRANSPARENT);
--- End diff --
Reflection is not the approach used by Android Studio in handling any of
the platform specific code. In fact, reflection has other drawbacks such as
being slow and making debugging harder.
The code uses a version check which is recognized by the standard Android
build process and it works fine also on e.g. Android API 19 and other versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #77: CB-10879: (android) Enable overla...
Github user Lazza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103163253
--- Diff: src/android/StatusBar.java ---
@@ -142,6 +142,23 @@ public void run() {
return true;
}
+if ("overlaysWebView".equals(action)) {
+if (Build.VERSION.SDK_INT >= 21) {
--- End diff --
This one is used to check the return value of the method, the one on line
186 is used to isolate API 21+ code, so that the compiler handles it correctly
and doesn't complain about it when building for older versions of Android.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #77: CB-10879: (android) Enable overla...
Github user Lazza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103162781
--- Diff: src/android/StatusBar.java ---
@@ -142,6 +142,23 @@ public void run() {
return true;
}
+if ("overlaysWebView".equals(action)) {
--- End diff --
I am not sure what you mean here. The method has the same name of the
equivalent one already existing for the iOS plug-in. Calling the method from JS
works fine and has been tested on multiple Android versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #77: CB-10879: (android) Enable overla...
GitHub user Lazza opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/77 CB-10879: (android) Enable overlaysWebView on Android API 21+ ### Platforms affected Android (API 21+). ### What does this PR do? This patch enables devices running Android API 21+ to have the status bar overlaying the WebView, i.e. `StatusBar.overlaysWebView(true)`. It lets any Android version call `StatusBar.overlaysWebView(false)` to disable the overlay, which is actually the default behavior on that platform. ### What testing has been done on this change? It has been tested on emulators running several android versions, both before and after API 21. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Lazza/cordova-plugin-statusbar patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/77.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #77 commit de4c0efa3a763807f9fbbf128ac165d2a43eb538 Author: Andrea Lazzarotto <andrea.lazzaro...@gmail.com> Date: 2017-02-26T19:11:07Z Enable overlaysWebView on Android API 21+ This patch enables devices running Android API 21+ to have the status bar overlaying the WebView, i.e. `StatusBar.overlaysWebView(true)`. It lets any Android version call `StatusBar.overlaysWebView(false)` to disable the overlay, which is actually the default behavior on that platform. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
