[GitHub] cordova-ios issue #265: CB-11952 - Introduce buildFlag option
Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/265 @shazron All checks have passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option
GitHub user adzellman reopened a pull request: https://github.com/apache/cordova-ios/pull/265 CB-11952 - Introduce buildFlag option ### Platforms affected iOS ### What does this PR do? - adds buildFlag option for passing args to xcodebuild - There can be multiple --buildFlag declarations - Warns if buildFlag would override a built-in setting ### What testing has been done on this change? - Added unit tests for build.js - I have tried this out with by passing various legal and illegal flags using the --buildFlag option. I used the xcodebuild man page to develop test cases. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/adzellman/aemm-ios CB-11952 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/265.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #265 commit e393738fe1f26824555bd090d1e08a725ed75f88 Author: Andrew Zellman <zell...@adobe.com> Date: 2016-10-05T22:14:59Z CB-11952 - Introduce buildFlag option - adds buildFlag option for passing args to xcodebuild - There can be multiple --buildFlag declarations - Warns if buildFlag would override a built-in setting commit d614152e7eafd57527de7f37dee757250c3fa3ad Author: Andrew Zellman <zell...@adobe.com> Date: 2016-10-06T23:20:14Z Remove the optional import of check_reqs. - Use a try-catch instead, because it actually works. commit 6d0cc7c56dc4e4e9c93e0a842e92c24964cc6d0e Author: Andrew Zellman <zell...@adobe.com> Date: 2016-10-06T23:26:30Z Use util for string formatting of warning. commit cbf4bac766467c150657d09fd9b5956bbf285b9d Author: Andrew Zellman <zell...@adobe.com> Date: 2016-10-07T17:09:29Z Make changes for using workspace instead of project. commit 68ab00a474ef947e5b2796e596cf23e5c3d8af75 Author: Andrew Zellman <zell...@adobe.com> Date: 2016-10-08T01:12:03Z Merge branch 'master' of https://github.com/apache/cordova-ios into CB-11952 commit 2b221fd38170486756bc0667fdc62acc0ce8d011 Author: Andrew Zellman <zell...@adobe.com> Date: 2016-10-08T03:04:10Z Fix up options in response to PR #257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option
Github user adzellman closed the pull request at: https://github.com/apache/cordova-ios/pull/265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #265: CB-11952 - Introduce buildFlag option
Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/265 I'm not sure why Travis would fail to run `n stable`. I just tried it locally and it installed v6.6.0 just fine. Can we re-trigger Travis? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option
Github user adzellman commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/265#discussion_r82491459
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -199,33 +219,52 @@ module.exports.findXCodeProjectIn =
findXCodeProjectIn;
* @param {Boolean} isDevice Flag that specify target for package
(device/emulator)
* @return {Array} Array of arguments that could be passed
directly to spawn method
*/
-function getXcodeBuildArgs(projectName, projectPath, configuration,
isDevice) {
+function getXcodeBuildArgs(projectName, projectPath, configuration,
isDevice, buildFlags) {
var xcodebuildArgs;
+var options;
+var buildActions = [ 'build' ];
+var settings;
+var customArgs = {};
+customArgs.otherFlags = [];
+
+if (buildFlags) {
+if (typeof buildFlags === 'string' || buildFlags instanceof
String) {
+parseBuildFlag(buildFlags, customArgs);
+} else { // buildFlags is an Array of strings
+buildFlags.forEach( function(flag) {
+parseBuildFlag(flag, customArgs);
+});
+}
+}
+
if (isDevice) {
-xcodebuildArgs = [
-'-xcconfig', path.join(__dirname, '..', 'build-' +
configuration.toLowerCase() + '.xcconfig'),
-'-workspace', projectName + '.xcworkspace',
-'-scheme', projectName,
-'-configuration', configuration,
-'-destination', 'generic/platform=iOS',
-'-archivePath', projectName + '.xcarchive',
-'archive',
--- End diff --
Oh, it actually changed from the build command to the archive command.
That's interesting.
This was allowed in just a couple days ago with no automated tests. It'll
take me a little bit to make sure I didn't break anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #265: CB-11952 - Introduce buildFlag option
Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/265 @shazron Review comments addressed. Please re-review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option
GitHub user adzellman opened a pull request: https://github.com/apache/cordova-ios/pull/265 CB-11952 - Introduce buildFlag option ### Platforms affected iOS ### What does this PR do? - adds buildFlag option for passing args to xcodebuild - There can be multiple --buildFlag declarations - Warns if buildFlag would override a built-in setting ### What testing has been done on this change? - Added unit tests for build.js - I have tried this out with by passing various legal and illegal flags using the --buildFlag option. I used the xcodebuild man page to develop test cases. ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/adzellman/aemm-ios CB-11952 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/265.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #265 commit e393738fe1f26824555bd090d1e08a725ed75f88 Author: Andrew Zellman <zell...@adobe.com> Date: 2016-10-05T22:14:59Z CB-11952 - Introduce buildFlag option - adds buildFlag option for passing args to xcodebuild - There can be multiple --buildFlag declarations - Warns if buildFlag would override a built-in setting --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #263: CB-11952 - Introduce buildFlag option
Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/263 I'm going to clean this up and submit a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #263: CB-11952 - Introduce buildFlag option
Github user adzellman closed the pull request at: https://github.com/apache/cordova-ios/pull/263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #263: CB-11952 - Introduce buildFlag option
Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/263 Let me see if I can add some tests here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #263: CB-11952 - Introduce buildFlag option
GitHub user adzellman opened a pull request: https://github.com/apache/cordova-ios/pull/263 CB-11952 - Introduce buildFlag option ### Platforms affected iOS ### What does this PR do? - Add buildFlag option for passing args to xcodebuild - There can be multiple --buildFlag declarations - Warns if buildFlag would override a built-in setting ### What testing has been done on this change? I have tried this out with by passing various legal and illegal flags using the --buildFlag option. I used the [xcodebuild man page](https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man1/xcodebuild.1.html) to develop test cases. ### Checklist - [] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/adzellman/aemm-ios CB-11952 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/263.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #263 commit dcbcaa466a3240eb277a5fcbd0691f18c21d3326 Author: Andrew Zellman <zell...@adobe.com> Date: 2016-10-05T22:14:59Z CB-11952 - Introduce buildFlag option - Allows user to pass arguments to xcodebuild --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-11218 Convert button list ...
GitHub user adzellman opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/76 CB-11218 Convert button list to appropriate type - If the buttons are passed in as a comma-separated string, then create an array with those values. JIRA: https://issues.apache.org/jira/browse/CB-11218 You can merge this pull request into a Git repository by running: $ git pull https://github.com/adobe-marketing-cloud-mobile/cordova-plugin-dialogs CB-11218cordova-plugin-dialogs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/76.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #76 commit 28633f14e1f02db8440e6465246597cac7c809d0 Author: Andrew Zellman <zell...@adobe.com> Date: 2016-05-06T19:17:24Z CB-11218 Convert button list to appropriate type - If the buttons are passed in as a comma-separated string, then create an array with those values. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-11218 iOS: Handle single b...
Github user adzellman closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-11218 iOS: Handle single b...
GitHub user adzellman opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/75 CB-11218 iOS: Handle single button passed as string - If the buttons are passed in as a string, then create an array with that string as the only value. JIRA: https://issues.apache.org/jira/browse/CB-11218 You can merge this pull request into a Git repository by running: $ git pull https://github.com/adobe-marketing-cloud-mobile/cordova-plugin-dialogs CB-11218cordova-plugin-dialogs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/75.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #75 commit fe94dc0d8139d69d9189b1bc86b53f7a45f6c16a Author: Andrew Zellman <zell...@adobe.com> Date: 2016-05-06T17:50:58Z CB-11218 iOS: Handle single button passed as string - If the buttons are passed in as a string, then create an array with that string as the only value. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: CB-11212 iOS: Explicitl...
GitHub user adzellman opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/61 CB-11212 iOS: Explicitly set the bundle for images - set the bundle to the CDVCapture's bundle instead of assuming application bundle. You can merge this pull request into a Git repository by running: $ git pull https://github.com/adobe-marketing-cloud-mobile/cordova-plugin-media-capture CB-11212cordova-plugin-media-capture Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media-capture/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit 9778908e151e7f4959311989a38d03d7a07a96db Author: Andrew Zellman <zell...@adobe.com> Date: 2016-05-05T23:47:52Z CB-11212 iOS: Explicitly set the bundle for images - set the bundle to the CDVCapture's bundle instead of assuming application bundle. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
