[GitHub] cordova-js pull request #150: CB-13501 : added support for node 8
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-js/pull/150 CB-13501 : added support for node 8 ### Platforms affected ### What does this PR do? Added support for node 8 ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-js CB-13501 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/150.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #150 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #162: CB-13504 : adding progress to knownIssues fo...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-coho/pull/162 CB-13504 : adding progress to knownIssues for cordova-fetch 1.2.1 rel⦠â¦ease ### Platforms affected ### What does this PR do? Adding progress to knownIssues for cordova-fetch 1.2.1 ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-coho CB-13504 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/162.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #162 commit 26e817f8af0ecb09712c11372b98d21bba13aa3a Author: Audrey So <audre...@apache.org> Date: 2017-10-27T22:38:38Z CB-13504 : adding progress to knownIssues for cordova-fetch 1.2.1 release --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request #288: CB-13501 : updated to include node 8
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-cli/pull/288 CB-13501 : updated to include node 8 ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-cli CB-13501 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/288.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #288 commit e2e42fd10bbcda65db27be4d3e5e8c998d1beaa3 Author: Audrey So <audre...@apache.org> Date: 2017-10-27T16:04:37Z CB-13501 : updated to include node 8 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #603: CB-12361 : added unit tests for check.js
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/603 CB-12361 : added unit tests for check.js ### Platforms affected ### What does this PR do? Added unit tests for check.js to increase coverage ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-check.js Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/603.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #603 commit d6a9afe9087327268e0e4c2d5cffb4424908f4d4 Author: Audrey So <audre...@apache.org> Date: 2017-10-24T22:26:41Z CB-12361 : added unit tests for check.js --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #600: CB-13478 : Fix CRLF line endings and lint integratio...
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/600 Hi! @akdor1154 Can you please squash your commits? Thank you! --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #602: CB-12774 : Don't munge scoped plugin IDs anym...
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/602#discussion_r147014589
--- Diff: src/cordova/util.js ---
@@ -255,11 +255,20 @@ function findPlugins (pluginDir) {
var plugins = [];
if (fs.existsSync(pluginDir)) {
-plugins = fs.readdirSync(pluginDir).filter(function (fileName) {
-var pluginPath = path.join(pluginDir, fileName);
-var isPlugin = isDirectory(pluginPath) ||
isSymbolicLink(pluginPath);
-return fileName !== '.svn' && fileName !== 'CVS' && isPlugin;
-});
+plugins = fs.readdirSync(pluginDir)
+.reduce(function (plugins, pluginOrScope) {
+if (pluginOrScope[0] === '@') {
+plugins.push(...fs.readdirSync(path.join(pluginDir,
pluginOrScope)).map(s => path.join(pluginOrScope, s)));
--- End diff --
Thanks for your question! We are sticking to the current style for now. We
need to have a discussion on our mailing list about starting to use es2015
features/ which ones to use and get some consensus.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #602: CB-12774 : Don't munge scoped plugin IDs anym...
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/602#discussion_r147012615
--- Diff: src/cordova/util.js ---
@@ -255,11 +255,20 @@ function findPlugins (pluginDir) {
var plugins = [];
if (fs.existsSync(pluginDir)) {
-plugins = fs.readdirSync(pluginDir).filter(function (fileName) {
-var pluginPath = path.join(pluginDir, fileName);
-var isPlugin = isDirectory(pluginPath) ||
isSymbolicLink(pluginPath);
-return fileName !== '.svn' && fileName !== 'CVS' && isPlugin;
-});
+plugins = fs.readdirSync(pluginDir)
+.reduce(function (plugins, pluginOrScope) {
+if (pluginOrScope[0] === '@') {
+plugins.push(...fs.readdirSync(path.join(pluginDir,
pluginOrScope)).map(s => path.join(pluginOrScope, s)));
--- End diff --
Hi! This line will need to be changed as it will not work with Node 4,
which is still currently supported.
http://node.green/#ES2015-syntax-spread---operator-with-generic-iterables--in-calls
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #599: CB-13463 : prevent package.json update with --nosave...
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/599 @stevengill CI is passing now. Let me know if I should merge it in! --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #599: CB-13463 : prevent package.json update with -...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/599 CB-13463 : prevent package.json update with --nosave (for plugins) ### Platforms affected ### What does this PR do? Prevent package.json update with --nosave (for plugins) ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13463 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/599.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #599 commit 2226a21bccf6a77f00ba8bdbd45c59667990 Author: Audrey So <audre...@apache.org> Date: 2017-10-20T21:10:26Z CB-13463 : prevent package.json update plugins with --nosave --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #598: CB-13123 : plugin add should use cordovaDepen...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/598 CB-13123 : plugin add should use cordovaDependency instead of plugin.xml engine tag ### Platforms affected ### What does this PR do? plugin add/ install should use cordovaDependency instead of plugin.xml engine tag ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13123 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/598.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #598 commit 5d6ad4a3dc4ed41b87140fcd9cf83d359b6fb798 Author: Audrey So <audre...@apache.org> Date: 2017-10-18T20:47:00Z CB-13123 : plugin add/ install should use cordovaDependency instead of plugin.xml engine tag --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #596: CB-13303 : added save_exact and production op...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/596 CB-13303 : added save_exact and production opts ### Platforms affected ### What does this PR do? Added save-exact and production opts ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13303 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/596.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #596 commit cdcfb60d3b5172c2c52ac7afe72e43610068af05 Author: Audrey So <audre...@apache.org> Date: 2017-10-03T22:57:52Z CB-13303 : added save_exact and production opts --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request #287: CB-13303 : added noprod/production as an opti...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-cli/pull/287 CB-13303 : added noprod/production as an option, no prod turns off pr⦠â¦oduction ### Platforms affected ### What does this PR do? Added noprod/production as an option ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-cli CB-13303 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/287.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #287 commit 145c1e6acc9152e39aeb3d2ebae5a1d4d5843e43 Author: Audrey So <audre...@apache.org> Date: 2017-10-03T21:14:18Z CB-13303 : added noprod/production as an option, no prod turns off production --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request #286: CB-13353 : added save-exact option
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/286#discussion_r142508791
--- Diff: src/cli.js ---
@@ -449,6 +450,10 @@ function cli (inputArgs) {
args.save = true;
}
+if (args['save-exact']) {
--- End diff --
@stevengill Hmm you are right, I don't think these are needed. I will take
it out. The test still passes without these lines and manual tests work too.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request #286: CB-13353 : added save-exact option
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/286#discussion_r142480887
--- Diff: src/cli.js ---
@@ -443,12 +444,16 @@ function cli (inputArgs) {
});
}
-if (args.nosave) {
+if (args.nosave || args['save-exact']) {
--- End diff --
kk updated! thanks!
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request #286: CB-13353 : added save-exact option
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-cli/pull/286 CB-13353 : added save-exact option ### Platforms affected ### What does this PR do? Added save-exact option ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-cli CB-13353 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/286.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #286 commit 5b742e7eb49b16899755ffae6e1153e0ff04 Author: Audrey So <audre...@apache.org> Date: 2017-09-29T22:40:55Z CB-13353 : added save-exact to cli and unit test --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r141135727
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB;
},
"scripts": {
+"eslint": "eslint src test",
--- End diff --
If I do `npm run eslint pkg/`, it will reveal all of the pkg/ errors. I can
reduce some errors using --fix (mostly indenting errors) but the rest would
have to be fixed manually. I won't be able to change/fix anything, however,
unless I can check in the pkg/ directory though. If I run `npm run eslint`
without specifying pkg, it will just ignore it. Hmm...
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #160: CB-13331 : add in missing labels/tags to tra...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-coho/pull/160 CB-13331 : add in missing labels/tags to track issues more easily and⦠⦠clearly ### Platforms affected ### What does this PR do? update/ add in missing labels & tags when triaging ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-coho CB-13331 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/160.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #160 commit b6e299cf868d61d468ce9f3445106d5ebfaf84bd Author: Audrey So <audre...@apache.org> Date: 2017-09-26T17:12:26Z CB-13331 : add in missing labels/tags to track issues more easily and clearly --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r141107663
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB;
},
"scripts": {
+"eslint": "eslint src test",
--- End diff --
But yes running eslint on pkg results in many errors. Mostly indentation
errors.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-js/pull/149 CB-12895 : added eslint to repo ### Platforms affected ### What does this PR do? Added eslint to repo ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-js CB-12895-eslint Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/149.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #149 commit b26580bf5cf4705c19ee00783f462e8fc4d3c958 Author: Audrey So <audre...@apache.org> Date: 2017-09-25T21:06:08Z CB-12895 : added eslint to repo --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #595: CB-12361 : updated and added unit tests for a...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/595 CB-12361 : updated and added unit tests for add.spec.js ### Platforms affected ### What does this PR do? Updated and added "to-do" unit tests for add.spec.js ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-plugin_fetch Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/595.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #595 commit ec07983d1ed587358a30fc003e9f86edd47e9bce Author: Audrey So <audre...@apache.org> Date: 2017-09-18T20:37:45Z CB-12361 : updated and added unit tests for add.spec.js --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #594: CB-13288 : updated index.js and test to fix c...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/594 CB-13288 : updated index.js and test to fix cordova plugin search ### Platforms affected ### What does this PR do? Updated index.js and test to fix cordova plugin search ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13288 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/594.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #594 commit e50c9b60e45cdc033d68bce62a2af894da0e1b61 Author: Audrey So <audre...@apache.org> Date: 2017-09-15T20:34:44Z CB-13288 : updated index.js and test to fix cordova plugin search --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #592: CB-12361 : added some unit tests for plugman
Github user audreyso closed the pull request at: https://github.com/apache/cordova-lib/pull/592 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #593: CB-12361 : added plugin unit tests for plugin...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/593 CB-12361 : added plugin unit tests for plugin list ### Platforms affected ### What does this PR do? Added plugin unit tests for plugin list ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-list_spec Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/593.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #593 commit e956fe7c8d0cbd8c7663bed4e66d5b1f78411e68 Author: Audrey So <audre...@apache.org> Date: 2017-09-15T16:32:55Z CB-12361 : added plugin tests for plugin list --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #592: CB-12361 : added some unit tests for plugman
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/592 CB-12361 : added some unit tests for plugman ### Platforms affected ### What does this PR do? Added some unit tests for plugman ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-plugman Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/592.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #592 commit d61c084b2192dbe3831c8448d35bdeeafb36636d Author: Audrey So <audre...@apache.org> Date: 2017-08-23T17:43:34Z CB-12361 : added unit tests for plugman --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request #285: CB-13274 : removed .jshintignore file and rem...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-cli/pull/285 CB-13274 : removed .jshintignore file and removed unneeded references to jshint ### Platforms affected ### What does this PR do? Removed .jshintignore file and removed unneeded references to jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-cli CB-13274 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/285.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #285 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #591: CB-13274 : updated readme.md & removed refere...
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/591
CB-13274 : updated readme.md & removed references to jshint
### Platforms affected
### What does this PR do?
Updated readme.md & removed references to jshint
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-13274
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/591.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #591
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #726: Small update to readme.md
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-docs/pull/726 Small update to readme.md ### Platforms affected ### What does this PR do? Small update to readme.md ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-docs update_README.md Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/726.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #726 commit bee54153c29d6840004746fa4e43081e23007e84 Author: Audrey So <audre...@apache.org> Date: 2017-09-07T16:39:23Z small update to readme.md --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #725: minor updates to README.md
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-docs/pull/725 minor updates to README.md ### Platforms affected ### What does this PR do? Minor updates to README.md. ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-docs update_release_docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/725.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #725 commit 0d2233831f76c9aabb513804cef6db63f14afa8d Author: Audrey So <audre...@apache.org> Date: 2017-09-05T23:23:42Z update README.md --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #724: CB-13231 : added cordova-common@2.1.0 releas...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-docs/pull/724 CB-13231 : added cordova-common@2.1.0 release blog post ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-docs CB-13231 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/724.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #724 commit 347dde1d1b9b6c04f6448c9da6497d9841bfe933 Author: Audrey So <audre...@apache.org> Date: 2017-09-01T23:32:58Z CB-13231 : added cordova-common@2.1.0 release blog post --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...
Github user audreyso closed the pull request at: https://github.com/apache/cordova-lib/pull/590 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #157: Fixed/revised tools-release-process.md
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-coho/pull/157 Fixed/revised tools-release-process.md ### Platforms affected ### What does this PR do? Fixed/revised tools-release-process.md ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-coho update-release-doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/157.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #157 commit 76bcbb2dface9c4d85dcd5c00ffd376bed6373ca Author: Audrey So <audre...@apache.org> Date: 2017-08-31T17:35:04Z : fixed tools-release-process.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #569: CB-12361: added main function unit tests for ...
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/569#discussion_r135308470
--- Diff: spec/cordova/plugin/add.spec.js ---
@@ -21,16 +21,82 @@
/* globals fail */
var Q = require('q');
-var add = require('../../../src/cordova/plugin/add');
+var rewire = require('rewire');
+var add = rewire('../../../src/cordova/plugin/add');
+var plugman = require('../../../src/plugman/plugman');
+var cordova_util = require('../../../src/cordova/util');
+var path = require('path');
+var fs = require('fs');
+var config = require('../../../src/cordova/config');
+var events = require('cordova-common').events;
+var registry = require('../../../src/plugman/registry/registry');
+var plugin_util = require('../../../src/cordova/plugin/util');
-describe('cordova/plugin/add', function () {
+fdescribe('cordova/plugin/add', function () {
var projectRoot = '/some/path';
var hook_mock;
+var Cfg_parser_mock = function () {};
+var cfg_parser_revert_mock;
+var plugin_info_provider_mock = function () {};
+var plugin_info_provider_revert_mock;
+var plugin_info;
+var package_json_mock;
+
beforeEach(function () {
hook_mock = jasmine.createSpyObj('hooks runner mock', ['fire']);
hook_mock.fire.and.returnValue(Q());
+Cfg_parser_mock.prototype = jasmine.createSpyObj('config parser
prototype mock', ['getPlugin', 'removePlugin', 'addPlugin', 'write']);
+/* eslint-disable */
+Cfg_parser_mock.prototype.getPlugin;
+Cfg_parser_mock.prototype.getPlugin;
--- End diff --
Hi! I think you have "getPlugin" twice?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/590 CB-13145: Create playservices version preference in config.xml Still need to add in tests ### Platforms affected ### What does this PR do? CB-13145: Create playservices version preference in config.xml ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13145-Steve Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/590.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #590 commit 315e6a80b95a425a07a0a32e53e24ce10e1ef89c Author: Steve Gill <stevengil...@gmail.com> Date: 2017-08-23T04:39:24Z CB-13145: pass full options to plugman uninstall commit faa48e255fc02dd42f2bcc7eaa43f816967305cb Author: Audrey So <audre...@apache.org> Date: 2017-08-23T20:27:45Z CB-13145 : added variable-merge.js to deal with plugin.xml variables for uninstall --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #574: CB-12838 : prevented sorting and alphabetizing platf...
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/574 Thanks @stevengill ! I will merge it in today! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/574#discussion_r132795105
--- Diff: src/cordova/restore-util.js ---
@@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {
fs.writeFileSync(pkgJsonPath, JSON.stringify(pkgJson, null,
2), 'utf8');
}
}
-// Write config.xml (only if plugins exist in package.json).
+// Write to config.xml (only if it is different from package.json in
content)
comboPluginIdArray.forEach(function (plugID) {
+var configXMLPlugin = cfg.getPlugin(plugID);
if (pluginIdConfig.indexOf(plugID) < 0) {
pluginIdConfig.push(plugID);
-}
-cfg.removePlugin(plugID);
-if (mergedPluginSpecs[plugID]) {
+if (mergedPluginSpecs[plugID]) {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID, spec:
mergedPluginSpecs[plugID]}, comboObject[plugID]);
+modifiedConfigXML = true;
+} else {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID}, comboObject[plugID]);
+modifiedConfigXML = true;
+}
+
+// Write only if the plugin variables or specs are different from
pkgJson
+} else if (((pluginIdConfig.indexOf(plugID) > 0) &&
(mergedPluginSpecs[plugID]) &&
+((configXMLPlugin.variables !== comboObject[plugID]))) ||
+((mergedPluginSpecs[plugID] !== configXMLPlugin.spec) ||
--- End diff --
Yes, exactly! Also rebased and updated based on feedback. Let me know if
there's anything else!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #154: CB-12895 : Added eslint
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-coho/pull/154 CB-12895 : Added eslint ### Platforms affected ### What does this PR do? Added eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-coho CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/154.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #154 commit dfe6f40058b1eafc48cd00eb3876853fc28a7cf3 Author: Audrey So <audre...@apache.org> Date: 2017-06-09T18:40:05Z CB-12895 : added eslint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #236: CB-12895 : Added eslint and r...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/236 CB-12895 : Added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-inappbrowser CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/236.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #236 commit db6072abe512b9a63ba8d568e98d8dfb23bddc73 Author: Audrey So <audre...@apache.org> Date: 2017-06-12T17:34:08Z CB-12895 : added eslint and removed jshint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-globalization pull request #60: CB-12895 : added eslint and r...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/60 CB-12895 : added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-globalization CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-globalization/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 commit 77894697a1931eece7cca33d39def94a096632f0 Author: Audrey So <audre...@apache.org> Date: 2017-06-12T17:26:46Z CB-12895 : added eslint and removed jshint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request #214: CB-12895 : Setup eslint and removed j...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-file/pull/214 CB-12895 : Setup eslint and removed jshint ### Platforms affected ### What does this PR do? Setup eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-file CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/214.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #214 commit c307226bb317f69a8df93688a6c2d71aa53fe37f Author: Audrey So <audre...@apache.org> Date: 2017-06-09T23:06:08Z CB-12895 : setup eslint and took out jshint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request #92: CB-12895 : Added eslint and rem...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/92 CB-12895 : Added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-geolocation CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-geolocation/pull/92.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #92 commit 69eb5ba5b5e801c55661dd277a2dd6997ff19c4d Author: Audrey So <audre...@apache.org> Date: 2017-06-12T17:18:43Z CB-12895 : added eslint and removed jshint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request #96: CB-12895 : setup eslint and removed...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/96 CB-12895 : setup eslint and removed jshint ### Platforms affected ### What does this PR do? Setup eslint and removed jshint. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-dialogs CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/96.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #96 commit 0b532b6eeb04c6adbccfea60f132f88de0c14755 Author: Audrey So <audre...@apache.org> Date: 2017-06-09T23:01:13Z CB-12895 : setup eslint and removed jshint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device pull request #70: CB-12895 : Setup eslint and removed ...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-device/pull/70 CB-12895 : Setup eslint and removed jshint ### Platforms affected ### What does this PR do? Setup eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-device CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 commit 042ce62ed25d9e2fa7c5b8295a426c622ebe5654 Author: Audrey So <audre...@apache.org> Date: 2017-06-09T22:27:27Z CB-12895 : setup eslint and removed jshint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request #82: CB-12895 : Added eslint and r...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/82 CB-12895 : Added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-media-capture CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media-capture/pull/82.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #82 commit 1694228a2cd01bdea8b15fb0d6b6f8d4dbcb091f Author: Audrey So <audre...@apache.org> Date: 2017-06-12T18:03:09Z CB-12895 : added eslint and removed jshint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-battery-status pull request #58: CB-12895 : Added eslint and ...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/58 CB-12895 : Added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-battery-status CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-battery-status/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit 835acc8d4daf4693d21c4be086fb06d1bdf9fc81 Author: Audrey So <audre...@apache.org> Date: 2017-06-09T21:41:05Z CB-12895 : added eslint and removed jshint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request #58: CB-12895 : added eslint...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/58 CB-12895 : added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-network-information CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit 78691e43e16d753603f41d646ca7e71b3212c282 Author: Audrey So <audre...@apache.org> Date: 2017-06-12T18:15:35Z CB-12895 : added eslint and removed eslint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request #59: CB-12895 : added eslint and remov...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/59 CB-12895 : added eslint and removed jshint ### Platforms affected ### What does this PR do? ### What testing has been done on this change? Added eslint and removed jshint ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-vibration CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-vibration/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit d23d7a870ed9fcfe6df076fe1ec49d4a71780d8d Author: Audrey So <audre...@apache.org> Date: 2017-06-12T18:43:21Z CB-12895 : added eslint and removed jshint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #588: CB-13056 : Removed parsers & platformApi poly...
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/588
CB-13056 : Removed parsers & platformApi polyfill for webos, blackberry, &
ubuntu
### Platforms affected
### What does this PR do?
Removed parsers & platformApi polyfill for webos, blackberry, & ubuntu.
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-13056
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/588.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #588
commit d855daa20165487b37bed6b07fcdd5878564337f
Author: Audrey So <audre...@apache.org>
Date: 2017-08-01T22:59:07Z
CB-13056 : removed parsers and platformApi polyfill for webos,
blackberry10, and ubuntu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #587: CB-13056 : added deprecation notice for webos
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/587 CB-13056 : added deprecation notice for webos ### Platforms affected ### What does this PR do? Added deprecation notice for webos ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13056-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/587.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #587 commit d673efd5b21fc452d1343771f731021ea6b5da28 Author: Audrey So <audre...@apache.org> Date: 2017-08-01T23:05:24Z CB-13056 : added deprecation notice for webos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #586: CB-13057 : Remove cordova platform save command
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/586 Can I delete: 1. commented out tests or parts of tests that contain platforms.json or platform_metadata? 2. Can I delete save.js and save.spec.js? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #586: CB-13057 : Remove cordova platform save comma...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/586 CB-13057 : Remove cordova platform save command ### Platforms affected ### What does this PR do? Remove cordova platform save command ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13057-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/586.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #586 commit 3f66326f751de7c78f1e1b544bed38cf009d5e9d Author: Audrey So <audre...@apache.org> Date: 2017-08-01T22:06:41Z CB-13057 : removed save function and updated unit-tests after these changes commit 799e14d032e5c59f9dca5ad5921155572b2e246e Author: Audrey So <audre...@apache.org> Date: 2017-08-01T22:07:52Z CB-13057 : removed platformsJson from integration tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #585: CB-13057 : added deprecation warning for cord...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/585 CB-13057 : added deprecation warning for cordova platform save ### Platforms affected ### What does this PR do? Added deprecation warning for cordova platform save ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13057 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/585.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #585 commit 5d9e3336071d00fc550cb1b042172466a0a86704 Author: Audrey So <audre...@apache.org> Date: 2017-08-01T20:46:59Z CB-13057 : added deprecation warning for cordova platform save --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework issue #26: CB-12895 : replaced jshint with esl...
Github user audreyso commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/26 Thanks for the review! Okay to merge @filmaj? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request #26: CB-12895 : replaced jshint w...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/26 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-test-framework CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 commit 37acdf6074e05a27768e02ab892782f97fedee24 Author: Audrey So <audre...@apache.org> Date: 2017-08-01T00:00:17Z CB-12895 : replaced jshint with eslint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #41: CB-12895: replaced jshint ...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/41 CB-12895: replaced jshint with eslint ### Platforms affected ### What does this PR do? replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-wkwebview-engine CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/41.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #41 commit b2b121b856d0ea92fadca6cae5d8ff283c68f40f Author: Audrey So <audre...@apache.org> Date: 2017-06-12T18:59:35Z CB-12895 : added eslint and removed jshint commit 919dbcec374b3a7ebab0131da9870ec25cb10db2 Author: Audrey So <audre...@apache.org> Date: 2017-07-31T20:52:59Z CB-12895 : rebased and updated files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/578#discussion_r129969368
--- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js ---
@@ -0,0 +1,79 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var path = require('path');
+var fs = require('fs');
+var Q = require('q');
+var rewire = require('rewire');
+var cordova_util = require('../../../src/cordova/util');
+var platform_getPlatformDetails =
rewire('../../../src/cordova/platform/getPlatformDetailsFromDir');
+var events = require('cordova-common').events;
+var fail;
+
+describe('cordova/platform/getPlatformDetailsFromDir', function () {
+var package_json_mock;
+package_json_mock = jasmine.createSpyObj('package json mock',
['cordova', 'dependencies']);
+package_json_mock.name = 'io.cordova.hellocordova';
+package_json_mock.version = '1.0.0';
+
+beforeEach(function () {
+spyOn(Q, 'reject');
+spyOn(fs, 'existsSync');
+spyOn(cordova_util, 'requireNoCache');
+spyOn(events, 'emit');
+});
+
+it('should throw if no config.xml or pkgJson', function (done) {
+platform_getPlatformDetails('dir', ['ios']);
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does
not seem to contain a valid package.json or a valid Cordova platform/));
+done();
+});
+
+it('should throw if no platform is provided', function (done) {
+cordova_util.requireNoCache.and.returnValue({});
+platform_getPlatformDetails('dir');
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does
not seem to contain a Cordova platform:/));
+done();
+});
+
+it('should return a promise with platform and version', function
(done) {
+fs.existsSync.and.callFake(function(filePath) {
+if(path.basename(filePath) === 'package.json') {
+return true;
+} else {
+return false;
+}
+});
+cordova_util.requireNoCache.and.returnValue(package_json_mock);
+platform_getPlatformDetails('dir', ['cordova-android'])
+.then(function(result) {
+expect(result.platform).toBe('io.cordova.hellocordova');
+expect(result.version).toBe('1.0.0');
+expect(Q.reject).not.toHaveBeenCalled();
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('should remove the cordova- prefix from the platform name for known
platforms', function (done) {
+platform_getPlatformDetails.platformFromName('cordova-ios');
+expect(events.emit).toHaveBeenCalledWith('verbose',
jasmine.stringMatching(/Removing "cordova-" prefix/));
+
expect(platform_getPlatformDetails.platformFromName('cordova-ios')).toBe('ios');
--- End diff --
ohh okay do you mean just like this?
```
it('should remove the cordova- prefix from the platform name for known
platforms', function (done) {
expect(platform_getPlatformDetails.platformFromName('cordova-ios')).toBe('ios');
expect(events.emit).toHaveBeenCalledWith('verbose',
jasmine.stringMatching(/Removing "cordova-" prefix/));
done();
});
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/584 CB-12361 : added tests for plugin/save.js ### Platforms affected ### What does this PR do? added tests for plugin/save.js ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-16-plugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/584.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #584 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #576: CB-12361 : added unit tests for remove platform
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/576 Thanks @stevengill I will merge it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #583: CB-12361 : added tests for plugin/index.js
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/583 CB-12361 : added tests for plugin/index.js ### Platforms affected ### What does this PR do? Added tests for plugin/index.js ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-15-plugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/583.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #583 commit aa955945048b0fac8287ee715e30a49f7219eb5c Author: Audrey So <audre...@apache.org> Date: 2017-07-26T18:36:21Z CB-12361 : added tests for plugin/index.js --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r129106466
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+
+bin/update
+- not entirely sure this code is run, or needs to exist with newish
non-destructive platform updates
+
+## Package Expectations
+
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this
platform and get access to the Api.
+
+## Api (Platform) Expectations
+- The PlatformApi class
+- The PlatformApi class is an abstraction around a particular platform
that exposes all the actions, properties, and methods for this platform so they
are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets
and js files.
+- It exposes a single 'prepare' method to provide a way for
cordova-lib to apply a project's setting/www content to the platform.
+- The PlatformApi class should be implemented by each platform that
wants to use the new API flow. For those platforms, which don't provide their
own PlatformApi, there will be a polyfill in cordova-lib.
+- Platforms that implement their own PlatformApi instance should
implement all prototype methods of this class to be fully compatible with
cordova-lib.
+- The PlatformApi instance should define the following field:
+- platform : This is a String that defines a platform name.
+
+- Api.js exports static functions
+- there is currently a requirement that the file be called Api.js
(todo:change that)
+
+
+- Api.js exports static function `updatePlatform(destination, options,
events);`
+- PlatformApi.updatePlatform = function (cordovaProject, options) {};
+- The `updatePlatform` method is equal to the bin/update script. It
should update an already installed platform. It should accept a CordovaProject
instance, that defines a project structure and configuration, that should be
applied to the new platform, and an options object.
+- cordovaProject: This is a CordovaProject instance that defines a
project structure and configuration, that should be applied to the new
platform. This argument is optional and if not defined, that platform is used
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that
should override the default one from platform.
+- options.link : This is a flag that should indicate that the
platform's sources will be linked to the installed platform instead of copying.
+ - The `updatePlatform` method must return a promise, which is either
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+
+- Api.js exports static function `createPlatform(destination, cfg,
options, events);`
+- PlatformApi.createPlatform = function(cordovaProject, options) {};
+- The `createPlatform method` is equal to the bin/create script. It
should install the platform to a specified directory and create a platform
project. It should accept a CordovaProject instance, that defines a project
structure and configuration, that should be applied to the new platform, and an
options object.
+- cordovaProject : This is a CordovaProject instance that defines a
project structure and configuration, that should be applied to the new
platform. This argument is optional and if not defined, that platform is used
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that
should override the default one from the platform.
+- options.link : This is a flag that should indicate that the
platform's sources will be linked to the installed platform instead of copying.
+- The `createPlatform` method must return a promise, which is either
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+
+The way most platforms work is somewhat tricky. The Api.js could be
anywhere in the platform repo, ex. /templates/cordova/Api.js . When a new
project is created for the platform, the platform copies this file (and
supporting files ) to destination/cordova/Api.js. The project expectations
demand that the Api.js file be av
[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r129104787
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+
+bin/update
+- not entirely sure this code is run, or needs to exist with newish
non-destructive platform updates
+
+## Package Expectations
+
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this
platform and get access to the Api.
+
+## Api (Platform) Expectations
+- The PlatformApi class
+- The PlatformApi class is an abstraction around a particular platform
that exposes all the actions, properties, and methods for this platform so they
are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets
and js files.
+- It exposes a single 'prepare' method to provide a way for
cordova-lib to apply a project's setting/www content to the platform.
+- The PlatformApi class should be implemented by each platform that
wants to use the new API flow. For those platforms, which don't provide their
own PlatformApi, there will be a polyfill in cordova-lib.
+- Platforms that implement their own PlatformApi instance should
implement all prototype methods of this class to be fully compatible with
cordova-lib.
+- The PlatformApi instance should define the following field:
+- platform : This is a String that defines a platform name.
+
+- Api.js exports static functions
+- there is currently a requirement that the file be called Api.js
(todo:change that)
+
+
+- Api.js exports static function `updatePlatform(destination, options,
events);`
+- PlatformApi.updatePlatform = function (cordovaProject, options) {};
+- The `updatePlatform` method is equal to the bin/update script. It
should update an already installed platform. It should accept a CordovaProject
instance, that defines a project structure and configuration, that should be
applied to the new platform, and an options object.
+- cordovaProject: This is a CordovaProject instance that defines a
project structure and configuration, that should be applied to the new
platform. This argument is optional and if not defined, that platform is used
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that
should override the default one from platform.
+- options.link : This is a flag that should indicate that the
platform's sources will be linked to the installed platform instead of copying.
+ - The `updatePlatform` method must return a promise, which is either
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+
+- Api.js exports static function `createPlatform(destination, cfg,
options, events);`
+- PlatformApi.createPlatform = function(cordovaProject, options) {};
+- The `createPlatform method` is equal to the bin/create script. It
should install the platform to a specified directory and create a platform
project. It should accept a CordovaProject instance, that defines a project
structure and configuration, that should be applied to the new platform, and an
options object.
+- cordovaProject : This is a CordovaProject instance that defines a
project structure and configuration, that should be applied to the new
platform. This argument is optional and if not defined, that platform is used
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that
should override the default one from the platform.
+- options.link : This is a flag that should indicate that the
platform's sources will be linked to the installed platform instead of copying.
+- The `createPlatform` method must return a promise, which is either
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+
+The way most platforms work is somewhat tricky. The Api.js could be
anywhere in the platform repo, ex. /templates/cordova/Api.js . When a new
project is created for the platform, the platform copies this file (and
supporting files ) to destination/cordova/Api.js. The project expectations
demand that the Api.js file be av
[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r129092432 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin/create scripts +- bin/create _(typically a node script)_ +- bin/create.bat for windows +- windows .bat file typically just calls bin/create with node + +bin/update +- not entirely sure this code is run, or needs to exist with newish non-destructive platform updates + +## Package Expectations + +- Platforms must have a package.json in their root. +- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"` +- This allows other modules to simply require() the path to this platform and get access to the Api. + +## Api (Platform) Expectations +- The PlatformApi class +- The PlatformApi class is an abstraction around a particular platform that exposes all the actions, properties, and methods for this platform so they are accessible programmatically. +- It can install & uninstall plugins with all source files, web assets and js files. +- It exposes a single 'prepare' method to provide a way for cordova-lib to apply a project's setting/www content to the platform. +- The PlatformApi class should be implemented by each platform that wants to use the new API flow. For those platforms, which don't provide their own PlatformApi, there will be a polyfill in cordova-lib. +- Platforms that implement their own PlatformApi instance should implement all prototype methods of this class to be fully compatible with cordova-lib. +- The PlatformApi instance should define the following field: +- platform : This is a String that defines a platform name. + +- Api.js exports static functions --- End diff -- Hmm so "static" functions came up in all of the notes, discussions, etc that I read through. I assumed it meant --> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/static Should I remove all the instances of "static" functions in this guide? Or maybe replace it with something else? Or define static functions at the top somewhere so readers know? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128880654
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+
+bin/update
+- not entirely sure this code is run, or needs to exist with newish
non-destructive platform updates
+
+## Package Expectations
+
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this
platform and get access to the Api.
+
+## Api (Platform) Expectations
+- The PlatformApi class
+- The PlatformApi class is an abstraction around a particular platform
that exposes all the actions, properties, and methods for this platform so they
are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets
and js files.
+- It exposes a single 'prepare' method to provide a way for
cordova-lib to apply a project's setting/www content to the platform.
+- The PlatformApi class should be implemented by each platform that
wants to use the new API flow. For those platforms, which don't provide their
own PlatformApi, there will be a polyfill in cordova-lib.
+- Platforms that implement their own PlatformApi instance should
implement all prototype methods of this class to be fully compatible with
cordova-lib.
+- The PlatformApi instance should define the following field:
+- platform : This is a String that defines a platform name.
+
+- Api.js exports static functions
+- there is currently a requirement that the file be called Api.js
(todo:change that)
+
+
+- Api.js exports static function `updatePlatform(destination, options,
events);`
+- PlatformApi.updatePlatform = function (cordovaProject, options) {};
+- The `updatePlatform` method is equal to the bin/update script. It
should update an already installed platform. It should accept a CordovaProject
instance, that defines a project structure and configuration, that should be
applied to the new platform, and an options object.
+- cordovaProject: This is a CordovaProject instance that defines a
project structure and configuration, that should be applied to the new
platform. This argument is optional and if not defined, that platform is used
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that
should override the default one from platform.
+- options.link : This is a flag that should indicate that the
platform's sources will be linked to the installed platform instead of copying.
+ - The `updatePlatform` method must return a promise, which is either
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+
+- Api.js exports static function `createPlatform(destination, cfg,
options, events);`
+- PlatformApi.createPlatform = function(cordovaProject, options) {};
+- The `createPlatform method` is equal to the bin/create script. It
should install the platform to a specified directory and create a platform
project. It should accept a CordovaProject instance, that defines a project
structure and configuration, that should be applied to the new platform, and an
options object.
+- cordovaProject : This is a CordovaProject instance that defines a
project structure and configuration, that should be applied to the new
platform. This argument is optional and if not defined, that platform is used
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that
should override the default one from the platform.
--- End diff --
Thank you for explaining that! So would be enough to just write :
- Templates allow developers to create apps based on boilerplate
application code.
- https://cordova.apache.org/docs/en/latest/guide/cli/template.html
(and just exclude the rest of the information since it's already in the
docs?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file
[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128880058
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+
+bin/update
+- not entirely sure this code is run, or needs to exist with newish
non-destructive platform updates
+
+## Package Expectations
+
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this
platform and get access to the Api.
+
+## Api (Platform) Expectations
+- The PlatformApi class
+- The PlatformApi class is an abstraction around a particular platform
that exposes all the actions, properties, and methods for this platform so they
are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets
and js files.
+- It exposes a single 'prepare' method to provide a way for
cordova-lib to apply a project's setting/www content to the platform.
+- The PlatformApi class should be implemented by each platform that
wants to use the new API flow. For those platforms, which don't provide their
own PlatformApi, there will be a polyfill in cordova-lib.
+- Platforms that implement their own PlatformApi instance should
implement all prototype methods of this class to be fully compatible with
cordova-lib.
+- The PlatformApi instance should define the following field:
+- platform : This is a String that defines a platform name.
+
+- Api.js exports static functions
+- there is currently a requirement that the file be called Api.js
(todo:change that)
+
+
+- Api.js exports static function `updatePlatform(destination, options,
events);`
+- PlatformApi.updatePlatform = function (cordovaProject, options) {};
+- The `updatePlatform` method is equal to the bin/update script. It
should update an already installed platform. It should accept a CordovaProject
instance, that defines a project structure and configuration, that should be
applied to the new platform, and an options object.
+- cordovaProject: This is a CordovaProject instance that defines a
project structure and configuration, that should be applied to the new
platform. This argument is optional and if not defined, that platform is used
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that
should override the default one from platform.
+- options.link : This is a flag that should indicate that the
platform's sources will be linked to the installed platform instead of copying.
+ - The `updatePlatform` method must return a promise, which is either
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+
+- Api.js exports static function `createPlatform(destination, cfg,
options, events);`
+- PlatformApi.createPlatform = function(cordovaProject, options) {};
+- The `createPlatform method` is equal to the bin/create script. It
should install the platform to a specified directory and create a platform
project. It should accept a CordovaProject instance, that defines a project
structure and configuration, that should be applied to the new platform, and an
options object.
+- cordovaProject : This is a CordovaProject instance that defines a
project structure and configuration, that should be applied to the new
platform. This argument is optional and if not defined, that platform is used
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that
should override the default one from the platform.
+- options.link : This is a flag that should indicate that the
platform's sources will be linked to the installed platform instead of copying.
+- The `createPlatform` method must return a promise, which is either
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+
+The way most platforms work is somewhat tricky. The Api.js could be
anywhere in the platform repo, ex. /templates/cordova/Api.js . When a new
project is created for the platform, the platform copies this file (and
supporting files ) to destination/cordova/Api.js. The project expectations
demand that the Api.js file be av
[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128879376
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+
+bin/update
+- not entirely sure this code is run, or needs to exist with newish
non-destructive platform updates
+
+## Package Expectations
+
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this
platform and get access to the Api.
+
+## Api (Platform) Expectations
+- The PlatformApi class
+- The PlatformApi class is an abstraction around a particular platform
that exposes all the actions, properties, and methods for this platform so they
are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets
and js files.
+- It exposes a single 'prepare' method to provide a way for
cordova-lib to apply a project's setting/www content to the platform.
+- The PlatformApi class should be implemented by each platform that
wants to use the new API flow. For those platforms, which don't provide their
own PlatformApi, there will be a polyfill in cordova-lib.
+- Platforms that implement their own PlatformApi instance should
implement all prototype methods of this class to be fully compatible with
cordova-lib.
+- The PlatformApi instance should define the following field:
+- platform : This is a String that defines a platform name.
+
+- Api.js exports static functions
+- there is currently a requirement that the file be called Api.js
(todo:change that)
+
+
+- Api.js exports static function `updatePlatform(destination, options,
events);`
+- PlatformApi.updatePlatform = function (cordovaProject, options) {};
+- The `updatePlatform` method is equal to the bin/update script. It
should update an already installed platform. It should accept a CordovaProject
instance, that defines a project structure and configuration, that should be
applied to the new platform, and an options object.
+- cordovaProject: This is a CordovaProject instance that defines a
project structure and configuration, that should be applied to the new
platform. This argument is optional and if not defined, that platform is used
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that
should override the default one from platform.
+- options.link : This is a flag that should indicate that the
platform's sources will be linked to the installed platform instead of copying.
+ - The `updatePlatform` method must return a promise, which is either
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+
+- Api.js exports static function `createPlatform(destination, cfg,
options, events);`
+- PlatformApi.createPlatform = function(cordovaProject, options) {};
+- The `createPlatform method` is equal to the bin/create script. It
should install the platform to a specified directory and create a platform
project. It should accept a CordovaProject instance, that defines a project
structure and configuration, that should be applied to the new platform, and an
options object.
+- cordovaProject : This is a CordovaProject instance that defines a
project structure and configuration, that should be applied to the new
platform. This argument is optional and if not defined, that platform is used
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that
should override the default one from the platform.
--- End diff --
How about something like this:
Templates allow you to use preexisting code to jumpstart your project.
Locate a template you wish to use. Then, create your project using that
template, by specifying the --template flag during the create command,
followed by your template source.
You can createCordova project with a custom template located locally, in
NPM, or GitHub.
```
$ cordova create hello com.example.hello HelloWorld --template
$ cordova create hello com.example.hello HelloWorld --template
$ cordova create hello com.example.hello HelloWorld --temp
[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128878157 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin/create scripts +- bin/create _(typically a node script)_ +- bin/create.bat for windows +- windows .bat file typically just calls bin/create with node + +bin/update +- not entirely sure this code is run, or needs to exist with newish non-destructive platform updates + +## Package Expectations + +- Platforms must have a package.json in their root. +- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"` +- This allows other modules to simply require() the path to this platform and get access to the Api. + +## Api (Platform) Expectations +- The PlatformApi class +- The PlatformApi class is an abstraction around a particular platform that exposes all the actions, properties, and methods for this platform so they are accessible programmatically. +- It can install & uninstall plugins with all source files, web assets and js files. +- It exposes a single 'prepare' method to provide a way for cordova-lib to apply a project's setting/www content to the platform. +- The PlatformApi class should be implemented by each platform that wants to use the new API flow. For those platforms, which don't provide their own PlatformApi, there will be a polyfill in cordova-lib. +- Platforms that implement their own PlatformApi instance should implement all prototype methods of this class to be fully compatible with cordova-lib. +- The PlatformApi instance should define the following field: +- platform : This is a String that defines a platform name. + +- Api.js exports static functions +- there is currently a requirement that the file be called Api.js (todo:change that) + --- End diff -- https://issues.apache.org/jira/browse/CB-13058 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128877652
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+
+bin/update
+- not entirely sure this code is run, or needs to exist with newish
non-destructive platform updates
+
+## Package Expectations
+
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this
platform and get access to the Api.
+
+## Api (Platform) Expectations
+- The PlatformApi class
+- The PlatformApi class is an abstraction around a particular platform
that exposes all the actions, properties, and methods for this platform so they
are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets
and js files.
+- It exposes a single 'prepare' method to provide a way for
cordova-lib to apply a project's setting/www content to the platform.
+- The PlatformApi class should be implemented by each platform that
wants to use the new API flow. For those platforms, which don't provide their
own PlatformApi, there will be a polyfill in cordova-lib.
+- Platforms that implement their own PlatformApi instance should
implement all prototype methods of this class to be fully compatible with
cordova-lib.
+- The PlatformApi instance should define the following field:
+- platform : This is a String that defines a platform name.
+
+- Api.js exports static functions
+- there is currently a requirement that the file be called Api.js
(todo:change that)
+
+
+- Api.js exports static function `updatePlatform(destination, options,
events);`
+- PlatformApi.updatePlatform = function (cordovaProject, options) {};
+- The `updatePlatform` method is equal to the bin/update script. It
should update an already installed platform. It should accept a CordovaProject
instance, that defines a project structure and configuration, that should be
applied to the new platform, and an options object.
+- cordovaProject: This is a CordovaProject instance that defines a
project structure and configuration, that should be applied to the new
platform. This argument is optional and if not defined, that platform is used
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that
should override the default one from platform.
+- options.link : This is a flag that should indicate that the
platform's sources will be linked to the installed platform instead of copying.
+ - The `updatePlatform` method must return a promise, which is either
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+
+- Api.js exports static function `createPlatform(destination, cfg,
options, events);`
+- PlatformApi.createPlatform = function(cordovaProject, options) {};
+- The `createPlatform method` is equal to the bin/create script. It
should install the platform to a specified directory and create a platform
project. It should accept a CordovaProject instance, that defines a project
structure and configuration, that should be applied to the new platform, and an
options object.
+- cordovaProject : This is a CordovaProject instance that defines a
project structure and configuration, that should be applied to the new
platform. This argument is optional and if not defined, that platform is used
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that
should override the default one from the platform.
+- options.link : This is a flag that should indicate that the
platform's sources will be linked to the installed platform instead of copying.
+- The `createPlatform` method must return a promise, which is either
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+
+The way most platforms work is somewhat tricky. The Api.js could be
anywhere in the platform repo, ex. /templates/cordova/Api.js . When a new
project is created for the platform, the platform copies this file (and
supporting files ) to destination/cordova/Api.js. The project expectations
demand that the Api.js file be av
[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128876824 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin/create scripts +- bin/create _(typically a node script)_ +- bin/create.bat for windows +- windows .bat file typically just calls bin/create with node + +bin/update +- not entirely sure this code is run, or needs to exist with newish non-destructive platform updates + +## Package Expectations + +- Platforms must have a package.json in their root. +- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"` +- This allows other modules to simply require() the path to this platform and get access to the Api. + +## Api (Platform) Expectations +- The PlatformApi class +- The PlatformApi class is an abstraction around a particular platform that exposes all the actions, properties, and methods for this platform so they are accessible programmatically. +- It can install & uninstall plugins with all source files, web assets and js files. +- It exposes a single 'prepare' method to provide a way for cordova-lib to apply a project's setting/www content to the platform. +- The PlatformApi class should be implemented by each platform that wants to use the new API flow. For those platforms, which don't provide their own PlatformApi, there will be a polyfill in cordova-lib. +- Platforms that implement their own PlatformApi instance should implement all prototype methods of this class to be fully compatible with cordova-lib. +- The PlatformApi instance should define the following field: +- platform : This is a String that defines a platform name. + +- Api.js exports static functions +- there is currently a requirement that the file be called Api.js (todo:change that) + + +- Api.js exports static function `updatePlatform(destination, options, events);` --- End diff -- Ohh okay! Just to confirm, all of the info about the updatePlatform function should be totally removed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834432 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin/create scripts +- bin/create _(typically a node script)_ +- bin/create.bat for windows +- windows .bat file typically just calls bin/create with node + +bin/update +- not entirely sure this code is run, or needs to exist with newish non-destructive platform updates + --- End diff -- Is there a better way to say this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834249 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin/create scripts +- bin/create _(typically a node script)_ +- bin/create.bat for windows +- windows .bat file typically just calls bin/create with node + +bin/update +- not entirely sure this code is run, or needs to exist with newish non-destructive platform updates + +## Package Expectations + +- Platforms must have a package.json in their root. +- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"` +- This allows other modules to simply require() the path to this platform and get access to the Api. + +## Api (Platform) Expectations +- The PlatformApi class +- The PlatformApi class is an abstraction around a particular platform that exposes all the actions, properties, and methods for this platform so they are accessible programmatically. +- It can install & uninstall plugins with all source files, web assets and js files. +- It exposes a single 'prepare' method to provide a way for cordova-lib to apply a project's setting/www content to the platform. +- The PlatformApi class should be implemented by each platform that wants to use the new API flow. For those platforms, which don't provide their own PlatformApi, there will be a polyfill in cordova-lib. +- Platforms that implement their own PlatformApi instance should implement all prototype methods of this class to be fully compatible with cordova-lib. +- The PlatformApi instance should define the following field: +- platform : This is a String that defines a platform name. + +- Api.js exports static functions +- there is currently a requirement that the file be called Api.js (todo:change that) + --- End diff -- I think this to-do is a note left from someone else as a reminder for something... Can I just take it out? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/582 CB-12361 : added tests for plugin/search.js ### Platforms affected ### What does this PR do? Added tests for plugin/search.js. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-12-plugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/582.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #582 commit 175513b5eaad88059b0e47257025f122da76a0a5 Author: Audrey So <audre...@apache.org> Date: 2017-07-20T20:23:11Z CB-12361 : added tests for plugin/search.js --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/581 CB-12361 : added plugin remove tests ### Platforms affected ### What does this PR do? Added plugin remove tests. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-13-plugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/581.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #581 commit f2326ca2b291aef0736b8924d060fe5bd219b1cd Author: Audrey So <audre...@apache.org> Date: 2017-07-20T23:19:07Z CB-12361 : added plugin remove tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #580: CB-12895 : Replaced jshint with eslint
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/580 CB-12895 : Replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12895-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/580.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #580 commit 4cb49cf58523d0ef8039cba6b2d3d6a7ebc260a9 Author: Audrey So <audre...@apache.org> Date: 2017-07-19T16:51:05Z CB-12895 : set up eslint commit 25c80f56f2697f6f359669eb8e150b208e2cd9f2 Author: Audrey So <audre...@apache.org> Date: 2017-07-19T16:54:49Z CB-12895 : ran eslint --fix on cordova-lib commit 55a3eccf913ac0cee11633718a11748a43e8cb88 Author: Audrey So <audre...@apache.org> Date: 2017-07-20T16:41:06Z CB-12895 : updated integration tests with eslint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #579: CB-12361 : added tests for save.js
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/579 CB-12361 : added tests for save.js ### Platforms affected ### What does this PR do? ### What testing has been done on this change? added tests for save.js ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-11 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/579.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/578 CB-12361 : added unit-tests for getPlatformDetailsFromDir ### Platforms affected ### What does this PR do? added unit-tests for getPlatformDetailsFromDir ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-10 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/578.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #578 commit e8a1cf2c062fd735ffb767dcd1c249de5c35684d Author: Audrey So <audre...@apache.org> Date: 2017-07-18T17:35:28Z CB-12361 : added unit-tests for getPlatformDetailsFromDir --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/577 CB-12361 : added tests for platform/list.js ### Platforms affected ### What does this PR do? Added tests for platform/list.js ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-8 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/577.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #577 commit 558554aea0654a4132feb057a73e3faa5a5bac1a Author: Audrey So <audre...@apache.org> Date: 2017-07-17T23:06:37Z CB-12361 : added tests for list platform --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #576: CB-12361 : added unit tests for remove platfo...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/576 CB-12361 : added unit tests for remove platform ### Platforms affected ### What does this PR do? Added unit tests for remove platform ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-7 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/576.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #576 commit 61ddb3d78182c51937539bcb8728fe97f9a9259f Author: Audrey So <audre...@apache.org> Date: 2017-07-17T19:01:20Z CB-12361 : added tests for remove platform --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-osx pull request #38: CB-12895 : replaced jshint with eslint
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-osx/pull/38 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-osx CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-osx/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 commit 031e2c2c99af24dd3d5de3c69a369814da6a6716 Author: Audrey So <audre...@apache.org> Date: 2017-06-01T18:41:28Z CB-12762 : point package.json repo items to github mirrors instead of apache repos site This closes #37 commit e6ff572ccc752817f989a5e29840da134c320cba Author: Audrey So <audre...@apache.org> Date: 2017-07-14T18:14:04Z CB-12985 : updated to use eslint format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #281: CB-12895 : replaced jshint with esl...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/281 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-camera CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/281.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #281 commit e2a27e6679585b0e4931b68dcf0b389014d877f2 Author: Audrey So <audre...@apache.org> Date: 2017-06-09T21:51:30Z CB-12985 : setup eslint and removed jshint commit f6a2fec1844b00ab6f1caf3e066c13817c9b4e70 Author: Audrey So <audre...@apache.org> Date: 2017-07-14T21:19:05Z CB-12895 : updated src files to use eslint format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugman pull request #90: CB-12895 : setup eslint and removed jshint
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugman/pull/90 CB-12895 : setup eslint and removed jshint ### Platforms affected ### What does this PR do? Setup eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugman CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugman/pull/90.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #90 commit 20c2f03ba55663dd3aebecb8558b8f2c36e1651f Author: Audrey So <audre...@apache.org> Date: 2017-06-09T21:01:44Z CB-12895 : setup eslint and remove jshint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request #37: CB-12895 : replaced jshint with eslint
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-browser/pull/37 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-browser CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-browser/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 commit a4bf54bf76ec53a04885d221484339b4d241a041 Author: Audrey So <audre...@apache.org> Date: 2017-06-09T18:32:38Z CB-12895 : set up eslint and remove jshint commit 36100a95b6228fd134a44052e6f650c739d1857e Author: Audrey So <audre...@apache.org> Date: 2017-07-13T19:19:25Z CB-12895 : updated based on eslint indenting rules --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #327: CB-12895: replaced jshint with eslint
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-ios/pull/327 CB-12895: replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-ios CB-12895-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/327.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #327 commit f9b046e5fae2f83c7aa9bf20d80a1fcfd09d05f9 Author: Audrey So <audre...@apache.org> Date: 2017-06-15T17:56:59Z CB-12895 : removed jshint and added eslint commit b7b92263af52efd2bad27d5bdba63ee24244e76a Author: Audrey So <audre...@apache.org> Date: 2017-06-15T18:02:03Z CB-12895 : formatted using eslint rules commit d2fae43e99f2f4da52d3aa13aee309c805964eea Author: Audrey So <audre...@apache.org> Date: 2017-07-12T21:47:46Z CB-12895 : updated indenting with eslint rules --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/574 CB-12838 : prevented sorting and alphabetizing platforms and plugins i⦠â¦n pkgJson and config ### Platforms affected ### What does this PR do? Prevents modifying/alphabetizing platforms and plugins in config ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12838 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/574.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #574 commit 083deef9ce70afe8455a36f49ddccf0b093558f8 Author: Audrey So <audre...@apache.org> Date: 2017-07-12T00:21:41Z CB-12838 : prevented sorting and aphabetizing platforms and plugins in pkgjson and config --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r127110528
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require('path');
+var fs = require('fs');
+var Q = require('q');
+var shell = require('shelljs');
+var events = require('cordova-common').events;
+var rewire = require('rewire');
+var platform_addHelper = rewire('../../../src/cordova/platform/addHelper');
+var platform_module = require('../../../src/cordova/platform');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var cordova_util = require('../../../src/cordova/util');
+var cordova_config = require('../../../src/cordova/config');
+var plugman = require('../../../src/plugman/plugman');
+var fetch_metadata = require('../../../src/plugman/util/metadata');
+var lazy_load = require('../../../src/cordova/lazy_load');
+var prepare = require('../../../src/cordova/prepare');
+var gitclone = require('../../../src/gitclone');
+var fail;
+
describe('cordova/platform/addHelper', function () {
+var projectRoot = '/some/path';
+// These _mock and _revert_mock objects use rewire as the modules
these mocks replace
+// during testing all return functions, which we cannot spy on using
jasmine.
+// Thus, we replace these modules inside the scope of addHelper.js
using rewire, and shim
+// in these _mock test dummies. The test dummies themselves are
constructed using
+// jasmine.createSpy inside the first beforeEach.
+var cfg_parser_mock = function () {};
+var cfg_parser_revert_mock;
+var hooks_mock;
+var platform_api_mock;
+var fetch_mock;
+var fetch_revert_mock;
+var prepare_mock;
+var prepare_revert_mock;
+var fake_platform = {
+'platform': 'atari'
+};
+var package_json_mock;
+package_json_mock = jasmine.createSpyObj('package json mock',
['cordova', 'dependencies']);
+package_json_mock.dependencies = {};
+package_json_mock.cordova = {};
+
+beforeEach(function () {
+hooks_mock = jasmine.createSpyObj('hooksRunner mock', ['fire']);
+hooks_mock.fire.and.returnValue(Q());
+cfg_parser_mock.prototype = jasmine.createSpyObj('config parser
mock', ['write', 'removeEngine', 'addEngine', 'getHookScripts']);
+cfg_parser_revert_mock =
platform_addHelper.__set__('ConfigParser', cfg_parser_mock);
+fetch_mock = jasmine.createSpy('fetch mock').and.returnValue(Q());
+fetch_revert_mock = platform_addHelper.__set__('fetch',
fetch_mock);
+prepare_mock = jasmine.createSpy('prepare
mock').and.returnValue(Q());
+prepare_mock.preparePlatforms =
jasmine.createSpy('preparePlatforms mock').and.returnValue(Q());
+prepare_revert_mock = platform_addHelper.__set__('prepare',
prepare_mock);
+spyOn(shell, 'mkdir');
+spyOn(fs, 'existsSync').and.returnValue(false);
+spyOn(fs, 'writeFileSync');
+spyOn(cordova_util,
'projectConfig').and.returnValue(path.join(projectRoot, 'config.xml'));
+spyOn(cordova_util, 'isDirectory').and.returnValue(false);
+spyOn(cordova_util, 'fixRelativePath').and.callFake(function
(input) { return input; });
+spyOn(cordova_util, 'isUrl').and.returnValue(false);
+spyOn(cordova_util, 'hostSupports').and.returnValue(true);
+spyOn(cordova_util, 'removePlatformPluginsJson');
+spyOn(cordova_config, 'read').and.returnValue({});
+spyOn(events, 'emit');
+// Fake platform details we will use for our mocks, returned by
either
+// getPlatfromDetailsFromDir (in the local-directory case), or
+// downloadPlatform (in every other case)
+spyOn(platform_module,
'getPlatformDetailsFromDir').and.returnValue(Q(fake_platform));
+spyOn(platform_addHelper,
'downloadPlatform').and.returnValue(Q(fake_platform));
+spyOn(platform_addHelper,
'getVersionFromConfigFile').and.returnValue(false);
+spyOn(platform_addHelper,
'installPluginsForNewPlatform').and.returnValue(Q());
+platform_api_mock = jasmine.createSpyObj('platform api mock',
['createPlatform', 'updatePlatform']);
+platform_api_mock.createPlatform.and.returnValue(Q());
+platform_api_mock.updatePlatform.and.returnValue(Q());
+spyOn(cordova_util,
'getPlatformApiFunction').and.returnValue(platform_api_mock);
+spyOn(platform_metadata, 'save');
+spyOn(cordova_util, 'requireNoCache').and.returnValue({});
+});
+afterEach(function () {
+cfg_parser_revert_mock
[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r127066391
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require('path');
+var fs = require('fs');
+var Q = require('q');
+var shell = require('shelljs');
+var events = require('cordova-common').events;
+var rewire = require('rewire');
+var platform_addHelper = rewire('../../../src/cordova/platform/addHelper');
+var platform_module = require('../../../src/cordova/platform');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var cordova_util = require('../../../src/cordova/util');
+var cordova_config = require('../../../src/cordova/config');
+var plugman = require('../../../src/plugman/plugman');
+var fetch_metadata = require('../../../src/plugman/util/metadata');
+var lazy_load = require('../../../src/cordova/lazy_load');
+var prepare = require('../../../src/cordova/prepare');
+var gitclone = require('../../../src/gitclone');
+var fail;
+
describe('cordova/platform/addHelper', function () {
+var projectRoot = '/some/path';
+// These _mock and _revert_mock objects use rewire as the modules
these mocks replace
+// during testing all return functions, which we cannot spy on using
jasmine.
+// Thus, we replace these modules inside the scope of addHelper.js
using rewire, and shim
+// in these _mock test dummies. The test dummies themselves are
constructed using
+// jasmine.createSpy inside the first beforeEach.
+var cfg_parser_mock = function () {};
+var cfg_parser_revert_mock;
+var hooks_mock;
+var platform_api_mock;
+var fetch_mock;
+var fetch_revert_mock;
+var prepare_mock;
+var prepare_revert_mock;
+var fake_platform = {
+'platform': 'atari'
+};
+var package_json_mock;
+package_json_mock = jasmine.createSpyObj('package json mock',
['cordova', 'dependencies']);
+package_json_mock.dependencies = {};
+package_json_mock.cordova = {};
+
+beforeEach(function () {
+hooks_mock = jasmine.createSpyObj('hooksRunner mock', ['fire']);
+hooks_mock.fire.and.returnValue(Q());
+cfg_parser_mock.prototype = jasmine.createSpyObj('config parser
mock', ['write', 'removeEngine', 'addEngine', 'getHookScripts']);
+cfg_parser_revert_mock =
platform_addHelper.__set__('ConfigParser', cfg_parser_mock);
+fetch_mock = jasmine.createSpy('fetch mock').and.returnValue(Q());
+fetch_revert_mock = platform_addHelper.__set__('fetch',
fetch_mock);
+prepare_mock = jasmine.createSpy('prepare
mock').and.returnValue(Q());
+prepare_mock.preparePlatforms =
jasmine.createSpy('preparePlatforms mock').and.returnValue(Q());
+prepare_revert_mock = platform_addHelper.__set__('prepare',
prepare_mock);
+spyOn(shell, 'mkdir');
+spyOn(fs, 'existsSync').and.returnValue(false);
+spyOn(fs, 'writeFileSync');
+spyOn(cordova_util,
'projectConfig').and.returnValue(path.join(projectRoot, 'config.xml'));
+spyOn(cordova_util, 'isDirectory').and.returnValue(false);
+spyOn(cordova_util, 'fixRelativePath').and.callFake(function
(input) { return input; });
+spyOn(cordova_util, 'isUrl').and.returnValue(false);
+spyOn(cordova_util, 'hostSupports').and.returnValue(true);
+spyOn(cordova_util, 'removePlatformPluginsJson');
+spyOn(cordova_config, 'read').and.returnValue({});
+spyOn(events, 'emit');
+// Fake platform details we will use for our mocks, returned by
either
+// getPlatfromDetailsFromDir (in the local-directory case), or
+// downloadPlatform (in every other case)
+spyOn(platform_module,
'getPlatformDetailsFromDir').and.returnValue(Q(fake_platform));
+spyOn(platform_addHelper,
'downloadPlatform').and.returnValue(Q(fake_platform));
+spyOn(platform_addHelper,
'getVersionFromConfigFile').and.returnValue(false);
+spyOn(platform_addHelper,
'installPluginsForNewPlatform').and.returnValue(Q());
+platform_api_mock = jasmine.createSpyObj('platform api mock',
['createPlatform', 'updatePlatform']);
+platform_api_mock.createPlatform.and.returnValue(Q());
+platform_api_mock.updatePlatform.and.returnValue(Q());
+spyOn(cordova_util,
'getPlatformApiFunction').and.returnValue(platform_api_mock);
+spyOn(platform_metadata, 'save');
+spyOn(cordova_util, 'requireNoCache').and.returnValue({});
+});
+afterEach(function () {
+cfg_parser_revert_mock
[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r127008421
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require('path');
+var fs = require('fs');
+var Q = require('q');
+var shell = require('shelljs');
+var events = require('cordova-common').events;
+var rewire = require('rewire');
+var platform_addHelper = rewire('../../../src/cordova/platform/addHelper');
+var platform_module = require('../../../src/cordova/platform');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var cordova_util = require('../../../src/cordova/util');
+var cordova_config = require('../../../src/cordova/config');
+var plugman = require('../../../src/plugman/plugman');
+var fetch_metadata = require('../../../src/plugman/util/metadata');
+var lazy_load = require('../../../src/cordova/lazy_load');
+var prepare = require('../../../src/cordova/prepare');
+var gitclone = require('../../../src/gitclone');
+var fail;
+
describe('cordova/platform/addHelper', function () {
+var projectRoot = '/some/path';
+// These _mock and _revert_mock objects use rewire as the modules
these mocks replace
+// during testing all return functions, which we cannot spy on using
jasmine.
+// Thus, we replace these modules inside the scope of addHelper.js
using rewire, and shim
+// in these _mock test dummies. The test dummies themselves are
constructed using
+// jasmine.createSpy inside the first beforeEach.
+var cfg_parser_mock = function () {};
+var cfg_parser_revert_mock;
+var hooks_mock;
+var platform_api_mock;
+var fetch_mock;
+var fetch_revert_mock;
+var prepare_mock;
+var prepare_revert_mock;
+var fake_platform = {
+'platform': 'atari'
+};
+var package_json_mock;
+package_json_mock = jasmine.createSpyObj('package json mock',
['cordova', 'dependencies']);
+package_json_mock.dependencies = {};
+package_json_mock.cordova = {};
+
+beforeEach(function () {
+hooks_mock = jasmine.createSpyObj('hooksRunner mock', ['fire']);
+hooks_mock.fire.and.returnValue(Q());
+cfg_parser_mock.prototype = jasmine.createSpyObj('config parser
mock', ['write', 'removeEngine', 'addEngine', 'getHookScripts']);
+cfg_parser_revert_mock =
platform_addHelper.__set__('ConfigParser', cfg_parser_mock);
+fetch_mock = jasmine.createSpy('fetch mock').and.returnValue(Q());
+fetch_revert_mock = platform_addHelper.__set__('fetch',
fetch_mock);
+prepare_mock = jasmine.createSpy('prepare
mock').and.returnValue(Q());
+prepare_mock.preparePlatforms =
jasmine.createSpy('preparePlatforms mock').and.returnValue(Q());
+prepare_revert_mock = platform_addHelper.__set__('prepare',
prepare_mock);
+spyOn(shell, 'mkdir');
+spyOn(fs, 'existsSync').and.returnValue(false);
+spyOn(fs, 'writeFileSync');
+spyOn(cordova_util,
'projectConfig').and.returnValue(path.join(projectRoot, 'config.xml'));
+spyOn(cordova_util, 'isDirectory').and.returnValue(false);
+spyOn(cordova_util, 'fixRelativePath').and.callFake(function
(input) { return input; });
+spyOn(cordova_util, 'isUrl').and.returnValue(false);
+spyOn(cordova_util, 'hostSupports').and.returnValue(true);
+spyOn(cordova_util, 'removePlatformPluginsJson');
+spyOn(cordova_config, 'read').and.returnValue({});
+spyOn(events, 'emit');
+// Fake platform details we will use for our mocks, returned by
either
+// getPlatfromDetailsFromDir (in the local-directory case), or
+// downloadPlatform (in every other case)
+spyOn(platform_module,
'getPlatformDetailsFromDir').and.returnValue(Q(fake_platform));
+spyOn(platform_addHelper,
'downloadPlatform').and.returnValue(Q(fake_platform));
+spyOn(platform_addHelper,
'getVersionFromConfigFile').and.returnValue(false);
+spyOn(platform_addHelper,
'installPluginsForNewPlatform').and.returnValue(Q());
+platform_api_mock = jasmine.createSpyObj('platform api mock',
['createPlatform', 'updatePlatform']);
+platform_api_mock.createPlatform.and.returnValue(Q());
+platform_api_mock.updatePlatform.and.returnValue(Q());
+spyOn(cordova_util,
'getPlatformApiFunction').and.returnValue(platform_api_mock);
+spyOn(platform_metadata, 'save');
+spyOn(cordova_util, 'requireNoCache').and.returnValue({});
+});
+afterEach(function () {
+cfg_parser_revert_mock
[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r127007878
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require('path');
+var fs = require('fs');
+var Q = require('q');
+var shell = require('shelljs');
+var events = require('cordova-common').events;
+var rewire = require('rewire');
+var platform_addHelper = rewire('../../../src/cordova/platform/addHelper');
+var platform_module = require('../../../src/cordova/platform');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var cordova_util = require('../../../src/cordova/util');
+var cordova_config = require('../../../src/cordova/config');
+var plugman = require('../../../src/plugman/plugman');
+var fetch_metadata = require('../../../src/plugman/util/metadata');
+var lazy_load = require('../../../src/cordova/lazy_load');
+var prepare = require('../../../src/cordova/prepare');
+var gitclone = require('../../../src/gitclone');
+var fail;
+
describe('cordova/platform/addHelper', function () {
+var projectRoot = '/some/path';
+// These _mock and _revert_mock objects use rewire as the modules
these mocks replace
+// during testing all return functions, which we cannot spy on using
jasmine.
+// Thus, we replace these modules inside the scope of addHelper.js
using rewire, and shim
+// in these _mock test dummies. The test dummies themselves are
constructed using
+// jasmine.createSpy inside the first beforeEach.
+var cfg_parser_mock = function () {};
+var cfg_parser_revert_mock;
+var hooks_mock;
+var platform_api_mock;
+var fetch_mock;
+var fetch_revert_mock;
+var prepare_mock;
+var prepare_revert_mock;
+var fake_platform = {
+'platform': 'atari'
+};
+var package_json_mock;
+package_json_mock = jasmine.createSpyObj('package json mock',
['cordova', 'dependencies']);
+package_json_mock.dependencies = {};
+package_json_mock.cordova = {};
+
+beforeEach(function () {
+hooks_mock = jasmine.createSpyObj('hooksRunner mock', ['fire']);
+hooks_mock.fire.and.returnValue(Q());
+cfg_parser_mock.prototype = jasmine.createSpyObj('config parser
mock', ['write', 'removeEngine', 'addEngine', 'getHookScripts']);
+cfg_parser_revert_mock =
platform_addHelper.__set__('ConfigParser', cfg_parser_mock);
+fetch_mock = jasmine.createSpy('fetch mock').and.returnValue(Q());
+fetch_revert_mock = platform_addHelper.__set__('fetch',
fetch_mock);
+prepare_mock = jasmine.createSpy('prepare
mock').and.returnValue(Q());
+prepare_mock.preparePlatforms =
jasmine.createSpy('preparePlatforms mock').and.returnValue(Q());
+prepare_revert_mock = platform_addHelper.__set__('prepare',
prepare_mock);
+spyOn(shell, 'mkdir');
+spyOn(fs, 'existsSync').and.returnValue(false);
+spyOn(fs, 'writeFileSync');
+spyOn(cordova_util,
'projectConfig').and.returnValue(path.join(projectRoot, 'config.xml'));
+spyOn(cordova_util, 'isDirectory').and.returnValue(false);
+spyOn(cordova_util, 'fixRelativePath').and.callFake(function
(input) { return input; });
+spyOn(cordova_util, 'isUrl').and.returnValue(false);
+spyOn(cordova_util, 'hostSupports').and.returnValue(true);
+spyOn(cordova_util, 'removePlatformPluginsJson');
+spyOn(cordova_config, 'read').and.returnValue({});
+spyOn(events, 'emit');
+// Fake platform details we will use for our mocks, returned by
either
+// getPlatfromDetailsFromDir (in the local-directory case), or
+// downloadPlatform (in every other case)
+spyOn(platform_module,
'getPlatformDetailsFromDir').and.returnValue(Q(fake_platform));
+spyOn(platform_addHelper,
'downloadPlatform').and.returnValue(Q(fake_platform));
+spyOn(platform_addHelper,
'getVersionFromConfigFile').and.returnValue(false);
+spyOn(platform_addHelper,
'installPluginsForNewPlatform').and.returnValue(Q());
+platform_api_mock = jasmine.createSpyObj('platform api mock',
['createPlatform', 'updatePlatform']);
+platform_api_mock.createPlatform.and.returnValue(Q());
+platform_api_mock.updatePlatform.and.returnValue(Q());
+spyOn(cordova_util,
'getPlatformApiFunction').and.returnValue(platform_api_mock);
+spyOn(platform_metadata, 'save');
+spyOn(cordova_util, 'requireNoCache').and.returnValue({});
+});
+afterEach(function () {
+cfg_parser_revert_mock
[GitHub] cordova-windows pull request #236: CB -12895 : updated files to use eslint i...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-windows/pull/236 CB -12895 : updated files to use eslint instead jshint ### Platforms affected ### What does this PR do? Updated files to use eslint instead jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-windows CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/236.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #236 commit 2d4278a06506e1725157c33b9f80ce10f5e4ae38 Author: Audrey So <audre...@apache.org> Date: 2017-06-09T20:46:56Z CB-12895 : setup eslint and removed jshint commit 459d1b00550f3b85be3eaf5e758d18a72cc3f3de Author: Audrey So <audre...@apache.org> Date: 2017-07-11T16:51:57Z CB-12895 : updated with eslint rules commit 2ea7bc2d59425a6a845265f334e215de94d4efbd Author: Audrey So <audre...@apache.org> Date: 2017-07-11T18:32:22Z CB-12895 : indenting using eslint rules --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #570: CB-12361 : updated cordova-lib addHelper.spec...
Github user audreyso closed the pull request at: https://github.com/apache/cordova-lib/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/573 CB-12361 : updated addHelper tests ### Platforms affected ### What does this PR do? updated addHelper tests ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-6 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/573.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #573 commit acda3f4be22c4dbb69bde54adf42ccc185080ba2 Author: Audrey So <audre...@apache.org> Date: 2017-06-29T16:46:57Z CB-12361 : updated addHelper tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #570: CB-12361 : updated cordova-lib addHelper.spec...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/570 CB-12361 : updated cordova-lib addHelper.spec tests Not ready to be merged/reviewed yet! Thank you! ### Platforms affected ### What does this PR do? Updated cordova-lib addHelper.spec tests. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-5 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/570.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #570 commit 494f5e9749fcdb82b4c7052c413e2bc4af494d7a Author: filmaj <maj@gmail.com> Date: 2017-06-16T23:07:13Z Filling out more addHelper specs. commit 34e4a00aec170741fea2a744eb089fa36100867b Author: filmaj <maj@gmail.com> Date: 2017-06-16T23:31:40Z finished laying out pending specs for main addhelper function. commit fa4d7c59c2069540080450362f9cd6b7c7e6e484 Author: filmaj <maj@gmail.com> Date: 2017-06-17T00:00:58Z further pending tests and some todos. commit ba6702c88f09497b6ee5eb0e2564fdb5a3478153 Author: filmaj <maj@gmail.com> Date: 2017-06-19T13:56:00Z already have tests for checking targets passed in to platform-add lined up elsewhere. commit ab8cd73e1810eb241caa6ac595f25c7bb42101c2 Author: filmaj <maj@gmail.com> Date: 2017-06-19T14:33:05Z filled out a few tests, more comments to describe testing approach. commit 3dbc8073ab020b98059d0920793ac979dc1d8b60 Author: Audrey So <audre...@apache.org> Date: 2017-06-26T22:37:00Z CB-12361 : updated addHelper tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli issue #281: CB-12895 : updated to use eslint instead of jshint
Github user audreyso commented on the issue: https://github.com/apache/cordova-cli/pull/281 Refactored! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user audreyso commented on the issue: https://github.com/apache/cordova-android/pull/386 I think I have permission, but haven't ever done it before! @filmaj --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/561 @filmaj I rebased this for now. If we change the tests to unit tests, should it be in this PR or in a separate one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user audreyso commented on the issue: https://github.com/apache/cordova-android/pull/386 I rebased this morning! @filmaj @infil00p If anyone has time to merge it in, that would be great :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user audreyso commented on the issue: https://github.com/apache/cordova-android/pull/386 Ohh thank you for that clarification @filmaj . So I did the following: 1. Left the project root level eslint file to keep--> root: true 2. Removed eslint config files from spec/e2e & spec/unit and just placed it in spec/.eslintrc.yml 3. Took out root:true from spec/.eslintrc.yml and just included ONE rule env: jasmine: true --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user audreyso commented on the issue: https://github.com/apache/cordova-android/pull/386 Thanks! @filmaj That makes sense and seems easier than having to add in /*eslint-env: jasmine*/ in every file. I made some changes and added .eslint configs where they are needed. Let me know if you have any other suggestions or feedback! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #386: CB-12895 : added eslint and removed jshin...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-android/pull/386 CB-12895 : added eslint and removed jshint / reformatted with eslint ### Platforms affected ### What does this PR do? Added eslint and removed jshint / reformatted with eslint. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-android CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/386.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #386 commit 8e4e071e5d6f3427feaf6e216db9757c42c0f0ea Author: Audrey So <audre...@apache.org> Date: 2017-06-09T18:18:57Z CB-12895 : added eslint and removed jshint commit 4e19a0ce08a2a117990ba20d7ef1fbb0f6ebcd5b Author: Audrey So <audre...@apache.org> Date: 2017-06-13T18:42:20Z CB-12895 : fixed eslint errors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request #281: CB-12895 : updated to use eslint instead of j...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-cli/pull/281 CB-12895 : updated to use eslint instead of jshint ### Platforms affected ### What does this PR do? Updated to use eslint instead of jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-cli CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/281.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #281 commit 2b2a0db48b7a3641e738c83cd7b8b4d7531830c5 Author: Audrey So <audre...@apache.org> Date: 2017-06-07T22:31:54Z CB-12895 : updated pkgJson with lint and removed jshint commit 23ff78736d72174d20e5d0b33e414ad2415ffae1 Author: Audrey So <audre...@apache.org> Date: 2017-06-13T17:31:54Z CB-12895 : updated to use eslint format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #561: Cb 12870 - Check that all use cases are caugh...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/561 Cb 12870 - Check that all use cases are caught in Api.js Not ready for review yet, still updating tests. Thanks! ### Platforms affected ### What does this PR do? Check that all use cases are caught in Api.js ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12870 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/561.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #561 commit 5ccbba28764faa675b65d26429e9685c76b98825 Author: Audrey So <audre...@apache.org> Date: 2017-05-31T17:41:22Z CB-12870 : catch all use cases for getPlatformApiFunc and update tests accordingly commit f051199236e85a546236891303147a11d0b123ee Author: Audrey So <audre...@apache.org> Date: 2017-06-03T00:24:32Z CB-12870 : checks if platformapi.createplatform func exists and throws error if api is not compatible commit 75c8d8b9bb4c3caecdd518de77a01ba95397aa0a Author: Audrey So <audre...@apache.org> Date: 2017-06-05T18:47:11Z CB-12870 : added util tests to check getPlatformApiFunction commit c8c8e626e698d8c742c40b2f7c8932aa52f880a1 Author: Audrey So <audre...@apache.org> Date: 2017-06-06T00:23:35Z CB-12870 : removed checkPlatformApiCompatible function and update tests in platforms.spec" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #36: CB-12762 : point package.j...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36 CB-12762 : point package.json repo items to github mirrors instead of⦠⦠apache repos site ### Platforms affected ### What does this PR do? Point package.json repo items to github mirrors instead of apache repos site. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-wkwebview-engine CB-12762 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit 4b803231f9c274eac14f4906e8bbde5ff938781d Author: Audrey So <audre...@apache.org> Date: 2017-06-02T16:59:05Z CB-12762 : point package.json repo items to github mirrors instead of apache repos site --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
