[GitHub] cordova-plugin-wkwebview-engine issue #42: CB-13205: Dynamic swipe back enab...
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42 ping @shazron --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #42: CB-13205: Dynamic swipe back enab...
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42 Alright @shazron made those changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 @shazron please check out my new PR https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #38: Dynamic Swipe Preference
Github user ccorcos closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #42: Dynamic swipe back enabled...
GitHub user ccorcos opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42 Dynamic swipe back enabled preference ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ccorcos/cordova-plugin-wkwebview-engine swipe Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #42 commit e67392fd53e6f0efb9d000be109b61ec6a889a09 Author: Chet Corcos <ccor...@gmail.com> Date: 2017-08-22T18:32:27Z Dynamic swipe back enabled preference --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 @shazron does this PR have any chance of making it in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 lol. would you mind making a ticket for this? I can't seem to get it to load! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 @shazron is JIRA broken? My browser says failed to connect: iled to connect to issues.apache.org port 443: Connection refused --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 Hmm. Is JIRA down? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #37: CB-10376, CB-12037: (ios) ...
Github user ccorcos closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 @cjpearson really cool. I'll do that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #38: Dynamic Swipe Preference
GitHub user ccorcos opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 Dynamic Swipe Preference This PR lets you dynamically change whether or not you can swipe navigation using `window.WkWebView.allowsBackForwardNavigationGestures(boolean)` ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ccorcos/cordova-plugin-wkwebview-engine dynamic-swipe-pref Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 commit 1109a1ace113579e76ad2384f966d8442ce14b4f Author: Chet Corcos <ccor...@gmail.com> Date: 2017-06-15T01:04:14Z Dynamically set allowsBackForwardNavigationGestures commit 0b6b29f9dee9cf326313639bf197c09c19c9dd18 Author: Chet Corcos <ccor...@gmail.com> Date: 2017-06-15T01:35:16Z Move code into proper @implementation commit cf1cb7b82516d4103f9913868183e829eab3b912 Author: Chet Corcos <ccor...@gmail.com> Date: 2017-06-15T01:46:51Z Separate window.WkWebView js module into another file commit 410b6cf4adc544e9d62c59e1fe5875d57bc3b2cc Author: Chet Corcos <ccor...@gmail.com> Date: 2017-06-15T01:50:55Z Readme --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 @SeanHub here's what I've learned so far: - you can call `.focus()` so long as its in the same tick as a user action. For example, you can call `.focus()` on an element synchronously in click event handler. - you can call `event.preventDefault()` on the mousedown event to prevent the input from being blurred Or if you want, you can use my fork and then`.focus()` just works! ```xml https://github.com/ccorcos/cordova-plugin-wkwebview-engine#e994874583d7e5f4ae1713643dbd8e01c60a0a03; /> ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #25: CB-12317: Allow to configure navi...
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/25 @shazron @fkoester is there a way to dynamically change this preference? I see theres an `updateWithInfo` function but I don't know how to call it. https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/src/ios/CDVWKWebViewEngine.m#L281 I don't want to be able to swipe when, for example, the sidebar is open. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 I see. But I figured that why we test on the next iOS before it comes out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 @shazron @stevengill any thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #37: CB-10376: (ios) Fix bug wh...
GitHub user ccorcos opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 CB-10376: (ios) Fix bug where WKWebView doesnt respect the KeyboardDisplayRequiresUserAction setting ### Platforms affected - iOS ### What does this PR do? This PR does some magic to allow `.focus()` to bring up the keyboard in WKWebView. I read about this approach in a few places and saw [this commit](https://github.com/Telerik-Verified-Plugins/WKWebView/commit/04e8296adeb61f289f9c698045c19b62d080c7e3) in another plugin. From what I understand, its basically accessing a private method in WKWebView. ### What testing has been done on this change? Using it on my iPhone 7 and in the Simulator and it definitely works :) I'm not a native developer so I could use some guidance getting this PR to the point where its mergeable. But its definitely useful and absolutely necessary for [the app I'm building](www.notion.so). ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ccorcos/cordova-plugin-wkwebview-engine master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 commit e994874583d7e5f4ae1713643dbd8e01c60a0a03 Author: Chet Corcos <ccor...@gmail.com> Date: 2017-06-09T22:42:25Z Patch KeyboardDisplayRequiresUserAction --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
