[GitHub] cordova-plugin-file pull request: CB-10317 Encoded # in uri parse
Github user dhams commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/172#issuecomment-216162738 @adamscybot Right , iOS version is able to parse this special char. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-10317 Encoded # in uri parse
GitHub user dhams opened a pull request: https://github.com/apache/cordova-plugin-file/pull/172 CB-10317 Encoded # in uri parse If we use # in folder name or file name Uri is not able parse that path as of now. As Uri class not parse # symbol (Uri class reserved that # as fragment identification so ) I have used encoded value of this symbol directly in `encodeHashUri `method. Method `parse` used in many places to parse the Uri path , I have encoded # in that method too in order to avoid code break. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accenture/cordova-plugin-file CB-10317 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/172.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #172 commit 585b9523a475ca5728023b16b6adef62aa569491 Author: Sharma <dharmendra.g.sha...@accenture.com> Date: 2016-03-21T13:28:05Z Encoded # in uri parse --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Cb 10637
Github user dhams commented on the pull request: https://github.com/apache/cordova-docs/pull/504#issuecomment-196665529 closing this PR as that changes has already been covered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Cb 10637
Github user dhams closed the pull request at: https://github.com/apache/cordova-docs/pull/504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...
Github user dhams commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/85#discussion_r53453538
--- Diff: src/android/SplashScreen.java ---
@@ -341,7 +341,11 @@ public void onCancel(DialogInterface dialog) {
}
});
-spinnerDialog.setCancelable(false);
+if(preferences.getBoolean("spinnerCancelable",true)){
--- End diff --
That may give a more privilege to developer I guess.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...
GitHub user dhams opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/85 CB-10643cordova plugin splashscreen : Added new preference to choose whether dialog is cancelable or not. Added option to choose whether developer wants cancelable dialog or not while loading splashscreen. I added preference ` ` in config.xml where user can set appropriate value. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accenture/cordova-plugin-splashscreen CB-10643cordova-plugin-splashscreen Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/85.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #85 commit d82b76cba98915612be960d9f66891584dfb215b Author: bbadrinath <bbadrin...@users.noreply.github.com> Date: 2016-02-10T06:56:29Z Merge pull request #1 from apache/master Rebasing the forked branch from 3.1.1 to current master branch 3.2.0 commit cef829bac947f734f3d50e727d91eb41827fdc57 Author: Sharma <dharmendra.g.sha...@accenture.com> Date: 2016-02-19T11:32:19Z Added new preference to choose whether dialog is cancelable or not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Give option for Splashsc...
Github user dhams commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/83#issuecomment-185711822 trying to correct travis-ci issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Give option for Splashsc...
Github user dhams closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Give option for Splashsc...
GitHub user dhams opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/83 Give option for Splashscreen spinner cancelable event Added option to choose user whether they want cancelable dialog or not while loading splashscreen. I added preference ` `where user can choose this. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accenture/cordova-plugin-splashscreen CB-10643splashscreen Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/83.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #83 commit d82b76cba98915612be960d9f66891584dfb215b Author: bbadrinath <bbadrin...@users.noreply.github.com> Date: 2016-02-10T06:56:29Z Merge pull request #1 from apache/master Rebasing the forked branch from 3.1.1 to current master branch 3.2.0 commit 803d52fc4a7349be131650c615723477e6e534a4 Author: Sharma <dharmendra.g.sha...@accenture.com> Date: 2016-02-10T08:41:24Z Fixed doccument issue commit ab1b3815d7991bdb76b73d35c3bbfb0e1cc82bb8 Author: Sharma <dharmendra.g.sha...@accenture.com> Date: 2016-02-18T12:12:20Z Added new prefrence choose dialog cancelable or not --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Cb 10637
GitHub user dhams opened a pull request: https://github.com/apache/cordova-docs/pull/504 Cb 10637 Fixed link location which was previously not correct. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accenture/cordova-docs CB-10637 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/504.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #504 commit ad62d21801f5c956277f7ee5ed3aab2fe2b95116 Author: dhams <dharam.in...@gmail.com> Date: 2016-02-17T13:10:03Z Made a correction in link location Corrected link location for config.md file and #pause tag events.md file commit d731acdcf4965d9a24567bc4c6320927c67bfd8b Author: bbadrinath <bbadrin...@users.noreply.github.com> Date: 2016-02-17T13:22:46Z Merge pull request #1 from dhams/patch-2 Made a correction in link location --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Cb 6498
GitHub user dhams opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/81 Cb 6498 Fixed document issue for android You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accenture/cordova-plugin-splashscreen CB-6498 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/81.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #81 commit d82b76cba98915612be960d9f66891584dfb215b Author: bbadrinath <bbadrin...@users.noreply.github.com> Date: 2016-02-10T06:56:29Z Merge pull request #1 from apache/master Rebasing the forked branch from 3.1.1 to current master branch 3.2.0 commit 803d52fc4a7349be131650c615723477e6e534a4 Author: Sharma <dharmendra.g.sha...@accenture.com> Date: 2016-02-10T08:41:24Z Fixed doccument issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue
Github user dhams commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/80#discussion_r52311417
--- Diff: README.md ---
@@ -123,6 +123,8 @@ window.setTimeout(function () {
}, splashDuration - fadeDuration);
```
+### iOS Quirks
--- End diff --
@daserge I have just changed document for Android only. You can see by
expanding those full changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue
GitHub user dhams opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/80 Fixed doccument issue Changed miss leaded document. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accenture/cordova-plugin-splashscreen CB-6498 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/80.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #80 commit 733cfbcd7a239df990158717f92ec75f78b3975d Author: Sharma, Dharmendra G <dharmendra.g.sha...@accenture.com> Date: 2016-02-09T13:23:53Z Fixed doccument issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue
Github user dhams closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: added android 5.1.0 release blog post
Github user dhams commented on the pull request: https://github.com/apache/cordova-docs/pull/462#issuecomment-175609597 Sorry guys but that not comes with the fixes ... Same #/CB-9189 is still there even after update 5.4.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
