[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...
Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Just squashed the commits into a single one for the PR request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...
Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 Would it be better to add an if condition check, and only apply the change if WKWebView is used? so that the change will not affect UIWebView's old behavior by any chance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #105: fix bug CB-11422 ios SplashScreen pl...
Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/105 Close the pull request as the change in CB-10895 already handled the case by removing the extra if condition check. Please refer to bug CB-11422 for details. Jonathan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request #105: fix bug CB-11422 ios SplashSc...
Github user jonathanli2 closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...
Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Actually as mentioned in jcesarmobile's comment at above, the right issue id for this pull request is CB-10288. I just edited the PR title to the "CB-10288" using the required format. Thanks Jonathan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...
Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Hi, Just follow jcesarmobile's suggestion and still use UIWindow's bounds in pluginInitialize method, then the status tab event gets fired as expected in my testing. As the original resizing issue was caused in ResizeWebView method, so as long as the webview bound is set to UIWindows' bound, then it should be fine for ipad pro slideview and split view function. I will update the pull request shortly. Thanks Jonathan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...
Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Hi, I believe I have signed the agreement a while ago (on November 2014) when suggested by John Wargo, but I think at that time I signed the agreement using my company's email address jonathan...@sap.com, instead of my personal email address used for the pull request (jonathan_li2...@yahoo.ca). In that case, do I need to submit the agreement again using my personal email address? Thanks Jonathan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...
Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Hi, Thanks for the quick review, and really appreciate your help. I updated the pull request based on your comment, please let me know if any other changes are needed. Thanks Jonathan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #62: CB:-9161 Support iPad multitaskin...
GitHub user jonathanli2 opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/62 CB:-9161 Support iPad multitasking in iOS 9. (statusbar plugin side fix) ### Platforms affected ios ### What does this PR do? With the ipad pro multitask slideview and splitview function, ios application cannot assume it can always use the full screen as its UI, instead the ios may only allow part of the screen to be used for the application's view. So when checking the bounds of UI view, it should get it from UIWindow's bounds instead of the device screen's bound ### What testing has been done on this change? Manual testing on ios devices ### Checklist - [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jonathanli2/cordova-plugin-statusbar master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 8070c69e91c2e317baf3b970350f3c950ffcbfa3 Author: Jonathan Li <jonathan...@sap.com> Date: 2016-08-28T20:01:54Z CB:-9161 Support iPad multitasking in iOS 9. (statusbar plugin side fix) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request #105: fix bug CB-11422 ios SplashSc...
GitHub user jonathanli2 opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/105 fix bug CB-11422 ios SplashScreen plugin may make webview disabled by⦠### Platforms affected ios ### What does this PR do? Fix bug CB-11422 ios SplashScreen plugin may make webview disabled by splash screen plugin ### What testing has been done on this change? Testing with an ios cordova project with splash screen. ### Checklist - [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. Yes - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database Yes - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. Yes - [ ] Added automated test coverage as appropriate for this change. ⦠not calling destroyView method You can merge this pull request into a Git repository by running: $ git pull https://github.com/jonathanli2/cordova-plugin-splashscreen master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/105.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #105 commit 60e3e3381ab0a9481e62fc305919e9c8d0930ab7 Author: Jonathan Li <jonathan...@sap.com> Date: 2016-06-13T15:05:35Z CB-11422: (ios): SplashScreen plugin may make webview disabled by not calling destroyView method --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
