[GitHub] cordova-ios issue #328: CB-13093: (iOS) Infinite looping when stressing navi...

2017-07-27 Thread luissilvaos
Github user luissilvaos commented on the issue:

https://github.com/apache/cordova-ios/pull/328
  
Yes, it is. Please check my last commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request #328: CB-13093: (iOS) Infinite looping when stressi...

2017-07-24 Thread luissilvaos
GitHub user luissilvaos opened a pull request:

https://github.com/apache/cordova-ios/pull/328

CB-13093: (iOS) Infinite looping when stressing navigation

### Platforms affected
iOS

### What does this PR do?
Fix the navigations that starts with the STATE_WAITING_FOR_LOAD_START  by 
calling the self webview:didFailLoadWithError method instead of delegating it.

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/luissilvaos/cordova-ios CB-13093

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/328.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #328


commit 138e58649a9b698d6a2fb2454497981d7b937669
Author: Luis Silva <luis.si...@outsystems.com>
Date:   2017-07-24T09:14:51Z

CB-13093: (iOS) Infinite looping when stressing navigation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #:

2016-12-09 Thread luissilvaos
Github user luissilvaos commented on the pull request:


https://github.com/apache/cordova-lib/commit/328980c2a91dada8049f1e4f27103df67ba07532#commitcomment-20134722
  
Hi,
This is preventing me from install a plugin with a git-ref without 
subdirectories.
Example: https://github.com/myrepo/my-cordova-plugin.git#1.0.0



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org