[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...
Github user mhartington commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/85 This pr does not address everything. In order to have full iPhoneX support you need the following 1) `viewport-fit=cover` added to your meta tag, this will tell the webview to use the full screen real estate 2) A launch storyboard image for your splashscreen. This is a single 2732x2732 image that will be cropped to fix different screen sizes. An example project can be found here. https://github.com/kerrishotts/lsb-example-simple What this PR _DOES_ is address a sizing issue for the statusbar plugin. Since it was hardcoded to 20px, it would create a small gap when you used viewport-fit and the storyboard image.  But applying this fix, along with the others, you can remove that gap.  --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #86: CB-13291: iOS 11 statusbar fixes
Github user mhartington commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/86 With `StatusBarCropsWebview`, does this override/breaks the expected behavior of `viewport-fit`? In my tested, most of the sizing/cropping settings can be fixed just by adding `viewport-fit=cover` to the viewport meta tag. If this setting does something similar, I'd think it would not be necessary. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #85: CB-13273: fix statusbar spacing w...
GitHub user mhartington opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/85 CB-13273: fix statusbar spacing with new iphoneX ### Platforms affected iOS ### What does this PR do? Adds additional check for iOS11/iPhone X and the new statusbar size ### What testing has been done on this change? Manual testing on devices and simulators. Note: I messed on the commit message format, tagged the wrong jira issue. But there is an issue for this. https://issues.apache.org/jira/browse/CB-13273 ### Checklist - [ x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ x] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mhartington/cordova-plugin-statusbar CB-12886cordova-plugin-statusbar Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/85.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #85 commit f4dbcc2d61c01c2766afdc5e40d1c47226a04f5d Author: mhartington <mikeharting...@gmail.com> Date: 2017-09-15T13:50:42Z CB-12886: fix statusbar spacing with new iphoneX --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #229: CB-11661: (ios) Add mandatory iOS 1...
GitHub user mhartington opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/229 CB-11661: (ios) Add mandatory iOS 10 privacy description ### Platforms affected iOS ### What does this PR do? Adds the mandatory NSCameraUsageDescription key to the info.plist, allowing to pass the value as a variable. Documented the usage of the variable on plugin install as iOS quirk ### What testing has been done on this change? ### Checklist - [X ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [X ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mhartington/cordova-plugin-camera master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/229.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #229 commit 8ead470d752fdc50f3d315fb3aeb3fa709ce3f45 Author: mhartington <mikeharting...@gmail.com> Date: 2016-08-11T19:22:39Z CB-11661: (ios) Add mandatory iOS 10 privacy description --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...
Github user mhartington commented on the pull request: https://github.com/apache/cordova-ios/pull/193#issuecomment-185951944 Same here, couldn't get anything to break for me. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: add ionic logo and description
GitHub user mhartington opened a pull request: https://github.com/apache/cordova-docs/pull/313 add ionic logo and description You can merge this pull request into a Git repository by running: $ git pull https://github.com/mhartington/cordova-docs cordova-website Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/313.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #313 commit 421839a958ed296c5bfb4c8c93f1f0bbf7d27b05 Author: mhartington mikeharting...@gmail.com Date: 2015-08-26T21:06:23Z add ionic logo and description --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
