Cordova Slack Digest :: Wed, 01 Jul 2020 09:42:39 GMT

[purplecabbage]

Cordova Slack Digest Wed, 01 Jul 2020 09:42:41 GMT
User count: 3980 https://cordova.slack.com/
Join the conversation at http://slack.cordova.io/

---

Channel random (1)
=
Thu, 25 Jun 2020 16:39:52 GMT
@harish959 says  Hey Cordova Community 

I wanted to give you a heads up on a virtual hackathon opportunity at Gitcoin!



 June 15 - July 6th
 Privacy Theme
 $50,000 USD in Prizes
欄 Keep Network, MakerDAO, NEAR, Ocean Protocol, Status, Tor Project, and Zcash

P.S. I have a secret!  Some of the challenges don’t have submissions yet, so 
get coding!

---


---

Channel general (64)
=
Wed, 17 Jun 2020 10:26:27 GMT
@jchevalier says Hello there. I'm a french computer scientist. Do have 
a question about AngularJS LTS from the cordova perspective.
Wed, 17 Jun 2020 10:27:54 GMT
@jchevalier says anyone interested in this topic ? 
Wed, 17 Jun 2020 10:30:38 GMT
@chadwick.blackford says <@U015RBBS93N> what u mean?)
Wed, 17 Jun 2020 15:52:27 GMT
@khatridevk says Anybody experienced this issue ! 
Have updated to xcode 11.. while doing Cordova build ios@4.3.1.. I get this 
error, 
am I missing any important configuration for the latest xcode..
Wed, 17 Jun 2020 15:57:41 GMT
@norman137 says  cordova-ios@4 doesn't support xcode 11.
Wed, 17 Jun 2020 15:58:10 GMT
@norman137 says  I think you need at least 5.x... but formal support was added 
in 6.x
Wed, 17 Jun 2020 16:00:18 GMT
@chadwick.blackford says <@UUQS37S1L> Xcode 11 work fine with 
cordova-ios@5.1.1
Wed, 17 Jun 2020 16:13:07 GMT
@khatridevk says Thanks... I ll give it a try.
Thu, 18 Jun 2020 07:28:28 GMT
@ooithianhooi says   I am currently working on wrapping an angular UI using 
Apache Cordova. The angular UI accesses an API by following a proxy to 
 which is hosting a server. The 
angular UI works fine as long as the server is up and running.

But when I wrap the Angular UI with cordova, it seems to not include the proxy 
configuration. Any idea on how to deal with this?

I have actually posted it on Stack Overflow.

Fri, 19 Jun 2020 08:42:10 GMT
@dan590 says Hi all! Just a general usage question in terms of different 
plugins on different branches. I have multiple branches with different set of 
Cordova plugins added to `package.json`  in them. However when I checkout a 
different branch `cordova plugin ls` still shows the same list plugins present. 
I want the packages built of different branches to strictly include only 
plugins included by that branch rather than all of them. Is there a process to 
manage that of which I’m obviously not aware? Thanks in advance for any 
pointers!
Fri, 19 Jun 2020 18:24:03 GMT
@chadwick.blackford says Hi <@UH64E8HG9>, this happens because you 
don’t clean your cordova-app folders after changing branches… you have always 
old state with last `npm install` . this happens because in normal cases 
`platforms` and `plugins` folders stay outside of SCM… write a script where you 
remove both folders and do `npm install  cordova prepare`
Sat, 20 Jun 2020 16:57:29 GMT
@george.earp094 says Hi guys, need some help. I just changed my 
cordova/angularjs app to use wkwebview. Set the config.xml preferences 
correctly but I'm having a template loading error. That doesn't happen when I'm 
running the same app in Android, so I discarded a template path error. Did 
someone face this issue before and could shed some light on this ? Thanks in 
advance
Sat, 20 Jun 2020 17:12:42 GMT
@erikyuzwa says  do you have a base href defined <@U015KE5EHQW> 
Sat, 20 Jun 2020 19:34:04 GMT
@chadwick.blackford says hallo guys! I need to create an intro slider.. 
and I think, on native layer it will be more stable, quick and secure as using 
broken (cross-browser vs. cross-device) CSS voodoo-magic… my question is, is it 
possible to start some activities/pages on iOS and android on demand?
Mon, 22 Jun 2020 05:21:06 GMT
@khatridevk says I have one more problem in #ios13...I have done the 
setup to optimize the images in my ipad, it has all the photos coming from 
iCloud. If I attach such file which is not in the device, the app just gets 
crashed... No logs...and this works perfectly in iOS 10 and iOS 12
Mon, 22 Jun 2020 12:21:50 GMT
@ariel.magno saysHello, quick question on pushing updates to existing 
Android app. Do you need the original app signing key when uploading new 
version of an existing app? My app builds and runs successfully as an APK file 
but I got this error when trying to upload a new APK file on beta track.
Mon, 22 Jun 2020 12:48:51 GMT
@khatridevk says Consistent issue with Xcode 11, cordova-ios5.0.1, 
swift version 4..."

[GitHub] cordova-plugin-battery-status pull request #21: install cordova-paramedic fr...

[purplecabbage]

Github user purplecabbage closed the pull request at:

https://github.com/apache/cordova-plugin-battery-status/pull/21


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js issue #146: CB-13163: fix using relative paths in calls to requir...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-js/pull/146
  
This broke other stuff :(
cordova-browser cannot install cordova-plugin-device-motion fails, for 
example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-test-platform/pull/1#discussion_r129178197
  
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+ 
+## Stand-alone scripts
+ 
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+ 
+bin/update
+- not entirely sure this code is run, or needs to exist with newish 
non-destructive platform updates
+ 
+## Package Expectations
+ 
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this 
platform and get access to the Api.
+ 
+## Api (Platform) Expectations
+- The PlatformApi class
+- The PlatformApi class is an abstraction around a particular platform 
that exposes all the actions, properties, and methods for this platform so they 
are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets 
and js files.
+- It exposes a single 'prepare' method to provide a way for 
cordova-lib to apply a project's setting/www content to the platform.
+- The PlatformApi class should be implemented by each platform that 
wants to use the new API flow. For those platforms, which don't provide their 
own PlatformApi, there will be a polyfill in cordova-lib.
+- Platforms that implement their own PlatformApi instance should 
implement all prototype methods of this class to be fully compatible with 
cordova-lib.
+- The PlatformApi instance should define the following field:
+- platform : This is a String that defines a platform name.
+ 
+- Api.js exports static functions
+- there is currently a requirement that the file be called Api.js 
(todo:change that)
+ 
+ 
+- Api.js exports static function `updatePlatform(destination, options, 
events);`
+- PlatformApi.updatePlatform = function (cordovaProject, options) {};
+- The `updatePlatform` method is equal to the bin/update script. It 
should update an already installed platform. It should accept a CordovaProject 
instance, that defines a project structure and configuration, that should be 
applied to the new platform, and an options object.
+- cordovaProject: This is a CordovaProject instance that defines a 
project structure and configuration, that should be applied to the new 
platform. This argument is optional and if not defined, that platform is used 
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that 
should override the default one from platform.
+- options.link : This is a flag that should indicate that the 
platform's sources will be linked to the installed platform instead of copying.
+ - The `updatePlatform` method must return a promise, which is either 
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+ 
+- Api.js exports static function `createPlatform(destination, cfg, 
options, events);`
+- PlatformApi.createPlatform = function(cordovaProject, options) {};
+- The `createPlatform method` is equal to the bin/create script. It 
should install the platform to a specified directory and create a platform 
project. It should accept a CordovaProject instance, that defines a project 
structure and configuration, that should be applied to the new platform, and an 
options object.
+- cordovaProject : This is a CordovaProject instance that defines a 
project structure and configuration, that should be applied to the new 
platform. This argument is optional and if not defined, that platform is used 
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that 
should override the default one from the platform.
+- options.link : This is a flag that should indicate that the 
platform's sources will be linked to the installed platform instead of copying.
+- The `createPlatform` method must return a promise, which is either 
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+ 
+The way most platforms work is somewhat tricky.  The Api.js could be 
anywhere in the platform repo, ex. /templates/cordova/Api.js .  When a new 
project is created for the platform, the platform copies this file (and 
supporting files ) to destination/cordova/Api.js.  The project expectations 
demand that the 

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-test-platform/pull/1#discussion_r129108993
  
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+ 
+## Stand-alone scripts
+ 
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+ 
+bin/update
+- not entirely sure this code is run, or needs to exist with newish 
non-destructive platform updates
+ 
+## Package Expectations
+ 
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this 
platform and get access to the Api.
+ 
+## Api (Platform) Expectations
+- The PlatformApi class
+- The PlatformApi class is an abstraction around a particular platform 
that exposes all the actions, properties, and methods for this platform so they 
are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets 
and js files.
+- It exposes a single 'prepare' method to provide a way for 
cordova-lib to apply a project's setting/www content to the platform.
+- The PlatformApi class should be implemented by each platform that 
wants to use the new API flow. For those platforms, which don't provide their 
own PlatformApi, there will be a polyfill in cordova-lib.
+- Platforms that implement their own PlatformApi instance should 
implement all prototype methods of this class to be fully compatible with 
cordova-lib.
+- The PlatformApi instance should define the following field:
+- platform : This is a String that defines a platform name.
+ 
+- Api.js exports static functions
--- End diff --

Static is the correct term for a method that is called by referencing the 
Class and not an instance of the class.

Can we merge this, and create new comments/issues for remaining changes? 
This is impossible to follow now with the number of comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-test-platform/pull/1#discussion_r128879785
  
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+ 
+## Stand-alone scripts
+ 
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+ 
+bin/update
+- not entirely sure this code is run, or needs to exist with newish 
non-destructive platform updates
+ 
+## Package Expectations
+ 
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this 
platform and get access to the Api.
+ 
+## Api (Platform) Expectations
+- The PlatformApi class
+- The PlatformApi class is an abstraction around a particular platform 
that exposes all the actions, properties, and methods for this platform so they 
are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets 
and js files.
+- It exposes a single 'prepare' method to provide a way for 
cordova-lib to apply a project's setting/www content to the platform.
+- The PlatformApi class should be implemented by each platform that 
wants to use the new API flow. For those platforms, which don't provide their 
own PlatformApi, there will be a polyfill in cordova-lib.
+- Platforms that implement their own PlatformApi instance should 
implement all prototype methods of this class to be fully compatible with 
cordova-lib.
+- The PlatformApi instance should define the following field:
+- platform : This is a String that defines a platform name.
+ 
+- Api.js exports static functions
+- there is currently a requirement that the file be called Api.js 
(todo:change that)
+ 
+ 
+- Api.js exports static function `updatePlatform(destination, options, 
events);`
+- PlatformApi.updatePlatform = function (cordovaProject, options) {};
+- The `updatePlatform` method is equal to the bin/update script. It 
should update an already installed platform. It should accept a CordovaProject 
instance, that defines a project structure and configuration, that should be 
applied to the new platform, and an options object.
+- cordovaProject: This is a CordovaProject instance that defines a 
project structure and configuration, that should be applied to the new 
platform. This argument is optional and if not defined, that platform is used 
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that 
should override the default one from platform.
+- options.link : This is a flag that should indicate that the 
platform's sources will be linked to the installed platform instead of copying.
+ - The `updatePlatform` method must return a promise, which is either 
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+ 
+- Api.js exports static function `createPlatform(destination, cfg, 
options, events);`
+- PlatformApi.createPlatform = function(cordovaProject, options) {};
+- The `createPlatform method` is equal to the bin/create script. It 
should install the platform to a specified directory and create a platform 
project. It should accept a CordovaProject instance, that defines a project 
structure and configuration, that should be applied to the new platform, and an 
options object.
+- cordovaProject : This is a CordovaProject instance that defines a 
project structure and configuration, that should be applied to the new 
platform. This argument is optional and if not defined, that platform is used 
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that 
should override the default one from the platform.
--- End diff --

Voice should be 2nd person.  
Something like ... Templates allow app developers to create apps based on 
boilerplate application code ...
Not sure how deep you need to go as the audience for this guide is/are 
platform developers, so it should be more 'How to I respect the template 
parameter when it is given?' and not 'How do I use templates?'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at i

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-test-platform/pull/1#discussion_r128877837
  
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+ 
+## Stand-alone scripts
+ 
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+ 
+bin/update
+- not entirely sure this code is run, or needs to exist with newish 
non-destructive platform updates
+ 
+## Package Expectations
+ 
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this 
platform and get access to the Api.
+ 
+## Api (Platform) Expectations
+- The PlatformApi class
+- The PlatformApi class is an abstraction around a particular platform 
that exposes all the actions, properties, and methods for this platform so they 
are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets 
and js files.
+- It exposes a single 'prepare' method to provide a way for 
cordova-lib to apply a project's setting/www content to the platform.
+- The PlatformApi class should be implemented by each platform that 
wants to use the new API flow. For those platforms, which don't provide their 
own PlatformApi, there will be a polyfill in cordova-lib.
+- Platforms that implement their own PlatformApi instance should 
implement all prototype methods of this class to be fully compatible with 
cordova-lib.
+- The PlatformApi instance should define the following field:
+- platform : This is a String that defines a platform name.
+ 
+- Api.js exports static functions
+- there is currently a requirement that the file be called Api.js 
(todo:change that)
+ 
+ 
+- Api.js exports static function `updatePlatform(destination, options, 
events);`
--- End diff --

Yes, you can remove the update api.  I would also recommend that you test 
it and verify that it does not get called.  ie. try commenting out 
Api.updatePlatform in ios,android,browser,windows,test platforms and call 
cordova platform update for each ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-test-platform issue #1: Doc requirements for platform api expectatio...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-test-platform/pull/1
  
Another thing to note is that the tests that are in this repo *could* be 
used to verify the platformAPI for anyone attempting to implement it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-test-platform/pull/1#discussion_r128874756
  
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+ 
+## Stand-alone scripts
+ 
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+ 
+bin/update
+- not entirely sure this code is run, or needs to exist with newish 
non-destructive platform updates
+ 
+## Package Expectations
+ 
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this 
platform and get access to the Api.
+ 
+## Api (Platform) Expectations
+- The PlatformApi class
+- The PlatformApi class is an abstraction around a particular platform 
that exposes all the actions, properties, and methods for this platform so they 
are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets 
and js files.
+- It exposes a single 'prepare' method to provide a way for 
cordova-lib to apply a project's setting/www content to the platform.
+- The PlatformApi class should be implemented by each platform that 
wants to use the new API flow. For those platforms, which don't provide their 
own PlatformApi, there will be a polyfill in cordova-lib.
+- Platforms that implement their own PlatformApi instance should 
implement all prototype methods of this class to be fully compatible with 
cordova-lib.
+- The PlatformApi instance should define the following field:
+- platform : This is a String that defines a platform name.
+ 
+- Api.js exports static functions
+- there is currently a requirement that the file be called Api.js 
(todo:change that)
+ 
--- End diff --

File an issue that we remove the requirement that the file be called Api.js


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-test-platform/pull/1#discussion_r128835893
  
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+ 
+## Stand-alone scripts
+ 
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+ 
+bin/update
+- not entirely sure this code is run, or needs to exist with newish 
non-destructive platform updates
+ 
+## Package Expectations
+ 
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this 
platform and get access to the Api.
+ 
+## Api (Platform) Expectations
+- The PlatformApi class
+- The PlatformApi class is an abstraction around a particular platform 
that exposes all the actions, properties, and methods for this platform so they 
are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets 
and js files.
+- It exposes a single 'prepare' method to provide a way for 
cordova-lib to apply a project's setting/www content to the platform.
+- The PlatformApi class should be implemented by each platform that 
wants to use the new API flow. For those platforms, which don't provide their 
own PlatformApi, there will be a polyfill in cordova-lib.
+- Platforms that implement their own PlatformApi instance should 
implement all prototype methods of this class to be fully compatible with 
cordova-lib.
+- The PlatformApi instance should define the following field:
+- platform : This is a String that defines a platform name.
+ 
+- Api.js exports static functions
+- there is currently a requirement that the file be called Api.js 
(todo:change that)
+ 
+ 
+- Api.js exports static function `updatePlatform(destination, options, 
events);`
+- PlatformApi.updatePlatform = function (cordovaProject, options) {};
+- The `updatePlatform` method is equal to the bin/update script. It 
should update an already installed platform. It should accept a CordovaProject 
instance, that defines a project structure and configuration, that should be 
applied to the new platform, and an options object.
+- cordovaProject: This is a CordovaProject instance that defines a 
project structure and configuration, that should be applied to the new 
platform. This argument is optional and if not defined, that platform is used 
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that 
should override the default one from platform.
+- options.link : This is a flag that should indicate that the 
platform's sources will be linked to the installed platform instead of copying.
+ - The `updatePlatform` method must return a promise, which is either 
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+ 
+- Api.js exports static function `createPlatform(destination, cfg, 
options, events);`
+- PlatformApi.createPlatform = function(cordovaProject, options) {};
+- The `createPlatform method` is equal to the bin/create script. It 
should install the platform to a specified directory and create a platform 
project. It should accept a CordovaProject instance, that defines a project 
structure and configuration, that should be applied to the new platform, and an 
options object.
+- cordovaProject : This is a CordovaProject instance that defines a 
project structure and configuration, that should be applied to the new 
platform. This argument is optional and if not defined, that platform is used 
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that 
should override the default one from the platform.
+- options.link : This is a flag that should indicate that the 
platform's sources will be linked to the installed platform instead of copying.
+- The `createPlatform` method must return a promise, which is either 
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+ 
+The way most platforms work is somewhat tricky.  The Api.js could be 
anywhere in the platform repo, ex. /templates/cordova/Api.js .  When a new 
project is created for the platform, the platform copies this file (and 
supporting files ) to destination/cordova/Api.js.  The project expectations 
demand that the 

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-test-platform/pull/1#discussion_r128835035
  
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+ 
+## Stand-alone scripts
+ 
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+ 
+bin/update
+- not entirely sure this code is run, or needs to exist with newish 
non-destructive platform updates
+ 
+## Package Expectations
+ 
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this 
platform and get access to the Api.
+ 
+## Api (Platform) Expectations
+- The PlatformApi class
+- The PlatformApi class is an abstraction around a particular platform 
that exposes all the actions, properties, and methods for this platform so they 
are accessible programmatically.
+- It can install & uninstall plugins with all source files, web assets 
and js files.
+- It exposes a single 'prepare' method to provide a way for 
cordova-lib to apply a project's setting/www content to the platform.
+- The PlatformApi class should be implemented by each platform that 
wants to use the new API flow. For those platforms, which don't provide their 
own PlatformApi, there will be a polyfill in cordova-lib.
+- Platforms that implement their own PlatformApi instance should 
implement all prototype methods of this class to be fully compatible with 
cordova-lib.
+- The PlatformApi instance should define the following field:
+- platform : This is a String that defines a platform name.
+ 
+- Api.js exports static functions
+- there is currently a requirement that the file be called Api.js 
(todo:change that)
+ 
+ 
+- Api.js exports static function `updatePlatform(destination, options, 
events);`
+- PlatformApi.updatePlatform = function (cordovaProject, options) {};
+- The `updatePlatform` method is equal to the bin/update script. It 
should update an already installed platform. It should accept a CordovaProject 
instance, that defines a project structure and configuration, that should be 
applied to the new platform, and an options object.
+- cordovaProject: This is a CordovaProject instance that defines a 
project structure and configuration, that should be applied to the new 
platform. This argument is optional and if not defined, that platform is used 
as a standalone project and not as part of a Cordova project.
+- options : This is an options object. The most common options are :
+- options.customTemplate : This is a path to custom template, that 
should override the default one from platform.
+- options.link : This is a flag that should indicate that the 
platform's sources will be linked to the installed platform instead of copying.
+ - The `updatePlatform` method must return a promise, which is either 
fulfilled with a PlatformApi instance or rejected with a CordovaError.
+ 
+- Api.js exports static function `createPlatform(destination, cfg, 
options, events);`
--- End diff --

MUST export a static function createPlatform that returns a new instance of 
the platformAPI


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834822
  
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+ 
+## Stand-alone scripts
+ 
+bin/create scripts
+- bin/create _(typically a node script)_
+- bin/create.bat for windows
+- windows .bat file typically just calls bin/create with node
+ 
+bin/update
+- not entirely sure this code is run, or needs to exist with newish 
non-destructive platform updates
+ 
+## Package Expectations
+ 
+- Platforms must have a package.json in their root.
+- Package.json exports a 'main', usually `"main": "src/cordova/Api.js"`
+- This allows other modules to simply require() the path to this 
platform and get access to the Api.
--- End diff --

this is a MUST
main MUST exist, and it MUST be an instance of the platformAPI with methods 
as you define later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/573#discussion_r127039183
  
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
 */
 /* eslint-env jasmine */
 
+var path = require('path');
+var fs = require('fs');
+var Q = require('q');
+var shell = require('shelljs');
+var events = require('cordova-common').events;
+var rewire = require('rewire');
+var platform_addHelper = rewire('../../../src/cordova/platform/addHelper');
+var platform_module = require('../../../src/cordova/platform');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var cordova_util = require('../../../src/cordova/util');
+var cordova_config = require('../../../src/cordova/config');
+var plugman = require('../../../src/plugman/plugman');
+var fetch_metadata = require('../../../src/plugman/util/metadata');
+var lazy_load = require('../../../src/cordova/lazy_load');
+var prepare = require('../../../src/cordova/prepare');
+var gitclone = require('../../../src/gitclone');
+var fail;
+
 describe('cordova/platform/addHelper', function () {
+var projectRoot = '/some/path';
+// These _mock and _revert_mock objects use rewire as the modules 
these mocks replace
+// during testing all return functions, which we cannot spy on using 
jasmine.
+// Thus, we replace these modules inside the scope of addHelper.js 
using rewire, and shim
+// in these _mock test dummies. The test dummies themselves are 
constructed using
+// jasmine.createSpy inside the first beforeEach.
+var cfg_parser_mock = function () {};
+var cfg_parser_revert_mock;
+var hooks_mock;
+var platform_api_mock;
+var fetch_mock;
+var fetch_revert_mock;
+var prepare_mock;
+var prepare_revert_mock;
+var fake_platform = {
+'platform': 'atari'
+};
+var package_json_mock;
+package_json_mock = jasmine.createSpyObj('package json mock', 
['cordova', 'dependencies']);
+package_json_mock.dependencies = {};
+package_json_mock.cordova = {};
+
+beforeEach(function () {
+hooks_mock = jasmine.createSpyObj('hooksRunner mock', ['fire']);
+hooks_mock.fire.and.returnValue(Q());
+cfg_parser_mock.prototype = jasmine.createSpyObj('config parser 
mock', ['write', 'removeEngine', 'addEngine', 'getHookScripts']);
+cfg_parser_revert_mock = 
platform_addHelper.__set__('ConfigParser', cfg_parser_mock);
+fetch_mock = jasmine.createSpy('fetch mock').and.returnValue(Q());
+fetch_revert_mock = platform_addHelper.__set__('fetch', 
fetch_mock);
+prepare_mock = jasmine.createSpy('prepare 
mock').and.returnValue(Q());
+prepare_mock.preparePlatforms = 
jasmine.createSpy('preparePlatforms mock').and.returnValue(Q());
+prepare_revert_mock = platform_addHelper.__set__('prepare', 
prepare_mock);
+spyOn(shell, 'mkdir');
+spyOn(fs, 'existsSync').and.returnValue(false);
+spyOn(fs, 'writeFileSync');
+spyOn(cordova_util, 
'projectConfig').and.returnValue(path.join(projectRoot, 'config.xml'));
+spyOn(cordova_util, 'isDirectory').and.returnValue(false);
+spyOn(cordova_util, 'fixRelativePath').and.callFake(function 
(input) { return input; });
+spyOn(cordova_util, 'isUrl').and.returnValue(false);
+spyOn(cordova_util, 'hostSupports').and.returnValue(true);
+spyOn(cordova_util, 'removePlatformPluginsJson');
+spyOn(cordova_config, 'read').and.returnValue({});
+spyOn(events, 'emit');
+// Fake platform details we will use for our mocks, returned by 
either
+// getPlatfromDetailsFromDir (in the local-directory case), or
+// downloadPlatform (in every other case)
+spyOn(platform_module, 
'getPlatformDetailsFromDir').and.returnValue(Q(fake_platform));
+spyOn(platform_addHelper, 
'downloadPlatform').and.returnValue(Q(fake_platform));
+spyOn(platform_addHelper, 
'getVersionFromConfigFile').and.returnValue(false);
+spyOn(platform_addHelper, 
'installPluginsForNewPlatform').and.returnValue(Q());
+platform_api_mock = jasmine.createSpyObj('platform api mock', 
['createPlatform', 'updatePlatform']);
+platform_api_mock.createPlatform.and.returnValue(Q());
+platform_api_mock.updatePlatform.and.returnValue(Q());
+spyOn(cordova_util, 
'getPlatformApiFunction').and.returnValue(platform_api_mock);
+spyOn(platform_metadata, 'save');
+spyOn(cordova_util, 'requireNoCache').and.returnValue({});
+});
+afterEach(function () {
+cfg_parser_revert_mock

[GitHub] cordova-plugin-file-transfer issue #130: Update index.md

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/130
  
Localized documentation is not editable.  
Please see https://github.com/cordova/cordova-discuss/wiki/Translations
for more details.

Thank you for your contribution!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #144: Fix documentation for options.heade...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/144
  
good call!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #168: patch method

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/168
  
https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/PATCH
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #174: CB-12399: (Android) Fix bug with We...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/174
  
Thoughts here @infil00p  ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #177: fix Chinese words error in filename

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/177
  
@feidianbo Can you provide an example url that would have failed and now 
will pass, short of writing the whole test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #386: CB-12895 : added eslint and removed jshin...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/386#discussion_r124902965
  
--- Diff: bin/templates/cordova/Api.js ---
@@ -112,16 +110,13 @@ Api.createPlatform = function (destination, config, 
options, events) {
 events = setupEvents(events);
 var result;
 try {
-result = require('../../lib/create')
-.create(destination, config, options, events)
-.then(function (destination) {
+result = require('../../lib/create').create(destination, config, 
options, events).then(function (destination) {
--- End diff --

This is an unfortunate workaround for eslint-ing.  I would much prefer this 
be broken up, ala ...

var libCreate = require('../../lib/create');
var result = libCreate.create(destination, config, options, events);
result.then(function (destination) {
// ...
});
...
return result;



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #571: CB-11980 Update readme to reflect new repos

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-lib/pull/571
  
Merged, closing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #571: CB-11980 Update readme to reflect new repos

[purplecabbage]

Github user purplecabbage closed the pull request at:

https://github.com/apache/cordova-lib/pull/571


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #571: CB-11980 Update readme to reflect new repos

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-lib/pull/571

CB-11980 Update readme to reflect new repos

### Platforms affected
node, text change only

### What does this PR do?
updates readme

### What testing has been done on this change?
proof-read

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-lib CB-11980

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/571.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #571


commit d164a88f6ea072a25bdcc2ce4082f63dd5606e4e
Author: filmaj <maj@gmail.com>
Date:   2017-06-22T20:29:57Z

Reorganized unit test directory. Changes include:
- consolidate spec-cordova/ and spec-plugman/ into a single spec/ dir.
- put jasmine config and helper modules in top-level spec dir.
- changed package.json npm run scripts to reflect purposes of tasks. remove 
"npm run ci" (dosnt fit in new tasks layout)
- updated readme to reflect package.json npm run script changes.
- update appveyor and travis to just run "npm test" - just like a dev would 
on their local machine.

commit 749762f31a4e0ae238e8f125cf84d40748ff3df2
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-27T23:21:55Z

CB-11980 Update readme to reflect new repos




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #323: CB-12960 Run tests on node 4.x and 6.x

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-ios/pull/323
  
This does not appear to run against node 4.x on Travis CI

```
$ node --version
v6.9.1
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #323: CB-12960 Run tests on node 4.x and 6.x

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-ios/pull/323

CB-12960 Run tests on node 4.x and 6.x

### Platforms affected
This one

### What does this PR do?
Runs tests against node 4.x and 6.x

### What testing has been done on this change?
Check travis status

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-ios TravisMatrix46

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/323.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #323


commit 11e396f15fd0667e83fb200993413c41f235b61f
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-27T21:26:29Z

CB-12960 Run tests on node 4.x and 6.x




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-android/pull/391
  
Yeah that might be the same issue with iOS ... 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-android/pull/391
  
Yeah, iOS doesn't even care ...
https://github.com/apache/cordova-ios/blob/master/.travis.yml
Windows does 4+6 ( without `nvm` )
https://github.com/apache/cordova-windows/blob/master/.travis.yml
Browser also 4+6
https://github.com/apache/cordova-browser/blob/master/.travis.yml



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/32#discussion_r124158440
  
--- Diff: bin/template/www/cordova-sw.js ---
@@ -0,0 +1,23 @@
+
+// Note, these will be updated automatically at build time
+var CACHE_VERSION = '%CACHE_VERSION%';
+var CACHE_LIST = ['CACHE_VALUES'];
+
+this.addEventListener('install', function(event) {
+// Perform install steps
+console.log("cordova service worker is installing.");
+event.waitUntil(caches.open(CACHE_VERSION)
+.then(function(cache) {
+return cache.addAll(CACHE_LIST);
+}));
+});
+
+this.addEventListener('activate', function(event) {
+// Perform activate steps
+console.log("cordova service worker is activated.");
+});
+
+this.addEventListener('fetch', function(event) {
+console.log("cordova service worker : fetch : " + event.request.url);
+event.respondWith(caches.match(event.request));
--- End diff --

defensively added to #36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/32#discussion_r124158393
  
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
 "locations":this.locations,
 "root": this.root,
 "name": this.platform,
-"version": { "version" : "1.0.0" },
+"version": { "version" : "1.0.0" }, // um, todo!
 "projectConfig": this.config
 };
 };
 
 Api.prototype.prepare = function (cordovaProject,options) {
 
 // First cleanup current config and merge project's one into own
-var defaultConfig = path.join(this.locations.platformRootDir,'cordova',
+var defaultConfigPath = 
path.join(this.locations.platformRootDir,'cordova',
 'defaults.xml');
-
-var ownConfig = this.locations.configXml;
-
+var ownConfigPath = this.locations.configXml;
 var sourceCfg = cordovaProject.projectConfig;
+
 // If defaults.xml is present, overwrite platform config.xml with it.
 // Otherwise save whatever is there as defaults so it can be
 // restored or copy project config into platform if none exists.
-if (fs.existsSync(defaultConfig)) {
+if (fs.existsSync(defaultConfigPath)) {
 this.events.emit('verbose', 'Generating config.xml from defaults 
for platform "' + this.platform + '"');
-shell.cp('-f', defaultConfig, ownConfig);
-} else if (fs.existsSync(ownConfig)) {
-shell.cp('-f', ownConfig, defaultConfig);
-} else {
-shell.cp('-f', sourceCfg.path, ownConfig);
+shell.cp('-f', defaultConfigPath, ownConfigPath);
+}
+else if (fs.existsSync(ownConfigPath)) {
+this.events.emit('verbose', 'Generating defaults.xml from own 
config.xml for platform "' + this.platform + '"');
+shell.cp('-f', ownConfigPath, defaultConfigPath);
+}
+else {
+this.events.emit('verbose', 'case 3"' + this.platform + '"');
+shell.cp('-f', sourceCfg.path, ownConfigPath);
 }
 
-// this._munger.reapply_global_munge().save_all();
-
-this.config = new ConfigParser(ownConfig);
+// merge our configs
+this.config = new ConfigParser(ownConfigPath);
 xmlHelpers.mergeXml(cordovaProject.projectConfig.doc.getroot(),
-this.config.doc.getroot(), this.platform, true);
+this.config.doc.getroot(),
+this.platform, true);
 this.config.write();
 
-/*
-"browser": {
-"parser_file": "../cordova/metadata/browser_parser",
-"handler_file": "../plugman/platforms/browser",
-"url": 
"https://git-wip-us.apache.org/repos/asf?p=cordova-browser.git;,
-"version": "~4.1.0",
-"deprecated": false
-}
-*/
-
 // Update own www dir with project's www assets and plugins' assets 
and js-files
 this.parser.update_www(cordovaProject.locations.www);
 
+// Copy or Create manifest.json
+// todo: move this to a manifest helper module
+// output path
+var manifestPath = path.join(this.locations.www,'manifest.json');
+var srcManifestPath 
=path.join(cordovaProject.locations.www,'manifest.json');
+if(fs.existsSync(srcManifestPath)) {
+// just blindly copy it to our output/www
+// todo: validate it? ensure all properties we expect exist?
+this.events.emit('verbose','copying ' + srcManifestPath + ' => ' + 
manifestPath);
+shell.cp('-f',srcManifestPath,manifestPath);
+}
+else {
+var manifestJson = {
+"background_color": "#000",
+"display": "standalone"
+};
+if(this.config){
+if(this.config.name()) {
+manifestJson.name = this.config.name();
+}
+if(this.config.shortName()) {
+manifestJson.short_name = this.config.shortName();
+}
+if(this.config.packageName()) {
+manifestJson.version = this.config.packageName();
+}
+if(this.config.description()) {
+manifestJson.description = this.config.description();
+}
+if(this.config.author()) {
+manifestJson.author = this.config.author();
+}
+ 

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/32#discussion_r124158333
  
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
 "locations":this.locations,
 "root": this.root,
 "name": this.platform,
-"version": { "version" : "1.0.0" },
+"version": { "version" : "1.0.0" }, // um, todo!
 "projectConfig": this.config
 };
 };
 
 Api.prototype.prepare = function (cordovaProject,options) {
 
 // First cleanup current config and merge project's one into own
-var defaultConfig = path.join(this.locations.platformRootDir,'cordova',
+var defaultConfigPath = 
path.join(this.locations.platformRootDir,'cordova',
 'defaults.xml');
-
-var ownConfig = this.locations.configXml;
-
+var ownConfigPath = this.locations.configXml;
 var sourceCfg = cordovaProject.projectConfig;
+
 // If defaults.xml is present, overwrite platform config.xml with it.
 // Otherwise save whatever is there as defaults so it can be
 // restored or copy project config into platform if none exists.
-if (fs.existsSync(defaultConfig)) {
+if (fs.existsSync(defaultConfigPath)) {
 this.events.emit('verbose', 'Generating config.xml from defaults 
for platform "' + this.platform + '"');
-shell.cp('-f', defaultConfig, ownConfig);
-} else if (fs.existsSync(ownConfig)) {
-shell.cp('-f', ownConfig, defaultConfig);
-} else {
-shell.cp('-f', sourceCfg.path, ownConfig);
+shell.cp('-f', defaultConfigPath, ownConfigPath);
+}
+else if (fs.existsSync(ownConfigPath)) {
+this.events.emit('verbose', 'Generating defaults.xml from own 
config.xml for platform "' + this.platform + '"');
+shell.cp('-f', ownConfigPath, defaultConfigPath);
+}
+else {
+this.events.emit('verbose', 'case 3"' + this.platform + '"');
+shell.cp('-f', sourceCfg.path, ownConfigPath);
 }
 
-// this._munger.reapply_global_munge().save_all();
-
-this.config = new ConfigParser(ownConfig);
+// merge our configs
+this.config = new ConfigParser(ownConfigPath);
 xmlHelpers.mergeXml(cordovaProject.projectConfig.doc.getroot(),
-this.config.doc.getroot(), this.platform, true);
+this.config.doc.getroot(),
+this.platform, true);
 this.config.write();
 
-/*
-"browser": {
-"parser_file": "../cordova/metadata/browser_parser",
-"handler_file": "../plugman/platforms/browser",
-"url": 
"https://git-wip-us.apache.org/repos/asf?p=cordova-browser.git;,
-"version": "~4.1.0",
-"deprecated": false
-}
-*/
-
 // Update own www dir with project's www assets and plugins' assets 
and js-files
 this.parser.update_www(cordovaProject.locations.www);
 
+// Copy or Create manifest.json
+// todo: move this to a manifest helper module
+// output path
+var manifestPath = path.join(this.locations.www,'manifest.json');
+var srcManifestPath 
=path.join(cordovaProject.locations.www,'manifest.json');
+if(fs.existsSync(srcManifestPath)) {
+// just blindly copy it to our output/www
+// todo: validate it? ensure all properties we expect exist?
+this.events.emit('verbose','copying ' + srcManifestPath + ' => ' + 
manifestPath);
+shell.cp('-f',srcManifestPath,manifestPath);
+}
+else {
+var manifestJson = {
+"background_color": "#000",
--- End diff --

Changed to white in #36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #36: CB-12804 Fixes some simple details - manif...

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-browser/pull/36

CB-12804 Fixes some simple details - manifest.json


### Platforms affected
browser

### What does this PR do?
addresses issues raised with pr #32

### What testing has been done on this change?
manual testing

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-browser CB-12804-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-browser/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit 7aa99f6f19ec8cf4be4136242e42d36cb6ec460b
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-27T01:07:20Z

Approach cache more defensively

commit b7ac532a06f3aea72bb45d5e6b8c7c36ed48cbcd
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-27T01:08:21Z

use white as default bgcolor in manifest, map unknown orientation values to 
'any', address some issues raised in #32




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/32#discussion_r124157183
  
--- Diff: cordova-js-src/confighelper.js ---
@@ -61,14 +61,9 @@ function readConfig(success, error) {
 }
 };
 
-if ("ActiveXObject" in window) {
-// Needed for XHR-ing via file:// protocol in IE
-xhr = new window.ActiveXObject("MSXML2.XMLHTTP");
--- End diff --

I'm older


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/32#discussion_r124157156
  
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
 "locations":this.locations,
 "root": this.root,
 "name": this.platform,
-"version": { "version" : "1.0.0" },
+"version": { "version" : "1.0.0" }, // um, todo!
 "projectConfig": this.config
 };
 };
 
 Api.prototype.prepare = function (cordovaProject,options) {
 
 // First cleanup current config and merge project's one into own
-var defaultConfig = path.join(this.locations.platformRootDir,'cordova',
+var defaultConfigPath = 
path.join(this.locations.platformRootDir,'cordova',
 'defaults.xml');
-
-var ownConfig = this.locations.configXml;
-
+var ownConfigPath = this.locations.configXml;
 var sourceCfg = cordovaProject.projectConfig;
+
 // If defaults.xml is present, overwrite platform config.xml with it.
 // Otherwise save whatever is there as defaults so it can be
 // restored or copy project config into platform if none exists.
-if (fs.existsSync(defaultConfig)) {
+if (fs.existsSync(defaultConfigPath)) {
 this.events.emit('verbose', 'Generating config.xml from defaults 
for platform "' + this.platform + '"');
-shell.cp('-f', defaultConfig, ownConfig);
-} else if (fs.existsSync(ownConfig)) {
-shell.cp('-f', ownConfig, defaultConfig);
-} else {
-shell.cp('-f', sourceCfg.path, ownConfig);
+shell.cp('-f', defaultConfigPath, ownConfigPath);
+}
+else if (fs.existsSync(ownConfigPath)) {
+this.events.emit('verbose', 'Generating defaults.xml from own 
config.xml for platform "' + this.platform + '"');
+shell.cp('-f', ownConfigPath, defaultConfigPath);
+}
+else {
+this.events.emit('verbose', 'case 3"' + this.platform + '"');
+shell.cp('-f', sourceCfg.path, ownConfigPath);
 }
 
-// this._munger.reapply_global_munge().save_all();
-
-this.config = new ConfigParser(ownConfig);
+// merge our configs
+this.config = new ConfigParser(ownConfigPath);
 xmlHelpers.mergeXml(cordovaProject.projectConfig.doc.getroot(),
-this.config.doc.getroot(), this.platform, true);
+this.config.doc.getroot(),
+this.platform, true);
 this.config.write();
 
-/*
-"browser": {
-"parser_file": "../cordova/metadata/browser_parser",
-"handler_file": "../plugman/platforms/browser",
-"url": 
"https://git-wip-us.apache.org/repos/asf?p=cordova-browser.git;,
-"version": "~4.1.0",
-"deprecated": false
-}
-*/
-
 // Update own www dir with project's www assets and plugins' assets 
and js-files
 this.parser.update_www(cordovaProject.locations.www);
 
+// Copy or Create manifest.json
+// todo: move this to a manifest helper module
+// output path
+var manifestPath = path.join(this.locations.www,'manifest.json');
+var srcManifestPath 
=path.join(cordovaProject.locations.www,'manifest.json');
+if(fs.existsSync(srcManifestPath)) {
+// just blindly copy it to our output/www
+// todo: validate it? ensure all properties we expect exist?
+this.events.emit('verbose','copying ' + srcManifestPath + ' => ' + 
manifestPath);
+shell.cp('-f',srcManifestPath,manifestPath);
+}
+else {
+var manifestJson = {
+"background_color": "#000",
+"display": "standalone"
+};
+if(this.config){
+if(this.config.name()) {
+manifestJson.name = this.config.name();
+}
+if(this.config.shortName()) {
+manifestJson.short_name = this.config.shortName();
+}
+if(this.config.packageName()) {
+manifestJson.version = this.config.packageName();
+}
+if(this.config.description()) {
+manifestJson.description = this.config.description();
+}
+if(this.config.author()) {
+manifestJson.author = this.config.author();
+}
+ 

[GitHub] cordova-browser pull request #35: CB-11181 add default favicon

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-browser/pull/35

CB-11181 add default favicon


### Platforms affected
Browser

### What does this PR do?
adds default favicon, that 'should' be overwritten by apps targeting 
browser, this avoids a 404 shown in console.error

### What testing has been done on this change?
manual

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-browser CB-11181

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-browser/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #35


commit db6d1180296b8578a596e6f03d5b4adc49e5fff6
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-26T23:22:50Z

CB-11181 add default favicon




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #34: CB-11710 Add missing 'clean.bat' file

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-browser/pull/34

CB-11710 Add missing 'clean.bat' file


### Platforms affected
browser ( when run on windows )

### What does this PR do?
adds missing clean.bat file

### What testing has been done on this change?


### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-browser CB-11710

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-browser/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #34


commit 7944f46521ddfe1559443c848f3e8a6d50b34bb8
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-23T20:09:40Z

CB-11710 Add missing 'clean.bat' file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status issue #55: CB-12935 Run paramedic builds on Tr...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/55
  
Awesome! 
Is the next step to just copy this to the other plugin repos?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #33: CB-11711 clean should destroy platforms/br...

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-browser/pull/33

CB-11711 clean should destroy platforms/browser/www folder contents



### Platforms affected
browser

### What does this PR do?
removes www/ folder during clean

### What testing has been done on this change?


### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-browser CB-11711

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-browser/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #33


commit 54ae99da4ee9ad802699f2f38b7b02eb7399a7d7
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-22T23:07:38Z

CB-11711 clean should destroy platforms/browser/www folder contents




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation issue #37: Fix error from translation, params nam...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-geolocation/pull/37
  
Sorry for not seeing this sooner, and thanks for contributing.
We use Crowdin, a translation and localization management platform to 
collaborate amongst translators and our core team.


https://github.com/apache/cordova-coho/blob/master/docs/doc-translation-process.md




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/567#discussion_r123380130
  
--- Diff: spec-cordova/prepare.spec.js ---
@@ -17,175 +17,265 @@
 under the License.
 */
 
-var shell = require('shelljs'),
-PlatformJson = require('cordova-common').PlatformJson,
-path = require('path'),
-util = require('../src/cordova/util'),
-prepare = require('../src/cordova/prepare'),
-lazy_load = require('../src/cordova/lazy_load'),
-ConfigParser = require('cordova-common').ConfigParser,
-platforms = require('../src/platforms/platforms'),
-HooksRunner = require('../src/hooks/HooksRunner'),
-xmlHelpers = require('cordova-common').xmlHelpers,
-et = require('elementtree'),
-Q = require('q');
+/* eslint-env jasmine */
 
-var project_dir = '/some/path';
-var supported_platforms = Object.keys(platforms).filter(function(p) { 
return p != 'www'; });
-
-var TEST_XML = '\n' +
-'http://www.w3.org/ns/widgets"\n' +
-'xmlns:cdv = "http://cordova.apache.org/ns/1.0"\n' +
-'id= "io.cordova.hellocordova"\n' +
-'version   = "0.0.1">\n' +
-'Hello Cordova\n' +
-'\n' +
-'A sample Apache Cordova application that responds to the 
deviceready event.\n' +
-'\n' +
-'http://cordova.io; 
email="dev@cordova.apache.org">\n' +
-'Apache Cordova Team\n' +
-'\n' +
-'\n' +
-'\n' +
-'\n' +
-'\n' +
-'\n';
+var path = require('path');
+var rewire = require('rewire');
+var util = require('../src/cordova/util');
+var cordova_config = require('../src/cordova/config');
+var prepare = rewire('../src/cordova/prepare');
+var restore = require('../src/cordova/restore-util');
+var platforms = require('../src/platforms/platforms');
+var HooksRunner = require('../src/hooks/HooksRunner');
+var Q = require('q');
+var PlatformJson = require('cordova-common').PlatformJson;
+var PluginInfoProvider = require('cordova-common').PluginInfoProvider;
 
-describe('prepare command', function() {
-var is_cordova,
-cd_project_root,
-list_platforms,
-fire,
-parsers = {},
-find_plugins,
-cp,
-mkdir,
-load, platformApi, getPlatformApi;
+var project_dir = '/some/path';
 
+describe('cordova/prepare', function () {
+let platform_api_prepare_mock;
--- End diff --

I am cool with `let|const|var`, my reservation is around `() =>` syntax as 
I want to be sure everyone is using it correctly before it gets dumped all over 
the place.

I kinda think this pr is not the place to start the conversion effort.





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #387: CB-12605 In Windows get Android studio pa...

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-android/pull/387

CB-12605 In Windows get Android studio path from the registry

### Platforms affected
Android on windows

### What does this PR do?
Allows installs of Android Studio in places other than C://

### What testing has been done on this change?
Tested with and without registry value present

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-android CB-12605

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #387


commit 656fc194cef72dc597c4528287bcc3ca3c025fee
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-20T23:54:32Z

CB-12605 In Windows get Android studio path from the registry




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #516: CB-12385: (win32/linux/darwin) auto open devtools in...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-lib/pull/516
  
cordova-serve now lives in it's own repo at 
github.com/apache/cordova-serve




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #255: CLI Refactor

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-cli/pull/255
  
Ima close this soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #281: CB-12895 : updated to use eslint instead of jshint

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-cli/pull/281
  
this needs a refactor with recent changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #283: CB-12901 Cli Refactor

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-cli/pull/283
  
That is correct!
The cordova-lib changes are already on master, so together they are broken 
without these changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #283: CB-12901 Cli Refactor

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-cli/pull/283

CB-12901 Cli Refactor

### What does this PR do?

- fixed failing tests.
- adjusted tests to call cordova instead of cordova.raw
- added tests to compare cordova.raw and cordova
- changed some console.log to logger.log
- help module returns help text and does not print it
-- this is to make testing easier and not have it spit all over jasmine 
output. 
- various minor refactors, removed some un-needed promises etc.
- added timeoutInSecs property to make user prompts testable without 
waiting for 30 seconds
- this includes @stevengill 's previous pr

### Platforms affected
tooling


### What testing has been done on this change?

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-cli RefactorWithCB-12901

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #283


commit a4c71847702793fc24cdfe393f954e4b2f1fc863
Author: Steve Gill <stevengil...@gmail.com>
Date:   2017-06-16T21:37:07Z

CB-12901: removed .raw from cordova-lib calls

commit a24ec7968f4b271d9c3487980d29b3766b690053
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-20T05:17:56Z

fixed lines that were too long, test was failing

commit a26a73a420f71c972094513580921070a9026a47
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-20T05:19:06Z

added timeoutInSecs property to make user prompts testable without waiting 
for 30 seconds

commit 310d6b0a1c33d2289b8909fc61d13b46c7ca5950
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-20T05:22:13Z

adjusted tests to call cordova instead of cordova.raw, added tests to 
compare cordova.raw and cordova, changed some console.log to logger.log; help 
module returns help text and does not print it, this is to make testing easier 
and not have it spit all over jasmine output. various minor refactors, removed 
some un-needed promises




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser issue #31: CB-12905: (linux) Fix issue with freezing after l...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-browser/pull/31
  
This needs to be addressed in the cordova-serve repo if it is an issue. 
Closing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #708: Win8 removed + bb10 & ubuntu depreciation info

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/708
  
Nope, it seems there are some mixed up deletions ) from a quick glance.
This is the data that shows up on  
https://cordova.apache.org/docs/en/latest/guide/support/index.html right?
Windows column should be renamed to `windows (uwp)` and should still exist.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #562: Removing lazy load, platform command refactor, start...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-lib/pull/562
  
This all looks great to me, good work.
I would like to move forward with this asap as it is big, and affects a lot 
of different areas.
Let's keep our merge conflict exposure low and get this in soon.
I am looking into failing tests on CI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #562: Removing lazy load, platform command refactor...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/562#discussion_r122330032
  
--- Diff: src/util/alias.js ---
@@ -0,0 +1,27 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var cordova_events = require('cordova-common').events;
+
+module.exports = function aliasMethodToRawWithDeprecationNotice(property, 
targetObj, component) {
+targetObj.raw[property] = function() {
+cordova_events.emit('warn', 'Use of `' + component + '.raw.*` 
methods is deprecated and `' + component + '.raw` will be removed in a future 
release. Please migrate to using the top-level `' + component + '.*` methods 
instead.');
--- End diff --

*nit: The habit of using backticks in output sort of muddies the water when 
we eventually move to using proper ES6 backtick javascript string formatting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #32: Cb 12804

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-browser/pull/32

Cb 12804

### Platforms affected
cordova-browser

### What does this PR do?
adds manifest.json support

### What testing has been done on this change?
added tests

This pr includes all commits from #30 which can be closed.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-browser CB-12804

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-browser/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #32


commit eec8c5398440f6fcbbd4e5c1178c46c3d12df688
Author: Audrey So <audre...@apache.org>
Date:   2017-05-26T16:38:09Z

CB-12804 : manifest.json added to browser during create

commit 4a52f045e4beb0d991db613937061757df9638f9
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-01T20:21:32Z

work in progress

commit b85f06ba6a17f8cbd551ef5f827e24384084a72f
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-02T18:50:58Z

Updated images to improve lighthouse score. Added orientation to manifest.

commit 3052805af944a38fa54926393d4f49e49c8cae11
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-04T06:51:49Z

add link rel=manifest, more manifest specs to check

commit 012191c3011076f995f4ec2af8f8729d153fd4e7
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-04T07:00:04Z

remove console.log to stop whining CI

commit 146fb74b69e0c24e56ecff38f0e38aad8353e9fd
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-06T18:47:08Z

remove old xhr-activex windows bs, update to use pagevisibility instead of 
webkitpagevisibility

commit 5b837270c26d0ee8856ebbf018f516f5998136c9
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-07T22:55:11Z

output create events, copy manifest.json from template to platform_www

commit c4511806452014fd99f5cce6f5ce73614402063a
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-09T18:54:09Z

clean up some cruft, create emit errors, removed old ActiveX seeking xhr 
code

commit 2e63f9fe43d0e927f9d2ab9cfc2aedd1c2f74f36
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-06-14T23:23:58Z

run gets start_url from manifest, spec verifies manifest, Api delays 
writing to manifest and uses platform_www/




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-orientation issue #36: CB-12728: Device Orientation - ...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-device-orientation/pull/36
  
lgtm
When we publish it next, we should also deprecate it in npm land.
https://docs.npmjs.com/cli/deprecate


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion issue #53: CB-12726: Device Motion - SUNSET

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-device-motion/pull/53
  
lgtm
When we publish it next, we should also deprecate it in npm land.
https://docs.npmjs.com/cli/deprecate


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/99
  
Attn: @shazron @infil00p 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
+1, let's merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser issue #25: CB-8260: (browser) Fix corrupted zip file (build)

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-browser/pull/25
  
I like this, and thank you, however, I am planning on removing zip 
functionality.
I believe zipping was only added because someone decided that `build` 
needed some sort of output.
Realistically, I think it makes more sense to let users zip their own build 
output as they see fit, and remove these extra deps.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser issue #2: Add generic Linux support to 'run' script

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-browser/pull/2
  
browser platform uses cordova-serve now. closing.
Please send a pr to cordova 
https://github.com/apache/cordova-lib/tree/master/cordova-serve if this is 
still relevant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser issue #28: CB-12527 Add platformAPI

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-browser/pull/28
  
This pr is ready for review!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/699#discussion_r113560349
  
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https://twitter.com/aud_rey_so
+title:  "Apache Cordova 7.0.0"
+categories: news
+tags: news releases
+---
+
+We are happy to announce that `Apache Cordova 7.0.0` has been released!
+
+Most notable changes include:
+* If a `package.json` does not exist in your project, it will be 
auto-created for you when `cordova prepare` is called.
+* When adding a platform or plugin, it will automatically save that 
platform or plugin to your `config.xml` and `package.json`. Details about 
platform and plugin versions are also automatically saved in `config.xml` and 
`package.json`. The `--save` flag is no longer required to save. Use `--nosave` 
to prevent saving to `config.xml` or `package.json`.
+* Fetch is now the default setting for fetching platforms. Fetch uses your 
system `npm` to `npm install` modules into your project. The `--fetch` flag is 
no longer required. Use the `--nofetch` flag to use the older cordova fetching 
method (pre `cordova@7`) and prevent using `npm install` to do the fetching.
+* After `cordova prepare` is run, `package.json` and `config.xml` should 
contain identical platforms and versions.  In case of conflicts, `package.json` 
is given precedence over `config.xml`. For example, suppose `package.json` 
contains `cordova-android@6.0.0` and `config.xml` contains 
`cordova-android@4.0.0`. After `cordova prepare` is run, `config.xml` and 
`package.json` will each contain only `cordova-android@6.0.0`.
+* Users can install any platform due to removing known platform check for 
platform API. For instance, users can now add custom platforms to their 
projects.
--- End diff --

Yeah, that's probably better ... it is somewhat of an incomplete feature 
right now as it requires substantial documentation ( how to write a platform ) 
and some thought around plugin support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/699#discussion_r113543204
  
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https://twitter.com/aud_rey_so
+title:  "Apache Cordova 7.0.0"
+categories: news
+tags: news releases
+---
+
+We are happy to announce that `Apache Cordova 7.0.0` has been released!
+
+Most notable changes include:
+* If a `package.json` does not exist in your project, it will be 
auto-created for you when `cordova prepare` is called.
+* When adding a platform or plugin, it will automatically save that 
platform or plugin to your `config.xml` and `package.json`. Details about 
platform and plugin versions are also automatically saved in `config.xml` and 
`package.json`. The `--save` flag is no longer required to save. Use `--nosave` 
to prevent saving to `config.xml` or `package.json`.
+* Fetch is now the default setting for fetching platforms. Fetch uses your 
system `npm` to `npm install` modules into your project. The `--fetch` flag is 
no longer required. Use the `--nofetch` flag to use the older cordova fetching 
method (pre `cordova@7`) and prevent using `npm install` to do the fetching.
+* After `cordova prepare` is run, `package.json` and `config.xml` should 
contain identical platforms and versions.  In case of conflicts, `package.json` 
is given precedence over `config.xml`. For example, suppose `package.json` 
contains `cordova-android@6.0.0` and `config.xml` contains 
`cordova-android@4.0.0`. After `cordova prepare` is run, `config.xml` and 
`package.json` will each contain only `cordova-android@6.0.0`.
+* Users can install any platform due to removing known platform check for 
platform API. For instance, users can now add custom platforms to their 
projects.
+* Platforms and plugins are now required to have a package.json file.
+
+Example: 
+
+   cordova platform add custom-platform-name
+
+Link to how to create your own platforms:
+
+* A cordova config command has been created to `set`, `get`, `delete`, 
`edit`, and `list` global cordova options. For example, you can use the 
following command `cordova config set  ` to set the value of 
autosave or fetch to true or false. 
+
+In this case, you are turning off autosave as the default setting. 
Example: 
+
+   cordova config set autosave false
+
+In this case, you are turning off fetch as the default setting. Example:
+
+   cordova config set fetch false
+
+In addition, the cordova config command supports browserify setting, which 
allows the JavaScript of plugins to be loaded at build time compared to run 
time. For instance, if the browserify value is not explicility passed in by the 
user, the cordova config command will automatically set the browserify value 
saved in `~/.config/configstore/` to saved `globally`. Users can get and set 
browserify. Example:
+   
+   cordova config get browserify
+   cordova config set browserify true
+
+* Removed support for node 0.x. Only node versions 4.0 and up are 
supported.
+* Removed support for `cordova-windows@8` and under.
+* Removed support for `cordova-android@4` and under.
+* Removed support for `cordova-ios@3` and under.
--- End diff --

and older?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #699: cordova7_post : cordova7 release post

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/699
  
👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/699#discussion_r113523749
  
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https://twitter.com/aud_rey_so
+title:  "Apache Cordova 7.0.0"
+categories: news
+tags: news releases
+---
+
+We are happy to announce that `Apache Cordova 7.0.0` has been released!
+
+Most notable changes include:
+* If a `package.json` does not exist in your project, it will be 
auto-created for you when `cordova prepare` is called.
+* When adding a platform or plugin, it will automatically save that 
platform or plugin to your `config.xml` and `package.json`. Details about 
platform and plugin versions are also automatically saved in `config.xml` and 
`package.json`. The `--save` flag is no longer required to save. Use `--nosave` 
to prevent saving to `config.xml` or `package.json`.
+* Fetch is now the default setting for fetching platforms. Fetch uses your 
system `npm` to `npm install` modules into your project. The `--fetch` flag is 
no longer required. Use the `--nofetch` flag to use the older cordova fetching 
method (pre `cordova@7`) and prevent using `npm install` to do the fetching.
+* After `cordova prepare` is run, `package.json` and `config.xml` should 
contain identical platforms and versions.  In case of conflicts, `package.json` 
is given precedence over `config.xml`. For example, suppose `package.json` 
contains `cordova-android@6.0.0` and `config.xml` contains 
`cordova-android@4.0.0`. After `cordova prepare` is run, `config.xml` and 
`package.json` will each contain only `cordova-android@6.0.0`.
+* Users can install any platform due to removing known platform check for 
platform API. For instance, users can now add custom platforms to their 
projects.
--- End diff --

~* Users can install any platform due to removing known platform check for 
platform API. For instance, users can now add custom platforms to their 
projects.~
* We have removed a requirement that `platform add` be called with a 
'_known platform_' and now simply expect that whatever you pass '_behaves like 
a known platform_'.  This will allow future custom platforms, and modified 
version of existing platforms.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-media-capture/pull/76
  
It is always nice to have, but not specifically required; sending a pr is 
proof of the intent to contribute.

In this case the graphics are really just resized versions of existing 
files, so this is a modification.
If brand new images were generated then we might need to insist as the ICLA 
also protects us from someone contributing something they don't have the rights 
to.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-media-capture/pull/76
  
they are both device specific, and cordova specific
I see these as something that an app developer should be providing 
themselves, unfortunately there is not an API for this, or a demo/doc of how a 
developer would do it.

The images already exist for every other device shape and size, so this 
isn't a new thing, just covering more new devices.

That said, I have never really agreed with the direction of providing a 
generic UI inside this plugin, ...
But, It is probably better to just accept this pr, and move on with another 
implementation some day when we find the time.  

The fact that @momomatteo ;) has taken the time to send this pr should 
speak much louder than my personal feelings on the subject ... 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-dialogs issue #30: Added option to specify the input type of ...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-dialogs/pull/30
  
No, @ktran13, it was not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #11: CB-12543 (iOS) Set orientation ...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
cleaned up a few merge issues, this is now in master, thanks @cnspaha 
Next the plugin will need to go thru the typical Apache vote process before 
being pushed to npm.

In the meantime, you should still be able to install it by using the github 
repo url : 

```cordova plugin add 
https://github.com/apache/cordova-plugin-screen-orientation```

or in build, add this to your config.xml 

```
 https://github.com/apache/cordova-plugin-screen-orientation; />
```





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #11: CB-12543 (iOS) Set orientation ...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
there is nothing more that @ego7repo can do.
I am reviewing this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #548: CB-12683: improved error messaging for when a plugin...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-lib/pull/548
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #80: CB-9057: Replaced the Windows 10 Preview version ...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-windows/pull/80
  

http://cordova.apache.org/docs/en/6.x/guide/cli/index.html#using-merges-to-customize-each-platform


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #516: CB-12385: (win32/linux/darwin) auto open devtools in...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-lib/pull/516
  
This is interesting, is it possible in other brower targets?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #538: Emit platformAPI loading error, remove Gradle...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/538#discussion_r112554925
  
--- Diff: 
cordova-lib/spec-cordova/fixtures/platforms/cordova-browser/bin/lib/create.js 
---
@@ -39,14 +39,14 @@ module.exports.createProject = 
function(project_path,package_name,project_name){
 console.error('Project already exists! Delete and recreate');
 process.exit(2);
 }
-
+
 // Check that requirements are met and proper targets are installed
 if (!check_reqs.run()) {
 console.error('Please make sure you meet the software requirements 
in order to build a browser cordova project');
 process.exit(2);
 }
 
-console.log('Creating Browser project. Path: ' + 
path.relative(process.cwd(),project_path));
+// console.log('Creating Browser project. Path: ' + 
path.relative(process.cwd(),project_path));
--- End diff --

can ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #80: CB-9057: Replaced the Windows 10 Preview version ...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-windows/pull/80
  
Sorry Peter, 
You are about 2 years too late. What is the goal you are trying to achieve? 
 
It is difficult to use different UI frameworks for different platforms ... 
although it IS possible through plugins.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser issue #28: CB-12527

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-browser/pull/28
  
I'll be doing more work on this branch, I just wanted it to be out in the 
open.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #28: CB-12527

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-browser/pull/28

CB-12527



### Platforms affected
Browser

### What does this PR do?
Adds platformAPI, and removes need for polyfil

### What testing has been done on this change?
some

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-browser CB-12527

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-browser/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #28


commit f1b136d0958d2f85ea4c88f10ab7f757e5363e6c
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-04-07T06:51:12Z

don't exit and don't expect a done()

commit 44578d2f9399dd614b270ce98ce00ed7db4d137c
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-04-07T21:59:52Z

added some basic tests, and updated package with Jasmine@2.5.3

commit 3b4a52f69132eeb384c3320755112575aadbe875
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-04-13T05:57:40Z

large refactor, added PlatformApi, deleted icons

commit 6281ea5af1a2c99a0fdc12356b01c36abc33c720
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-04-13T06:34:46Z

hooking up run




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #541: Exit with exitCode:1 if a plugin could not be...

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-lib/pull/541

Exit with exitCode:1 if a plugin could not be restored from config.xml



### Platforms affected
lib

### What does this PR do?
see description

### What testing has been done on this change?
manual testing

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-lib CB-12649

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/541.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #541


commit 540bcb97311ecb133ef3e71ad05636fbbe87f2d3
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-04-12T00:17:29Z

Exit with exitCode:1 if a plugin could not be restored from config.xml




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #538: Emit platformAPI loading error, remove Gradle...

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-lib/pull/538

Emit platformAPI loading error, remove GradleBuilder and Browser crea…

…te console logs



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-lib EmitPlatformAPIError

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/538.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #538


commit 209b9b2da23c4d73cafac640fe8c3019c44cc60e
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-04-06T00:51:10Z

Emit platformAPI loading error, remove GradleBuilder and Browser create 
console logs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #230: CB-12617 Removed node 0.x

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-windows/pull/230

CB-12617 Removed node 0.x



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-windows CB-12617

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #230


commit 47f2ddb2c13f65dae75f5dc860b6c7ab18034876
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-03-30T09:23:19Z

CB-12617 Removed node 0.x from CI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #229: Allow build when using --bundle and multi...

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-windows/pull/229

Allow build when using --bundle and multiple architectures. This clos…

…es #175



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-windows MultiArch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #229


commit b992fb82818b6d204ad0ab6d46f1dd98af284b8d
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-03-30T08:06:35Z

Allow build when using --bundle and multiple architectures. This closes #175




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #688: Remove misleading reference to "publisherId" cause ...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/688
  
This pr was a replacement for #402 which I closed prematurely.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #688: Remove misleading reference to "publisherId"...

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-docs/pull/688

Remove misleading reference to "publisherId" cause it is ignored

The only way to override the `Publisher` value in the generated 
`AppxManifest.xml` is to provide a custom signing certificate. Merely setting 
the "publisherId" does not do anything. I've tried it a whole day. Only when I 
set a custom signing certificate my applications manifest looked like it 
should. And then setting "publisherId" to anything did not affect how the 
resulting manifest file looked.
So I propose to remove the value from the docs (and it should also be 
removed from the Cordova Windows plugin).



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pke/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #688


commit 62b148bb62714676aff0c02b7bd719a6746a7e24
Author: Philipp Kursawe <phil.kurs...@gmail.com>
Date:   2015-10-23T21:45:51Z

Remove misleading reference to "publisherId" cause it is ignored

The only way to override the `Publisher` value in the generated 
`AppxManifest.xml` is to provide a custom signing certificate. Merely setting 
the "publisherId" does not do anything. I've tried it a whole day. Only when I 
set a custom signing certificate my applications manifest looked like it 
should. And then setting "publisherId" to anything did not affect how the 
resulting manifest file looked.
So I propose to remove the value from the docs (and it should also be 
removed from the Cordova Windows plugin).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #402: Remove misleading reference to "publisherId" cause ...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/402
  
No, I closed it. Sorry, I didn't think it was still valid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #402: Remove misleading reference to "publisherId" cause ...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/402
  
One commit, a merge and a close ... unrelated.
Much like 25485819612937251bb521a9b68f73cae54065c3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #212: Instructions about signing and releasing a phonegap...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/212
  
closing this now very old pr.  Thanks for contributing, if this is still 
valid and needed, please rebase and resend.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #259: CB-7949 Added docs for cordova-local utility

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/259
  
closing, ... please resend/rebase if this is still valid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #402: Remove misleading reference to "publisherId" cause ...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/402
  
Is this still an issue?  Did you find a suitable solution @pke ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #443: Update index.md

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/443
  
Pretty sure this has already been said in Russian ...
Thanks for your contribution. The file you made the change in is actually a 
generated file that comes via a crowdin translation, please have a look at 
README.md for details about the process.
You can find the crowdin translations at https://crowdin.com/project/cordova

I am going to close this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #611: Lowercase Windows consistently through the docs

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/611
  
look good, merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #634: Update storage.md

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/634
  
Also, the file you modified is build generated from crowdin.
Plugin documentation lives with the plugins.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #669: Update spec.md

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/669
  
Thanks for your contribution @p-w 
The file you made the change in is actually a generated file that comes via 
a crowdin translation, please have a look at README.md for details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #664: Update images.md

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-docs/pull/664
  
closing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #687: Documented that some files are auto-gen from...

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-docs/pull/687

Documented that some files are auto-gen from other sources



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-docs DocExternalSrc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/687.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #687


commit dd12b2b0c300261fb70dcb299730102bf4839b9f
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-03-22T23:41:09Z

Documented that some files are auto-gen from other sources




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #11: CB-12543 (iOS) Set orientation ...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
If this is still valid, please rebase. Otherwise it will be closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-android/pull/369
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #13: [windows] Fix failing te...

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-plugin-screen-orientation/pull/13

[windows] Fix failing tests, added Promise if it is not defined 8.1



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull 
https://github.com/purplecabbage/cordova-plugin-screen-orientation 
WindowsFailingTests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13


commit 837c17b4797ed134c3a699be2c5be552d1f61ec6
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-03-11T01:59:50Z

[windows] Fix failing tests, added Promise if it is not defined 8.1




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #12: Follows spec w3 c

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-screen-orientation/pull/12#discussion_r105305926
  
--- Diff: www/screenorientation.js ---
@@ -18,83 +18,127 @@
  * under the License.
  *
  */
+var screenOrientation = {};
+if (!window.OrientationType) {
+window.OrientationType = {
+'portrait-primary': 0,
+'portrait-secondary': 180,
+'landscape-primary': 90,
+'landscape-secondary': -90
+};
+}
+if (!window.OrientationLockType) {
+window.OrientationLockType = {
+'portrait-primary': 1,
+'portrait-secondary': 2,
+'landscape-primary': 4,
+'landscape-secondary': 8,
+'portrait': 3, // either portrait-primary or portrait-secondary.
+'landscape': 12, // either landscape-primary or 
landscape-secondary.
+'any': 15 // All orientations are supported (unlocked orientation)
+};
+}
+var orientationMask = 1;
+screenOrientation.setOrientation = function(orientation) {
+orientationMask = window.OrientationLockType[orientation];
+cordova.exec(null, null, "CDVOrientation", "screenOrientation", 
[orientationMask, orientation]);
+};
 
+if (!screen.orientation) {
+screen.orientation = {};
+}
 
-var screenOrientation = {};
-if (!window.OrientationType) {
-window.OrientationType = {
-'0': 'portrait-primary',
-'180': 'portrait-secondary',
-'90': 'landscape-primary',
-'-90': 'landscape-secondary'
-};
-}
-if (!window.OrientationLockType) {
-window.OrientationLockType = {
-'portrait-primary': 1,
-'portrait-secondary': 2,
-'landscape-primary': 4,
-'landscape-secondary': 8,
-'portrait': 3, // either portrait-primary or 
portrait-secondary.
-'landscape': 12, // either landscape-primary or 
landscape-secondary.
-'any': 15 // All orientations are supported (unlocked 
orientation)
-};
-}
-var orientationMask = 1;
-screenOrientation.setOrientation = function(orientation) {
-orientationMask = window.OrientationLockType[orientation];
-cordova.exec(null, null, "CDVOrientation", "screenOrientation", 
[orientationMask, orientation]);
-};
+setOrientationProperties();
 
-function addScreenOrientationApi(screenObject) {
-if (screenObject.unlock || screenObject.lock) {
-screenObject.nativeLock = screenObject.lock;
-}
+function addScreenOrientationApi(screenObject) {
 
-screenObject.lock = function(orientation) {
-var promiseLock;
-var p = new Promise(function(resolve, reject) {
-if (screenObject.nativeLock != null) {
-promiseLock = screenObject.nativeLock(orientation);
-promiseLock.then(function success(res) {
+if (screenObject.unlock || screenObject.lock) {
+screenObject.nativeLock = screenObject.lock;
+}
+
+screenObject.lock = function(orientation) {
+var promiseLock;
+var p = new Promise(function(resolve, reject) {
+if (screenObject.nativeLock != null) {
+promiseLock = screenObject.nativeLock(orientation);
+promiseLock.then(function success(res) {
 resolve();
 }, function error(err) {
 screenObject.nativeLock = null;
 resolveOrientation(orientation, resolve, reject);
 });
-} else {
-resolveOrientation(orientation, resolve, reject);
-}
-})
-return p;
-}
+} else {
+resolveOrientation(orientation, resolve, reject);
+}
+})
+return p;
+}
+
+screenObject.unlock = function() {
+screenOrientation.setOrientation('any');
+};
 
-screenObject.unlock = function() {
-screenOrientation.setOrientation('any');
-};
+}
 
+function resolveOrientation(orientation, resolve, reject) {
+if (!OrientationLockType.hasOwnProperty(orientation)) {
+var err = new Error();
+err.name = "NotSupportedError";
+reject(err); //"cannot change orientation");
+} else {
+screenOrientation.setOrientation(orientation);
+resolve("Orientation set

[GitHub] cordova-plugin-screen-orientation pull request #12: Follows spec w3 c

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-screen-orientation/pull/12#discussion_r105282708
  
--- Diff: demo/config.xml ---
@@ -1,14 +1,31 @@
+/*
--- End diff --

This is suddenly NOT a valid XML file ...
See: 
https://github.com/apache/cordova-plugin-screen-orientation/blob/master/plugin.xml#L1
 for an example of how to add the license header to XML files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #11: CB-12543 (iOS) Set orien...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-screen-orientation/pull/11#discussion_r105280210
  
--- Diff: www/screenorientation.js ---
@@ -54,7 +54,7 @@
 screenObject.lock = function(orientation) {
 var promiseLock;
 var p = new Promise(function(resolve, reject) {
-if (screenObject.nativeLock != null) {
+if (screenObject.nativeLock !== null) {
--- End diff --

if you are gonna be strict, then you would have to test for undefined also


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #524: CB-12528 use fs instead of our own existsSync

[purplecabbage]

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-lib/pull/524

CB-12528 use fs instead of our own existsSync



### Platforms affected
Lib

### What does this PR do?
Removes unneeded API


### What testing has been done on this change?


### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-lib CB-12528

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/524.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #524


commit 62d491f3ff107ab03957ded15603667bf68e692f
Author: Jesse MacFadyen <purplecabb...@gmail.com>
Date:   2017-03-03T02:08:52Z

use fs instead of our own existsSync




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #267: CB: 11982 -Created new cordova config command

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-cli/pull/267
  
This PR will need to follow #270 and will need to be rebased, and have a 
conflict fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #267: CB: 11982 -Created new cordova config command

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/267#discussion_r103999595
  
--- Diff: src/cli.js ---
@@ -160,7 +183,7 @@ module.exports = function (inputArgs, cb) {
 };
 
 function getSubCommand(args, cmd) {
-if(cmd === 'platform' || cmd === 'platforms' || cmd === 'plugin' || 
cmd === 'plugins' || cmd === 'telemetry') {
+if(cmd === 'platform' || cmd === 'platforms' || cmd === 'plugin' || 
cmd === 'plugins' || cmd === 'telemetry' || cmd === 'config') {
--- End diff --

This is absolutely going to be a merge conflict with #270 

https://github.com/apache/cordova-cli/pull/270/files#diff-d9d9214113dea1c364abd4ba3c70be11R317



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #255: CLI Refactor

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-cli/pull/255
  
This now has conflicts, and even more when considered with other prs.  
Should I look to reimplement this cleanly?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #268: CB-11977 : removed support for node 0.x

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-cli/pull/268
  
Ship it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org