[GitHub] cordova-js issue #130: Fix CB-3785 - enable EventListener interface support
Github user rayshan commented on the issue: https://github.com/apache/cordova-js/pull/130 Yay! No worries. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js issue #136: handleEvent for addEventListener
Github user rayshan commented on the issue: https://github.com/apache/cordova-js/pull/136 Duplicate of https://github.com/apache/cordova-js/pull/130? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins issue #23: CB-10956: Update the GCDWebServer
Github user rayshan commented on the issue: https://github.com/apache/cordova-plugins/pull/23 We've tested this and it seems to work well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js issue #130: Fix CB-3785 - enable EventListener interface support
Github user rayshan commented on the issue: https://github.com/apache/cordova-js/pull/130 Rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...
Github user rayshan commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175756155 Hi @srgpqt, why is it no longer relevant? Seems like we still have to do `window.open` instead of `target="_blank"`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...
Github user rayshan commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175785833 Thanks. By "new window", do you mean links are opening in Safari as a new tab when you use `target="_blank"`? FYI We've been using https://github.com/apache/cordova-plugin-inappbrowser and `window.open` to open links in the in-app-browser. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...
Github user rayshan commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175819620 Thanks for the confirmation! We'll try this as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: Fix CB-3785 - enable EventListener interf...
GitHub user rayshan opened a pull request: https://github.com/apache/cordova-js/pull/130 Fix CB-3785 - enable EventListener interface support This patch enables support for `EventListener` interface for `Channel.prototype.subscribe` / `unsubscribe`, based on the patch by @motorro in https://issues.apache.org/jira/browse/CB-3785. This bug prevents other frameworks that make heavy use of the EventListener interface to work with Cordova, such as [Montage](https://github.com/montagejs/montage) and its `EventManager`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rayshan/cordova-js master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/130.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #130 commit 0cca16c84e6b95e29abbe68803d54b3f12ee9316 Author: Ray Shan <r...@shan.io> Date: 2015-12-19T00:32:08Z Fix CB-3785 Enable support of EventListener interface for Channel.prototype.subscribe / unsubscribe --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9462 iOS 3.9.0 breaks npm link module...
Github user rayshan commented on the pull request: https://github.com/apache/cordova-ios/pull/153#issuecomment-136541007 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
