[GitHub] cordova-plugin-inappbrowser issue #210: CB-12367: Modernize styling of iOS I...

2017-09-13 Thread timbru31
Github user timbru31 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/210
  
@artyom-dorokhov you might want to check out 
https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-08-24 Thread timbru31
Github user timbru31 commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15
  
Sorry for the revive/bump but has there been any dialogue recently to merge 
the Ionic changes back into the upstream Apache project? They are drifting more 
and more apart...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser pull request #223: CB-12941: update typings

2017-06-21 Thread timbru31
GitHub user timbru31 opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/223

CB-12941: update typings

### Platforms affected
n/a - development via TypeScript

### What does this PR do?
Updates the typings to match the latest published version on 
DefinitelyTyped.  
See https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17192 and 
https://stackoverflow.com/q/42095516/1902598

### What testing has been done on this change?
Project compiles again ;)

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- n/a: Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/timbru31/cordova-plugin-inappbrowser 
feature/update-typings

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #223


commit 6b36f485f4853f8d448d7de4fed9571d1a45241f
Author: Tim Brust <tim.br...@sinnerschrader.com>
Date:   2017-06-21T09:52:19Z

CB-12941: update typings




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org