[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/337 The Android System WebView (in Android 5.0+ anyhow) also fires `visibilitychange` when the app is focused/backgrounded, which might be an alternative (and is, arguably, the spec-compliant event to use for this sort of thing). Unfortunately the CrossWalk webview does not fire `visibilitychange`, nor do the older WebViews on Android 4.x, so it's not a perfect solution --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/337 https://issues.apache.org/jira/browse/CB-12601 is the bug for this new issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/337 It's obviously a bug, and we should probably make sure the pause event fires before we pause the timers somehow, since it's clear there's a threading issue. That said, broken apps in the store are better than no apps in the store. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView
Github user vinzscam commented on the issue: https://github.com/apache/cordova-android/pull/337 It makes sense :) I just want to point out that it is not just a broken API: it could affects the functionality of existing apps (in my case I was using it to connect/disconnect a persistent connection to a server). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/337 Sorry, but this is more important than the pause event, this stays. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView
Github user vinzscam commented on the issue: https://github.com/apache/cordova-android/pull/337 The #337 has broken the firing of `pause` event. Now the `pause` event fires when the native platform pulls the application out from the background (just before firing the `resume` event). Maybe is better to rollback the changes keeping consistent to the [documentation](https://cordova.apache.org/docs/en/latest/cordova/events/events.html#pause). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/337 BTW: Don't add a commit that says "This closes #337" on this. I want to be certain that this actually closes it and sign off on the commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/337 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/337?src=pr) is 35.15% (diff: 100%) > Merging [#337](https://codecov.io/gh/apache/cordova-android/pull/337?src=pr) into [master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) will not change coverage ```diff @@ master #337 diff @@ == Files12 12 Lines 1007 1007 Methods 198198 Messages 0 0 Branches168168 == Hits354354 Misses 653653 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [30325e4...9357737](https://codecov.io/gh/apache/cordova-android/compare/30325e4f32564cc8806bb1e100dbe4be8a0db449...9357737f3c6f7396af947c5c4529cba7022882b0?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
