[GitHub] cordova-android pull request: CB-10897 Refactor URI Parsing for Wh...

[infil00p]

Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/283#issuecomment-204006738
  
We should be able to unit test the methods on the Whitelist object itself 
without plugins.  I also don't see the commit where the test is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10897 Refactor URI Parsing for Wh...

[ktop]

Github user ktop commented on the pull request:

https://github.com/apache/cordova-android/pull/283#issuecomment-201509250
  
@infil00p can you review again? see my previous comment. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10897 Refactor URI Parsing for Wh...

[infil00p]

Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/283#issuecomment-200517498
  
Can we have tests in the test project for this?  It looks fine, but since 
it's new functionality in cordova-android, adding a test would be good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10897 Refactor URI Parsing for Wh...

[ktop]

GitHub user ktop opened a pull request:

https://github.com/apache/cordova-android/pull/283

CB-10897 Refactor URI Parsing for Whitelist

Fix for CB-10897. 

I moved out the code that parses the 'origin' from the whitelist to a 
separate function so that it can also be used to parse the URLs that request 
access instead of using Android's Uri class parse function. Android's Uri parse 
function does not parse 'host' the same way that Cordova parses the host in 
origin for whitelist, so host ends up being null and the comparison fails. 
Using the same parsing methods is the way to go to give accurate comparisons of 
URLs to those in the whitelist. 

Also, I can have specific non http/https URLs in my whitelist now. 
Something like this works now without the wildcard:


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ktop/cordova-android CB-10897

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #283


commit 26662acada6f44a83c11c1e13faa8fea3a959720
Author: Karen Tran 
Date:   2016-03-18T18:45:57Z

CB-10897 Refactor URI Parsing for Whitelist




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org