[GitHub] cordova-android pull request: CB-11138 Reuse PluginManager from co...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/301


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-11138 Reuse PluginManager from co...

[jasongin]

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-android/pull/301#issuecomment-215561101
  
:+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-11138 Reuse PluginManager from co...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-android/pull/301#issuecomment-215537523
  
Sure, you can skip them safely. This is because we ship them as 'bundled' 
dependencies, since we don't run `npm install` after downloading the platform.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-11138 Reuse PluginManager from co...

[jasongin]

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-android/pull/301#issuecomment-215533601
  
Can I ignore all the changes under node_modules? I don't understand why 
that is checked in to source control...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-11138 Reuse PluginManager from co...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-android/pull/301#issuecomment-215523214
  
@jasongin Can you please help review.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-11138 Reuse PluginManager from co...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-android/pull/301

CB-11138 Reuse PluginManager from common to add/rm plugins

A change to use `PluginManager` class to manage plugin 
installation/uninstallation instead of custom logic

JIRA: [CB-11138](https://issues.apache.org/jira/browse/CB-11138)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android CB-11138

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/301.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #301


commit beb9875246ca3e1eb2218856df2a606e8b353ec0
Author: Vladimir Kotikov 
Date:   2016-04-22T12:56:02Z

CB-11138 Bump cordova-common to 1.2.0

commit b40b4fccb3259a4f4b633bf6a1785409fad26b4d
Author: Vladimir Kotikov 
Date:   2016-04-22T13:03:02Z

CB-11138 Reuse PluginManager from common to add/rm plugins




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org