[GitHub] cordova-android pull request: CB-11163 Android Builds are failing ...

2016-04-28 Thread daserge
Github user daserge commented on the pull request:

https://github.com/apache/cordova-android/pull/302#issuecomment-215487630
  
Reverted 
https://github.com/apache/cordova-android/commit/abcaee24f9bd0e680f8d06ced5e0d363d63cffb7
 to unblock the CI.
Reopened the [CB-11133](https://issues.apache.org/jira/browse/CB-11133) - 
the proper fix is to be investigated.

The issue was that the main process in emulator.js was waiting for adb 
emulator child process end because of our subscription to stdout (in which the 
ERROR message was being caught) and was never returned as emulator is running 
in the background.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: CB-11163 Android Builds are failing ...

2016-04-28 Thread nikhilkh
Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-android/pull/302#issuecomment-215486540
  
Can you explain what was the issue here and why this fixes it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: CB-11163 Android Builds are failing ...

2016-04-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/302


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: CB-11163 Android Builds are failing ...

2016-04-28 Thread codecov-io
Github user codecov-io commented on the pull request:

https://github.com/apache/cordova-android/pull/302#issuecomment-215448214
  
## [Current coverage][cc-pull] is **100%**
> Merging [#302][cc-pull] into [master][cc-base-branch] will not change 
coverage

```diff
@@master  #302   diff @@

  Files   1111  
  Lines 1707  1690-17   
  Methods207   204 -3   
  Messages 0 0  
  Branches   169   167 -2   

- Hits  1707  1690-17   
  Misses   0 0  
  Partials 0 0  
```



> Powered by [Codecov](https://codecov.io?src=pr). Last updated by b2b37c2
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-android/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-android/pull/302?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: CB-11163 Android Builds are failing ...

2016-04-28 Thread daserge
GitHub user daserge opened a pull request:

https://github.com/apache/cordova-android/pull/302

CB-11163 Android Builds are failing in CI

CB-11133 Handle android emulator start failure (reverted from commit 
abcaee24f9bd0e680f8d06ced5e0d363d63cffb7)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android CB-11163

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/302.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #302


commit 914e2fa35fa111a45ce6de7937e62ce97e29dcc8
Author: daserge 
Date:   2016-04-28T14:25:39Z

CB-11163 Android Builds are failing in CI

CB-11133 Handle android emulator start failure (reverted from commit 
abcaee24f9bd0e680f8d06ced5e0d363d63cffb7)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org