[GitHub] cordova-android pull request #386: CB-12895 : added eslint and removed jshin...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/386#discussion_r124902965
  
--- Diff: bin/templates/cordova/Api.js ---
@@ -112,16 +110,13 @@ Api.createPlatform = function (destination, config, 
options, events) {
 events = setupEvents(events);
 var result;
 try {
-result = require('../../lib/create')
-.create(destination, config, options, events)
-.then(function (destination) {
+result = require('../../lib/create').create(destination, config, 
options, events).then(function (destination) {
--- End diff --

This is an unfortunate workaround for eslint-ing.  I would much prefer this 
be broken up, ala ...

var libCreate = require('../../lib/create');
var result = libCreate.create(destination, config, options, events);
result.then(function (destination) {
// ...
});
...
return result;



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #386: CB-12895 : added eslint and removed jshin...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/386


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #386: CB-12895 : added eslint and removed jshin...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-android/pull/386

CB-12895 : added eslint and removed jshint / reformatted with eslint 



### Platforms affected


### What does this PR do?

Added eslint and removed jshint / reformatted with eslint.

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-android CB-12895

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #386


commit 8e4e071e5d6f3427feaf6e216db9757c42c0f0ea
Author: Audrey So 
Date:   2017-06-09T18:18:57Z

CB-12895 : added eslint and removed jshint

commit 4e19a0ce08a2a117990ba20d7ef1fbb0f6ebcd5b
Author: Audrey So 
Date:   2017-06-13T18:42:20Z

CB-12895 : fixed eslint errors




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org