[GitHub] cordova-android pull request #394: CB-13006: replace create end-to-end tests...

[filmaj]

Github user filmaj closed the pull request at:

https://github.com/apache/cordova-android/pull/394


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #394: CB-13006: replace create end-to-end tests...

[filmaj]

GitHub user filmaj opened a pull request:

https://github.com/apache/cordova-android/pull/394

CB-13006: replace create end-to-end tests with unit tests

There were create end-to-end tests that validated use of unicode, spaces 
and ascii characters in project names and destination paths. These tests were 
HEAVY - they would shell out to create _and_ compile each one, and there were 6 
of these tests. Additionally, these tests would regularly time out on Travis.

Instead, this PR replaces those tests with lighter weight unit tests 
exercising the same logic (hopefully).

*NOTE*: by removing the create end-to-end tests, we now no longer test that 
created projects can compile using the Android SDK. We may want to consider 
adding a basic smoke-test for this back into the end-to-end tests.

Please review / discuss / FYI @infil00p, @stevengill, @dpogue, @alsorokin, 
@matrosov-nikita, @jcesarmobile 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/filmaj/cordova-android CB-13006

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/394.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #394


commit 41c24a8ae1f3415d3fc0bdc6f6fd00fa7075a15a
Author: filmaj 
Date:   2017-07-11T17:25:12Z

CB-13006: removed create end-to-end tests, and instead added more unit test 
coverage. tweaked code coverage invocation so that we get coverage details on 
the create.js module. slight changes to the create.js module so that it is 
slightly easier to test.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org