[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56472196
  
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -119,6 +120,45 @@ different screen resolutions.
 - [App icon and image size 
guidelines](https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html)
 
 ##Windows
+
+For Windows the recommended approach to define app icons is to use 
`target` attribute.
+
+```xml
+
+
+
+
+
+
+
+
+
+
+```
+
+where `source` is the path to the icon which needs to be added.
+
+Please note that Windows platform handles MRT icons automatically, so if 
you specify `src="res/windows/storelogo.png"` the following files will be 
copied into app's `images` folder: `res/windows/storelogo.scale-100.png`, 
`res/windows/storelogo.scale-200.png`, etc.
+
+The `target` attribute specifies the base name for resultant icons. For 
every icon file destination filename is calculated as `target + '.' + 
MRT_qualifiers + extension(src)`. For the icons to display properly in 
resultant app every `target` value should be the one of icon filenames, defined 
in application's `.appxmanifest` file.
+
+Summarizing the above, using `target` attribute it is possible to:
+
+  * define a group of icons for different device scale factors using 
single `` element, for example:
+```xml
+
--- End diff --

It should not, according to the paragraph before:
> The `target` attribute specifies the _base name_ for resultant icons.

This is another copy/paste typo


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-docs/pull/558#issuecomment-197379532
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/558#issuecomment-197417802
  
One last small comment. LGTM otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-docs/pull/558#issuecomment-197407826
  
Sorry, I wasn't aware of the current process. Reapplied changes to `dev` 
version


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/558


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/558#issuecomment-197387971
  
I noticed you are modifying 6.x version of the document - it's not a good 
idea to do so as dev gets copied to 6.x periodically and these edits will be 
lost unless both are updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56368991
  
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -119,6 +120,45 @@ different screen resolutions.
 - [App icon and image size 
guidelines](https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html)
 
 ##Windows
+
+For Windows the recommended approach to define app icons is to use 
`target` attribute.
+
+```xml
+
+
+
+
+
+
+
+
+
+
+```
+
+where `source` is the path to the icon which needs to be added.
+
+Please note that Windows platform handles MRT icons automatically, so if 
you specify `src="res/windows/storelogo.png"` the following files will be 
copied into app's `images` folder: `res/windows/storelogo.scale-100.png`, 
`res/windows/storelogo.scale-200.png`, etc.
+
+The `target` attribute specifies the base name for resultant icons. For 
every icon file destination filename is calculated as `target + '.' + 
MRT_qualifiers + extension(src)`. For the icons to display properly in 
resultant app every `target` value should be the one of icon filenames, defined 
in application's `.appxmanifest` file.
+
+Summarizing the above, using `target` attribute it is possible to:
+
+  * define a group of icons for different device scale factors using 
single `` element, for example:
+```xml
+
--- End diff --

Should `target` have extension or not?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56233993
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -119,6 +120,39 @@ different screen resolutions.
 - [App icon and image size 
guidelines](https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html)
 
 ##Windows
+
+For Windows the recommended approach to define app icons is to use 
`target` attribute.
+
+```xml
+
+
+
+
--- End diff --

Perhaps we should clarify that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56227358
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -119,6 +120,39 @@ different screen resolutions.
 - [App icon and image size 
guidelines](https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html)
 
 ##Windows
+
+For Windows the recommended approach to define app icons is to use 
`target` attribute.
+
+```xml
+
+
+
+
--- End diff --

The `src` filename could be any, but the `target` should be one of the icon 
filenames, used in appxmanifest file. Historically in default cordova-windows 
template these names are: "StoreLogo", "Square30x30Logo", "Square44x44Logo", 
"Square70x70Logo", etc...

When copying icons, the resultant filename is calculated as `target + '.' + 
MRT_qualifiers + extension(src)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56224058
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -135,6 +136,22 @@ different screen resolutions.
 
 
 ```
+
--- End diff --

Yes, they are get copied during 'prepare' phase. The resultant filename is 
calculated based on `width` and `height` attributes using [hardcoded 
map](https://github.com/apache/cordova-windows/pull/159/files#diff-32bff2189ca335a5581636fff314a504R315).
 The source filename does not matter in this case and is used only to indicate 
where to get source images.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56203793
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -119,6 +120,39 @@ different screen resolutions.
 - [App icon and image size 
guidelines](https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html)
 
 ##Windows
+
+For Windows the recommended approach to define app icons is to use 
`target` attribute.
+
+```xml
+
+
+
+
--- End diff --

I'm confused - does the `target` name have to be this? How does this 
eventually get represented in the manifest - does the target/src filename not 
matter?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56203099
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -135,6 +136,22 @@ different screen resolutions.
 
 
 ```
+
--- End diff --

Does `cordova-windows` actually copy these files over?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-docs/pull/558#issuecomment-196796748
  
@nikhilkh, @daserge, updated. please take a look once more


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56153499
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -41,6 +41,7 @@ platform  | *Optional*  Target platform
 width | *Optional*  Icon width in pixels
 height| *Optional*  Icon height in pixels
 density   | *Optional*  Specified icon density (Android Specific)
+target| *Optional*  Destination filename for the image file 
and all its' MRT companions (Windows Specific)
--- End diff --

Thanks for advice, i've made similar change for `density` attribute as well 
(`==Android==`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56150831
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -135,6 +136,22 @@ different screen resolutions.
 
 
 ```
+
--- End diff --

Looks like these sizes are still [supported for Windows 8.1 
apps](https://msdn.microsoft.com/en-us/library/windows/apps/xaml/hh781198.aspx#details_on_sizing__padding__scaling__and_transparency_for_windows_phone_store_apps)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56042466
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -135,6 +136,22 @@ different screen resolutions.
 
 
 ```
+
+For Windows it's also possible to specify icons destination using `target` 
attribute. This approach has the following advantages:
+
+  * it is possible to define group of icons for different device scale 
factors using one `` element, for example:
+```xml
+
+```
+  which is equal to the following lines:
--- End diff --

equal => equivalent


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56042785
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -41,6 +41,7 @@ platform  | *Optional*  Target platform
 width | *Optional*  Icon width in pixels
 height| *Optional*  Icon height in pixels
 density   | *Optional*  Specified icon density (Android Specific)
+target| *Optional*  Destination filename for the image file 
and all its' MRT companions (Windows Specific)
--- End diff --

For platform specific, content - we use ==Windows== as it shows up as 
a  element and is custom formatted on the website. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56042624
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -135,6 +136,22 @@ different screen resolutions.
 
 
 ```
+
+For Windows it's also possible to specify icons destination using `target` 
attribute. This approach has the following advantages:
--- End diff --

Because of these advantages should this be the recommended way - and hence, 
be the first example?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56042402
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -135,6 +136,22 @@ different screen resolutions.
 
 
 ```
+
--- End diff --

I believe these need to be removed:   
```xml
 
 
 
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[daserge]

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/558#discussion_r56040443
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -135,6 +136,22 @@ different screen resolutions.
 
 
 ```
+
+For Windows it's also possible to specify icons destination using `target` 
attribute. This approach has the following advantages:
+
+  * it is possible to define group of icons for different device scale 
factors using one `` element, for example:
+```xml
+
+```
+  which is equal to the following lines:
+```xml
+
+
+
--- End diff --

This looks like a copy-paste typo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-docs/pull/558

CB-10178 Added `target` attribute docs to windows icons reference

JIRA [CB-10178](https://issues.apache.org/jira/browse/CB-10178)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-10178

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #558


commit fb55bca669986f75cfd819f74af033687fd57ec3
Author: Vladimir Kotikov 
Date:   2016-03-14T15:07:29Z

CB-10178 Added `target` attribute docs to windows icons reference




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org